From nobody Thu Oct 2 10:39:57 2025 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011045.outbound.protection.outlook.com [40.93.194.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F16DF302774; Wed, 17 Sep 2025 13:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116184; cv=fail; b=Jt0edQJr2c0DpezngZKym6haWpTE7H4I0kJbyw5qtFJbg0qJajMQyjUto/JLR+mCB1wJwjYVHdefZ3pp4mM8r9YXdmqkjzR8lJHVGBS6IGvn4831wBiaJoq1e/ZYWoz84r/fSk3ue9CM9/mcsraBoi31HIVLBo2pUYenhWStAIU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116184; c=relaxed/simple; bh=OoRmKRCwcgmtbywoBZnH9cZQ/8T7Q8Ne4jga0I1DriA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IgI/SuxFcjeyS+70KyeVfjWuNA0i6bDaLcjPjFukO77ROcM6td2fBJw5xGKkiCx1wHMostHYFV6/CT34IIA4U33DfXfKwWnU9IOwI9MildElTTiuTOfpvNjTVq0npNOmop9u6sCKpb3yc0ilpnu4HjUiVGYyqS+W656y0LYqSFM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=OaNDs+79; arc=fail smtp.client-ip=40.93.194.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="OaNDs+79" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SSiZbs4unLf1zDgqXJFwYR7GoLpTbiOeeL3pB3BKbukpN9uXPVG0qCwlxtHuHCe+emh6/lHgbOGHYGoQ32rJAx9MfLHX+dYeco33NlfC0XZgg+11o5ZGUJv7cbABS325fAo99C8yP/FT9B7pvbOwABDNbaCPD67kN6XwcqFpyC6ZbAk1qtmY+EaigED9EJMyguxJL9qAeNM35f921mUP4JUrAYQIT9QXDnGnBJya6dGYamlj1iYZ8DCPCfPU199yi9kOVG/ji98aCZ11Ssc3ge1FS0vd9r+NhvccaaAGZkgn2VAMamJQRZL4XElJOArk4QjAyXgN3iIYBor7c4vqNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJ0xBOgVnFj72ohvoBp+/Ol/MIKB06H+59m2QYcv2Uo=; b=ddWbNkz67j/5acqtboU499tnlUwnn/IRb5b0Z0KFB1H/0KWMnxbmlKqa8NVYBhPoRt3bHEE0oDPgdwpnTsIUD2cAlLtCcu8YDyYCiDtQ7wLAIn6cR6PiIrfp+PS5lKR00oMfnbwoaMMoRcR3805YUFis6cPI5GGdc2ncWxpbKlAiGKbcYm/zYH7JIBN6fHjCmQRQ5aWoOot278cnZrQ0npPKVl4AmA3bLQ1411eBaSbeQXwNa/GJO37SzrYH2KecHLJK1+K5GXXw+fyaof1sEvQKh11aWignnEWy7ZDbg+sOzjwOopggBHDEZ8Q6Y86CvcVGXVQiipq9DNRWZOT4cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJ0xBOgVnFj72ohvoBp+/Ol/MIKB06H+59m2QYcv2Uo=; b=OaNDs+793MxOVkXp0anQ7rHhrrqUGTa//m8PtOEufnmXYkWIU8VJfgedqhjnyy8ysYy3Mkbx2O4CrAmZ7cxU6Vfj3BAKXENUa6uQGxQgDE1vBHaSLsqIy0M2SNw6O5DVrEf6cjwC/1Mb+tezwbQO2jhFO9SxUsYErgejil9v7Es= Received: from MW4PR04CA0071.namprd04.prod.outlook.com (2603:10b6:303:6b::16) by PH7PR12MB5879.namprd12.prod.outlook.com (2603:10b6:510:1d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.23; Wed, 17 Sep 2025 13:36:18 +0000 Received: from MWH0EPF000A6730.namprd04.prod.outlook.com (2603:10b6:303:6b:cafe::20) by MW4PR04CA0071.outlook.office365.com (2603:10b6:303:6b::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.22 via Frontend Transport; Wed, 17 Sep 2025 13:36:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by MWH0EPF000A6730.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Wed, 17 Sep 2025 13:36:17 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 17 Sep 2025 06:36:15 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 17 Sep 2025 06:36:15 -0700 Received: from xhdsuragupt40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 17 Sep 2025 06:36:13 -0700 From: Suraj Gupta To: , , CC: , , Subject: [PATCH 1/3] dmaengine: xilinx_dma: Fix channel idle state management in interrupt handler Date: Wed, 17 Sep 2025 19:06:07 +0530 Message-ID: <20250917133609.231316-2-suraj.gupta2@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250917133609.231316-1-suraj.gupta2@amd.com> References: <20250917133609.231316-1-suraj.gupta2@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6730:EE_|PH7PR12MB5879:EE_ X-MS-Office365-Filtering-Correlation-Id: d5099fd9-4b52-4e0c-f32c-08ddf5ef2e57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wAseg5BB8Jggr085yCIwC9IBu7LW2QrkApJQKLdyPa6hy/PLPhBzi/KraehU?= =?us-ascii?Q?VpjqzXpGeXE6JRG+ZDRj5jZetq+eoIS2N0gh51OYZHjTU7rmwaHOWKF7qhq/?= =?us-ascii?Q?1Rv2v7FWvK0Bx2CDy8+00QvyrWRyfrpbja/Eu8v+SY7eU83IVbyEGtKTjh/J?= =?us-ascii?Q?n1fC7JSLhAsssUZqygPLE9u3Td0Uk8W7USe0dwKwk2KBLYnOpit8zBRvCJQw?= =?us-ascii?Q?TiRgND4pkVUoc+lL3l18InPBN/V/OUTjXbf8ZhW6/IdNnpMlhCLbZsPFMPla?= =?us-ascii?Q?g60ECyANOaDDPqucPSOCEFEGp+/iWQKhpnm7WpMgK47zl8w/gP+7GmU8bM+i?= =?us-ascii?Q?N0OpsSgpDLMho6kZ9YRdyRo4ucv81dKy+sHcw6CWtCZlNURtMz7uxC4QjIQ0?= =?us-ascii?Q?/Tiwf+6fICwNaZG4PgcVRJyGfUQI/zjRYTxoGBiZ5pWU3MZwoocnWCSPvlsI?= =?us-ascii?Q?qnGWdpQ7yOrz1Okqjic3ufr/xKs093/3ecn9wemCwWnjx7BntUVSxLEbK6N2?= =?us-ascii?Q?WNWvPIbqXclezN59Ll2O6axLg5CaS6Qz69l2Rjpqed4fak46s7a8Fs1/EUlX?= =?us-ascii?Q?y4OSD8rcjsenbk5m79p4S6hez6BPJpiCls9px6qTXSfTCD2JnpNSRT+G0c6d?= =?us-ascii?Q?J6zIRmlnjto/rirkshU9qaHqyR9dCcduvwPLdBP9iG4pp4ImxJHxY3T53DHE?= =?us-ascii?Q?8ufvcnc3f9TFDFxiRCg7nQLEDR2BcpNsH9sajhVMNuS6cMtvzZCoMrCHleTq?= =?us-ascii?Q?hRqc5PO7mFR6WQ5GtlxIAMeDhSCJioTQcbjeLOgKKL5xRdHBZhVx0bld3DNr?= =?us-ascii?Q?FgNpBZpP1Y8u1fJVPW2KPpUlXio9Dg4DH6MQ7pYncj8bVP9/I+fYyBJSHnnE?= =?us-ascii?Q?uIevHh/D/5AX/tKu7013XVcc3g9cHX7Z7iVUziLZirUzG/sK8tiF5cKyU6Vf?= =?us-ascii?Q?SHRciQEHg6BTYqTxIN652iao3vw4s4i+DVP5dqnfVihoRgZhrVVg4rLZa0zw?= =?us-ascii?Q?tIQBrpVpuMFt3UOam2L2aVpACSkO4ZcDeQgmsQkR8xhMw3JTwLtkFO+jZeDl?= =?us-ascii?Q?zIZlT3IgvgSsR3KI1Gppe4hq6+tRwrMhji4SMT6baA2rN2ZweokWtmmnkbaZ?= =?us-ascii?Q?DIQkOY35hcWPCqaKtydI5kuL2djh0eluwSL34CdU2Xz99ii7huwc0xxbncwz?= =?us-ascii?Q?4xPhNneT9uKXEPtwS2UoTmLFEALeyoaKDiPD7Io8Ds1dS40nEjDm7YG64YFS?= =?us-ascii?Q?3MCWnPoHEsQ4xhJxgXDUy3om7v4Qfiae6yCRA7r/MBnoITVJhPj5BUTpUQnG?= =?us-ascii?Q?qfVhgv0GworX527/nWRwI725gNtW13Ru+W4DgSHXmFPrtWy8FP0B2o4++7ML?= =?us-ascii?Q?LjnUytjY8qW7rUSDQZQ7QW/FuKQt4F9BgMJ4/1G/KReRIQeV3FvEXpwPt69i?= =?us-ascii?Q?pGsv9uRxO23F7+BHKryzXE1uPY/Qckp2u+pukhtm732Eek6Gfj1sOxsPZ2Tk?= =?us-ascii?Q?sljSIRFN6iP44bLzRbuNpZmNM8SFtUuhVycb?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 13:36:17.8645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d5099fd9-4b52-4e0c-f32c-08ddf5ef2e57 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6730.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5879 Content-Type: text/plain; charset="utf-8" Only mark the channel as idle and start new transfers when the active list is actually empty, ensuring proper channel state management and avoiding spurious transfer attempts. Signed-off-by: Suraj Gupta Fixes: c0bba3a99f07 ("dmaengine: vdma: Add Support for Xilinx AXI Direct Me= mory Access Engine") Tested-by: Folker Schwesinger --- drivers/dma/xilinx/xilinx_dma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index a34d8f0ceed8..9f416eae33d0 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1914,8 +1914,10 @@ static irqreturn_t xilinx_dma_irq_handler(int irq, v= oid *data) XILINX_DMA_DMASR_DLY_CNT_IRQ)) { spin_lock(&chan->lock); xilinx_dma_complete_descriptor(chan); - chan->idle =3D true; - chan->start_transfer(chan); + if (list_empty(&chan->active_list)) { + chan->idle =3D true; + chan->start_transfer(chan); + } spin_unlock(&chan->lock); } =20 --=20 2.25.1 From nobody Thu Oct 2 10:39:57 2025 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012033.outbound.protection.outlook.com [40.107.209.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0C52222B6; Wed, 17 Sep 2025 13:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116183; cv=fail; b=bZ5C0YCTdDixAZm1r4jAhufFJZvXKX2uggd63/2ZhCdib5LVINFbavGosgTqCyC0Xab+7fAfaIEl/eFhELBAM8cCz7B7iTlOgqbYsqyKGIAToqZLejuak09o5x24XU65eaizref+cpkJF2JCQdKy1cmOfaRlCufBvQxSBn6Tm/k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116183; c=relaxed/simple; bh=kC603L80Tb+GXnPR4qlJSbMMqCGGaUYhdAIM2IAhZlg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o0SOwHhiXJSavCwOoZyzMXzfDbqULh61IPRjMQJxyvM7Rvik1l3g0nZXxHsgkSIYEn8ttFIYh0dNvfjycQqu2eWpDzOL4QB3PMNzYg4WvNfht2fNrcRNQWqb6xM2h06iqfqAX1mS1nhzkR8PG2SmjJbdM3en8DXxEYCXENAxt/Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iZfSN1af; arc=fail smtp.client-ip=40.107.209.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iZfSN1af" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vj4qxsSC+9gPK3rv+z1DqdDFe1bk6hXW9IYiZ86NFf2OJN54c1le29NDAsCwkOsnWQQctK1ugWVy25r9+xLkvvwkiC6ebsoLkCNPv8q2Gi/FbL8FZJ6rY8fm+nlK+NMlqluL8ZY1MVtoNKLevoinMJVlIpONt9xjYsUiOZrKS6zceoAo5QmUaqmDEU19lBOrDzTYmbrrC1tONPmJhxU1PCJf+siWMO0+xMnDk1FBtcnuZRdEUwzekIHQj2pUbFXCb/Ke+goRD2+nbj52MDpyLoR8roMpkPECuVyPDnWmV3jDrDRFJ8Smqd/gKl6oUZNRRVOjeFhUY8t3mWJ0HszObA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=07fjk4okce04G2lK1vLBZK4H5aSeTLpYRU17MwIojbM=; b=MNt2ho+f3xWdwaDSam/K5EZkyFpxKGj4IqlVcOe2hHRGqK7VWVhczwcxo8QIhVexY8eEXb38b4TtnFnw0LorkV7Nz5jXgfuSyDZGpzNfpWxBzIcignSOUCh8DLEY2J8vMVC6nK3wAtniNfpyTQp/n1JI1hK7Ok18dW0nYFvng9sQRjLQwvtiNeEyNqMkUYK6YVYpBypj2IS8aOv+whzSgvEz5to4qim6CVagAY6TEhnCMM290p6k0ewbbdLsSaS6C4f6O7A3GKwxm8Tl0fRg9JRG79/qiTD5uNNaSTfWkiRDC/XxPK49v4CEI3UOq+IhnXCMFSw19ZrhU/xawzXTOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=07fjk4okce04G2lK1vLBZK4H5aSeTLpYRU17MwIojbM=; b=iZfSN1afahXVyNgIsAZGwpwszjtmNWyEzFKWulw0lLSLCz7lBX7mGeR8+TBDu77g+gn4W0cZPDoVLYU3AVkaNhuZHv22j1JxsV7k/HRiYw+krv7TIW3DazkYt7fI/EQLp/nsgrygrkkr2mfRlU/V81oNy0zOWtL9j+nnhSfQKxw= Received: from BN9PR03CA0508.namprd03.prod.outlook.com (2603:10b6:408:130::33) by DM4PR12MB7669.namprd12.prod.outlook.com (2603:10b6:8:106::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.13; Wed, 17 Sep 2025 13:36:19 +0000 Received: from MN1PEPF0000F0E3.namprd04.prod.outlook.com (2603:10b6:408:130:cafe::c6) by BN9PR03CA0508.outlook.office365.com (2603:10b6:408:130::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.22 via Frontend Transport; Wed, 17 Sep 2025 13:36:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MN1PEPF0000F0E3.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Wed, 17 Sep 2025 13:36:19 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Wed, 17 Sep 2025 06:36:18 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 17 Sep 2025 08:36:18 -0500 Received: from xhdsuragupt40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 17 Sep 2025 06:36:15 -0700 From: Suraj Gupta To: , , CC: , , Subject: [PATCH 2/3] dmaengine: xilinx_dma: Enable transfer chaining by removing idle restriction Date: Wed, 17 Sep 2025 19:06:08 +0530 Message-ID: <20250917133609.231316-3-suraj.gupta2@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250917133609.231316-1-suraj.gupta2@amd.com> References: <20250917133609.231316-1-suraj.gupta2@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E3:EE_|DM4PR12MB7669:EE_ X-MS-Office365-Filtering-Correlation-Id: f547864f-0dc7-43d2-4461-08ddf5ef2f2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hM9Q9rmCysEprjZqXlFPRu0r4QpztWnvlriy3XYLGVjBk3a7PzinL1P9ZtVY?= =?us-ascii?Q?lBW0zizySKShqagN3Y1RIbYvbjg3WfMRvGnARKV8WCLteigN8DS1DevyFz3/?= =?us-ascii?Q?f8T7QlLQxlYvgakHtPddFSkEHVwCHcURTZmItP0HiuNw3nzmtJHdKVkMiuDA?= =?us-ascii?Q?lv4rCLu+M/XgdxzXbk+5KWR0UvUDbzY++5jrbJf0B3dT0Fh5iP8yVaDN2OFh?= =?us-ascii?Q?0Sor9ajASUzY8+RESvDZpEH3O+Uo5Q9p/9dk43zZQZXhoz5gzAufWZjBjthM?= =?us-ascii?Q?FyPMuwi8aIH5vxwKAfb0JTTCUNdxZvnKnIzaB0DHAFaz3bsTCqE421ROUNkN?= =?us-ascii?Q?1eNiQJKm99XY5g8jIpoma0SomD2rYJ6e1H6H85HzforQxOjWnfOCYoc90PCy?= =?us-ascii?Q?9NLTJOjYD9lTUhQvrRHLCQAoIl8LjNaL4JDYlfuJhaEIwUo72J8OI4yhXwNe?= =?us-ascii?Q?W0LlNuoJ+tGg08U560Gl03SgVjECTMmI/DS6/BPLTpmA9g4ZuF/igTDah0Sc?= =?us-ascii?Q?0OoM9bHRgOkjG/i8p+i8sw54Qc2v9d1+BTJ7cIrebb7m1/Y+6ZmqqamkuEEW?= =?us-ascii?Q?NFVP41wrI/NzhBqQqdyqeFqzOxJ3ceNPzngwmP0zNIaJNSsLH/Vgqa1ufGIW?= =?us-ascii?Q?dqw4eewxLpQRFn3qAv2bGRbbCWdCKMPyOe1iy1wrRat+8dJGPnOHDvxrk76q?= =?us-ascii?Q?+tQ3MoHm6cii0j3Kt6JGeRVoJAMBIwhNmLWqqKQgV2dGAmSsAQslgOszMK+g?= =?us-ascii?Q?ECs+CApT4NUUjGoqtYL+LUIYlIo0KPHTHI8ZlTbJKRLUqwzi6noSxcv56g/h?= =?us-ascii?Q?vvWjiZtKZbi76XgJtIbLqebyKO/sv09XGhYr8KMVyMiLHwwG4zK/7n7KTm8E?= =?us-ascii?Q?k8Mz2YYF2b45pdzztK9bED1oFhwhj1/SX5r6rpvn5lkoSnu5mTR21iuALImD?= =?us-ascii?Q?JVh6x30Xwf5OBwqgf/fmt/Pe0CizpbK9edpOMYLi4Iiffhu86bIb/k1fmgRr?= =?us-ascii?Q?7K427t1T92lnupTu9/AVp2uYRnhJ29IBerAhCN5naT+3t1VOFQMBE3Zv/tq6?= =?us-ascii?Q?2A/2E/iUxksoarBSt1ybcKOdWP5p0MEYv/VPXYe+9Ulodbt0r1Xt48P/S+WS?= =?us-ascii?Q?i1S4NyrhQ6GAalq4HFculVSSKvRTCGGu22dqYXXWtgy1nELDqcAImICOC36B?= =?us-ascii?Q?ut6M0RtYP504N6RlmM7mhhaDTSKfOIp7H/CrtaToNShqHflxVIlObsiCP87p?= =?us-ascii?Q?m/oVcGT8TQQbMJYqIP6q3ULMK8P+RXeJzCTOewS6UcqjCx/hdPfKNWoleKxJ?= =?us-ascii?Q?+jENYH4vG003l1bJVFVQXLQIBhZRBu32+pPtR2vK3km/otT3xJY1OwwFXTgJ?= =?us-ascii?Q?mFg0Ii1acc7SZhcoWUSPrf5HgTEuwo+SKyAceiOU6AGGF4/0HC+PetutDqyL?= =?us-ascii?Q?B6Y5h0X5Gcwbu6XX0Z5X+isg9ri7LFsiOHUQVL4JBpll0ACvmrEinZYWZOHw?= =?us-ascii?Q?pRGxVTZnR8YPKnAN58+tYz5zUIhQc5ctvHvh?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 13:36:19.3324 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f547864f-0dc7-43d2-4461-08ddf5ef2f2a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E3.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7669 Content-Type: text/plain; charset="utf-8" Remove the restrictive idle check in xilinx_dma_start_transfer() that prevented new transfers from being queued when the channel was busy. Additionally, only update the CURDESC register when the active list is empty to avoid interfering with transfers already in progress. When the active list contains transfers, the hardware tail pointer extension mechanism handles chaining automatically. Signed-off-by: Suraj Gupta Tested-by: Folker Schwesinger --- drivers/dma/xilinx/xilinx_dma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 9f416eae33d0..7211c394cdca 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1548,9 +1548,6 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) if (list_empty(&chan->pending_list)) return; =20 - if (!chan->idle) - return; - head_desc =3D list_first_entry(&chan->pending_list, struct xilinx_dma_tx_descriptor, node); tail_desc =3D list_last_entry(&chan->pending_list, @@ -1567,7 +1564,7 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) dma_ctrl_write(chan, XILINX_DMA_REG_DMACR, reg); } =20 - if (chan->has_sg) + if (chan->has_sg && list_empty(&chan->active_list)) xilinx_write(chan, XILINX_DMA_REG_CURDESC, head_desc->async_tx.phys); reg &=3D ~XILINX_DMA_CR_DELAY_MAX; --=20 2.25.1 From nobody Thu Oct 2 10:39:57 2025 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010044.outbound.protection.outlook.com [52.101.56.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FC0432899F; Wed, 17 Sep 2025 13:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116187; cv=fail; b=mvs81seWDaDom3tbj+rERhM6VJMPWxSvkGGuRVARrNr4iTozFFcvwtYjExfWWXYuTEZgxm0VEyGWKn0ZQgQ9XCex4tai/R/rbndZb8BHSLyw2kvvPLHQgE80sgYv8T1qsHWoumK3pyvISwURH7V04+GJopPSEOcacecxicGRw0E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116187; c=relaxed/simple; bh=P9oDTuCdD1o3iuOHfKtFUL0qnTV9orHwi27cZRar6Yg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l1fxcziHts34TfDvztwrrDNDrLNGUs5D/31V1ly94rTGCjdTWceQmlJlVqOYO+bl/3MHVCMyup5t0HRoseX5X5sT732eQ92Zv27f7ms/CuM5ZLCzi8UqR/UxmdUAwky4fRUKP6ctts7db4cuvbywFquNR/uj5i4W970T03impEY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NyHFAqOt; arc=fail smtp.client-ip=52.101.56.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NyHFAqOt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PR1o50wxdtDAUgwKwPFCiKcveA58KlSQvWbW0rCt5c/aFHuyIkeJLr+BS9KYPz0qLCY7rQiuFrevVnd+Q3pXG2azl7Pj44n3KSa1GKRrZKFCL6TrO2k3mjn8OYFPeOqwKPl0t8lmeVACQhXy8jXRiWcs8BaTerK49YtcgmL0P73EdkJ38pGdzAHDf50NUch11yK+p/dR4FujEWVrCThEDGOV9iftLN4086Zpfh/6oMHfYpPWmxBckSvhIPY3H0MBxVGi6+z2wDgU7a5llqCWJvM6esMErF/7Wn0aCsndmdUVKfgDjX79faf7M2geq0KITfj4yYo9Hgx3C5uLeumYPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eTLHzJ4iODut4l38k52LLQc0+Xw73JtLgp7yW1kSnHs=; b=Cn5msgfO1I2vwkY7S7b4t8SKYdexYP2lPChIcyuj7J3/pcOR1tqjOaFY7n3XP/1ILzc5d1KHguELiD5yEJsw9Nj8FwdWhf6Wh6VaH9eWlYgacXsRCjKD7d+n8dnHHi8aF9/vQLSCBdd+/AHSZo612mDWIIUz0aA4LXLGK/vGrUjMm4WHbjT6UA2uWK2IL0aQJB3ksqoNhmXsXVsMBOVifOomQ9ooKzqsDlFYgPCU+Zu/yz1RvkIe7AA0JjH355WqQEN/p3Bp9PI4/EIJFaauztlESJRzl6f9aniXHge3QYTeSU6QkAxwia5JJjOcyowUvOC5f1f17GBQkTW853HHtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTLHzJ4iODut4l38k52LLQc0+Xw73JtLgp7yW1kSnHs=; b=NyHFAqOtn61ecBWzuxGm7+MGw/Ilaix6surZGrKBzGi5GWYH8w4FymbbB639nrDC86fM6iT5uG39dTJVKo97/8GQW8ISkmFlcD9OrvT65lcxM4bcEP508cH5Mz1/y+NHwQXlS7lhaJySN2IeZpeaoD5RdgSaYiEbW4mqihugqxU= Received: from SJ0PR05CA0185.namprd05.prod.outlook.com (2603:10b6:a03:330::10) by PH7PR12MB6834.namprd12.prod.outlook.com (2603:10b6:510:1b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.21; Wed, 17 Sep 2025 13:36:22 +0000 Received: from MWH0EPF000A672E.namprd04.prod.outlook.com (2603:10b6:a03:330:cafe::ca) by SJ0PR05CA0185.outlook.office365.com (2603:10b6:a03:330::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.14 via Frontend Transport; Wed, 17 Sep 2025 13:36:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by MWH0EPF000A672E.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Wed, 17 Sep 2025 13:36:22 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Wed, 17 Sep 2025 06:36:21 -0700 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 17 Sep 2025 08:36:21 -0500 Received: from xhdsuragupt40.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 17 Sep 2025 06:36:18 -0700 From: Suraj Gupta To: , , CC: , , Subject: [PATCH 3/3] dmaengine: xilinx_dma: Optimize control register write and channel start logic in xilinx_dma_start_transfer Date: Wed, 17 Sep 2025 19:06:09 +0530 Message-ID: <20250917133609.231316-4-suraj.gupta2@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250917133609.231316-1-suraj.gupta2@amd.com> References: <20250917133609.231316-1-suraj.gupta2@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672E:EE_|PH7PR12MB6834:EE_ X-MS-Office365-Filtering-Correlation-Id: d4ffa83a-f35e-4f32-1981-08ddf5ef30ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AsK1FxRKVNYvlhXxXEymWy/E+rwawu/rzb4d2e/fIFM6i+e6fxSoi/NUBHEC?= =?us-ascii?Q?ZcuPbNvYGFz/tlvWzyWNau7J3OX3Y8/CMctByIeJXFOJQtQ+shWursgL/msK?= =?us-ascii?Q?S3pFYtuZLy47bRVGFOkeP2L9Zo6qsjJ2CA9AqrR9XnZH6CaTsaFtK6w0bdfT?= =?us-ascii?Q?og3rpSLAE3sC8inswaTabJT7OTSWs2YEiTnWWCVR+YOP7e0AksHRtoWQeAHg?= =?us-ascii?Q?f9a4p1MjDF8O8FsFF+LdPe4Jj9KlAse77Q5hK9zPulF2r2IDaX/GStmiM5wW?= =?us-ascii?Q?ZTVctA2dfoCUlW3dc5nXYpfiwmI0AyS7rwg5VLkHMk0bWx+PPQ25lgyGXteR?= =?us-ascii?Q?xfW+ukZ8+SeRGkohAMNImetL/jPs3gMsiurLUZJjvo3ONaOE3DUM5tDA62e3?= =?us-ascii?Q?2tISKuzKH4HQs2WHWYw53+z2Lx80OjZDDCQ8HYTHclKUeLi+pQVrktXFPlK/?= =?us-ascii?Q?H0mhoovIYW3hz7XF6NhU6h9sU42YY2DkC95rrNc5WNUy/BThr1pJVlbRx5Sw?= =?us-ascii?Q?ST9DsztUz6coV1BsRCaYj9XyMIcEONpZaR/CehaRj6gCxwLu80KhVS/ZrdVI?= =?us-ascii?Q?yvnpOQbA+3mD0mcDu55QXya3b5xeR/Orsjkmy6sEv4pyrO2/cL23FBEujPZC?= =?us-ascii?Q?oyBR5xwWoc/C2HcQ1+qtQMaQzq+baGsA3a5ISG+YqN+GitzUuzKSMybn8wfD?= =?us-ascii?Q?nEFHk0BTCdAjAH7Y8zcxU4cBwJWl0jgzqVUAs3otvhs6IKyRZkQ6Y+hMR2Wj?= =?us-ascii?Q?iW99gnqtf8VtkzvhN/tdOXC05ADwPF9hZV9zICFl5svM0EQv6xqcUCgWce2n?= =?us-ascii?Q?O9hoL8guGoZ2Kd6CF1QnAMhJH3pqOA428cLWyCuIvFqoglpQSAWa6NHh5PS9?= =?us-ascii?Q?NZ3DoP391qBdZt/5CSDYbM4zNpU07i8May9LGMCOQfc4wggk5pVOrEogpGik?= =?us-ascii?Q?eYgvscWUq6nw9NHwVYWtc7fDPkvATrXcL8feMGfIRyJUnDRAym5+K6q1Xi9q?= =?us-ascii?Q?WwxXlQJ3gkRk3FotL4Ux4jSn0/8M0XlxX66/gjT1M49lKQSpEGWECuFPE8Zt?= =?us-ascii?Q?PKLpFMBbqNgAmStz05CqS3gYdFL+kGadWGCiLFsswgeQvx08Ia6/1/4+CeyF?= =?us-ascii?Q?pxpiuSEuApJ60oywO3dTvWH8oE7uA3HBabX0H2HGYMT0hpmrggRkcLuXHUeY?= =?us-ascii?Q?68A/Tk/mfcSirAW/Z2o7qKGD7oT0Jkz3M7DXN/3Iled8pczX4+PxxSTpJQVu?= =?us-ascii?Q?6P1mYq2d9uRi8mvMfPpj3hX3EnGWJYh/hDLthYDGpuMh+PlFXKuM9W2r2FJj?= =?us-ascii?Q?bCSsNq9wgo56z/g1i3xLoOKm8tBysu35jUHtRGilrHvs1bnUP90dlu4gAxFG?= =?us-ascii?Q?bRtxX36A4FTr6eRqNJB7SR5FRE5uea2kzynAH3YxLUKwC0FPX/y0xxffA8pp?= =?us-ascii?Q?2tN7RqvwHiBGWZWpo3V8rvosAVft8iAqXv+bM4SGd3bsSPT0d6txIIWOtrW4?= =?us-ascii?Q?FDmQ49BI5xZSMX0vwQvATvWRnXgr16nOaf6E?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 13:36:22.1779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4ffa83a-f35e-4f32-1981-08ddf5ef30ea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6834 Content-Type: text/plain; charset="utf-8" Optimize AXI DMA control register programming by consolidating coalesce count and delay configuration into a single register write. Previously, the coalesce count was written separately from the delay configuration, resulting in two register writes. Combine these into one write operation to reduce bus overhead. Additionally, avoid redundant channel starts by only calling xilinx_dma_start() when the channel is actually idle. Signed-off-by: Suraj Gupta Tested-by: Folker Schwesinger --- drivers/dma/xilinx/xilinx_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index 7211c394cdca..6e9bf4732ded 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1561,7 +1561,6 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) reg &=3D ~XILINX_DMA_CR_COALESCE_MAX; reg |=3D chan->desc_pendingcount << XILINX_DMA_CR_COALESCE_SHIFT; - dma_ctrl_write(chan, XILINX_DMA_REG_DMACR, reg); } =20 if (chan->has_sg && list_empty(&chan->active_list)) @@ -1571,7 +1570,8 @@ static void xilinx_dma_start_transfer(struct xilinx_d= ma_chan *chan) reg |=3D chan->irq_delay << XILINX_DMA_CR_DELAY_SHIFT; dma_ctrl_write(chan, XILINX_DMA_REG_DMACR, reg); =20 - xilinx_dma_start(chan); + if (chan->idle) + xilinx_dma_start(chan); =20 if (chan->err) return; --=20 2.25.1