From nobody Thu Oct 2 11:57:48 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB8932BC17 for ; Wed, 17 Sep 2025 13:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116195; cv=none; b=oNwlpEYGMxnjAPfTgxpahL38ptKzt+gyYHFfsjYqhbtva4/qO2lEiYWMY0lueLcis/NWz0buA6S5wH6QePRhHo2pDFrxzgG3HEZAVsRj9lbRTUG3EkDDOv10Eaes6mx05vlMaB5+u8GmO7I2N4tsRGkgosPCg1zU+auDTdZzjCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758116195; c=relaxed/simple; bh=gWMmpxO3/QyySBmyRF9UaNZFqybtXo64CSoJ0E1jRmY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QXmRq0C2qorlpCYpgys4PoJJHrV55YhU92bH1fBmdfSkE+Pfo5CbjHQfOlgNSHZFe/xsM9FaS1CvuTotOsJUCRuk85plkSiLn1weBd7UHuZ8ITyZGizJDiJOYHGyJ8u1p8FFmRwEnmHrgvYbuPyQNWsYeYv1CHYG6WlawkoPdNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UYF8otPY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UYF8otPY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45dd505a1dfso51977405e9.2 for ; Wed, 17 Sep 2025 06:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758116192; x=1758720992; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VSoCVcELFMldoX3y3Du2YUF3k7DlmnQItruU/P14Jd4=; b=UYF8otPYX4EcGx1GUcbiqykrIIKP6VPcWQyn8zjMNfmfiE22WZTfnIDqi/gIG3BXUz Ve2JCX5yNr/fTkQzTBCZp4Ud+0Uih+4GHtoYVEkV1qMZPVZQ5cW5eAXCb+oIFyBlMkAi sIQhOMdhN7/mff9qLxjPqdo6g15vx982ow0ib/kV/9JDfSQLngeia9yGciqCl7MLOose qgLTt9oNoD3JpWa1TOGYM/0HiJXvryH9o1tvpU+7u/CUvxGZyMmDSsVSP89lMhJ0axhv yg29hEpuTWpT0qhyv8HcRK3RGKsNaKJ+iFvLJ/LIzpZrBqsuOxAEFHVv76DIeUQYSsOM Os7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758116192; x=1758720992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VSoCVcELFMldoX3y3Du2YUF3k7DlmnQItruU/P14Jd4=; b=tStRcp9tqKScG6cF7TZAUMQfTUPKbwhQoxjJKCCiPouydfbV6Gpg4UCRTNi62gkWMr sPawFBbNrGm2rmg61T4E76MXYetSzOYWlmEMBrKiE4HGamM+rOYvYd5mcJtnUd9Gp4q+ 97+NmkY7TcXPGag/O6IN607vZl8LCqaGv3k0woNYWk/1LOQf61ZNh5uZzwN/5C/gFhux e5v7ac/ddVIm7jkJPK1WTYk8nG2VzuftdayyqUkVdqW6jFfAvkDzKpa6jMnt6IIYxzno oMBYfy0x/NpLPyNDzPKiWerfBjtOMev2Gey00IH19p9HeIilouY0WVWqEgPF4no+sNef vsyw== X-Forwarded-Encrypted: i=1; AJvYcCU6xtEfAX5UYi1FtCtu4sxfy5gSRRG4pWOVge4oY/BDLETDPBLXaICcw2Wv80gS1ctatYCUGsjoFtyHVQQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxSKwuJnH/sWfLkdzhsW/2ZT1U7jUXuJpPK/iVbu68XGds6qiaH ryoq3Wj/t4lj+QZNXgGmy5IUmusKBjT5RNOGtqgBw9ZIVdv+Sp4OaxZ+ X-Gm-Gg: ASbGnctMDyzoqDpwIWJcAkeXUtHRKoHvVO6BWHYNmB8dR48jbI6VWxp4ZZOXlK9R2ds 3EIOAwMRUtzOB3ABGf7WdLQ8Btdg0jLKEJIllT9u8299PaM7AYLmzI50Rybe1Rs72AhPf4O4kqr gPhBCn3EFPyEyUiOBzdXidAylBf/Ha0Bm8OawQAMK5/+PuTWrlKxRSD35HR6wsV20KzSa0ncTnG Kkmkhh9Jz+4sGlzJrCiC+R0sNvyZuxmYGAK7HdWk8IUN9qf4X/6RVIEU2bFiWx9KFBJv2OmDMj8 kyAAlRbAt1iV+2uBRm8DyclrNWZob7yBsTP+WogRPRPiPpUlM+PxtcDCcNGsmb67rUsj2J4qgFs ccZDTQFGtITCqdrnzGUKGoGCbaGERtsRX0y283maB X-Google-Smtp-Source: AGHT+IGXv7lCvSiC5jwcu15TTnkjthCUCqYkUi8gYvCV4k6lcJVuvHccVU1DUXs4EAeskxxTkOh/sA== X-Received: by 2002:a05:600c:4f86:b0:450:d37d:7c with SMTP id 5b1f17b1804b1-46206842450mr18528565e9.21.1758116191764; Wed, 17 Sep 2025 06:36:31 -0700 (PDT) Received: from hangmanPC.. ([86.124.200.102]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46139ab391bsm38198075e9.21.2025.09.17.06.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 06:36:31 -0700 (PDT) From: Cezar Chiru To: andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v4 1/3] i2c: pcf8584: Fix debug macros defines of if statements Date: Wed, 17 Sep 2025 16:35:22 +0300 Message-ID: <20250917133524.85063-2-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250917133524.85063-1-chiru.cezar.89@gmail.com> References: <20250907114557.15453-1-chiru.cezar.89@gmail.com> <20250917133524.85063-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Enclose 'if' statements debug macros defines in do - while loops. Fix inconsistent macro usage ending ';', which caused build errors in some cases. Enforce errors fixing based on checkpatch.pl output on file. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-= pcf.c index fd563e845d4b..3fc4b5080a32 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -23,10 +23,19 @@ #include "i2c-algo-pcf.h" =20 =20 -#define DEB2(x) if (i2c_debug >=3D 2) x -#define DEB3(x) if (i2c_debug >=3D 3) x /* print several statistical value= s */ -#define DEBPROTO(x) if (i2c_debug >=3D 9) x; - /* debug the protocol by showing transferred bits */ +#define DEB2(x) do { \ + if (i2c_debug >=3D 2) \ + x; \ + } while (0) +#define DEB3(x) do { \ + if (i2c_debug >=3D 3) \ + x; /* print several statistical values */ \ + } while (0) +#define DEBPROTO(x) do { \ + if (i2c_debug >=3D 9) \ + x; \ + /* debug the protocol by showing transferred bits */ \ + } while (0) #define DEF_TIMEOUT 16 =20 /* @@ -308,7 +317,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, timeout =3D wait_for_bb(adap); if (timeout) { DEB2(printk(KERN_ERR "i2c-algo-pcf.o: " - "Timeout waiting for BB in pcf_xfer\n");) + "Timeout waiting for BB in pcf_xfer\n")); i =3D -EIO; goto out; } @@ -318,7 +327,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, =20 DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: Doing %s %d bytes to 0x%02x - %d= of %d messages\n", str_read_write(pmsg->flags & I2C_M_RD), - pmsg->len, pmsg->addr, i + 1, num);) + pmsg->len, pmsg->addr, i + 1, num)); =20 ret =3D pcf_doAddress(adap, pmsg); =20 @@ -336,7 +345,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, } i2c_stop(adap); DEB2(printk(KERN_ERR "i2c-algo-pcf.o: Timeout waiting " - "for PIN(1) in pcf_xfer\n");) + "for PIN(1) in pcf_xfer\n")); i =3D -EREMOTEIO; goto out; } @@ -344,13 +353,13 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, /* Check LRB (last rcvd bit - slave ack) */ if (status & I2C_PCF_LRB) { i2c_stop(adap); - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: No LRB(1) in pcf_xfer\n");) + DEB2(printk(KERN_ERR "i2c-algo-pcf.o: No LRB(1) in pcf_xfer\n")); i =3D -EREMOTEIO; goto out; } =20 DEB3(printk(KERN_DEBUG "i2c-algo-pcf.o: Msg %d, addr=3D0x%x, flags=3D0x%= x, len=3D%d\n", - i, msgs[i].addr, msgs[i].flags, msgs[i].len);) + i, msgs[i].addr, msgs[i].flags, msgs[i].len)); =20 if (pmsg->flags & I2C_M_RD) { ret =3D pcf_readbytes(i2c_adap, pmsg->buf, pmsg->len, --=20 2.43.0