From nobody Thu Oct 2 11:50:43 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 800DA3451D7 for ; Wed, 17 Sep 2025 09:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101321; cv=none; b=p38oCERUdXYtbdgZEU4BBqlEH+PHLcnTtbG7Pbj2hA4+nWg278Bp6i/TafQ6dRQjRtycmgqWS0m5zAYgWE0gkbSV5RKPDilM7ep5XJD4koil5B2krh/B+rOEtRnx85qUYUhFuRkPCMZLs1kqkAYDxiAO/DmoLp6yDLRikJlt4JA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101321; c=relaxed/simple; bh=Mapi4qRO18JNApuqaFmvuJzPJiuchg7jIC/0OT7vifs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DlAfiMuJYl5rJiS6G4dTUq/jndJ6AiIfQH0n4GuAaqZmgxBYKwI8Cv2zkEl12H8mJXMkdhEpxyDy+kVTUsp0IZbCVYMFQs7hhOhp3Qo6JXfwCe+wiIWgZK4RmRSuXR+HiNJPdbT7+ZO5zuW3UEAH9YYSSF1t2SoNIjdyvlz5iQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com; spf=none smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=x/EcPSuU; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="x/EcPSuU" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-251fc032d1fso72712155ad.3 for ; Wed, 17 Sep 2025 02:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1758101318; x=1758706118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8j1xWi8yHO61hmZJR2yMfuKWLMhG/TRDNgL+UU0ZcBE=; b=x/EcPSuU+lAPQL78GTrl1pLUr5KZEhTRcU0MB58zX/PfF3F9bIFaSwLSUUnIOCIJnU xnHDihNrJqNp2k+LUuqspEk/lHSjDPIW3BtCa866rY11mUYR2hN4coQpftxS6oTXzcaW qSaM3C1bUlOz5HrY/9UX4FCeTYqMK7ciol7n3E2/Pd1j67RAEbqaF3xIZKHay6UY5ebY eSvbrMmj5cBJhMcmLKUN4Eta5ESAwyYfGYbfugbUO2yuWfqybVegQhjRQ+aXIinqP7dL dLL4cm9akoWhNBJ+6Yx3awmFZEnFXfMisRcwb63fNuCsP4m9PDFYklPab3QFYnP5ZWxx jyhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758101318; x=1758706118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8j1xWi8yHO61hmZJR2yMfuKWLMhG/TRDNgL+UU0ZcBE=; b=k2mNXV6cGovR/F5Uxnv4/wlPObtJiomqfWNsERsAUx6UEg8zWvKFh77h9JbCBgxU/Z 2GX/9dHImD+rw934iBl+ezis3O1gDXGtI4fqM3y/VJIPQW8dRrrn6IWKr3HOlORAuvqg g9Op+mJNyadJCa1F14JqstU3v3YZgU+/hkhA3CYTjjV3JQxlbHVVTB0khvL0FNgg0jOh i+JydkZCkpUitsBgqkhuNWkFzfknu9ldhyiHd60su9/12c+yuOZIKR41MIT0liWM/drk W9C5ekOzLmRKoMktMv6eeEqnhApcq9SIwkOZeXS/+km9S0fFmQbRsriZOQ5gZ+DIsQba YtMg== X-Forwarded-Encrypted: i=1; AJvYcCVlw+7VinUzO7OzFrck2YvobiwNmzmh3GGzdf4HC7DBhvxkK8z6z+7bbqBnluzWkC9gls2GNnWvlCMbFe4=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ+ZuXJR3J2yLGr+RQKYMC3qv2blq7QroFQ/0BifwqIsVBd4se BofBZUcHVepxaqcKjHv3XyBt1UYHKNtVPHJgiP4CW4Fs2xAFY+1biL0HnCrqBNKAKps= X-Gm-Gg: ASbGncu0xbWThR759EHs2IvjZ9q7bd1RKG+9wwHIgtf66CGOS7diCwTrhGHxQO85Q6m qKRUGDNhtoVppEvQJkLzsTcBeUZmOEZfRF/HRq6rAlRiRPtbzNy+j6LXiMvRbNrdhuzL9X/SBkr AoajcW4F1Pb2Y1LKuemaWNb0e+Mk9+fpnQa1w8owGoUdtd0ARpSRXlhhPtERR46HE7+ehi9I5Vb hXNYjTPITiM1AizL2EL1+BNkhbS/dqs0+aavwX0lLnnhg3kKyQXSQiakPwQ93DYwMdhBO+/mDXs U+/lXcipOuBrAIMbEaulO4YCLs+oPekm6boYFjL60k9iJsaRuxPAY07kVZf9FAGoFYPq6+C7cF5 L7pc/JAQm+hJfv2zAEY2lt2Ed4kbukgwU+Jx82Lm4okqjTCHs0jo= X-Google-Smtp-Source: AGHT+IGrUlWL0tzfLtquvrJRbqTi99ooOO3SYsnEAMGANiYtwIWUXXJnYFIYJ1snMKEuZ1H2K+q1RA== X-Received: by 2002:a17:903:3585:b0:259:5284:f87b with SMTP id d9443c01a7336-26811e87273mr18453755ad.16.1758101317378; Wed, 17 Sep 2025 02:28:37 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25f4935db09sm137047885ad.61.2025.09.17.02.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 02:28:37 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v1 1/3] Revert "x86: kvm: introduce periodic global clock updates" Date: Wed, 17 Sep 2025 17:28:22 +0800 Message-ID: <20250917092824.4070217-2-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250917092824.4070217-1-lei.chen@smartx.com> References: <20250917092824.4070217-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 332967a3eac06f6379283cf155c84fe7cd0537c2. Commit 332967a3eac0 ("x86: kvm: introduce periodic global clock updates") introduced a 300s interval work to sync ntp corrections across all vcpus. Since commit 53fafdbb8b21 ("KVM: x86: switch KVMCLOCK base to monotonic raw clock"), kvmclock switched to mono raw clock, we can no longer take ntp into consideration. Signed-off-by: Lei Chen --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/x86.c | 25 ------------------------- 2 files changed, 26 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index f19a76d3ca0e..e41e4fe91f5e 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1436,7 +1436,6 @@ struct kvm_arch { u64 master_kernel_ns; u64 master_cycle_now; struct delayed_work kvmclock_update_work; - struct delayed_work kvmclock_sync_work; =20 #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a1c49bc681c4..399045a384d4 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -157,9 +157,6 @@ EXPORT_SYMBOL_GPL(report_ignored_msrs); unsigned int min_timer_period_us =3D 200; module_param(min_timer_period_us, uint, 0644); =20 -static bool __read_mostly kvmclock_periodic_sync =3D true; -module_param(kvmclock_periodic_sync, bool, 0444); - /* tsc tolerance in parts per million - default to 1/2 of the NTP threshol= d */ static u32 __read_mostly tsc_tolerance_ppm =3D 250; module_param(tsc_tolerance_ppm, uint, 0644); @@ -3439,20 +3436,6 @@ static void kvm_gen_kvmclock_update(struct kvm_vcpu = *v) KVMCLOCK_UPDATE_DELAY); } =20 -#define KVMCLOCK_SYNC_PERIOD (300 * HZ) - -static void kvmclock_sync_fn(struct work_struct *work) -{ - struct delayed_work *dwork =3D to_delayed_work(work); - struct kvm_arch *ka =3D container_of(dwork, struct kvm_arch, - kvmclock_sync_work); - struct kvm *kvm =3D container_of(ka, struct kvm, arch); - - schedule_delayed_work(&kvm->arch.kvmclock_update_work, 0); - schedule_delayed_work(&kvm->arch.kvmclock_sync_work, - KVMCLOCK_SYNC_PERIOD); -} - /* These helpers are safe iff @msr is known to be an MCx bank MSR. */ static bool is_mci_control_msr(u32 msr) { @@ -12327,8 +12310,6 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) =20 void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) { - struct kvm *kvm =3D vcpu->kvm; - if (mutex_lock_killable(&vcpu->mutex)) return; vcpu_load(vcpu); @@ -12339,10 +12320,6 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcp= u) vcpu->arch.msr_kvm_poll_control =3D 1; =20 mutex_unlock(&vcpu->mutex); - - if (kvmclock_periodic_sync && vcpu->vcpu_idx =3D=3D 0) - schedule_delayed_work(&kvm->arch.kvmclock_sync_work, - KVMCLOCK_SYNC_PERIOD); } =20 void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) @@ -12722,7 +12699,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long= type) #endif =20 INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); - INIT_DELAYED_WORK(&kvm->arch.kvmclock_sync_work, kvmclock_sync_fn); =20 kvm_apicv_init(kvm); kvm_hv_init_vm(kvm); @@ -12830,7 +12806,6 @@ void kvm_arch_pre_destroy_vm(struct kvm *kvm) * is unsafe, i.e. will lead to use-after-free. The PIT also needs to * be stopped before IRQ routing is freed. */ - cancel_delayed_work_sync(&kvm->arch.kvmclock_sync_work); cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work); =20 #ifdef CONFIG_KVM_IOAPIC --=20 2.44.0 From nobody Thu Oct 2 11:50:43 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC653346A12 for ; Wed, 17 Sep 2025 09:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101324; cv=none; b=Liu/cvmmppFb5owUlHNIvHv3bFFldqyVOUqltu0zZh1hPS3HM0JWQDEM9cnUkbs5PI9CDuTFgQx4MfV0BRx87yb4U8+G3eLFasf9YP6twW1dXGznzVEPDkCkKC4rFGUheyz4F2LbQSrIMVjyU2znWf2kB+1ia0Rkh5p22yDvuEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101324; c=relaxed/simple; bh=eUrR4NP72EKznEUzfrQ6RmdmdpoU6ltR0MbO4Ojo8Yg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SvTnzIlN6CIbhnnCdKwVPlB54aVb+3uc4hfOybDd+vFSZcXYQdWZ0vLvMJT7COjHjewY3FDaOWCV9VZkMItakO7qmxnfo01xqLF1yUjwD4ZiPGq/OFpGzclyjhE5wluLSP1sewJBUTnUl+kW52+ep9NlkwB/IxuPk3+CpquIekM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com; spf=none smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=hW2r4C7z; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="hW2r4C7z" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-25669596955so66409995ad.0 for ; Wed, 17 Sep 2025 02:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1758101322; x=1758706122; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2lSDpgMZajVKYY0uCSDb90s/Pt+KK5ftnBEiQn/IXqA=; b=hW2r4C7zbLW/qK1X5VOp71dVhRAQQhnoZbxaCfdFo+cGs+GCEDEskzZmnW4Ba8I4cQ CBy4DPFsZj9PzD823R3xGWUo/bStErnWGk1aIXADI5kak3SnypPPZk08jUMH96uXCXx0 nh5Jc5urQ06r2Ci/wUQH3Lgo/+oClveMdrrUL0IP77bo9bdWTI3WMFH12LFZXVkxj7Bc ldVqVobquLYNsR4BXT7jbhQuPtmTDi+1cxCxx8hQCi7ljlGbH5+jpcJpSvMfISde6HEa 0jIK0m99ZNhykEtnAjjQCug+UaeIBez9hdsPRVptGjtcKAo4AhLuaJmKGJycWjCzcXZT qqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758101322; x=1758706122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2lSDpgMZajVKYY0uCSDb90s/Pt+KK5ftnBEiQn/IXqA=; b=cmhXmG3hX59qm7IRPmNy0gJPXDCMSaPGavmKix+vwWlxpGlGWvajVeFYnc3q+h9ewy dgqrBr20emQ6mL0BRY35ucBMjtddiMn7ES1jX9cLsjT0nN8IXNtMQQPQ7e8Dl57Tb+6m vzgZhwWla0nOXekpRy0J5XD6JBtSVKJsbQd5qVzteYmLZw4dFat5LQ7odqRBivOg+io6 P3Fikg6orJFdEe4ByN5rgB5tAsCux834PYc8Vc/PQhUlpekWJ1HyIBDzLGrwbrMRlDe+ LWS8KpdWNWXhz6PbUb24eRXW8ZT5OPESgWJozwJ9i+Agvq2/QQmEvlwFduuzyNyzpTCQ CZ4w== X-Forwarded-Encrypted: i=1; AJvYcCWyhKe+oAoj1C+pm4QBog9Of+4stN1hiYUxnsqF4+qAB+ti6mGOzTDC2D8Dx8UUPBJfhmUnxbSRGPk8XUk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkeq2ZJhXdinZXK90AUkVL10uG663+pRsc74oBHTpZC1VPnt+J DNR38LgLadsY/IokTZ3WCHqsFSD4wJQJ44TbOoPqAPWnam6+qx3dA0OQxCPWYHcee6Y= X-Gm-Gg: ASbGnctGcUHWT8jUxsiFQFHBRjE5mVk4eih3WGt6SwVc96Ph7dWbo3wZGBjH+qA+hF9 b/jUGXYpo5/20BkzG/1TiwQy5IwWv4IccnuT/wdQChcQPttkE8+hOAdglJ3I+hwwpxSolh51eEX tRwd65uBY3YOtmpsy6DIa04tJZR/5HULBYN6BlvlPTJrbW2CgWZ8PMjTggeG4cU+0WkLnsE7tXp lwIGA2v9eKJF449ZDNgpltFzGcuG+dQaXV69KQQ/BGdFzZlR3BCLV45DzJOQpKhX6c2NrQ1vZQb rP2ub+gO1X0TxZxVpulpZDZI3Fi90f4vQMQXeSe8ksZHWiDeGkLDBc4DMqnoeyddiz6xSJtuLu5 vRoffK4JubnmjUfBcpQmr+AlQJwCJCW/jn/9E5ngkjXTtNZTGaEw= X-Google-Smtp-Source: AGHT+IEjfRijYq0VwSv+OEvYQ2UAxv0++/v+P+9EkS/eMiH1jCSd8Xml7DcvHul7KRrKoeKUOK/rzw== X-Received: by 2002:a17:903:950:b0:267:b308:c614 with SMTP id d9443c01a7336-26813cedefbmr18895185ad.50.1758101321484; Wed, 17 Sep 2025 02:28:41 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25f4935db09sm137047885ad.61.2025.09.17.02.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 02:28:41 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v1 2/3] Revert "x86: kvm: rate-limit global clock updates" Date: Wed, 17 Sep 2025 17:28:23 +0800 Message-ID: <20250917092824.4070217-3-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250917092824.4070217-1-lei.chen@smartx.com> References: <20250917092824.4070217-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 7e44e4495a398eb553ce561f29f9148f40a3448f. Commit 7e44e4495a39 ("x86: kvm: rate-limit global clock updates") intends to use a kvmclock_update_work to sync ntp corretion across all vcpus kvmclock, which is based on commit 0061d53daf26f ("KVM: x86: limit difference between kvmclock updates") Since kvmclock has been switched to mono raw, this commit can be reverted. Signed-off-by: Lei Chen --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/x86.c | 29 ++++------------------------- 2 files changed, 4 insertions(+), 26 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index e41e4fe91f5e..0a1165f40ff1 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1435,7 +1435,6 @@ struct kvm_arch { bool use_master_clock; u64 master_kernel_ns; u64 master_cycle_now; - struct delayed_work kvmclock_update_work; =20 #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 399045a384d4..d526e9e285f1 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3404,22 +3404,14 @@ uint64_t kvm_get_wall_clock_epoch(struct kvm *kvm) * the others. * * So in those cases, request a kvmclock update for all vcpus. - * We need to rate-limit these requests though, as they can - * considerably slow guests that have a large number of vcpus. - * The time for a remote vcpu to update its kvmclock is bound - * by the delay we use to rate-limit the updates. + * The worst case for a remote vcpu to update its kvmclock + * is then bounded by maximum nohz sleep latency. */ - -#define KVMCLOCK_UPDATE_DELAY msecs_to_jiffies(100) - -static void kvmclock_update_fn(struct work_struct *work) +static void kvm_gen_kvmclock_update(struct kvm_vcpu *v) { unsigned long i; - struct delayed_work *dwork =3D to_delayed_work(work); - struct kvm_arch *ka =3D container_of(dwork, struct kvm_arch, - kvmclock_update_work); - struct kvm *kvm =3D container_of(ka, struct kvm, arch); struct kvm_vcpu *vcpu; + struct kvm *kvm =3D v->kvm; =20 kvm_for_each_vcpu(i, vcpu, kvm) { kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); @@ -3427,15 +3419,6 @@ static void kvmclock_update_fn(struct work_struct *w= ork) } } =20 -static void kvm_gen_kvmclock_update(struct kvm_vcpu *v) -{ - struct kvm *kvm =3D v->kvm; - - kvm_make_request(KVM_REQ_CLOCK_UPDATE, v); - schedule_delayed_work(&kvm->arch.kvmclock_update_work, - KVMCLOCK_UPDATE_DELAY); -} - /* These helpers are safe iff @msr is known to be an MCx bank MSR. */ static bool is_mci_control_msr(u32 msr) { @@ -12698,8 +12681,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long= type) kvm->arch.hv_root_tdp =3D INVALID_PAGE; #endif =20 - INIT_DELAYED_WORK(&kvm->arch.kvmclock_update_work, kvmclock_update_fn); - kvm_apicv_init(kvm); kvm_hv_init_vm(kvm); kvm_xen_init_vm(kvm); @@ -12806,8 +12787,6 @@ void kvm_arch_pre_destroy_vm(struct kvm *kvm) * is unsafe, i.e. will lead to use-after-free. The PIT also needs to * be stopped before IRQ routing is freed. */ - cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work); - #ifdef CONFIG_KVM_IOAPIC kvm_free_pit(kvm); #endif --=20 2.44.0 From nobody Thu Oct 2 11:50:43 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7518534A305 for ; Wed, 17 Sep 2025 09:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101328; cv=none; b=bKJnvz6EOQ89GpsUYeobVaicu+6rAjIO6YZxzTdwOA6SQTZRBQFFo3yZA0L7Rv4omJzw1ha/f5YScPIFdepkPu6swBWrXOxnAZm+xSLGovhoRcuIhVrBY7UZaDEdfk33CD5tai3v6NvE0+XkohYTgERuX7zFcT+4p4c1IxY9v24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758101328; c=relaxed/simple; bh=HomK9oR9q6PgZ6KTjkrL0ZAF4ixtQM3rr4sUa8Fd5OA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NrOxLk282tkWn5LAWaEilyOd83Gqbacld0sTXr5aezRFgLDqr9URJJvkQ0b23fBKPME761rckndJNbIwZgY+stM6MHc1YT+4b+r5XeotE2iA9idMz2OzDJt2JW+bsnlkuQBHEgfe+uALiMfgb2S4vNcubGyDPXs6QWCXtTCEdqM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=smartx.com; spf=pass smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b=sdvs0fDL; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20230601.gappssmtp.com header.i=@smartx-com.20230601.gappssmtp.com header.b="sdvs0fDL" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-268107d8662so4608405ad.2 for ; Wed, 17 Sep 2025 02:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1758101326; x=1758706126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A/CvHxpYU6aT1JADHVD5nQ98mr1UgBNDG9QHGX5cLNQ=; b=sdvs0fDL+fmQRx4+XxxE3b9aXLyW1htEcXlyoM4Svot1JDLnZ8KzEZtzMP2j+A9KcH zew8ka7Cjiz6f0OmchCUAkBj5M+uIih4NnBIoqI40FgAxqsZF5KUA8qZ2/Hg1EP71/2v CGHZQzRGTCAJpXN1Clg7ughI6mIQaOLD654LBR1z7pi/ztn3w/aPS5dPRcIfsmpyNyf4 c09stCP4lu9iS2noUc+WBr6FB18ftTE7jph3cCsja3wyoAba4qk7tA8EvgNQnbJJBtKo I2Y+a860saPGnJXwO3agqwwfbdaRjDbWl2De2o29Fc5ePUiLwO1UM2UBguKZIOHcLlI8 MW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758101326; x=1758706126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/CvHxpYU6aT1JADHVD5nQ98mr1UgBNDG9QHGX5cLNQ=; b=tuAViu0++caZTdZ8azZlMadS6sYsksYwKwL3jgcyfrDUh7W9X84okL0ef5PlmUcYdb vzc/6ByP81buRyCP7bM62Q7P/njdP/KWWs6vV12BqNDl3FgGq+mpgrSi/uu3yWFtqJcD wwtPB9hLXEKyzZab5wuuOdbvtYti594WP6N6mE+NzpPU2wxpME6CNiiyBPbXdnZfh0/w iQ8g48k/MhlCI0NJ6j3uquOuepJIe4AXqZiH6e8Q3+55ayxqxCFAGVHKuUNYq8El72WA DSHKPfLDlFtbEDHmMQyGwh0Bz4Mkab8cs5ukInNNJ6zDbartvsTLXQQ6p2vzVir2r8vj hVXw== X-Forwarded-Encrypted: i=1; AJvYcCU7vGhxk6ySmGIlrfFnfRFlmBjxR8HUrQArQ/thc9GN7zRvie9nlNVGRLcTd2/JqWraBN4nv91pQ/VPPHs=@vger.kernel.org X-Gm-Message-State: AOJu0YzIjfmCzjn/GelOWwLPVUHFuqfccEztjT12szsL37Kvmm+KpsM4 UX90ydj7psbVvts/msAQJafHDYn+YlDNr7N2iiYZT2NeDQEtNAEs6xhuzyI0+YYLwINllNoQW67 duLWbKgJOxg== X-Gm-Gg: ASbGncvp2ozNvryYpLJM/+Rpk5dh/4e5Mkts8gZPB9+0kjIQlIbf0ogibADzDCnaI+e Yh1oBwjMPcC9cHQ6v/CqlJQaBFIDA7kI3NRYW11ZDcvqDi7UUxx4/9Kvt+Ib0lF3mLHPeNQ3Paq IjmwwmivNofiMmXiiGASdsSFig8n2HCYxT0aLZ+4ca4SKWZCHA7qjovH2vHLJubDWYkSVKu+vUL aHlIgZpiil2/RDqbRloZzFiGnuU5jgiLgxOhY6ReWMHbvLNrc2XDoFDxW+WGKr0TavWA2970WHI Uwe0081ILkkLEELUZMIh/602SHgCuMeO6woHIbBwilv6/QMtwG1qnQ8kPpz1XUnlV0e6IWV5tNz ZXmucv1dHcnDCjD35N7fx9W45aWxSxm77vF0Kx+2MuwGLVSC+EF0= X-Google-Smtp-Source: AGHT+IFh/uBlLQN+Z64/3NY4nlJ9THrCXhkwHJPZh1q+BGnbJDaVlEFVI0umfFifgHpYECE5AHRbLA== X-Received: by 2002:a17:903:1b2e:b0:24b:270e:56c7 with SMTP id d9443c01a7336-268119b2a8fmr20448045ad.7.1758101325500; Wed, 17 Sep 2025 02:28:45 -0700 (PDT) Received: from localhost.localdomain ([193.246.161.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25f4935db09sm137047885ad.61.2025.09.17.02.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 02:28:45 -0700 (PDT) From: Lei Chen To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v1 3/3] KVM: x86: remove comment about ntp correction sync for Date: Wed, 17 Sep 2025 17:28:24 +0800 Message-ID: <20250917092824.4070217-4-lei.chen@smartx.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250917092824.4070217-1-lei.chen@smartx.com> References: <20250917092824.4070217-1-lei.chen@smartx.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since vcpu local clock is no longer affected by ntp, remove comment about ntp correction sync for function kvm_gen_kvmclock_update. Signed-off-by: Lei Chen --- arch/x86/kvm/x86.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index d526e9e285f1..f85611f59218 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3399,9 +3399,7 @@ uint64_t kvm_get_wall_clock_epoch(struct kvm *kvm) /* * kvmclock updates which are isolated to a given vcpu, such as * vcpu->cpu migration, should not allow system_timestamp from - * the rest of the vcpus to remain static. Otherwise ntp frequency - * correction applies to one vcpu's system_timestamp but not - * the others. + * the rest of the vcpus to remain static. * * So in those cases, request a kvmclock update for all vcpus. * The worst case for a remote vcpu to update its kvmclock --=20 2.44.0