From nobody Thu Oct 2 10:55:21 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3EF92FB63A; Wed, 17 Sep 2025 17:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758130927; cv=none; b=P77npUj/FTraVZylPYCXWn19dg6uztoCM21ZMW/oFFtkuT4LJUX4Ig9d5ehAFpUL/vygybsJ0ew1x+vWeEABXsuhcNfjU7BvLGR+g14wXsDB8zg8awTeKjnnZwjByj9bMjykvIs+BiHdbvMveFkgX9OrhKfRdznUHS5JQEfqLdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758130927; c=relaxed/simple; bh=xznId6KLEjexVhy44PArHFtKkaLQrxQlKITeJniEfMw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nX0g1bjV8doqnfclTDBG5La9+d1seUqzJ3SGXtphuZXXtGq9wOIB4+U+wCpViBi+pCsrGKnLNiEPplpeAVo83Yu/XqmgtcMPXQ3LrR9Qk+P5alTvLOVb9yPUP27SBE+20n6mTA6g1LdYRT51SG5vTbA9dik9ZYgqN9Q0Sp8CNHw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3DE426B9; Wed, 17 Sep 2025 10:41:56 -0700 (PDT) Received: from e132581.arm.com (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5608A3F694; Wed, 17 Sep 2025 10:42:03 -0700 (PDT) From: Leo Yan Date: Wed, 17 Sep 2025 18:41:38 +0100 Subject: [PATCH 1/2] coresight: trbe: Prevent overflow in PERF_IDX2OFF() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250917-fix_aux_trace_index-v1-1-e36a76ac6292@arm.com> References: <20250917-fix_aux_trace_index-v1-0-e36a76ac6292@arm.com> In-Reply-To: <20250917-fix_aux_trace_index-v1-0-e36a76ac6292@arm.com> To: Will Deacon , Mark Rutland , Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Anshuman Khandual , Tamas Zsoldos Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758130921; l=966; i=leo.yan@arm.com; s=20250604; h=from:subject:message-id; bh=xznId6KLEjexVhy44PArHFtKkaLQrxQlKITeJniEfMw=; b=xm7EqYkG+5d5BnteZZCaYjnZng4eknZZdmbDF+4qbTnRmbX8O0oYWWZNZ524Yz6+MGMQaq42R A8hgQsIIvpdCneK9sYCcTau5oHci7VEb13RVQmcwjMCjNofM/d119GP X-Developer-Key: i=leo.yan@arm.com; a=ed25519; pk=k4BaDbvkCXzBFA7Nw184KHGP5thju8lKqJYIrOWxDhI= Cast nr_pages to unsigned long to avoid overflow when handling large AUX buffer sizes (>=3D 2 GiB). Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver") Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/coresight-trbe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtraci= ng/coresight/coresight-trbe.c index 8267dd1a2130d37d9507791620ea7bc8cbcd675c..8f426f94e32a15fd26e6c4e4238= 5a5d93a7b7c1a 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -23,7 +23,8 @@ #include "coresight-self-hosted-trace.h" #include "coresight-trbe.h" =20 -#define PERF_IDX2OFF(idx, buf) ((idx) % ((buf)->nr_pages << PAGE_SHIFT)) +#define PERF_IDX2OFF(idx, buf) \ + ((idx) % ((unsigned long)(buf)->nr_pages << PAGE_SHIFT)) =20 /* * A padding packet that will help the user space tools --=20 2.34.1 From nobody Thu Oct 2 10:55:21 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6D273002A0; Wed, 17 Sep 2025 17:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758130929; cv=none; b=LTZaODywcb3zVqbBQd02fEGMUiclft9lO1hbtDii1x3EFAzY+iOsVHPuz9Xhcf+bix0AKOW2OAaorw3p09lW4jqqRG7Ef0da6anFzazATRP+U1TZc8cCDnC2MjbpvHXHB/tOgM+7bKE2Di0mtIbLAjgF5873Vq7hF36sMkwloHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758130929; c=relaxed/simple; bh=/9UdUZ9OJII8IHbRr4Maef/QuxaY9QyUmTQxAX7pvqg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l1WxwENPVh9Vhvvlj9eAtJhyjuDEDqDV6rpv9u+M1e6vIRXRF+MgkRjGwmB2E+2BVFIfbeGtVkZrv1QNHKN0IXx4RhoBAmbheX9EbdsEQLoE9AkKcEVtnxQ+rvrSQULDFpw1wvaW0tNOOVOO5FNNuesCF7OjCXkiQmPhnRD2dLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D86E726BC; Wed, 17 Sep 2025 10:41:58 -0700 (PDT) Received: from e132581.arm.com (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D3803F694; Wed, 17 Sep 2025 10:42:05 -0700 (PDT) From: Leo Yan Date: Wed, 17 Sep 2025 18:41:39 +0100 Subject: [PATCH 2/2] perf: arm_spe: Prevent overflow in PERF_IDX2OFF() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250917-fix_aux_trace_index-v1-2-e36a76ac6292@arm.com> References: <20250917-fix_aux_trace_index-v1-0-e36a76ac6292@arm.com> In-Reply-To: <20250917-fix_aux_trace_index-v1-0-e36a76ac6292@arm.com> To: Will Deacon , Mark Rutland , Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Anshuman Khandual , Tamas Zsoldos Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758130921; l=1032; i=leo.yan@arm.com; s=20250604; h=from:subject:message-id; bh=/9UdUZ9OJII8IHbRr4Maef/QuxaY9QyUmTQxAX7pvqg=; b=x0p7c5gNdLZczsCfpgoOfdRVsyQTPiTO8a7q3eclGz88s9gvUi3g63j/BIGmu+UrjcROmjZ+6 UCpvygM7/WrALEAZljLPsga55AGq0wDkfpn8JHk/HzPcrAAruaPZDGS X-Developer-Key: i=leo.yan@arm.com; a=ed25519; pk=k4BaDbvkCXzBFA7Nw184KHGP5thju8lKqJYIrOWxDhI= Cast nr_pages to unsigned long to avoid overflow when handling large AUX buffer sizes (>=3D 2 GiB). Fixes: d5d9696b0380 ("drivers/perf: Add support for ARMv8.2 Statistical Pro= filing Extension") Signed-off-by: Leo Yan --- drivers/perf/arm_spe_pmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index 369e77ad5f13ffb490bf8f128fee5180d1254bc6..8f14cb324e018349fbe19c5c20d= 92a9cdcfd2e73 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -97,7 +97,8 @@ struct arm_spe_pmu { #define to_spe_pmu(p) (container_of(p, struct arm_spe_pmu, pmu)) =20 /* Convert a free-running index from perf into an SPE buffer offset */ -#define PERF_IDX2OFF(idx, buf) ((idx) % ((buf)->nr_pages << PAGE_SHIFT)) +#define PERF_IDX2OFF(idx, buf) \ + ((idx) % ((unsigned long)(buf)->nr_pages << PAGE_SHIFT)) =20 /* Keep track of our dynamic hotplug state */ static enum cpuhp_state arm_spe_pmu_online; --=20 2.34.1