From nobody Thu Oct 2 14:26:15 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7519130DECC; Tue, 16 Sep 2025 12:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758024290; cv=none; b=ftR/h/u+c5ZHQh1DpTQzNEW+UBBpGMZNbhnKapeVwa/Vs5urmkFHn8uaVHHAE6ggsdAUW7DSqdpDF/C+N4cu38Nk2OejiordDs05IWupESMK9rZo3xXogKlSbZ+muSiuEZ3msfIKirFkU03epdyJ0Ul+r9lIL/qpLbv7uX43lbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758024290; c=relaxed/simple; bh=b3IOQESW/mIXTD/yKAxdQFbR5Vp6zP2+u9V9iRgwxT0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tPR84LHbnGQsIIqX8KrnZ8sauaLHHzL9u3Cs7eBTS2CXQ8y6bS0XRsQU9FgfVjHlA61MmlLzCw9cdtjGMl/otWQSXIkbwHNgmMacrN7sln28i+fv7oMlpNP5VzMsnlPWgIxSOL/AFyr65RE/cs7t3hhrudIW4fucgh0ZiTG7yUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kdzFwBk9; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kdzFwBk9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758024288; x=1789560288; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b3IOQESW/mIXTD/yKAxdQFbR5Vp6zP2+u9V9iRgwxT0=; b=kdzFwBk9Jphqz6jUd5WtkhEuVB/6bEJImtK8nNCoSfAROgutmAjH71Nx ktyQnCe7Ow/AimGga+KgpCk0GU6HPlO9B7MjRT+rUQTN2rXwT4/ilSLG5 YhZMB30HrBUvyyiAxF0g6kvIVry7HtHJvuuX2eoAaDsslqgvR/Ihi3coi NLfO6yYtEQ8sRZYKBZYNZLMK6PTBoDD5n1adSVZam7Tzw5QDvzigvgoPA Z5iVTTS43ElHUVU3xHqp3e70KpXG1hcQs2+9+49/HKQ6O5P1QGqc/L10W dgnij/MAzOmkzbsILodqBHUfeEKX1OVzW99zTuJ2I5zeHmWeuz7QrX7fM w==; X-CSE-ConnectionGUID: 9YyGI2C+QZqYPdHoWjZAhQ== X-CSE-MsgGUID: 1bD8nDRKSNKhgqLdPbRgqQ== X-IronPort-AV: E=McAfee;i="6800,10657,11554"; a="59347171" X-IronPort-AV: E=Sophos;i="6.18,269,1751266800"; d="scan'208";a="59347171" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2025 05:04:48 -0700 X-CSE-ConnectionGUID: ARg0KeKPT3y0lw2xkMzUOw== X-CSE-MsgGUID: gAcgNXJuTP2ybjktJX/vkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,269,1751266800"; d="scan'208";a="180058286" Received: from gklab-kleszczy-dev.igk.intel.com ([10.102.25.215]) by orviesa005.jf.intel.com with ESMTP; 16 Sep 2025 05:04:46 -0700 From: Konrad Leszczynski To: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cezary.rojewski@intel.com, sebastian.basierski@intel.com, Karol Jurczenia , Konrad Leszczynski Subject: [PATCH net v4 2/2] net: stmmac: check if interface is running before TC block setup Date: Tue, 16 Sep 2025 14:09:32 +0200 Message-Id: <20250916120932.217547-3-konrad.leszczynski@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916120932.217547-1-konrad.leszczynski@intel.com> References: <20250916120932.217547-1-konrad.leszczynski@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Karol Jurczenia If the interface is down before setting a TC block, the queues are already disabled and setup cannot proceed. Reviewed-by: Konrad Leszczynski Reviewed-by: Sebastian Basierski Reviewed-by: Cezary Rojewski Signed-off-by: Karol Jurczenia --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 7b16d1207b80..133ffdc91153 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6247,6 +6247,9 @@ static int stmmac_setup_tc_block_cb(enum tc_setup_typ= e type, void *type_data, struct stmmac_priv *priv =3D cb_priv; int ret =3D -EOPNOTSUPP; =20 + if (!netif_running(priv->dev)) + return -EINVAL; + if (!tc_cls_can_offload_and_chain0(priv->dev, type_data)) return ret; =20 --=20 2.34.1