From nobody Thu Oct 2 15:15:51 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A10172C3261 for ; Tue, 16 Sep 2025 04:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998104; cv=none; b=gPtuoIhVsVVmKzLiwFBrbgnAAK++Fkt6TV4z/fr/An8P5DYct/cws9XsFmyIOf6ixnd+EepaH22pj/Pbqu1kCxICAeWgaU5wltAOSFn0NtEjmtEU5JwQpSzxn+pKIQES59cidYbFSRnxapYxIOsxaAKjONlrgKBqLsxCtNK48oI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998104; c=relaxed/simple; bh=psJk8MWkw4yWUzhoGl6iC+/oKrIajPgKeNxYtGpbGJs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ph27U6nSo/E/fSMmLjOgT6bbcv0mvTBWa9cQKW/brKJR0BEmmxfUCXX2k7aD+/98JpYJRSDpEIt04Zdavt0jSfVvkV47pZqE2omCM7D5tyyxi+NClEYCO8u/3ojC8frSKLYvlaReh4bLx5jGw7u8lfJChazE9NuxOnxoMzG2nhI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UgiTKs98; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UgiTKs98" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-24456ce0b96so56441435ad.0 for ; Mon, 15 Sep 2025 21:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998101; x=1758602901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vOaEQ/7pID9TluLY7/w8zgk+8Z8ChedlXZfnOV6tq/0=; b=UgiTKs98TYt0zah/UeSi4De4R5qcPuP9nE+oBFiDNrhtI0JRukYpwBGkrD1qMj8YZJ zxAPGGH9qL2hIdPkF9Ps9Xnd7Jvxf/ZVlkbnd47UidqnLrPiaPttc/PPgcfGNO4KSZFH MII8pjx2Ab32A8kOPiHi/IVq0+PdVSk9AH6nKylqP4ciHrUFZteDTLfbAAMcPsfOW9/9 SxBLWNNbByPGH2KJGO4I8tQi++oIv91NAcecNWvFFImMV/zfHb4u5kUEiUYwITx8m6l+ PbhcI71UPtGbN3T10jjL7ELy4EIjkaG/PtU6I9mrth/K43lLg7JX0O8z0A9pbbonH3JS zeIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998101; x=1758602901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vOaEQ/7pID9TluLY7/w8zgk+8Z8ChedlXZfnOV6tq/0=; b=FrytnYCqSMig7vwrkxyrH1wsUeRx98wjS1MydX5x6zveozfYxnXG3XEfw9MDbvYeFJ tv+XPI5lHEXlu0BEVb9oH1OpcjSP/kHf0q1A57Hjia3IuUIxVr09/MmaYwBq3BQrOAdT Q5Hzj0WeoqUka2DA4giplInZgNaV1DBD7tESwTX+QNMsI7Ly6+zEdzeRd1+E++xcwoJ5 d+XSRtc402AOUiuyzEIJDqOTC+hU0Pc5HlXJlxB8mtm95VcyNDGEiEL0jAvSYJbkFC2T zO/AjCKNHHYSS5fv6OpLnsVvgabGqnnZ5H401e2tj0f0g3GkijJ+a3ylKR7YUH6Pb1y9 WSEw== X-Forwarded-Encrypted: i=1; AJvYcCWR2AD9xgbx86flsiuphJ1XL+L8CCYsM7fsdTcuRdWm8AxeX7aC7AGUeqy6wRld+/DAQhUIQY2tHIRzDMI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd3rRRjGqDthbwSxuNP6Alh9xlydZ5J1b5FxnM77o4uCjeVqmB dGmjVV8U+SP9QpkoOGzV70wcDoL54cUBUVVZMZow/mUkpbFbeqfVeGdl X-Gm-Gg: ASbGnctXHA1xmiIHNhqAFRTyDMcr89z5ppXCX/54GwavFneWQ6IHX4ikIkeDgJf+HTt X/hS/Nig+VlZDryKyFCuldI5YKCi1/IO9ACQGV3lGt31v8JUrcI2ZWLFr+akesZ4cbc4R9PvK5k xHQ94WEbSePGZVaKO9VNCMKZKNhYqRW/VWnD2njF0ZnwFiqSrGavcgFWI5uCe5pF+PKLoapN+Y+ pNzFcAqi9ymXHM2Wm2XzTKYbuF7ilfydF4NUHmn65+BpyWLb+rPtVMNseoiDL6zMoavxTA0e/rT gI9+oYzZv0Rkv8Tm+1ZD3siTpGv2EneRxIhtbDKev1OJriUnlFOU/8epTwlScmIhEBfCxr7s6ZO CmwRO8VfK6P6z8h50g6P5NXoU7L3V6T8ETy15MtA= X-Google-Smtp-Source: AGHT+IFncLMpEiSXyRV3g2udd9oLTip5CIZ6fjiDS7nm0eY3IrUPzgwzagMuf9PJuGmIj5O4nns0xw== X-Received: by 2002:a17:903:2f87:b0:249:71f5:4e5a with SMTP id d9443c01a7336-267d161e3b9mr10726455ad.26.1757998100825; Mon, 15 Sep 2025 21:48:20 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:48:20 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , "Rafael J. Wysocki" , Hanjun Guo , pengdonglin Subject: [PATCH v3 01/14] ACPI: APEI: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:22 +0800 Message-Id: <20250916044735.2316171-2-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side functio= n definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: "Rafael J. Wysocki" Cc: Tony Luck Cc: Hanjun Guo Signed-off-by: pengdonglin Signed-off-by: pengdonglin Reviewed-by: Hanjun Guo --- drivers/acpi/apei/ghes.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index a0d54993edb3..97ee19f2cae0 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -1207,12 +1207,10 @@ static int ghes_notify_hed(struct notifier_block *t= his, unsigned long event, int ret =3D NOTIFY_DONE; =20 spin_lock_irqsave(&ghes_notify_lock_irq, flags); - rcu_read_lock(); list_for_each_entry_rcu(ghes, &ghes_hed, list) { if (!ghes_proc(ghes)) ret =3D NOTIFY_OK; } - rcu_read_unlock(); spin_unlock_irqrestore(&ghes_notify_lock_irq, flags); =20 return ret; --=20 2.34.1