From nobody Thu Oct 2 15:16:47 2025 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC1F82EC08B for ; Tue, 16 Sep 2025 04:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998170; cv=none; b=pGCfFOjyiKoIj/VrdTmY8H0GwWSVoJfFa3ygClMy4K5zrqa0dPivevQz2zh1DtQIjRr5pLPNlY3XKReUsZmCHdKwQn3T/yTR2Qv/qpDFyo0hkbfQO0AjQ1PkH28M18mGcG08vRHT516rs4GWs9cnFf4qd0fYJg64nZSZgt4jQ/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757998170; c=relaxed/simple; bh=+qvXPu8HTVeRFaubIyM3rQFPhKws6qzYTh9yka49uSI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jx4IcYbfFeGrptGivEa7QgX6h11np9EKMsWcDUHJHHtLX7ONlPQEJb4evIGHIOccN+tLJdNnik4KlOu6RH0QoPrRuxY9XFaMaJ1qcFF21nEo/eCupsEC85BDU4NvTPEGS/wapsmEGZVWqdz3JjwxMqP/QTgI/menjEEGkrJb8lA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h23e2S6Y; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h23e2S6Y" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b54dd647edcso548517a12.1 for ; Mon, 15 Sep 2025 21:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998167; x=1758602967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zSw+5V18QQW1zrEulMj1oteRdmYU7Zw4RYS7vag/74M=; b=h23e2S6YBhzCpQQF+vf3PMKlnWyaXYUwO6oF/J1csVqE8vMSVBFHJPP2kFyA7mTnw6 QwnvilGcLAzZwk5dm9UBosQKS6iNp2CfPLVNNazBVsUUUJfAbDLJfrY+mfJQkUvtu3z1 zWQax3mYP1rICXuSyt9xs3gS4/ZaW0cCGP0shYpcIQA0XBLWLYOdGS2SU+OIMLgtd4+t B4N2aRUeDCv7XMX5ZYvbbFkYrMoh8OH7RWXOt/2ZQJzUw1ujVaB2Fx6RTQa2fB9o45cH XBGVenMM6TSDsWgpoWOuPERolaNznuaoeMDBjHfKZa46SDncBp6qxbnQ5Typ86pzizmn KHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998167; x=1758602967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSw+5V18QQW1zrEulMj1oteRdmYU7Zw4RYS7vag/74M=; b=K3LKOVXkKagyK83tE6yLvRbqbGw35EkPGSW2OA/RQKlA4I6ASR9y6sGO8p8NiKIb/D Dul3+iNXp/65eihLW2bXdd3WlLITd1jV9ZLLTVyXdj5OCfeHOxJOIDFtvknA/BAgkVbe PG505R9DE3sCCpUTvhlS7CBTYWuZCCy2xab60OjN4uGLc2pxzpwA5LdYzJCeO/EYeGw6 1XRyMbRlnqdQmsoo3hGuXDPBbrQAHGQjDPpH78HEknQHWyhudhqh3VilKtH+8CqPuIGn +xdRWePuqg2ToTHCYQVZzoOKF2zHaiOje5tEh+a/zlOPUX1qZl8SODM8kPG+0Pk4zdYc Hvhw== X-Forwarded-Encrypted: i=1; AJvYcCVUoIQQ03oqHcApfou05HmM+R0its66EVfyxB3Za1mpMKHNuo/D2yBUyCN7FYBFYFRg/94AT44pvbahTqI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4a9miSaxKb9oGwUImuqQa5XRTeQFlS0V2Pii+VOCcvoWMKWMV y9YHXNrlKE/h7xrASyzNkkoWspSxgoWo9yozjvm30KwM64ksrAhJYg9W X-Gm-Gg: ASbGncvGF9JKhaXwA8KO81oz4djSduvoVr3ChxT8xuyAhlZg8SFi0IePwVxi/gnDu6B mrPOBzuuQ/7N04T1uAAmi3Iwzste3beaxdqe8FboRwtWM1tQ3StqI87qNaUcWwIv2STSfXQMHF8 9pA0GiLvYcZLRbdAqZ59qiDc8a3hOVD60qQFcBh5fkNFYhIcX/lvCRJRj6cKDNBaMBj+MaFrmhN fQ3qZs0qWF9DMrEHmjOsuix1S6Hte4Hq4mowi0KOSjBpTDDmQVO+DFBcJIbmQwxi8/6Qki64SXB KiE4ThU0f+Sfg9I+tPaZzZVV7s4GQeNpH1AlSIUJXTG89SO8pO2Oi95Ft4ujj3wM/tFjSG6XbZ7 00HyUwBrZTId/jXpJeV9hg09GJ9wl5vbL0qsy+HQ= X-Google-Smtp-Source: AGHT+IFoVKHWE4WmC5NQoAJgz5S3HoMpNrjT8PBpaSw1vdAI3yXeG2nG2SQAkLHZCeabG5ejGwx28A== X-Received: by 2002:a17:902:ea10:b0:24e:bdfa:112b with SMTP id d9443c01a7336-25d289e9988mr159622635ad.61.1757998167045; Mon, 15 Sep 2025 21:49:27 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:49:26 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Samuel Mendoza-Jonas , Paul Fertser , pengdonglin Subject: [PATCH v3 11/14] net: ncsi: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:32 +0800 Message-Id: <20250916044735.2316171-12-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side functio= n definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Samuel Mendoza-Jonas Cc: Paul Fertser Signed-off-by: pengdonglin Signed-off-by: pengdonglin Reviewed-by: Paul Fertser --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 446e4e3b9553..6e36cd64a31e 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -650,7 +650,6 @@ static int set_one_vid(struct ncsi_dev_priv *ndp, struc= t ncsi_channel *nc, =20 spin_lock_irqsave(&nc->lock, flags); =20 - rcu_read_lock(); list_for_each_entry_rcu(vlan, &ndp->vlan_vids, list) { vid =3D vlan->vid; for (i =3D 0; i < ncf->n_vids; i++) @@ -661,7 +660,6 @@ static int set_one_vid(struct ncsi_dev_priv *ndp, struc= t ncsi_channel *nc, if (vid) break; } - rcu_read_unlock(); =20 if (!vid) { /* No VLAN ID is not set */ --=20 2.34.1