From nobody Thu Oct 2 17:00:07 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B982F2914; Mon, 15 Sep 2025 09:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757927697; cv=none; b=GQegvdpLLZcZaSZLvUAAYtf4iE+dN+SHaAM7IgnN9jPTwNmvnOIq4EpzcKWlN/453hvFx9KZXzQPIsV8GT/ZxxCxeuMeiypT4N5Y37kqCZ9Ak4EpRtsFatWcBo6utr+Ks2bR9V/uetOQ6TODK0asBbp5zQpxWvhCtgQXgt+0+YQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757927697; c=relaxed/simple; bh=1+6Fv0qxouEzFgCczwmS+CHk+F/6UXgZ5FbJQnoSQiI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=QyU6zUY+KHhQ8TLr99TnjVFGM66n8/o/hggmpJFUewW4qSDedmcU2uBotSyw2meyzyYR8/v7N2tkq1a1iWpHj0aGcvFBC4NlIHVUV01NEHCuYrkX2ETPqGwECTPq3MpNxXplxtcNBq5CvNs2OoSgMVorXYc5xN8HxIxFESCnRJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HnLubFCa; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HnLubFCa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757927696; x=1789463696; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1+6Fv0qxouEzFgCczwmS+CHk+F/6UXgZ5FbJQnoSQiI=; b=HnLubFCasvw5tqdrBPKArMEev+/C3K2g3J38/pxfBGcp2vQefO26zZDQ WlzefTDiLiRZB19shvII0msp8/9uf4/0Ps9bBY/uiZ62dRi2EXTQzFX3h I3tDz9UxMscmhqWBOj8IwRB2O7J1M8jRwhpsa5+AkiG2EdXwBdaCZaXD/ 7TLDGW3dx58qbrbvosdpzPosnZ5TDU+N/OUkIVTqNc7EQBbhajciACCq5 XNJVGFbgWn1UAYVIfHubnb0T6efVhcGmfMzOnQiCSexiTLI9Wa/GbyxRD jQsJxQrSJYyQcTZwZOtOD3DmsQNlqFzbkYthht1Bj16fTzpXhK3dJ3sqm A==; X-CSE-ConnectionGUID: bkrBb66tQ3S/BPCXhWOUtQ== X-CSE-MsgGUID: fpD7235yTuGmcpZF5iy5aQ== X-IronPort-AV: E=McAfee;i="6800,10657,11553"; a="82764130" X-IronPort-AV: E=Sophos;i="6.18,265,1751266800"; d="scan'208";a="82764130" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2025 02:14:56 -0700 X-CSE-ConnectionGUID: 9p4wvxzCTjSTRXPNbUs6gg== X-CSE-MsgGUID: pO2yxNeVQzCC0NO0XMHi+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,265,1751266800"; d="scan'208";a="173860751" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.39]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2025 02:14:47 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-pci@vger.kernel.org, Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , =?UTF-8?q?Christian=20K=C3=B6nig?= , =?UTF-8?q?Micha=C5=82=20Winiarski?= , Alex Deucher , amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Lucas De Marchi , Rodrigo Vivi , Simona Vetter , Tvrtko Ursulin , ?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , "Michael J . Ruhl" , linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v2 03/11] PCI: Move pci_rebar_size_to_bytes() and export it Date: Mon, 15 Sep 2025 12:13:50 +0300 Message-Id: <20250915091358.9203-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250915091358.9203-1-ilpo.jarvinen@linux.intel.com> References: <20250915091358.9203-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable pci_rebar_size_to_bytes() is in drivers/pci/pci.h but would be useful for endpoint drivers as well. Move the function into rebar.c and export it. In addition, convert the literal to where the number comes from (PCI_REBAR_MIN_SIZE). Signed-off-by: Ilpo J=C3=A4rvinen Reviewed-by: Christian K=C3=B6nig --- drivers/pci/pci.h | 4 ---- drivers/pci/rebar.c | 12 ++++++++++++ include/linux/pci.h | 1 + 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index f1b30414b2f1..3d5068d6e195 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -929,10 +929,6 @@ void pci_rebar_init(struct pci_dev *pdev); void pci_restore_rebar_state(struct pci_dev *pdev); int pci_rebar_get_current_size(struct pci_dev *pdev, int bar); int pci_rebar_set_size(struct pci_dev *pdev, int bar, int size); -static inline u64 pci_rebar_size_to_bytes(int size) -{ - return 1ULL << (size + 20); -} =20 struct device_node; =20 diff --git a/drivers/pci/rebar.c b/drivers/pci/rebar.c index 95e00d8e0c89..0c943d9e3a08 100644 --- a/drivers/pci/rebar.c +++ b/drivers/pci/rebar.c @@ -35,6 +35,18 @@ int pci_rebar_bytes_to_size(u64 bytes) } EXPORT_SYMBOL_GPL(pci_rebar_bytes_to_size); =20 +/** + * pci_rebar_size_to_bytes - Convert BAR Size to bytes + * @size: BAR Size as defined in the PCIe spec (0=3D1MB, 31=3D128TB) + * + * Return: BAR size in bytes. + */ +resource_size_t pci_rebar_size_to_bytes(int size) +{ + return 1ULL << (size + ilog2(PCI_REBAR_MIN_SIZE)); +} +EXPORT_SYMBOL_GPL(pci_rebar_size_to_bytes); + void pci_rebar_init(struct pci_dev *pdev) { pdev->rebar_cap =3D pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_REBAR); diff --git a/include/linux/pci.h b/include/linux/pci.h index 894e9020b07d..6f0c31290675 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1421,6 +1421,7 @@ void pci_release_resource(struct pci_dev *dev, int re= sno); =20 /* Resizable BAR related routines */ int pci_rebar_bytes_to_size(u64 bytes); +resource_size_t pci_rebar_size_to_bytes(int size); u32 pci_rebar_get_possible_sizes(struct pci_dev *pdev, int bar); int __must_check pci_resize_resource(struct pci_dev *dev, int i, int size); =20 --=20 2.39.5