From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838D22F0C5B; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=eGezbd/yPqoXEF1bebWdLAdmQsRWBqrMQ/QzKOxc/IUWY+l5jfaRcgJSuev95Sak0s/kTg7U+3/PzVBHd5HgdlnBM4jyyoR6Z+9R/p6a7Qyxn9W948wrcUj7OskS5v5ICBG970FQ3CK9+z0FUTwwMLqa0ZkTn6b1VCde+yP42GQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=Yr+RgLN3Vap9mjogsRQGWKdmsM2xbbmuwitsD5UlBqk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lOmmR2Wk444Ri+4grZynQqubH6Rrz5TJPgea5FGSVAwfCYmKdzSe0RI5cd5p2sCmZCH5g2j9YKhYL4Sxb3eetODY2UUTVN1narXVHLJdWoyHccFcvfmqpEaQTpBMpG9DdywwdCvoYRVpmccF1L47+sWedhdMSkSvQ0pf+rNRPgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tdo0Ux+t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tdo0Ux+t" Received: by smtp.kernel.org (Postfix) with ESMTPS id 08D13C4CEF9; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=Yr+RgLN3Vap9mjogsRQGWKdmsM2xbbmuwitsD5UlBqk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Tdo0Ux+taQme3/yFpM4sPQkcWlQe9krUfsyNrDQf5iPGLYhASxre/qi/J/5t2Tmb0 B2A9lofOmonkSY/m0BmTOCybwCbhgrA6X/2Bqv1VhuudwRIbT7CyvGWBzJ9oZ6khfS a6KbBdLdSsQO6vdxqC/M6nLOMnSpmWLiOY7/WA+n6nANVf+Na8Cu7Xn8sBFxFBnVCZ vCtb5hA0WYwS9dmmQiOx8rnQM7/3QOmmHUoItqR2N6ez9g45iZdfZWBb9BKOL5epcd 3URF7QJV+3xCDNfCXAAkkSlyLYuej1fo0OBrAc9miG5zZzWHIqApDR0uOWVHJfFIy5 yK7Xpe21uj6uw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D78CAC597; Mon, 15 Sep 2025 08:50:13 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:53 +0800 Subject: [PATCH v4 1/8] power: supply: core: Add resistance power supply property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-1-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=2917; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=yLQp6yJehiZBpFT5IxDtU3pReZwpxFlv7BCVLt8iMb8=; b=LJsm57i6alMaYbJDGVtZlO8QXWyrUFYgdK16Fgaxp16LLryYwTupxARcUe9gxWSMDVewwjZQB kTmE4nLhA+YCAnRpkMUOVkN0voyaptJHzDvOAegda/bP3x74LXwy6fV X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Some battery drivers provide the ability to export internal resistance as a parameter. Add internal_resistance power supply property for that purpose. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- Documentation/ABI/testing/sysfs-class-power | 16 ++++++++++++++++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h | 1 + 3 files changed, 18 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/AB= I/testing/sysfs-class-power index 560124cc31770cde03bcdbbba0d85a5bd78b15a0..cea1a38f5a8fb754d4e6323967e= f6cf2e20a68ce 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -552,6 +552,22 @@ Description: Integer > 0: representing full cycles Integer =3D 0: cycle_count info is not available =20 +What: /sys/class/power_supply//internal_resistance +Date: August 2025 +Contact: linux-arm-msm@vger.kernel.org +Description: + Represent the battery's internal resistance, often referred + to as Equivalent Series Resistance (ESR). It is a dynamic + parameter that reflects the opposition to current flow within + the cell. It is not a fixed value but varies significantly + based on several operational conditions, including battery + state of charge (SoC), temperature, and whether the battery + is in a charging or discharging state. + + Access: Read + + Valid values: Represented in microohms + **USB Properties** =20 What: /sys/class/power_supply//input_current_limit diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supp= ly/power_supply_sysfs.c index a438f7983d4f6a832e9d479184c7c35453e1757c..cfa8f90a88ebc8fc1c7447198f1= 38e5d2e699e5a 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -220,6 +220,7 @@ static struct power_supply_attr power_supply_attrs[] __= ro_after_init =3D { POWER_SUPPLY_ATTR(MANUFACTURE_YEAR), POWER_SUPPLY_ATTR(MANUFACTURE_MONTH), POWER_SUPPLY_ATTR(MANUFACTURE_DAY), + POWER_SUPPLY_ATTR(INTERNAL_RESISTANCE), /* Properties of type `const char *' */ POWER_SUPPLY_ATTR(MODEL_NAME), POWER_SUPPLY_ATTR(MANUFACTURER), diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index c4cb854971f53a244ba7742a15ce7a5515da6199..8bc3b7a67eb5693a16db9b7d123= e7881711c6bf4 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -174,6 +174,7 @@ enum power_supply_property { POWER_SUPPLY_PROP_MANUFACTURE_YEAR, POWER_SUPPLY_PROP_MANUFACTURE_MONTH, POWER_SUPPLY_PROP_MANUFACTURE_DAY, + POWER_SUPPLY_PROP_INTERNAL_RESISTANCE, /* Properties of type `const char *' */ POWER_SUPPLY_PROP_MODEL_NAME, POWER_SUPPLY_PROP_MANUFACTURER, --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 837F52F0C48; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=ToS5W0+Qg+tb/AhahbPzi92V/fA15ax/mCqsWHVCoQ4Sy6C1+CqAoM6T2Qlm9H1lVHJqsJx8tG+tIWr/bGoGt3uB9/BzG/hovKKGXTglDDROc071DUCe4sPBVXoMuONHZwBzv5hI2g22OHgCttPS/xmOg9dGsn196C+/2hnqfww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=UyVkt9kgZ1dAVjpRzQO7orB5FMJYrIW9UO+mYwY2znA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nFHTcqpQ8g5EvwUPUKMRsS2szPIqIV6dww8HSumEhI8jQfNINNLVmAL8bcOtAp78eSmccdurt8P/JAXXlUM/wKA4Qz1N8LTqQLopSXDRf0CKgJOK182fUUPmNmz1aGT1DRvq5X1CvJaZi/zr/W1475GgGQICxsTBll1jKTE+YjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PLmxamwW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PLmxamwW" Received: by smtp.kernel.org (Postfix) with ESMTPS id 15A85C4CEFD; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=UyVkt9kgZ1dAVjpRzQO7orB5FMJYrIW9UO+mYwY2znA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=PLmxamwWn/hDhDjiZVrgW+KiB19atIbeggA8rIvHaxwaCJdpcGCBSRoC9SEqa9vtf Qym6iK1QLFfPlfqJ9kBrLC9BcEABl1zc6mi62pUfeqwRfEloEZHDVzg+XAjx3HR5dn y1fLF3S91CA8MMbbqPV5oPlUybsaebhMlranXuuA99z+eaVB/1HRMv2rRiHx65f3YK aK/mOwCSDzfKMxCc52hbht8/lVSZB+jDKA80fgEstkdEqchr3DFFIoE8DxTHQrJuCx wTMqeFzIFL3O6z6XQLvbSnL4W1trGmrniROD5IOFpOPiddeuQmlSIk+WhKJ+OvLRkP w4oHnEwM0v1LA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E4ECAC599; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:54 +0800 Subject: [PATCH v4 2/8] power: supply: core: Add state_of_health power supply property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-2-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=2731; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=yg7P5kRYu2rRp9PC3aRwe0HnoeoxRVLkEnVF92HMtnY=; b=Kn2a5HBOPLrP4lN/WQeRIeH+VK6UHKv9R0pKGMPuGos1SlnOzzkmCZcJ2C7PQqjZYbwGosVok MG6cD7/mIsxA5OiX4pCjZU+Ht1qWNISSu5DMXuOwMbM/Eu/XBxSSUvt X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add state_of_health power supply property to represent battery health percentage. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- Documentation/ABI/testing/sysfs-class-power | 15 +++++++++++++++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h | 1 + 3 files changed, 17 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/AB= I/testing/sysfs-class-power index cea1a38f5a8fb754d4e6323967ef6cf2e20a68ce..04f82e3e33aad6e16dc4fbace06= 6b5d26069bf44 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -568,6 +568,21 @@ Description: =20 Valid values: Represented in microohms =20 +What: /sys/class/power_supply//state_of_health +Date: August 2025 +Contact: linux-arm-msm@vger.kernel.org +Description: + The state_of_health parameter quantifies the overall condition + of a battery as a percentage, reflecting its ability to deliver + rated performance relative to its original specifications. It is + dynamically computed using a combination of learned capacity + and impedance-based degradation indicators, both of which evolve + over the battery's lifecycle. + + Access: Read + + Valid values: 0 - 100 (percent) + **USB Properties** =20 What: /sys/class/power_supply//input_current_limit diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supp= ly/power_supply_sysfs.c index cfa8f90a88ebc8fc1c7447198f138e5d2e699e5a..d96a8578308e3af60cc1a352845= 662aa922c29b3 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -221,6 +221,7 @@ static struct power_supply_attr power_supply_attrs[] __= ro_after_init =3D { POWER_SUPPLY_ATTR(MANUFACTURE_MONTH), POWER_SUPPLY_ATTR(MANUFACTURE_DAY), POWER_SUPPLY_ATTR(INTERNAL_RESISTANCE), + POWER_SUPPLY_ATTR(STATE_OF_HEALTH), /* Properties of type `const char *' */ POWER_SUPPLY_ATTR(MODEL_NAME), POWER_SUPPLY_ATTR(MANUFACTURER), diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 8bc3b7a67eb5693a16db9b7d123e7881711c6bf4..ccb43fe44381965069dc3bd9505= d45050b9b1bd8 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -175,6 +175,7 @@ enum power_supply_property { POWER_SUPPLY_PROP_MANUFACTURE_MONTH, POWER_SUPPLY_PROP_MANUFACTURE_DAY, POWER_SUPPLY_PROP_INTERNAL_RESISTANCE, + POWER_SUPPLY_PROP_STATE_OF_HEALTH, /* Properties of type `const char *' */ POWER_SUPPLY_PROP_MODEL_NAME, POWER_SUPPLY_PROP_MANUFACTURER, --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838612F0C52; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=qwdsjIWUKexGVkpEHN8V/V0bM8UoqUaz02exKNcC+LglVz4U+mP8GEsy5WkPP7c+WdNBsPwmnTU7UKIeN03MAr849RbY41OhYGVoS1m2rWfFJt1cAi0pGZzcE6uHIhMYfz9PWWi4pbUsQqw4STuR4zLxWF3DHLmBqApJf5OKpFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=RwF7eMX1nZ8p+S5/F/PMsjeqGTLxB+0i/FZbAx2z01k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BwygIoAINbA12eN6il+sDxB7njdx4lAtM15Md41SrVEe3jViv+ziGG19Zu8H8HiAXsZQHelhLw6HtInlcsuWL5WZBptHjrMxkn2ZNbETDVwcKqDF7fD253YJ8yMAXpU9AlYjU3NlMa5CaQGrQweTFVhnEWR/ohcrOr/BA+YuiJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nyl0QFtt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nyl0QFtt" Received: by smtp.kernel.org (Postfix) with ESMTPS id 28A4DC4AF0B; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=RwF7eMX1nZ8p+S5/F/PMsjeqGTLxB+0i/FZbAx2z01k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nyl0QFttrw/s0vbqNGODx4hv5yNob/Z0bsB6QOHkqR664158rajY+PRdMetsu+N3M f0VnfkcjEZ6mdPR8iydairmtvu3Dhycs2XTXDK4aMmpTkwlcDFL4kMxzXxDZHwS11e ejnFeAPYHZaXODwZW/GQEs9+gvamd05S1G/kwQzEfE95Eh2JRu+ycEs2BXbar1eR2z HPX0SCsZlwObxbyxZrInPhUaV3QcnSU12gsveHLc96lhF8zThzvK1acwT2NOh3sRjK omiBubbXAF96s+xpM7UhvtJpD62QxyuQ9eQ7VB15gAYTQL4kwy6A/0MUDWb1MnaWsN T+sffR/RwaZ9g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131A1CAC598; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:55 +0800 Subject: [PATCH v4 3/8] power: supply: qcom_battmgr: Add resistance power supply property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-3-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=2552; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=OQgd2W4o/rV8XW+P2dEYESDwonjckeDW+a75iXfgrNE=; b=m9Y49dtk+T+Sbp6QODq3a2bJ+WmTVL5YUTEdrlBQLSszbTukWLjh7UHFJZKWl+OSqVSLHGL1Z 9jqn9Tf8/D7BKj/wPqia4ptMcamPbXa1r/jNoiGRt1e7EOZOb953g0W X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add power supply property to get battery internal resistance from the battery management firmware. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- drivers/power/supply/qcom_battmgr.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qco= m_battmgr.c index fe27676fbc7cd12292caa6fb3b5b46a18c426e6d..55477ae92fd56ede465b32d6f7e= d9da78ebd869c 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -2,6 +2,7 @@ /* * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. * Copyright (c) 2022, Linaro Ltd + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. */ #include #include @@ -254,6 +255,7 @@ struct qcom_battmgr_status { unsigned int voltage_now; unsigned int voltage_ocv; unsigned int temperature; + unsigned int resistance; =20 unsigned int discharge_time; unsigned int charge_time; @@ -418,6 +420,7 @@ static const u8 sm8350_bat_prop_map[] =3D { [POWER_SUPPLY_PROP_MODEL_NAME] =3D BATT_MODEL_NAME, [POWER_SUPPLY_PROP_TIME_TO_FULL_AVG] =3D BATT_TTF_AVG, [POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG] =3D BATT_TTE_AVG, + [POWER_SUPPLY_PROP_INTERNAL_RESISTANCE] =3D BATT_RESISTANCE, [POWER_SUPPLY_PROP_POWER_NOW] =3D BATT_POWER_NOW, }; =20 @@ -582,6 +585,9 @@ static int qcom_battmgr_bat_get_property(struct power_s= upply *psy, case POWER_SUPPLY_PROP_TEMP: val->intval =3D battmgr->status.temperature; break; + case POWER_SUPPLY_PROP_INTERNAL_RESISTANCE: + val->intval =3D battmgr->status.resistance; + break; case POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG: val->intval =3D battmgr->status.discharge_time; break; @@ -665,6 +671,7 @@ static const enum power_supply_property sm8350_bat_prop= s[] =3D { POWER_SUPPLY_PROP_MODEL_NAME, POWER_SUPPLY_PROP_TIME_TO_FULL_AVG, POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, + POWER_SUPPLY_PROP_INTERNAL_RESISTANCE, POWER_SUPPLY_PROP_POWER_NOW, }; =20 @@ -1174,6 +1181,9 @@ static void qcom_battmgr_sm8350_callback(struct qcom_= battmgr *battmgr, case BATT_TTE_AVG: battmgr->status.discharge_time =3D le32_to_cpu(resp->intval.value); break; + case BATT_RESISTANCE: + battmgr->status.resistance =3D le32_to_cpu(resp->intval.value); + break; case BATT_POWER_NOW: battmgr->status.power_now =3D le32_to_cpu(resp->intval.value); break; --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 837832F0696; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=fHMTs1cr9T2a5EQUIWIWO48wD3LKlS8Q2zzmuhc5xrNsDIGH2y5Ft4nG9OIy0CyMoa4XiKHQht1f/gy6gxqEPJLCn3dGX/wv3+H7VbN25o3Q4czP5kDMOW2Q/4DVt0PE6unN1Ca79uNAj7Mzj+ywJuQ6cFoIBP9AAuLrcUvWU+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=W+b8h6Qxt10qDCCb1XrQIJLibkuQUcej5ptibTlODKI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NbuSYXuLXmqCCHdg3Ur82mx71i3VT2Tur9rWrWiUekx0lB3FCM2mIwDrBXoI6DFf6sNjwOorY8OggBPdI2dGZxZiV6EQ7bKRo4nPSNHIPbDSB1a4t2fyf0gZQnafRuAdw/48C5D5DoWYqWSF3nOIPvFWThN1u+PRUlOerqqGj8c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ruCcniRt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ruCcniRt" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2E0C5C16AAE; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=W+b8h6Qxt10qDCCb1XrQIJLibkuQUcej5ptibTlODKI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ruCcniRt/eRvs164a66R1kQQNyLWBh3oCjYhYm1n8TVjWrsr2z2XKSe1+5vH/GRp3 7HOaaSikj6lz84KEmlWac5VRFGl6OD9Vjlz5SntF+uLK1btWcqphgRz9iYaoKO67cU i20W/uV2I1tTaF4+IVL54euISpm2mZgk8Qu8L+OkXLOL/2NM8jd1rhoIm5WbepnEYC AbidNhuZTXeEfV49OqD+XtK1mQ7wxwi8wvz0PfGY1SifgarlND9xqlQHtK6CGVJWzE JCE7obb2f9hY7h23lpaBXmf6szlGFeHQpbU98nkTBqFfFDStPEl22vHzndZTI29PVa vGSkPHaLPAAmg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224C7CAC59A; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:56 +0800 Subject: [PATCH v4 4/8] power: supply: qcom_battmgr: Add state_of_health property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-4-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=2278; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=VIN2pXk/U1+wm3Thq8v/fKUD3hKeRjRBB653GlANfdk=; b=Ox21fema1o1mrdUdH2t3LlgNM+skvt0wpjfURX8IBrf2Ta9Iv+7KqncS380cQJOUHifFy7uao KPEZgenQYPoDyIvke0TiPZksVedf0I1rWLa/CopiRCUnt+jJkFNKtQf X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add state_of_health property to read battery health percentage from battery management firmware. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- drivers/power/supply/qcom_battmgr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qco= m_battmgr.c index 55477ae92fd56ede465b32d6f7ed9da78ebd869c..008e241e3eac3574a78459a2256= e006e48c9f508 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -256,6 +256,7 @@ struct qcom_battmgr_status { unsigned int voltage_ocv; unsigned int temperature; unsigned int resistance; + unsigned int soh_percent; =20 unsigned int discharge_time; unsigned int charge_time; @@ -421,6 +422,7 @@ static const u8 sm8350_bat_prop_map[] =3D { [POWER_SUPPLY_PROP_TIME_TO_FULL_AVG] =3D BATT_TTF_AVG, [POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG] =3D BATT_TTE_AVG, [POWER_SUPPLY_PROP_INTERNAL_RESISTANCE] =3D BATT_RESISTANCE, + [POWER_SUPPLY_PROP_STATE_OF_HEALTH] =3D BATT_SOH, [POWER_SUPPLY_PROP_POWER_NOW] =3D BATT_POWER_NOW, }; =20 @@ -588,6 +590,9 @@ static int qcom_battmgr_bat_get_property(struct power_s= upply *psy, case POWER_SUPPLY_PROP_INTERNAL_RESISTANCE: val->intval =3D battmgr->status.resistance; break; + case POWER_SUPPLY_PROP_STATE_OF_HEALTH: + val->intval =3D battmgr->status.soh_percent; + break; case POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG: val->intval =3D battmgr->status.discharge_time; break; @@ -672,6 +677,7 @@ static const enum power_supply_property sm8350_bat_prop= s[] =3D { POWER_SUPPLY_PROP_TIME_TO_FULL_AVG, POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, POWER_SUPPLY_PROP_INTERNAL_RESISTANCE, + POWER_SUPPLY_PROP_STATE_OF_HEALTH, POWER_SUPPLY_PROP_POWER_NOW, }; =20 @@ -1141,6 +1147,9 @@ static void qcom_battmgr_sm8350_callback(struct qcom_= battmgr *battmgr, case BATT_CAPACITY: battmgr->status.percent =3D le32_to_cpu(resp->intval.value) / 100; break; + case BATT_SOH: + battmgr->status.soh_percent =3D le32_to_cpu(resp->intval.value); + break; case BATT_VOLT_OCV: battmgr->status.voltage_ocv =3D le32_to_cpu(resp->intval.value); break; --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E772EFDB6; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=ir/4IVv3dFwVm4+y5xZUbSamYZkOsmgX+XulOXo8eESa9VFn778BLKcwJC7XnAiqj03PWzBTZe7cv9mGKtpsZuFojMQ2z2u970tGD+f1Q+OIQhVU11/FrfNSRMi/D84mlWbnwXv2s7Iif/Xz7OZNcV201M2nsYDgMOqXv17qYBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=tsehSsRduiMLDfiK/ZnPvndOdLHJ35iXTLk0fVXPvZ8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kpkkBsmZClAwj44vT4L4ZG6BKHnIr0P5GVqYhbwUrfQhi+9hqm+KZouynUj04k19bOn1Aa8bUbfos8NpPenlw6IFuuminlf78tmYcPlEG1JlejHAJVyOg8asuvQ4JHbHMYxIBOZYty9fqLglF1cEL7434CBLeErYaycRpfIKgVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jGFodUPl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jGFodUPl" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3BCC5C19424; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=tsehSsRduiMLDfiK/ZnPvndOdLHJ35iXTLk0fVXPvZ8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jGFodUPltni9TE92IoXukDoawV5kZ8cZ6KkOi4JSoHCkhUGryxvRbMf1qYRm6QIiK MvX43WeLq2kOWu6W/H/IqvEHx2o2UwQlI4iwNLHAlj5qMzkUIjK349irCs02tY9KtW QBoF27VLsN3yzstB9zpXE5KV7McSMt06EscfABJX6xjxUm6JOeT9HQ6xFu9pKfyhoF pkxIvHMZNTlacetbtwRZYta8HHWMgg2qrXb3++ECSNRp1Kq4QfQ3sAylz5Okif1ZGS z09lC+7XQjn6LgM2vOeK53vMrybik31URzFEZdTnjlaJuSCvf24SYrVVWMPs2WAxj1 MjiCJqO/JMmuw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EDCCAC599; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:57 +0800 Subject: [PATCH v4 5/8] power: supply: qcom_battmgr: update compats for SM8550 and X1E80100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-5-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=1658; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=Padek38N2d5tUa3CUkX9jyBikXlN/Pbraz4T8Ku3qcU=; b=I2tXllxxFJiZp1PUs2ZXAd6+fCURDDMuR+9uSp9oDmD2Tsk4GEidsm/gxEWwTp7rsC5RoNMHo EIJAKUQ91JFDkmHXp0ELnNtx3haCRxlQtBI3QzjBsr8ZOOF2X1L7xXt X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add variant definitions for SM8550 and X1E80100 platforms. Add a compat for SM8550 and update match data for X1E80100 specifically so that they could be handled differently in supporting charge control functionality. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- drivers/power/supply/qcom_battmgr.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qco= m_battmgr.c index 008e241e3eac3574a78459a2256e006e48c9f508..174d3f83ac2b070bb90c21a4986= 86e91cc629ebe 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -19,8 +19,10 @@ #define BATTMGR_STRING_LEN 128 =20 enum qcom_battmgr_variant { - QCOM_BATTMGR_SM8350, QCOM_BATTMGR_SC8280XP, + QCOM_BATTMGR_SM8350, + QCOM_BATTMGR_SM8550, + QCOM_BATTMGR_X1E80100, }; =20 #define BATTMGR_BAT_STATUS 0x1 @@ -1333,7 +1335,8 @@ static void qcom_battmgr_pdr_notify(void *priv, int s= tate) static const struct of_device_id qcom_battmgr_of_variants[] =3D { { .compatible =3D "qcom,sc8180x-pmic-glink", .data =3D (void *)QCOM_BATTM= GR_SC8280XP }, { .compatible =3D "qcom,sc8280xp-pmic-glink", .data =3D (void *)QCOM_BATT= MGR_SC8280XP }, - { .compatible =3D "qcom,x1e80100-pmic-glink", .data =3D (void *)QCOM_BATT= MGR_SC8280XP }, + { .compatible =3D "qcom,sm8550-pmic-glink", .data =3D (void *)QCOM_BATTMG= R_SM8550 }, + { .compatible =3D "qcom,x1e80100-pmic-glink", .data =3D (void *)QCOM_BATT= MGR_X1E80100 }, /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ {} }; --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED8442F5469; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926218; cv=none; b=MpkrBOdG820qzq5nD7NgiTCFZUwG+aExleRDp330iGFtOMypjJIwnrS0BeS6xYVjc7S+qLJpUgDzuSSHBJJKR/qEhvq4if6qM6P3RoBbOEqmL8z2jMo5+YYTKPeNcI8TV96WTVM7QIF8DA793po3vwOZesae0GSkBbBYTpVqtyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926218; c=relaxed/simple; bh=BeB7zw1Yr47qwTix1CPy5qpweNbSDIpz6FPY8JF38uY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h1zaufd8t0nM1wG3b4fNx9yXa6++g3eJI52GS3wfg0DJdxaZwMhJqYYgtpdgPPkS3K7tm/QNV9HRwtImA5nYUZDHrfbGyxHVExA5OZb9Y782txa2/Co2GGLcNpE0pByTd9I0qE1CqljOx9xgKdiM9CzKbtrHEjtOVD48rGYtk+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GtW/eqqH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GtW/eqqH" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4C38DC2BCAF; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=BeB7zw1Yr47qwTix1CPy5qpweNbSDIpz6FPY8JF38uY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=GtW/eqqHcWMfuBt5NIeXV7+iQeOo2iS0uYe1NTnn5W3x5FO0PcRCyph/jznGySKK0 NUdElzPv0A+QAs+ziaY7mn25e8r6RhTCoqsy6WSW1SVWt9EcR5Hgn9sm95XAaAbivq R1lkIzOeaBu32YjyuodbDbx8Lo9uywGsskFP1rgYZEb/0Unr6TAobOYdl10niFjPVV E4pSOK6x7Ax5nXaZtjsVRQY9ftdX82qv8T8ciZl1d04Ji5EelZlI0Vo9PsEoYAh5X+ uG+bsFupJjndZ9F9XS2H9FtBtc56VUcsGSEjnJp6wKDmVtI223ZD0QUMKOauBBxIzT r+PSltpPheQiA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D66CAC58E; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:58 +0800 Subject: [PATCH v4 6/8] dt-bindings: soc: qcom,pmic-glink: Add charge limit nvmem properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-6-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=1571; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=r0dveNAduFjQEgggFyZyipCDUyI6ungTfqPcc80RgpY=; b=vTv8yPMPxWkB/XQII+CiZBVMu6B2WX4XZ1krRRGU4nWjaiZJhpzXimt6M8/MWqHaUx1u4VlU8 zY2ukDgtkDECHaQ2UA16dj81HIz35NOXBOmEgmMPLHCfE3kMPBLRsk1 X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add nvmem properties to retrieve charge control configurations from the PMIC SDAM registers. Acked-by: Rob Herring (Arm) Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 14 ++++++++++= ++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yam= l b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml index 4c9e78f29523e3d77aacb4299f64ab96f9b1a831..9d6db4825da389aa14d77f653d2= f8a3442e22162 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml @@ -55,6 +55,20 @@ properties: The array should contain a gpio entry for each PMIC Glink connector,= in reg order. It is defined that GPIO active level means "CC2" or Reversed/Flipped= orientation. =20 + nvmem-cells: + minItems: 3 + maxItems: 3 + description: + The nvmem cells contain the charge control settings, including the c= harge control + enable status, the battery state of charge (SoC) threshold for stopp= ing charging, + and the battery SoC delta required to restart charging. + + nvmem-cell-names: + items: + - const: charge_limit_en + - const: charge_limit_end + - const: charge_limit_delta + patternProperties: '^connector@\d$': $ref: /schemas/connector/usb-connector.yaml# --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B33342F0C76; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=fFEPLCP39DQm9Y7xUMYzZdl5k9h2TLLts0xcZPo6rnrQlslY12BOLAeCZWfGR+NBSbpvRaZHrX9OqFigKt5iZHfX9v24DDXJoiaE1+xf7mtL46mIUHdRkxgNV+lGEF8CMl5sfLFJhhInQHth0pEZFcgeXBurnJCQhd2vfbEttuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=PS+mr7iO0a5jdtYd0VaFNs9GMsJ2dXsHIT12WNpcsMM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t/9F1AOmKPHn5e1EwrUPHeE0KvfOycOFjRmu3Hqeco6qYsfmwflnII/skUFeJrTbW/Ozt02qREEVtb/0M8V6g8ii7CE71epFwZ6FWWHC+LqDCetkL/m1/N4g94gRTpUkEHrVmvAgy31RCR+hPmDb/OT5y9jsnViX51xgyPbWnkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a2e1aF9v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a2e1aF9v" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5DF08C116C6; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=PS+mr7iO0a5jdtYd0VaFNs9GMsJ2dXsHIT12WNpcsMM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=a2e1aF9vggG7iD6yCbmuA4SteWQ/yjdlkNBaU2OaScueoatKsj6jP5NvwSO/k0NBp FjjHxunOY3tlvcCbO81B+pgRDmyccZHjDve6GDp3qfrPjdnV2WXP2SYAz1vdiBO6R9 vXn6Hjk4vMlfCb0Kz7trUcQiSuhDdf2LrdqxucPvn4jnEWN7kxB6+MzsDijwo1p8si GipzxHMBfPNQ7Z3ltNwxTBDzfSWgP4SNECce8fKFnwcVyKwmzw6eEOqXRq6NDH478D W0eCAb6xH8k8gl5bDjbj6djAj8n4j0ypkzacXxGhgchHHVP8uyG3p7LUuFQOpMydkE nNwA0bjMSuPeQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53260CAC597; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:49:59 +0800 Subject: [PATCH v4 7/8] power: supply: qcom_battmgr: Add charge control support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-7-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=16401; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=EAq22bLqroFSgGNKI81NR1embBAdsIV5YQ+b3vaavkA=; b=1Sa+yPKySRIQn1I9TiUtFw0w31qZSPOR1pUiKMwSozCnCVA5I2VosQskIuLZaEoOJTegLbYDS L7cJCQZ5D5eDqjuTMiTI/BHE0Y6wRo79TKG4blrxmEqqT4skpm8MFC0 X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add charge control support for SM8550 and X1E80100. It's supported with below two power supply properties: charge_control_end_threshold: The battery SoC (State of Charge) threshold at which the charging should be terminated. charge_control_start_threshold: The battery SoC threshold at which the charging should be resumed. Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu --- drivers/power/supply/qcom_battmgr.c | 290 ++++++++++++++++++++++++++++++++= +++- 1 file changed, 283 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qco= m_battmgr.c index 174d3f83ac2b070bb90c21a498686e91cc629ebe..23c68eb942f1b213f634e31a454= 20b3e113e2764 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -68,6 +69,9 @@ enum qcom_battmgr_variant { #define BATT_RESISTANCE 21 #define BATT_POWER_NOW 22 #define BATT_POWER_AVG 23 +#define BATT_CHG_CTRL_EN 24 +#define BATT_CHG_CTRL_START_THR 25 +#define BATT_CHG_CTRL_END_THR 26 =20 #define BATTMGR_USB_PROPERTY_GET 0x32 #define BATTMGR_USB_PROPERTY_SET 0x33 @@ -92,6 +96,13 @@ enum qcom_battmgr_variant { #define WLS_TYPE 5 #define WLS_BOOST_EN 6 =20 +#define BATTMGR_CHG_CTRL_LIMIT_EN 0x48 +#define CHARGE_CTRL_START_THR_MIN 50 +#define CHARGE_CTRL_START_THR_MAX 95 +#define CHARGE_CTRL_END_THR_MIN 55 +#define CHARGE_CTRL_END_THR_MAX 100 +#define CHARGE_CTRL_DELTA_SOC 5 + struct qcom_battmgr_enable_request { struct pmic_glink_hdr hdr; __le32 battery_id; @@ -126,6 +137,13 @@ struct qcom_battmgr_discharge_time_request { __le32 reserved; }; =20 +struct qcom_battmgr_charge_ctrl_request { + struct pmic_glink_hdr hdr; + __le32 enable; + __le32 target_soc; + __le32 delta_soc; +}; + struct qcom_battmgr_message { struct pmic_glink_hdr hdr; union { @@ -238,6 +256,8 @@ struct qcom_battmgr_info { unsigned int capacity_warning; unsigned int cycle_count; unsigned int charge_count; + unsigned int charge_ctrl_start; + unsigned int charge_ctrl_end; char model_number[BATTMGR_STRING_LEN]; char serial_number[BATTMGR_STRING_LEN]; char oem_info[BATTMGR_STRING_LEN]; @@ -426,6 +446,8 @@ static const u8 sm8350_bat_prop_map[] =3D { [POWER_SUPPLY_PROP_INTERNAL_RESISTANCE] =3D BATT_RESISTANCE, [POWER_SUPPLY_PROP_STATE_OF_HEALTH] =3D BATT_SOH, [POWER_SUPPLY_PROP_POWER_NOW] =3D BATT_POWER_NOW, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD] =3D BATT_CHG_CTRL_STAR= T_THR, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD] =3D BATT_CHG_CTRL_END_TH= R, }; =20 static int qcom_battmgr_bat_sm8350_update(struct qcom_battmgr *battmgr, @@ -496,7 +518,8 @@ static int qcom_battmgr_bat_get_property(struct power_s= upply *psy, if (!battmgr->service_up) return -EAGAIN; =20 - if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP) + if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP || + battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) ret =3D qcom_battmgr_bat_sc8280xp_update(battmgr, psp); else ret =3D qcom_battmgr_bat_sm8350_update(battmgr, psp); @@ -601,6 +624,12 @@ static int qcom_battmgr_bat_get_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_TIME_TO_FULL_AVG: val->intval =3D battmgr->status.charge_time; break; + case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD: + val->intval =3D battmgr->info.charge_ctrl_start; + break; + case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: + val->intval =3D battmgr->info.charge_ctrl_end; + break; case POWER_SUPPLY_PROP_MANUFACTURE_YEAR: val->intval =3D battmgr->info.year; break; @@ -626,6 +655,149 @@ static int qcom_battmgr_bat_get_property(struct power= _supply *psy, return 0; } =20 +static int qcom_battmgr_set_charge_control(struct qcom_battmgr *battmgr, + u32 target_soc, u32 delta_soc) +{ + struct qcom_battmgr_charge_ctrl_request request =3D { + .hdr.owner =3D cpu_to_le32(PMIC_GLINK_OWNER_BATTMGR), + .hdr.type =3D cpu_to_le32(PMIC_GLINK_REQ_RESP), + .hdr.opcode =3D cpu_to_le32(BATTMGR_CHG_CTRL_LIMIT_EN), + .enable =3D cpu_to_le32(1), + .target_soc =3D cpu_to_le32(target_soc), + .delta_soc =3D cpu_to_le32(delta_soc), + }; + + return qcom_battmgr_request(battmgr, &request, sizeof(request)); +} + +static int qcom_battmgr_set_charge_start_threshold(struct qcom_battmgr *ba= ttmgr, int start_soc) +{ + u32 target_soc, delta_soc; + int ret; + + if (start_soc < CHARGE_CTRL_START_THR_MIN || + start_soc > CHARGE_CTRL_START_THR_MAX) { + dev_err(battmgr->dev, "charge control start threshold exceed range: [%u = - %u]\n", + CHARGE_CTRL_START_THR_MIN, CHARGE_CTRL_START_THR_MAX); + return -EINVAL; + } + + /* + * If the new start threshold is larger than the old end threshold, + * move the end threshold one step (DELTA_SOC) after the new start + * threshold. + */ + if (start_soc > battmgr->info.charge_ctrl_end) { + target_soc =3D start_soc + CHARGE_CTRL_DELTA_SOC; + target_soc =3D min_t(u32, target_soc, CHARGE_CTRL_END_THR_MAX); + delta_soc =3D target_soc - start_soc; + delta_soc =3D min_t(u32, delta_soc, CHARGE_CTRL_DELTA_SOC); + } else { + target_soc =3D battmgr->info.charge_ctrl_end; + delta_soc =3D battmgr->info.charge_ctrl_end - start_soc; + } + + mutex_lock(&battmgr->lock); + ret =3D qcom_battmgr_set_charge_control(battmgr, target_soc, delta_soc); + mutex_unlock(&battmgr->lock); + if (!ret) { + battmgr->info.charge_ctrl_start =3D start_soc; + battmgr->info.charge_ctrl_end =3D target_soc; + } + + return 0; +} + +static int qcom_battmgr_set_charge_end_threshold(struct qcom_battmgr *batt= mgr, int end_soc) +{ + u32 delta_soc =3D CHARGE_CTRL_DELTA_SOC; + int ret; + + if (end_soc < CHARGE_CTRL_END_THR_MIN || + end_soc > CHARGE_CTRL_END_THR_MAX) { + dev_err(battmgr->dev, "charge control end threshold exceed range: [%u - = %u]\n", + CHARGE_CTRL_END_THR_MIN, CHARGE_CTRL_END_THR_MAX); + return -EINVAL; + } + + if (battmgr->info.charge_ctrl_start && end_soc > battmgr->info.charge_ctr= l_start) + delta_soc =3D end_soc - battmgr->info.charge_ctrl_start; + + mutex_lock(&battmgr->lock); + ret =3D qcom_battmgr_set_charge_control(battmgr, end_soc, delta_soc); + mutex_unlock(&battmgr->lock); + if (!ret) { + battmgr->info.charge_ctrl_start =3D end_soc - delta_soc; + battmgr->info.charge_ctrl_end =3D end_soc; + } + + return 0; +} + +static int qcom_battmgr_charge_control_thresholds_init(struct qcom_battmgr= *battmgr) +{ + int ret; + u8 en, end_soc, start_soc, delta_soc; + + ret =3D nvmem_cell_read_u8(battmgr->dev->parent, "charge_limit_en", &en); + if (!ret && en !=3D 0) { + ret =3D nvmem_cell_read_u8(battmgr->dev->parent, "charge_limit_end", &en= d_soc); + if (ret < 0) + return ret; + + ret =3D nvmem_cell_read_u8(battmgr->dev->parent, "charge_limit_delta", &= delta_soc); + if (ret < 0) + return ret; + + if (delta_soc >=3D end_soc) + return -EINVAL; + + start_soc =3D end_soc - delta_soc; + end_soc =3D clamp(end_soc, CHARGE_CTRL_END_THR_MIN, CHARGE_CTRL_END_THR_= MAX); + start_soc =3D clamp(start_soc, CHARGE_CTRL_START_THR_MIN, CHARGE_CTRL_ST= ART_THR_MAX); + + battmgr->info.charge_ctrl_start =3D start_soc; + battmgr->info.charge_ctrl_end =3D end_soc; + } + + return 0; +} + +static int qcom_battmgr_bat_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD: + case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: + return 1; + default: + return 0; + } + + return 0; +} + +static int qcom_battmgr_bat_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *pval) +{ + struct qcom_battmgr *battmgr =3D power_supply_get_drvdata(psy); + + if (!battmgr->service_up) + return -EAGAIN; + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD: + return qcom_battmgr_set_charge_start_threshold(battmgr, pval->intval); + case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: + return qcom_battmgr_set_charge_end_threshold(battmgr, pval->intval); + default: + return -EINVAL; + } + + return 0; +} + static const enum power_supply_property sc8280xp_bat_props[] =3D { POWER_SUPPLY_PROP_STATUS, POWER_SUPPLY_PROP_PRESENT, @@ -659,6 +831,43 @@ static const struct power_supply_desc sc8280xp_bat_psy= _desc =3D { .get_property =3D qcom_battmgr_bat_get_property, }; =20 +static const enum power_supply_property x1e80100_bat_props[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_TECHNOLOGY, + POWER_SUPPLY_PROP_CYCLE_COUNT, + POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_POWER_NOW, + POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, + POWER_SUPPLY_PROP_CHARGE_FULL, + POWER_SUPPLY_PROP_CHARGE_EMPTY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN, + POWER_SUPPLY_PROP_ENERGY_FULL, + POWER_SUPPLY_PROP_ENERGY_EMPTY, + POWER_SUPPLY_PROP_ENERGY_NOW, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_MANUFACTURE_YEAR, + POWER_SUPPLY_PROP_MANUFACTURE_MONTH, + POWER_SUPPLY_PROP_MANUFACTURE_DAY, + POWER_SUPPLY_PROP_MODEL_NAME, + POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_SERIAL_NUMBER, + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, +}; + +static const struct power_supply_desc x1e80100_bat_psy_desc =3D { + .name =3D "qcom-battmgr-bat", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D x1e80100_bat_props, + .num_properties =3D ARRAY_SIZE(x1e80100_bat_props), + .get_property =3D qcom_battmgr_bat_get_property, + .set_property =3D qcom_battmgr_bat_set_property, + .property_is_writeable =3D qcom_battmgr_bat_is_writeable, +}; + static const enum power_supply_property sm8350_bat_props[] =3D { POWER_SUPPLY_PROP_STATUS, POWER_SUPPLY_PROP_HEALTH, @@ -691,6 +900,42 @@ static const struct power_supply_desc sm8350_bat_psy_d= esc =3D { .get_property =3D qcom_battmgr_bat_get_property, }; =20 +static const enum power_supply_property sm8550_bat_props[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_HEALTH, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_CHARGE_TYPE, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_VOLTAGE_OCV, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_TECHNOLOGY, + POWER_SUPPLY_PROP_CHARGE_COUNTER, + POWER_SUPPLY_PROP_CYCLE_COUNT, + POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, + POWER_SUPPLY_PROP_CHARGE_FULL, + POWER_SUPPLY_PROP_MODEL_NAME, + POWER_SUPPLY_PROP_TIME_TO_FULL_AVG, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, + POWER_SUPPLY_PROP_INTERNAL_RESISTANCE, + POWER_SUPPLY_PROP_STATE_OF_HEALTH, + POWER_SUPPLY_PROP_POWER_NOW, + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, +}; + +static const struct power_supply_desc sm8550_bat_psy_desc =3D { + .name =3D "qcom-battmgr-bat", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D sm8550_bat_props, + .num_properties =3D ARRAY_SIZE(sm8550_bat_props), + .get_property =3D qcom_battmgr_bat_get_property, + .set_property =3D qcom_battmgr_bat_set_property, + .property_is_writeable =3D qcom_battmgr_bat_is_writeable, +}; + static int qcom_battmgr_ac_get_property(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val) @@ -766,7 +1011,8 @@ static int qcom_battmgr_usb_get_property(struct power_= supply *psy, if (!battmgr->service_up) return -EAGAIN; =20 - if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP) + if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP || + battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) ret =3D qcom_battmgr_bat_sc8280xp_update(battmgr, psp); else ret =3D qcom_battmgr_usb_sm8350_update(battmgr, psp); @@ -888,7 +1134,8 @@ static int qcom_battmgr_wls_get_property(struct power_= supply *psy, if (!battmgr->service_up) return -EAGAIN; =20 - if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP) + if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP || + battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) ret =3D qcom_battmgr_bat_sc8280xp_update(battmgr, psp); else ret =3D qcom_battmgr_wls_sm8350_update(battmgr, psp); @@ -1085,6 +1332,9 @@ static void qcom_battmgr_sc8280xp_callback(struct qco= m_battmgr *battmgr, case BATTMGR_BAT_CHARGE_TIME: battmgr->status.charge_time =3D le32_to_cpu(resp->time); break; + case BATTMGR_CHG_CTRL_LIMIT_EN: + battmgr->error =3D 0; + break; default: dev_warn(battmgr->dev, "unknown message %#x\n", opcode); break; @@ -1198,6 +1448,12 @@ static void qcom_battmgr_sm8350_callback(struct qcom= _battmgr *battmgr, case BATT_POWER_NOW: battmgr->status.power_now =3D le32_to_cpu(resp->intval.value); break; + case BATT_CHG_CTRL_START_THR: + battmgr->info.charge_ctrl_start =3D le32_to_cpu(resp->intval.value); + break; + case BATT_CHG_CTRL_END_THR: + battmgr->info.charge_ctrl_end =3D le32_to_cpu(resp->intval.value); + break; default: dev_warn(battmgr->dev, "unknown property %#x\n", property); break; @@ -1280,6 +1536,7 @@ static void qcom_battmgr_sm8350_callback(struct qcom_= battmgr *battmgr, } break; case BATTMGR_REQUEST_NOTIFICATION: + case BATTMGR_CHG_CTRL_LIMIT_EN: battmgr->error =3D 0; break; default: @@ -1299,7 +1556,8 @@ static void qcom_battmgr_callback(const void *data, s= ize_t len, void *priv) =20 if (opcode =3D=3D BATTMGR_NOTIFICATION) qcom_battmgr_notification(battmgr, data, len); - else if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP) + else if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP || + battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) qcom_battmgr_sc8280xp_callback(battmgr, data, len); else qcom_battmgr_sm8350_callback(battmgr, data, len); @@ -1346,11 +1604,13 @@ static char *qcom_battmgr_battery[] =3D { "battery"= }; static int qcom_battmgr_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { + const struct power_supply_desc *psy_desc; struct power_supply_config psy_cfg_supply =3D {}; struct power_supply_config psy_cfg =3D {}; const struct of_device_id *match; struct qcom_battmgr *battmgr; struct device *dev =3D &adev->dev; + int ret; =20 battmgr =3D devm_kzalloc(dev, sizeof(*battmgr), GFP_KERNEL); if (!battmgr) @@ -1376,8 +1636,19 @@ static int qcom_battmgr_probe(struct auxiliary_devic= e *adev, else battmgr->variant =3D QCOM_BATTMGR_SM8350; =20 - if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP) { - battmgr->bat_psy =3D devm_power_supply_register(dev, &sc8280xp_bat_psy_d= esc, &psy_cfg); + ret =3D qcom_battmgr_charge_control_thresholds_init(battmgr); + if (ret < 0) + return dev_err_probe(dev, ret, + "failed to init battery charge control thresholds\n"); + + if (battmgr->variant =3D=3D QCOM_BATTMGR_SC8280XP || + battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) { + if (battmgr->variant =3D=3D QCOM_BATTMGR_X1E80100) + psy_desc =3D &x1e80100_bat_psy_desc; + else + psy_desc =3D &sc8280xp_bat_psy_desc; + + battmgr->bat_psy =3D devm_power_supply_register(dev, psy_desc, &psy_cfg); if (IS_ERR(battmgr->bat_psy)) return dev_err_probe(dev, PTR_ERR(battmgr->bat_psy), "failed to register battery power supply\n"); @@ -1397,7 +1668,12 @@ static int qcom_battmgr_probe(struct auxiliary_devic= e *adev, return dev_err_probe(dev, PTR_ERR(battmgr->wls_psy), "failed to register wireless charing power supply\n"); } else { - battmgr->bat_psy =3D devm_power_supply_register(dev, &sm8350_bat_psy_des= c, &psy_cfg); + if (battmgr->variant =3D=3D QCOM_BATTMGR_SM8550) + psy_desc =3D &sm8550_bat_psy_desc; + else + psy_desc =3D &sm8350_bat_psy_desc; + + battmgr->bat_psy =3D devm_power_supply_register(dev, psy_desc, &psy_cfg); if (IS_ERR(battmgr->bat_psy)) return dev_err_probe(dev, PTR_ERR(battmgr->bat_psy), "failed to register battery power supply\n"); --=20 2.34.1 From nobody Thu Oct 2 15:35:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B89C32F1FC1; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; cv=none; b=JdVssxwJ3lQPh+1Pi20lKPpa7k/ZCH9Y0B4+guMnoO++mxh4DpnUnvkYt9i1naAy09TBzAZL3utVpQHi3loDGZ4Vtqlu98wrHnXkDawSf0JNMVEA40aKbwwJYoNUmOERMo2tzW6b8FOXA8JZuoJ5Ud0y9FM1Rzs1IYWLNtJpBeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757926214; c=relaxed/simple; bh=8YzhXVDGYfiV4HzTOVlRZNfrx9Hq7QkrlqseIUH0EYI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KGtQRqdvXvG3FmToUyB4OlRlMMnLGbOCNpz+HhCa+ZF+WOFZNzdRjGsoDtZDeu64wega8cCnE9HLOuEbKSX8AvuNcG7jRo42Y3oV+oTYYPjIgEsayckyvKmqOdh+zPx9yjd+JOmuEM8eCBzyelw4PAGRSsX8C3ap/n6RP+sDDsI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NQ0NpqNv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NQ0NpqNv" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6B7A5C4CEF1; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757926214; bh=8YzhXVDGYfiV4HzTOVlRZNfrx9Hq7QkrlqseIUH0EYI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NQ0NpqNvkvYE0l4RSbPoTHOTPbGJT/+89CAcdxh0NsRxoRAjbL0UqHZmlT/T5RKX/ dLjw0Y88xoRckdPuCvP9BVMwaOmpyA0fAg+Gv21ctOnoBhSmwloqsozM2cOGAbOG1V 5jTzm2Fhbp/XmtyYFnM+Ugt0VpQ//jMva6/ZeTVaVYwxIc/3k+HfMdgVaDgAXf2apa 4L4RgM7nQD6vf2wXbH+htk2SCzHEMVePCGKp5lMa9SNswE9n5HsRzuaymBtx3+Mmbd 42sSuN7FwWg5E+ZU3mdN+nCCUjEmTI9IM/61mh0fb8V3XEd/yuokUlPGQAwBXAJnUD cexKP8k13A9PQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EB0CAC59A; Mon, 15 Sep 2025 08:50:14 +0000 (UTC) From: Fenglin Wu via B4 Relay Date: Mon, 15 Sep 2025 16:50:00 +0800 Subject: [PATCH v4 8/8] arm64: dts: qcom: x1e80100-crd: Add charge limit nvmem Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250915-qcom_battmgr_update-v4-8-6f6464a41afe@oss.qualcomm.com> References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> In-Reply-To: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> To: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio Cc: Subbaraman Narayanamurthy , David Collins , =?utf-8?q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Fenglin Wu , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757926212; l=1975; i=fenglin.wu@oss.qualcomm.com; s=20240327; h=from:subject:message-id; bh=SlhYoRKUJUUMoUaX/eiBPiu6dsVcqAGHcuhRs7McyOc=; b=GjM4eAr5cx5pHz/1tZPKjDVs9VSuyjl3fTa8ewSgbClqY1eC7/sUZcfjjmU7pvnCMtXDPOAG7 06zPtmGQZVDAcZZ4W2W8vpM34ESmYDmse4lra4jYucpJIz5QMhiJLoM X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=BF8SA4IVDk8/EBCwlBehKtn2hp6kipuuAuDAHh9s+K4= X-Endpoint-Received: by B4 Relay for fenglin.wu@oss.qualcomm.com/20240327 with auth_id=406 X-Original-From: Fenglin Wu Reply-To: fenglin.wu@oss.qualcomm.com From: Fenglin Wu Add nvmem cells for getting charge control thresholds if they have been set previously. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Signed-off-by: Fenglin Wu Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/x1-crd.dtsi | 3 +++ arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qco= m/x1-crd.dtsi index c9f0d505267081af66b0973fe6c1e33832a2c86b..fee65391653ae9c2ee23f9f3954= d9ed018c9aecd 100644 --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi @@ -82,6 +82,9 @@ pmic-glink { <&tlmm 123 GPIO_ACTIVE_HIGH>, <&tlmm 125 GPIO_ACTIVE_HIGH>; =20 + nvmem-cells =3D <&charge_limit_en>, <&charge_limit_end>, <&charge_limit_= delta>; + nvmem-cell-names =3D "charge_limit_en", "charge_limit_end", "charge_limi= t_delta"; + /* Left-side rear port */ connector@0 { compatible =3D "usb-c-connector"; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot= /dts/qcom/x1e80100-pmics.dtsi index c02fd4d15c9649c222caaafa5ed2c777a10fb4f5..eb5562e4393c88faa16d9172ee2= a1ceabef076ff 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi @@ -239,6 +239,26 @@ reboot_reason: reboot-reason@48 { }; }; =20 + pmk8550_sdam_15: nvram@7e00 { + compatible =3D "qcom,spmi-sdam"; + reg =3D <0x7e00>; + #address-cells =3D <1>; + #size-cells =3D <1>; + ranges =3D <0 0x7e00 0x100>; + + charge_limit_en: charge-limit-en@73 { + reg =3D <0x73 0x1>; + }; + + charge_limit_end: charge-limit-end@75 { + reg =3D <0x75 0x1>; + }; + + charge_limit_delta: charge-limit-delta@76 { + reg =3D <0x76 0x1>; + }; + }; + pmk8550_gpios: gpio@8800 { compatible =3D "qcom,pmk8550-gpio", "qcom,spmi-gpio"; reg =3D <0xb800>; --=20 2.34.1