From nobody Thu Oct 2 16:32:32 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B12CB1D95A3 for ; Sun, 14 Sep 2025 18:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874548; cv=none; b=CIcwp21Caje9gW/ptK2Dl/wuu/za+JLta5nLQfgP9JURwYSZ8zNcdEyOYTUswyYg0TrsO6qk9yt4u+TFlLHbSfclvmv/BGXiEMKi+vFl8Hka0IdDP8sO/K2wzHJ9D56KVTo5KfTb7GyQAElDf5xDKdRPHLo+IJBAPDZTAPNh8rY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874548; c=relaxed/simple; bh=+i4xQMP5N+7tTEJLjyp4Lzml52ZZB5eYnS6qu0gy9v4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=KivvP+rnkHR+FkekHupnHGFIzeuYZZKovhjkHeA9yWcbKmCf6fnfj4LWuETmc52a5REu0zxYnSQbEdDD2TXMw1OzB0+CrRt9IREPNkMXGc9HEWLJehH3Af1t5NxXh40gwYakhvLhfmz/3rW7/mfbIm/vo+GbI0vmMuBpETqyT3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gJ/HxC1H; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gJ/HxC1H" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2490768ee5fso26657745ad.3 for ; Sun, 14 Sep 2025 11:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757874546; x=1758479346; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=4HAiy3Nfgo/52bieljut+UzYUSPPtF1Iok2zeSkSwug=; b=gJ/HxC1HzC+beIGDqBSrl3LA2BA4UqboVMyWGWSae1UzLukO3d+FvWz5TV81egPBUF ZQ3ICgDXhsS6V4rqbdpftVcApTJR8mVUs+SJ5DTqwGpuG+GffU8+knVHKeY9DUrQNp21 mHonehYRZOJU9rTPgaP0eofGxGAArXB9h9oCNC+j9Mt2lSj8UIgD6oKTkLJizSa25fLA YfyBzodNTxoE4eohyfIu/MpJ7S6lX3am5vWVvm0c98eG6gGkMn8+prD7DMWLczRRtoPm JDcFQvMBjD1PAugIWpFKpyxNHDwN0+aVdpQwKZOPJtSOLjj8eBj8LHQOHkVPcBgHijz/ Mj1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757874546; x=1758479346; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4HAiy3Nfgo/52bieljut+UzYUSPPtF1Iok2zeSkSwug=; b=wRkwN0uuiyKX2ADB76J9I6TMz0ICJ4gBO0ZHAhxwoSUTb79QKMMrUH8KWvLWrIz7E8 7R1FNfGOk4mF0h5oHxZg7gtzbCnGvFLH3WCZss7j5E/rhAlC9qs1c5zDrWo5aG1aQqdZ EgrBcsjdrxKGCecigtdkfDwvDtbXuiGyW9pwFKg3WsI3iJhlnsTZp6aE0ts4oZ4xDuPf rUKHNYhSWzde8rvaFyyicGYNRssqFk3f1r4l+V0jbrUewKHG+5Y9wyPzaw08UkSeTUUg Oefzv+Ch0yfLc7prt36pOhz21gLqQsFCzcoZcsCMcGxVYyOjMOsKr3MTkQVNK11G0EMZ EOpw== X-Forwarded-Encrypted: i=1; AJvYcCWxrLyCzdAYNt/3kbySgMG/87ehjq+M+8kN1mooz7QbetTCZ839aeX6L5t3SdQIAbI6usUIdnQn1bI/iKc=@vger.kernel.org X-Gm-Message-State: AOJu0YyClzb2Qf8clEQtbz+D1C6CbKJE/sSIgtAKiDCAMWeaId/tRwfD CxuFQpIpJDal7sfsww5YqzS+ugx2g3NzDoNpKzl9rVYEtHNZr/MtRAE9/yy9y/X2arNSJ13T3tG k3hAasPBwEQ== X-Google-Smtp-Source: AGHT+IHnyivzNtqrN3wSUVPkTq+iybkdIGO3uTylpMD8cdqzOFZYHwsBZlnbxQepi11eeRvtVPHlAeTVjPxF X-Received: from plbmb8.prod.google.com ([2002:a17:903:988:b0:24c:b394:50e4]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e78f:b0:25c:8005:3efb with SMTP id d9443c01a7336-25d2703b924mr126822205ad.54.1757874545977; Sun, 14 Sep 2025 11:29:05 -0700 (PDT) Date: Sun, 14 Sep 2025 11:28:57 -0700 In-Reply-To: <20250914182900.1960567-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250914182900.1960567-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250914182900.1960567-2-irogers@google.com> Subject: [PATCH v1 1/4] perf test: Be tolerant of missing json metric none value From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" print_metric_only_json and print_metric_end in stat-display.c may create a metric value of "none" which fails validation as isfloat. Add a helper to properly validate metric numeric values. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/lib/perf_json_output_lint.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/tests/shell/lib/perf_json_output_lint.py b/tools/pe= rf/tests/shell/lib/perf_json_output_lint.py index c6750ef06c0f..ff90c23d1d62 100644 --- a/tools/perf/tests/shell/lib/perf_json_output_lint.py +++ b/tools/perf/tests/shell/lib/perf_json_output_lint.py @@ -43,6 +43,9 @@ def isint(num): def is_counter_value(num): return isfloat(num) or num =3D=3D '' or num =3D=3D '' =20 +def is_metric_value(num): + return isfloat(num) or num =3D=3D 'none' + def check_json_output(expected_items): checks =3D { 'counters': lambda x: isfloat(x), @@ -57,7 +60,7 @@ def check_json_output(expected_items): 'event-runtime': lambda x: isfloat(x), 'interval': lambda x: isfloat(x), 'metric-unit': lambda x: True, - 'metric-value': lambda x: isfloat(x), + 'metric-value': lambda x: is_metric_value(x), 'metric-threshold': lambda x: x in ['unknown', 'good', 'less good', = 'nearly bad', 'bad'], 'metricgroup': lambda x: True, 'node': lambda x: True, @@ -65,7 +68,7 @@ def check_json_output(expected_items): 'socket': lambda x: True, 'thread': lambda x: True, 'unit': lambda x: True, - 'insn per cycle': lambda x: isfloat(x), + 'insn per cycle': lambda x: is_metric_value(x), 'GHz': lambda x: True, # FIXME: it seems unintended for --metric-on= ly } input =3D '[\n' + ','.join(Lines) + '\n]' --=20 2.51.0.384.g4c02a37b29-goog From nobody Thu Oct 2 16:32:32 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BFBE2DE717 for ; Sun, 14 Sep 2025 18:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874550; cv=none; b=jMve03Gc+xyTsbCTLXPpRsHE333j2DQB9e/D1v6KNW8iaGVeV0ZJhtkxI5gK2EAr1d2rzdaVtnhY5htwp5FsEuWiCBOakbKGOQvVBk3mNP91TE8CpDsCcGRT6y4aqzYWLFi8TX2OztcojSj6XZzzIZEmZ8NL0v5sc4Njpenxe60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874550; c=relaxed/simple; bh=mTOn6giSoP53VSWktwhOwxCbO9sMvgSdd93tY2pNJs8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=M055PdazMQCqkSgihIx5RIJuquGQF1raOeHXNdeYuwF5TMPoEKaIvdhBkbzkkDjvVDHgFKfmBMy/joGd9avgnPbN+LvlbA4nPn1atxHt3Dk7dk4c9RdYU/vUHCWrxJ/T+bKUd5IYkLHT/BKKatZtwPOVQYKDq4SQv1FEUjBrG4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZJC/1qLf; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZJC/1qLf" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-24457f59889so37204185ad.0 for ; Sun, 14 Sep 2025 11:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757874548; x=1758479348; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=i1UXr9DddIml2mw3JC9NZw81ayshLyyLu0KNuaMckGo=; b=ZJC/1qLfZxPuxZYKyc43GsF9FWsz7giifTJq3rco4knDrbu54qFRJGzY4q/JKymt6l 1ABrQmZ+BEiBAlzlV3IAL12A3dCBwejhzx8Mwgsu3een8cchj/OoMZ5UgotkSsWOOJQn UwjZVnD2yutzUEeuS4ThNqMYWFBNar6HgjU60oZIbjLNAtni7Ytw3AX75aUovf3HDc8z OBMFf5F6xCqdPY2TQKn6puvCtGjP9JRlv3jhAH3avbEUD767fzRKusVlTTFnJR2GDdJO izgFcSJLPGa8b9dFPm7/h8ynE3JoRcVN073TboTzl/MVZF4jnpYFuyIEJqHyKVNzihNB v4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757874548; x=1758479348; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i1UXr9DddIml2mw3JC9NZw81ayshLyyLu0KNuaMckGo=; b=rZ12buTzjcqLiv98obT8MwccK9x8Xq7Cn1Lp0fuHLrLAmVVjfRsGRog1zqHzSxSvkr +NN3Ks2fq5nFv3Ob9M0z5y9dpFHP5B9vZ0pltxZHAXWxpn8efxoaqC3OIDSfQbMDBNi7 bl2EEne2OXnTrJl0dV1rCZooJjUYm8LiSYHpTXj+EK8DjaiyOjqb+eaY0AO5YXhHUuqQ u8rrty8p05LV0OoUMovxjQuEBw6Cp2/ukdcuKV36bRLZfLzrQrbjEUWyRwp0sdTW72Ua INmwvRwEGVR3FnX/31oXh9hyIFF2nopk897pRQi0QrXluDQrhcm0vAM6QibhCZS21QoM tU4w== X-Forwarded-Encrypted: i=1; AJvYcCUCFXXn2+dvJ40iZKZUGb/M4t+Vv1nAaeZzwRJ1G8EW65hGjinc6r2ieQuqmnfqYKKquW23MiBj5vsqF08=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9uFrjPSuydpO25lF1xzkMNfLQbjNZdlwWFUUyiHKIHcNuxVGy BY8wniu6EFumjXjJZX24fKbM2qz/hpJZnzkqgP3IAFwf4yeUFKT9hjb82o3NRey1L4MTh28QPvt HqgeRfBLCCQ== X-Google-Smtp-Source: AGHT+IFeXUQzkJIJjFsaSyL3OefAj4LJj2IjQXlqOLKAqr9meNr+oFat66AV3yKPiRMp+IW7ZIJe30YGIioR X-Received: from plok6.prod.google.com ([2002:a17:903:3bc6:b0:266:d686:956a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:fc4b:b0:246:7a43:3f84 with SMTP id d9443c01a7336-25d242f30e3mr113738465ad.5.1757874548053; Sun, 14 Sep 2025 11:29:08 -0700 (PDT) Date: Sun, 14 Sep 2025 11:28:58 -0700 In-Reply-To: <20250914182900.1960567-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250914182900.1960567-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250914182900.1960567-3-irogers@google.com> Subject: [PATCH v1 2/4] perf parse-events: Add debug logging to perf_event From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If verbose is enabled and parse_event is called, typically by tests, log failures. Signed-off-by: Ian Rogers --- tools/perf/util/parse-events.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 5dbbede45363..f96f2e750fe7 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -2211,6 +2211,8 @@ int parse_event(struct evlist *evlist, const char *st= r) =20 parse_events_error__init(&err); ret =3D parse_events(evlist, str, &err); + if (ret && verbose > 0) + parse_events_error__print(&err, str); parse_events_error__exit(&err); return ret; } --=20 2.51.0.384.g4c02a37b29-goog From nobody Thu Oct 2 16:32:32 2025 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 443372DF128 for ; Sun, 14 Sep 2025 18:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874551; cv=none; b=onMKN10R8XMywYqVc/Z5IuKmOd8pZOiSXu306wbRqVw3N9205qkqe/EfbB+9rMDWorTkviKNN7cPt0ac7kqrlSTWgsIwo328tUAnVaxbDJRxQeXOwi60udZ6tz5CvuAnw+I8Jt033l3umv57lNPqBBO20e/kHA2zCQYsDYkZ/dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874551; c=relaxed/simple; bh=0lYXmqlBpYk30yEty0a21FLXkVSzUHTg5T5wQf3ZAeE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=K144qSL3kc5jJw0Qz1hglV3N0ST7vNr+TtxGLFALv5W94kRW26A2mECFXZn3WU0g5edxd0P9wAuXfuYCW/+0WiFFvSxzjAfLHuEmM4OVnv/tET4wDtDGZNBqIqwEWqqhPG3rjoCtqYZCNb4KEgXLLBGbntH1T7RP5zrb7+GOjB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=3Xg7tmdP; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="3Xg7tmdP" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b521ae330b0so2535908a12.2 for ; Sun, 14 Sep 2025 11:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757874550; x=1758479350; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=TvKgbG4XWpm9j/FvFDZJd7wO0CKfdrc2kepJ8gLxvYI=; b=3Xg7tmdPIR4FY3+tzNRKBWwjSVfd7O6KZJsj8dEJl0s2eEc1hakrznlhxxcXr4ZQnO 7jQkLswZBU7vqFCyMtfiLMbTwPsWRTKUmdWaT6ABumrP0YhWlLIjpTuqq3iA2gIAGJ49 x7rcxbml/aY2EqSbYShHdYArwp9nC97Yc8N70wLEb2uG7a+MHYZioaq+6p9KfjB7Gf5V a+wV3/zkd0ZG+b+T51DNK+PnOAA+7DngVY3poCDSggmltJ5M7z8LlCmNtCvNc7Rzkrh7 euh8WwF2IdJEzqnfV/w/yYw2ZaI704STvy5fnbSTwuoRQQTmUa04sv90B7lKtSu0wOUv M9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757874550; x=1758479350; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TvKgbG4XWpm9j/FvFDZJd7wO0CKfdrc2kepJ8gLxvYI=; b=oAId5sHqjRuBH4hqiNndTi400nKFtngDBmwYUHqBtvME4HatCL/ORWhAD9aZGX6jDg DeOYmWMkS6BAW63UKam8dhjo8CCuGUDhjwzow72zfzr5q6Fw6EVDYejch23kmfTv2NnX zCSq4w4FTyQqwK6v9v7DZ77jQ8BbZvXbouzrOZ9pMs6PIkah0tAt8KGWBvEnL3/FnT6j tbbot3fbbHe+eW6JGmWVxpbyPov32s69iT+Fy5Np/xZgX0FgDIFvQ342pWjGTn/ExtsW 2q9AHUud5pbiAzE5s5NRbzNQzunZ8nUNVhL0lMjiBZB13GSgSJ413LXjmPme6DdzfoPW dCyQ== X-Forwarded-Encrypted: i=1; AJvYcCWwRviJ6wnEzDAr4bdPWtfYzPXCneN8TwMPphEkd9bSENRg84BsCIf56zgiGOkstmB4mR6a76qLSqnVSJs=@vger.kernel.org X-Gm-Message-State: AOJu0YzvfL9qd89TncHV3yPbTy8nOhhP/nczWNrWjHdZKj8Sytc4qnVS piMkdPvOGlqjwNGg3gHBwx+mnNkVw3XwQ9t++ydzVtN24Y4qBTn7GdtxR9tM2dTwwwFY3kltRAG jBJB7h/kL+w== X-Google-Smtp-Source: AGHT+IGxW9Yja9epoc4iIK/yOFAiIZoZRfLvsUOXZa2OGRrep9OIb1OYkQrTlNUDj0uJte5SI7cFznkvnVg6 X-Received: from pjss8.prod.google.com ([2002:a17:90a:1c08:b0:32e:12f0:20e3]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:548d:b0:250:9175:96db with SMTP id adf61e73a8af0-2602aa853eemr12978800637.26.1757874549586; Sun, 14 Sep 2025 11:29:09 -0700 (PDT) Date: Sun, 14 Sep 2025 11:28:59 -0700 In-Reply-To: <20250914182900.1960567-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250914182900.1960567-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250914182900.1960567-4-irogers@google.com> Subject: [PATCH v1 3/4] perf test: Don't fail if user rdpmc returns 0 when disabled From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In certain hypervisor set ups the value 0 may be returned but this is only erroneous if the user rdpmc isn't disabled. Signed-off-by: Ian Rogers --- tools/perf/tests/mmap-basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c index 3c89d3001887..3313c236104e 100644 --- a/tools/perf/tests/mmap-basic.c +++ b/tools/perf/tests/mmap-basic.c @@ -322,7 +322,7 @@ static int test_stat_user_read(u64 event, enum user_rea= d_state enabled) } =20 perf_evsel__read(evsel, 0, 0, &counts); - if (counts.val =3D=3D 0) { + if (rdpmc_supported && counts.val =3D=3D 0) { pr_err("User space counter reading for PMU %s [Failed read]\n", pmu->na= me); ret =3D TEST_FAIL; goto cleanup; --=20 2.51.0.384.g4c02a37b29-goog From nobody Thu Oct 2 16:32:32 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61942DF152 for ; Sun, 14 Sep 2025 18:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874553; cv=none; b=DaJgdliyi0Lh5IlmHASSjTKNdeGNYbTtdQINWs/RgZ/2t0tZNaj89w8M92PBmQ0mBNvSwFj0FsOJmZWkIfnyGb1Q3CzlAj0K3SiXPO9CjpLaHFDcvTmUQ0gT7kknbvGlNy2kNdDPKgHMgRGu1Vty5fQLLPy7AMxg2auKyZmoMYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757874553; c=relaxed/simple; bh=kHCFkoShNUOlHMlQ879xfha1TjDoflpSxnCnwqm/tOc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=YwKauuZm5vMIWTftGnsJi6kb0dlN029OGpUyXECqMUCwhdZEF0GZYIcg+LxXVlFL8Lkck3SF4URAzYXA3BB7dvkQ0wbgNPa2ftM8eGrc8Ani4qFAQvgTecCEcYhOIJYzn2orqNp2FYQplVITNR9hNJ0BvvCOW6cLcMtQKslsm9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DxWnHjna; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DxWnHjna" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32dd3e922fdso5344099a91.0 for ; Sun, 14 Sep 2025 11:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757874551; x=1758479351; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=ALDUZA03/UTXBYu9euaSzX+Yf6hYZQnIYDNKkWvFhVE=; b=DxWnHjnaldwzNC2iTQVPj0qJMXHvzx0RXgxVdP3nWfdIA1ULVPDoE+wjzHbZ/C+ctK PFX/h0xWAaWkq0IH5rx/VG4hmceHE8+ccjEdWn+brvjHmdcinZpiXWVp6aB2kTyhp2Yc LK9cHlJUmwHwbP29vi8Id77FY6A9aWZfef6652a4Gx01jHkHhZss2pS5NXezR5V0NWMa iVhboCF6Bd1SVwpY8uGPwSPEfGBy+kgJvJiPVllL+cxgmdETjp9xiMFnt3ucjnTeuMgv F5K7FAZf4TTF8/5BH+3qQfoVLmhgRMv90VGKqMuwbLScDJRcaHJhGmxW290FR2JDR23u 81fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757874551; x=1758479351; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALDUZA03/UTXBYu9euaSzX+Yf6hYZQnIYDNKkWvFhVE=; b=mNRcuFNkPyRXqcLV13QotzYjJxIHr39wUooMntiaCUs6VZSNYUrkqoEkzrvYXAnCCi T5Vt0X8QktWfuibWklmJVRczqH+/tiEHVCA9aqNbEFculuM95HCEqdI8JNMZPqNHNfu8 wbFbv40M6du/nJn3Ykr/VIGTB5NTiDdBgASnyub9Pwr/Zq1PhlnSO5wGGO06nWI+cE6z llVDTB2uTP1OtkCyEhkntLu/z2kEPSdQoJ6Dan4HyYYYgBlHYoU8kvRNtjpMOOG1uJbG J3SmXYymP3r+Eycc/YCciSki3KQY121B2d2q9sHLtfLzijmRt6tOrEsSlqBPC1/oFXqe rAug== X-Forwarded-Encrypted: i=1; AJvYcCViFWYR9HNeGCW3kF1wBFu0UorcEp2JY1J+Fs84+hqqFC0EQIDQZlrzl6bqlQRsmodFbTnI2oE2GUqaDPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzA0XJVuxd2LFwFYRAiWwZ/Fw7H3ERacl3o1IAY+bo//uYjBFQa ScYPdhzftpCa3wnId/D15iBx6T0Li/FmFzv9ebl7sw7buJHtZPzrk6perCVf6C0U74f7YQ1Yi3L vqzX1uIZiAQ== X-Google-Smtp-Source: AGHT+IFd71ZjRBakGhbafgnPTzrixccPSZLeSg9hHh43AJijBVxQ6iVQT+Cq9+9/FUnZC5J4hMdzOxh4UJP/ X-Received: from pjtu3.prod.google.com ([2002:a17:90a:c883:b0:32e:6111:40ac]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1648:b0:32d:d714:b3d9 with SMTP id 98e67ed59e1d1-32de4f9be8dmr11359334a91.31.1757874551179; Sun, 14 Sep 2025 11:29:11 -0700 (PDT) Date: Sun, 14 Sep 2025 11:29:00 -0700 In-Reply-To: <20250914182900.1960567-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250914182900.1960567-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250914182900.1960567-5-irogers@google.com> Subject: [PATCH v1 4/4] perf stat-shadow: Display metric-only for 0 counters From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 0 counters may occur in hypervisor settings but metric-only output is always expected. This resolves an issue in the "perf stat STD output linter" test. Signed-off-by: Ian Rogers --- tools/perf/util/stat-display.c | 3 +++ tools/perf/util/stat-shadow.c | 11 ++++------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index a67b991f4e81..8a72e019e6c7 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -944,6 +944,9 @@ static bool should_skip_zero_counter(struct perf_stat_c= onfig *config, if (verbose =3D=3D 0 && counter->skippable && !counter->supported) return true; =20 + /* Metric only counts won't be displayed but the metric wants to be compu= ted. */ + if (config->metric_only) + return false; /* * Skip value 0 when enabling --per-thread globally, * otherwise it will have too many 0 output. diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c index abaf6b579bfc..dd3a15b17eb9 100644 --- a/tools/perf/util/stat-shadow.c +++ b/tools/perf/util/stat-shadow.c @@ -320,13 +320,10 @@ static void print_instructions(struct perf_stat_confi= g *config, double max_stalled =3D max(find_stat(evsel, aggr_idx, STAT_STALLED_CYCLES= _FRONT), find_stat(evsel, aggr_idx, STAT_STALLED_CYCLES_BACK)); =20 - if (cycles) { - print_metric(config, ctxp, METRIC_THRESHOLD_UNKNOWN, "%7.2f ", - "insn per cycle", instructions / cycles); - } else { - print_metric(config, ctxp, METRIC_THRESHOLD_UNKNOWN, /*fmt=3D*/NULL, - "insn per cycle", 0); - } + print_metric(config, ctxp, METRIC_THRESHOLD_UNKNOWN, "%7.2f ", + "insn per cycle", + fpclassify(cycles) =3D=3D FP_ZERO ? 0 : instructions = / cycles); + if (max_stalled && instructions) { if (out->new_line) out->new_line(config, ctxp); --=20 2.51.0.384.g4c02a37b29-goog