From nobody Thu Oct 2 19:30:15 2025 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCBC132CF79 for ; Fri, 12 Sep 2025 15:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757689870; cv=none; b=K8SBgTwAXlog94GzOWq61TLcOK0Qp0ECOwjB8oaxL9WTYH/4hof0K05Z2lLGocDFN9jEikHVf0TDxXx3dWeNhuZ/a+Qyt7h+3hIPL57kmRGZfE9FHXtA1HCCvwA0JT0QxhN4RJopQxEfpDuWQ9d7/WEOlX0R2ln0gQArQHDHZT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757689870; c=relaxed/simple; bh=HUD4Mjc5wMBAw/SAWwLyhxv8mf9k+BoSYkr0D6u7wvI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gas+2y162Zl3gj1Lii/s+QsUJD7aybYt3hvoSDo5IaNKWicpiZl2cZ6H+gnT8PbltWnQ3z1N6OHZAjX+i9gd4s1zkmxFXj/g7b8VlnMN0kg2qHSQ9vhlOmnAP/nVMkyXBI5C61RRaf26m0C51lMWxwfeOzNDmLvJv69s7KJj3zo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AKjzJCNu; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AKjzJCNu" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-71d60157747so14587557b3.0 for ; Fri, 12 Sep 2025 08:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757689868; x=1758294668; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TgoQ+woT/93cBsRw8kKeoK5/i5b3BJOE5ioHeOB3mNE=; b=AKjzJCNuqfuNkKu/VY2j98CAAa6ccyfjrnZ0yHYAqqlYremzksSlk347ea78qE6QTJ pXgun726DA8jIrcyHiabYvPFutlE2KoUT1NUmrgIBBTqUycpB0Jd7DpDrIajJq865I9Y DXnANmRo1GlOYOfirfAUaMwofDRHL4o1Q0WPEY/mQiOAx0jedN0xmhPXizBAje6kZ2uy zNMTaAubhD0d70tcU9ZHViggY0ifEV4U68nYQwFR/z08p3ZObeSSTnC0m32YbkPlW8qE St7Ic0RYZrZ6Cix+wQvCABy0D5PQAyo8aGgjzzy/26f6PLlWS8fepfgwlXhs5NA9huLm FcdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757689868; x=1758294668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TgoQ+woT/93cBsRw8kKeoK5/i5b3BJOE5ioHeOB3mNE=; b=RU5HLVJhoEfF4iEWvzpHGfEfOjlBaEV8PBS3mYRRs5yzR/u1ypuGgSV5e3XxKZkRJ9 cxa0u5baRvv/XrSye5BaT/lTZwpUsqRkPiKwGfhs6536svvmwCAMnHoPprbQo8yoPsH0 OTrDQzMH+jVWNbDTgJwPOavVO10zNR/G0IdiveEY2R7aJwNC5+XCw9TidSYE1za9826v YcmjAZawNP05Z4kR5H6M7XcprBPPqrEBCMyid+rXROaYocSu4eEjq4LSBesqgR+WYwGs So/dr7uE6WNysog+HC412yogr/wm+D7krmgIrUM83VM0l1Lub7vdyeWd5zySLbg9eSvq 0sTA== X-Forwarded-Encrypted: i=1; AJvYcCVgU/I+hGnREZG+8nb3f69aCzqH+S5r8t+OSjL5+/uK1xTXzknLNsAtDqNkxVY5zMP95jP0cyg2W3Xh1uY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7nAmAituPfPDq+ExdpR7wb84l7UaZ24p3j6w5lh8OYv3g5vKa PDZd6ysmYoVUNgYvJdvGs4T3+rGqRO6byGVJW40JXqU1ggdnHKce6y9YKVRBqmlaBME= X-Gm-Gg: ASbGncs3Gubo1pEa1iyiCK2myMcOggCdtjIy3vRJHAA+wIz0kypK7n2NUiSj9telUjs qykehjq5DJoalTHeN4DN/JGR4JE0kSZieC3oTzzDI6IU5T7ZpZwM82fxUXvrFyMVdyv0m3u3wHL YbqWftkj7S5VtSzhseYlmCmMiJsIg8mFcbtoVFoLfW0YWUNhwdviuUwiUggQl1owLVUcOxh4q1/ cHaCbSjmIJ8HxzxLLU2zIApBWAVGxkgKW7QsNyZCAi/xe0xAGtWLki+6EUF3bxfoNq5FsqE9nOK E5gMvtK/b34ccYGAowEnC8eht4bfQRU08HKfEQzIha/fra09mDO7SPt/cLjJjGUljYaVPfRlIt2 6ebn++nCJepSficRBJ2irV1lIeb+lklWj5A== X-Google-Smtp-Source: AGHT+IGUcGV4IM3PVToM3wIMhJFlncT19Inxpe70tej0adAKBemPa7cOoqolhGXuc6qPV6B9GeZ9vg== X-Received: by 2002:a05:690c:f92:b0:70e:2d17:84b5 with SMTP id 00721157ae682-7305f99fd82mr33784177b3.0.1757689867582; Fri, 12 Sep 2025 08:11:07 -0700 (PDT) Received: from eugen-station.. ([145.224.119.89]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-624841586c1sm1302244d50.6.2025.09.12.08.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 08:11:07 -0700 (PDT) From: Eugen Hristev To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, andersson@kernel.org, pmladek@suse.com, rdunlap@infradead.org, corbet@lwn.net, david@redhat.com, mhocko@suse.com Cc: tudor.ambarus@linaro.org, mukesh.ojha@oss.qualcomm.com, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, jonechou@google.com, rostedt@goodmis.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Eugen Hristev Subject: [RFC][PATCH v3 15/16] kmemdump: Add Kinfo backend driver Date: Fri, 12 Sep 2025 18:08:54 +0300 Message-ID: <20250912150855.2901211-16-eugen.hristev@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250912150855.2901211-1-eugen.hristev@linaro.org> References: <20250912150855.2901211-1-eugen.hristev@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add Kinfo backend driver. This backend driver will select only regions of interest for the firmware, and it copy those into a shared memory area that is supplied via OF. The firmware is only interested in addresses for some symbols. The list format is kinfo-compatible, with devices like Google Pixel phone. Signed-off-by: Eugen Hristev Tested-by: Tudor Ambarus --- MAINTAINERS | 5 + mm/kmemdump/Kconfig.debug | 13 ++ mm/kmemdump/Makefile | 1 + mm/kmemdump/kinfo.c | 293 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 312 insertions(+) create mode 100644 mm/kmemdump/kinfo.c diff --git a/MAINTAINERS b/MAINTAINERS index 8234acb24cbc..65d9e5db46a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13818,6 +13818,11 @@ F: include/linux/kmemdump.h F: mm/kmemdump/kmemdump.c F: mm/kmemdump/kmemdump_coreimage.c =20 +KMEMDUMP KINFO BACKEND DRIVER +M: Eugen Hristev +S: Maintained +F: mm/kmemdump/kinfo.c + KMEMDUMP QCOM MINIDUMP BACKEND DRIVER M: Eugen Hristev S: Maintained diff --git a/mm/kmemdump/Kconfig.debug b/mm/kmemdump/Kconfig.debug index 91cec45bc3ca..ff88bf8017ae 100644 --- a/mm/kmemdump/Kconfig.debug +++ b/mm/kmemdump/Kconfig.debug @@ -38,3 +38,16 @@ config KMEMDUMP_QCOM_MINIDUMP_BACKEND into the minidump table of contents. Further on, the firmware will be able to read the table of contents and extract the memory regions on case-by-case basis. + +config KMEMDUMP_KINFO_BACKEND + tristate "Shared memory KInfo compatible backend" + depends on KMEMDUMP + select VMCORE_INFO + help + Say y here to enable the Shared memory KInfo compatible backend + driver. + With this backend, the registered regions are copied to a shared + memory zone at register time. + The shared memory zone is supplied via OF. + This backend will select only regions that are of interest, + and keep only addresses. The format of the list is Kinfo compatible. diff --git a/mm/kmemdump/Makefile b/mm/kmemdump/Makefile index 6ec3871203ef..1ec94ee6c008 100644 --- a/mm/kmemdump/Makefile +++ b/mm/kmemdump/Makefile @@ -3,3 +3,4 @@ obj-y +=3D kmemdump.o obj-$(CONFIG_KMEMDUMP_COREIMAGE) +=3D kmemdump_coreimage.o obj-$(CONFIG_KMEMDUMP_QCOM_MINIDUMP_BACKEND) +=3D qcom_minidump.o +obj-$(CONFIG_KMEMDUMP_KINFO_BACKEND) +=3D kinfo.o diff --git a/mm/kmemdump/kinfo.c b/mm/kmemdump/kinfo.c new file mode 100644 index 000000000000..9f0ec8a1aaa2 --- /dev/null +++ b/mm/kmemdump/kinfo.c @@ -0,0 +1,293 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * + * Copyright 2002 Rusty Russell IBM Corporation + * Copyright 2021 Google LLC + * Copyright 2025 Linaro Ltd. Eugen Hristev + */ +#include +#include +#include +#include +#include +#include +#include +#include + +#define BUILD_INFO_LEN 256 +#define DEBUG_KINFO_MAGIC 0xCCEEDDFF + +/* + * Header structure must be byte-packed, since the table is provided to + * bootloader. + */ +struct kernel_info { + /* For kallsyms */ + __u8 enabled_all; + __u8 enabled_base_relative; + __u8 enabled_absolute_percpu; + __u8 enabled_cfi_clang; + __u32 num_syms; + __u16 name_len; + __u16 bit_per_long; + __u16 module_name_len; + __u16 symbol_len; + __u64 _relative_pa; + __u64 _text_pa; + __u64 _stext_pa; + __u64 _etext_pa; + __u64 _sinittext_pa; + __u64 _einittext_pa; + __u64 _end_pa; + __u64 _offsets_pa; + __u64 _names_pa; + __u64 _token_table_pa; + __u64 _token_index_pa; + __u64 _markers_pa; + __u64 _seqs_of_names_pa; + + /* For frame pointer */ + __u32 thread_size; + + /* For virt_to_phys */ + __u64 swapper_pg_dir_pa; + + /* For linux banner */ + __u8 last_uts_release[__NEW_UTS_LEN]; + + /* Info of running build */ + __u8 build_info[BUILD_INFO_LEN]; + + /* For module kallsyms */ + __u32 enabled_modules_tree_lookup; + __u32 mod_mem_offset; + __u32 mod_kallsyms_offset; +} __packed; + +struct kernel_all_info { + __u32 magic_number; + __u32 combined_checksum; + struct kernel_info info; +} __packed; + +struct debug_kinfo { + struct device *dev; + void *all_info_addr; + u32 all_info_size; + struct kmemdump_backend kinfo_be; +}; + +static struct debug_kinfo *kinfo; + +#define be_to_kinfo(be) container_of(be, struct debug_kinfo, kinfo_be) + +static void update_kernel_all_info(struct kernel_all_info *all_info) +{ + int index; + struct kernel_info *info; + u32 *checksum_info; + + all_info->magic_number =3D DEBUG_KINFO_MAGIC; + all_info->combined_checksum =3D 0; + + info =3D &all_info->info; + checksum_info =3D (u32 *)info; + for (index =3D 0; index < sizeof(*info) / sizeof(u32); index++) + all_info->combined_checksum ^=3D checksum_info[index]; +} + +static int build_info_set(const char *str, const struct kernel_param *kp) +{ + struct kernel_all_info *all_info =3D kinfo->all_info_addr; + size_t build_info_size; + + if (kinfo->all_info_addr =3D=3D 0 || kinfo->all_info_size =3D=3D 0) + return -ENAVAIL; + + all_info =3D (struct kernel_all_info *)kinfo->all_info_addr; + build_info_size =3D sizeof(all_info->info.build_info); + + memcpy(&all_info->info.build_info, str, min(build_info_size - 1, + strlen(str))); + update_kernel_all_info(all_info); + + if (strlen(str) > build_info_size) { + pr_warn("%s: Build info buffer (len: %zd) can't hold entire string '%s'\= n", + __func__, build_info_size, str); + return -ENOMEM; + } + + return 0; +} + +static const struct kernel_param_ops build_info_op =3D { + .set =3D build_info_set, +}; + +module_param_cb(build_info, &build_info_op, NULL, 0200); +MODULE_PARM_DESC(build_info, "Write build info to field 'build_info' of de= bug kinfo."); + +static int register_kinfo_region(const struct kmemdump_backend *be, + enum kmemdump_uid id, void *vaddr, size_t size) +{ + struct debug_kinfo *kinfo =3D be_to_kinfo(be); + struct kernel_all_info *all_info =3D kinfo->all_info_addr; + struct kernel_info *info =3D &all_info->info; + struct uts_namespace *uts; + + switch (id) { + case KMEMDUMP_ID_COREIMAGE__sinittext: + info->_sinittext_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE__einittext: + info->_einittext_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE__end: + info->_end_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE__text: + info->_text_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE__stext: + info->_stext_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE__etext: + info->_etext_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_num_syms: + info->num_syms =3D *(__u32 *)vaddr; + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_relative_base: + info->_relative_pa =3D (u64)__pa(*(u64 *)vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_offsets: + info->_offsets_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_names: + info->_names_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_token_table: + info->_token_table_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_token_index: + info->_token_index_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_markers: + info->_markers_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_kallsyms_seqs_of_names: + info->_seqs_of_names_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_swapper_pg_dir: + info->swapper_pg_dir_pa =3D (u64)__pa(vaddr); + break; + case KMEMDUMP_ID_COREIMAGE_init_uts_ns: + uts =3D vaddr; + strscpy(info->last_uts_release, uts->name.release, __NEW_UTS_LEN); + break; + default: + break; + }; + + update_kernel_all_info(all_info); + return 0; +} + +static int unregister_kinfo_region(const struct kmemdump_backend *be, + enum kmemdump_uid id) +{ + return 0; +} + +static int debug_kinfo_probe(struct platform_device *pdev) +{ + struct device_node *mem_region; + struct reserved_mem *rmem; + struct kernel_info *info; + struct kernel_all_info *all_info; + + mem_region =3D of_parse_phandle(pdev->dev.of_node, "memory-region", 0); + if (!mem_region) { + dev_warn(&pdev->dev, "no such memory-region\n"); + return -ENODEV; + } + + rmem =3D of_reserved_mem_lookup(mem_region); + if (!rmem) { + dev_warn(&pdev->dev, "no such reserved mem of node name %s\n", + pdev->dev.of_node->name); + return -ENODEV; + } + + /* Need to wait for reserved memory to be mapped */ + if (!rmem->priv) + return -EPROBE_DEFER; + + if (!rmem->base || !rmem->size) { + dev_warn(&pdev->dev, "unexpected reserved memory\n"); + return -EINVAL; + } + + if (rmem->size < sizeof(struct kernel_all_info)) { + dev_warn(&pdev->dev, "unexpected reserved memory size\n"); + return -EINVAL; + } + + kinfo =3D kzalloc(sizeof(*kinfo), GFP_KERNEL); + if (!kinfo) + return -ENOMEM; + + kinfo->dev =3D &pdev->dev; + + strscpy(kinfo->kinfo_be.name, "debug_kinfo"); + kinfo->kinfo_be.register_region =3D register_kinfo_region; + kinfo->kinfo_be.unregister_region =3D unregister_kinfo_region; + kinfo->all_info_addr =3D rmem->priv; + kinfo->all_info_size =3D rmem->size; + + all_info =3D kinfo->all_info_addr; + + memset(all_info, 0, sizeof(struct kernel_all_info)); + info =3D &all_info->info; + info->enabled_all =3D IS_ENABLED(CONFIG_KALLSYMS_ALL); + info->enabled_absolute_percpu =3D IS_ENABLED(CONFIG_KALLSYMS_ABSOLUTE_PER= CPU); + info->enabled_base_relative =3D IS_ENABLED(CONFIG_KALLSYMS_BASE_RELATIVE); + info->enabled_cfi_clang =3D IS_ENABLED(CONFIG_CFI_CLANG); + info->name_len =3D KSYM_NAME_LEN; + info->bit_per_long =3D BITS_PER_LONG; + info->module_name_len =3D MODULE_NAME_LEN; + info->symbol_len =3D KSYM_SYMBOL_LEN; + info->thread_size =3D THREAD_SIZE; + info->enabled_modules_tree_lookup =3D IS_ENABLED(CONFIG_MODULES_TREE_LOOK= UP); + info->mod_mem_offset =3D offsetof(struct module, mem); + info->mod_kallsyms_offset =3D offsetof(struct module, kallsyms); + + return kmemdump_register_backend(&kinfo->kinfo_be); +} + +static void debug_kinfo_remove(struct platform_device *pdev) +{ + kfree(kinfo); + kmemdump_unregister_backend(&kinfo->kinfo_be); +} + +static const struct of_device_id debug_kinfo_of_match[] =3D { + { .compatible =3D "google,debug-kinfo" }, + {}, +}; +MODULE_DEVICE_TABLE(of, debug_kinfo_of_match); + +static struct platform_driver debug_kinfo_driver =3D { + .probe =3D debug_kinfo_probe, + .remove =3D debug_kinfo_remove, + .driver =3D { + .name =3D "debug-kinfo", + .of_match_table =3D of_match_ptr(debug_kinfo_of_match), + }, +}; +module_platform_driver(debug_kinfo_driver); + +MODULE_AUTHOR("Eugen Hristev "); +MODULE_AUTHOR("Jone Chou "); +MODULE_DESCRIPTION("kmemdump Kinfo Driver"); +MODULE_LICENSE("GPL"); --=20 2.43.0