From nobody Thu Oct 2 19:40:16 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B4602FD7CF for ; Fri, 12 Sep 2025 10:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757674063; cv=none; b=t4HkvWBhqQWVBUjWlP60eyL866KqWM4t+IBGNJKpC+euyjkodprAia7aKoolaT0Hqg7FKLgrUKKrdiXUFbOZtSprnXUOyQDuypY97OaZYPOOYJWjgYpibOnnACuAe9P0XlS+jDVKXAMrAm4PV49v+PVTjM2zFGo5D/uNcJ2eOE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757674063; c=relaxed/simple; bh=OlTOFvKJfT0A22fcOpYTqFab8+1TW6hkZGEds47Z0Qk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0z8SV4knIflV00QNtR+j2YD+k5930lAp/Du3wfvL4kDUAHQFtoxBO72MuaJTOIqvbn/nHQi3Bt2Sm9gtxkq1m0/76DPNPPoI39eDFZjL6Zv35/3CfG1HTbsLJlEYWkM8auY7mvLmLOaHP9IIma2A5OZGUP8HpjM9um4N8jkTUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kadm2p5q; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kadm2p5q" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3e7622483beso932970f8f.3 for ; Fri, 12 Sep 2025 03:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757674058; x=1758278858; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fdCzNJXdDljgG/kIDC0Ddrqtrlk8v9FUTdWx7KN6R8Q=; b=Kadm2p5qfS0acoZk72bNm8J+JOBxE0R7+Bcvs9FG+tbZ016dTIwAQbeZsQiS8xyFgV h1Q/jxI+fttRzVRwEwfKHST94fTXOVO8W98tq8ib57K4uuQ8NQLrggbskG3VtHJOON7O vK6hCJdRK686mqtvISA7x4c7lEUtYUBcThvGT/W8QZS45iTTqXjx9QHrdIMnWAuMDu/z VQgToeWaKvG7w+e6x3JzklivpTYbuXDzvfMS/uoMyskOt4FJ+PncHV3U1GTmbtGOU0s0 6pgRDh7MCDqnzUoMQU/yNrxKrplGHf0KMxAq+pEB9XvUK5y/115gNItum0561XPT1VaQ xkpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757674058; x=1758278858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fdCzNJXdDljgG/kIDC0Ddrqtrlk8v9FUTdWx7KN6R8Q=; b=TS+Z6jyGoWCjRjrG02zFRIM1nVwZB2NAfGMuMjs3H+fHTrk2LJYuggRV507vfwPz7s GU/lrMSAe+ZbusiYhc2ilUf6iXdo6vzJfHPRkwMKie2IMA6NYQsPuQKlNeUkGQH3t4I+ wwD2CEEUKKCZEFTJc5h/U5e1Rx4vpmUa7g1nYIgi8DGvIS/IXUhk0KuiSPgzwscaidZE /WVLLKjduXgKeW16zajWK97t53cBdgFVUDgpkILNKNzkWt8PLoLHi/wDSu/KvIytUE55 qZdIR8bxufWASjgA9uKMovh5r8VHQI29alTFyGfFO1K+2MbIdzqfmlYsfH3xGTGpwONY C+cQ== X-Forwarded-Encrypted: i=1; AJvYcCUeaqOHH1ZhvWoqK580MSTwNH2FlEQZuDSzNRoEHxjEi5Vt2WHNNjOXk1JhKJm5FtWhJt3xiWOaqhzGoJA=@vger.kernel.org X-Gm-Message-State: AOJu0YwxLicTG2Wvf4NSLdWZR4kYQVhLw08Fe+DjkhPefVNYjq37DQLj PGS0hsQfv3ncj+pbPf8HD7na95raSEzZt1SFynnD6mi8cea29C23Y6cCfbAriH5N X-Gm-Gg: ASbGncul9G2ImOQ53pQ9/XYFFrDUjwZEAMGIT9Uzyq75iMonQFqsl64zqawhAfgjKVX SzgWf5WsM1V98nv3iVLh8HL85PfrBg3XO39Lhx3zvAs/TJp/baGSEkKrgfp9TDqxO4Dlrw+NomE 8+vsmziAwL8JDoV4TTzlrOggZBKA5GZKIKKvZF4XPN2i47EiCDcquzWzaEMMkWPTcidLBe1mvyx OaUr212QzloiAnVVMwGtdOeHaqnXXDOSLaWcdfDq+HbyTQFWynr33wdu7zP1C8FMgLKUaUygqrG WibEaNgXaBvNfHTr0tY8EilSsDiCfFXWdWrVe1/RzKzNFLi+SWJvDa83Xeh2RJCCVeFlDWpNFkY yRDO1wYPZvd3l7I1ZvwuhO9PQC39DzoQW+fsGOhdto0UCD/PrBGKDutNmLPSvDGrxEb3T/+krm6 9eyA== X-Google-Smtp-Source: AGHT+IFX7SP3Nc3fAURuh1zzId9OJYmZNsTdzvaZuLmsYmsYDvGx6+heBUvwIB58UK6jq1AeT+W/1g== X-Received: by 2002:a05:6000:1a8c:b0:3df:4fd3:6e95 with SMTP id ffacd0b85a97d-3e765a051b7mr1893543f8f.34.1757674058280; Fri, 12 Sep 2025 03:47:38 -0700 (PDT) Received: from biju.lan (host86-139-30-37.range86-139.btcentralplus.com. [86.139.30.37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd329sm6197316f8f.31.2025.09.12.03.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 03:47:38 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v2 5/7] can: rcar_canfd: Invert CAN clock and close_candev() order Date: Fri, 12 Sep 2025 11:47:23 +0100 Message-ID: <20250912104733.173281-6-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250912104733.173281-1-biju.das.jz@bp.renesas.com> References: <20250912104733.173281-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geert Uytterhoeven The CAN clock is enabled before calling open_candev(), and disabled before calling close_candev(). Invert the order of the latter, to restore symmetry. Signed-off-by: Geert Uytterhoeven Reviewed-by: Biju Das Signed-off-by: Biju Das --- v1->v2: * Collected tag --- drivers/net/can/rcar/rcar_canfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index c26a605659eb..f0dfab177b98 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -1569,8 +1569,8 @@ static int rcar_canfd_close(struct net_device *ndev) netif_stop_queue(ndev); rcar_canfd_stop(ndev); napi_disable(&priv->napi); - clk_disable_unprepare(gpriv->can_clk); close_candev(ndev); + clk_disable_unprepare(gpriv->can_clk); phy_power_off(priv->transceiver); return 0; } --=20 2.43.0