From nobody Thu Oct 2 19:04:26 2025 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D0827EC7C for ; Fri, 12 Sep 2025 10:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.51.26.146 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757672109; cv=none; b=MlKh4pb9QM3ObjK2/Ye5Cj1u19CG2K0i0H5BFx52lWGWKgzSZ0tcc7U74xTqiLqY4De66G9XZPoXYffgwRjgtr68PMrxZjivEUblHSuRUnlrDsQhjHVs8T+QkQsEc4yVv4UM2puwUwwSsFkZwgikBGDzTaLLQ+KRsMGQzmYzsCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757672109; c=relaxed/simple; bh=Wqc4PSuQxVxondoZXB1b6xHH5GpS8US7xvzX3T6eTjQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=WvwKXx1cMsb3aPu9rtXlD3j2ZCNodMZIU3Tbyw2xazejhvR2TEwaEB7jCHDmRLRUwJLuWv9Lo+C6oZb1fCDwlp6FrLamXtFSRS0XvK/KWkq+Bs48SALiSwCiwGwX2bGMCmoUxAmKdJolFiW4al2HskSUYPEr46QaUNtIf1wVHqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com; spf=pass smtp.mailfrom=inspur.com; arc=none smtp.client-ip=210.51.26.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inspur.com Received: from jtjnmail201610.home.langchao.com by unicom146.biz-email.net ((D)) with ASMTP (SSL) id 202509121814533872; Fri, 12 Sep 2025 18:14:53 +0800 Received: from locahost.localdomain.com (10.94.9.215) by jtjnmail201610.home.langchao.com (10.100.2.10) with Microsoft SMTP Server id 15.1.2507.57; Fri, 12 Sep 2025 18:14:54 +0800 From: Charles Han To: , , , CC: , Charles Han Subject: [PATCH] misc: amd-sbi: Add NULL check in create_misc_rmi_device Date: Fri, 12 Sep 2025 18:14:51 +0800 Message-ID: <20250912101451.1928-1-hanchunchao@inspur.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tUid: 20259121814536597104dcdccf3c6ad174a6980de98bc X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Content-Type: text/plain; charset="utf-8" Add check for the return value of devm_kmemdup() to prevent potential null pointer dereference. Fixes: 35ac2034db72 ("misc: amd-sbi: Add support for AMD_SBI IOCTL") Signed-off-by: Charles Han --- drivers/misc/amd-sbi/rmi-core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/misc/amd-sbi/rmi-core.c b/drivers/misc/amd-sbi/rmi-cor= e.c index 3dec2fc00124..50b8e9e02833 100644 --- a/drivers/misc/amd-sbi/rmi-core.c +++ b/drivers/misc/amd-sbi/rmi-core.c @@ -471,6 +471,9 @@ int create_misc_rmi_device(struct sbrmi_data *data, GFP_KERNEL, "sbrmi-%x", data->dev_static_addr); + if (!data->sbrmi_misc_dev.name) + return -ENOMEM; + data->sbrmi_misc_dev.minor =3D MISC_DYNAMIC_MINOR; data->sbrmi_misc_dev.fops =3D &sbrmi_fops; data->sbrmi_misc_dev.parent =3D dev; @@ -478,6 +481,9 @@ int create_misc_rmi_device(struct sbrmi_data *data, GFP_KERNEL, "sbrmi-%x", data->dev_static_addr); + if (!data->sbrmi_misc_dev.nodename) + return -ENOMEM; + data->sbrmi_misc_dev.mode =3D 0600; =20 return misc_register(&data->sbrmi_misc_dev); --=20 2.43.0