From nobody Thu Oct 2 20:27:33 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D75472E7BAE for ; Fri, 12 Sep 2025 10:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757671945; cv=none; b=MBI2E+Uxt5mjBSdXknFV7IyDlIjPYHex0OIlTCU8rGt9Iv5u8wnBjfU4Xv1wQ7va+tp6k/saLVzBb8MGZuTNn/QWCAcAsAkXSSLTvIn/EK2UeKTxHWams8qo/m6Lk2dlJy0CZZScY2pdJdm77OeTqz6y8VE294jhmA0eUhjs7RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757671945; c=relaxed/simple; bh=xhEgADxCH9HYuhwsYpDsUfcMELRNH4wMvbrMimvNP+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=McT6PscNp9K+JTfGpcNhk8ip9vrbEpRdgZVj2weYv5q6VS0bMLA1lv4wUij87YIrn6y67tphBwmqi8yc76fEpP2q4sLr5nM4FmTA0zjYLShXTse6zG+ucoB0eWqAX/jO/PwFeaU7/JTnignl1ieDkfa2n0kyWXb62lQz1BaGOJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c15xj1QS; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c15xj1QS" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7741991159bso2554948b3a.0 for ; Fri, 12 Sep 2025 03:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757671942; x=1758276742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JWZ0kuFk/JGga2KckHsx8bbCMGd9rBXEdZWbqFyn8fw=; b=c15xj1QSKbz4R78VR5Ydnn9qhuKW+VxOvGuRwITXMiYCDEIzarIhBT0b6Qv1LZdLfC 2A+IYSKSr7ChOY6791wVSjLOJi7C9DuktUcAH/CAbeq10xOg52Drc6z6GmfYoLYKczAZ ZHtySvi3DhvAIAU7tp4uI/weAx/4rsfuhPh6PhZg2Ja1dzPQNiWAIvlYJcyl1cTch/0v 25S3mDAGcJZ3otwywQDssYLnxFQRwCwxuWyyCvNq8b625tDBO+A9X/aWfx+vxXpE7u6r u3xmQuntV4qkUjJXnW6rCQgqmN745W9704bskr9MmqYxEBOZ9OKLn3HBkhTRYPzoLl1V /SUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757671942; x=1758276742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JWZ0kuFk/JGga2KckHsx8bbCMGd9rBXEdZWbqFyn8fw=; b=Unw+XMH5Ru7QsJnk9JsYRmcs4ClJckLc3YBVQlJZXyahICfCV9wlDF4+G8ETNk+AKF llVr+GEAMdULW94d2KKlK6vyVdEKWDkSSyhQPzDamhx8G3Ea96msAw5MmZo44J1b/76F 6Qd7z+bQS0SBqbtt7dxDP+Eq735OSo6NtO4Kmrx+vcf3LfEngguf7qeAPX7VqtG6NmQD 7ydG6ZOXTX2+D3QbnNoyViGqPOFfpo0xvTqmydw7fshf+kZ9u8Urh3FJH8//wrN4qjLK xJZlmLLDvWxgkfhw0YkbPVcdY7QSGLrn4UrMQeFmn+gWd0dH7ZaOQZyQo76Sn9+0Fqf2 d/dA== X-Forwarded-Encrypted: i=1; AJvYcCXfEusSPjd7mQMeQ9ZanPqjspiTo7QXcxxnfjzoP0QC8+3tuheDFc8yl0weUukjzncrUlhjkOvjIrERUz8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrfmdYPFJiG5p++J9OG0qQ+wLq02H9bBDQaRq8aTIp89aircF5 ikNGijVuPz+ZvK/ljBReU2XxJ1k7MZgxqcmxdFH5u/gcZqhOP45AJ+dR X-Gm-Gg: ASbGnctf26svTZq94RpXMQfAGXST9KeBI41pEmMIWxtfhv6kNKrRHAOC7vkuvwM564h ewgEyax5EV8AgVuqZsvMIX1avMAnTm0waoduwZYJ7C8cblg54d38+qY7j7U3dM/D6ZbJjNKV/3o wqXMTCp7Xsa+pM2nT49EPfPXi8Bmcu1x+GaukK5D1gxdaeWkGYMlX4K8maP4pSzvohxgbTZwuOB k/xCT5HmkFyz+zBkWPnuJE9Gghph5KSOhp8/yEqTA/Z5LDzMyV9zPjxCNM46nVcCtJLxmXIAE/B sH4u8W2qQC4ou/py6AZqKO+lk3Rjn1awQnRm3tBQTW50vvGPLrdVfficfbfmTvVduq+/ZLbAs/x gKsVOdMexqk3G6/3J63/jOchRPLxy9hnY4LhGvYY2vrj6Nrswsw== X-Google-Smtp-Source: AGHT+IE8+93TdDPnsE4atda/JWPbNWLLDtzQ/rRojiuKNJS4zwHA9ycGi7y7HjIuRi4Y0KG1ZDhRqQ== X-Received: by 2002:a05:6a00:812:b0:772:5899:eae8 with SMTP id d2e1a72fcca58-77612189a24mr2770987b3a.27.1757671941982; Fri, 12 Sep 2025 03:12:21 -0700 (PDT) Received: from localhost ([185.49.34.62]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77607a46eedsm4969144b3a.30.2025.09.12.03.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 03:12:21 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v4 05/21] mm/ksw: add ksw_config struct and parser Date: Fri, 12 Sep 2025 18:11:15 +0800 Message-ID: <20250912101145.465708-6-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250912101145.465708-1-wangjinchao600@gmail.com> References: <20250912101145.465708-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add struct ksw_config and ksw_parse_config() to parse user string. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 91 ++++++++++++++++++++++++++++++++++++ mm/kstackwatch/kstackwatch.h | 33 +++++++++++++ 2 files changed, 124 insertions(+) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 40aa7e9ff513..1502795e02af 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -1,20 +1,111 @@ // SPDX-License-Identifier: GPL-2.0 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 +#include #include +#include + +#include "kstackwatch.h" =20 MODULE_AUTHOR("Jinchao Wang"); MODULE_DESCRIPTION("Kernel Stack Watch"); MODULE_LICENSE("GPL"); =20 +static struct ksw_config *ksw_config; + +/* + * Format of the configuration string: + * function+ip_offset[+depth] [local_var_offset:local_var_len] + * + * - function : name of the target function + * - ip_offset : instruction pointer offset within the function + * - depth : recursion depth to watch + * - local_var_offset : offset from the stack pointer at function+ip_offset + * - local_var_len : length of the local variable(1,2,4,8) + */ +static int __maybe_unused ksw_parse_config(char *buf, struct ksw_config *c= onfig) +{ + char *func_part, *local_var_part =3D NULL; + char *token; + u16 local_var_len; + + memset(ksw_config, 0, sizeof(*ksw_config)); + + /* set the watch type to the default canary-based watching */ + config->type =3D WATCH_CANARY; + + func_part =3D strim(buf); + strscpy(config->config_str, func_part, MAX_CONFIG_STR_LEN); + + local_var_part =3D strchr(func_part, ' '); + if (local_var_part) { + *local_var_part =3D '\0'; // terminate the function part + local_var_part =3D strim(local_var_part + 1); + } + + /* parse the function part: function+ip_offset[+depth] */ + token =3D strsep(&func_part, "+"); + if (!token) + goto fail; + + strscpy(config->function, token, MAX_FUNC_NAME_LEN - 1); + + token =3D strsep(&func_part, "+"); + if (!token || kstrtou16(token, 0, &config->ip_offset)) { + pr_err("failed to parse instruction offset\n"); + goto fail; + } + + token =3D strsep(&func_part, "+"); + if (token && kstrtou16(token, 0, &config->depth)) { + pr_err("failed to parse depth\n"); + goto fail; + } + if (!local_var_part || !(*local_var_part)) + return 0; + + /* parse the optional local var offset:len */ + config->type =3D WATCH_LOCAL_VAR; + token =3D strsep(&local_var_part, ":"); + if (!token || kstrtou16(token, 0, &config->local_var_offset)) { + pr_err("failed to parse local var offset\n"); + goto fail; + } + + if (!local_var_part || kstrtou16(local_var_part, 0, &local_var_len)) { + pr_err("failed to parse local var len\n"); + goto fail; + } + + if (local_var_len !=3D 1 && local_var_len !=3D 2 && + local_var_len !=3D 4 && local_var_len !=3D 8) { + pr_err("invalid local var len %u (must be 1,2,4,8)\n", + local_var_len); + goto fail; + } + config->local_var_len =3D local_var_len; + + return 0; +fail: + pr_err("invalid input: %s\n", config->config_str); + config->config_str[0] =3D '\0'; + return -EINVAL; +} + static int __init kstackwatch_init(void) { + ksw_config =3D kzalloc(sizeof(*ksw_config), GFP_KERNEL); + if (!ksw_config) + return -ENOMEM; + pr_info("module loaded\n"); return 0; } =20 static void __exit kstackwatch_exit(void) { + kfree(ksw_config); + pr_info("module unloaded\n"); } =20 diff --git a/mm/kstackwatch/kstackwatch.h b/mm/kstackwatch/kstackwatch.h index 0273ef478a26..7c595c5c24d1 100644 --- a/mm/kstackwatch/kstackwatch.h +++ b/mm/kstackwatch/kstackwatch.h @@ -2,4 +2,37 @@ #ifndef _KSTACKWATCH_H #define _KSTACKWATCH_H =20 +#include + +#define MAX_FUNC_NAME_LEN 64 +#define MAX_CONFIG_STR_LEN 128 + +enum watch_type { + WATCH_CANARY =3D 0, + WATCH_LOCAL_VAR, +}; + +struct ksw_config { + /* function part */ + char function[MAX_FUNC_NAME_LEN]; + u16 ip_offset; + u16 depth; + + /* local var, useless for canary watch */ + /* offset from rsp at function+ip_offset */ + u16 local_var_offset; + + /* + * local var size (1,2,4,8 bytes) + * it will be the watching len + */ + u16 local_var_len; + + /* easy for understand*/ + enum watch_type type; + + /* save to show */ + char config_str[MAX_CONFIG_STR_LEN]; +}; + #endif /* _KSTACKWATCH_H */ --=20 2.43.0