From nobody Thu Oct 2 20:27:50 2025 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974AB2DF132 for ; Fri, 12 Sep 2025 09:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757668846; cv=none; b=X/tDhIU3v64yi17OEo3LGKArJTovk/8Aw+busABzTDLHMDRYkKW9PaqTjhQUpTK9WLA+yamSZtX2UwyH08ceA3JL2kB5y8IQVf+gQTXvQ5/0OxvbHn7+evpMmjt/ownsi7luhgxlMeUWc6ZrbDiENZn5FebU99VmE2y9m772bB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757668846; c=relaxed/simple; bh=490XaeJOSXOPOipAwlaja6D50/cNV+4mssGhLZMnMJo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TNZrE/ylNGdMVd1QPoKzKp/keM/fbvOxFY9DEMg87eOCUl5mi271IwDGqNW7udPbMYXG+csyy/YftX0Xp0gQio+RZAVOySWxNyrnUGqhsZJwOWj7cSrk38wnPPoEPoynNYJ9F5OJML5viLhZMTp2Bz8fUvudqSpgm0A32HvsnOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UOHOzuUb; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UOHOzuUb" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-32de096bf8aso1210326a91.2 for ; Fri, 12 Sep 2025 02:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757668843; x=1758273643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgDT8yas3IcACX8dpF1Z+jTHl5S85Xg0OLjTZ81TkYA=; b=UOHOzuUb45N4osHau19ITbQhlJ5LHhfyenMkBxeFC25t5i2kVamZ2Qb4JcYIxCyPhv dGebg6l+Hm6h6+5HqKuVvVpcc/1mpsNLPQzs//xh+yjbg40bCui2LLsZO5M7kXXstEd1 LgusTq4e+TvagY27d26bi5V7y3jdYPW1QJ26+ZOrAnLI9Jvdupgdir+DiZzLYw+rvSml bHe7sHly3uti++I+SGw7mous5xla/OmGiOtXlhl0AtumVvuTA4RBZhgToCXyfpFB0YWc 14LpcBX+2H9yYSu939PY3IZpHURkPphtbfbVG+Z8Z5BCJX6lcZlr9+7154KE48p+TEhT xoJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757668843; x=1758273643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GgDT8yas3IcACX8dpF1Z+jTHl5S85Xg0OLjTZ81TkYA=; b=Qx5sTooPdyg/XuJEBJ9cAs4odklaEwf4o4mO2ADhLLgZqyZuKkH0nT4IRoqwIjOxlM YgHdXxkgm3pTTcda2yTqgXgjxQzJEUZx6UVqi381BJH4SSL8/pY5kp+iVRnKjpMbmMDn 7HDc2gTBlZQJWIQ1SGCQfwYbi3aiwh+JcIRNSlIiZr1QDkNYOMyRpYFOW2GfhRoMjDMn rbchEawjfjz+4fXyS6ogNk/hqtwKnVHxB0eseHcmUgseeGFpjb1CmQpWJMz0YAgcYCXV SJ9QdZbKAYaetRR3BVts7xIWZ7x1NAqPZo70NIP0MEaSL/FQeEXnWxTpGIQkp8MVRuNr LRog== X-Gm-Message-State: AOJu0YwQLBVYoEDm9DeMwthCLof2z8NMBMOrvpL6Vg8hAL46ck6S08M6 EvjdYR+NEJPnR1zYJt5++bsl1HArW/4hvPDB6Mux+jBAIoX+epUxKmHn X-Gm-Gg: ASbGncu542drCh26mF5Xq9TW2RsjCgW0GhQIbI+8RbeO5HSiKPOfzMoQRxFeCqpQIR1 p5+pIpNOE5nT2C9n54rfMfMPNqkWz3O8Ksr/9ptx5TTtX9kFpId9frL4Z/q+t6ZQNBak12jWVX/ sNxqp+EfLLCuo/rat8VMrciePiAQ8nc47iJFkVEKZbNA7M7HDmQ/27qLiN2T7SundkUfYVJ/+iv /qi2YQGiD8rXzICjNjIYPYbRqYB7lcvC+HlSwL/xkVvq/0PaX0n1ACQKJUjjLjjDGXrN4p4Y2jT 6iags9Tl/ljDFB5C9K2X5wZ9B8APAnpUNtBNftn0oX4oDNMSO7cPg7GbIxQ5VHIh/1FZVCXmfb5 SNvPqt1z9/2UWQ5fBpHoOQeQ4t6bGNInRBQdcCNg8J9QY6GRff43YIgVqkaYv3Ir3sQ== X-Google-Smtp-Source: AGHT+IExdBehpPUbHsaoXn2hWCJuv0LpOESNjTgw/5wU/Er5DJI4ga/ArIntuYfQJ3gORg8zNqnSQw== X-Received: by 2002:a17:90b:5110:b0:325:7845:fc52 with SMTP id 98e67ed59e1d1-32de5144bafmr2400546a91.25.1757668842632; Fri, 12 Sep 2025 02:20:42 -0700 (PDT) Received: from hcdev-d520mt2.. (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b54a36dc461sm4066564a12.23.2025.09.12.02.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 02:20:42 -0700 (PDT) From: a0282524688@gmail.com To: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de, mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net, jdelvare@suse.com, alexandre.belloni@bootlin.com Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, Ming Yu Subject: [PATCH RESEND v14 7/7] rtc: Add Nuvoton NCT6694 RTC support Date: Fri, 12 Sep 2025 17:19:52 +0800 Message-Id: <20250912091952.1169369-8-a0282524688@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250912091952.1169369-1-a0282524688@gmail.com> References: <20250912091952.1169369-1-a0282524688@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ming Yu This driver supports RTC functionality for NCT6694 MFD device based on USB interface. Acked-by: Alexandre Belloni Signed-off-by: Ming Yu --- Changes since version 13: Changes since version 12: - Use same email address in the signature Changes since version 11: Changes since version 10: Changes since version 9: - Add devm_add_action_or_reset() to dispose irq mapping Changes since version 8: - Modify the signed-off-by with my work address - Add irq_dispose_mapping() in the error handling path and in the remove function Changes since version 7: Changes since version 6: Changes since version 5: - Modify the module name and the driver name consistently Changes since version 4: - Modify arguments in read/write function to a pointer to cmd_header - Modify all callers that call the read/write function Changes since version 3: - Modify array buffer to structure - Fix defines and comments - Drop private mutex and use rtc core lock - Modify device_set_wakeup_capable() to device_init_wakeup() Changes since version 2: - Add MODULE_ALIAS() Changes since version 1: - Add each driver's command structure - Fix platform driver registration - Drop unnecessary logs - Fix overwrite error return values - Modify to use dev_err_probe API MAINTAINERS | 1 + drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-nct6694.c | 297 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 309 insertions(+) create mode 100644 drivers/rtc/rtc-nct6694.c diff --git a/MAINTAINERS b/MAINTAINERS index bbacc9d48a83..442f24a408a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18090,6 +18090,7 @@ F: drivers/hwmon/nct6694-hwmon.c F: drivers/i2c/busses/i2c-nct6694.c F: drivers/mfd/nct6694.c F: drivers/net/can/usb/nct6694_canfd.c +F: drivers/rtc/rtc-nct6694.c F: drivers/watchdog/nct6694_wdt.c F: include/linux/mfd/nct6694.h =20 diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 64f6e9756aff..4a8dc8d0a4b7 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -416,6 +416,16 @@ config RTC_DRV_NCT3018Y This driver can also be built as a module, if so, the module will be called "rtc-nct3018y". =20 +config RTC_DRV_NCT6694 + tristate "Nuvoton NCT6694 RTC support" + depends on MFD_NCT6694 + help + If you say yes to this option, support will be included for Nuvoton + NCT6694, a USB device to RTC. + + This driver can also be built as a module. If so, the module will + be called rtc-nct6694. + config RTC_DRV_RK808 tristate "Rockchip RK805/RK808/RK809/RK817/RK818 RTC" depends on MFD_RK8XX diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index 789bddfea99d..610a9ee5fd33 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile @@ -119,6 +119,7 @@ obj-$(CONFIG_RTC_DRV_MXC) +=3D rtc-mxc.o obj-$(CONFIG_RTC_DRV_MXC_V2) +=3D rtc-mxc_v2.o obj-$(CONFIG_RTC_DRV_GAMECUBE) +=3D rtc-gamecube.o obj-$(CONFIG_RTC_DRV_NCT3018Y) +=3D rtc-nct3018y.o +obj-$(CONFIG_RTC_DRV_NCT6694) +=3D rtc-nct6694.o obj-$(CONFIG_RTC_DRV_NTXEC) +=3D rtc-ntxec.o obj-$(CONFIG_RTC_DRV_OMAP) +=3D rtc-omap.o obj-$(CONFIG_RTC_DRV_OPAL) +=3D rtc-opal.o diff --git a/drivers/rtc/rtc-nct6694.c b/drivers/rtc/rtc-nct6694.c new file mode 100644 index 000000000000..35401a0d9cf5 --- /dev/null +++ b/drivers/rtc/rtc-nct6694.c @@ -0,0 +1,297 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Nuvoton NCT6694 RTC driver based on USB interface. + * + * Copyright (C) 2025 Nuvoton Technology Corp. + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +/* + * USB command module type for NCT6694 RTC controller. + * This defines the module type used for communication with the NCT6694 + * RTC controller over the USB interface. + */ +#define NCT6694_RTC_MOD 0x08 + +/* Command 00h - RTC Time */ +#define NCT6694_RTC_TIME 0x0000 +#define NCT6694_RTC_TIME_SEL 0x00 + +/* Command 01h - RTC Alarm */ +#define NCT6694_RTC_ALARM 0x01 +#define NCT6694_RTC_ALARM_SEL 0x00 + +/* Command 02h - RTC Status */ +#define NCT6694_RTC_STATUS 0x02 +#define NCT6694_RTC_STATUS_SEL 0x00 + +#define NCT6694_RTC_IRQ_INT_EN BIT(0) /* Transmit a USB INT-in when RTC al= arm */ +#define NCT6694_RTC_IRQ_GPO_EN BIT(5) /* Trigger a GPO Low Pulse when RTC = alarm */ + +#define NCT6694_RTC_IRQ_EN (NCT6694_RTC_IRQ_INT_EN | NCT6694_RTC_IRQ_GPO_E= N) +#define NCT6694_RTC_IRQ_STS BIT(0) /* Write 1 clear IRQ status */ + +struct __packed nct6694_rtc_time { + u8 sec; + u8 min; + u8 hour; + u8 week; + u8 day; + u8 month; + u8 year; +}; + +struct __packed nct6694_rtc_alarm { + u8 sec; + u8 min; + u8 hour; + u8 alarm_en; + u8 alarm_pend; +}; + +struct __packed nct6694_rtc_status { + u8 irq_en; + u8 irq_pend; +}; + +union __packed nct6694_rtc_msg { + struct nct6694_rtc_time time; + struct nct6694_rtc_alarm alarm; + struct nct6694_rtc_status sts; +}; + +struct nct6694_rtc_data { + struct nct6694 *nct6694; + struct rtc_device *rtc; + union nct6694_rtc_msg *msg; + int irq; +}; + +static int nct6694_rtc_read_time(struct device *dev, struct rtc_time *tm) +{ + struct nct6694_rtc_data *data =3D dev_get_drvdata(dev); + struct nct6694_rtc_time *time =3D &data->msg->time; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_TIME, + .sel =3D NCT6694_RTC_TIME_SEL, + .len =3D cpu_to_le16(sizeof(*time)) + }; + int ret; + + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, time); + if (ret) + return ret; + + tm->tm_sec =3D bcd2bin(time->sec); /* tm_sec expect 0 ~ 59 */ + tm->tm_min =3D bcd2bin(time->min); /* tm_min expect 0 ~ 59 */ + tm->tm_hour =3D bcd2bin(time->hour); /* tm_hour expect 0 ~ 23 */ + tm->tm_wday =3D bcd2bin(time->week) - 1; /* tm_wday expect 0 ~ 6 */ + tm->tm_mday =3D bcd2bin(time->day); /* tm_mday expect 1 ~ 31 */ + tm->tm_mon =3D bcd2bin(time->month) - 1; /* tm_month expect 0 ~ 11 */ + tm->tm_year =3D bcd2bin(time->year) + 100; /* tm_year expect since 1900 */ + + return ret; +} + +static int nct6694_rtc_set_time(struct device *dev, struct rtc_time *tm) +{ + struct nct6694_rtc_data *data =3D dev_get_drvdata(dev); + struct nct6694_rtc_time *time =3D &data->msg->time; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_TIME, + .sel =3D NCT6694_RTC_TIME_SEL, + .len =3D cpu_to_le16(sizeof(*time)) + }; + + time->sec =3D bin2bcd(tm->tm_sec); + time->min =3D bin2bcd(tm->tm_min); + time->hour =3D bin2bcd(tm->tm_hour); + time->week =3D bin2bcd(tm->tm_wday + 1); + time->day =3D bin2bcd(tm->tm_mday); + time->month =3D bin2bcd(tm->tm_mon + 1); + time->year =3D bin2bcd(tm->tm_year - 100); + + return nct6694_write_msg(data->nct6694, &cmd_hd, time); +} + +static int nct6694_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *a= lrm) +{ + struct nct6694_rtc_data *data =3D dev_get_drvdata(dev); + struct nct6694_rtc_alarm *alarm =3D &data->msg->alarm; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_ALARM, + .sel =3D NCT6694_RTC_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(*alarm)) + }; + int ret; + + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, alarm); + if (ret) + return ret; + + alrm->time.tm_sec =3D bcd2bin(alarm->sec); + alrm->time.tm_min =3D bcd2bin(alarm->min); + alrm->time.tm_hour =3D bcd2bin(alarm->hour); + alrm->enabled =3D alarm->alarm_en; + alrm->pending =3D alarm->alarm_pend; + + return ret; +} + +static int nct6694_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *al= rm) +{ + struct nct6694_rtc_data *data =3D dev_get_drvdata(dev); + struct nct6694_rtc_alarm *alarm =3D &data->msg->alarm; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_ALARM, + .sel =3D NCT6694_RTC_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(*alarm)) + }; + + alarm->sec =3D bin2bcd(alrm->time.tm_sec); + alarm->min =3D bin2bcd(alrm->time.tm_min); + alarm->hour =3D bin2bcd(alrm->time.tm_hour); + alarm->alarm_en =3D alrm->enabled ? NCT6694_RTC_IRQ_EN : 0; + alarm->alarm_pend =3D 0; + + return nct6694_write_msg(data->nct6694, &cmd_hd, alarm); +} + +static int nct6694_rtc_alarm_irq_enable(struct device *dev, unsigned int e= nabled) +{ + struct nct6694_rtc_data *data =3D dev_get_drvdata(dev); + struct nct6694_rtc_status *sts =3D &data->msg->sts; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_STATUS, + .sel =3D NCT6694_RTC_STATUS_SEL, + .len =3D cpu_to_le16(sizeof(*sts)) + }; + + if (enabled) + sts->irq_en |=3D NCT6694_RTC_IRQ_EN; + else + sts->irq_en &=3D ~NCT6694_RTC_IRQ_EN; + + sts->irq_pend =3D 0; + + return nct6694_write_msg(data->nct6694, &cmd_hd, sts); +} + +static const struct rtc_class_ops nct6694_rtc_ops =3D { + .read_time =3D nct6694_rtc_read_time, + .set_time =3D nct6694_rtc_set_time, + .read_alarm =3D nct6694_rtc_read_alarm, + .set_alarm =3D nct6694_rtc_set_alarm, + .alarm_irq_enable =3D nct6694_rtc_alarm_irq_enable, +}; + +static irqreturn_t nct6694_irq(int irq, void *dev_id) +{ + struct nct6694_rtc_data *data =3D dev_id; + struct nct6694_rtc_status *sts =3D &data->msg->sts; + static const struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_RTC_MOD, + .cmd =3D NCT6694_RTC_STATUS, + .sel =3D NCT6694_RTC_STATUS_SEL, + .len =3D cpu_to_le16(sizeof(*sts)) + }; + int ret; + + rtc_lock(data->rtc); + + sts->irq_en =3D NCT6694_RTC_IRQ_EN; + sts->irq_pend =3D NCT6694_RTC_IRQ_STS; + ret =3D nct6694_write_msg(data->nct6694, &cmd_hd, sts); + if (ret) { + rtc_unlock(data->rtc); + return IRQ_NONE; + } + + rtc_update_irq(data->rtc, 1, RTC_IRQF | RTC_AF); + + rtc_unlock(data->rtc); + + return IRQ_HANDLED; +} + +static void nct6694_irq_dispose_mapping(void *d) +{ + struct nct6694_rtc_data *data =3D d; + + irq_dispose_mapping(data->irq); +} + +static int nct6694_rtc_probe(struct platform_device *pdev) +{ + struct nct6694_rtc_data *data; + struct nct6694 *nct6694 =3D dev_get_drvdata(pdev->dev.parent); + int ret; + + data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->msg =3D devm_kzalloc(&pdev->dev, sizeof(union nct6694_rtc_msg), + GFP_KERNEL); + if (!data->msg) + return -ENOMEM; + + data->irq =3D irq_create_mapping(nct6694->domain, NCT6694_IRQ_RTC); + if (!data->irq) + return -EINVAL; + + ret =3D devm_add_action_or_reset(&pdev->dev, nct6694_irq_dispose_mapping, + data); + if (ret) + return ret; + + ret =3D devm_device_init_wakeup(&pdev->dev); + if (ret) + return dev_err_probe(&pdev->dev, ret, "Failed to init wakeup\n"); + + data->rtc =3D devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(data->rtc)) + return PTR_ERR(data->rtc); + + data->nct6694 =3D nct6694; + data->rtc->ops =3D &nct6694_rtc_ops; + data->rtc->range_min =3D RTC_TIMESTAMP_BEGIN_2000; + data->rtc->range_max =3D RTC_TIMESTAMP_END_2099; + + platform_set_drvdata(pdev, data); + + ret =3D devm_request_threaded_irq(&pdev->dev, data->irq, NULL, + nct6694_irq, IRQF_ONESHOT, + "rtc-nct6694", data); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "Failed to request irq\n"); + + return devm_rtc_register_device(data->rtc); +} + +static struct platform_driver nct6694_rtc_driver =3D { + .driver =3D { + .name =3D "nct6694-rtc", + }, + .probe =3D nct6694_rtc_probe, +}; + +module_platform_driver(nct6694_rtc_driver); + +MODULE_DESCRIPTION("USB-RTC driver for NCT6694"); +MODULE_AUTHOR("Ming Yu "); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:nct6694-rtc"); --=20 2.34.1