From nobody Thu Oct 2 20:27:51 2025 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62FEF2DCF55 for ; Fri, 12 Sep 2025 09:20:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757668844; cv=none; b=csFo3tyXnQwvqkMzwe3J0gF+8GDlp3DtHnmF4dbmT9rAt86n5DYSBaRx5GcrP8HwTZI5GuPXKI2o8DNKC2zQi1zkzY+/OsQ03S40e5qA6eQbznX3pYmrqHN+J6V50kDWbBUwEkS8ki5Ecp/cqD1o3kVJqZc6yOmYgqpmY5s30bI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757668844; c=relaxed/simple; bh=BcdbO04+6XlX06T3x3N5ak9Umf/0mTwibjGYRx4+cZI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BGlnQ1Jh3+Z3etcJPKubutTO3MlMRTV/NbKEY7zE23i85mbx77KTdqWacq3IgPDdyqY1PPzeRi4E9OEr8BAsG2hB8vGOZzT2+pPaop/sI4Wfh6T9edqA9ueNr4IIdj2lx47wbVFt971sWggr6u44RxKb9l92WJyEmM7fj9a2uWA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LsBYiomh; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LsBYiomh" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7724cacc32bso1421075b3a.0 for ; Fri, 12 Sep 2025 02:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757668839; x=1758273639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bKwsSmqa4n2KxosM4t23OoTGRweStl/nH9+WGWRW/Hk=; b=LsBYiomhKhPDoSmRmSW760sFZkzH3tOhrwq3jCIJNaCswlQpyVxJWwN9R644nkxLb4 VVTbfI+pvqmZ0RMmfOQoV1GTMUPbQ1gNAXWXQWojoFun5Yw5uHQUwEzm3gKbH6Yqe3VB HAI1PIUaDodk48W4zFqaUjbzaxlGQrdT3FxtYTYWswyyfprnGiQ/1gEH1Dcqqu5lwtAZ 0XbZcd9hRGk4zZtgBYTLl94NnHE6rdRoqSlrJMKnNQ7JSyUkNeSq1xu7vUy3bIUnTkt1 vG1H+VqoJSRplE+thvqkbVtc5gMg71P6awXkYrGvWZ98tIcurbtYwYKsND+4q+RTDKxd ucqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757668839; x=1758273639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bKwsSmqa4n2KxosM4t23OoTGRweStl/nH9+WGWRW/Hk=; b=Mc6+8ioz3+qISdWjdOb7vsuibkWTLt6iY6tTjLO4Q5Pa8keYmXgynzBxIRBxa1RJ0d POfOKbx851ia+7KjzscG64+rchlDYFGHySKyGt7nc5mBlH+2JwKIr1GA4W9xVqHQpWVU x2+qUzM4czirvxwkFik/61BSYMRJ+z1kBKGQ2590697dtP0qwxpSWUF9hJAIOwSwyZ4j 0AQK1iV29HJd0kO8To2yatOud8ABLq77nYsjDHZxuHKxhcPnntqWTYNtTan3UPHuV61U +e31BoWn05PGrdMqktsqIVHEYDQulinDRVTGHUkCdljADB3VgsKHX1+Y1b7MQFYbWFBr 1eow== X-Gm-Message-State: AOJu0Yw2PxhHx4Ycx80+cG3xxI+k6Wly3ckn5pDzjUqlIFwLCaqgIT64 qbeX6e0eGB/iqFi9a6Tpv+A/N22Tz7smC7BMuEhn673PKcjs7L6mg/Qg X-Gm-Gg: ASbGnctGTB73UDnz5iAIGgZpCq2kv15M8vlQIScueL8A4UF17BcP0aoumJK6fH8geSj zaHa1cSgq3OWbg9flR3f3k/HqNzSm9qEE07pCc/73P+nY+fluNnkC9nrA9qVuin6AWR5m7ubcF9 2/NVSYr5Li57zQstQ35tXFG9d7jXXbP/xh5bx9sEv7k3YjSBBfKKhY1TYoxrL5wmiHYTUym4gj2 6L8rjIvkjM0QHzh1F9iB+0UEeGgxkHNXw/uFzQrCLK3ZaPG36frZjDOoZsMS+Ldvfz16/S9ngCb PGMWz8thfrRrMov9Q/V/o4Z06HMGJkMWXpNM867jROfOdN6S6qSpsA5ZSJTVagtOjSJ2sNd1CJq SBQ2lZOssI/iPSrXYB1CFYu5nhjcvfCn93j+qzKUvb64rPi8Td9SOWsO7zYqa5k/t/oGcIjq90B GG X-Google-Smtp-Source: AGHT+IHvpU0r7bXjBYfFJu1uMfNiYVCqkgf6LEBGhK1+qPsZ8JpTxjVs4C8Htj8kAcO2ZksuWth0Xg== X-Received: by 2002:a05:6a20:2451:b0:244:58:c147 with SMTP id adf61e73a8af0-2602aa89dddmr2885571637.21.1757668838591; Fri, 12 Sep 2025 02:20:38 -0700 (PDT) Received: from hcdev-d520mt2.. (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b54a36dc461sm4066564a12.23.2025.09.12.02.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 02:20:38 -0700 (PDT) From: a0282524688@gmail.com To: tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de, mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net, jdelvare@suse.com, alexandre.belloni@bootlin.com Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, Ming Yu Subject: [PATCH RESEND v14 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Date: Fri, 12 Sep 2025 17:19:51 +0800 Message-Id: <20250912091952.1169369-7-a0282524688@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250912091952.1169369-1-a0282524688@gmail.com> References: <20250912091952.1169369-1-a0282524688@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ming Yu This driver supports Hardware monitor functionality for NCT6694 MFD device based on USB interface. Reviewed-by: Guenter Roeck Signed-off-by: Ming Yu --- Changes since version 13: Changes since version 12: - Use same email address in the signature Changes since version 11: - Fix the typo in the header Changes since version 10: Changes since version 9: Changes since version 8: - Modify the signed-off-by with my work address Changes since version 7: - Add error handling for devm_mutex_init() Changes since version 6: - Fix temp_hyst's data type to signed variable Changes since version 5: - Modify the module name and the driver name consistently Changes since version 4: - Modify arguments in read/write function to a pointer to cmd_header - Modify all callers that call the read/write function - Fix warngings Changes since version 3: - Modify array buffer to structure - Fix defines and comments - Modify mutex_init() to devm_mutex_init() - Modify the division method to DIV_ROUND_CLOSEST() Changes since version 2: - Add MODULE_ALIAS() - Fix warnings Changes since version 1: - Add each driver's command structure - Fix platform driver registration - Add voltage sensors functionality - Add temperature sensors functionality - Fix overwrite error return values - Add write value limitation for each write() function MAINTAINERS | 1 + drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/nct6694-hwmon.c | 949 ++++++++++++++++++++++++++++++++++ 4 files changed, 961 insertions(+) create mode 100644 drivers/hwmon/nct6694-hwmon.c diff --git a/MAINTAINERS b/MAINTAINERS index 4639d5933c5e..bbacc9d48a83 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18086,6 +18086,7 @@ NUVOTON NCT6694 MFD DRIVER M: Ming Yu S: Supported F: drivers/gpio/gpio-nct6694.c +F: drivers/hwmon/nct6694-hwmon.c F: drivers/i2c/busses/i2c-nct6694.c F: drivers/mfd/nct6694.c F: drivers/net/can/usb/nct6694_canfd.c diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 9d28fcf7cd2a..19f660d9a0c5 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1698,6 +1698,16 @@ config SENSORS_NCT6683 This driver can also be built as a module. If so, the module will be called nct6683. =20 +config SENSORS_NCT6694 + tristate "Nuvoton NCT6694 Hardware Monitor support" + depends on MFD_NCT6694 + help + Say Y here to support Nuvoton NCT6694 hardware monitoring + functionality. + + This driver can also be built as a module. If so, the module + will be called nct6694-hwmon. + config SENSORS_NCT6775_CORE tristate select REGMAP diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index cd8bc4752b4d..9bce91611dc3 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile @@ -174,6 +174,7 @@ obj-$(CONFIG_SENSORS_MLXREG_FAN) +=3D mlxreg-fan.o obj-$(CONFIG_SENSORS_MENF21BMC_HWMON) +=3D menf21bmc_hwmon.o obj-$(CONFIG_SENSORS_MR75203) +=3D mr75203.o obj-$(CONFIG_SENSORS_NCT6683) +=3D nct6683.o +obj-$(CONFIG_SENSORS_NCT6694) +=3D nct6694-hwmon.o obj-$(CONFIG_SENSORS_NCT6775_CORE) +=3D nct6775-core.o nct6775-objs :=3D nct6775-platform.o obj-$(CONFIG_SENSORS_NCT6775) +=3D nct6775.o diff --git a/drivers/hwmon/nct6694-hwmon.c b/drivers/hwmon/nct6694-hwmon.c new file mode 100644 index 000000000000..6dcf22ca5018 --- /dev/null +++ b/drivers/hwmon/nct6694-hwmon.c @@ -0,0 +1,949 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Nuvoton NCT6694 HWMON driver based on USB interface. + * + * Copyright (C) 2025 Nuvoton Technology Corp. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* + * USB command module type for NCT6694 report channel + * This defines the module type used for communication with the NCT6694 + * report channel over the USB interface. + */ +#define NCT6694_RPT_MOD 0xFF + +/* Report channel */ +/* + * The report channel is used to report the status of the hardware monitor + * devices, such as voltage, temperature, fan speed, and PWM. + */ +#define NCT6694_VIN_IDX(x) (0x00 + (x)) +#define NCT6694_TIN_IDX(x) \ + ({ typeof(x) (_x) =3D (x); \ + ((_x) < 10) ? (0x10 + ((_x) * 2)) : \ + (0x30 + (((_x) - 10) * 2)); }) +#define NCT6694_FIN_IDX(x) (0x50 + ((x) * 2)) +#define NCT6694_PWM_IDX(x) (0x70 + (x)) +#define NCT6694_VIN_STS(x) (0x68 + (x)) +#define NCT6694_TIN_STS(x) (0x6A + (x)) +#define NCT6694_FIN_STS(x) (0x6E + (x)) + +/* + * USB command module type for NCT6694 HWMON controller. + * This defines the module type used for communication with the NCT6694 + * HWMON controller over the USB interface. + */ +#define NCT6694_HWMON_MOD 0x00 + +/* Command 00h - Hardware Monitor Control */ +#define NCT6694_HWMON_CONTROL 0x00 +#define NCT6694_HWMON_CONTROL_SEL 0x00 + +/* Command 02h - Alarm Control */ +#define NCT6694_HWMON_ALARM 0x02 +#define NCT6694_HWMON_ALARM_SEL 0x00 + +/* + * USB command module type for NCT6694 PWM controller. + * This defines the module type used for communication with the NCT6694 + * PWM controller over the USB interface. + */ +#define NCT6694_PWM_MOD 0x01 + +/* PWM Command - Manual Control */ +#define NCT6694_PWM_CONTROL 0x01 +#define NCT6694_PWM_CONTROL_SEL 0x00 + +#define NCT6694_FREQ_FROM_REG(reg) ((reg) * 25000 / 255) +#define NCT6694_FREQ_TO_REG(val) \ + (DIV_ROUND_CLOSEST(clamp_val((val), 100, 25000) * 255, 25000)) + +#define NCT6694_LSB_REG_MASK GENMASK(7, 5) +#define NCT6694_TIN_HYST_MASK GENMASK(7, 5) + +enum nct6694_hwmon_temp_mode { + NCT6694_HWMON_TWOTIME_IRQ =3D 0, + NCT6694_HWMON_ONETIME_IRQ, + NCT6694_HWMON_REALTIME_IRQ, + NCT6694_HWMON_COMPARE_IRQ, +}; + +struct __packed nct6694_hwmon_control { + u8 vin_en[2]; + u8 tin_en[2]; + u8 fin_en[2]; + u8 pwm_en[2]; + u8 reserved1[40]; + u8 pwm_freq[10]; + u8 reserved2[6]; +}; + +struct __packed nct6694_hwmon_alarm { + u8 smi_ctrl; + u8 reserved1[15]; + struct { + u8 hl; + u8 ll; + } vin_limit[16]; + struct { + u8 hyst; + s8 hl; + } tin_cfg[32]; + __be16 fin_ll[10]; + u8 reserved2[4]; +}; + +struct __packed nct6694_pwm_control { + u8 mal_en[2]; + u8 mal_val[10]; + u8 reserved[12]; +}; + +union __packed nct6694_hwmon_rpt { + u8 vin; + struct { + u8 msb; + u8 lsb; + } tin; + __be16 fin; + u8 pwm; + u8 status; +}; + +union __packed nct6694_hwmon_msg { + struct nct6694_hwmon_alarm hwmon_alarm; + struct nct6694_pwm_control pwm_ctrl; +}; + +struct nct6694_hwmon_data { + struct nct6694 *nct6694; + struct mutex lock; + struct nct6694_hwmon_control hwmon_en; + union nct6694_hwmon_rpt *rpt; + union nct6694_hwmon_msg *msg; +}; + +static inline long in_from_reg(u8 reg) +{ + return reg * 16; +} + +static inline u8 in_to_reg(long val) +{ + return DIV_ROUND_CLOSEST(val, 16); +} + +static inline long temp_from_reg(s8 reg) +{ + return reg * 1000; +} + +static inline s8 temp_to_reg(long val) +{ + return DIV_ROUND_CLOSEST(val, 1000); +} + +#define NCT6694_HWMON_IN_CONFIG (HWMON_I_INPUT | HWMON_I_ENABLE | \ + HWMON_I_MAX | HWMON_I_MIN | \ + HWMON_I_ALARM) +#define NCT6694_HWMON_TEMP_CONFIG (HWMON_T_INPUT | HWMON_T_ENABLE | \ + HWMON_T_MAX | HWMON_T_MAX_HYST | \ + HWMON_T_MAX_ALARM) +#define NCT6694_HWMON_FAN_CONFIG (HWMON_F_INPUT | HWMON_F_ENABLE | \ + HWMON_F_MIN | HWMON_F_MIN_ALARM) +#define NCT6694_HWMON_PWM_CONFIG (HWMON_PWM_INPUT | HWMON_PWM_ENABLE | \ + HWMON_PWM_FREQ) +static const struct hwmon_channel_info *nct6694_info[] =3D { + HWMON_CHANNEL_INFO(in, + NCT6694_HWMON_IN_CONFIG, /* VIN0 */ + NCT6694_HWMON_IN_CONFIG, /* VIN1 */ + NCT6694_HWMON_IN_CONFIG, /* VIN2 */ + NCT6694_HWMON_IN_CONFIG, /* VIN3 */ + NCT6694_HWMON_IN_CONFIG, /* VIN5 */ + NCT6694_HWMON_IN_CONFIG, /* VIN6 */ + NCT6694_HWMON_IN_CONFIG, /* VIN7 */ + NCT6694_HWMON_IN_CONFIG, /* VIN14 */ + NCT6694_HWMON_IN_CONFIG, /* VIN15 */ + NCT6694_HWMON_IN_CONFIG, /* VIN16 */ + NCT6694_HWMON_IN_CONFIG, /* VBAT */ + NCT6694_HWMON_IN_CONFIG, /* VSB */ + NCT6694_HWMON_IN_CONFIG, /* AVSB */ + NCT6694_HWMON_IN_CONFIG, /* VCC */ + NCT6694_HWMON_IN_CONFIG, /* VHIF */ + NCT6694_HWMON_IN_CONFIG), /* VTT */ + + HWMON_CHANNEL_INFO(temp, + NCT6694_HWMON_TEMP_CONFIG, /* THR1 */ + NCT6694_HWMON_TEMP_CONFIG, /* THR2 */ + NCT6694_HWMON_TEMP_CONFIG, /* THR14 */ + NCT6694_HWMON_TEMP_CONFIG, /* THR15 */ + NCT6694_HWMON_TEMP_CONFIG, /* THR16 */ + NCT6694_HWMON_TEMP_CONFIG, /* TDP0 */ + NCT6694_HWMON_TEMP_CONFIG, /* TDP1 */ + NCT6694_HWMON_TEMP_CONFIG, /* TDP2 */ + NCT6694_HWMON_TEMP_CONFIG, /* TDP3 */ + NCT6694_HWMON_TEMP_CONFIG, /* TDP4 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN0 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN1 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN2 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN3 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN4 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN5 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN6 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN7 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN8 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN9 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN10 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN11 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN12 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN13 */ + NCT6694_HWMON_TEMP_CONFIG, /* DTIN14 */ + NCT6694_HWMON_TEMP_CONFIG), /* DTIN15 */ + + HWMON_CHANNEL_INFO(fan, + NCT6694_HWMON_FAN_CONFIG, /* FIN0 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN1 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN2 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN3 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN4 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN5 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN6 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN7 */ + NCT6694_HWMON_FAN_CONFIG, /* FIN8 */ + NCT6694_HWMON_FAN_CONFIG), /* FIN9 */ + + HWMON_CHANNEL_INFO(pwm, + NCT6694_HWMON_PWM_CONFIG, /* PWM0 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM1 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM2 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM3 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM4 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM5 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM6 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM7 */ + NCT6694_HWMON_PWM_CONFIG, /* PWM8 */ + NCT6694_HWMON_PWM_CONFIG), /* PWM9 */ + NULL +}; + +static int nct6694_in_read(struct device *dev, u32 attr, int channel, + long *val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + unsigned char vin_en; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_in_enable: + vin_en =3D data->hwmon_en.vin_en[(channel / 8)]; + *val =3D !!(vin_en & BIT(channel % 8)); + + return 0; + case hwmon_in_input: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_VIN_IDX(channel)), + .len =3D cpu_to_le16(sizeof(data->rpt->vin)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->vin); + if (ret) + return ret; + + *val =3D in_from_reg(data->rpt->vin); + + return 0; + case hwmon_in_max: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + *val =3D in_from_reg(data->msg->hwmon_alarm.vin_limit[channel].hl); + + return 0; + case hwmon_in_min: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + *val =3D in_from_reg(data->msg->hwmon_alarm.vin_limit[channel].ll); + + return 0; + case hwmon_in_alarm: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_VIN_STS(channel / 8)), + .len =3D cpu_to_le16(sizeof(data->rpt->status)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->status); + if (ret) + return ret; + + *val =3D !!(data->rpt->status & BIT(channel % 8)); + + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_temp_read(struct device *dev, u32 attr, int channel, + long *val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + unsigned char temp_en, temp_hyst; + signed char temp_max; + int ret, temp_raw; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_temp_enable: + temp_en =3D data->hwmon_en.tin_en[channel / 8]; + *val =3D !!(temp_en & BIT(channel % 8)); + + return 0; + case hwmon_temp_input: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_TIN_IDX(channel)), + .len =3D cpu_to_le16(sizeof(data->rpt->tin)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->tin); + if (ret) + return ret; + + temp_raw =3D data->rpt->tin.msb << 3; + temp_raw |=3D FIELD_GET(NCT6694_LSB_REG_MASK, data->rpt->tin.lsb); + + /* Real temperature(milli degrees Celsius) =3D temp_raw * 1000 * 0.125 */ + *val =3D sign_extend32(temp_raw, 10) * 125; + + return 0; + case hwmon_temp_max: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + *val =3D temp_from_reg(data->msg->hwmon_alarm.tin_cfg[channel].hl); + + return 0; + case hwmon_temp_max_hyst: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + temp_max =3D data->msg->hwmon_alarm.tin_cfg[channel].hl; + temp_hyst =3D FIELD_GET(NCT6694_TIN_HYST_MASK, + data->msg->hwmon_alarm.tin_cfg[channel].hyst); + *val =3D temp_from_reg(temp_max - temp_hyst); + + return 0; + case hwmon_temp_max_alarm: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_TIN_STS(channel / 8)), + .len =3D cpu_to_le16(sizeof(data->rpt->status)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->status); + if (ret) + return ret; + + *val =3D !!(data->rpt->status & BIT(channel % 8)); + + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_fan_read(struct device *dev, u32 attr, int channel, + long *val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + unsigned char fanin_en; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_fan_enable: + fanin_en =3D data->hwmon_en.fin_en[channel / 8]; + *val =3D !!(fanin_en & BIT(channel % 8)); + + return 0; + case hwmon_fan_input: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_FIN_IDX(channel)), + .len =3D cpu_to_le16(sizeof(data->rpt->fin)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->fin); + if (ret) + return ret; + + *val =3D be16_to_cpu(data->rpt->fin); + + return 0; + case hwmon_fan_min: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + *val =3D be16_to_cpu(data->msg->hwmon_alarm.fin_ll[channel]); + + return 0; + case hwmon_fan_min_alarm: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_FIN_STS(channel / 8)), + .len =3D cpu_to_le16(sizeof(data->rpt->status)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->status); + if (ret) + return ret; + + *val =3D !!(data->rpt->status & BIT(channel % 8)); + + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_pwm_read(struct device *dev, u32 attr, int channel, + long *val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + unsigned char pwm_en; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_pwm_enable: + pwm_en =3D data->hwmon_en.pwm_en[channel / 8]; + *val =3D !!(pwm_en & BIT(channel % 8)); + + return 0; + case hwmon_pwm_input: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_RPT_MOD, + .offset =3D cpu_to_le16(NCT6694_PWM_IDX(channel)), + .len =3D cpu_to_le16(sizeof(data->rpt->pwm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->rpt->pwm); + if (ret) + return ret; + + *val =3D data->rpt->pwm; + + return 0; + case hwmon_pwm_freq: + *val =3D NCT6694_FREQ_FROM_REG(data->hwmon_en.pwm_freq[channel]); + + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_in_write(struct device *dev, u32 attr, int channel, + long val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_in_enable: + if (val =3D=3D 0) + data->hwmon_en.vin_en[channel / 8] &=3D ~BIT(channel % 8); + else if (val =3D=3D 1) + data->hwmon_en.vin_en[channel / 8] |=3D BIT(channel % 8); + else + return -EINVAL; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + case hwmon_in_max: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + val =3D clamp_val(val, 0, 2032); + data->msg->hwmon_alarm.vin_limit[channel].hl =3D in_to_reg(val); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + case hwmon_in_min: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + val =3D clamp_val(val, 0, 2032); + data->msg->hwmon_alarm.vin_limit[channel].ll =3D in_to_reg(val); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_temp_write(struct device *dev, u32 attr, int channel, + long val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + unsigned char temp_hyst; + signed char temp_max; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_temp_enable: + if (val =3D=3D 0) + data->hwmon_en.tin_en[channel / 8] &=3D ~BIT(channel % 8); + else if (val =3D=3D 1) + data->hwmon_en.tin_en[channel / 8] |=3D BIT(channel % 8); + else + return -EINVAL; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + case hwmon_temp_max: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + val =3D clamp_val(val, -127000, 127000); + data->msg->hwmon_alarm.tin_cfg[channel].hl =3D temp_to_reg(val); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + case hwmon_temp_max_hyst: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + + val =3D clamp_val(val, -127000, 127000); + temp_max =3D data->msg->hwmon_alarm.tin_cfg[channel].hl; + temp_hyst =3D temp_max - temp_to_reg(val); + temp_hyst =3D clamp_val(temp_hyst, 0, 7); + data->msg->hwmon_alarm.tin_cfg[channel].hyst =3D + (data->msg->hwmon_alarm.tin_cfg[channel].hyst & ~NCT6694_TIN_HYST_MASK)= | + FIELD_PREP(NCT6694_TIN_HYST_MASK, temp_hyst); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_fan_write(struct device *dev, u32 attr, int channel, + long val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_fan_enable: + if (val =3D=3D 0) + data->hwmon_en.fin_en[channel / 8] &=3D ~BIT(channel % 8); + else if (val =3D=3D 1) + data->hwmon_en.fin_en[channel / 8] |=3D BIT(channel % 8); + else + return -EINVAL; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + case hwmon_fan_min: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + val =3D clamp_val(val, 1, 65535); + data->msg->hwmon_alarm.fin_ll[channel] =3D cpu_to_be16(val); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_pwm_write(struct device *dev, u32 attr, int channel, + long val) +{ + struct nct6694_hwmon_data *data =3D dev_get_drvdata(dev); + struct nct6694_cmd_header cmd_hd; + int ret; + + guard(mutex)(&data->lock); + + switch (attr) { + case hwmon_pwm_enable: + if (val =3D=3D 0) + data->hwmon_en.pwm_en[channel / 8] &=3D ~BIT(channel % 8); + else if (val =3D=3D 1) + data->hwmon_en.pwm_en[channel / 8] |=3D BIT(channel % 8); + else + return -EINVAL; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + case hwmon_pwm_input: + if (val < 0 || val > 255) + return -EINVAL; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_PWM_MOD, + .cmd =3D NCT6694_PWM_CONTROL, + .sel =3D NCT6694_PWM_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->pwm_ctrl)) + }; + + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->pwm_ctrl); + if (ret) + return ret; + + data->msg->pwm_ctrl.mal_val[channel] =3D val; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->pwm_ctrl); + case hwmon_pwm_freq: + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + + data->hwmon_en.pwm_freq[channel] =3D NCT6694_FREQ_TO_REG(val); + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) +{ + switch (type) { + case hwmon_in: + /* in mV */ + return nct6694_in_read(dev, attr, channel, val); + case hwmon_temp: + /* in mC */ + return nct6694_temp_read(dev, attr, channel, val); + case hwmon_fan: + /* in RPM */ + return nct6694_fan_read(dev, attr, channel, val); + case hwmon_pwm: + /* in value 0~255 */ + return nct6694_pwm_read(dev, attr, channel, val); + default: + return -EOPNOTSUPP; + } +} + +static int nct6694_write(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long val) +{ + switch (type) { + case hwmon_in: + return nct6694_in_write(dev, attr, channel, val); + case hwmon_temp: + return nct6694_temp_write(dev, attr, channel, val); + case hwmon_fan: + return nct6694_fan_write(dev, attr, channel, val); + case hwmon_pwm: + return nct6694_pwm_write(dev, attr, channel, val); + default: + return -EOPNOTSUPP; + } +} + +static umode_t nct6694_is_visible(const void *data, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + switch (type) { + case hwmon_in: + switch (attr) { + case hwmon_in_enable: + case hwmon_in_max: + case hwmon_in_min: + return 0644; + case hwmon_in_alarm: + case hwmon_in_input: + return 0444; + default: + return 0; + } + case hwmon_temp: + switch (attr) { + case hwmon_temp_enable: + case hwmon_temp_max: + case hwmon_temp_max_hyst: + return 0644; + case hwmon_temp_input: + case hwmon_temp_max_alarm: + return 0444; + default: + return 0; + } + case hwmon_fan: + switch (attr) { + case hwmon_fan_enable: + case hwmon_fan_min: + return 0644; + case hwmon_fan_input: + case hwmon_fan_min_alarm: + return 0444; + default: + return 0; + } + case hwmon_pwm: + switch (attr) { + case hwmon_pwm_enable: + case hwmon_pwm_freq: + case hwmon_pwm_input: + return 0644; + default: + return 0; + } + default: + return 0; + } +} + +static const struct hwmon_ops nct6694_hwmon_ops =3D { + .is_visible =3D nct6694_is_visible, + .read =3D nct6694_read, + .write =3D nct6694_write, +}; + +static const struct hwmon_chip_info nct6694_chip_info =3D { + .ops =3D &nct6694_hwmon_ops, + .info =3D nct6694_info, +}; + +static int nct6694_hwmon_init(struct nct6694_hwmon_data *data) +{ + struct nct6694_cmd_header cmd_hd =3D { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_CONTROL, + .sel =3D NCT6694_HWMON_CONTROL_SEL, + .len =3D cpu_to_le16(sizeof(data->hwmon_en)) + }; + int ret; + + /* + * Record each Hardware Monitor Channel enable status + * and PWM frequency register + */ + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->hwmon_en); + if (ret) + return ret; + + cmd_hd =3D (struct nct6694_cmd_header) { + .mod =3D NCT6694_HWMON_MOD, + .cmd =3D NCT6694_HWMON_ALARM, + .sel =3D NCT6694_HWMON_ALARM_SEL, + .len =3D cpu_to_le16(sizeof(data->msg->hwmon_alarm)) + }; + + /* Select hwmon device alarm mode */ + ret =3D nct6694_read_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); + if (ret) + return ret; + + data->msg->hwmon_alarm.smi_ctrl =3D NCT6694_HWMON_REALTIME_IRQ; + + return nct6694_write_msg(data->nct6694, &cmd_hd, + &data->msg->hwmon_alarm); +} + +static int nct6694_hwmon_probe(struct platform_device *pdev) +{ + struct nct6694_hwmon_data *data; + struct nct6694 *nct6694 =3D dev_get_drvdata(pdev->dev.parent); + struct device *hwmon_dev; + int ret; + + data =3D devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->rpt =3D devm_kzalloc(&pdev->dev, sizeof(union nct6694_hwmon_rpt), + GFP_KERNEL); + if (!data->rpt) + return -ENOMEM; + + data->msg =3D devm_kzalloc(&pdev->dev, sizeof(union nct6694_hwmon_msg), + GFP_KERNEL); + if (!data->msg) + return -ENOMEM; + + data->nct6694 =3D nct6694; + ret =3D devm_mutex_init(&pdev->dev, &data->lock); + if (ret) + return ret; + + ret =3D nct6694_hwmon_init(data); + if (ret) + return ret; + + /* Register hwmon device to HWMON framework */ + hwmon_dev =3D devm_hwmon_device_register_with_info(&pdev->dev, + "nct6694", data, + &nct6694_chip_info, + NULL); + return PTR_ERR_OR_ZERO(hwmon_dev); +} + +static struct platform_driver nct6694_hwmon_driver =3D { + .driver =3D { + .name =3D "nct6694-hwmon", + }, + .probe =3D nct6694_hwmon_probe, +}; + +module_platform_driver(nct6694_hwmon_driver); + +MODULE_DESCRIPTION("USB-HWMON driver for NCT6694"); +MODULE_AUTHOR("Ming Yu "); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:nct6694-hwmon"); --=20 2.34.1