From nobody Thu Oct 2 20:28:26 2025 Received: from mail-m32112.qiye.163.com (mail-m32112.qiye.163.com [220.197.32.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6C61A3142; Fri, 12 Sep 2025 08:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.112 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757667564; cv=none; b=hrOUYVWDpjJSYOfq0r9T9d29YT6fYi9tMq8AUNpATp4hRcz4mrgzDE/cAqgldYep+QMpvRdJX8gW3pzeNRPlcJ0SUnKUHqECIR3dNSdg1WU6J1kXBeVqYre7I4C3bHAQc++tythMb9w9Ho8SCDN8Vbmm83czasVSHENSvfTw6Os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757667564; c=relaxed/simple; bh=d4yuFSQhIruk30bHEXzh0Z2vQkt26EoqjvErB0NB1dk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LFnAzgpB0OWk+YK/m99oroHjsblI6VtTkvyQXCzgbSGxwVWL7aBnsRET3wKwt4Hqmr5+kjtmBng1nip/HymlVxeZ3L6lQHVDCWWYcYsgKID/T1IMZwt0ywqL1cOwDC5vedGxMwCbjs17gZuLEfr6k5WhA7yIiUI6cs6FekIkEN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=bUnBMVRx; arc=none smtp.client-ip=220.197.32.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="bUnBMVRx" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 229880a0f; Fri, 12 Sep 2025 16:59:17 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, luca.ceresoli@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v5 08/17] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Date: Fri, 12 Sep 2025 16:58:37 +0800 Message-Id: <20250912085846.7349-9-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250912085846.7349-1-damon.ding@rock-chips.com> References: <20250912085846.7349-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a993d26804303a3kunm813a8c8ea45da5 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQhlDHVZISUIaQ01CHU0fSElWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=bUnBMVRxs+JphzbyObzmGF25ulJgVz4kS+1p/AFmcRodc1mLTEYNPC4bsOGi/mqJx7bMCtuyMN+S8HCYwyT4DTPnHtB6DY40f7qRicyyQiLidySEJRy2Wqtl2mO8uoxeS79DLiXUAInzve4sbjYa+QP60f/Xdbi0HW73sTIbRfQ=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=xElXCyG6FEy4sSDQfYeJ/7uWrIvoMgcrx1iJZeNZ1Vc=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" For Rockchip platforms, the YUV color formats are currently unsupported. This compatibility check was previously implemented in &analogix_dp_plat_data.get_modes(). Moving color format check to &drm_connector_helper_funcs.atomic_check() would get rid of &analogix_dp_plat_data.get_modes() and be more reasonable than before. Signed-off-by: Damon Ding --- .../gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++++ .../gpu/drm/rockchip/analogix_dp-rockchip.c | 18 ------------------ 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 02d6a5a1a836..5d15fdf88c92 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -894,8 +894,19 @@ static int analogix_dp_atomic_check(struct drm_connect= or *connector, struct drm_atomic_state *state) { struct analogix_dp_device *dp =3D to_dp(connector); + struct drm_display_info *di =3D &connector->display_info; struct drm_connector_state *conn_state; struct drm_crtc_state *crtc_state; + u32 mask =3D DRM_COLOR_FORMAT_YCBCR444 | DRM_COLOR_FORMAT_YCBCR422; + + if (is_rockchip(dp->plat_data->dev_type)) { + if ((di->color_formats & mask)) { + DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); + di->color_formats &=3D ~mask; + di->color_formats |=3D DRM_COLOR_FORMAT_RGB444; + di->bpc =3D 8; + } + } =20 conn_state =3D drm_atomic_get_new_connector_state(state, connector); if (WARN_ON(!conn_state)) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/= drm/rockchip/analogix_dp-rockchip.c index 94da0f745525..0a185ebd26af 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -165,23 +165,6 @@ static int rockchip_dp_powerdown(struct analogix_dp_pl= at_data *plat_data) return 0; } =20 -static int rockchip_dp_get_modes(struct analogix_dp_plat_data *plat_data, - struct drm_connector *connector) -{ - struct drm_display_info *di =3D &connector->display_info; - /* VOP couldn't output YUV video format for eDP rightly */ - u32 mask =3D DRM_COLOR_FORMAT_YCBCR444 | DRM_COLOR_FORMAT_YCBCR422; - - if ((di->color_formats & mask)) { - DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); - di->color_formats &=3D ~mask; - di->color_formats |=3D DRM_COLOR_FORMAT_RGB444; - di->bpc =3D 8; - } - - return 0; -} - static bool rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, @@ -480,7 +463,6 @@ static int rockchip_dp_probe(struct platform_device *pd= ev) dp->plat_data.dev_type =3D dp->data->chip_type; dp->plat_data.power_on =3D rockchip_dp_poweron; dp->plat_data.power_off =3D rockchip_dp_powerdown; - dp->plat_data.get_modes =3D rockchip_dp_get_modes; =20 ret =3D rockchip_dp_of_probe(dp); if (ret < 0) --=20 2.34.1