From nobody Thu Oct 2 18:15:50 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EAF531B126 for ; Fri, 12 Sep 2025 16:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695365; cv=none; b=E522SbWqbtSXiLUFYhLN4kZ6heuVc068hjKgYs+6coREJoAF3BtEl2I7etOzn7MszzePMZo4E3lDuK0Xg05JpwXw+vRxS1Ku2VIhGOwtrw7ERr/0mIyWdL8y/FurtdyCkb2GEqdY+xdYxqhQZkGuEyCOEEtjtibmZ9EgK5cYsDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695365; c=relaxed/simple; bh=tzsN7qKm6dUmRDagLQir/qm3kiDTLaHsDU+/1R/XgkY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=faHVkcyij/s9ZPXp68KZRY8r7lwJkEUCFnlcVqStEAdQ87sR3MrBkhknW6ww/qbniI5W+SjkMu7I+S+c4gZ7AVcxCOPZ1P/xgMBaxDbZIPnhQqMEANMDlRCYHqJsvikI1DzM5MV6tYFSTMdgl40Ug29Do/G8IEeWss9gZZEI5e4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dlnTmPrC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dlnTmPrC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45dec1ae562so19948835e9.1 for ; Fri, 12 Sep 2025 09:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757695362; x=1758300162; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SoeciE1g87M9Qxg6df56vLYD1QTe3IoOL1+JcFYtWuk=; b=dlnTmPrCmZgpYzUwfna9MgeYFNSaYhRelcrXb8jLe4JeUUoYbjG+u4xEVX5MQ7GArW dorxuWQPBI/ZoLHr9Vj5snOfrmZTGTgq2cZycR5LoG6HsChAGhguCuAYtEwic7qYIXaF lX6h4Q088zAHYTxDZ3gSbWh3xZihtQ+3NfKX288hacx8TWqaAifEbtHAA+ChU9XdqHbP U4HZ04EQPsCTvZICuAj31YdstbEBIz2iGgRRzJi+pQNf6+3y5XJ1FwDrWGrO+XsrYnfT unyKxJKLKBemhAT8a+iKbyWwwqfGDjzEYRF4u3kW0/Q2mFuVUK5hndyA9PX1iqDfh77W UX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757695362; x=1758300162; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SoeciE1g87M9Qxg6df56vLYD1QTe3IoOL1+JcFYtWuk=; b=uwa37K3Bo7Gr08IMocI9+PyI7g5/iRq6ON0mt3+/jPaZH/z5WoDuUyDgN973oInOgW hONmYWD/eEHWR28I2YbWYngT5bzjM+ebiAS9TM1ukL1jsTQdijCOasz94rxsqbqhIdTc IA+4mLZdgQCZMrJT8kwhoW3vfw0q5lFTxa7cNNJcpnDvogoOZArsu+e5dMGCdpvlGrtH zJFZs0BXUXJ1BCZXTSwMNfX4sr/p6wZ6GgVlnK2COYpx+CHDyjWKkUyijjQuWJ/FOPmi 4fx+Q2qKWX4BGjpD6/3zpU42i003Mmdxl6WjrxeroNDoNanxlaStakqOXJS7vGqTlj0E eYwg== X-Forwarded-Encrypted: i=1; AJvYcCVoJefSlDtMHgII68MSD66T8zF3JDfrWR+lTuLz/i8T2a/tpxeOH9RY0MZ2WmPG7Men793APNQAgvmBmow=@vger.kernel.org X-Gm-Message-State: AOJu0YzzYtxMDY21PJsG8rWwkBVpgnsntSKkq521fXPAvT4jro5yfTO1 uPmIrMqdZBEGiZBVnla/bWZrFx3+5PBm1RkbEuS763rDKd6mYhaQRqD0 X-Gm-Gg: ASbGncvv76gO1S+AIA3Qi+u7YW9Yqxchbs8LFsGsZKPvep6FQM3gNeW8A4ZbgJcQjal Q+81HfQXDJHJXXi+5HTHOPFkllxPYz91Jd9jWTwoLRCnsIRjVZRYo9dO1D5UncSWNICYwphIKuO B6FXuDoM6zXBDBJXwu2s3lzq/OB8zcThMbu2XOKSXIXoyaWNV0JZgLwb7BBf4QZ7cu7UPiqYUQS VzKOrio7OR8OUPBErZNJFrvVztfToBU1fNnCmxFxNmJ30vsp9qDLRJi2ZYOaAlkojymnYupxFQp DbF2DUuXojOpUs6kJ3iHmvqQuy9QNNoh2SamSQ33Owk0XhHERsn3p4zI65IwRa3XfbcUqFJui6X sg9fO1H+A3Vef3uD/Ucq4U4j14RebW6YIwJHoIrzPjafuLvzejby5msorkM8AgIBx2m4zgP+rT2 Y= X-Google-Smtp-Source: AGHT+IHuJSFr0dqtOsT5NPWoHGSkNkCmgSeBnBH2v+uNiFiipuyD5CsBrYBuPM84MejkBy847xlygg== X-Received: by 2002:a05:600c:55c6:b0:45d:e0d8:a0aa with SMTP id 5b1f17b1804b1-45f211fa411mr30126825e9.17.1757695362172; Fri, 12 Sep 2025 09:42:42 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd415sm7086696f8f.30.2025.09.12.09.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 09:42:41 -0700 (PDT) From: Iker Pedrosa Date: Fri, 12 Sep 2025 18:42:09 +0200 Subject: [PATCH 1/5] drm/solomon: Move calls to drm_gem_fb_end_cpu*() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-improve-ssd130x-v1-1-bc9389ed299e@gmail.com> References: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> In-Reply-To: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iker Pedrosa X-Mailer: b4 0.14.2 Calls to drm_gem_fb_end_cpu*() should be between the calls to drm_dev*(), and not hidden inside some other function. This way the critical section code is visible at a glance, keeping it short and improving maintainability. Signed-off-by: Iker Pedrosa Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index dd2006d51c7a2fc8501904565da806aa47333ad6..297593c7fd20a5a5da81f1e1fcf= da9092b19cf90 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1016,15 +1016,9 @@ static int ssd130x_fb_blit_rect(struct drm_framebuff= er *fb, =20 dst_pitch =3D DIV_ROUND_UP(drm_rect_width(rect), 8); =20 - ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); - if (ret) - return ret; - iosys_map_set_vaddr(&dst, buf); drm_fb_xrgb8888_to_mono(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); =20 - drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); - ssd130x_update_rect(ssd130x, rect, buf, data_array); =20 return ret; @@ -1048,15 +1042,9 @@ static int ssd132x_fb_blit_rect(struct drm_framebuff= er *fb, =20 dst_pitch =3D drm_rect_width(rect); =20 - ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); - if (ret) - return ret; - iosys_map_set_vaddr(&dst, buf); drm_fb_xrgb8888_to_gray8(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); =20 - drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); - ssd132x_update_rect(ssd130x, rect, buf, data_array); =20 return ret; @@ -1078,15 +1066,9 @@ static int ssd133x_fb_blit_rect(struct drm_framebuff= er *fb, =20 dst_pitch =3D drm_format_info_min_pitch(fi, 0, drm_rect_width(rect)); =20 - ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); - if (ret) - return ret; - iosys_map_set_vaddr(&dst, data_array); drm_fb_xrgb8888_to_rgb332(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); =20 - drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); - ssd133x_update_rect(ssd130x, rect, data_array, dst_pitch); =20 return ret; @@ -1232,6 +1214,9 @@ static void ssd130x_primary_plane_atomic_update(struc= t drm_plane *plane, if (!drm_dev_enter(drm, &idx)) return; =20 + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + return; + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); drm_atomic_for_each_plane_damage(&iter, &damage) { dst_clip =3D plane_state->dst; @@ -1245,6 +1230,8 @@ static void ssd130x_primary_plane_atomic_update(struc= t drm_plane *plane, &shadow_plane_state->fmtcnv_state); } =20 + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + drm_dev_exit(idx); } =20 @@ -1267,6 +1254,9 @@ static void ssd132x_primary_plane_atomic_update(struc= t drm_plane *plane, if (!drm_dev_enter(drm, &idx)) return; =20 + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + return; + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); drm_atomic_for_each_plane_damage(&iter, &damage) { dst_clip =3D plane_state->dst; @@ -1280,6 +1270,8 @@ static void ssd132x_primary_plane_atomic_update(struc= t drm_plane *plane, &shadow_plane_state->fmtcnv_state); } =20 + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + drm_dev_exit(idx); } =20 @@ -1301,6 +1293,9 @@ static void ssd133x_primary_plane_atomic_update(struc= t drm_plane *plane, if (!drm_dev_enter(drm, &idx)) return; =20 + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + return; + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); drm_atomic_for_each_plane_damage(&iter, &damage) { dst_clip =3D plane_state->dst; @@ -1313,6 +1308,8 @@ static void ssd133x_primary_plane_atomic_update(struc= t drm_plane *plane, &shadow_plane_state->fmtcnv_state); } =20 + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + drm_dev_exit(idx); } =20 --=20 2.51.0 From nobody Thu Oct 2 18:15:50 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1359131C56B for ; Fri, 12 Sep 2025 16:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695366; cv=none; b=nLrrVWJ5aVyUnPxrqwOJIyGV0z8qD+2dOryyixvjYANPgkHiGyJ5GB5YU+1tK5JjXc5xptsLjqxW7fPWkiypV5f9aynZeSOpi7KhGcj3nMOAqE+3C9XPPb/XhZEEek4DPOXv9F2TNOBljUQKyTWyMT//ZCFX+Y/GO6KT7lryCFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695366; c=relaxed/simple; bh=x1o4rMIoDFPnj228i4/i+X3VOW0Hk0iMVCOnI2xopbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q0E1fTFiK3vKoHsandzql5+jR9L5wsbma8EAiviRC5LaP/q5yMHmGB68Kr/8BY29DYHIE20bfIaR+S8EupEcI1WprISX8Vn5LcQzUUZTyzHfQePjjmtgL7INQAtB+UpMHVf8upw+5/2+oBb9bozqV5vew6oYAPSPcXy7VnG7IMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iijwAOaf; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iijwAOaf" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3e75fb6b2e2so2260207f8f.3 for ; Fri, 12 Sep 2025 09:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757695363; x=1758300163; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=O2gnDI76Cg2pQY4d+7l+CRi3OFLEEk/WHj+p8hJRcSw=; b=iijwAOaflrxRf+Sc6zvrp2bTS6Dn8+7q2b+pXlFSXEHvLWu0rxhklzVaZ16QT7fmFN +WYdjgfkB38lpq+ii06Z9oOyuHHtZuZ+snlamgIWt7puNI3ZLGqN0YpwNeSRofyVTloD ep38UHS3kWAqMOG6K8dcygeF8xEk82a+BabNyfLlY9IzHhkKpPhNSB4PxhUYkWqy5nd8 iynSVImTihg3onG4XBssBtGo6UsS1w9bWtF+Ing7A1z9NSyd5OxgghcentkIib3KOZwO j3I7fT2go4zICXGOy4z4q+uL1tRHfdhGR9dAP6mMggm3V76Njo0CimlJ/K7iibOXmm4J DFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757695363; x=1758300163; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O2gnDI76Cg2pQY4d+7l+CRi3OFLEEk/WHj+p8hJRcSw=; b=GdbVRUblDFg10HwjC9YFOyfiS6/ZQTCuQCXgN9tRgoyRnrhks108Syj2E+Z8RmcfGu TQrKH1Fi7Ype1w7Y90kO+TNOmQdCnDTUPT6yIKtDh9Abx56Hp+BsuBicl6diGCo9xmOR 2Hben6TZV3zHiC9bLd6EGU08TSxyS4t6G3LXl8BJ6kSt9ExD0o6FT0ZPgS/dAh2EDd8O IVCyZH2h6BCqQpI7BWXsglmpp3pYs3DHSB3h980oFf0WAcAlr9mQMxYjCod082CPGHpp ox5Rkdp3qSzDaGJNAzVHQ2s/dyd9eXFdmnwGJhr12vkM8GXjYllr2thvlJvIamsf97/V Zj3g== X-Forwarded-Encrypted: i=1; AJvYcCXvtoTbgIwgQiNxlTcP9jhN7vct96AQGUgtD3ubo88ioZ40mRYeX5sUgGPXUotIPrNP7QL+70thHne3rmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzwnzreAP/tBE+9OSofpSE/bC+0714RMc4iH1Ngh+OkVo5Y4iNU T5IBccIDkQbnocd2YhBeQ7zQCo3ATHLUxva70sDos54gZb5kTzCTHrju X-Gm-Gg: ASbGncvWMDWCTYptfSzPc7fVcf3ixTTyqkOB9eBV79EKL6qRaQfJHm8Pt6BU5tSjiym 22yFyB2g3TwL96KVRwIX605NH3AakXugDRBtWiwGch4aPuGn6v3xnRvbV0stnl/BRTiDQ0gtu0P RT21Df5H/vgRsQUKCabx/6BSYijIsBBhVGQeLGL6cnCtaMQmUgHNBbXIAFF/dgrqV+Hv8W25oOu PD2iKHa4lel8aGV/n76eaMLB3N+QHqRMKBQZW9A4KP/qIATm4Uf5zl7KUTXxVjx0lGw/hZ8eY7C RH1Faifsd3X+8La5/Xa9Or2KQ3QNZECXZ9XHZrhFF2wKRgS1MWleS/NBrzLh/rw4kabw/eCntQg hr/07ZX2xH4jRIRxhSu4kDjWVdWRdPhehT2LAdvqkn5j+4FqMJd41pTUftuOM5H0eUU88itNQii Y= X-Google-Smtp-Source: AGHT+IE959gtwBhse6FsnHVMnHsBtmS240AL0UVQnNung5XxUIW4zcMVG/r4gPAUBC/WAXs7IQvx0g== X-Received: by 2002:a05:6000:2584:b0:3e2:c41c:b2e2 with SMTP id ffacd0b85a97d-3e7659f3806mr4012838f8f.39.1757695363112; Fri, 12 Sep 2025 09:42:43 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd415sm7086696f8f.30.2025.09.12.09.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 09:42:42 -0700 (PDT) From: Iker Pedrosa Date: Fri, 12 Sep 2025 18:42:10 +0200 Subject: [PATCH 2/5] drm/solomon: Use drm_WARN_ON_ONCE instead of WARN_ON Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-improve-ssd130x-v1-2-bc9389ed299e@gmail.com> References: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> In-Reply-To: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iker Pedrosa X-Mailer: b4 0.14.2 To prevent log spam, convert all instances to the DRM-specific drm_WARN_ON_ONCE() macro. This ensures that a warning is emitted only the first time the condition is met for a given device instance, which is the desired behavior within the graphics subsystem. Signed-off-by: Iker Pedrosa Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 297593c7fd20a5a5da81f1e1fcfda9092b19cf90..c6939377ec4b5a42ce0f40d070c= e60d544d8516d 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1390,7 +1390,7 @@ static void ssd130x_primary_plane_reset(struct drm_pl= ane *plane) { struct ssd130x_plane_state *ssd130x_state; =20 - WARN_ON(plane->state); + drm_WARN_ON_ONCE(plane->dev, plane->state); =20 ssd130x_state =3D kzalloc(sizeof(*ssd130x_state), GFP_KERNEL); if (!ssd130x_state) @@ -1405,7 +1405,7 @@ static struct drm_plane_state *ssd130x_primary_plane_= duplicate_state(struct drm_ struct ssd130x_plane_state *old_ssd130x_state; struct ssd130x_plane_state *ssd130x_state; =20 - if (WARN_ON(!plane->state)) + if (drm_WARN_ON_ONCE(plane->dev, !plane->state)) return NULL; =20 old_ssd130x_state =3D to_ssd130x_plane_state(plane->state); @@ -1555,7 +1555,7 @@ static void ssd130x_crtc_reset(struct drm_crtc *crtc) { struct ssd130x_crtc_state *ssd130x_state; =20 - WARN_ON(crtc->state); + drm_WARN_ON_ONCE(crtc->dev, crtc->state); =20 ssd130x_state =3D kzalloc(sizeof(*ssd130x_state), GFP_KERNEL); if (!ssd130x_state) @@ -1569,7 +1569,7 @@ static struct drm_crtc_state *ssd130x_crtc_duplicate_= state(struct drm_crtc *crtc struct ssd130x_crtc_state *old_ssd130x_state; struct ssd130x_crtc_state *ssd130x_state; =20 - if (WARN_ON(!crtc->state)) + if (drm_WARN_ON_ONCE(crtc->dev, !crtc->state)) return NULL; =20 old_ssd130x_state =3D to_ssd130x_crtc_state(crtc->state); --=20 2.51.0 From nobody Thu Oct 2 18:15:50 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6D231D39B for ; Fri, 12 Sep 2025 16:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695368; cv=none; b=LjaOJ6SgJyh6EHFCmpq4bXtCDhpL1IJmqJBCFem93SR4MY4bmKyoyWHoPbFxOAvAcwMNFhtgJEkqVfFfYgeODcSpRO+n8OOQ5yLAd0TFbY5EQZeRbx9OqT2NoCUZXFmheK4OlvetLmRXH3R0nu5GLTAUDyJ2rgLDVNfyKNFFi6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695368; c=relaxed/simple; bh=fpI2rGosAyCwTrEIHYOyRLpy9n+YPNCBEImOehwdl8o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RiIYV1U4Tbnv/8HHD8CFDZUZOPkqtduLak8NTTl1HXaBnjlV447nr90C3vC4UHftW/QH1IK088E+8SCh2MsuTrOcfpjgimHbUKPc1m2toQ/2JC6ED69ZSj/65y+jwMRwuC7V6hLvHRPGOVOeOoxoUZflXoXWIEyGLs/0TdqUe2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ljn+XN/b; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ljn+XN/b" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45cb659e858so15910785e9.2 for ; Fri, 12 Sep 2025 09:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757695364; x=1758300164; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wqiZoJVgMOmFeDlGNdTZ/DvTlXJdgaRd3JdTxV/yzP0=; b=Ljn+XN/bHnxEwHqbabHvT+qDMajLC6QXB1WLv9W4O0ncgt1C1HmCR9oEz7R1xSYUtr x0H4o1WdToBo8DQvwkU/QKNCDVncUyKhm8RXOPbcSYSWngEbXIjbB4bLxKaafsA0B7jV Ju96A50LGtriPcIeWbVJWfvZR7ZzJzgnqVhxBqw0TyWH1qbDUWXtNlAo71IanXdaP5rx HNfruVkVkBVU6lYPW9HPmKdREMl9QIiXG5JdIPzAH/Yq2HUSnhDRM4PNcGKLKiULXGDM wSr025fDseq4bN7Euc34MTXj2fLwLoH4OBN654lB7eUoxBO6WwC1kUjcQvqKFrSyJPlt 3SIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757695364; x=1758300164; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqiZoJVgMOmFeDlGNdTZ/DvTlXJdgaRd3JdTxV/yzP0=; b=B3cO2CiHcefKYPYSvCMoHwDtyZEYpG6ZwLIM6iMpH6aLSjVf/v/mNSR64LjAoMqtAI eTAXEThQA7yaHuGtHpXY12jtTL3ww9UqJRZePq8l/1EhwXPMx0khTKB4UETAYij01Xw8 ZfGNHBrJWGfoLtm4HsSa+WBFO3PzuryJjNOU7f2jWkRD64cK1FKJaBgvSpCMwafkvWwu eBm+807/8vBaM1D7HOIHYFckvJ31kjqMyo0Awr6cT7hErp352/C18dowJNexb/rqeR4D 8Q/hYjg7qKzpjeH4E4QfdqU0KhVLqLJTQyxWI+OvryxGNuJb91xv/CqrWhBCQU7uzmul pczw== X-Forwarded-Encrypted: i=1; AJvYcCXPpDK3rjxXUAogplGBrYR1zelLfkuwcBWABW3R8qIbkKebnQy1kvGosptn3gcff0LrQFCQ/AKBhWZ7Ci0=@vger.kernel.org X-Gm-Message-State: AOJu0YwsT4WnZ+vbUKTTHDoF3CqzPbizBWbqXQja+bRe/DhhoBG7G/Au oCvtphtH4OHaZWzGAOed/YyBuCRWwM77qoKcykIvhJPfCNHz4H4yfL9/ X-Gm-Gg: ASbGnctUL4UsTl7XwZu8l7hCUvC67gX3sLf+7JuYFt43J7i2AJpmWPI+SOB7lJjUIY1 DLIwP57z4m9kEcvpVbklBierVK2tlCsSheHyybVi4ocHiHrFdFCM5z7F5/Be3Uw0zb39kmZCPLz z86weDEO3yzcoJTAwr8TUhwfYVm8REnwZ67snGrgZH4UbAYEMBgZMZBGyxx+MTeXTbkfjmehGEY o5zwz72EKtJc994oLhIkiH3YVlOt3KdrbzdSe84yaogYetP0jTf8uH0aOM74dpKBJ2ZraAf/k8Z p6eorok5pIoEhB/FhVR/SaTsI6osg/J+QUNmnwVafzwp8kar3QLx5seAzfABJR28o6EgttolXRu HXd5DEDnOeHiXeocJlkWVPzeYdzdKRV/jwmX1cQGg9vo/2kZhX4C75rOVHrk34TEuIUq+Kw/uak AHVBxOyZVzug== X-Google-Smtp-Source: AGHT+IEXS2pOOoqyUGEyr9k2erY2e78Z3kuSD92aGvSLgW0w5dzdl2COsGyUAMxnuPKhgacOKyiX3A== X-Received: by 2002:a05:600c:19c9:b0:45d:d291:5dc1 with SMTP id 5b1f17b1804b1-45f211da6aamr36954765e9.15.1757695364107; Fri, 12 Sep 2025 09:42:44 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd415sm7086696f8f.30.2025.09.12.09.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 09:42:43 -0700 (PDT) From: Iker Pedrosa Date: Fri, 12 Sep 2025 18:42:11 +0200 Subject: [PATCH 3/5] drm/solomon: Simplify mode_valid() using DRM helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-improve-ssd130x-v1-3-bc9389ed299e@gmail.com> References: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> In-Reply-To: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iker Pedrosa X-Mailer: b4 0.14.2 The ssd130x_crtc_mode_valid() function contains a manual implementation to validate the display mode against the panel's single fixed resolution. This pattern is common for simple displays, and the DRM core already provides the drm_crtc_helper_mode_valid_fixed() helper for this exact use case. Signed-off-by: Iker Pedrosa Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index c6939377ec4b5a42ce0f40d070ce60d544d8516d..2058d188159c3eae28de1614b9f= ffb06ac5551be 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1470,15 +1470,7 @@ static enum drm_mode_status ssd130x_crtc_mode_valid(= struct drm_crtc *crtc, { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(crtc->dev); =20 - if (mode->hdisplay !=3D ssd130x->mode.hdisplay && - mode->vdisplay !=3D ssd130x->mode.vdisplay) - return MODE_ONE_SIZE; - else if (mode->hdisplay !=3D ssd130x->mode.hdisplay) - return MODE_ONE_WIDTH; - else if (mode->vdisplay !=3D ssd130x->mode.vdisplay) - return MODE_ONE_HEIGHT; - - return MODE_OK; + return drm_crtc_helper_mode_valid_fixed(crtc, mode, &ssd130x->mode); } =20 static int ssd130x_crtc_atomic_check(struct drm_crtc *crtc, --=20 2.51.0 From nobody Thu Oct 2 18:15:51 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB253203BF for ; Fri, 12 Sep 2025 16:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695370; cv=none; b=jsYrhMkImtEd3aUQWIKFMCMp/r2GFmDV7aDRdLrjMbY6QCSEQHJIMctv9Fom6Aj+5hedUlRJdOritiaGncgbw0poSCG4jQgNl3uenILNU00DFJTecx6Zhlmcna5ZqOWyh3panvcCTHoeblNHQjepUa8vDLxZneW/AkYsnC78VBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695370; c=relaxed/simple; bh=Fei2JLl73dmjplKfRszReY+sa+vv7AHK9iZ2Xfstrwg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O90hoaah2LqU5dFSTOLse3rWberE6NpqvMh+IDuBgPeNH0sPP+PuYcEs3dK40NH6ah6mTltLeVQTyfyB8mdRejTQiVUjrCbfRGg2Y/aBMU6lK1RHcp7ynV8VqgM/6PjmS4xcp/FEhX7Na9N78IVszUNo83I+WNN0v34qm1pcT78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GERmBQTV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GERmBQTV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45b9c35bc0aso18352995e9.2 for ; Fri, 12 Sep 2025 09:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757695365; x=1758300165; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KFENQRkaHWGLQP/LJzCU4+3J7bwp0+IQHEZ8jQOM3aY=; b=GERmBQTVwWZOFLqoB2UkqUCe5IWkUod5HkW/lfEXJt8Oy7HLzpkoEEMutiE/bM12gM GeDXBxQpYca/BqJB91bznPNGSZuRdfsYZlG5FfCANLRURZpXrs+lVsDaC38gAv16at/P 8Ex+SojjRBoORlNuNkGvAFMuXH6W2rdtl2bMlh54vK4zn18xbXwiNEZR4k7xNFuK8u9G Z88y/TwdPg4M9w5UbGhIDySxEA3wRGnR0ZIm0je0pn8zWmwhUZBki/eLvtlC5s6KsW86 esEqlx9GD/Bl1qGbaeX1K5RCVOXqEy/fujnR9B2qEtGKkMR4xfeICHnOryeEpHNvkDe1 EPqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757695365; x=1758300165; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KFENQRkaHWGLQP/LJzCU4+3J7bwp0+IQHEZ8jQOM3aY=; b=wR5LbUsTUm9vuxpFvDxK6FLClyruKZBetVuZ+oh5kIam4WXJdmvdBrfdoxhPez6odU DiqJBAhx+dkcJUA2l8Tnmn15PDJbctFNlxH1mFT/E0HjP7NOisocC9cZmixw/GrF33HA ccfv+9ILRCzohlC6lcPOYXuUvbdqUBa/LVOgMr9gjcCtM7rjMROIghw14tBIfGxaY+LB r4e1tDXuCrZALYneDujuLr41g8Gv+H0ZEndc6hM6lZAn71VXpxxjwNgc238VHTKNELtg Z6Ls32Z3uKXugdp/QpKvf3iijQJOF2xuq9Dh99H4d6ob2Z0JGeyPu8cltpzO14Qnx2JI QRKQ== X-Forwarded-Encrypted: i=1; AJvYcCVHY5cqwM+E3LOCZwT35nu6c0cbmlAFAyVmifczJ+/KYvaDOyaMq+ECNuoXHMxgNW8Sd7uus2ukDFCHExo=@vger.kernel.org X-Gm-Message-State: AOJu0Yykdo18Qf8tcvwkSkjB5CrYXneAv/jBeJwwdLMds6Z0AiQwAONV KUDpzDEMbFG88NunUrMrjCvhwwrtN0h/eLH8UTqA+fXY+Zv3gFnpb8Zd X-Gm-Gg: ASbGncts4EkHvgfYVQZ4Z9YuAd7AbLOXzbjDey0SrE/Xa4IH3MSd5J9jkOhBeC+sRIh Ya3KkatovE7tGBVTfsaMujsgF23mAy0rhD4FC52UBZsW7d27LDKJXiIJ290018AQd2PPS2EFbgf uZufCmHEheZEULotfn9GjP4JyHxIE7I/G6k8xfjQBWIU4KagdZibjkHmxQRKwKqQG6JaPnxstbT 62nD7R8iFCxBa0qvnyMcpdBpvLbV6jO5iih3r1k6c/ow7OhHinuAgNktq47yqwvBN0pHJED5AVn Eam36WklPxRjJFrj8dnA0pxUhgnNJokrmhhZiX/wdAW+dJXjmm2y40UBIf20Q5kS7hEHM2dRxQD 2J26O5y/YkSylAEpbP04U5IQYWx/TMAPQtxQmFXu70lZ3KpM/sh8vb0RR7T4G3owa0aPRLuefH6 M= X-Google-Smtp-Source: AGHT+IFUXlWlMsI+O3HCeBbRHHVgWy9WXZNhNJzCqjRktFunB1HznFupXLMqa6IWJ2R3netjj8TKLA== X-Received: by 2002:a05:6000:2389:b0:3e7:6268:71fd with SMTP id ffacd0b85a97d-3e765a4c887mr3756492f8f.52.1757695365250; Fri, 12 Sep 2025 09:42:45 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd415sm7086696f8f.30.2025.09.12.09.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 09:42:44 -0700 (PDT) From: Iker Pedrosa Date: Fri, 12 Sep 2025 18:42:12 +0200 Subject: [PATCH 4/5] drm/solomon: Simplify get_modes() using DRM helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-improve-ssd130x-v1-4-bc9389ed299e@gmail.com> References: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> In-Reply-To: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iker Pedrosa X-Mailer: b4 0.14.2 The ssd130x_connector_get_modes function contains a manual implementation to manage modes. This pattern is common for simple displays, and the DRM core already provides the drm_connector_helper_get_modes_fixed() helper for this exact use case. Signed-off-by: Iker Pedrosa Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 2058d188159c3eae28de1614b9fffb06ac5551be..7bdccb5140195a45d8ffd01e139= dd4eb2e3cc327 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1729,20 +1729,8 @@ static const struct drm_encoder_funcs ssd130x_encode= r_funcs =3D { static int ssd130x_connector_get_modes(struct drm_connector *connector) { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(connector->dev); - struct drm_display_mode *mode; - struct device *dev =3D ssd130x->dev; - - mode =3D drm_mode_duplicate(connector->dev, &ssd130x->mode); - if (!mode) { - dev_err(dev, "Failed to duplicated mode\n"); - return 0; - } - - drm_mode_probed_add(connector, mode); - drm_set_preferred_mode(connector, mode->hdisplay, mode->vdisplay); =20 - /* There is only a single mode */ - return 1; + return drm_connector_helper_get_modes_fixed(connector, &ssd130x->mode); } =20 static const struct drm_connector_helper_funcs ssd130x_connector_helper_fu= ncs =3D { --=20 2.51.0 From nobody Thu Oct 2 18:15:51 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40CF31E10A for ; Fri, 12 Sep 2025 16:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695369; cv=none; b=c4vw3GL+Dc2Bmi79Ri9dciJzsYz8ocr2UAPMqnsdv8qj5PtqZuDNm31kXYLy/SZjFG6NVfWr3aLLr69oUgCGNNYqqfWKkPDVZGDkHiVtLOf90CNPxQoCTwurg0Cn8Afzes9QnJNYDZjOezDpWxi/G0t1Ir7OJqWRJLlsNM3J2bA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757695369; c=relaxed/simple; bh=lZaPWL908OVj4SrzNG7Ubz2Oo21Sbd6XaAvjzfQjEMc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pz3BkjIt8SCMYUYhNX17Y+C5zndrxprQryiOVEyHzROAQ0trv4cTYCY+trieYMuXiXL45jzPvdKXWNP8t1pR2YqPeIUKihu087wph7hEsOsvWPPQoVTKMEkMDsqc3ghH0s9jPJh2qYIGxh99mHS7wGGn/TQcYfZzl1XM8lbJ9gM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TUb+E3YN; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TUb+E3YN" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3e249a4d605so2331722f8f.3 for ; Fri, 12 Sep 2025 09:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757695366; x=1758300166; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eLwAUPbOiAmud7bKZYKSB1YsNPeEWpmZUaenVfyVXkU=; b=TUb+E3YNSSIIFwhlqi1V9rzcVdKEbiAvytIqL4poSIe5F+xiCiXqZH/MHLi8mdySCe MOtXLWJDV6XB4fgbVIzx7xdGLbmfTNbHoy2Uzcmnso0yePwzezzdER7/hXcZ82BFIZKG tOILUieIeYV4KfjP026WqdhcqPKg5Ytga3lxG8yPtMJpBrenO+ApASoTB/ts9mjDR9GN 2lfwY33opi53YtygX18nKnww/ML8ZjFHnUUl6w0wpystTav/A1GqO0bRzjc9s1bVzKI4 yEVm9PQd2numkK/ROiWaErmeQmtU2kcfiIWPINOdmkqqowPxixod1hJHalpPtNy4S9kR Ny4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757695366; x=1758300166; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLwAUPbOiAmud7bKZYKSB1YsNPeEWpmZUaenVfyVXkU=; b=eI48TUXRZ228QowKWO+XQ73lIP7ErSargBnLsAHnqQWk9Cu1zKrTHezeInflgr2Nsu aKUrG79IgLljhJ7Yk8nJa8rIFHrLrEqYrp4ThD8ah3FSrtQZzGD26zbwNXdcdafOtmgB IDzuFviOldUH3vaRvkg50xkRPBdsFwcANvgFuwuozmNNljwAFcmFSdji2i0uL/19hJqV FIlND9YV2Z5elfDHxH8sYGRCjPir8aZLtHJ9e6wYVeZAyLhdMFqGcG0r3AqcnR2uHTxs KbpEr0nfb+FaPJb8KqHofU/pvXRNCdnWCdo6cldL78hTYfOZjhjWF84jcgCnBOt1KFI/ u9Zg== X-Forwarded-Encrypted: i=1; AJvYcCUbfPzT1Ba2K4gOofXfemtAUG8OrP32C9nLtDyxeJ/yv3LKuz9tkIjDi/cXKFYzmfHvGjSlMDXngvraejM=@vger.kernel.org X-Gm-Message-State: AOJu0YxQfqP1YNc666KFqyvz1X35QSRI+kUYEC4dY4wrrVPJvsp4ptKi /GG80toixe0fas6zY+mJcZ7u8M0v+llP1tBqnos68QxXdxe1CXXaDpH3UCcOdw== X-Gm-Gg: ASbGnctfzMajUBWSmOYYeSrcGF6qVM1rz5bZi63sX7hLnGZM8WV1DZ++IhkSmoIoWW3 4qFttaRB8A6m6T125ighL3u8IjvgHTT8c/gX9WsHqTkHZArm4wAWHg7iDSjDyCiLcGYSXeQeuA1 QdWJtNWZCkK394o7UXjq0KlDv4KEPW9L8ro4PHy3+6Ukbm803PmQeoFav+IIbp29pw9RTaHwSvn toIJ8OKzDhLkbhgalAV/UW/RQ0tUO/IX/nNIVDDdibpGR+BhowNNXiPvf4l5W7p5PLP+nChQ9aD NUjdPDknlU48dSVgRnFREmX0WnsAexWlIGBZ3n8EiaMosSGuptdZHANFNJlFLMqR866iEDGDL/y uirjbRKw5LUTH0XOn72I8ZNBnU218Uh4hV1E0bgsymocUXsb8ON4vxxggT6B91+8RN3VIjwHPak M= X-Google-Smtp-Source: AGHT+IEKnltXeeMvVDI2QemSGP+MIU6It7d9Of00qdZt9eZWQWOA1s5MS+l2BWMiGa13PqXhzaHkNA== X-Received: by 2002:a05:6000:402b:b0:3dc:eb5:503b with SMTP id ffacd0b85a97d-3e765a1607cmr3933540f8f.56.1757695366194; Fri, 12 Sep 2025 09:42:46 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd415sm7086696f8f.30.2025.09.12.09.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 09:42:45 -0700 (PDT) From: Iker Pedrosa Date: Fri, 12 Sep 2025 18:42:13 +0200 Subject: [PATCH 5/5] drm/solomon: Enforce one assignment per line Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-improve-ssd130x-v1-5-bc9389ed299e@gmail.com> References: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> In-Reply-To: <20250912-improve-ssd130x-v1-0-bc9389ed299e@gmail.com> To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Iker Pedrosa X-Mailer: b4 0.14.2 The code contains several instances of chained assignments. The Linux kernel coding style generally favors clarity and simplicity over terse syntax. Refactor the code to use a separate line for each assignment. Signed-off-by: Iker Pedrosa Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 7bdccb5140195a45d8ffd01e139dd4eb2e3cc327..a09e64719f62562126851e67c4f= 77d779b861148 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1864,10 +1864,14 @@ static int ssd130x_init_modeset(struct ssd130x_devi= ce *ssd130x) =20 mode->type =3D DRM_MODE_TYPE_DRIVER; mode->clock =3D 1; - mode->hdisplay =3D mode->htotal =3D ssd130x->width; - mode->hsync_start =3D mode->hsync_end =3D ssd130x->width; - mode->vdisplay =3D mode->vtotal =3D ssd130x->height; - mode->vsync_start =3D mode->vsync_end =3D ssd130x->height; + mode->hdisplay =3D ssd130x->width; + mode->htotal =3D ssd130x->width; + mode->hsync_start =3D ssd130x->width; + mode->hsync_end =3D ssd130x->width; + mode->vdisplay =3D ssd130x->height; + mode->vtotal =3D ssd130x->height; + mode->vsync_start =3D ssd130x->height; + mode->vsync_end =3D ssd130x->height; mode->width_mm =3D 27; mode->height_mm =3D 27; =20 --=20 2.51.0