From nobody Thu Oct 2 21:27:33 2025 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F4DD342CAC for ; Thu, 11 Sep 2025 13:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757598653; cv=none; b=ErE8HEG3ljw6ptz00AmyouvKGaVDfu/gnblKDoVCw5iwUwsPBNnZLAv44yXHFodTbYlX/aZ6LW6d7cjaPPi6oo/Oc747QhbRxM432MMZFxcFuAlSQP/rmD38a079jz7IDQ6KGROGJN/08b7VH1YuZmhgW7JValt/p8aO5jqVwRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757598653; c=relaxed/simple; bh=ljVsBiUSoqP9nQ6E/AbsEzgi5WJ+mPSnwPoiSvNWF84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mb96n1DlX4LrXra5LAGopxE7wtDSYOv0uH6JU1Va0cVnQGbCXhmG1uFeXiZf+eQaBp+jhDZC+Ttwy6R6+Teuhg9dVu0se3SJOVOONHU1T3+Ib6txDs6SsEMkMSh2t8RZsj5wBYid5TArRHKe/YF8zT7mtVzNPi0awhh7yRPkIXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Oi8nvu2G; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oi8nvu2G" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-71d603a9cfaso5633097b3.1 for ; Thu, 11 Sep 2025 06:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757598648; x=1758203448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r7AlbrbWF01PAGMb+n5yznNoBl+a3KG2eoPDEibc0TE=; b=Oi8nvu2GhqmYk3tturpJWEuSTV1rgaqOVoiOyNFmxxGtwMguvhTjYTRpjkLEzyjFk6 Bxb+dxYTN4gOgUyIj1y1KWDi9uBvSR6V7BnZGCAuIT8CDjOuzxtMIuRpJmoErsqEssQ1 gedDTUzS6zD6Rmh9gW3bjc7bkdZjoVcAyPodfmqwmvrnf8eTzmqv8jmxwi15WNqo6uBV 2g+Q2zSQARWr/Qt01Rtyi/OopVLolo1PBOv6YH+8RrRRNHebGr6WJHq/syQyUBtRnX1K zmE7k7N1uOy1I5ZCz7OPAteHOG4t/xP3Sym0+KrhyniALmJbi9xt5G6DRdvpnXIXj+6G TtWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757598648; x=1758203448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r7AlbrbWF01PAGMb+n5yznNoBl+a3KG2eoPDEibc0TE=; b=K0VDC3kA0u+WRxMNKkzge+EqbaFWrIudaJsQsqdywqwJpeZXVf1xH+QIuC5RoWPNjr x9FLWujPITbv1+B/mNBBmtgnz36yqdRDUecvLf6GcMnc78vlZjPcCa+b67MB5Uwh4L7b YRIP075J8AYhMYncoSMoLXHRkbj25pizXBCoGTMOHWUFlgn2ecJTsDZUyjbXb/yx8B9C VZv41IiYsVivjVP9pY5tnpc/byM7oiQH3tjwvNP5NNc59rTrK3mwR/K8dvVvPq8ky0Yq 0u0hZ0VZQ0vb8zqc4M1iE1Fjc0xN+ceRrd8fT47PH6ZLdnfLGj2F5TITpAJwkgJQDdzj z0Mw== X-Gm-Message-State: AOJu0YyiS7spp3RXTm1AuqVGJh6l20yUr4VzmwElycwrfWHsN26elAkX 6OVQ6uvAozovjHE7zfFYERY8tjhn4jGTwtr+h1Udyig+YLf0vGYa/036+qGgj5ZcfSPjJlmi5sQ cOWnFOBXboQ== X-Gm-Gg: ASbGnctyng6wZ9sJwOM+xNvAIYSgEElvUr6lq6Wln+8wr6GroQDekikjHbiowRYF2SH sXCtk5kgiWrLN3J3c+uUZGmAGpndX2n95XO1WJVigu1UfuVvXuXgjYDpXrWvh/h5yluKoL3wqSC QZCG3Z46TlGuH0GBEYm+OO0GueDprjczOUXMA0yPQnANJzh56LFs2eIp8L/1ytq3owCjpJHtWez kpTOqj2KTlW5pPv+TS8S82Y0Emcd4prnj2jki2G0fiUcdVctw2TMtzaH+73kLpjBCsfDU/gw4nV WJss1xvVrUcl0eT+RLKRgzDX5nouZH3wXlRBgZt/mCBFgFxqnOtBq904lD8bzj5d+35sV0tKkQ8 b1Zp7cPpNLX2TqvFPU01Yxf89DbslsOG3MSUntgoJCjJY16O6sUn2EN4Yam0tuZr8m+28qlRbdC 2ri7JRTOG5eg== X-Google-Smtp-Source: AGHT+IENGIldq5JqNWVYj879nv5c12Hu2gAcLXkQcT4am7WHRztg/K9ENUf9gRzRFcua+CJvdep3gQ== X-Received: by 2002:a05:690c:4d88:b0:724:2cad:8df6 with SMTP id 00721157ae682-727f2ebd695mr176268437b3.16.1757598647587; Thu, 11 Sep 2025 06:50:47 -0700 (PDT) Received: from rayden.urgonet (h-37-123-177-177.A175.priv.bahnhof.se. [37.123.177.177]) by smtp.gmail.com with ESMTPSA id 00721157ae682-72f7623434csm3526257b3.11.2025.09.11.06.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 06:50:45 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org Cc: Olivier Masse , Thierry Reding , Yong Wu , Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T . J . Mercier" , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sumit Garg , Matthias Brugger , AngeloGioacchino Del Regno , azarrabi@qti.qualcomm.com, Simona Vetter , Daniel Stone , Rouven Czerwinski , robin.murphy@arm.com, Jens Wiklander , Sumit Garg Subject: [PATCH v12 6/9] tee: add tee_shm_alloc_dma_mem() Date: Thu, 11 Sep 2025 15:49:47 +0200 Message-ID: <20250911135007.1275833-7-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250911135007.1275833-1-jens.wiklander@linaro.org> References: <20250911135007.1275833-1-jens.wiklander@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add tee_shm_alloc_dma_mem() to allocate DMA memory. The memory is represented by a tee_shm object using the new flag TEE_SHM_DMA_MEM to identify it as DMA memory. The allocated memory will later be lent to the TEE to be used as protected memory. Reviewed-by: Sumit Garg Signed-off-by: Jens Wiklander --- drivers/tee/tee_shm.c | 85 +++++++++++++++++++++++++++++++++++++++- include/linux/tee_core.h | 5 +++ 2 files changed, 88 insertions(+), 2 deletions(-) diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c index 76195a398c89..e195c892431d 100644 --- a/drivers/tee/tee_shm.c +++ b/drivers/tee/tee_shm.c @@ -5,6 +5,8 @@ #include #include #include +#include +#include #include #include #include @@ -13,9 +15,14 @@ #include #include #include -#include #include "tee_private.h" =20 +struct tee_shm_dma_mem { + struct tee_shm shm; + dma_addr_t dma_addr; + struct page *page; +}; + static void shm_put_kernel_pages(struct page **pages, size_t page_count) { size_t n; @@ -48,7 +55,16 @@ static void tee_shm_release(struct tee_device *teedev, s= truct tee_shm *shm) { void *p =3D shm; =20 - if (shm->flags & TEE_SHM_DMA_BUF) { + if (shm->flags & TEE_SHM_DMA_MEM) { +#if IS_ENABLED(CONFIG_TEE_DMABUF_HEAPS) + struct tee_shm_dma_mem *dma_mem; + + dma_mem =3D container_of(shm, struct tee_shm_dma_mem, shm); + p =3D dma_mem; + dma_free_pages(&teedev->dev, shm->size, dma_mem->page, + dma_mem->dma_addr, DMA_BIDIRECTIONAL); +#endif + } else if (shm->flags & TEE_SHM_DMA_BUF) { struct tee_shm_dmabuf_ref *ref; =20 ref =3D container_of(shm, struct tee_shm_dmabuf_ref, shm); @@ -268,6 +284,71 @@ struct tee_shm *tee_shm_alloc_priv_buf(struct tee_cont= ext *ctx, size_t size) } EXPORT_SYMBOL_GPL(tee_shm_alloc_priv_buf); =20 +#if IS_ENABLED(CONFIG_TEE_DMABUF_HEAPS) +/** + * tee_shm_alloc_dma_mem() - Allocate DMA memory as shared memory object + * @ctx: Context that allocates the shared memory + * @page_count: Number of pages + * + * The allocated memory is expected to be lent (made inaccessible to the + * kernel) to the TEE while it's used and returned (accessible to the + * kernel again) before it's freed. + * + * This function should normally only be used internally in the TEE + * drivers. + * + * @returns a pointer to 'struct tee_shm' + */ +struct tee_shm *tee_shm_alloc_dma_mem(struct tee_context *ctx, + size_t page_count) +{ + struct tee_device *teedev =3D ctx->teedev; + struct tee_shm_dma_mem *dma_mem; + dma_addr_t dma_addr; + struct page *page; + + if (!tee_device_get(teedev)) + return ERR_PTR(-EINVAL); + + page =3D dma_alloc_pages(&teedev->dev, page_count * PAGE_SIZE, + &dma_addr, DMA_BIDIRECTIONAL, GFP_KERNEL); + if (!page) + goto err_put_teedev; + + dma_mem =3D kzalloc(sizeof(*dma_mem), GFP_KERNEL); + if (!dma_mem) + goto err_free_pages; + + refcount_set(&dma_mem->shm.refcount, 1); + dma_mem->shm.ctx =3D ctx; + dma_mem->shm.paddr =3D page_to_phys(page); + dma_mem->dma_addr =3D dma_addr; + dma_mem->page =3D page; + dma_mem->shm.size =3D page_count * PAGE_SIZE; + dma_mem->shm.flags =3D TEE_SHM_DMA_MEM; + + teedev_ctx_get(ctx); + + return &dma_mem->shm; + +err_free_pages: + dma_free_pages(&teedev->dev, page_count * PAGE_SIZE, page, dma_addr, + DMA_BIDIRECTIONAL); +err_put_teedev: + tee_device_put(teedev); + + return ERR_PTR(-ENOMEM); +} +EXPORT_SYMBOL_GPL(tee_shm_alloc_dma_mem); +#else +struct tee_shm *tee_shm_alloc_dma_mem(struct tee_context *ctx, + size_t page_count) +{ + return ERR_PTR(-EINVAL); +} +EXPORT_SYMBOL_GPL(tee_shm_alloc_dma_mem); +#endif + int tee_dyn_shm_alloc_helper(struct tee_shm *shm, size_t size, size_t alig= n, int (*shm_register)(struct tee_context *ctx, struct tee_shm *shm, diff --git a/include/linux/tee_core.h b/include/linux/tee_core.h index b6c54b34a8b5..7b0c1da2ca6c 100644 --- a/include/linux/tee_core.h +++ b/include/linux/tee_core.h @@ -29,6 +29,8 @@ #define TEE_SHM_POOL BIT(2) /* Memory allocated from pool */ #define TEE_SHM_PRIV BIT(3) /* Memory private to TEE driver */ #define TEE_SHM_DMA_BUF BIT(4) /* Memory with dma-buf handle */ +#define TEE_SHM_DMA_MEM BIT(5) /* Memory allocated with */ + /* dma_alloc_pages() */ =20 #define TEE_DEVICE_FLAG_REGISTERED 0x1 #define TEE_MAX_DEV_NAME_LEN 32 @@ -298,6 +300,9 @@ void *tee_get_drvdata(struct tee_device *teedev); */ struct tee_shm *tee_shm_alloc_priv_buf(struct tee_context *ctx, size_t siz= e); =20 +struct tee_shm *tee_shm_alloc_dma_mem(struct tee_context *ctx, + size_t page_count); + int tee_dyn_shm_alloc_helper(struct tee_shm *shm, size_t size, size_t alig= n, int (*shm_register)(struct tee_context *ctx, struct tee_shm *shm, --=20 2.43.0