From nobody Mon Feb 9 17:34:41 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A024247280 for ; Thu, 11 Sep 2025 04:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757565204; cv=none; b=LPw3XvUP/36CY2A6yioYiMiKUO90xLUN8yjRYcb60t4K91IAU/3Kt9rV44wxf7z9fE2DdKMufGBoeNnwpHsdU+qkE/5vIIPs+i7lCBXF1Qeo1FUkypX7bYVg6m1vFe3dbaTQAMT+4nGCJsWG1Hd2HhIPYFWgLE2HIGbRPhdGViQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757565204; c=relaxed/simple; bh=xw0q4NcwHHSieNerwzr051tx91leTFsT79dNH6hi6Gk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Dhx+hbKmDKyZSXrmhApBrG+CKmZdI4gP51HZ+R6ch2/wwBZaNyaZbOygqCEcpTPctfTh/lKrEECqovBIrcvmIp7irjP+eteK0o60vfXnu3dVyH5TkCrpoD7uF2HtjUiH7BA3T+YOYLW7CWJqsVrInZvyQsMvN2WLq//pKB28YXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ofz02RjW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ofz02RjW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58B2J1pw007124 for ; Thu, 11 Sep 2025 04:33:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ejmKrdCNEld h2vZcjwyV0oT0m8cVWo38CkmzCmn2HDo=; b=ofz02RjW3/Zp/XxDwwQwsWRh8A/ SMmjQ45uby2p2n4TTjO+Ix6NIBQGWRNYFOeKfeSvJ98DM0G5dni/aGoTn6+1yGej aWSxJWCcmedhe5arx0mksRCixBTz83mG/FJKX/GmuEZOqq3SqM6+ietIyJlw9Bso lm3wVgDL1W/sD9tDv5kcQACEwA1wC0cNSDf/EiuAMhLVWFLMrTWRWgG/0heJEyLW WloZsjo64syjDmIWx6s4pLplhbzCjpx8jXZQzsmtSCS8XSj50wE8iIl+tXACfRsI z7C7vAOkJZKqFAlhi0+zK2ik21zBeMGYPZICBmB+eiO+25edwnPvDncqDBA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490e8ae6yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 11 Sep 2025 04:33:22 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b5242b0f450so261428a12.0 for ; Wed, 10 Sep 2025 21:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757565201; x=1758170001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejmKrdCNEldh2vZcjwyV0oT0m8cVWo38CkmzCmn2HDo=; b=mUO+4woIAWjlXaqqI01W5xY2+ZAW39IVEVcB3x5dUlJBgfGtP/zk5lMAAFqioDu6Gl C0Sp5kq0lI+npuqhY4lRJElZJYpPnEkAbf+CXZp972jWh0/qHwgVx8q4WjiAMIqiTdVe ntlWh5nvOxljLcbM9Yq5YdNUJFklHlB9PqFkaRuMg2uFWVZbkWuNmFcsdGl7kmdX3yBP Zq7GNz/FOcRdnpvhAnK6MyGGWXhvKqfV2qFd+zPgEO1EhThIPbJgqNLTMsPv5jFpjjD6 wyyNnwi0UWIO8ZsUET8hIvH/0FkyGyMCINcYLod1i/65ShfaHg274+VN3TQU6IZLyW85 rsmA== X-Forwarded-Encrypted: i=1; AJvYcCU1FNfqoHXIESqakljq1qG4aR1R063MqIvrhlcVbKGpwxmONgWHaP2qZ8veaQvYB3o1ljrmo+Ey+dYNeew=@vger.kernel.org X-Gm-Message-State: AOJu0YweBvSkoqbO20W8Tf/yUSBEVzSoLYOFUiKlsPUngNx51qPrvwQu 9H2aW2sBRo78S3xjLUuO7Y0IxpraCPN4aeLmM+C8/hgYrlQPE/hZw0Tb7sBgL66oCVjdXLYNsae PobHh0iTfzg6T9zaWd1xXjOy+lnmG4i+cBgilSfVzZfgJmRYiMQ41pNMNN4sf/zVeWWQ= X-Gm-Gg: ASbGncsW6q+Ud+Sj7dLQW4Z2nzPV5MYFzxbpCr/D35hNuP0FlMaA7mzMN8PelQQNg80 1R/NNAQ6leW4FtX8o2KoJ3VG9IuePm3cXNR9BccdFq2RpU+kPeTfe6lYF9/tzh3kUW6H42LEnQY OICttXyUzYNF3IofV6bX14Qs9A3QW0ymnXBNxw8Ab+37tZ9uvMc/q/F7YAijAgUaDMQ7Y1Gx/VD mnDFoimngraNSMclbvLEiCjhisKJD+dytBHpWUrju0ZDpsXS3Z1EAvsCVX0YuzOGf62MoIYcnKV 765sBaou0xteFaKoBMoh2Y/wotriT524h+7J5g8msz4C/RD+SDs/1LGQNgsf8Q8haZsDFBfyLle e X-Received: by 2002:a17:902:d60f:b0:248:6d1a:4304 with SMTP id d9443c01a7336-251715f313fmr234729755ad.38.1757565201171; Wed, 10 Sep 2025 21:33:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJ7A0F6WCIjNO2Y/9hW5CAwxfdYIL+kP6hhmDpJXN4sGHF3R8Sfwt9fcXfmuZlD03HByRPUQ== X-Received: by 2002:a17:902:d60f:b0:248:6d1a:4304 with SMTP id d9443c01a7336-251715f313fmr234729435ad.38.1757565200678; Wed, 10 Sep 2025 21:33:20 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25c3a84a46csm4323975ad.91.2025.09.10.21.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 21:33:20 -0700 (PDT) From: Viken Dadhaniya To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, andersson@kernel.org, konradybcio@kernel.org, broonie@kernel.org, johan+linaro@kernel.org, dianders@chromium.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org Cc: mukesh.savaliya@oss.qualcomm.com, Viken Dadhaniya Subject: [PATCH v7 2/6] soc: qcom: geni-se: Cleanup register defines and update copyright Date: Thu, 11 Sep 2025 10:02:52 +0530 Message-Id: <20250911043256.3523057-3-viken.dadhaniya@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250911043256.3523057-1-viken.dadhaniya@oss.qualcomm.com> References: <20250911043256.3523057-1-viken.dadhaniya@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=H7Dbw/Yi c=1 sm=1 tr=0 ts=68c25112 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=cWaLTDLleWsxmrQceUoA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: EMw3rGOdX9V6K1E2AhjS6PT6aeDhJfGX X-Proofpoint-ORIG-GUID: EMw3rGOdX9V6K1E2AhjS6PT6aeDhJfGX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzOSBTYWx0ZWRfX9sBvr2Aebtn6 s2fVxMjpx7EaXZGFyFHmsD/h2ejlMoYe2lssMGNEtXye2/JSvY2cZyP3C/KQhTaOTnwLedtCbUQ jT3DG5vVT7k+sevIqs4RZW9DMSgj0Zh8jkGcv5pL+KGjPspKdXq98MZj0j98740xOmSygnTLO9D mG+uGXOJYdl4i1xgDixXwlw/RkcD7FnZDuSdtdMxn+t+DnQgySG6IymzF1UqGhvbXcMRG9uC/kF f/hEokNw+zCEeOkItlof9NNU4YO/GYvhRkBst0r8SQzIgSXJn2o3IkExqX9ANVSSUqiQptS2wd5 32NBfRJZHTugHAivi46e6tRMKzMudMxoDF1U0OhiiosI02XEWTjH9hng7BRGB6nsIHNyNHmjMzB 72GE65pJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060039 Content-Type: text/plain; charset="utf-8" Refactor register macros for consistency and clarity and remove redundant definitions and update naming for better alignment. Update copyright to include Qualcomm Technologies, Inc. Signed-off-by: Viken Dadhaniya --- v6 -> v7 - No change. v6 Link: https://lore.kernel.org/all/20250822072651.510027-3-viken.dadhaniy= a@oss.qualcomm.com/ --- --- drivers/soc/qcom/qcom-geni-se.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 3c3b796333a6..e8ab2833815e 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1,5 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 -// Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. +/* + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ =20 /* Disable MMIO tracing to prevent excessive logging of unwanted MMIO trac= es */ #define __DISABLE_TRACE_MMIO__ @@ -110,22 +113,20 @@ struct geni_se_desc { static const char * const icc_path_names[] =3D {"qup-core", "qup-config", "qup-memory"}; =20 -#define QUP_HW_VER_REG 0x4 +/* Common QUPV3 registers */ +#define QUPV3_HW_VER_REG 0x4 =20 /* Common SE registers */ -#define GENI_INIT_CFG_REVISION 0x0 -#define GENI_S_INIT_CFG_REVISION 0x4 -#define GENI_OUTPUT_CTRL 0x24 -#define GENI_CGC_CTRL 0x28 -#define GENI_CLK_CTRL_RO 0x60 -#define GENI_FW_S_REVISION_RO 0x6c +#define SE_GENI_INIT_CFG_REVISION 0x0 +#define SE_GENI_S_INIT_CFG_REVISION 0x4 +#define SE_GENI_CGC_CTRL 0x28 +#define SE_GENI_CLK_CTRL_RO 0x60 +#define SE_GENI_FW_S_REVISION_RO 0x6c #define SE_GENI_BYTE_GRAN 0x254 #define SE_GENI_TX_PACKING_CFG0 0x260 #define SE_GENI_TX_PACKING_CFG1 0x264 #define SE_GENI_RX_PACKING_CFG0 0x284 #define SE_GENI_RX_PACKING_CFG1 0x288 -#define SE_GENI_M_GP_LENGTH 0x910 -#define SE_GENI_S_GP_LENGTH 0x914 #define SE_DMA_TX_PTR_L 0xc30 #define SE_DMA_TX_PTR_H 0xc34 #define SE_DMA_TX_ATTR 0xc38 @@ -142,7 +143,6 @@ static const char * const icc_path_names[] =3D {"qup-co= re", "qup-config", #define SE_DMA_RX_IRQ_EN 0xd48 #define SE_DMA_RX_IRQ_EN_SET 0xd4c #define SE_DMA_RX_IRQ_EN_CLR 0xd50 -#define SE_DMA_RX_LEN_IN 0xd54 #define SE_DMA_RX_MAX_BURST 0xd5c #define SE_DMA_RX_FLUSH 0xd60 #define SE_GSI_EVENT_EN 0xe18 @@ -179,7 +179,7 @@ static const char * const icc_path_names[] =3D {"qup-co= re", "qup-config", /* SE_DMA_GENERAL_CFG */ #define DMA_RX_CLK_CGC_ON BIT(0) #define DMA_TX_CLK_CGC_ON BIT(1) -#define DMA_AHB_SLV_CFG_ON BIT(2) +#define DMA_AHB_SLV_CLK_CGC_ON BIT(2) #define AHB_SEC_SLV_CLK_CGC_ON BIT(3) #define DUMMY_RX_NON_BUFFERABLE BIT(4) #define RX_DMA_ZERO_PADDING_EN BIT(5) @@ -196,7 +196,7 @@ u32 geni_se_get_qup_hw_version(struct geni_se *se) { struct geni_wrapper *wrapper =3D se->wrapper; =20 - return readl_relaxed(wrapper->base + QUP_HW_VER_REG); + return readl_relaxed(wrapper->base + QUPV3_HW_VER_REG); } EXPORT_SYMBOL_GPL(geni_se_get_qup_hw_version); =20 @@ -220,12 +220,12 @@ static void geni_se_io_init(void __iomem *base) { u32 val; =20 - val =3D readl_relaxed(base + GENI_CGC_CTRL); + val =3D readl_relaxed(base + SE_GENI_CGC_CTRL); val |=3D DEFAULT_CGC_EN; - writel_relaxed(val, base + GENI_CGC_CTRL); + writel_relaxed(val, base + SE_GENI_CGC_CTRL); =20 val =3D readl_relaxed(base + SE_DMA_GENERAL_CFG); - val |=3D AHB_SEC_SLV_CLK_CGC_ON | DMA_AHB_SLV_CFG_ON; + val |=3D AHB_SEC_SLV_CLK_CGC_ON | DMA_AHB_SLV_CLK_CGC_ON; val |=3D DMA_TX_CLK_CGC_ON | DMA_RX_CLK_CGC_ON; writel_relaxed(val, base + SE_DMA_GENERAL_CFG); =20 --=20 2.34.1