From nobody Thu Oct 2 20:44:49 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3B02E0B68 for ; Thu, 11 Sep 2025 21:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757627821; cv=none; b=t+hpIjv10cHxwZ+l/kWcCyyYS8VLU4ljd94NRQQdnsW+yvff3V8i/u9TxxzRHO+Dk+M1Uk9GEhwSfSBKvykIhp0sfkwinhuNTOsclQyP+toD0wnZkT0H3XTIACYKeFG8Y1WDHlbnHJhnItskV5orZ2Sq39Nno8gwPDHhH5uEAI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757627821; c=relaxed/simple; bh=YVmSvLmXA4fSHddIJODfvJPQ3kUAobuiJCXsXHGJMhg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=He/ZocKDuCmPyrgUgpDQvvm4GfVWc2a7uTY5ve1HppWd2CB3uW5J7GHnEU3+f5Y+4AHhoixbAVyciBYIzxwjmNkPpPvyoXLDqWtcgtvDzde9eYJvEZE0q9d7DPAEeV2GU1v1ZdaUyfoLdI5swwYi1JIISFZAg4O5I2LGB5/GO9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uwpHe-0004g5-G9; Thu, 11 Sep 2025 23:56:50 +0200 From: Marco Felsch Date: Thu, 11 Sep 2025 23:56:51 +0200 Subject: [PATCH v2 10/10] dmaengine: imx-sdma: make use of dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-v6-16-topic-sdma-v2-10-d315f56343b5@pengutronix.de> References: <20250911-v6-16-topic-sdma-v2-0-d315f56343b5@pengutronix.de> In-Reply-To: <20250911-v6-16-topic-sdma-v2-0-d315f56343b5@pengutronix.de> To: Vinod Koul , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jiada Wang Cc: dmaengine@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marco Felsch , Frank Li X-Mailer: b4 0.14.2 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Add dev_err_probe() at return path of probe() to support users to identify issues easier. Reviewed-by: Frank Li Signed-off-by: Marco Felsch Reviewed-by: Peng Fan --- drivers/dma/imx-sdma.c | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index a7e6554ca223e2e980caf2e2dea832db9ad60ed6..d4430e6e56deda7de3538e42af7= 987a456957b43 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2292,7 +2292,7 @@ static int sdma_probe(struct platform_device *pdev) =20 ret =3D dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); if (ret) - return ret; + return dev_err_probe(dev, ret, "Failed to set DMA mask\n"); =20 sdma =3D devm_kzalloc(dev, sizeof(*sdma), GFP_KERNEL); if (!sdma) @@ -2309,24 +2309,24 @@ static int sdma_probe(struct platform_device *pdev) =20 irq =3D platform_get_irq(pdev, 0); if (irq < 0) - return irq; + return dev_err_probe(dev, irq, "Failed to get IRQ\n"); =20 sdma->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(sdma->regs)) - return PTR_ERR(sdma->regs); + return dev_err_probe(dev, PTR_ERR(sdma->regs), "ioremap failed\n"); =20 sdma->clk_ipg =3D devm_clk_get_prepared(dev, "ipg"); if (IS_ERR(sdma->clk_ipg)) - return PTR_ERR(sdma->clk_ipg); + return dev_err_probe(dev, PTR_ERR(sdma->clk_ipg), "IPG clk_get_prepared = failed\n"); =20 sdma->clk_ahb =3D devm_clk_get_prepared(dev, "ahb"); if (IS_ERR(sdma->clk_ahb)) - return PTR_ERR(sdma->clk_ahb); + return dev_err_probe(dev, PTR_ERR(sdma->clk_ahb), "AHB clk_get_prepared = failed\n"); =20 ret =3D devm_request_irq(dev, irq, sdma_int_handler, 0, dev_name(dev), sdma); if (ret) - return ret; + return dev_err_probe(dev, ret, "Failed to request IRQ\n"); =20 sdma->irq =3D irq; =20 @@ -2367,11 +2367,11 @@ static int sdma_probe(struct platform_device *pdev) =20 ret =3D sdma_init(sdma); if (ret) - return ret; + return dev_err_probe(dev, ret, "sdma_init failed\n"); =20 ret =3D sdma_event_remap(sdma); if (ret) - return ret; + return dev_err_probe(dev, ret, "sdma_event_remap failed\n"); =20 if (sdma->drvdata->script_addrs) sdma_add_scripts(sdma, sdma->drvdata->script_addrs); @@ -2398,28 +2398,21 @@ static int sdma_probe(struct platform_device *pdev) platform_set_drvdata(pdev, sdma); =20 ret =3D dma_async_device_register(&sdma->dma_device); - if (ret) { - dev_err(dev, "unable to register\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "unable to register\n"); =20 ret =3D devm_add_action_or_reset(dev, sdma_dma_device_unregister_action, = sdma); - if (ret) { - dev_err(dev, "Unable to register release hook\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Unable to register release hook\n"); =20 ret =3D of_dma_controller_register(np, sdma_xlate, sdma); - if (ret) { - dev_err(dev, "failed to register controller\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to register controller\n"); =20 ret =3D devm_add_action_or_reset(dev, sdma_dma_of_dma_controller_unregist= er_action, sdma); - if (ret) { - dev_err(dev, "failed to register of-dma-controller unregister hook\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to register of-dma-controller unregister hook\n"); =20 /* * Because that device tree does not encode ROM script address, --=20 2.47.3