From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D6222126D for ; Thu, 11 Sep 2025 09:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583811; cv=none; b=DdHEgfZbS4Zlt2uVhRWSC2obRICXnDhBnJJL/jF4/hKFtnnD/fICnYg++IsdTMy3sMG8RgUuLPP/ySasrt8yjLbvf9ieJvmqF97/97Lkhf5nvB5J4MK92SMbE0o2G+y9eBE22E1ofeOD+MHsiyPxSWJ1uNrbDKt3ihsLAF/QPHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583811; c=relaxed/simple; bh=LQehtAx2kmaY57h5u012j/ttcRk/Yy2y8c0kuDacy/Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cfGQeHWTLybHD1wsiSYFbVviGRFGrzwsOYuHggdA+OsaFiPzX7f8NUvI610bkLV9whBXorPDotHeRHdLjor72JAgAZ1HnzOEM10otaVqwGGSJZ9XVXtK002AMwoFt2M9pD/RVHaHAaNJUmyH3zWUvezJpEN81/xZFmK2DSfce4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cXOB0Zoj; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cXOB0Zoj" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3cea1388486so21615f8f.1 for ; Thu, 11 Sep 2025 02:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583808; x=1758188608; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DJlYrA2HvnrAW5ag27Ypg8qPNoGajHDP94gxoPy/A6E=; b=cXOB0ZojmqUw30QW4No26lk8/jA9q+r+E90cCj7IYs49jMK+Pu7K38t9DNpfDhUtOD XIO0k4OpW0xIxlSoZ3Iakjyh2Xtfgsa4Faa2wOja5vZTgO/P0FCx8oCzBWtD1Fm5asgm tbhMuV1ok/uq2kGUM4Haf2qCSsL1jaTYssJg9QwIQrQu5Tawr8vdoYd2TKYkQdjeFMOT FvTdRcOz3Ue49No26BFtlxYtKFJpmR5WFQQ8YOAMAahKDdYP689Hz56dEuI3AyAkdX5Y Y35F6SWd4QxK6xk5/KQksCwIvCjO2WNHEEWOty5e54ts0OJ9/7kMxZVRo6i4W0Bd8B7H 76Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583808; x=1758188608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJlYrA2HvnrAW5ag27Ypg8qPNoGajHDP94gxoPy/A6E=; b=ljlTRFprcPr1CKasbnY1+mWDb5QsO0wLLPDQLUOhe+VINU0ttMrOhgtTH/AkL305D1 AhFyUNHyAubq8tYs9KjvedA5CFVae1HIN2suUavimA/p7DXOiqnTzs0GklYJ5K3+Dcd2 2yRfgI0qihcnyvi0RtK1SPCjkqM+Ihf1Qdb7gvcDkQSJFuibzv/77vcRgBBdprnoR3wP 97TYDbTUS5Obu4E/2DwI5Bv8eqwHQaIonpHhgwCxVKxyJ1W2DrCfhYIFRpHoXoC2KgHl 46oprcoTNFiSmAlTjBH9xhsfaNuac8MmHi9LPa9I8PCR56/jgG4Do5hSS+OlytixDKJ7 l8Iw== X-Gm-Message-State: AOJu0YwG0ypGYhTFycj2xT+r6mAf85PxTHjcJA6pbLchSz4bC5rZy13k edXUV2SDNNCB6yM1zRSRTS905kBD4iafcBmtp5d2hggWII4sy1HbYnEUZf3h3pGRRMw= X-Gm-Gg: ASbGncuMAd4xgM2W+qAKM4/Wd5q7gIsGuLKCXn8yOwg4Jj4s1d+bm8r7u8/EgepqPs0 IOCuByZcR27BmLw4maoocAQ4Gjm4IZIP/4BwXeDeWAVNVajNChSSBWxnWM7B55sUoLZ436lmXyd wVbLDYkbagnpWOZNB/XhPN8Xj7a5xxiLu3UlRzISOaX+xla9Em8L1dbtbQjk1Y6YTjWlzQmLO0N /yyU3ZzZ8uMukbVrsS304RoW1rGw6eSJ987kUYYPH4bT7ELw3iq9JiYjIZqGxxmj1YcyuGfyVwI JMAfW0fi7jssRoTZ+v5Umn5rsLXczfdzNFM1ljNFuP9RJ2KU0Z54y0V3+z7QRRDs56fM90yrmgH y4HTefHeJatZCCrj7h/QuR8OK64Qrsj+HxDNQvFOGTqB/cDVMfOOPTFp4hK2c X-Google-Smtp-Source: AGHT+IEvVJCpB1MRFgEyQoHhDJU3qcuvnYQYpEAAmmKNlgqJfObCwFZIxiKKPOjmlp65QpOlOzuVxw== X-Received: by 2002:a05:6000:b88:b0:3e7:5f26:f1d4 with SMTP id ffacd0b85a97d-3e75f26f5a4mr763480f8f.4.1757583808018; Thu, 11 Sep 2025 02:43:28 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:27 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:12 +0200 Subject: [PATCH v2 01/13] memory: tegra124-emc: Simplify return of emc_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-1-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1374; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=LQehtAx2kmaY57h5u012j/ttcRk/Yy2y8c0kuDacy/Q=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpmyBpG/amnIUnmiIQAQJ6yjT1bf6cHeegd+F MVQof7FXTSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZsgAKCRDBN2bmhouD 150lD/9bg+z24kDozvRzCdyxq7TeVnHoBKzlv01ObNT7OaKniUoT4DnrpBmddv0Tjs7vf9HZF7p f2t//1VsXSVzVEZ/1Dsfe1ug/9/fZSWI4qq88yqxDIfN3hOqj+vLQFSfs1lMJqFL1lmQOzglY8Z UmDobTyKBwP5JZJKPblbeLzJ5RKm+n9a3drhgNJUo2Pc/JI02K6eUubyNDp24Bz5JeOA79LAVfy A1IZcrlSoc/ZBIV3cwNpaeHp9MRY4qCW3If7RXU4niLN5vZNYX4GJoFfhLHPxy2I9RKMPvdMhg/ dPUJkHQttAStUYwAXCm139BgJQ73QGhe7PBTUkEfFxK1TpK5IK3rIpO+j5UgPbZ5iK6lxnw8GMU +Y5tVnrlZ9D1nAkwVmdvDvEvk47YUP0bQcFHXW6T//iJdUKyty3g860stoA9RnSEML6a2nhhg2e /m2H139QbqjsIEspk2yFbTg3mKQp/zC3DqqDtziYzYv5SLb0qg1oQFeap+DZaYdcIWtlBZ2XWmJ 63gp3A6+UFtXqxXhPDxpedQgXZu1528pYo05FO0Jah/iqHOgrkUvMZwrNxRFtlA3YyPmS1GjLE8 /QnC9lYaPY/47onxbmti5SfeWOAE+CzRm7Hs9ljoiZyXaVyfe0uTGizcb1kmTg24Rb14ladzqXQ Ncfe9OlXrdraCfg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B emc_init() returns always success, so just drop return valye to simplify it. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra124-emc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index 03f1daa2d132a81d28705ec7c62d640d7d25a894..9aad02901613f1b2ed855c11bcd= 76fef153034af 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -896,7 +896,7 @@ static void emc_read_current_timing(struct tegra_emc *e= mc, timing->emc_mode_reset =3D 0; } =20 -static int emc_init(struct tegra_emc *emc) +static void emc_init(struct tegra_emc *emc) { emc->dram_type =3D readl(emc->regs + EMC_FBIO_CFG5); =20 @@ -913,8 +913,6 @@ static int emc_init(struct tegra_emc *emc) emc->dram_num =3D tegra_mc_get_emem_device_count(emc->mc); =20 emc_read_current_timing(emc, &emc->last_timing); - - return 0; } =20 static int load_one_timing_from_dt(struct tegra_emc *emc, @@ -1472,11 +1470,7 @@ static int tegra_emc_probe(struct platform_device *p= dev) ram_code); } =20 - err =3D emc_init(emc); - if (err) { - dev_err(&pdev->dev, "EMC initialization failed: %d\n", err); - return err; - } + emc_init(emc); =20 platform_set_drvdata(pdev, emc); =20 --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C3F2EAB72 for ; Thu, 11 Sep 2025 09:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583812; cv=none; b=mdAxU47glED7HVtcadchjtmA5IpVx28wlfOq8gy68QbS1PzHZX0JqidNAhcO8tZ/YX75fEButtSj6IhtmvhKpPKsbrvZoRrm5wHeZ5cv2wQTRzJYyH3e0N/LwTnWrAK7kdI8xjKDMdA1isvjbHQhcVGiGPNMdh6MQgUjfAlvGw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583812; c=relaxed/simple; bh=+1ac3GUtdyb/dGqR8+GvO4DnEY81F76aKbH4bVPkyxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kIjC+yT+G1jG2+BMZ7RnAjPgGZ1etmecvOw2O83VYIVZbUJjVlx5MunSA/fCiWdmiq5/R5H50KvE1Kyorv0SCJ5oPdElsdErTZqkmSDt5j4T633SXE439KkJHng97a6j5I9t6KtmeA74pYkocLAd8nxs4QquNKn9FWeJ08gFYLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j76i+kiZ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j76i+kiZ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-45dd505ae02so705325e9.1 for ; Thu, 11 Sep 2025 02:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583809; x=1758188609; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WiDSDs3vgPK4naVERjozVRDiMqNnwv/gBegchhROC9Y=; b=j76i+kiZqzpBC1BNt1rQb88tkfU9lL4LEV+j4nvwx0dwqY/h1resxoc76rMoZLjSTr 4+UjzIAhgrG6DhbqqUa2S81H9FwE9LiKygc1XJBqHnjMSTc7tYyuAZ73+vtjXcQ0a4I0 mKgjGB6stbbLUeqtpfolSVAbtc5UaQk4iIYM7QJ+3XkY+cCagOz/1r6Esq1vaH+MKnwO nQIjmixfVJy+pDB/a6V18oN6cX5Wn+5Fq/BmPdE4QEdtuUpxpPpJLvFk4q3QtwcUY6QH Ys1E+lYAZBxnetraY2WBieWHtiaviM1OMUPkgIOZjG0AgHoeO/w32hWPLc7W9PQ/7DLw ftpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583809; x=1758188609; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WiDSDs3vgPK4naVERjozVRDiMqNnwv/gBegchhROC9Y=; b=vm/vk5lcO29p6T9MFbUdlMzSQe3ebKn6wBtx+xtljvkaxjQyeupLfrYnUKU62lHtX4 o08Z2qd1v5ZUbFzaxet4VcdYpDxG1hphu3dGJtp9/YwMGCx4ugLzWnVI19EyfNBPksQm JXIkfUM6w1o4PGKYpSte+JghznF06qB6Z8nULuR28DOZ3IxAaCWLBq2LUZ+/LTCbm1B3 5gY+SgRjAQJniXKZr3hIZvnXH0hb0OGo8aJ/tbrIyQbYHjB6TQzeKk+nF6uxPICncEaa 2us06MPXSQiSM6Xb+3b/tnBIUn7HrTiZe9fk/yp44CXGkEQ6ImSdurqJwNkFE8uRLMej NBPA== X-Gm-Message-State: AOJu0YyhfK//6V0w8/swQ2JncZSzyrDKcZ3dveSSGIO5lIItlNPRCQMT pEdats0nunIN/EA4wkFDti271SFjF7XPSHLdpdc4Rv0NbyLPSKKMtv3sIkdhyAWqISs= X-Gm-Gg: ASbGncvf07K0jk5abJzv1DVRKxcAVfJLJkTL1XJFCoAT/yHRHJsxb7xS0jRYCMPXEoe USub+FTad13+NKLYQKidqcPO97hs2dcQT2tJHoEHMkfFBMVkJ5cNeQWwNO1Sho4dpHRT4QqhlVZ c2t45J7gJ0n/jeuOCyhU6RPuucORmteLeuWP1VtjoOeQxwVmLOmh5JTF9NZmht/8PLhb12T69m4 KaSfl2crJ6Cd9bDgsDiLC8hccniunPbHRGjPCxcWNAGucYIX/0gCNhhJMgc9O1LXfQGebB/KrXS x7I3wgjD2X294/g3rqc6pwA8ZMJ5Rh1EvWCPADBI5PcBjyroS4XPK+ygy5UIxue3nKMQ3voHCr8 HbdfMxslLFiz2UaTLm+E6T405dzmktjSChxspjgKQSPdNyLnkiA== X-Google-Smtp-Source: AGHT+IHS9tYhf091OBztmobdfbj5Fdpeq8uN9LnenYjgCcxAwPpUy6aF+2m0BHN5JBLR2HOO67w8WQ== X-Received: by 2002:a05:600c:430a:b0:45d:e16a:8cf8 with SMTP id 5b1f17b1804b1-45de16a8e06mr53531705e9.8.1757583809243; Thu, 11 Sep 2025 02:43:29 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:28 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:13 +0200 Subject: [PATCH v2 02/13] memory: tegra124-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-2-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1227; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=+1ac3GUtdyb/dGqR8+GvO4DnEY81F76aKbH4bVPkyxo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpmyTvZfpYOtMF52dmosD2C8tgzKBSg7E/br1 JS1uYmsOn2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZsgAKCRDBN2bmhouD 10SRD/9OA1b8omkL0LsNd9stCmk1V1blJAOrM4xI+7jqN8/hi3wDYMp+m9MFbLP5EseD6eEZgKQ eyHqS4ZOfiM1C/MSdE5EyODE7qpSQz/onyYdM/TzbnRBsEmxagb2PiQADiAu+RRfJXGpUX84sKM cWeEPkueaFUa2UlhUZzYRYGEJZyb16Y2QkkMWVXw5p7dLJRKcywnyAkeJj89hwW+YNJUef3+Gq1 5jaueSy63dCk6WxOwSK9MGkF2lrSWVcs6FMyttCe2/rCFnHjav/f4E5+rRi/YsU+pwjJ8B0BPNx ww3jACB9E+0l23fkvIZiOiE5VFFq8Ar7ByvKhkvG7EP6hE5VKRNJvYkpiHb4NJCcsQI5b8vM9cY ycZkTrxb6C3mAso2HTdV2dvwcD0PfIC6w8A4Y87Zsc3Pc3iqHuak90A+0lIJGgykJGltRMQwfTr Xj5hMmw2mpMkqUR8+qbgsZs+etMKqqUcUEJwwG20JdOG6v5k8XNzFtac3la0WUysSDGnKSby5E6 EG9OdfwT9W6pMqdZ2Ukdb6pbBRyoTqhJV1goiLgJOgBmoDiyQQQtpII1Tpu5eEfS21UnzQCo1w0 L9rifFeKp2OE0a1S0AjBcp6lNMXQVTAJXPj0Mdmx0by5gKnPCGZkVBU/L/6BOPhADTvr6Vdtecz tuBvxkdbSn7bHIA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra124-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index 9aad02901613f1b2ed855c11bcd76fef153034af..f3372bd78ce8db666015a7844cb= a4e6aad79e61c 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -1350,10 +1350,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1381,7 +1379,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2223B2EB5B8 for ; Thu, 11 Sep 2025 09:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583813; cv=none; b=NxWRE9N43HR2bdUP0HGCU22kN2n3JG5Sasy+v+tNnp7s+JiWHx/J1yHd++i7GwSybDB9qg9fHwYAgW4ArumDQC+mgejpTYVUeUIYs2Y+XdxvwpsQBTuUI6R5EbA7gywiRyq4E0ymn6kx1e/BURfncmpHumkbOhHJrfEhhW6I9UA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583813; c=relaxed/simple; bh=oEubvqZI2n3V9FuebymqRYT9aJaRR3Y7ftHMN9o4xTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7ZzfsPW2m3y76oivnf+Zg1hFybvhh12gwt22o+IzQSrCQRNuY8Jrf78nUg+Mu+XWUcY/XaCoBODRnN9YUQS4iZimgJBlTtXUO9lKTCt4T10lJgQjsvFLdlPYGPnL9mn1kMJP1JIeEUIyGRHbPHnE9/Ba+354e09c8toxpMvcrs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ikz42SOw; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ikz42SOw" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45e05ff0c86so344105e9.2 for ; Thu, 11 Sep 2025 02:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583810; x=1758188610; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=65ye4XkCH8izeRtH/tdAUKF+n65DyQp+SjhteFd0SJM=; b=ikz42SOwIIQC0yKbQwWgdrEEcrUcebhQxXPHiEB4EXPkxd4y6hOg6RYZSp/pwWx7OP HXQ/bHEJzm3WZxRGxCThKeXLKa6peURjYDUtVBECBTPRj60866bIAhsnOpG3iOd1yHJj HyEkHjqzcHOuJ4kI/HKrg9N/D2pevHbrde+cjrvEEdwm6feiXIjKskMMJlQA/8mVgtEM gzM5nT215A3D49Of4Jp2CWhe0xK2Q+ksBNuz+9YBBWmaTZikWvL9R82s0NPkc/4Ztoal ZW8mUSOXtmUlUTlY4Bt+iJp/W8DiZiRcufUqwB1yfnYpC786I/bJCoMpQyvywaNvzJ5j u//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583810; x=1758188610; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=65ye4XkCH8izeRtH/tdAUKF+n65DyQp+SjhteFd0SJM=; b=oBsszaJT1tsKD/vOPm5B8hoJWbGyqF1FhY4RlSIlCEQB6JLiq8MmaxYF9qWD6DD4hq YMp+sktVRtcuN0mLRxrKeIPdLVK/ATYnBMA5UnCoqI5oFTNex6Kc+84Gcj4YD2dlN4Pt ImsALrG9aFISix/F10Jp08XFHf4sk/c2QCOmpgYBLy9qRmQzWS+Hfvkv2IJwxVg9eqK0 YdoKY2yrPgsBxFHr7Nt33/ls2P2o0kxEynDAowKNYhnaRTRjL6IXUHpsq7r+L7UFZEtw uv9SVmS5KBb3WvommiXLWlkPJTwy/TFm+R8XPuhsSM61NDz+WcDoP1NCKOryJvmC3yG8 4LOQ== X-Gm-Message-State: AOJu0Yw68ZllUDaBzTmQ/3OKoE2qqu2mrA661waMSLoUlSButuc74jNK Q4ZRBVY6PcRLgOjVcfxnxThzyin8ysKXlHmj85y+nbWVJVwaxXl9H/GlAKteeO3bqNc= X-Gm-Gg: ASbGncsG6NJEx61Gs393lbmfQv2CKs3NoJuh2XYLUC/o6cvREXNon/Ceo/ujNe6aKSv ZunRm3h1kLsHMo2ndt+cjy0OONS/0yt2CtTCmfkkiZGj4WLdLSlIhpdXs3aiBfXYzLGfFa1a583 Y9UVZbOammvJWmqcEQFxSbXECiaJO+hviZXVaCHk9Q+u1VmnWJ3MfjQ9F9CkehaxmfBErzc1zHM 3sLlq72MdUu5sqTHcldJ+vObSqsSsGmAeBkSTFyQ/F2z0xxkQ4tHscNHMSVEOsxuG87A2hodfzh 2951EeNTEayBltOVToGigahgRxO7n1oTSWZw3uWE6NF7SOEz4NlSsP0tj4v7PDgTlUjuwbThBah RsM1p3Ye6wAXEK54Hnm/7ARs1+GNRgiCtgUvTyGyESGxtzFbThg== X-Google-Smtp-Source: AGHT+IFxRjg9v81uuQcKgJCjKcjEAv0xsM9sp4SmD5WV8eob4iRgRmj1/g3CrehTKJs6CiX8Y1qZsA== X-Received: by 2002:a05:600c:3508:b0:45d:ec41:e0d2 with SMTP id 5b1f17b1804b1-45ded9275a2mr42385585e9.3.1757583810410; Thu, 11 Sep 2025 02:43:30 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:29 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:14 +0200 Subject: [PATCH v2 03/13] memory: tegra186-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-3-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1229; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=oEubvqZI2n3V9FuebymqRYT9aJaRR3Y7ftHMN9o4xTM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpmzCfQwakqbrLKcSYcAFISPKrzFONKXF4Njj ePXILqcC6eJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZswAKCRDBN2bmhouD 12xKD/9hZV01mI7q0n2e0xRk06eXW9N4OPyG9owp/9bT/kwAnwmDRcqneVbww+q4jvJYmbsOdni 3q7b+9wLhDLrQtoEjljXFwt1HDjfAT0njGbKrJgk0SJfWcFHuTyTq/q92WtaQOoSth5MmiJyeiH sIMAtHO/aTVXxUS5Zf3wDrvzbVJZEYOPc99ae7WliHQk7Pr9S1n2+L77hWnVzIfP7Fc5MhAqlse 0AGbwous3Yd5fRQobeD6iqL3Gdi9M/TE8qjxRH9QqJcYg+8U3c6uTEKmUr+4IWEs65rVeU6sXJ8 Lf83hpskL6GS1pAuT4+AIDJU6JUFMamgCW9FgeH077Qxf5X6FwdKKJ5vgwaf35z2SGMwFnOlNJv VNUkrWYuyS7rXV45Qg9bpOumQG+54o8yES2uanEM2XW4T6lcxlxIccwYSbT0/ZK+0ILpMaKnz8A SuyvleV7K41Pr83MjaPiKevpnyc2W1NnvLQM5XncrVArHRAyh+QXWpQE4yeoEcwTGvkc8pl8qQw eSMJvnA1iYWJdyuAWgYBzSVHbbgEtiaTVMLoi/JxpPydTIWGnaViRn2DLAMbmJgfD7o3TaxLJ+K H9j8qJfxJNtaFdTJcdm61EUaVyxJjwEgl6r6GALykIhLL8MBZhmZkEpojGnLUOOywalwgRZLIV8 poyv0y7OWjVc0tw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra186-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index d6cd90c7ad5380a9ff9052a60f62c9bcc4fdac5f..00baa7ab89214b1a151ab0c0a9a= b76f90f922478 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -273,10 +273,8 @@ static int tegra_emc_interconnect_init(struct tegra186= _emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -304,7 +302,6 @@ static int tegra_emc_interconnect_init(struct tegra186_= emc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478062EB869 for ; Thu, 11 Sep 2025 09:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583815; cv=none; b=dLFWiDqbpKtpiLxlkTFGF13/YAqV9vBSNdw6P7b24I8yv8lQj9tnroT1Puw4INo6hscrtjtJfytCT/OEpyHMkxtYj1s91xbJBL9vicw0oh4mKb/QaY2/vwvzRimx6+u2mDrK5Nu/ABRmjdZGZkB+p3f7mUP7Lz6Q+fvtkbFIqy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583815; c=relaxed/simple; bh=cFuDo5Z2uP1vNw3Fz9+yS4AQ1ai8HrNLm9qBQebCrJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p4f0P6/Mdh7/NNbU52H56cwO7o7sZvNka5VtoMxFKmfOAaZmLNRQxxqX2qIA0MR7TAEsM/WEy9HJF0KF+GzIZbfOYr7M6n4o8bLiJ0qi4BbpvAwV/QUGW7J7pXYT3LUjsqLs7Nr3WqqA26BvrRAQ55brzs7Q41yxnBBR9SVo7Fg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=icRsZ7Ty; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="icRsZ7Ty" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3e35d87f961so80822f8f.1 for ; Thu, 11 Sep 2025 02:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583811; x=1758188611; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZV4GDPvDgh6nloAqz+zBTonlpmiF4OqD5ra6XGnPRtI=; b=icRsZ7Tywg4DHrqE2CMVaIIliy1uN13NdpCs7HE4043f7SvRfcZ3Lsbtxe5nbz+u4N fprnk/eWYh8RMUsT66im6dK4tIVIS+c4t65KJm3GIs5BYqhOB/C/wPclZcIK0R3oeF+O l+MW0e5nrjH/M32NzW97Bg0vujgCfHyb37WQWTUKNfjzLU40qGmTJ1KItdY0Hj+u2QzN mbHzP465q9cgIBfnIdxHhOh2HzCs/IUx1Ht+3NQisLbL5VZdnwacHyj43so7QKlZnxHw pUMU3ywTSFieHFck/sinD9lLGILAxDjW17k1Bi50Guesu3kekm7EJwl1M8j3wMe+jNwR K0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583811; x=1758188611; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZV4GDPvDgh6nloAqz+zBTonlpmiF4OqD5ra6XGnPRtI=; b=IJVtRhkT4QZIeE4Lt8WgAb0s1PEg7XeTJkKCbcatOCyO3zC64RQPd+h0Q75hY6+WG0 VrNrzDcppmljhIqtzwigyscomIdvB48BI3WvmTqo3wWujt99PwyWExt0+LToQVcx3/US I4W6uBQZnqfYSGr3+I2E/d7qQCOzN2LowyqNJkDUMG0S0/2KwkHFGL2pc6Qi1wKTjrIW HxkFFD1dKCXNGBvU5vIEplaN84MbAzBbXkRObdmZU3iju7x4370fPb8ASEq5kJsSdRfu +MhCTtZfudJ6haim2gQEHDXeigJT96DPhj4mNzEGsm4SqG7GgpnUpQXFUprmR9O1F6fc HHpg== X-Gm-Message-State: AOJu0Ywp5OOogzGdTEqpPIMRlyRggyLoYNEMeM6FH+sYSjIEPxQcJN6e /F5xQrM4qOakzK83wycdH7PWtIIdu8F4IEd2/iFk56aRdE9hbZUYYOLPCZIxC/tD5eoTb8snXC/ Xqu9L X-Gm-Gg: ASbGncsEduIjCIqn0b/SGvqoiMsR+xUoWBfHITGtF9a2F3a9n5GSKWWAIJtTYZlBLo+ gkaHHyLUEDOyTRYznf8gM2CMX50zEa+4hidSKxAJxobYIjFwRNr+tc/+6nwTT6t/8r3665gYFtC R5LwJVMbi/JrHXnL9N9asQ2ZEgOcH0lssQNampq0GAy9+BPunJBqCBhy8evhMoZYRtrEigTRRgB 2ffjP27BViV8mUhMox5HFRB74w1GHGqcHL84HO7Sv9mGJqBmdxSFZ8WZC27zhuNCuelrF0/7Lp1 8Xjmvl63WEed1dkURJMJOjslULg1+Si/KLCLaTiLpp3C4k2ivm3YUFhqQDv2xUzWRKU3wP70OGR n/vYWr6xjOLsrWJitu+CVc5fmYA6S9lu4cbCcuco= X-Google-Smtp-Source: AGHT+IH77lDTY1FG+waVIQeOJyVVL9Or9NAxNar8nZmacm66v/uym9jeHrXA1F4tlBZ3X+fRq2nh2Q== X-Received: by 2002:a05:6000:2f87:b0:3d9:9347:b303 with SMTP id ffacd0b85a97d-3e63736d448mr7526749f8f.2.1757583811512; Thu, 11 Sep 2025 02:43:31 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:31 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:15 +0200 Subject: [PATCH v2 04/13] memory: tegra20-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-4-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=cFuDo5Z2uP1vNw3Fz9+yS4AQ1ai8HrNLm9qBQebCrJY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm0yiG9Cj04MQgd2COmd7fb2PCwWZ53WboHb erTOHPEy12JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZtAAKCRDBN2bmhouD 13iLD/4xs7F24EsokEgirdfDDqjkHbCsP1pvzcEHDuqKtBhh9tI0UdQG68DH679lLSyTxjZwjbw 1JTSwBoTjx8mnORC5X6aYD4LxtWs2eughZPa1+ahT0wUfPFhSWzvXIFFRy/1W/Dh8ZVEGFaG05u iqpxaKwmzafZh1OsdZ8cjQeFiNs5nPNRg7nMs8s3vEMaAAxCuXPTo2XkEyNqpq70SY+gMox4eEE XB8wBqlO6+GJbqIz8kEL3Bj8G5l9kj/Fnkes4Va41KeLuOUKDOnQYG+amcqDFWSAnqwc+ot6bxA bBT6Jo9Zx+1/rIWxhAkuchtdMRPdOBjeMs2t7tQdQ3HJS8c3OllDPk7SwlLbn5beSv8Beluhkrq q2ipXGTCmw8H/GkreviP1zJl0d8Mg4oEEgKQ64q+LQKHxCIyzY0OgQ2vROmNakEv1mfsx7hx7vi 5yur8Fc/reChCG5CxqQF1PzYOZczRaWQLtqNYUC/m1SLM00dMjIQzVLlgWw1vTQvRbGfNCM4Rgv SaT+icMtmmfzOw5l3WDq+3WzpWucSvMykxXN3snkBHprG8mdN3swENO+pnFf+g73ZzsvrBA9bda Of0r0SpJAajHUaT9U/E9+e5zDCYVtmi47O3tLUnDEqYxnV5nBwBVwvdY6of3LTqLJj55hWl0+gN 4shsc3mcmwACJkQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra20-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index 44ac55feacd3eef0bd095271bd3dceec60c34bb7..a34636a1c4c55419c323eabfe96= c5f27375df344 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -1022,10 +1022,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1053,7 +1051,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A8C02EA74D for ; Thu, 11 Sep 2025 09:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583816; cv=none; b=lCM6XlMtByl+Zkb9tCJY+ZgZoHxJZ3sUbK6KOp87pSc1p4zzcjwO9HO2fKPRxgRxkqpnx8ACHtSYFcAAn76FrRnUaBEFGcxM8BDJK1M7+SbvgH1lkwEmuWSHEwSZVqKZd1XrVTY2ps+a0sC5wwM7lCu5H9MxF26f3OeU0IjXnQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583816; c=relaxed/simple; bh=56WhvEjp/PteZn0tyO9c/SCroF1xJwxk2BOxQgVeGvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lKy40DNyX58J1OuSVWiM6szd8iwuSgPdHUEnDjXxAkVakjVrotVgiO5FX18NR/d9HhqDRUHCSeJUQMKmZakYgra8Ieh4KPXWLJnn3zYPuVvbsMd9em1lvV8lLKqWxc6I9aa8x3tN8BpWPfhaHq2NV4QSE2wvXxmjXAz9TnzEcU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bt5R3C4N; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bt5R3C4N" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-45dd505ae02so705455e9.1 for ; Thu, 11 Sep 2025 02:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583813; x=1758188613; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3WpkGEUpfxQBkF0AFg2VeVRpKBfctEX+Z1irkwx05L8=; b=bt5R3C4N/krEXlprt3p+xl409XPbHQTiFkjxok0unzjv8pQ+zTFV/bIq+abB+IW2FY 6ASEIjKwf1B94yQOhpmIVGkTP9cgD8z+0A2kHGl5sYeRHWJlHC6XJoZIdSu5U8kWdpoc IuGBbhwQxQ+LwiKhWtYQofMES5++yYld0GdQLZnVUGf2ky0Eua8VhQ9elaR8k2s/9yGz NrH4aLYQVp32ntcWGOVEq7dAy/ARup63fWc9UNKaGgYBjQPghgWDioeCa+N282r4EtXY xdmnEPG/MlAbdPB/1TlrU7znbDjQu7loxl9161c100S+7x8RM2ihkUX+kmzYM6Sg3Wov 9H/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583813; x=1758188613; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3WpkGEUpfxQBkF0AFg2VeVRpKBfctEX+Z1irkwx05L8=; b=M7mqTae8THS8sI7aAx6OH3CPXANEDgUbbvMflBfvOeF8NUl75ORZxA0hyt4Iac1dS3 T8cHpA+oFKBi1lwerbjiHf7ZT9h/LD6UKsMdIJ4smvdX/012nu9MOIp/alZMXBKg/Fmf 2+5jf534ZbhhkTUBib69YnlzlXXl1FwrmxcHAzANwXO143JSUN1WVouQBTe0qjOvfkFk G8/RP+grpzgfpksfww58tO+uq7OIXTsZgP7QMWWzaiwlsUDaC4BAKftgehDf00NcEu3d bllRkripbJcPz2+12z/H8zP/raCbwUHXo7PsqYgJ3nQpOtCATfDHK1nbu6TflFnn1K39 Ez1Q== X-Gm-Message-State: AOJu0YyYxMIEuifwfhXDxUysn2XIO1rFxfTCA/ngxV0ytB7hdraG9RaH 8SPY/rJjLR3aVS4qNSiK1PkHgfau3d88V8h0kFBtwtGHRgKNqhXdbsI5WtQu4xEsTdw= X-Gm-Gg: ASbGncszbs5jm9N41KdOEoLs2G6+OgPhLwWyr0u8ujRZvQH6Om/w1IruNfVEJKjuFA0 JLxBAy/nMI+bQbfmV62l6xaqNSPsYoM4TScUJIzqFvwkjGENrKMogHexHodiyIopmbXxA5BD3z8 UWaNW5zcrlzGjR36ZIHS+fq9iMkzTLMk6F8NZdrwjH2fRm2QooopiXXeIW49Q9ek5vA6VDekVmR oWizSIFXm7YjV3XUZDThh/cAe5tz41wezrQFV5OfA1Ik+bzpKl8KJVGLvaNDJI/Cq4xXmVwRti4 B8kERKBGf4iZZEOCobhn0Me0jZsxavMvltH+XKz+cxXzJdS5yCxaO2gf2Bpar8KmZrkTKarderp g7SsfO7mVyisvwUKS+oixxcJObmDvwm7YH67EeJc= X-Google-Smtp-Source: AGHT+IGOi8yePNpjL9Di2sL2vnUH2TM8QtjY6K907W0jyRKbUhHFCvXr5nWkzRUEpbuxYpHNK796lQ== X-Received: by 2002:a05:600c:3508:b0:45d:ec41:e0d2 with SMTP id 5b1f17b1804b1-45ded9275a2mr42386125e9.3.1757583812634; Thu, 11 Sep 2025 02:43:32 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:32 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:16 +0200 Subject: [PATCH v2 05/13] memory: tegra30-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-5-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=56WhvEjp/PteZn0tyO9c/SCroF1xJwxk2BOxQgVeGvo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm1xGat8rkZCvILMqUYbZN3jt3PPw6hxPAdh THBB4Skd8mJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZtQAKCRDBN2bmhouD 1z1sEACZH4T1RNX6pSPNQRXKPTNegmtWwifR0vG5bf/r8FnbJ0aZzbDlYHhXhk0GDlP8YrVDiKz dA51H3u/TRAaOWIMEQAXVVEbOOuwPwDYzpIw/TUawL3xT8pvO/NjwKvO4CkBAZMy2OGbSYaZUyc ICG2I5hG3f7f8MwGtkt6ndD0A2EHcPSt6BOEyTgu975w9jQrHLzKQrwy2lOYtlEJYhLJ4eFPQ7I J1e2g3/efiL0FNZcRHmX9akTZGR3cAE1h9fuea/1uah2fpRl11kHF0JVV9rXodfWG3D4yWdBFkQ /iA+IrIAm7U0rM7SEykgTpb7bTpvTPabITxGxQD6UyPzR2CTXwKY0umkhyRFJ+3PCwNY8MvBBTx wjtTjk8W7/M9Bra8bSMmHaz6QvyKEoP16cRVA7klBrrTs9QBP2hLGDeZ5413Sj1+g+EfVnP6uYF aTq7tTKDTMICV/Ks1XdlOTkVqGCaDgJVxGQi6yUmpg2BvUbqm49+3mXojxTqv5jwt7qrPBqj0iM /KPg7h/nvvB2lr0no04+2GOxDjegZED3q6IG9xKR4HHJSqEuVY2g+gpwUGi1ScETcNFegbwyRjo rxbyR/pqPV/HMG/wSqMYq+6LNQDtzPAV7dx58sgryXqU/M3M9bFJ7TugjyMLWvRLMLGkgcEQDZy FV6QJn/vu77kGLA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra30-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index 921dce1b8bc6382ea66d70ad0f2a12283316ad90..c96aa63a5aa085a409ae7ec901d= 2a210748f5bcb 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1534,10 +1534,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1565,7 +1563,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7ED2EC0AB for ; Thu, 11 Sep 2025 09:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583817; cv=none; b=rnjFOj60h7iSA7GHOuigCgqBOUpbdyPTGbNi6NdSV/bjvd5AWdcXF/g1r6QLNXCm4r7lj5FITTSoFg/txrTWQFwNIkZg3wIlWN/dQXOA6d6kNh951dAAoN807p69bzQiIx+9+En0VqC5r5mWSni2XZ5iUaG4FTXrFCh8KTGoKaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583817; c=relaxed/simple; bh=9uLbL4CfehXgK0FgR1jl+4z97FyCLswBjlNfgLA3G44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jnJGwPgfghRqHF9OQe1vk3/SPYIk5HECzW8exY4pBh8Rna5b7XoE01h50e7eaX/3LqhkEoULb9VfqhoqZkHQqpRZtl2+IQtQVtrnpQwYIjN7MCYbsvbcF2DvT8KMeZJZBJ1OCqtjszESD/vHQaikH2/hTCMwziEOPiG75OvbEnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tdTOju7G; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tdTOju7G" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45a1b0ce15fso933485e9.3 for ; Thu, 11 Sep 2025 02:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583814; x=1758188614; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cqRItD2bt3js5TTmQrynwO8hQqUf0mH+3ap8vOPgmc0=; b=tdTOju7GIecgXuPKmodd/ZazcvvbehnWM6hZV88ooWbZTHNJwEBUKy6VM9BzhG9MEL k+IFdrL7lwci9Ks/WmDJc0zApCdQl2T0gog+sM+9eOdGlkcTRu4ekz+W3u+1A8W/MVdw XWDdXzJG4iXms+30531xxllCg1uXCzeyCu5HE6yo4SVnjc0bPw4ZGFsHq3Ti3ejqoCd2 OsjjPCEEWFZvEPAfOiQT3oY411L3nq4ut+YVyUhX5bZ4cuPwT50mzLR6zzVpnFZrEjfO PlV3+jRwAw42fDaU+0j0JI7saHI6fwaOIzcaHWIGyl3fJpLJHJpgl5TsseFZWDNLgZVf 4lNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583814; x=1758188614; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqRItD2bt3js5TTmQrynwO8hQqUf0mH+3ap8vOPgmc0=; b=A3d9JGG8TJzyEDLbBkC8Bdf09lSuHp56sF7qeITJ2Smtg6nHAkzY8dH/I39zh05omM vWNl8+qklkOVcLpTN9vTuopZtei5YAhNL+/8FhW/D6xIdMcmtP8fBmrbRppaFYa+LWlH WMYw6uNMk4F7jjgwNb6S5JeKZ4u5jKJ88+psGM0iALFdD5Gk2hqnzq/IY3Xzj8R6TWM/ IDvSOG7/CPEsSnSMvICurF8hEdOcSVtfPvwaqpsvh3S0yDnYFNVJbkec5qG8BF6mYl6G 7Sa1FZ1+Jj4csQSKS/FP0kkOj70FoHM8QLlg8OpXTX2h1MxUcBsv/OMkf9S+J+WDDID2 142w== X-Gm-Message-State: AOJu0Yx6lsWhfNpgiITUfqcxJ0WwaeQwTTBqVVXkkRckNJb8wJA04eC2 iM2Hitl4SeG84ARZQfB0Jpb3wh9hQtIMs1W3BPZ7SPaWSMKuWHsF7OR6r7or4XzRun4= X-Gm-Gg: ASbGncsJYZCaPVelaHBt4yxXD6FjtUig0stL0ywTrKno9ky0K+6bhZj/RQ35urYos8m s7rPIR42Ch5ulNTRAA/3gqWQWa/F6hx7qPw/3DNLIzoCsdcrKmd9ETRAmNHeCmmuoS4OxLRI9dY QS9iD/GxO8NqMzWlBu6D8Ui9cq17NpL5U5HV7A1MtDQhAg3rDKlMbx2dfZj8hywT2s1dj7mUAww qkLmj9WAXkifM2AJ6ekxh8QSjPg9zISYOGg3a9KHRy0DdDHqxwg90Mtzf5nSsPAgJfVlJ4svxJ9 64MXAv26MLyZt7+64GLWat6J1GkGZ/xgX8R0saai8Ax59pCMH+ofS4+js0DE0nhDUbhZkEzamSX LP20bqD7iLVwoUYVIFN2Y9Vaeg77LpZD/W4fUJxXfdjZGJky3/w== X-Google-Smtp-Source: AGHT+IF/UhrqWprkaN640qed/DfCGwg7Vw72qdq8PFaV5rt/q6nx97cRxngQECQXshfiBlN0JgRgdQ== X-Received: by 2002:a05:600c:1993:b0:45d:da49:c475 with SMTP id 5b1f17b1804b1-45ddde0a13cmr81741435e9.0.1757583813832; Thu, 11 Sep 2025 02:43:33 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:33 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:17 +0200 Subject: [PATCH v2 06/13] memory: tegra30-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-6-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2183; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=9uLbL4CfehXgK0FgR1jl+4z97FyCLswBjlNfgLA3G44=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm24oqvTHVAOF9Rq8i0mjZwTtnJuKFFxYt2j opJqGjF5B+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZtgAKCRDBN2bmhouD 1+woEACLJwCCvryDUj6nedFa7ciRAt6z6uMVkga16E5DH6vokdSkj3K86WCISjS03oAvZp/5a9f Ap0GaKgfndRG95e2VKczvWjGEO8dZdvYtOsammc3FveGGjIGsYfnEKYbM3TNRhfmERsUOvKmuWU VKX6OhUzm7xLG6jI8XaMAsd26YkO8O0UN3I1N7BN2aXAww5G4NZM1f2FO4sh84jwbqdS87++/Ps AxlpDqfcCurrriA3E4lTXS5vvZALjejUkCrOkO0nJQbTeqoF/PPtTg2gP5yeigoaFIwh9vP0A/Q /2IFKwJj8R9VDU3Ge0WF4dG/oxk5gtDqQctP6Qlem6cMN8OLUAS5+t7QwqM4gDZGaE3eZrapRYq HkWWuxhRlZH9lkla2J4xXTPY75Q6kd16mVP4PGwPBTILzlBsr6VjSjAIhHgPkjlRzcl/SyTqELd rzLL9fwRDMTGr/PsQWfmgzvm2YjVcZGJG4c+0a5rBecKAWQ54IZSeDRvKhfNUwwAEuT3eJ0gqnS igyDVhYPTaAlxU3hwIK7YcLNIXBmz8Kk/s7+ijo5xI7S3NdkAFKZB8bGn1eznbQPfjkfNH8KjdX YfF2TpqFp8yDhFvyPqPU0Tx/3pQmkkgCwnMBxlrFa3afHU4gJkUf9gaDQSdHckwr6uQPvifODBz x4JgGde4f959Wng== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra30-emc.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index c96aa63a5aa085a409ae7ec901d2a210748f5bcb..cca386af423e9647266878ce6cd= 1bcec09c8eba4 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1563,9 +1563,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static void devm_tegra_emc_unset_callback(void *data) @@ -1592,16 +1591,13 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return err; =20 emc->clk =3D devm_clk_get(emc->dev, NULL); - if (IS_ERR(emc->clk)) { - dev_err(emc->dev, "failed to get EMC clock: %pe\n", emc->clk); - return PTR_ERR(emc->clk); - } + if (IS_ERR(emc->clk)) + return dev_err_probe(emc->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D clk_notifier_register(emc->clk, &emc->clk_nb); - if (err) { - dev_err(emc->dev, "failed to register clk notifier: %d\n", err); - return err; - } + if (err) + return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unreg_clk_notifier, emc); @@ -1654,10 +1650,8 @@ static int tegra_emc_probe(struct platform_device *p= dev) =20 err =3D devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, dev_name(&pdev->dev), emc); - if (err) { - dev_err(&pdev->dev, "failed to request irq: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, "failed to request irq\n"); =20 err =3D tegra_emc_init_clk(emc); if (err) --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51142ECE8C for ; Thu, 11 Sep 2025 09:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583818; cv=none; b=O52x+jXUodv+5mceil8IhN8U1F2Q16fnXzuAC+BIELV1YOx44i37yxHDnQYdC9A0yNaLQCHNJFY5l77UjeCsABcH/qOBIGlszxCgWNZWtfM+4PA/+xLCQ6Z3MyIBqtP9rpM5/foLI/aUtS1fHUoXdBMNInE84wNSIiONf0Y51/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583818; c=relaxed/simple; bh=M1UcDlfXbj/5vPqirllwe6Mt+pNopstDQ9HKCl8tOeY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iLn9GQ5J6FUJkvntrDXhfdT+LpVWhxZlJNDWSVyG3uqoodjDbZzDrndUkF3fML+K6PmmhBYR0mo995NGqZOMOEnCu/39xNvCXYFQQlqlv6bblMOYgEyoHIzwKmnTutX7XKKKMwjAQVxHC/3lkjln/3fjVxsMM9eBw+Y+758hcm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CbmG3QRR; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CbmG3QRR" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45dec4289f0so166925e9.3 for ; Thu, 11 Sep 2025 02:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583815; x=1758188615; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BnBsMIetOHLgxvRafB9XZsD33miPY9fW8C/xMa98MG0=; b=CbmG3QRR9WJ5BKhZ4LzQ+u0NfeA964oyXNVJwhav6jELOKUT0GMYtaOhSOj/ergmpc 5hbaiVIPeSNfJAZeBVzfUkyo3vaXz+PRxKhyEro+uTFYa13vbYCR9LygSIu2c60e5l98 dv7GMGRksRwB6RPlmriYxaUVB0vKLRRFaTt0wd5Y7hiFlIdvn5zCecvaUx0DdIDFRqfP 7Wq4z9dmCj1mJbwo3GqfyESuem1u4YvxdozPvr2EY452Ak5TkS+089VJv5cPNMj182O8 xL1L4jBCOXfA3PW25nqEa0/6FYZ4fqCKAcG7enHSjcraKYuubPRrLSRPsXOcPOGtv4m0 zNUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583815; x=1758188615; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BnBsMIetOHLgxvRafB9XZsD33miPY9fW8C/xMa98MG0=; b=KGTmqILwNdDtWVQGA9cTfAd9dfymaQZgRaNEIaR75TKZku2CzGzv2gUu/1jq7/JEsM B/hVMBMQ2+AHxOGJRbn2a673ItxiXmoHI+UppT0gMKireM2CETZA0rc63ieOpi7QDdQH 2ZltCFcnIbDZICndh/B2540Np+73VlYqJ+5bpv4w9aPJN2xlm50MW+7Y/6skwwmDtHmO vRNpNCm58r28NNg1A8R/GBJmrDxpJzSVjB4USOSMRWQpirbTbmR9V0ucHTV95ojMDlPD c7u4w8KMYITTucB1fzLCcMsqrs1ElOB74kPb28D71Sh1NmMc98bsKJ6Pro29spjJYyf2 Pdqw== X-Gm-Message-State: AOJu0YxUBaIIrH9DOtVjXgSoeilMXP192c6Gh8idiA8PycRK4/+djIaw IPitcacHKinHAEXTizb91vglr5u/3epcM0guhIcUhs2EhXvNAN2mXScPgTYFTqNNksE= X-Gm-Gg: ASbGncu9nSKKsPWBjcKqh8rA2EwkHfFzy7IDcjl+wQNbUU6FtfXp/ucTT6HADZahyrY 42jsY9fqOfsW2eRCATmhrJcInfcZ4B3lHZfYljvrOg/zMLsy3gwsloVJMm6YEA/qoDdbFLgt69h EyakzS59LqCE39iHHAbzxFz7RtupblCzTdVG+uAn8JK7XiHs/jMObgTluOXH6T3U5Sl/rgZVc2e KGdVMGYB0RQEdzZLQwdYJDwMQA0zKGtepwrr18pg3sr6P66rojwYC9ZQwrvbGgzB7EgivIHyfqs r+UWKqCzwYcz88Jk/oWtoji/MhvwjlTWna+jNVtXI7LPE7gPkVzvqwXF/cYOG9tA8G1CNTMLAAX fvpeBclaes3CDa+ZLiO4c1tVWGggpVO7aC+OUxtA= X-Google-Smtp-Source: AGHT+IHEMiH++JoRVvHy1y1PZidVKgVZFCcnyZuOWsGWb4yjXBnZ7oLGJoZr0iasMERrGw7+95wwXg== X-Received: by 2002:a05:600c:1c0c:b0:45c:b659:6fd8 with SMTP id 5b1f17b1804b1-45e04660032mr7225905e9.3.1757583815068; Thu, 11 Sep 2025 02:43:35 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:34 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:18 +0200 Subject: [PATCH v2 07/13] memory: tegra20-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-7-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2340; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=M1UcDlfXbj/5vPqirllwe6Mt+pNopstDQ9HKCl8tOeY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm3l72Ukn3gSEbqLzDsJLPtuC+VvBTPRiSsL 7Imq6KeqO+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZtwAKCRDBN2bmhouD 18tlD/4ud8ibDbzpWdsBXFKTq4bK68MZ6ZdwnmDEBa8V1W1zMtqOpOmj2Z5D7OkWSMdYoU6gZOi JV0WDGq2YoFPoXngdUhrR7P3RXf6akwUTdfpjSB/huEnnLGD3WEIFyrBZ+kDkSah/Vz6zjh2C5E 59XtqWvZV9Qaj2gzbxp/9X1zl4SUTDv6FbMTqpCoiQq2anNgNgu+z5z02dkrNgMm01IanhWVbcN 5bNpT7hZ2xnLVSsMCF/kUU19QorVcODmTd/XqKRDjvySUg7Aik6GrpC6FrStsXy8JkQjpcQpcUi VcXx6fkPFgbrW8ggSffF7CR+tdItKgKRfpG6hrYBKWRLJnbud/JlltSu0Bs3drRe4Z4cOrZ2Rjj H1+cswNgYV37JrrhKCumJNmg8+Qx3KgfVrbE3FbEcFmJu6KqQ70dWUeJYzf4Hv1doRrT0ky868o HQV4zg3GhDqeY3gFzDI9Xk7X5aj5IHz3TYnLG0lqY2zk8pdkLcdqGsboTAIi2KkQOon0JNR1GEX nf58nPhwWIou6Pjnl2+11YaG6xEloZvuF00XbMy/trlT6PSEL7WImk0LvZulM04z6bRPaV55/rp t/GIbstDngLsYNjRDD3SLtHOL4g76o3bAbMtk9JtJJ2jG5nPzFuWKzQ3iky6xjXpAHnpgAHNKzR IigbD9IwF1fbegw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Also fix missing new line in error message of devm_devfreq_add_device(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra20-emc.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index a34636a1c4c55419c323eabfe96c5f27375df344..18e266dde5d2a0fb962fadc0416= 1b03fb79f76cb 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -1051,9 +1051,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static void devm_tegra_emc_unset_callback(void *data) @@ -1080,16 +1079,13 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return err; =20 emc->clk =3D devm_clk_get(emc->dev, NULL); - if (IS_ERR(emc->clk)) { - dev_err(emc->dev, "failed to get EMC clock: %pe\n", emc->clk); - return PTR_ERR(emc->clk); - } + if (IS_ERR(emc->clk)) + return dev_err_probe(emc->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D clk_notifier_register(emc->clk, &emc->clk_nb); - if (err) { - dev_err(emc->dev, "failed to register clk notifier: %d\n", err); - return err; - } + if (err) + return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unreg_clk_notifier, emc); @@ -1172,10 +1168,9 @@ static int tegra_emc_devfreq_init(struct tegra_emc *= emc) devfreq =3D devm_devfreq_add_device(emc->dev, &tegra_emc_devfreq_profile, DEVFREQ_GOV_SIMPLE_ONDEMAND, &emc->ondemand_data); - if (IS_ERR(devfreq)) { - dev_err(emc->dev, "failed to initialize devfreq: %pe", devfreq); - return PTR_ERR(devfreq); - } + if (IS_ERR(devfreq)) + return dev_err_probe(emc->dev, PTR_ERR(devfreq), + "failed to initialize devfreq\n"); =20 return 0; } --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B452EDD52 for ; Thu, 11 Sep 2025 09:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583819; cv=none; b=fGrPl8KmebrwjwRKCDQLuGbdX/3vBS2WjZfYYIp4r9oj4dT6KgLxK5U1OjIEeHMjRxffKnZl2gusTbqwlG/9pHcD+iDKpfoLU+uV3LDgxbnf4HYbQ2CAsyw3j3uzBay73qzcQY7QiS97B42oIbX8qwQiknHA90uWZbsaP6M4jMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583819; c=relaxed/simple; bh=RkEbb4vtXH/1xa3ZAFyhmneUOFAU8k6zYcos8ICuhT4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q2o2hm+yJRnLbK99LamuQMy4d56pPAhVo6GIqM2esI1bQxqmOd5NQ7y6mEWsm9NWXdxCftKUdNNdtws8rHFgJ3JdsUxDJfUpAYltwPOEJj6ymOzsCXVlwXOgY+PB5xb3s1yr0UY6/MGgTBbBfbECOe6VOxOP7HiW4B3h7z35uic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uni7XEXv; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uni7XEXv" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45cb5c60ed3so463135e9.2 for ; Thu, 11 Sep 2025 02:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583816; x=1758188616; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I5m3ByHgnOeEhXsQQzbVD5zJSTnURIXU/8oB9ElOads=; b=uni7XEXvpezQ0f9yVmHVSHkVoU4tSlBcmiwPur3oOPgfUu0G+E28TwoaSSMqGPoRkg 4ma7e/tA2Bx5tgkNMny6SIeAHmiT27BRKAmASZi4Yjj6dsiVVp0nyuOlOsWQXA2wvH9w P7L5jdQpPpjnGHfVXu3oXzLmzRs+X193/QZYPjJdysLm8I4KrAIvzBxGLkLa2tie+0cE 1K0nVfqDl8+eAENInh9jAuoItcWJ7r5IVC2sPwDdzlVuf0Gpq2GeMSVWZcEJsRChZQr8 00HVuhzZampz8B8F0eIKFXOV+nnB+IJbFxItayyDrFvyLY66ZnP70fzuZdbGdWa+57jM yRJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583816; x=1758188616; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I5m3ByHgnOeEhXsQQzbVD5zJSTnURIXU/8oB9ElOads=; b=Ek7iklwJUxtvip2Xrc4q257mFEJLa45Wi9lDO9hvpRWI/f0vsBEMAfcT1ULqaSuT31 AOJYj2AvIoWpVJ+vFOKx7GpkU2CPduK8HaPz+8KiEtHYp16bzkkysY+rU5hA//2XkMxR +0HO2Gjsaa+Rks/2Mfwi75pUz47E7WaqXTb7e4eXHDWrqJlbSw1Di/OEPTiECXKc0ihl KwXwZV9eGk97MlZDyfVZQW3htgrgj6xHGXONmZhtQW7MzYicAWRv0/0e3zpe+N234NUj rgGNwxX/EmKsY6aPjdTNvgCFeWpRrwFWE0Aajv1lS285NTzb1riC2ho3yMEozsUu8iTc iMkQ== X-Gm-Message-State: AOJu0Yy344JW3Z3nroUBdfpbV9COBG3crpaU2oIiqQg1tIxmXQCcl3iZ 0G1dIFHH7mvFkF2knXPYmIKr5FnAr0SDnUnZ629fr07QVYnNsRWY2aysSscokajSZDw= X-Gm-Gg: ASbGncsSjON+25oEJBbdufdckByqKWwh1/S2w6I8aAlBpk4cpjBWOo47NNbMqIhnKuv 77q14kjb9fLdxcFAPP5dUMHKAtv447MuQsNPqXqMyHjC6jK2We9YRchwKiYeUqMIW5aVEfpl2R4 7+yudj4vdcbkAO6HZ4dhO2CIB405Nr3VNHtXUMdPjAOlFyTxLrPOZbHOOARTMGdczqwsfAw19q8 nZnrjU8yeYS6zlqYmgxuAthoAitlHM8KNdyyZU9tFgpSzW43itverxdR6MAkFrXlOblM72fRtPI RsTsQZyuCNtKzG8GJDIa6bE4IBGgtzKPoYtmDRr2p0pS5UcDLRzY/tYs0BRTIAMO2YEf85oIxUb T86Q5dNuqJ3XraE9Qxy4DEFG0tgA16DuuyXVtKghGcuOmc7xNgg== X-Google-Smtp-Source: AGHT+IGdWCIF1BMNbE6xqBraxyICJw6etdGWZx6LlrGJw3xFOwFuyThGq1KYi3b5AvIEEioeX/sfiQ== X-Received: by 2002:a05:600c:870f:b0:45d:c85f:5030 with SMTP id 5b1f17b1804b1-45dddea1c78mr86161325e9.2.1757583816226; Thu, 11 Sep 2025 02:43:36 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:35 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:19 +0200 Subject: [PATCH v2 08/13] memory: tegra186-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-8-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=RkEbb4vtXH/1xa3ZAFyhmneUOFAU8k6zYcos8ICuhT4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm4Aa1oUYSFXi/sOsTHz4twSK2bs9ZcZMbr6 uho3feukkKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZuAAKCRDBN2bmhouD 18y9D/9R09f1RgS8aqXPAwB5hy/F//5GLx350tJRizHtJ/kE7iuk+2uhHkNeriG3vYgy4fvQ7D4 LmjAjJB2Jq25o/QYP18SgNiNy44O/AChi2GvJX9YU4z+O1ANxod02E/nrmUn2l/d1fZI9hkfWOp YkITq0xOtHRTJ7SgNs1xo5pkoSSQImG5LGtrTtD/uyRLr5tvXEWgLILfarG3nJvEpGCNyBlFhkA UmxWNZqknk0kfLG4vTIP8lYYpK+s/z7tAVMLU+0ng3jp0aWdbiJoLl97iwRaiMe9CSkZbAjEJQS DgAalqcJKKTehusrhtilyTMKXNjH2I+/9dOG3B4e/FeoNy6Q43DbckzvbV0aYE6r9gytL9fx+gd Fdm8SYsuOoVADpS5Ve7SvNYjyIyrEKsncm4LC3p1jfPZrmAD/sg5ys+O6woBGfUs1hdI5jiIt5g nZwuV3tlh/OxFUfqY46kroJkHv6pZuAX55mSp7lOtUYRmMgMEaY7HocODHohsN+Zao/Wd+RRc1w CqIcnSIRZ3tFXLx6fTGfg1D3vM46eSWAgF5ct1z+Ema+CQRVPlTtDjPUwUFrCqJ9HBdozW7sfkU MbnGSbmM0Q9zL1aARXYE9W3bCNumVwxcAR/aHLCH+KfXdXLKpyvGIqovpTUuXd9Xi3/E9OFYefR yshHh3nnHKbKA4w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra186-emc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index 00baa7ab89214b1a151ab0c0a9ab76f90f922478..a0de80afe3e90531fcfb29d2077= 3aed0d04478c5 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -302,9 +302,8 @@ static int tegra_emc_interconnect_init(struct tegra186_= emc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static int tegra186_emc_probe(struct platform_device *pdev) @@ -319,14 +318,13 @@ static int tegra186_emc_probe(struct platform_device = *pdev) =20 emc->bpmp =3D tegra_bpmp_get(&pdev->dev); if (IS_ERR(emc->bpmp)) - return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get BPMP= \n"); + return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), + "failed to get BPMP\n"); =20 emc->clk =3D devm_clk_get(&pdev->dev, "emc"); - if (IS_ERR(emc->clk)) { - err =3D PTR_ERR(emc->clk); - dev_err(&pdev->dev, "failed to get EMC clock: %d\n", err); - goto put_bpmp; - } + if (IS_ERR(emc->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 platform_set_drvdata(pdev, emc); emc->dev =3D &pdev->dev; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088F42EE279 for ; Thu, 11 Sep 2025 09:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583820; cv=none; b=BuuaKvHlDyVEjeOO+bk+4D9QqHdHFlVTTQsI7bxrCNzxvw6wZ6NPw1ni3ucmISpo8XqwYA0itu1qsi+9Y7ZJhc+wgIK5h9beSTMyuYmOzF85vf42hl7IX/PHXKm3yAIHFlcgaIco8By/jDxp3M4g/tirS8m99xdcjDdvF1U467U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583820; c=relaxed/simple; bh=sumypjm5su+//BJZ7zcWLArNigqTGnmSYrUE7kO9jkw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bdYwMRFowzkcogrNz8apsrSxOaP9O6p0fJjB5m4HcEQry06aWELSbWmyCkfwS4XimQXlH80m5w+6kANlYI0WUKl/lrPnGO0KZNveMUDCu+rInPdTeg5OYQY4lhu7Ws4MJtXPiWQEWE3ZCgV5IwpoE1Fcggd0bEiJG+hjO0HmV1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sxHux3c4; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sxHux3c4" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3d9e0a6aa4aso61558f8f.0 for ; Thu, 11 Sep 2025 02:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583817; x=1758188617; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oOK2rQuOJsLR6f1VEysNbCIuj//keNB8l7Qc/i/XdYU=; b=sxHux3c4o3YKLzUnNbpZtpeFTVjGz8B3s+dY7niMITU1gOtvIMQCL/3KQa39CnXYkD Krat7PKCo3jpohAYZD5Qoxy27hIOnP9mWnE+jvKD5JM5kQMbfb1GkWTkWd+Q3A1w49yE /8OXdSdhAtkWPbezxQ4TZ2aZbDg1XYMr23htsbUhGvmjZXgA8k883T3ScosA0Cz8YRmX DNOVEllVOJs/hMeKv9iKVHqs1H3iSgCZINt8PzeU/tneFwLKT0Gz/DLFE17GQg4P+Zuh uQr8FC6v/uRS7Hi4ItAZXNdVlvUpcRC+xasWW4Y41SJKrwNTbpoJ6d7fKt/pNLw04dbB KqjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583817; x=1758188617; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oOK2rQuOJsLR6f1VEysNbCIuj//keNB8l7Qc/i/XdYU=; b=mNPFEj3+2FW9pLZK/zhxKGTsfVSHnY36VQjv692tYzntTIYHcB2kYYfOEOckh+DflW ZkBL2K1yy2mOWxiBE4NbbY2yIqY2Smo2C17NHgY/yPXz9qNd2GG3+vwgZk14IrXJv+YB RCuqXbAquunzDWO0Hce1cpzuzgDKBF44q8LL6eqxwJUj09WXSVb8wGkgIYturnvq1TEM GFPsauUOsOT6gelC+G2P0+5UU7Ik87N1/piwH2y+KknpNKYiehAMxxQ13gu5SGhWP93k 1dD5sTXN/az/o/FCQ6bvbuAJ+lDvuZWiJnuC2EaFZikTbFZdOF8RQtDqlbrrN1ImZb9g xIMA== X-Gm-Message-State: AOJu0YxqAfdDdveS02ZfICeN21Ym6xtq9BYMOSeRmZShILspGmaytEYm OiwwersO8Br7Z8+5zkg+DDIZHt/BmDmY3ofHiD9lupitONx5TJkH3lv6fjn/mB2hfBs= X-Gm-Gg: ASbGncsWpn6IwEN/ONjea6kqGv6vSfFutYDtPbFCYqi9rfNJ27vqEChZvkqmJkZu24i xZKKIXU+dwZF0y2gXqq7Kws1/UsglJkeg7EZS1Td5mt6M3h/eA1ZbJvirVADGeEmnH5OQOxEmeo XBnj9Ep1U5Hp3aaosf5LzSkcfrZoVcw0l9kNkvrw0sLTrq1+QCazaetGRCqCfpAkORM8v4xhO1T XQxekUU8IDb0jtdBkMRpRxQcC/Mj8ZAzr75QqoQpZiVZVarjYn+Rvb/oUsGr5LANtTC7720HVtd jHw+7tHZrrw6KcGKV0UEV9GtmdtMed/FZEjzV0Il9rJ2YEkYDuMa0lEOdDp24/MIQHi4cO+kttK H4JHTK2MqKjf8Ul0lg08EBqUXs9sPqoAc3UeBeds= X-Google-Smtp-Source: AGHT+IFkAwrAZp0H9jBCgjtU096PPs4fGUojk6A9dTh9oIHMsZzNgAkOrY3q9UlVUhF4a29UZ3zC5Q== X-Received: by 2002:a05:600c:34c5:b0:45d:d0a9:18b3 with SMTP id 5b1f17b1804b1-45ddded6bd4mr86496415e9.4.1757583817310; Thu, 11 Sep 2025 02:43:37 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:36 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:20 +0200 Subject: [PATCH v2 09/13] memory: tegra124-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-9-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2718; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=sumypjm5su+//BJZ7zcWLArNigqTGnmSYrUE7kO9jkw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm5zmIUlCl08oxthWj/NRTMFIrk/VS7v9CZA lsRM4+xbDWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZuQAKCRDBN2bmhouD 14ZSD/9mJ4vpTvPjFqTXWclWNCkypobbcRrapFPN84NAmWthC3x9B4m46oqxPKmlJIe22xzKEMn tRoeHvUiogSJ8/3feS01kOtEgmKt5zBqnHpL03afu2bYoVfcSdIF8OGkLyqx5NIFtjpGrEYz96s go50oNXRev3NabD3hWhVZMgkLDO6+2eUQP/THzrDuoBKTuaggmFBxCjDVzUNCtiGJ8B07Q2So5L lFNWs8NsJhnOuf/bvYVWRxTFnYaDY4L2pprB/5ERZBlcPdPzAWLmAWAckKHblZdLf0+e6E6BNeK psP/KTesA5CqLOM2SZSh/1rSZWBpiTB9el9sxjzgUtmI2EQKPJYnw5KFmDjHbJbuzWK8NxmIO0x b+piCBylcm1vo7Ve7azJMuMxxiH9AoTIv+z/09DaUdBYll1W3OX/28w5FpMdf7EQEOkwYd/ACDP N4gFjGSxDiburwOaQ6tjWEDcYA/uJgYP2j+SIOdJZAITpQ5tzmQgTurPEbZS59YpLlTOiGVVf9+ pPOQXUEddOeZpOLA1pQORQtH7YGI4k8iHu9rtVAE/NVkdHUNr4Fw29SfF+2j2cCQTKw51cJktOV JplC3f/Vmxgdixgj3Wq3WRpA7LXIcUchi1h3WnmgjHeBXHG/HSblri6qzAy+LhRzNy7TLru/mPN yqOT3H9hM072yRg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra124-emc.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index f3372bd78ce8db666015a7844cba4e6aad79e61c..f4d703103d9ca155eca92331ee7= 62cecd4e01302 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -1379,9 +1379,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static int tegra_emc_opp_table_init(struct tegra_emc *emc) @@ -1390,18 +1389,18 @@ static int tegra_emc_opp_table_init(struct tegra_em= c *emc) int opp_token, err; =20 err =3D dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1); - if (err < 0) { - dev_err(emc->dev, "failed to set OPP supported HW: %d\n", err); - return err; - } + if (err < 0) + return dev_err_probe(emc->dev, err, "failed to set OPP supported HW\n"); + opp_token =3D err; =20 err =3D dev_pm_opp_of_add_table(emc->dev); if (err) { if (err =3D=3D -ENODEV) - dev_err(emc->dev, "OPP table not found, please update your device tree\= n"); + dev_err_probe(emc->dev, err, + "OPP table not found, please update your device tree\n"); else - dev_err(emc->dev, "failed to add OPP table: %d\n", err); + dev_err_probe(emc->dev, err, "failed to add OPP table\n"); =20 goto put_hw_table; } @@ -1412,7 +1411,7 @@ static int tegra_emc_opp_table_init(struct tegra_emc = *emc) /* first dummy rate-set initializes voltage state */ err =3D dev_pm_opp_set_rate(emc->dev, clk_get_rate(emc->clk)); if (err) { - dev_err(emc->dev, "failed to initialize OPP clock: %d\n", err); + dev_err_probe(emc->dev, err, "failed to initialize OPP clock\n"); goto remove_table; } =20 @@ -1480,11 +1479,9 @@ static int tegra_emc_probe(struct platform_device *p= dev) return err; =20 emc->clk =3D devm_clk_get(&pdev->dev, "emc"); - if (IS_ERR(emc->clk)) { - err =3D PTR_ERR(emc->clk); - dev_err(&pdev->dev, "failed to get EMC clock: %d\n", err); - return err; - } + if (IS_ERR(emc->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D tegra_emc_opp_table_init(emc); if (err) --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E082EB5B1 for ; Thu, 11 Sep 2025 09:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583822; cv=none; b=bDsq5AyZGlTx5ncgc9RGV6YhT8VUaiLk7W+WOB5u86B5umeuSe8eOWs1tsEzqLiEC6msGBuPRbHjA7KdYrJyhpu4UCSHG/9XWFYoZv9Z6KxKVMiPILzYDO3FICIPfowQxUPSMdXBK++6OlcrI5CkBilVzg7XXxFVKacaVXOajp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583822; c=relaxed/simple; bh=NsGEIgGjbOpROhUmLr+vi+i7gGp3+YQdgw+pRaV7CFw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JCkGogzRaG0VSG0mDKHOYIHqthji7xg5/6dlqO0Mtb8bEY11ic2S9IEv3gRNFqGr6/GJYrR9pi/xgFy0ST8KLmNtHJInOV9sQuopBDB1s5cZs5jh1At7b4JdrSrZYJmDIFH8UikX0yfsYQtXIYufONZ79YKmj8RrLl7GjFF4/hE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E0PGyN7X; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E0PGyN7X" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3e761e9c2ffso42461f8f.3 for ; Thu, 11 Sep 2025 02:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583819; x=1758188619; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/EvFDcJgp1O+VKVo0SG7emVdOYaEBH1SQVuBhC1JrkI=; b=E0PGyN7XMv35WszBD3I/ooqbQIQenXIbaEX5m11JFf1ZSuHLDQu4n5RzkmqmqYMV2A ZycXPZk3hW2oR+3/9kuA9CK6p3omzILAzDMjQbFNRW8x2IhYhAbPjbZlE5wa0yQZ2c+a 8ps1vPTHFDqdRh8uzKzZ9ZObYriuFMC29PKyrpHbeYXEyjMoSihl5HsW6cfM/2ePjR1x fJUm4Bbn8xWtu0GJPHZPE0/Ck5dt1MoHW0vWAW9bVdZ5ebahijIMe4SiyOOA17AyOMFm C+50t6f8upxiQvLhMX5/f5xN2F1ZuYrZCKr7KvAPTTfwWUCRA9NtdLvGa8QN/hcdWEos Ddag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583819; x=1758188619; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EvFDcJgp1O+VKVo0SG7emVdOYaEBH1SQVuBhC1JrkI=; b=xTHAGoqdI9pE8OkWN9So+QHsHf8k7ZgyoIycuvcTSi4T1FCOQuQwncwmZFCtTctT2J rsI4Ci8hqU/KDMIZlapIu7Wn5a/JJ4hkaUiG4PM6F4NbfipIQsD2ArNqOrCnQknHPBRr hEXIViGBvnlVcXTt7PT1wXe+sAt7nv9JzjyKK1Jx10cu8mtwtjfDw2zibXw2pdXFVhYa KVtKaBA3NhIg3mSp/MGiSAQ56lL5IWVpaZnUANmP/3Jd3TlTVFTvZSXe6VKvmKZJNsw9 JfL98CpFzz0acxXKtZJeu6q5z4b9hFgEvpywfFNiTxu1XGQ0kLkqZGLnx31bfMcXGbnb FtbA== X-Gm-Message-State: AOJu0YwM8n+zgndN8vP1Bn7cPC5ei54BP8aLUBuTiiNEz/LWwTLcYjF5 vpdvv3ygWZds+iVV7j1JkJukPOwOwLZyT2k3LZq9QS4ONR2OkFrLK0ySeE43aNYUKQE= X-Gm-Gg: ASbGncuGerV+VTesKB+OLhCI4WxthcR0ZJX7PcbLJkPZVLJ+DijGoGNQK7EORitoIWk H4XpLKRg3egLagWTWDhUiIZyUDIP0z1HPwzHs07VO7I7grr43CzK9iM3L814ahpCTJsDJ5BD2J9 Zl15aySKwpZKVohG2N3TTMBfXhgpjtcUHdjvtCw4a1nwzi482DbWCKIxJa3Q7eBqvddGD/HfXmJ YyDB3wRbBwUrP1JydIDEl1M+j3qQMl8f4saUSoeg9CYvQ/uMxeWh1XLJfHPEomFRcZO73llhd3A 66uvZBf1J/AtG93nXMkiP+Pi1RFqxnhAxQyXic17H5APLjRd0fjEgTS1vJ1sdaWerPHzclYpyPZ M0Csgk5xKJVv1FIkkeuogrIFfTaMULbGV1eb/Va0= X-Google-Smtp-Source: AGHT+IFQATZ5uV9m+s4qitY14CNE6n5q3MaFIEeJl26/7kZH/FIZPFZHicuPgJZqEB4MJGjuy6zN4g== X-Received: by 2002:a05:6000:40de:b0:3e7:5f26:f1d9 with SMTP id ffacd0b85a97d-3e75f26f67bmr1055051f8f.3.1757583818669; Thu, 11 Sep 2025 02:43:38 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:37 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:21 +0200 Subject: [PATCH v2 10/13] memory: tegra124-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-10-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10836; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=NsGEIgGjbOpROhUmLr+vi+i7gGp3+YQdgw+pRaV7CFw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm65lTN/m95NUl69MLbrPKF8ihpruNwpNKz8 fiQ2vCTH0qJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZugAKCRDBN2bmhouD 1z0+D/9escPOZFJ19BWYtWVn3aglhmAMEVdHZT3+zxJ6q3lwjLKIKF7++w7zl9YaukUhXaD2hHa DBJlCK4tXh8V9aMduzuSA303Y1kInERZn00S5idUFyhr7aarF/dSs3RaT0AMOoLIw8GrJw5OXX7 s7A3NSjZNtMJqOXVUTfTVuJPfaSHtrKeoj20XuXPxhttLq9BsM+fn9k2gJ0O06qGh2zzdv6grrM PoSoLndwFmoRtTm/3eoRegAl8Pa4fGuNGJXrVom2OwZ2KciX50+GCAX5/HOmQCbpr9lWSVa1A3U P7PagFutwGLIaiZWQCAIngr7l5293czb3DNhGhom2eBLuC1/mHFMZ6oOwWchYw8l1wr8C7eSZtl EgHpqBG9oh0S2QjXtV5dhf+zlVoWcw2kai8qWKa4E6HetUy1YtZRf7YSCfB54zxcTg96tNMSCjJ ICmQB7OgCrPRhvD+5KmffvFRy1/GGAFi4EUmjWPwtMKNOdJ0OsOBEglaEgn2ZR3HT50e48MSqvm H/8tnh6OAX/AH5hxcOlmKR++OeRTvjfoRztB9/3WaiQSue05YkbsMLOgJGdymrNQYk9klsDnzQL vN/wNSBHisrwtHm3fxYYYlQWTUDUgkPLcUYKEvyUtHf9d5JSm4Xj/nWs8/Cumx8JOE5vMSPZ3f2 O4UWhtluHNCwX3A== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra124_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra124-emc.c | 98 ++++++++++++++++++---------------= ---- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index f4d703103d9ca155eca92331ee762cecd4e01302..9978ff911c4790b30423064c8fe= 0d3d53e8efcef 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -571,8 +571,8 @@ static void emc_seq_wait_clkchange(struct tegra_emc *em= c) dev_err(emc->dev, "clock change timed out\n"); } =20 -static struct emc_timing *tegra_emc_find_timing(struct tegra_emc *emc, - unsigned long rate) +static struct emc_timing *tegra124_emc_find_timing(struct tegra_emc *emc, + unsigned long rate) { struct emc_timing *timing =3D NULL; unsigned int i; @@ -592,10 +592,10 @@ static struct emc_timing *tegra_emc_find_timing(struc= t tegra_emc *emc, return timing; } =20 -static int tegra_emc_prepare_timing_change(struct tegra_emc *emc, - unsigned long rate) +static int tegra124_emc_prepare_timing_change(struct tegra_emc *emc, + unsigned long rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra124_emc_find_timing(emc, rate); struct emc_timing *last =3D &emc->last_timing; enum emc_dll_change dll_change; unsigned int pre_wait =3D 0; @@ -820,10 +820,10 @@ static int tegra_emc_prepare_timing_change(struct teg= ra_emc *emc, return 0; } =20 -static void tegra_emc_complete_timing_change(struct tegra_emc *emc, - unsigned long rate) +static void tegra124_emc_complete_timing_change(struct tegra_emc *emc, + unsigned long rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra124_emc_find_timing(emc, rate); struct emc_timing *last =3D &emc->last_timing; u32 val; =20 @@ -986,8 +986,8 @@ static int cmp_timings(const void *_a, const void *_b) return 1; } =20 -static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, - struct device_node *node) +static int tegra124_emc_load_timings_from_dt(struct tegra_emc *emc, + struct device_node *node) { int child_count =3D of_get_child_count(node); struct emc_timing *timing; @@ -1015,15 +1015,15 @@ static int tegra_emc_load_timings_from_dt(struct te= gra_emc *emc, return 0; } =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra124_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra124-emc" }, { .compatible =3D "nvidia,tegra132-emc" }, {} }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra124_emc_of_match); =20 static struct device_node * -tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) +tegra124_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) { struct device_node *np; int err; @@ -1041,7 +1041,7 @@ tegra_emc_find_node_by_ram_code(struct device_node *n= ode, u32 ram_code) return NULL; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra124_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -1143,7 +1143,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, un= signed long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra124_emc_validate_rate(struct tegra_emc *emc, unsigned lon= g rate) { unsigned int i; =20 @@ -1154,8 +1154,8 @@ static bool tegra_emc_validate_rate(struct tegra_emc = *emc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, - void *data) +static int tegra124_emc_debug_available_rates_show(struct seq_file *s, + void *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -1171,9 +1171,9 @@ static int tegra_emc_debug_available_rates_show(struc= t seq_file *s, return 0; } =20 -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra124_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra124_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1182,12 +1182,12 @@ static int tegra_emc_debug_min_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra124_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra124_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -1199,11 +1199,11 @@ static int tegra_emc_debug_min_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra124_emc_debug_min_rate_fops, + tegra124_emc_debug_min_rate_get, + tegra124_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra124_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1212,12 +1212,12 @@ static int tegra_emc_debug_max_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra124_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra124_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -1229,9 +1229,9 @@ static int tegra_emc_debug_max_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra124_emc_debug_max_rate_fops, + tegra124_emc_debug_max_rate_get, + tegra124_emc_debug_max_rate_set, "%llu\n"); =20 static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc) { @@ -1266,11 +1266,11 @@ static void emc_debugfs_init(struct device *dev, st= ruct tegra_emc *emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc, - &tegra_emc_debug_available_rates_fops); + &tegra124_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra124_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra124_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1334,7 +1334,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra124_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc =3D emc->mc->soc; struct icc_node *node; @@ -1383,7 +1383,7 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static int tegra_emc_opp_table_init(struct tegra_emc *emc) +static int tegra124_emc_opp_table_init(struct tegra_emc *emc) { u32 hw_version =3D BIT(tegra_sku_info.soc_speedo_id); int opp_token, err; @@ -1425,12 +1425,12 @@ static int tegra_emc_opp_table_init(struct tegra_em= c *emc) return err; } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra124_emc_unset_callback(void *data) { tegra124_clk_set_emc_callbacks(NULL, NULL); } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra124_emc_probe(struct platform_device *pdev) { struct device_node *np; struct tegra_emc *emc; @@ -1454,9 +1454,9 @@ static int tegra_emc_probe(struct platform_device *pd= ev) =20 ram_code =3D tegra_read_ram_code(); =20 - np =3D tegra_emc_find_node_by_ram_code(pdev->dev.of_node, ram_code); + np =3D tegra124_emc_find_node_by_ram_code(pdev->dev.of_node, ram_code); if (np) { - err =3D tegra_emc_load_timings_from_dt(emc, np); + err =3D tegra124_emc_load_timings_from_dt(emc, np); of_node_put(np); if (err) return err; @@ -1470,10 +1470,10 @@ static int tegra_emc_probe(struct platform_device *= pdev) =20 platform_set_drvdata(pdev, emc); =20 - tegra124_clk_set_emc_callbacks(tegra_emc_prepare_timing_change, - tegra_emc_complete_timing_change); + tegra124_clk_set_emc_callbacks(tegra124_emc_prepare_timing_change, + tegra124_emc_complete_timing_change); =20 - err =3D devm_add_action_or_reset(&pdev->dev, devm_tegra_emc_unset_callbac= k, + err =3D devm_add_action_or_reset(&pdev->dev, devm_tegra124_emc_unset_call= back, NULL); if (err) return err; @@ -1483,16 +1483,16 @@ static int tegra_emc_probe(struct platform_device *= pdev) return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), "failed to get EMC clock\n"); =20 - err =3D tegra_emc_opp_table_init(emc); + err =3D tegra124_emc_opp_table_init(emc); if (err) return err; =20 - tegra_emc_rate_requests_init(emc); + tegra124_emc_rate_requests_init(emc); =20 if (IS_ENABLED(CONFIG_DEBUG_FS)) emc_debugfs_init(&pdev->dev, emc); =20 - tegra_emc_interconnect_init(emc); + tegra124_emc_interconnect_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1504,16 +1504,16 @@ static int tegra_emc_probe(struct platform_device *= pdev) return 0; }; =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra124_emc_driver =3D { + .probe =3D tegra124_emc_probe, .driver =3D { .name =3D "tegra-emc", - .of_match_table =3D tegra_emc_of_match, + .of_match_table =3D tegra124_emc_of_match, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra124_emc_driver); =20 MODULE_AUTHOR("Mikko Perttunen "); MODULE_DESCRIPTION("NVIDIA Tegra124 EMC driver"); --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1D72EFDA0 for ; Thu, 11 Sep 2025 09:43:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583823; cv=none; b=quR3XEfIGGMpr9owRa2DsO7gky3VnPjY6U9xFHkLnZ7MKaCqZrxGFeNDq9v4VwAX2vSQ9Fy3/9FC48I9qF8NnMUBbq6Xoea3nlq5BktcPfLV7Ik1UygMEZYOqGQWtnv/epGqIKcsHnQvSU6CYH3iz9nnlYuFJiZz3O/4/Z34P7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583823; c=relaxed/simple; bh=GAd4svxSVgnkOhIwOQn+NSNpac5IpOx7copCWoIZ7eU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gitnSS3Cdn7LEQkjZXJDzmSaT/y9IE1D8kAxBgfuqd9mN2iixLpWKfX+hPhxtK2Zo3TVlNWbn8iwNbZo8gLOp3G+ConsnlnJyp+txqKGnhoEbp8KXbXxNjMTZ8g2xNYrZnEEJ7vF5q9R22Y0rbYZl5LpRMJLtcRmLKmylGnAEqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jOtAJS+t; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jOtAJS+t" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45b9bc2df29so406085e9.0 for ; Thu, 11 Sep 2025 02:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583820; x=1758188620; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U80QC7ZRGmD2zeYUt/JuyYkH4QiRinpLjt2jmWesQl0=; b=jOtAJS+t2JwE/VUyABZnkB0QVB9r3W03lnlnBkJXnxhumuCXjeO8WIbfJ2uFJB1Inx M7clHP7qg/dmlx4PmW8fQk2BVClj26fqL2/shw8rs1r/eihm0a0ru/E1RAPcvRMBxy45 xYe+JpAdHl8geL6n9ZMo6EDBu8twrgR1HtfnsbmIGFBowSwydlOybXPZ2qotJ54kGQ0Y V+rOr56u18F5d2XythCHUGrXU11aL//PXp0pRGTIvar8eyC6uDG5KOg4lO9EuuPlRTAs ga5U40oSDJdu22YeAuQW/9HvkO2Oyzc0WxwyZwegkT1nzU4h4eJjotRvSc8tt7kU2bpt hXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583820; x=1758188620; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U80QC7ZRGmD2zeYUt/JuyYkH4QiRinpLjt2jmWesQl0=; b=ITqE+OA2H73e8K+/07yGtK06osXmuZcpSRD4lNsS+vsDz/PDDys045uxhb2Bkl5PZt +axAiGe5Cl8tS1idjuNcG9nczPwChUAHnFl4BLJ+DvZFoRk8Ca34EUqmlayxyvT+e03N /2/XxWuvsDnwXIrme6JRC33GsYxKuLJDLPoDcx3rZM6m8BpghjfjiYYUEGobgcotvSQE T/gOdsqgAjfn+x1zZOtdkESG0PuQOQEwq43FiPt3t+AwYPcj7YrShPR+QbtIVC+PMcCR FbchXZ1Zfu8hrcFSonmIp4Q1u1tYVKgszgNdxMvT8KfcXK3bsuaZebbql9lVP48pEZTt QVqQ== X-Gm-Message-State: AOJu0YzyCAWbsDPGhzCynicm1Stoqu9MOnW1Na37SsF6A+ZxrLIkWH54 robIl8B1Nxv/bQb5cjyf7ng5gVoNW9ixTxkjSvrWQvQyugvF9oof64I247Z8+2H1GMBrMF02M5a zYwEk X-Gm-Gg: ASbGncs1/l+veMh5xoeR1ePgrez8kvCjgCwJTlYZ7tKwGlIGKkDIUbgQT3A5WInM506 weNpI3P3dMPYCMZg1dm9bKIzr++/4Md6G5uEbv9j4ZoR0USCtqhCRK65QsfVLow/VLpWlYIyf9I PuSly63NBJHkltc+1rWS5KZ/wZ8revXuGG84WsuavOTG2LcD0eHFvLkvdRI9CWVxPyg1k3dQlGe L2YOR5FvEUbKJBNr7S7Z0r1rlmiz/56tgpGxtRfZ6OyxB3ZTCZz/p/SKgCnDCOpz8+swnhU/l8D fGryiZp+c5WgITxxXD/EuUbgunFkNUkl0wSeDBmpXZIb98fvDe43iAanzXfQ3fVBkgSTFoxC72b H/2c39IBQZfVxPDdCBFRS1Y6ErXkRXfvOpU4LrYU= X-Google-Smtp-Source: AGHT+IEh/Uq9AaVnfyJLiH7s3S7h4eHgrMQvqFPZnx+khD3aEY9xCE9DokvzHDxbUHKjVpIvYM7OLg== X-Received: by 2002:a05:600c:3ace:b0:45d:dd02:cdc8 with SMTP id 5b1f17b1804b1-45dddee9ea4mr85213625e9.3.1757583819813; Thu, 11 Sep 2025 02:43:39 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:39 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:22 +0200 Subject: [PATCH v2 11/13] memory: tegra186-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-11-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3374; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=GAd4svxSVgnkOhIwOQn+NSNpac5IpOx7copCWoIZ7eU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm7pEGQ9eJRN63t83Qgfbkb8IpSkIxS2GIRT pAlyLWoypGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZuwAKCRDBN2bmhouD 1wHgD/9FA8yMCbzeCJ2kUBrBApGFPUxEeTzyXQTwodPDGp+v9l0qqfhwd8Wl8UEpouNQgu/rXRx DqDp1qWgeGCZzbvfdPS5z/6IM1Wo4ScOa/UlsIZgPLHU14AtW6dRw5AnD11WgNrbd4uonc0d8vA 1QNI1OXS0buVAtzvOcv9yMkMuSH/+o+VxZm/qOd1ruMgFAjY1kMG6Zh3EHPlm9Oip1IfSGHwIks KVr9YfsURMA6hXfcrsd/Zb6/zTPj2TmlHbfJN5koE1+JSIAroTaPDIck5ehB2CIdtxUPJtW2Wf2 URd4p5a1KDWm3a5tzJGOJY0F2nQqfovwQrUoJOlTVnR4Qmn5i5olypldZqgsRv5wToAwxyxOrXQ KgZx7ihdx49OU3H/a1r0dQ24hCrcQgtT/t2BFxNm7Y99IIHL41HNTLMd9wYwBatzXNuAzz5Yz5o Reuzzlif+XhkGXmqI9OMvqfmJPlQa7GUfiDC3uTyDyYXz3Z7pzQtiuTc2EIdnYtS069ZFPOJTOz ALOLNLqZGeyMBHgcj+cVJvtUCCa3yL4Kwjc7XmKUAD82qDKMMeLZQgcDmPlogg9Qza6luGVMY6y rialgVt4G00z0M5dqo5mTfdQ8XTh67Ou/CLssYvmQjxxJEKFp0MIFbMblPlZookpo/XyJR8pKf+ 5g/wfaK68HWpaCQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra186_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra186-emc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index a0de80afe3e90531fcfb29d20773aed0d04478c5..9959ad5804b444b269456d1fbae= 87b4bc111661b 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -218,20 +218,20 @@ static int tegra186_emc_get_emc_dvfs_latency(struct t= egra186_emc *emc) } =20 /* - * tegra_emc_icc_set_bw() - Set BW api for EMC provider + * tegra186_emc_icc_set_bw() - Set BW api for EMC provider * @src: ICC node for External Memory Controller (EMC) * @dst: ICC node for External Memory (DRAM) * * Do nothing here as info to BPMP-FW is now passed in the BW set function * of the MC driver. BPMP-FW sets the final Freq based on the passed value= s. */ -static int tegra_emc_icc_set_bw(struct icc_node *src, struct icc_node *dst) +static int tegra186_emc_icc_set_bw(struct icc_node *src, struct icc_node *= dst) { return 0; } =20 static struct icc_node * -tegra_emc_of_icc_xlate(const struct of_phandle_args *spec, void *data) +tegra186_emc_of_icc_xlate(const struct of_phandle_args *spec, void *data) { struct icc_provider *provider =3D data; struct icc_node *node; @@ -247,7 +247,7 @@ tegra_emc_of_icc_xlate(const struct of_phandle_args *sp= ec, void *data) return ERR_PTR(-EPROBE_DEFER); } =20 -static int tegra_emc_icc_get_init_bw(struct icc_node *node, u32 *avg, u32 = *peak) +static int tegra186_emc_icc_get_init_bw(struct icc_node *node, u32 *avg, u= 32 *peak) { *avg =3D 0; *peak =3D 0; @@ -255,7 +255,7 @@ static int tegra_emc_icc_get_init_bw(struct icc_node *n= ode, u32 *avg, u32 *peak) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra186_emc *emc) +static int tegra186_emc_interconnect_init(struct tegra186_emc *emc) { struct tegra_mc *mc =3D dev_get_drvdata(emc->dev->parent); const struct tegra_mc_soc *soc =3D mc->soc; @@ -263,11 +263,11 @@ static int tegra_emc_interconnect_init(struct tegra18= 6_emc *emc) int err; =20 emc->provider.dev =3D emc->dev; - emc->provider.set =3D tegra_emc_icc_set_bw; + emc->provider.set =3D tegra186_emc_icc_set_bw; emc->provider.data =3D &emc->provider; emc->provider.aggregate =3D soc->icc_ops->aggregate; - emc->provider.xlate =3D tegra_emc_of_icc_xlate; - emc->provider.get_bw =3D tegra_emc_icc_get_init_bw; + emc->provider.xlate =3D tegra186_emc_of_icc_xlate; + emc->provider.get_bw =3D tegra186_emc_icc_get_init_bw; =20 icc_provider_init(&emc->provider); =20 @@ -354,7 +354,7 @@ static int tegra186_emc_probe(struct platform_device *p= dev) * EINVAL instead of passing the request to BPMP-FW later when the BW * request is made by client with 'icc_set_bw()' call. */ - err =3D tegra_emc_interconnect_init(emc); + err =3D tegra186_emc_interconnect_init(emc); if (err) { mc->bpmp =3D NULL; goto put_bpmp; --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073A12F28E6 for ; Thu, 11 Sep 2025 09:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583825; cv=none; b=eOCQO0LbZobm4wi0Pd4p9NvWCCvw8Fa2TvjOXdlW38MJ1jw6ZNdkC2FaHv/ITT2P93DxORoy0uqp6wpLZk6txrzUHiLKFgCGYhCRK1XPCmPWecaYAPY00GuIk71FW/dtuhUDe4OZFAVQLi/lUFJHch/sWtQPeF26g3lKQdkjX+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583825; c=relaxed/simple; bh=+DKhnZ/wfxN+lWYBhIDkpgdioNkSeR/jV1dNtS5sXFk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tkthp2eiO7pqRTS50ZKhULvVIH0FZTHS3UvdEQOpOBSw9fb/1C4gjLx9PR+NVh0xyFoGB+PJmI6KaQYMHnnKquVLWks3hw/05o0xVMVkRHTYwm+NHVaFEGApk3xRLOkZXremlBVS+k/cAyqtoW3LrzUKAP6T5WvkHY515nt+U9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OUckuSjI; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OUckuSjI" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3d614be80c3so28129f8f.2 for ; Thu, 11 Sep 2025 02:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583821; x=1758188621; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E0wAbG0tLjrUM+iYP+v2dL+KRMi3fNkJUpDnkhwIEjQ=; b=OUckuSjIgKjKULLgJktHrGqEgMDW5aq8XouFT5lSSuvru/YRgiwDTb55habKXJE8QZ YYKb2tKCM6L6ZOPGt7+r4DTJHQ9fvjOzudz/ZLhHTR9WHvz1PRurr7fc0JO2UtgJHIs4 C/iI0W/iq06Yv+NrSXJgSJcQS0QB5SIg/1y8rSoIdMoo1DkfmGzQxOIRjOhz5JIdnjdT f4+RISND6ctHfa6EGhWeAlTdnlsDvLCD2dZR8i5qofBofk72/bs4a0TkpOPBNXe+ysPC ypkxzlBImS4JYcux/vESCCJbIHFlG8phUmApuJRz8Jor2Ry4oEcJRowKFzU+KRtocR2g SPPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583821; x=1758188621; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E0wAbG0tLjrUM+iYP+v2dL+KRMi3fNkJUpDnkhwIEjQ=; b=vPW84VkNpspF/4fLpf10dCTE8oG9JBGV0SWL925HuMIMVN7d9a8fGuLl71ITugBpDW m72GhRIKa0pJ7KPK39qX+c1k6ycxM2owCltNhB0hiF9I7UD+s8ePko0aaRv4/uRzZE0M z9YK4T/S5qX1qWOR4A2cQy5CgIH6MGjEyXeaaoXnQBjH/4JM/FscumIIlItOU9BosLRJ 4FeHv/5uAxiUfaqmhSMUDn4lC5J9dBNUm6ZpG8YMzy+2PduL4vnOe8Tkn2E72u0uxdmZ isxP6WZrXIevaWFva0c+4ce0aIenEnQSoSnkoWvsW3t/voZvd84lIbQrI/rPlYyq0JAG XgtQ== X-Gm-Message-State: AOJu0Yy2E39BsAQnfWHYHa4tDav4Ginzft5rEBVWR7z88FNW7B3HMT9+ BFvhN+xU0jlXDS9kY9NeLCK6+EVhQGyr4mh09wfQPutOvCeisVAKmY0ualVyr6eEEqo= X-Gm-Gg: ASbGnctXu0LPUOLhqz9Vc1QyRm8d91HsD+R+oO2+vXK9lNcfVrhLixTq2gSo4Nrxl5D tZfLjRDecR+xf++hs3l2ndMBpB0RRnUNGXTSbxrx0AsbByCkfXBzRHbxjDFO6khencj6I/XkgmV 6YhiioteOx5v1F3P7GX4EddMXByjdFNLX409OBUPsQtG7uWTJtNdBuVEZ+CJsDo+Ey/i9uH/EhE /JKIwjgo6LlGGh45IpUNF3Gaaxm9ussIFybGqZg//gEfi70HOo3ZhuJ4kMkRWO0VWTrJK6YZnaC lb0A0KXZpTlstKjyj65dO7Va6kH6nqQH/AI0MGX7ObZmQ9f2O0JO0yI1rQ8MRvs/uH1i3NO4FRV lc76513kYWyRjI9EzAjw0UOiUSCJbtePv6BICUP88pI5ZlWgJ+g== X-Google-Smtp-Source: AGHT+IEy8voEinK3BVG47F9R0HEk4/OyfusT1NLJgI+IHvactxZuhNeBeG6un9EMsviFxU4sExX7BQ== X-Received: by 2002:a05:600c:37c9:b0:45d:dbf0:4826 with SMTP id 5b1f17b1804b1-45ded02d62fmr49716645e9.6.1757583821274; Thu, 11 Sep 2025 02:43:41 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:40 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:23 +0200 Subject: [PATCH v2 12/13] memory: tegra20-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-12-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=13252; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=+DKhnZ/wfxN+lWYBhIDkpgdioNkSeR/jV1dNtS5sXFk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm7BHYgc+Lq5cLJtVfPxdZDzccjS8+Ia5y5l M+04t7XQ1+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZuwAKCRDBN2bmhouD 1835D/4gfXZfisy/4EKxTmMiAiNMWJe3VlfAWZjtS0sqdi5GtMjfBpATCs7F2clNu4oG10gzMPd v/0NqY6fdFCrN3ebWe+IE2hfDBqC9FgEoGqK2PB5YSW4pn5psTib2frjGkX4F7fJHzeZgdyzr+k bXlvd26QZxmBt29pNC1VE3hRH8uT1cd6GdrtQxkevYFA8rHx+eRg654W1D+juQxspa3bUKtl43o 8tRaDN5seKZZtNKwy+efGenAIfgVBTutOEA9uJHPyXxRmuOoii08pUl61FhIL7AcPYm38DEXKnW MX+s63Ri+Q96rxklrjmVNse/8TdTS8JYxRDdHQ1TQkL0YGYjb0TjkroHYlOpZ5ANWulT1af+Cz8 SDajapnzi9wrOgI5Tijyx+CoPXVE1l7S4d0QHENTcQmKygzPQNh43laX18ZZO1PjKwbhErvU5LB +0v50hCT0VZ4LW8DP7swdRYYS/N+XG15vfyHAG0wowD7iO4o4KKyiK2x9gkTb1g5Vx6Lft/7A99 GXYoHFftXOX4bfUG3dZqXU6vQ/RwQUZ1SaXU5HJBmJkI8StHsia3WYdK5t6hya14d0T+m/Nmnc6 gx8Ab0wFWjhNenc3wxULYYXwLq8mf3B5wajHvvkd7j774BgnAG/liqzNP28Ae4gxl2X5OUphfYh 3P7p3qd/SoiAoWw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra20_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra20-emc.c | 120 ++++++++++++++++++---------------= ---- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index 18e266dde5d2a0fb962fadc04161b03fb79f76cb..398cb8ae2e38736fcac04d71738= b11b3d5b75f4e 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -232,7 +232,7 @@ struct tegra_emc { bool mrr_error; }; =20 -static irqreturn_t tegra_emc_isr(int irq, void *data) +static irqreturn_t tegra20_emc_isr(int irq, void *data) { struct tegra_emc *emc =3D data; u32 intmask =3D EMC_REFRESH_OVERFLOW_INT; @@ -253,8 +253,8 @@ static irqreturn_t tegra_emc_isr(int irq, void *data) return IRQ_HANDLED; } =20 -static struct emc_timing *tegra_emc_find_timing(struct tegra_emc *emc, - unsigned long rate) +static struct emc_timing *tegra20_emc_find_timing(struct tegra_emc *emc, + unsigned long rate) { struct emc_timing *timing =3D NULL; unsigned int i; @@ -276,7 +276,7 @@ static struct emc_timing *tegra_emc_find_timing(struct = tegra_emc *emc, =20 static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long = rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra20_emc_find_timing(emc, rate); unsigned int i; =20 if (!timing) @@ -321,8 +321,8 @@ static int emc_complete_timing_change(struct tegra_emc = *emc, bool flush) return 0; } =20 -static int tegra_emc_clk_change_notify(struct notifier_block *nb, - unsigned long msg, void *data) +static int tegra20_emc_clk_change_notify(struct notifier_block *nb, + unsigned long msg, void *data) { struct tegra_emc *emc =3D container_of(nb, struct tegra_emc, clk_nb); struct clk_notifier_data *cnd =3D data; @@ -407,8 +407,8 @@ static int cmp_timings(const void *_a, const void *_b) return 0; } =20 -static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, - struct device_node *node) +static int tegra20_emc_load_timings_from_dt(struct tegra_emc *emc, + struct device_node *node) { struct emc_timing *timing; int child_count; @@ -452,7 +452,7 @@ static int tegra_emc_load_timings_from_dt(struct tegra_= emc *emc, } =20 static struct device_node * -tegra_emc_find_node_by_ram_code(struct tegra_emc *emc) +tegra20_emc_find_node_by_ram_code(struct tegra_emc *emc) { struct device *dev =3D emc->dev; struct device_node *np; @@ -710,7 +710,7 @@ static long emc_round_rate(unsigned long rate, return timing->rate; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra20_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -812,7 +812,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, unsi= gned long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra20_emc_validate_rate(struct tegra_emc *emc, unsigned long= rate) { unsigned int i; =20 @@ -823,7 +823,7 @@ static bool tegra_emc_validate_rate(struct tegra_emc *e= mc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, void *= data) +static int tegra20_emc_debug_available_rates_show(struct seq_file *s, void= *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -838,9 +838,9 @@ static int tegra_emc_debug_available_rates_show(struct = seq_file *s, void *data) =20 return 0; } -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra20_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra20_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -849,12 +849,12 @@ static int tegra_emc_debug_min_rate_get(void *data, u= 64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra20_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra20_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -866,11 +866,11 @@ static int tegra_emc_debug_min_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(tegra20_emc_debug_min_rate_fops, + tegra20_emc_debug_min_rate_get, + tegra20_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra20_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -879,12 +879,12 @@ static int tegra_emc_debug_max_rate_get(void *data, u= 64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra20_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra20_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -896,11 +896,11 @@ static int tegra_emc_debug_max_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(tegra20_emc_debug_max_rate_fops, + tegra20_emc_debug_max_rate_get, + tegra20_emc_debug_max_rate_set, "%llu\n"); =20 -static void tegra_emc_debugfs_init(struct tegra_emc *emc) +static void tegra20_emc_debugfs_init(struct tegra_emc *emc) { struct device *dev =3D emc->dev; unsigned int i; @@ -933,11 +933,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc *= emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, - emc, &tegra_emc_debug_available_rates_fops); + emc, &tegra20_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra20_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra20_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1000,7 +1000,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra20_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc; struct icc_node *node; @@ -1055,25 +1055,25 @@ static int tegra_emc_interconnect_init(struct tegra= _emc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra20_emc_unset_callback(void *data) { tegra20_clk_set_emc_round_callback(NULL, NULL); } =20 -static void devm_tegra_emc_unreg_clk_notifier(void *data) +static void devm_tegra20_emc_unreg_clk_notifier(void *data) { struct tegra_emc *emc =3D data; =20 clk_notifier_unregister(emc->clk, &emc->clk_nb); } =20 -static int tegra_emc_init_clk(struct tegra_emc *emc) +static int tegra20_emc_init_clk(struct tegra_emc *emc) { int err; =20 tegra20_clk_set_emc_round_callback(emc_round_rate, emc); =20 - err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unset_callback, + err =3D devm_add_action_or_reset(emc->dev, devm_tegra20_emc_unset_callbac= k, NULL); if (err) return err; @@ -1088,15 +1088,15 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, - devm_tegra_emc_unreg_clk_notifier, emc); + devm_tegra20_emc_unreg_clk_notifier, emc); if (err) return err; =20 return 0; } =20 -static int tegra_emc_devfreq_target(struct device *dev, unsigned long *fre= q, - u32 flags) +static int tegra20_emc_devfreq_target(struct device *dev, unsigned long *f= req, + u32 flags) { struct tegra_emc *emc =3D dev_get_drvdata(dev); struct dev_pm_opp *opp; @@ -1114,8 +1114,8 @@ static int tegra_emc_devfreq_target(struct device *de= v, unsigned long *freq, return emc_set_min_rate(emc, rate, EMC_RATE_DEVFREQ); } =20 -static int tegra_emc_devfreq_get_dev_status(struct device *dev, - struct devfreq_dev_status *stat) +static int tegra20_emc_devfreq_get_dev_status(struct device *dev, + struct devfreq_dev_status *stat) { struct tegra_emc *emc =3D dev_get_drvdata(dev); =20 @@ -1137,13 +1137,13 @@ static int tegra_emc_devfreq_get_dev_status(struct = device *dev, return 0; } =20 -static struct devfreq_dev_profile tegra_emc_devfreq_profile =3D { +static struct devfreq_dev_profile tegra20_emc_devfreq_profile =3D { .polling_ms =3D 30, - .target =3D tegra_emc_devfreq_target, - .get_dev_status =3D tegra_emc_devfreq_get_dev_status, + .target =3D tegra20_emc_devfreq_target, + .get_dev_status =3D tegra20_emc_devfreq_get_dev_status, }; =20 -static int tegra_emc_devfreq_init(struct tegra_emc *emc) +static int tegra20_emc_devfreq_init(struct tegra_emc *emc) { struct devfreq *devfreq; =20 @@ -1165,7 +1165,7 @@ static int tegra_emc_devfreq_init(struct tegra_emc *e= mc) writel_relaxed(0x00000000, emc->regs + EMC_STAT_LLMC_CONTROL); writel_relaxed(0xffffffff, emc->regs + EMC_STAT_PWR_CLOCK_LIMIT); =20 - devfreq =3D devm_devfreq_add_device(emc->dev, &tegra_emc_devfreq_profile, + devfreq =3D devm_devfreq_add_device(emc->dev, &tegra20_emc_devfreq_profil= e, DEVFREQ_GOV_SIMPLE_ONDEMAND, &emc->ondemand_data); if (IS_ERR(devfreq)) @@ -1175,7 +1175,7 @@ static int tegra_emc_devfreq_init(struct tegra_emc *e= mc) return 0; } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra20_emc_probe(struct platform_device *pdev) { struct tegra_core_opp_params opp_params =3D {}; struct device_node *np; @@ -1191,7 +1191,7 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return -ENOMEM; =20 mutex_init(&emc->rate_lock); - emc->clk_nb.notifier_call =3D tegra_emc_clk_change_notify; + emc->clk_nb.notifier_call =3D tegra20_emc_clk_change_notify; emc->dev =3D &pdev->dev; =20 emc->regs =3D devm_platform_ioremap_resource(pdev, 0); @@ -1202,22 +1202,22 @@ static int tegra_emc_probe(struct platform_device *= pdev) if (err) return err; =20 - np =3D tegra_emc_find_node_by_ram_code(emc); + np =3D tegra20_emc_find_node_by_ram_code(emc); if (np) { - err =3D tegra_emc_load_timings_from_dt(emc, np); + err =3D tegra20_emc_load_timings_from_dt(emc, np); of_node_put(np); if (err) return err; } =20 - err =3D devm_request_irq(&pdev->dev, irq, tegra_emc_isr, 0, + err =3D devm_request_irq(&pdev->dev, irq, tegra20_emc_isr, 0, dev_name(&pdev->dev), emc); if (err) { dev_err(&pdev->dev, "failed to request IRQ: %d\n", err); return err; } =20 - err =3D tegra_emc_init_clk(emc); + err =3D tegra20_emc_init_clk(emc); if (err) return err; =20 @@ -1228,10 +1228,10 @@ static int tegra_emc_probe(struct platform_device *= pdev) return err; =20 platform_set_drvdata(pdev, emc); - tegra_emc_rate_requests_init(emc); - tegra_emc_debugfs_init(emc); - tegra_emc_interconnect_init(emc); - tegra_emc_devfreq_init(emc); + tegra20_emc_rate_requests_init(emc); + tegra20_emc_debugfs_init(emc); + tegra20_emc_interconnect_init(emc); + tegra20_emc_devfreq_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1243,22 +1243,22 @@ static int tegra_emc_probe(struct platform_device *= pdev) return 0; } =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra20_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra20-emc", }, {}, }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra20_emc_of_match); =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra20_emc_driver =3D { + .probe =3D tegra20_emc_probe, .driver =3D { .name =3D "tegra20-emc", - .of_match_table =3D tegra_emc_of_match, + .of_match_table =3D tegra20_emc_of_match, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra20_emc_driver); =20 MODULE_AUTHOR("Dmitry Osipenko "); MODULE_DESCRIPTION("NVIDIA Tegra20 EMC driver"); --=20 2.48.1 From nobody Thu Oct 2 20:42:11 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 799D52EB844 for ; Thu, 11 Sep 2025 09:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583826; cv=none; b=mx2/o6ksHAJreR04QmBnnEcuu3lRIg7H13SV9NVf6aAzkWmQ+tI//eiQ44wpqYSDBrcAVYFWSdpNdUK0ch1JOd4IiJIljIAptf4VtBodzZYkUeUCvYikZjocpoKifJO82Fpy54eP/NftQVAguVlh+4HK3OcVq3KOLGBO5gqdpPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757583826; c=relaxed/simple; bh=qGIxMSFLdD1OCW1aPIt9bsZ4hBPy6eHSxZx7l14iFd0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HyyZoS/b/rbxphgOOVNvAzoMzJ2xM2BYGXgLwtxC1EvduAwwrNM6IfEroud/HKddSuyLSVgSLwWEAPhT7ekpQL7pL/r7quzcHfZ+IXadh1KuTkOJsYF1bQgvYZexy7ou+FcUSVZertO8Rg1foFZmKpudj0zMIJCAzGu6seXNZJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OU6vfKHO; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OU6vfKHO" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3e74c6de6f7so20649f8f.2 for ; Thu, 11 Sep 2025 02:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757583823; x=1758188623; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oxm1Eo+tRVdG33tlSfkjwXUAZLC8Gj8vvJyWE8eg9vc=; b=OU6vfKHOrW+PSV5cA3VHnZAjDNiB0x6FNGDKo+pIm0uPnGqJXJvjuKqBHllT2U0WnA kA1BB7s1YS8DTIX8FWf5TezwaUgGyYij4uBaLmC9GPpH8zUwGmx5c0UKROTJueZT+ikv Sc2VOpVPv8o1RVb0KuN4gOHLSyA+xc7u5ZadCmbdTaQuEM3/6sNdRyYTRxiZKNo6WfJK y7/Cb+I5vH6m342mDDX7AdCnc3Dvkn+7FdQ5mjTuuIiVnTxpX79eyJ920gRrw/bX2geC 3Xtf6s3a9Pj48s10wWSbLtO+kXAWntD59am9NzNTrHCZ0cjfSeuIxMv6CTcdiF3AZCkx yuPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757583823; x=1758188623; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxm1Eo+tRVdG33tlSfkjwXUAZLC8Gj8vvJyWE8eg9vc=; b=eC9dyXyz3/Vr14UAL+3/nCDp1ql663Oc6whI0knSe5E8gJGX4n4OwXHzYZ0JV0IRGQ 8KSbsw79s5begNwWG7dWHHtOGgb+di+aRes6pJ9+RIr5d6TQyk1SAz46kwX5OY5FFRIE nRReIKhZ1cPQXZVC33Ub4Turq4vm+kcBFJsDg1YA0XeT6mVQYJ8sxWr2VVy5KX31uAXz 0JiPl4VhZZcDQl0smQ47nM2FyPeV+R8dmscdylAIgllH1p1HS8DqiLl67ENLPg1Bs4fG qHJ9uSWxSV9cjLeE71TYAQKB7GJcOc63olWc2Pgk/MQM76LqsCm0q2y4KBFObjiIQFtd rq3g== X-Gm-Message-State: AOJu0Yz+3aplP3oSVmHYLmCsedatWMKvVmNt+XYonf9O11T6LIUkYSK6 +/5LQksiZpMkNhRzJaKYI6VXLR/flxD1W24SYRt74vKSzRZKoxf1OSrQwjspVghGszg= X-Gm-Gg: ASbGncttzcAw15RWjMELDqs7R17wTyfrwiYuTuCvExaK2/S2jPHIfPVcPWjVQGw48ZP y078fCnnT39RO/Sdo2YvuKr2NtmmQcEFXtWnH/tgOguAAW9argrbvgThMmGkYTegXIbLg/WccNu aF9z2E6WJbMN/ueW4FGsvqHYqOaQbce/hRZOhx7HvGug0Q2+jD4Khuvvn3JefpiHP9UC4uXY55b n+ub4usecSverCyTh0soXN71HrmJZEbOF5NfT0EXyGFctGDl7eLHjO8JOCHgBnKPkTzmdzRrH3a E78uSJmnUpl6ZmjFmTDJsPEFpNumEMFz3VvpMD2Qv3wB0SVpjVEnOljqJuuoPZd4aWHmrLGliDf rDA2aDFubl7GgRkt9lZW53EGG7C/PxJ7laLVDIFdSYtRNYbn0Xg== X-Google-Smtp-Source: AGHT+IESgQNFTpFSdG46pbyJ2UEU3eU1nSWsrpT2/U9X2fR3VWQlkL0gjrMqXFn6GSKpJ4DwDpc7Yw== X-Received: by 2002:a05:6000:4701:b0:3e7:41bf:e631 with SMTP id ffacd0b85a97d-3e741bfebabmr7390778f8f.6.1757583822571; Thu, 11 Sep 2025 02:43:42 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e76078fe3bsm1759218f8f.28.2025.09.11.02.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 02:43:41 -0700 (PDT) From: Krzysztof Kozlowski Date: Thu, 11 Sep 2025 11:43:24 +0200 Subject: [PATCH v2 13/13] memory: tegra30-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-memory-tegra-cleanup-v2-13-d08022ff2f85@linaro.org> References: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> In-Reply-To: <20250911-memory-tegra-cleanup-v2-0-d08022ff2f85@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=9708; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=qGIxMSFLdD1OCW1aPIt9bsZ4hBPy6eHSxZx7l14iFd0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowpm84iHlQtrL7wZB/qixqHvtxPxb87A4e746c IokH9VddreJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMKZvAAKCRDBN2bmhouD 127UD/428T8EFWTrGJuXRmbJ8M1VxxMbIkaLD0Bn5iKaiQSY/anngI7+nX0Vpu3xHilEc8GOlbV qDB7C2aA2glBtjX0NqixSAjHmXIS31ePZo4V45CdvnS7ww/eXXdKLNaNZaPnpa/vBAR/wgmGVq+ wzWHIM+j8Qomf1DbxmwwZQL4epXmD/H2sZsr1KgvYzt2cvH03ODo+2Gr0eyWKfbt1rl16HF7tLg zGNyxfH5MA7ltp/4dDwX3rZGe8y/q7ORWU8r4ucC9/Sq8TKncjhgM6doZEiPIMFBPaILYFU8Wli uc1uUUoKMm3Y4K2tEAW6TLqDK0g60lvIqC4ZT5LBqi1KxzcMCb3nZ/IFSEiBEbWYBvhlim5yFwu 6CL66kD34OlFvYsbLI03PDo/FX2GYLhl3JN5i5eEnhfkroXvsXqPQppPJTJ9r8LqbEAmSqIEjeI K4Qq14U052W3ag0b3jfgkywONwX2IO5zTmPwtQSc0/1P5xGVQU+ufugTnYnvL6OU9j64T5OGHhw HwUCIovUVEx6yYuI2edcR4WwiQc8QArcIUx3mNm0rkc5cO7bk5WYEwp0VEetHAqw1YprP8CNVsp uT5eycNSJvwvClfQbOiMK4qoEKTL12Szz4tIyuhMaxQFkd1mRTAnO6/XO7OPokgFTJ+M4nnp1ns UXKUEV1YlB79YiA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra30_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Jon Hunter --- drivers/memory/tegra/tegra30-emc.c | 90 +++++++++++++++++++---------------= ---- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index cca386af423e9647266878ce6cd1bcec09c8eba4..914116d8ec16d0d52180c7fadd1= 843adc139ceaf 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -413,7 +413,7 @@ static int emc_seq_update_timing(struct tegra_emc *emc) return 0; } =20 -static irqreturn_t tegra_emc_isr(int irq, void *data) +static irqreturn_t tegra30_emc_isr(int irq, void *data) { struct tegra_emc *emc =3D data; u32 intmask =3D EMC_REFRESH_OVERFLOW_INT; @@ -1228,7 +1228,7 @@ static long emc_round_rate(unsigned long rate, return timing->rate; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra30_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -1330,7 +1330,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, un= signed long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra30_emc_validate_rate(struct tegra_emc *emc, unsigned long= rate) { unsigned int i; =20 @@ -1341,7 +1341,7 @@ static bool tegra_emc_validate_rate(struct tegra_emc = *emc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, void *= data) +static int tegra30_emc_debug_available_rates_show(struct seq_file *s, void= *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -1356,9 +1356,9 @@ static int tegra_emc_debug_available_rates_show(struc= t seq_file *s, void *data) =20 return 0; } -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra30_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra30_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1367,12 +1367,12 @@ static int tegra_emc_debug_min_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra30_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra30_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -1384,11 +1384,11 @@ static int tegra_emc_debug_min_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra30_emc_debug_min_rate_fops, + tegra30_emc_debug_min_rate_get, + tegra30_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra30_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1397,12 +1397,12 @@ static int tegra_emc_debug_max_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra30_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra30_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -1414,11 +1414,11 @@ static int tegra_emc_debug_max_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra30_emc_debug_max_rate_fops, + tegra30_emc_debug_max_rate_get, + tegra30_emc_debug_max_rate_set, "%llu\n"); =20 -static void tegra_emc_debugfs_init(struct tegra_emc *emc) +static void tegra30_emc_debugfs_init(struct tegra_emc *emc) { struct device *dev =3D emc->dev; unsigned int i; @@ -1451,11 +1451,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc= *emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, - emc, &tegra_emc_debug_available_rates_fops); + emc, &tegra30_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra30_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra30_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1518,7 +1518,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra30_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc =3D emc->mc->soc; struct icc_node *node; @@ -1567,25 +1567,25 @@ static int tegra_emc_interconnect_init(struct tegra= _emc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra30_emc_unset_callback(void *data) { tegra20_clk_set_emc_round_callback(NULL, NULL); } =20 -static void devm_tegra_emc_unreg_clk_notifier(void *data) +static void devm_tegra30_emc_unreg_clk_notifier(void *data) { struct tegra_emc *emc =3D data; =20 clk_notifier_unregister(emc->clk, &emc->clk_nb); } =20 -static int tegra_emc_init_clk(struct tegra_emc *emc) +static int tegra30_emc_init_clk(struct tegra_emc *emc) { int err; =20 tegra20_clk_set_emc_round_callback(emc_round_rate, emc); =20 - err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unset_callback, + err =3D devm_add_action_or_reset(emc->dev, devm_tegra30_emc_unset_callbac= k, NULL); if (err) return err; @@ -1600,14 +1600,14 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, - devm_tegra_emc_unreg_clk_notifier, emc); + devm_tegra30_emc_unreg_clk_notifier, emc); if (err) return err; =20 return 0; } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra30_emc_probe(struct platform_device *pdev) { struct tegra_core_opp_params opp_params =3D {}; struct device_node *np; @@ -1648,12 +1648,12 @@ static int tegra_emc_probe(struct platform_device *= pdev) =20 emc->irq =3D err; =20 - err =3D devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, + err =3D devm_request_irq(&pdev->dev, emc->irq, tegra30_emc_isr, 0, dev_name(&pdev->dev), emc); if (err) return dev_err_probe(&pdev->dev, err, "failed to request irq\n"); =20 - err =3D tegra_emc_init_clk(emc); + err =3D tegra30_emc_init_clk(emc); if (err) return err; =20 @@ -1664,9 +1664,9 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return err; =20 platform_set_drvdata(pdev, emc); - tegra_emc_rate_requests_init(emc); - tegra_emc_debugfs_init(emc); - tegra_emc_interconnect_init(emc); + tegra30_emc_rate_requests_init(emc); + tegra30_emc_debugfs_init(emc); + tegra30_emc_interconnect_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1678,7 +1678,7 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return 0; } =20 -static int tegra_emc_suspend(struct device *dev) +static int tegra30_emc_suspend(struct device *dev) { struct tegra_emc *emc =3D dev_get_drvdata(dev); int err; @@ -1699,7 +1699,7 @@ static int tegra_emc_suspend(struct device *dev) return 0; } =20 -static int tegra_emc_resume(struct device *dev) +static int tegra30_emc_resume(struct device *dev) { struct tegra_emc *emc =3D dev_get_drvdata(dev); =20 @@ -1711,28 +1711,28 @@ static int tegra_emc_resume(struct device *dev) return 0; } =20 -static const struct dev_pm_ops tegra_emc_pm_ops =3D { - .suspend =3D tegra_emc_suspend, - .resume =3D tegra_emc_resume, +static const struct dev_pm_ops tegra30_emc_pm_ops =3D { + .suspend =3D tegra30_emc_suspend, + .resume =3D tegra30_emc_resume, }; =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra30_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra30-emc", }, {}, }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra30_emc_of_match); =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra30_emc_driver =3D { + .probe =3D tegra30_emc_probe, .driver =3D { .name =3D "tegra30-emc", - .of_match_table =3D tegra_emc_of_match, - .pm =3D &tegra_emc_pm_ops, + .of_match_table =3D tegra30_emc_of_match, + .pm =3D &tegra30_emc_pm_ops, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra30_emc_driver); =20 MODULE_AUTHOR("Dmitry Osipenko "); MODULE_DESCRIPTION("NVIDIA Tegra30 EMC driver"); --=20 2.48.1