From nobody Thu Oct 2 20:46:24 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0343936209C for ; Thu, 11 Sep 2025 17:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757613442; cv=none; b=n7xWsW6AlAbmPMg/eqBC3IraFndDrZIVD91Ve5nWmBJfAX3kDsbBjL/dCGO56qb9IXwWlaeM25glkOxZeKHax8gfbEKXZcKRcDKa0N4W5D/YXrvhZC4m6B/0bjstPZ/VNqGAKnvRZLcR8+0OvBFStRy4Jpza8fmsVl2Gj9Jt5fA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757613442; c=relaxed/simple; bh=HOFral57BQL8UYkTuj9H3P5RIa5oSgklRaCCxDv4muA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TASBwuVb82ta7ZjUJQy2I/TppGkVNtWeNGBFYTg7gkDMIrNByGRX2c+hMSLQBuvxMrhCN/na8TC5yUCd6ITTBTad1XUhrZVOa5U7Qk6rBG6/GFKCsFkKDzo+RQm1brscoAASLgo5pUGGixZWm5Oh/iNicQbOR3262QrWKC+p6Lk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gVQKHh+K; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gVQKHh+K" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6228de280ccso2182735a12.3 for ; Thu, 11 Sep 2025 10:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757613438; x=1758218238; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3ct1QxM5jLU79bjOOr6iNioQP9jRwP1CqDRkzzfxBLo=; b=gVQKHh+KSrwN480ef6w8jOVOGfp1mgh1r6QSQ/+aa80aahwMrMHlSqCGyf07w3hmzU lui1/C5ncdmFRUHscBuIcA9OcPQ/ki3J0rjg8Kjx7o9xMvMUGU93LnamOxjxKFDDpNc+ Xv/pViDhPc3fc40qTbhl+RdWVwd6PUJmSUVaEDgOvoQ3+ARI9IYlomVkrii/3p7GGRQL vQKnHDdZndARN2xt/972ZnR4Qsd08LBlP0hh4o9JVlbduMKyEJV/pdnXSZXpKvKR8ze6 b69584GGQJCr6r/soDvOVEOfX812rJp2fBFTlrIjHmFo6dd+iVmKmxu8UXrLnA7aD4pq 3oKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757613438; x=1758218238; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ct1QxM5jLU79bjOOr6iNioQP9jRwP1CqDRkzzfxBLo=; b=qymGYtMynAwuzR6+nWLld727el1NAerLML7tYJG3Un2ZO5BvgZS+QYsKRFLd7vuvY9 1vCwBad5GPz6OLxUxs789LyddotNdoKiytdZuRF1Ft1NgvS2YVINBCt+FdCgxe/22AZR UQ52XLo88q1EbKlevPdbQoEMoD1pBD0eBjKToc2/+KLReiQXifurr1UJNRTbFpxrPxSX WnoQzlAffRvzamANSBc+Ofev2/NuuFYY4mXKjQtW9o7ClNllasm6uW/jvdXSLqlkJf8O 7fbkadCwSZkFUw6C5NdOn77DmqLCr6gIYc6JwHkW5kcfzrZqhHj+zpolpmlmbPRJOedM OZ9w== X-Forwarded-Encrypted: i=1; AJvYcCWUgt2ShyH2ebMgmhcRPUjzkwulFIxymde3ueFmLAWtLh3saxiDPAXAhA+O0GPTfb++JAEM0MHVo/p2ncs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+6PiA8r1zNeukr78zUkV7PcPJNVP9nVLiOvtDJNG4FbooFg1+ fELGeDVe3lmtJP8TdEL1uAaY73E7uSFQoXmEEB1FHjlFKbRefp68HNzH X-Gm-Gg: ASbGncvUClX7T+LmRlDd31TNXK3+rQuO+hKlPmkbsrirFtna+BbircO7aehUNqHY2vl 8OpXFOfIYHY2n9cXxAXVJUL68Qt0KWl9CBCz0c0UQ5rEZcOEX9FRKtl5wV6AUe/TrncZsmNzr+J 5NrgXqB639PZ6GsIp4/Px4Rg9S6icgiLm/PVwfLUXHpl/bBQ8tvLiflOCII4ukjrXr43gDMmlmu +PA+qOxroYv3QhuTZSlM3BMxJeiXPnBuQPerI+xvvqwiS/iMRIFuEnmwKuzKj9FJhFS7Iz5aPk4 TPkcTEIAyhAtBR7413DYUSF6XqVnWBNc64+b/x9KA7lmE/YZjPr/ShE0o16+jPTCYVmg8Lkhrjv PtFlNk01/KMy5x/aOn0+A X-Google-Smtp-Source: AGHT+IEHQVpkWBC6pm/Vi3j3JbNAq8z1jQ10jnzlee4RvupHLJfqOIx/TplcXsBXKw7RR/7qDFKyBA== X-Received: by 2002:a17:907:7ba1:b0:b04:1a1c:cb5b with SMTP id a640c23a62f3a-b07c353e303mr3739266b.7.1757613438097; Thu, 11 Sep 2025 10:57:18 -0700 (PDT) Received: from [127.0.1.1] ([46.53.240.27]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b07b312845esm171377166b.26.2025.09.11.10.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 10:57:17 -0700 (PDT) From: Dzmitry Sankouski Date: Thu, 11 Sep 2025 20:57:10 +0300 Subject: [PATCH v3 2/9] power: supply: max77705_charger: refactoring: rename charger to chg Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-max77705_77976_charger_improvement-v3-2-35203686fa29@gmail.com> References: <20250911-max77705_77976_charger_improvement-v3-0-35203686fa29@gmail.com> In-Reply-To: <20250911-max77705_77976_charger_improvement-v3-0-35203686fa29@gmail.com> To: Chanwoo Choi , Krzysztof Kozlowski , Lee Jones , Sebastian Reichel , Luca Ceresoli Cc: Krzysztof Kozlowski , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Dzmitry Sankouski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757613433; l=9595; i=dsankouski@gmail.com; s=20240619; h=from:subject:message-id; bh=HOFral57BQL8UYkTuj9H3P5RIa5oSgklRaCCxDv4muA=; b=wTTOLZLMF1IRP98JIMy+SUS3xQC+nO/abtaMtN1f50uhDdSSganPD/SQb9Ah8Pp9/+SFw8V51 3XCMSUWRTs4DddrgJ2k8c8Bp5/fKgCUZV1AB9D0egZv0alNcPF9xWhg X-Developer-Key: i=dsankouski@gmail.com; a=ed25519; pk=YJcXFcN1EWrzBYuiE2yi5Mn6WLn6L1H71J+f7X8fMag= Rename struct max77705_charger_data variable to chg for consistency. Signed-off-by: Dzmitry Sankouski --- drivers/power/supply/max77705_charger.c | 80 ++++++++++++++++-------------= ---- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/power/supply/max77705_charger.c b/drivers/power/supply= /max77705_charger.c index 3b75c82b9b9e..7855f890e0a9 100644 --- a/drivers/power/supply/max77705_charger.c +++ b/drivers/power/supply/max77705_charger.c @@ -42,9 +42,9 @@ static enum power_supply_property max77705_charger_props[= ] =3D { =20 static int max77705_chgin_irq(void *irq_drv_data) { - struct max77705_charger_data *charger =3D irq_drv_data; + struct max77705_charger_data *chg =3D irq_drv_data; =20 - queue_work(charger->wqueue, &charger->chgin_work); + queue_work(chg->wqueue, &chg->chgin_work); =20 return 0; } @@ -109,19 +109,19 @@ static int max77705_get_online(struct regmap *regmap,= int *val) return 0; } =20 -static int max77705_check_battery(struct max77705_charger_data *charger, i= nt *val) +static int max77705_check_battery(struct max77705_charger_data *chg, int *= val) { unsigned int reg_data; unsigned int reg_data2; - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; =20 regmap_read(regmap, MAX77705_CHG_REG_INT_OK, ®_data); =20 - dev_dbg(charger->dev, "CHG_INT_OK(0x%x)\n", reg_data); + dev_dbg(chg->dev, "CHG_INT_OK(0x%x)\n", reg_data); =20 regmap_read(regmap, MAX77705_CHG_REG_DETAILS_00, ®_data2); =20 - dev_dbg(charger->dev, "CHG_DETAILS00(0x%x)\n", reg_data2); + dev_dbg(chg->dev, "CHG_DETAILS00(0x%x)\n", reg_data2); =20 if ((reg_data & MAX77705_BATP_OK) || !(reg_data2 & MAX77705_BATP_DTLS)) *val =3D true; @@ -131,9 +131,9 @@ static int max77705_check_battery(struct max77705_charg= er_data *charger, int *va return 0; } =20 -static int max77705_get_charge_type(struct max77705_charger_data *charger,= int *val) +static int max77705_get_charge_type(struct max77705_charger_data *chg, int= *val) { - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; unsigned int reg_data; =20 regmap_read(regmap, MAX77705_CHG_REG_CNFG_09, ®_data); @@ -159,9 +159,9 @@ static int max77705_get_charge_type(struct max77705_cha= rger_data *charger, int * return 0; } =20 -static int max77705_get_status(struct max77705_charger_data *charger, int = *val) +static int max77705_get_status(struct max77705_charger_data *chg, int *val) { - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; unsigned int reg_data; =20 regmap_read(regmap, MAX77705_CHG_REG_CNFG_09, ®_data); @@ -234,10 +234,10 @@ static int max77705_get_vbus_state(struct regmap *reg= map, int *value) return 0; } =20 -static int max77705_get_battery_health(struct max77705_charger_data *charg= er, +static int max77705_get_battery_health(struct max77705_charger_data *chg, int *value) { - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; unsigned int bat_dtls; =20 regmap_read(regmap, MAX77705_CHG_REG_DETAILS_01, &bat_dtls); @@ -245,16 +245,16 @@ static int max77705_get_battery_health(struct max7770= 5_charger_data *charger, =20 switch (bat_dtls) { case MAX77705_BATTERY_NOBAT: - dev_dbg(charger->dev, "%s: No battery and the charger is suspended\n", + dev_dbg(chg->dev, "%s: No battery and the chg is suspended\n", __func__); *value =3D POWER_SUPPLY_HEALTH_NO_BATTERY; break; case MAX77705_BATTERY_PREQUALIFICATION: - dev_dbg(charger->dev, "%s: battery is okay but its voltage is low(~VPQLB= )\n", + dev_dbg(chg->dev, "%s: battery is okay but its voltage is low(~VPQLB)\n", __func__); break; case MAX77705_BATTERY_DEAD: - dev_dbg(charger->dev, "%s: battery dead\n", __func__); + dev_dbg(chg->dev, "%s: battery dead\n", __func__); *value =3D POWER_SUPPLY_HEALTH_DEAD; break; case MAX77705_BATTERY_GOOD: @@ -262,11 +262,11 @@ static int max77705_get_battery_health(struct max7770= 5_charger_data *charger, *value =3D POWER_SUPPLY_HEALTH_GOOD; break; case MAX77705_BATTERY_OVERVOLTAGE: - dev_dbg(charger->dev, "%s: battery ovp\n", __func__); + dev_dbg(chg->dev, "%s: battery ovp\n", __func__); *value =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; break; default: - dev_dbg(charger->dev, "%s: battery unknown\n", __func__); + dev_dbg(chg->dev, "%s: battery unknown\n", __func__); *value =3D POWER_SUPPLY_HEALTH_UNSPEC_FAILURE; break; } @@ -274,9 +274,9 @@ static int max77705_get_battery_health(struct max77705_= charger_data *charger, return 0; } =20 -static int max77705_get_health(struct max77705_charger_data *charger, int = *val) +static int max77705_get_health(struct max77705_charger_data *chg, int *val) { - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; int ret, is_online =3D 0; =20 ret =3D max77705_get_online(regmap, &is_online); @@ -287,15 +287,15 @@ static int max77705_get_health(struct max77705_charge= r_data *charger, int *val) if (ret || (*val !=3D POWER_SUPPLY_HEALTH_GOOD)) return ret; } - return max77705_get_battery_health(charger, val); + return max77705_get_battery_health(chg, val); } =20 -static int max77705_get_input_current(struct max77705_charger_data *charge= r, +static int max77705_get_input_current(struct max77705_charger_data *chg, int *val) { unsigned int reg_data; int get_current =3D 0; - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; =20 regmap_read(regmap, MAX77705_CHG_REG_CNFG_09, ®_data); =20 @@ -313,11 +313,11 @@ static int max77705_get_input_current(struct max77705= _charger_data *charger, return 0; } =20 -static int max77705_get_charge_current(struct max77705_charger_data *charg= er, +static int max77705_get_charge_current(struct max77705_charger_data *chg, int *val) { unsigned int reg_data; - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; =20 regmap_read(regmap, MAX77705_CHG_REG_CNFG_02, ®_data); reg_data &=3D MAX77705_CHG_CC; @@ -327,12 +327,12 @@ static int max77705_get_charge_current(struct max7770= 5_charger_data *charger, return 0; } =20 -static int max77705_set_float_voltage(struct max77705_charger_data *charge= r, +static int max77705_set_float_voltage(struct max77705_charger_data *chg, int float_voltage) { int float_voltage_mv; unsigned int reg_data =3D 0; - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; =20 float_voltage_mv =3D float_voltage / 1000; reg_data =3D float_voltage_mv <=3D 4000 ? 0x0 : @@ -345,12 +345,12 @@ static int max77705_set_float_voltage(struct max77705= _charger_data *charger, (reg_data << MAX77705_CHG_CV_PRM_SHIFT)); } =20 -static int max77705_get_float_voltage(struct max77705_charger_data *charge= r, +static int max77705_get_float_voltage(struct max77705_charger_data *chg, int *val) { unsigned int reg_data =3D 0; int voltage_mv; - struct regmap *regmap =3D charger->regmap; + struct regmap *regmap =3D chg->regmap; =20 regmap_read(regmap, MAX77705_CHG_REG_CNFG_04, ®_data); reg_data &=3D MAX77705_CHG_PRM_MASK; @@ -365,28 +365,28 @@ static int max77705_chg_get_property(struct power_sup= ply *psy, enum power_supply_property psp, union power_supply_propval *val) { - struct max77705_charger_data *charger =3D power_supply_get_drvdata(psy); - struct regmap *regmap =3D charger->regmap; + struct max77705_charger_data *chg =3D power_supply_get_drvdata(psy); + struct regmap *regmap =3D chg->regmap; =20 switch (psp) { case POWER_SUPPLY_PROP_ONLINE: return max77705_get_online(regmap, &val->intval); case POWER_SUPPLY_PROP_PRESENT: - return max77705_check_battery(charger, &val->intval); + return max77705_check_battery(chg, &val->intval); case POWER_SUPPLY_PROP_STATUS: - return max77705_get_status(charger, &val->intval); + return max77705_get_status(chg, &val->intval); case POWER_SUPPLY_PROP_CHARGE_TYPE: - return max77705_get_charge_type(charger, &val->intval); + return max77705_get_charge_type(chg, &val->intval); case POWER_SUPPLY_PROP_HEALTH: - return max77705_get_health(charger, &val->intval); + return max77705_get_health(chg, &val->intval); case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return max77705_get_input_current(charger, &val->intval); + return max77705_get_input_current(chg, &val->intval); case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: - return max77705_get_charge_current(charger, &val->intval); + return max77705_get_charge_current(chg, &val->intval); case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: - return max77705_get_float_voltage(charger, &val->intval); + return max77705_get_float_voltage(chg, &val->intval); case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN: - val->intval =3D charger->bat_info->voltage_max_design_uv; + val->intval =3D chg->bat_info->voltage_max_design_uv; break; case POWER_SUPPLY_PROP_MODEL_NAME: val->strval =3D max77705_charger_model; @@ -410,10 +410,10 @@ static const struct power_supply_desc max77705_charge= r_psy_desc =3D { =20 static void max77705_chgin_isr_work(struct work_struct *work) { - struct max77705_charger_data *charger =3D + struct max77705_charger_data *chg =3D container_of(work, struct max77705_charger_data, chgin_work); =20 - power_supply_changed(charger->psy_chg); + power_supply_changed(chg->psy_chg); } =20 static void max77705_charger_initialize(struct max77705_charger_data *chg) --=20 2.39.5