From nobody Thu Oct 2 20:46:44 2025 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013034.outbound.protection.outlook.com [52.101.72.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD452DF12C; Thu, 11 Sep 2025 08:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580308; cv=fail; b=Av3CY1ywBPnwdb6lWR9MCcHax1QRqIaP++MwKNG2m8K6KGFDs0pORJyibexzbmBdPr3Qcx4H0K+0KJzk3kSEzCIPTlAebVzPLLxM72L4y/a0LPfQb+Pu1DY4nkXTLToBGWRuV5C+DLkj6zujIQSAMYyAKkFyQIXL3H9yVOzC8wU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580308; c=relaxed/simple; bh=vnNqjrorFqjiYR0OEX2t6f7x5OyXLa4flu/HsqOKNEc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=eFSdjM/5t0sEVTJQnyZ/ETxIdC/TkBEAIBSvgWmhLfVC/ZddDTI0Jv/o76ofyMX5Ytng27zPICKos3s+fsCAvGci1wTzEGCH5rzWP6WureS/QfsRS0DVphn++YaGssXwKSjYA0Goj+O9X3vSRRhzWWh1unVCbU1TmgLubL+E3wg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=XQPc45gU; arc=fail smtp.client-ip=52.101.72.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="XQPc45gU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gTM3O2Kgfo/rp8UywOWVY7lJ2dZj8TTxmFlq1CSAJ6L52yVWuffUQxg54viq/vVvuVEDbX7pHg1fXBV++bwNaeACKxAfJt3sCb/SbivAVGwFlHTlFUOdVppuIv03VlejAQ0itdgCxxwKXFsKffVBVVl04WGXTw+FcsPL9Zg9Gsr+dFdd5mcuITjEYDkYijzYEQTePCWcTKUkS5SLxIGFXcma0qO8fkr3LL9dqP7vCyjew1f+ixqGO/eUnzJUnO7Pc7In+grSzNUfCwy0TTu1en2IBB9zDylgvddV0VJOa2pLixKeWEY2nBAdaXX0l3pqnNdQjFO6gOKEw2p2NsPSgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6k8N54HFsrN90uPIvk4JVBaqu9mWtjHVkVARcU7n588=; b=UX+lZ81g9KXeVHitbzLfeIxVRWTHv//s85uVasuw6qzwxtaoWQ8y5cdHu9Zif3jzutuJ31EGattSvJrOGiz2KtLRHgMWl5TFIZEZ38dKYJJFrVIJJCtPGdRh1nLx5CRTXv3lUeYu+09a1zRh2iWC4gboh7gyFuXyir2KA3vW0SaaO1LGniZK//6CpGyQ6dScjKsAxKSqdHZ85brWoqOabWssxwaKbsffdfvye1ftbjsNy+AmwehHdfZ3ajKCCp2fE9nxGuk01/6SkwJ1go+5MafJ1c8NkM4oNIjL4pqcEnPGmbrCY3m2e6qdmC60xYEeW2Jc+Koitu5N2ARLY6UsdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6k8N54HFsrN90uPIvk4JVBaqu9mWtjHVkVARcU7n588=; b=XQPc45gUAfwPrSWm3iAUqj04LKSeGpF9fTPTi69b4hpBOfeR6NJcbnin/uAAeAC9GpgIx3UMT6vHI7Lxuxz5O0b2zu1diSNA3r8DkOIJN4adXYXdaFvjZGmOEmA0ukhoZ4QlbfH42PXh21pJ8VKWDk+WugXBjeMiPOeS4SbzJCp4OQ6OVBTldSf6h/AlB5m2Ap8zsRir4kuXavm4/QACuDW1Gf+KNApkP4UTNlhbtJmvoIa5ZBKlrGOpSlptUQEfxyRW77mhaLKOj3WBwEbqLLW+pnZ2SZ2Evs/KUqixx6si/q02BgXTGKxO4zAvbptSbFMMF6F4wBuPK5zRrU66Lw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by PAXPR04MB8287.eurprd04.prod.outlook.com (2603:10a6:102:1c4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14; Thu, 11 Sep 2025 08:45:01 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Thu, 11 Sep 2025 08:45:01 +0000 From: Guoniu Zhou Date: Thu, 11 Sep 2025 16:44:22 +0800 Subject: [PATCH v2 1/4] dt-bindings: media: ti,ds90ub953: Add third cell for GPIO controller Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-ds90ub953-v2-1-03ee76eb6b59@nxp.com> References: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> In-Reply-To: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757580308; l=2656; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=vnNqjrorFqjiYR0OEX2t6f7x5OyXLa4flu/HsqOKNEc=; b=WSZI5upBwxqQ7lr7MIn1tYlYh/owR5V03FPfO84lPywII/ZngDkPOqJ9ccWZbVh9WSvOQ5U8+ qSlis3jK8fDCKB6VmSKTyezEvaQ6i3R3hyRAv9209+nRrmLf3Vrr3gv X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI1PR02CA0026.apcprd02.prod.outlook.com (2603:1096:4:1f4::11) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|PAXPR04MB8287:EE_ X-MS-Office365-Filtering-Correlation-Id: fa33dbe9-98b8-466e-2a0e-08ddf10f7ed5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|1800799024|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U29Sak9ZUjJqZVZURU14S3ZkQkwwTzdwdWhUdDQ4VlJzcjR2bU9KbCtuMi9w?= =?utf-8?B?cjVoWG9lTzBnYjlUeWd5bzRIM1dwWWUzY1h1TWZDYVhCbTRjSHZqZURIdWR1?= =?utf-8?B?ejh4ODdlaGI5QmZWSUhUUFpJWGFiVlZPcWFLSkk3elhodVU2d2RPS2haSi96?= =?utf-8?B?eGxoM05LKzFDUnZSREJGQ2kyRW5ZaWQzdVRzWTF6b0UrQW9FTG9GeERidXhs?= =?utf-8?B?ZFMxRUx3TDZwRS9TdEc5Vm12TjErU3h2NGNOTWV6VFNQZWwyN3h3TnNZbmE1?= =?utf-8?B?T05iVE45MmMyWlY0aTdNVnE5T3hJOCs4enhTT0h3UmdkK1QwNDZFc2RHbmt6?= =?utf-8?B?ak5qRGpxTkRyelhxaGszN1BTclVmRVgvL0lNbkcyK0M1eGRkSGdPMjQ0SFYz?= =?utf-8?B?ZlVWK0EzaFducVJudUMzendya0RNakpTUG1UVnQ1eE0zaUdMdjRCNXMvRE1S?= =?utf-8?B?QjE4NzUyc2kxYmlWa2hlM1RtY2VlN1BWUTNSSDRpL1krRGlzNEVnYkc1bkM5?= =?utf-8?B?L05GbjFZVERkMlNjNTltVCtOSjdKQ3dMeXJNa25GSVpJS0cxTEFCNDJkb1Jy?= =?utf-8?B?d2lXNWllT25hSHhHOVMrK0o2ODh1Z2daSWRaS0dtVzhHNlhidDFQTVU3R0d3?= =?utf-8?B?SDFxZUhIU25ncmFPZ3pCUFhsRTZIZWdycE5zSXVOMnI2bjcvMUZ4dklBckZC?= =?utf-8?B?ekQxQVdEM2E2Mk44QUFyR0RlaTBIb254c0hjZzBUM0JKVkpwd3oyQ014aER3?= =?utf-8?B?V29qTGRLa2J0clBVOTZHdDJOK01XSHlZelRsa0FhNHZsZFhKZWxNVThlYk5E?= =?utf-8?B?K242NnZRNVo3NXMwV1h1OWdWTlgwbG9RTUFRenVMWUpQbFczZHB4YThFUWpZ?= =?utf-8?B?dy9OZzFLeExlZGY3RW9pRmpPTmxiTWVMYUcwTUdIREw5cGJmTnpIbnZxYll5?= =?utf-8?B?eFRwV09EdDcxWkpxemszalhrWWZTKzhmeU1ueHVmdnhNdzFsMStzNTM0bnFw?= =?utf-8?B?c0RZR3BXZFUzMm9WRkRSVlQzaHIxZUsvUnIxbFRDNk92dkljRkNlb2kvWVBl?= =?utf-8?B?OHJSME1KdHMvUnd4VlhCbFRFQVd0dGYwZkZWbzMvSS8zaHdvTXA0UHRxT0xh?= =?utf-8?B?c1Jnd3E2Rkl1M21iYXl6bEZGWTc1UkR1Yk9kTnhralF2aGduNFpxYjIwWlpk?= =?utf-8?B?OFRIbGJHSlF0TXVXRTgrbUhkaHlSVU03TThJaEFUYU4yNmhjVmJJZjlQWStW?= =?utf-8?B?cVVGM01NcGwxMmc3WGlLMkNMeHhOUU1jaUQwT2ZEU05Kc1VrUGorSkFHV1Iz?= =?utf-8?B?STdpUHQ2OEg5TEFIREprcy9KWFF2aGlJY0kxQVE2YzkwNnlsYzlvUTVyQnpS?= =?utf-8?B?bTFReTNab3pwamovQ0ZNQzFQbTVtV1k4T0RSdWJOV2xTekxidkZiRXpDZFdD?= =?utf-8?B?ODZIcTM4d1NRT3pDcXJlY1ZzZEcxT2hWdnFmL1dVZFpONzk0aTFvTlo3NWNX?= =?utf-8?B?b1RweWp0VTduTVE3SXV6N2JSMmxBRWI2NFJFVVk1ZzdRNG5LdEsyYW9ncU85?= =?utf-8?B?VVBHSHpySHQ1SFcwbDJkRmZUZ1BiUUp4QzcrdVJPYnV4YWd4emtodWZyNjdB?= =?utf-8?B?dVI0ZWZMUHBOcEZpZEZHUXpnMFZtb0hVdU5rUXJaTHY0QUFwTm5GU0JocUlo?= =?utf-8?B?dzQwL2Z6NzNFZnhxczhUUkxMN0Y2UTE4MVExY2d1QTQvZkd1SENTdGNUdmpN?= =?utf-8?B?eVI0WEU2RE52N0x4RE1ZOW5BdmtGbnJkekRQbmVDcXlUK04zSlRFSll6RW9u?= =?utf-8?B?clYxUmhHRnZZTGp5d0s0ZDhhVjJMNkE3SXg3TXdZcTVqZnp5MXFBQ2lzYUZC?= =?utf-8?B?cTdqZnpEb283bHZXODQ3ZEp1MVBEZVBlVUF5SDc3dUpKTlF0OGdpQU5IbUZj?= =?utf-8?B?NFFBU2xydmQvbjZWSS9DNEwxUHJJZm9IMXFEU0NreU5qMldvdXpSOElFVDFR?= =?utf-8?B?TVVKdEVsbzlBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(1800799024)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTBVT095MVdqTi9IZDMwYjFuTFArZlI0VEEvL3UzQWxoSWowSytFLzQwelJF?= =?utf-8?B?VWFLeG1wUndzd3NjYkdxRmpFbFZ3Y2p0L21tWGRRaTdIZGlPcjU1V3kvdkNh?= =?utf-8?B?L1o4WmJkdDRBdkpGK0FTWXZZNk9kemVCYnVURm9rZFpTeU1nSitoaEl0dk5h?= =?utf-8?B?aWUvYVAxMzA3c29ReDYxMnVZUmI0ZmVTWXJ5Yjl1VmZieElCZ2FPdEhhZjNH?= =?utf-8?B?Y0duQnl1RCtFRm13bmZxNGgvY2c2eWF4NGNJN1BXL01uQ2Fmc3lqQzVxaW1K?= =?utf-8?B?dE1MTVBWdDY4dU1vRUxJclRMdk1FeVhLbjhOT2JQODFldDM3VmI4U0VzNStD?= =?utf-8?B?MjhNWEJ6UDZUcVVTeG5Tb09xeml1TndGM05rdVZJYjJvbmdNcTg2eVlWUjIx?= =?utf-8?B?OGpUQkxzL25Ha1RCT21oOEF1eGIwRzkwMDRiNTJRcHIxZmpORDYvR0ZuYmpt?= =?utf-8?B?L005Q3JDeitIY2pPRUZJZjFtRFhoc2VVMjBRZEQ0cEF6anJNazJuS0NwRFFm?= =?utf-8?B?a0tadUx0WHRSU09EQjBNb1NSZzZWOWpHcVE1cWJOODU0RkJnRURFT2pPT2Ja?= =?utf-8?B?bE5NSEI5ZkNoL0hrb1dkdCtNN2VJaTZNSGVhZ21ZZVFlSURuMnNmeld5cVJ2?= =?utf-8?B?cG5Wc21BUml5RlE4RjVVRGpYaURjNlBhUmVNRXNuOXlmR1RQYmRkR0R6SXdy?= =?utf-8?B?TytYNGZXYUQvQ2cwZWljem9YTVhhdlF6SlozSWVpejVad0huYnUzZ01ablJJ?= =?utf-8?B?dmxONVBLalVsak1oRGZrS1RTYm1TT2p1RTlVZHJSU2hWRnFmQ1ZhbGxwUDJR?= =?utf-8?B?VmI4Y3RTVnVaQU9YR2NjQm50MWxvSHhxOVB5TmJ6a3VJL0xvVk5iUlNhT1Ju?= =?utf-8?B?b21wbWJZNVlIaEhOY1MxV1AxaE9GZ0dVWlhkcm5wdENmZkxhTk5wY1pMc0I1?= =?utf-8?B?TDdqb20zZnZIMGQxU0pFbkRYRU5lV0RZUkQ1VnN3RVFjRGo3K2RVZDB4NUp4?= =?utf-8?B?dEJ0VHJBdGU1MzRZc3pHL3ZaNS9tTHV4WWRBNU9MMXUrbUdKNzFlV1NDdXFF?= =?utf-8?B?UlZISTNleTBEb0tlSUlMdnpzektIekc4ckl1NkxRamYzVGlWKzZtTmFNY3hW?= =?utf-8?B?SlhaVWJFRmJ1N0s3NC9TRXJTNGUxWVJ5OHZJZ2MrVTgxcWN2MFBTU1lyUndG?= =?utf-8?B?cC9HYnV2OE5GU24rMUJqdkh5dCtKSGRBMkxUZkdnQ0JsSEZIVFJxWHZkakJz?= =?utf-8?B?U2ZIb1h5V2lVT3hUQzBuZWRoVStJSlpnWUs1VXNhRzg3dVFxVVlWOXdrYTA1?= =?utf-8?B?T3dtaE9td3hidmJ5TkM5eDlGaTAwMDFWTkxhK2krSFdRbkN3RWxKZTE4SnJG?= =?utf-8?B?QkxaaXloSWJlUnBJTVJRYjhsTTZCSkg5aXhYRlYvQ1lBRUNYRVh6bEp3SGN1?= =?utf-8?B?WExCbDlRMkhhRytlQjBnZWpOdm1RTU90bHF6eUNTZnluM3lQMlM2cVNmaXFY?= =?utf-8?B?WStDbUZPK0M0aXpPR3dNU2tsU2c5TFl2dUJNNDNFa1ZHVTZCZDdZMDg2M2Ur?= =?utf-8?B?cWxQM3ljUUwvYmNFTFhua05QVkZiSzlsT0ZSMStMZ0hoSmJTUTcwMGw5NUM4?= =?utf-8?B?bXlvN2VZQWppemtaV3p2ZExQUzB3ZHE2UVNZTzdiU1kwUGJZa25qZHJ1Y0FF?= =?utf-8?B?bFcyTTNzUktvakpZVDNSV1lzcUgyUXFGZzVmMG5LTld6TzVCNnJDYlFWajVp?= =?utf-8?B?MVVvTVhlQitMZVcxejNUSm9CWVpIZUttb0Qxc21JUlZkTDd1eFFNMXh5SzdC?= =?utf-8?B?NCtpaDZ2cU5vSUNmMEdyeXRPL0ZzZHFWR3REbjVjbkxaejRaS0lySnArblI3?= =?utf-8?B?U2pxdXVXNE03ZnR5T2ZXUXNEQmI0YkgwWFYrcEdXUG5wSG9TcHZDVXZGWWZ3?= =?utf-8?B?SU8wVjZUVGZEcGYzNzk2WTJvd3lNZHRYY2oxM01TMEVFc1crelh0ZThqWU9O?= =?utf-8?B?eWovTFQ2bllpc1U1c0VBcUk4R2Q0VlBxRmtOOXhxY3ZFMy9LOXYxazd1YnBB?= =?utf-8?B?Mm1KUllOZlJsd3YwKzhmRUxvY1VYOExEZ1J0WDlEeGZjVHNhaURDQ21rejZx?= =?utf-8?Q?oP3GfOAhh6PRkXRkGXu9jK8J/?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa33dbe9-98b8-466e-2a0e-08ddf10f7ed5 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2025 08:45:01.5242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: msWAGYqnKiJtqYbAzDhC1VoDn4L76yRnAw2PBxecMQyRSkh4RrocYg2QX1WDcGy+V3zfl29C/E8Rhc8JqRUDow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8287 Add third cell for GPIO controller to select GPIO output source. 0 to select output source from local GPIO data, 1 to select output source from remote compatible deserializer GPIO data. Signed-off-by: Guoniu Zhou --- Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 8 +++++--- Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml = b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..de759413a36060d3be6f2c3b67d= e48ee6e4d29f2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml @@ -19,10 +19,12 @@ properties: - ti,ds90ub971-q1 =20 '#gpio-cells': - const: 2 + const: 3 description: First cell is the GPIO pin number, second cell is the flags. The GPI= O pin number must be in range of [0, 3]. + Third cell is GPIO output source(0 for local gpio data, 1 for remote + gpio data from remote compatible deserializer). =20 gpio-controller: true =20 @@ -97,7 +99,7 @@ examples: reg =3D <0x18>; =20 gpio-controller; - #gpio-cells =3D <2>; + #gpio-cells =3D <3>; =20 #clock-cells =3D <0>; =20 @@ -130,7 +132,7 @@ examples: compatible =3D "sony,imx274"; reg =3D <0x1a>; =20 - reset-gpios =3D <&serializer 0 GPIO_ACTIVE_LOW>; + reset-gpios =3D <&serializer 0 GPIO_ACTIVE_LOW 0>; =20 clocks =3D <&serializer>; clock-names =3D "inck"; diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml = b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml index 4dcbd2b039a58edfc57c5cc0bedceefdf158bf0c..4af5e0e3b413a64a4b61344f1da= 63be7e02a1af8 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml @@ -328,7 +328,7 @@ examples: reg =3D <0x30>; =20 gpio-controller; - #gpio-cells =3D <2>; + #gpio-cells =3D <3>; =20 #clock-cells =3D <0>; =20 @@ -361,7 +361,7 @@ examples: compatible =3D "sony,imx274"; reg =3D <0x1a>; =20 - reset-gpios =3D <&serializer1 0 GPIO_ACTIVE_LOW>; + reset-gpios =3D <&serializer1 0 GPIO_ACTIVE_LOW 0>; =20 port { sensor_1_out: endpoint { --=20 2.34.1 From nobody Thu Oct 2 20:46:44 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010008.outbound.protection.outlook.com [52.101.69.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04692E6CBB; Thu, 11 Sep 2025 08:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580312; cv=fail; b=Q+rZAduzZ4Ync+oYrjEa1wd7lwgStT+gtiAo5GPnx35Oq1MwTazILJoIPvPbF/rR7KVxXrS0cI4MVH9lMgmKfP1HrVpKp6D5iUPQ7Ptify8I/6uMT8+WsejzZNwehuFlzn8MtClxngL7YMzgqDmvyNdFBqTtCwrh6HEDqRt0kFc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580312; c=relaxed/simple; bh=PQ4anAdu8DeRWFAbeRrMikCJtLcI0q/L0HQepJU8h8I=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ho9oilgVLqksRFz+HXSKss+oMA5DkpWIohn9k3pIyfnsLOhvB67tzvbI8iOFP41rFFEEL5Ud2euNbpTL4JMj+ge7PIZx80+yAq8LTJW/GimJ9Cq+Ync3fIRg9F6wQNu2FjcVDRieVq87okLFP/qEwIgnlwqCg3Qv6ZIQMIMlE7Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=nySRT04A; arc=fail smtp.client-ip=52.101.69.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="nySRT04A" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dX2QVVcFjgTi+jHl7LSiqyhzDj3ehdoxhjgzY8ujgd1dyf7ZO//NqgStzZHsdWoNwEnXL3T5wUHcudc+OZt6n3lwlENBnUqvz7gCyqq+ASIS1HiZ3s0u8CI5IsUV4fYS3/WmvHmcUdt3m+zqKfZvT6D2UqVDCTaCVExTCZP61fOoVNzs2mV4RASfqMfapzE7Qdzo29dzOQq7s+mz4E1zFJTZwDpzNO1spTuQBxFt+iBe30+t16ToecUUUeRzj1dV4tJKPneW2DB91mtsXS6TF5VP8geHIzGbRgRk/a3zncabXiKrQwVgOlqDAekp8VVauE1RH8c1DX3YpMB1iVbj6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NgsAC2eRi/NqCjsHcTE4PpmYKtshhGz0Ea7mzRS1PSw=; b=J02UFwbTeBagcG4synkCeJdkeksrWjhU04UDnV+3ALzWxcLeXO89B822KT0dncqMxtCwjbs3nKJx4d2SwgEpTbag+6Qp9bbhJ6WqLTiEDIGqihP5oNWMxTsaWX0tQ1QDgSlIXq/1ehvP22UyrtwFwI2Tv0yP9/wdnhG2G7zaJuygVHb+Fj3miMhPlKgqLmGe7wJAUCOJHeTTANyrFTZuWFGr88yIIJkhD50/ZAhQGqdeZ3qi3OIdPXA2w0yG4iWOYa6AF0NEUI4WV7NM/1DgH4kGzOd1PUCsWOT5WxCaDXjmwC3VC3ogpi1VvJTWfe7V8sPlcNrMAMHY0Pk3wJG/lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NgsAC2eRi/NqCjsHcTE4PpmYKtshhGz0Ea7mzRS1PSw=; b=nySRT04Ag2ifkGwX1ngL3qeDI9EdbAXqIwFvVnMJwOOEc5VL7VXSwVMegSjtlr953ypv3iu5mrC9P8wvcTbOp2Vu23gRINT/T60bd4qbls3mf4dsKp5GFFYkuJlIlgCOCv8oEMbUgmzlowL/2fW1ZVqENP6hhXcbbIUQxMJvS9rLFO4m7rTg3PCiNPfMEaRckDtLLf7z0qZDvnwkCzi62tDo1lCG0UMOMrF8a4bwOjKF79ZLdtdZdET20RdW4rf56mxW7q/zT8+ueizJ1C99YfpZm8ECjb78F8RGs6zdjFJwM2C8EqKzQLZ6tqLdrC55ObkPHpv1sddg3PvaQYivVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by DB9PR04MB8364.eurprd04.prod.outlook.com (2603:10a6:10:24c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.15; Thu, 11 Sep 2025 08:45:05 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Thu, 11 Sep 2025 08:45:05 +0000 From: Guoniu Zhou Date: Thu, 11 Sep 2025 16:44:23 +0800 Subject: [PATCH v2 2/4] media: i2c: ds90ub953: Add back channel GPIO support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-ds90ub953-v2-2-03ee76eb6b59@nxp.com> References: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> In-Reply-To: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757580308; l=3072; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=PQ4anAdu8DeRWFAbeRrMikCJtLcI0q/L0HQepJU8h8I=; b=jh3peuH9tiSljD+1o3lSSfmUCwNB/YV/PhrwY7tWJxm7TPfj/veTXn6NXMX1H5px5yb581uHp xrBFKFix4KtBA/bp1fdCitbzyJy4jDZVq+XyPA0cQhhh3WDQI6p8dp6 X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI1PR02CA0026.apcprd02.prod.outlook.com (2603:1096:4:1f4::11) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|DB9PR04MB8364:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c84d8c6-2765-4a2f-1bf2-08ddf10f8117 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|19092799006|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFNGSlVyc24yV1JySS9SZUJITzczU0hVRGpBNStWTjl5RnBrSnZDQzZIbzZr?= =?utf-8?B?QjdhaDNoQm0yalQyNEh6WUQyR3FsR0YvUUZBTStMdDFFbTZ4WUo5ODFxS3dP?= =?utf-8?B?Qjcxd0IwZklHaURjb01FMU5VWVp4cEkrY0NFNmNTR2ZIVUNQSk54eUpMem1Y?= =?utf-8?B?Z0R4Uyt3QzVoTmxoMnQ1WURzeTVmNFNUYUV1cVpIY2FReFp2czlEanVJZzFr?= =?utf-8?B?blF0S3J1VlFIL1dNeVJPYzdMVGd5akVDTmtIZDBpelJyMHhrZEJBZVBpTEVY?= =?utf-8?B?YngwNkl4cW8rNjVWUm5vWGxqUlRyNzFjbXlLVUJzY25iS2JJZDJQUUgyeHJ2?= =?utf-8?B?M1NJV0lYS3huRmg1RUIwdjBtaTJRcElNVTBRNExiQW1xTHF2RlFlQ2luQ1FS?= =?utf-8?B?QnVwaXJjVWFSZnNwaWUzcDBJR293d2FxdmliWERORklZUnYvdkxmZWl3ZWlR?= =?utf-8?B?Z2xJRjJiZTVZOEFEOXhtOEI4ZVFIR09KOWRCb2xXdnQ1Szh0dmNOWHg3ZUQw?= =?utf-8?B?bjh1OERMTUtXazJqVWJtUklKR1YyTlMzdyt3em9xQmtmNXlTcE5xYXNLNGwz?= =?utf-8?B?S01tYWVrSW1UZmdQbHVwaU1EWnd5emtRZkxaTVdoR3NGUlJwMjljQjJYMTc3?= =?utf-8?B?OEdzNzF6dmdJWVlpbWkvcW12MWptWGRzK0pBT2N4NFE2MlNySHU0UEFKT3lF?= =?utf-8?B?anZ5alcvMW02UGZBbHMrR2I5MjM2aVQweTNYQjZ4Q2JkYStjWmp4OW52U1Y5?= =?utf-8?B?b05VL0pOLzIwWVlEMXdwNktzUkRGSDA5STBIMnFxY0ZLNGNlSDBQdG5zczMy?= =?utf-8?B?OU82d05xWFh0YzF4T3FnL3pNUmNPZjZNN0xEOG5Ca0lwNGNpYnhXdm5MQncx?= =?utf-8?B?MjRDNmswakROejRQeDl2bjJ5Y0dLejFFMlpNRUdRQmR4MW82QnlsQ0JNZVdx?= =?utf-8?B?SjRGZ2pKVDRsdk1tZUtsOGRZVWxiM3JVVEJ6WmlJakoyancrR0R3WWlCVG5Z?= =?utf-8?B?UjhaWExzbzIxZWRPUi9iMGtsUjR2SE9HNHNJVEQyRzF1dm8xZXA5UWExdzhj?= =?utf-8?B?Sy9wVElrQVE0YjAwV2Vzcm1sMW52NUt3dkdDSEtJNkM2ZWlwanFvbnJLeHZX?= =?utf-8?B?Y2M1b0tPdWFPR2xpcEMxTEd3VjEyRHFXaXJ3L0pIVC8zSmdLTDg5eXZrYnBx?= =?utf-8?B?blk0ZlR4NnBWS2xEdkIzb0Z3Z0Y3cWt5aHVjV29PcVhNZWNkTlV6WG1oRTNV?= =?utf-8?B?WVBwanlnZzZjUUd0WkhZMVRWOS9VN0FkS0ZBU0c4MXZQZEtvZ1BiU1U5L1BX?= =?utf-8?B?TEZKZERUQUlJRU9sMXZ2WUJkTCtMU09mRFRlbUk5UHM3c2VWNWxxa3lKUis1?= =?utf-8?B?NGtUYXIvLzNIN1hCZUQrRjd3SGowZVpMbG4vd25kK0U3ZTM3dUcveElHdU93?= =?utf-8?B?cFJkc1d0UW9LY3VQNWx3T3JIN0JaWUphU2tOdnhxbFhwS2pCNXJHRlRFa0d1?= =?utf-8?B?d3hNSmpnZHRKVmhFMTZjdjBSaHdRc2hrMnpEbEpROGlYdVR3MThyR0o4cTZp?= =?utf-8?B?VjM5SEZDN1FDQ2k5bVZUd092TFpCWHhxQVFqVDJJVjRoZGFNSHhvU05BeEIz?= =?utf-8?B?bk1ydjBzNGU5Zjl5cXF2S1Npb0Z4cUJIMlhoY0tkWk4yQTFOVkhKUGh6ekpF?= =?utf-8?B?QmxUWEdGVnhlKzM0RXh4eFR3YUVMeUtVZDRJQ1hHeVU0a1dtd25lNlJmY2dO?= =?utf-8?B?d2lVTnJ3Z0hteUc4Q1I5SU1vaXdUK2dscjRkbWM0YUNNMWFPWnpnK28rK1NV?= =?utf-8?B?WGViNGhIak1HaUhkNmU3UWVTa0VCTnFIakV1czU5aFpORE9LTHNiKzlxQWY1?= =?utf-8?B?RnJVSGhzSHU4N1JNVUI5eThicVJHekxFbVF1V0NiT1cwZVhPMERKaWx5UHAy?= =?utf-8?B?KzVZWnc0V2RXWUVNRXFlNDMzbGdmRGVVakxkUklKK3FPWnZ3NUMzbFg0eWZN?= =?utf-8?Q?YBcDtwZgivjmPeJfRqbaQoPCUOa34c=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(19092799006)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3EvSDdTN29zL3VtdmpaTXVxOFdRUlpXbDF1eVQ4Y2Zrd2ZISXAvRUw0eldL?= =?utf-8?B?N211Wk9rOEFON1lHT2lRMGU3RXZpU01HUW5yR2p0TjQ3R2FrOC9udGE4bUNm?= =?utf-8?B?QWc4TFJuYklHam8rQUVTdnVKZFFGSUxCdExxMGM0aDRXajR3U3Z3MmE3ZkVX?= =?utf-8?B?V3A5Z1owenVUOWVTTllIYmJnQmZta09ub3F0OU03SWg0SU1lMnZteUp4ZlRz?= =?utf-8?B?Z0pQNndycHpuN0x1TjlBam56Kzl4dnRud05tWDhManFoMm1KdkhXMjVZdTMr?= =?utf-8?B?ZlFPdHlKald5VUJXcjE2R2R3Ull6eTRIOWg0T1p0MzF0TjJmbGJnOS9CbTEw?= =?utf-8?B?VFM0U1NyMlBJbllnSWdRd0Ivd1VJN3hpcUkxN211cWl3eC9qUnVMeEVqdzla?= =?utf-8?B?b3BGZjZYSjdQNGtYaWdhWFdZQWJObzBQVHM4RDdBRGo4VFBhcFlCNkJaZWhD?= =?utf-8?B?QW1NMDJsV2Y0bnlGNk4raWQvUVI3UGRFdy9BT3BKSHlCSzFreXYyWDJhcXlk?= =?utf-8?B?NjZ6YXh6WkVXUFEwOHhHSGNlQ2hpNjh2dlRzRElXZFNqYzRRdWoxamF0MmNx?= =?utf-8?B?N3F5bXRWTWI4WEczdlROZDhlWVNES2NwWnJrS0hJbUMwaC85TVJ4cjltUUFI?= =?utf-8?B?aGdGY3RPZGV2a2haVkM0SjE2VzlROTc5anFMVWhVUHJsV05adUpJa1FyajdK?= =?utf-8?B?bGNjSEZFQlhCMTg5bStENW5BbldhVXhxdU9ONmd6TnB2ZGZRNVdQejNCbFJO?= =?utf-8?B?clpqL25KYm1IYmhJdE40UW1HNkI3VHpXSWYxWE51alVUcG1sMUx0Ymk5V2ZD?= =?utf-8?B?NmRUQk9hdWhzWGtxbzZkUUNtQW9QRmROejNiVy9WNThhZWVxM2wwWUNhWGd3?= =?utf-8?B?VnpJdDEzN1Bxeko1RmZhdjI5eDZvZ3l0WWpjcSs5ZjVoTE41UW5pUk45c1Rz?= =?utf-8?B?dXd5TlJNNHpTN3BFVm10U2lzYmd2cGJ4NkNCblB0RkFXdlByb2RUQXJmT3lE?= =?utf-8?B?RHN5WmFBcUYxUzkzblkzODMyeHppSThJaG16YUZLamtoMWVRN0h2NlFFTzdQ?= =?utf-8?B?TTl2SUtiS3hkMktqQ2VuNThtMG4zUk9BdVZLeHpubE1qa0F6Y3RmRlBnTitX?= =?utf-8?B?c3NpNXdzbTdHdXJGOWdtL3A0Um9hRGJhTEIzbDVDZkZYQklMWFA5QmxsS0NE?= =?utf-8?B?ekJIL2I2QmlpRDFJSlRYVjd4MU1wbndkTTR1ZjFyYzVPRUlCMCtrWHd1cThS?= =?utf-8?B?ZldkSU56SVZQREtaZnRaV1Q1KzVxdGJWNDYvT1BPYVVwaGtmdDVDODF6eks4?= =?utf-8?B?QlpMck1TUnNmb2NQcWlIUEZHZmtDT2dzTllVWEFwcTB0WE1FS2MxcjhoZ1d1?= =?utf-8?B?R2xybDJOTmFnL0N6TFFtT0g2dDFNTjg1dWRmWldrR21BdHpuSFFJWlI4blQz?= =?utf-8?B?OEhTRituaTM4ZENlU3grZzI3TC9scldRYnRLRmhHaVJBa0cxd0RzV3pZRG5h?= =?utf-8?B?TzFQdHFBbkU2WDhFOGxNcGg5Z0xNVk8vWk1ydGllWCtnTUMrbkxLU1VQaTBr?= =?utf-8?B?QkRkRVdKTEc4YTdMUnk3U3hCL2VFWnVnNDZYYlkxT01zUXVOU1ZwTjJVWmNu?= =?utf-8?B?WGgwZ2JYbWlQdCtMc1FhNG9LMFVDNkg5d0s5L1lCMVp2REhoU2czUXNMb1lj?= =?utf-8?B?NFhhalcvSDNYWWV2UzZhbHR1TUsyQ0dBVmY5N1grdXcvTWR1Q1BidHRsVUlr?= =?utf-8?B?dHNCK1BtVmpObStzVnpvdHFsbVhvSzdYYVVmYXg2VTV4WnpncU96THRVR0s0?= =?utf-8?B?VXV2NHRJZlNLRVV3YXEzK21PUkNQcFpxb1ZhUVBVOXBOcnpncHVIWnpJdlpu?= =?utf-8?B?RFZnZll3YjFMRHJtL2VVcDM4ZlBSeENBTXpCU01FcFRLZTB2c3VZblhucHFa?= =?utf-8?B?aHlDaU9sZ0cvOWxFRjR1L3ZsZ1JJVzdUUUc2SEdPYlFKbm96NDFmdGoxZDh5?= =?utf-8?B?UnB0ZXVTRDlQZlNxK2F3U3JsakdnclpMRDZuWmU2S21wSzVXVCtuZGRmeXpE?= =?utf-8?B?VDhBajQzOTFiRnFHQ29lYXY5Tnoxd0F4S1BSRWNnRVluWERrWk0yUkZDZG8w?= =?utf-8?Q?XHYKcPlswv0KYC20fBTVI4tpN?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c84d8c6-2765-4a2f-1bf2-08ddf10f8117 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2025 08:45:05.1133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9t+86POMjs1H1MNo6XjCQ+7i+8mGI7kOtPCvPIaR3INW1gSGOYEHraYY/Qr8kGrelpBuagTDI4ROl9sYfFq+7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8364 The ds90ub953 supports GPIO0 through GPIO3. When enabled as an output, each GPIO pin can be programed to output remote data coming from the compatible deserializer using the register LOCAL_GPIO_DATA[7:4] field. Add third cell for GPIO controller to select output source. Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 32 ++++++++++++++++++++++++++------ 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index e3fc9d66970a762d284955f14db48d7105b4b8c4..274972cd21f9f0facd5098b724c= 0d6c661ce95c2 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -71,6 +71,7 @@ struct ub953_data { bool non_continous_clk; =20 struct gpio_chip gpio_chip; + bool gpio_rmten[UB953_NUM_GPIOS]; =20 struct v4l2_subdev sd; struct media_pad pads[2]; @@ -288,13 +289,17 @@ static int ub953_gpio_direction_out(struct gpio_chip = *gc, unsigned int offset, int value) { struct ub953_data *priv =3D gpiochip_get_data(gc); + unsigned int val; int ret; =20 - ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), - value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : - 0); + val =3D priv->gpio_rmten[offset] + ? UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(offset) + : value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0; =20 + ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) | + UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(offset), + val); if (ret) return ret; =20 @@ -320,6 +325,12 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsign= ed int offset) static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (priv->gpio_rmten[offset]) { + dev_err(dev, "GPIO%u be programed to output remote data\n", offset); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), @@ -330,10 +341,19 @@ static int ub953_gpio_of_xlate(struct gpio_chip *gc, const struct of_phandle_args *gpiospec, u32 *flags) { + struct ub953_data *priv =3D gpiochip_get_data(gc); + u32 line; + + line =3D gpiospec->args[0]; + if (line >=3D UB953_NUM_GPIOS) + return -EINVAL; + + priv->gpio_rmten[line] =3D gpiospec->args[2] ? true : false; + if (flags) *flags =3D gpiospec->args[1]; =20 - return gpiospec->args[0]; + return line; } =20 static int ub953_gpiochip_probe(struct ub953_data *priv) @@ -363,7 +383,7 @@ static int ub953_gpiochip_probe(struct ub953_data *priv) gc->get =3D ub953_gpio_get; gc->set =3D ub953_gpio_set; gc->of_xlate =3D ub953_gpio_of_xlate; - gc->of_gpio_n_cells =3D 2; + gc->of_gpio_n_cells =3D 3; =20 ret =3D gpiochip_add_data(gc, priv); if (ret) { --=20 2.34.1 From nobody Thu Oct 2 20:46:44 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010008.outbound.protection.outlook.com [52.101.69.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82D9C2E62A2; Thu, 11 Sep 2025 08:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580317; cv=fail; b=mRMbufFDqwLdWnrcyLSPlOOd+cbzYg9da2PpcfLE4PlGOR6iGSDI/HLFRDRLfivKuhAWw3phfyx+gVqb9pMyrqimMkk67xfgtxcg7wL21nnQyiaTJ4UgOQiSx8gV69ApPvbshmgunTOCNi2Saismd01WT2BB6Dh2teELrePnZOY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580317; c=relaxed/simple; bh=w2c8Y7FuxRigBktjcQpe6gkFVu1Xme2NhLcIrOO4bnU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=LhDh7eGmPsNqDxmPKk2tLZOka35giSsYKJeu1M5lqT2Q3u/x6y2H3MFX2d4Lbv7aDNKUPaMniBWOW+24MnrEEbI+x2WJg+18KLXnevMbDMyVnlfOLupeJtufu64bLtB0pBVzWS2d4f5yr5m02zfgOL//7YTTjiVSVJd/bcSREj0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Rqrtcfq/; arc=fail smtp.client-ip=52.101.69.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Rqrtcfq/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ECEnMrJ5QCQgITuS62pIefnUuLCiYuo1XeCTpEdrpvAL2tx+A1wswbJpMagb5jGqVhLkQh9xDPPqq2Uyr5xrlcCg0BH/iqWoOEwRkVe3a7/ccm59WU+04P/NPSS+dklBwD2aVWHq9jRe2mB+m/e/h4JBwOWjSZdveD5lCbtTzjS8VQgCrZr0u7oqZ//TWUk2lRlj8Q4lhXjTBZaHvXDpR5ux2OY5DRiFTCVya5CvgYp2ne2DkQCzXLb4IlFzWBK4K7Hz/7/m5Z97nYV7nnOAZltB2a1vYTCdGxKLkXn90H0uPeSr5IKyBp5EpT3HeWZMae4goqAYZkN7L87ngBulxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDszbDrizhEfgYsvRbDSVnIiheerjOyeqd4WFktKZ5Q=; b=eO4nB2OzsRMITQkKKqnLLFIgVfe71iR+IIDFo5/Ox+CILV01ZyNQvWzSjjVUq1P/MGm95utPhCN20M99QTX54Yio9SQ4mwE1IMtPjHHH2Z7JjoRxr9DHtidvUFJXTQFhY8lEKl1+kmiXJxcd1VxayiY/MhT5lPHxeVVPihZJ2ZKfe2tUiDzHi0vrc9hTw/MKBp8tpUV6hUtMKbrVjov8CqfdI0DRqur1dQHLOKBzuZzbyrRHJH6i3z9od+a82BKNmm0pLkb2ye3S8QiUH4ePBUbhZqCjm+jFKTWYBvBud1tsG08IBhsO5cQfaOT4HzeyaUoRajWvp3NAXcPn+9dYAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDszbDrizhEfgYsvRbDSVnIiheerjOyeqd4WFktKZ5Q=; b=Rqrtcfq/PlUeWQJIinvao9oPHtaeqW9KogBntTFS3BUZGL2h8bZ5WQCSkkMWm9A0smu1C+cxX+kO3+FbFRy3lVK2EF7PLDSq7l7ACnUvvHBJ+iTdTKhxWfVSK1G6iph4S7Sk2OqV3sGFMR7BABN4VJONKLPaSlWjZGqVRSmNVbiaQ2D7mfpUAIPc71lliaFAcF0vov6Y3TIliEJ20UJUSRSvqW5psHa7qU58i0yCKCPdGveG82vjyQWrxRaDfhnsXXJsHlQxyzAdIzb08Wac3dQYtl9yyvfKQDhpOTvtK6qB5vV4NETHWU95es4n/pyb99gmedBm625IZBE0ZCvkLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by DB9PR04MB8364.eurprd04.prod.outlook.com (2603:10a6:10:24c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.15; Thu, 11 Sep 2025 08:45:08 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Thu, 11 Sep 2025 08:45:08 +0000 From: Guoniu Zhou Date: Thu, 11 Sep 2025 16:44:24 +0800 Subject: [PATCH v2 3/4] media: i2c: ds90ub953: use devm_mutex_init() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-ds90ub953-v2-3-03ee76eb6b59@nxp.com> References: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> In-Reply-To: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757580308; l=2586; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=w2c8Y7FuxRigBktjcQpe6gkFVu1Xme2NhLcIrOO4bnU=; b=adA5IdXu4LI8WCIanuWJC0d4tmzA8bs/bgGFowcDsf3+jVal4/l/S7UldkTQAABhR211iwTQ1 JPxAKyG479FBUy/eWf0Sl989wXQSMNZTqGNEe64wWPQaguHPiMBrCJo X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI1PR02CA0026.apcprd02.prod.outlook.com (2603:1096:4:1f4::11) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|DB9PR04MB8364:EE_ X-MS-Office365-Filtering-Correlation-Id: db0bde3e-b5b8-4aea-cba4-08ddf10f833e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|19092799006|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MG1sYUt2aXF5cUFIQm96ZTNISE1GZUt4eEFpb3pKR3pvYXBCK0lCYmlyOHhX?= =?utf-8?B?YXhYOUhFYmdJVFUrem1UTkNEQkxiZWVrUkdnS05PSU1jN1VvZkpkQ2hYazVZ?= =?utf-8?B?c0VWWmhHc2xpNU1DTFFTQmJ6UmRuNU1sKzlERHRIZUYrK3c1MkVBMlFqamhr?= =?utf-8?B?Z1BWZDIyV3R4WnY2WERUTDcrWlZBdk55ZGFZMWJkUVljaFBQSHdUQTdPZ0th?= =?utf-8?B?QVdIWUtQcjNWVGwyR21GSzg0dksraE16TGZpOG4wN2Z1LzVUdXZwWmh2Qi9a?= =?utf-8?B?emFiUytyMjdkY3Q2VGE0alhWUm9UaVc1TDdjY2daQ242d3ZWR09vaGdhY3gr?= =?utf-8?B?R016VHV5R3FsOFZhNTk1b21mU3kxNHhyYkhTbzFrZ2hpekEySnRBQ005b3RB?= =?utf-8?B?MEdFVURza2JNcUs5YlRhQlBvUnJtdkNwd3FES1pWYXdKY2toV3JKV1ZyZndF?= =?utf-8?B?Q0Y0djJTNWQ5S2lqeTF1cU9iNkVKdDM3ZWxYOGtIU3B4aDZZdld6UUNNS3RM?= =?utf-8?B?Q3RtdEVHdGtLVzlPTHE0UDNDdElsMGZkMXU4bVNmZC9qZFpXVWEwV0NSNHAz?= =?utf-8?B?eW1YUytpQ2k2ZWZKQy80SUFHMFVidjBTb3BDVmxrMVI4SnhnVzNNUjRrZlVa?= =?utf-8?B?V0s5cmFYOGZDSGVSeEdWOE02Q2x4ZW5jMUNrYmF2OWs0bGQyOFZQbW5BUjlm?= =?utf-8?B?SUp0NUtjR3FYOU9HVmJMc2NRWGx0QVBwWG5wcVdyTFYrRmtINC9uSG5OcXVW?= =?utf-8?B?ai9NNnc2MEF5MDBpVEphRTBKa1FKd2VtRnErMkFqME5TY1dtZUJxZWMwWnQy?= =?utf-8?B?eUo1MGRHK2dXVnB6WVNkV3o2WVdpc0ZYdFpQRnlkekRZZitoNjhiTjg3eHJS?= =?utf-8?B?UitGRWVzakdPM3J3WlZ4R2RqeVYySnN1WWJYaE44TW5DbHEyVEMyQ2lTZlo3?= =?utf-8?B?Uk5nVVZ4cVdiOG4yZDdiUElzTTNjTXpsUlNjSnNjT29ER2d4d3JlT0FyVjR4?= =?utf-8?B?aTVhMkJLd1lnSHVtOXlJVXBEcWRjb2ExKzJiczZsMmZELzRtVXRGU2ZwNjNx?= =?utf-8?B?dDlZenlSejlOMzR4b0Zsbjc5Z29qTUdvRWdNRzd5amVRaTdqQWNvbXowSlVD?= =?utf-8?B?SU1QZWQ2TDJYTisxQzgyMFhlc2NidWZldmFCbzFMNFVaUkhYRUhGM3VVTVRh?= =?utf-8?B?VVg0U2FkMHU0NWxLV2g0ZnNQVExQOFJKVU5HY1N1N2E2bGZmNUMyR1ZVTEox?= =?utf-8?B?SDMwMXB5MU1HVGJmMGFJL0FWUm00UkRwOHRKVXVraEVrMTgxSWphSDY1ZlQr?= =?utf-8?B?VVQ2eXVERW5wcURIbXFJQjY2L0VwVnlOcFRPemVnSUtGbnh5MWhnTTBmUmd5?= =?utf-8?B?aTE0RjBOcmlYdG4zNXE3WmQwMDNBa2FLOFdlTzZTSGhRVmt0UlluclZhTG9n?= =?utf-8?B?OU82djZCR0F1cFd1UU5SYm1ZN1IwNmcxcGxhaEpOY2RIZjNRaEhYdEt1UVFL?= =?utf-8?B?VUp1R05abG9mQmhpNEpiaWVWRDFmekVBS0syRkxGdmMzN0dJL3JNckxGbnBs?= =?utf-8?B?SFhsT0NaemZzR1VZazVmWllhTnVyUjdFZWd3TEtmRXpQbTh6ZG5XcFRxZWZX?= =?utf-8?B?ZW5UVVdnQ0RheTFKdjRDQXFJd2JHYVRMeHc0WThiVVRuYkUwc2U1b0VqUHlN?= =?utf-8?B?TDhRNWxyWjlMNTgySGFhQUt4dkpKV3RIUXArOFluQkNXbVdwOGx1M1g5R2hO?= =?utf-8?B?M3oxNGJ4QXZ0eXNiWmV5K3p0ODhia3RTeThaMTBCUldDTUU2Z1g1MHJnZTVZ?= =?utf-8?B?WkYxMVVQeU4wMFN3d3JNcmoyVUFOd2k3TFNXbThhMXFXbmdaQzZhVEszRnN3?= =?utf-8?B?UllSQVNWQ0M4RHZCaW83UVBBK3E5RjREdTBabzRBcWZ6NkxWQUhDL1ZpZE54?= =?utf-8?B?Zi9ZOWlMU293TjhXSEl5NGxtR3hXamdBeFVYdUJ6U1ljY2dIaDFzS055Q2lr?= =?utf-8?Q?gI1VSm8gbDuPbcyEd89KsUKUpxhBCQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(19092799006)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkdNaC9wc3QvV0VQVE5WL3VabkJFZ3lJaE92eUt4TDB4eEJFYm03U2UrUlpl?= =?utf-8?B?NWltaWR5aURvbXNIUVNqRTIybjU5S1JPWVNOUUVuNkJaTUw1emxOYzMyVWpj?= =?utf-8?B?dTB1SHJqZTU1WUI1WXFDWE5XNnpkMlJFb0Yrc0YzNzdmMTdtd0UrVUhHc1JF?= =?utf-8?B?TWJwVG9EMmtLSUxKSno4dEQrcHBFaElTcUpNUHhYS05qd242dGk0aGpqN3ZQ?= =?utf-8?B?N2ZTQ0MxVHcxTEdVSDZvaHlTZElnbTEzOU8yZzYxZlNPNmE1eDFDMVJMVUk3?= =?utf-8?B?aTVFRGFwalRKcXRVcThBc3VoS3lxOFcvcnR5KzYrem9LV2crOUk3cFFyT3Qr?= =?utf-8?B?ak1oRlEyOS94b2JMd0Q2SjVCS0dsS3pvekFNWWhnU2xBR3hXNGR3dkJoUnl6?= =?utf-8?B?QmhLZFlFU0xraS9EbG0xQTBBQWcwYi9HQWl4TzFCVklPUW45dktLTDVkS1By?= =?utf-8?B?a1FDWldxMDFyYnp6NWtBRXdxVUtxd09lQ0orOXc4ZmRJNks1d09vNHFJM2tI?= =?utf-8?B?d1JKaFhlTC9lRlVvK3Z4dXFkOEI2QTd3cVZ3emZ4QzJaWWp6S3Ficjg1YlBj?= =?utf-8?B?QVRRM2hyN2NMOUU5Qk0yS3JJa2pCU2dSZEdJSXFBd2tXc2xPV01GTkFybTRM?= =?utf-8?B?Z3NtK0htM2cyTHF6K29QcU1iajQrVEh4dkRleDd3eUhjNU0yYkFHMVJsN3lu?= =?utf-8?B?dm5HZEVyREluZ1liS08rVTc1WmtUbW9ZMFgvUnV1YmduaGsza2dJZGNEMFRS?= =?utf-8?B?bjU4ZkREUWxBN3NJaW9sN01sL2tCUDlXRlo0dVVub0IxMlIzczY5OGVoZVNm?= =?utf-8?B?aThwdVhDUVhITzVMenBDYWNBeHgyUnk5TjZJT1EzbWsrMlpvWDJzRk5OSlRL?= =?utf-8?B?ZURqaTBvYjBwbTZ0OU5MTU92V1VyUmF4azdJTVQ1UFk2MS9FeTBJV2M3cnlm?= =?utf-8?B?S0pHYm0wYlJmdlYzdjJUYTFKcytQelNka1hTeTUvZUUxQnVJR2dhbVcrTmM2?= =?utf-8?B?WEVFTFhMMXBweTlidUtIazk3SDdMaityNnR6cUJBaVA1eHFhYVl6bTgxckVT?= =?utf-8?B?anRIMTBGdWtNcnJTRVI5SWlFWDVrdFFveXV5RGZTNkxZMFBXSTN3YmlsQnNX?= =?utf-8?B?dHU2SWtCL3JrU1llTUtReVF5dzZIUjF0OXVORWZHd3V6UWFQcWU2STBtOVdY?= =?utf-8?B?YTRvdk9OakZQRFlOaC9WanNDOUhVU2FFZ0xlK3cwdS9jbWovMzNFZG9IUmk5?= =?utf-8?B?Tng0OWM2QzllSHRGVnhpcnBCZWlUOHhzdzlKY3dEWGQrQU5LSkwrRCs4bVZx?= =?utf-8?B?Tmw5dXdEeU1yT0h1VFp3NzJaUXA4K1dSNTVoTk5zL3lTWEV6SFJUVHROZ2ZL?= =?utf-8?B?S0ZiYURWMHlJT0pFTlExRDJINUFCUGFzYmhQYm1yWVBBckluOEhSR3pIUkJF?= =?utf-8?B?OTVYaXRBKzB4VDB0L3RPa2RyMUtseE96WHgrUXdHVCtFN1Y0YVc0RjVaZk41?= =?utf-8?B?Sll5WlBQL3ZwZXRmWXJ0NHNJbW5nM3JQV0VxazNnbmpKeWI3bHlsZVNIYVQ4?= =?utf-8?B?cXlBZk5qVCtlRUd6OGNScThvV2p0ZGs1eDlUV204VTkvbGR6YkxrbWJHTWtz?= =?utf-8?B?MEtKbzFEd2h5TUVtSlExSVo4SVpZWTJNWVBQejdCOHZiUWFsYTM1QU4rRmsw?= =?utf-8?B?RDBoOFR1cWJpZFJ6U2RwcjNjMVhKamNMdzVjOGRBOGJOUDJNRXpBUFhhcDVB?= =?utf-8?B?aXZrcUcvOUNyUERYYUdjNkk3YkJJSC9PcFl0Mnd3ZzZvWjNOdGk3YjUyV1Jh?= =?utf-8?B?MHExUlY4SFEzK2VVY2hkNVBvSTJncFoxRHB4NlZCYUdyK0Q3N2MyL0NZSjlz?= =?utf-8?B?ZHNZSXppRk9RRjZRUHViR2N5RS9wVjBLdUZjUktrZUVZdWpyc29aanEwMXR1?= =?utf-8?B?Z283Rm8xREY4MVVaMGxmdUlPQ1VaV29tSjR2bFN5OXF2a3JXMXp4aHJOdGI0?= =?utf-8?B?cWhJR3JvRGJ3cEJQN0E3V3l6TUtXcWNkREEwa280Wi90WVBZWXZIVHV5MjVD?= =?utf-8?B?cHVlV01DNlF2dXVBRHlKdDNhenVjTkxEUmIzdDV6TnY2VFVEbmV4WDBYdVJv?= =?utf-8?Q?YL+1AEIRMuSQMqd0nHDv5AsnG?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: db0bde3e-b5b8-4aea-cba4-08ddf10f833e X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2025 08:45:08.6891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uwyBtHL7+7txxy0ga8bbtOCJTScyQnLM7tBHQnWuVtUJSMrNjtrOljxnmTfA5mwEjF3IfHc2QcKQUCLGdrlj9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8364 Use devm_mutex_init() to simplify the code. No functional change. Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 274972cd21f9f0facd5098b724c0d6c661ce95c2..0e3b9796dc1aeae58e626e06e70= 68b20b40dd213 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -1337,7 +1337,9 @@ static int ub953_probe(struct i2c_client *client) if (!priv->plat_data) return dev_err_probe(dev, -ENODEV, "Platform data missing\n"); =20 - mutex_init(&priv->reg_lock); + ret =3D devm_mutex_init(dev, &priv->reg_lock); + if (ret) + return ret; =20 /* * Initialize to invalid values so that the first reg writes will @@ -1346,32 +1348,26 @@ static int ub953_probe(struct i2c_client *client) priv->current_indirect_target =3D 0xff; =20 priv->regmap =3D devm_regmap_init_i2c(client, &ub953_regmap_config); - if (IS_ERR(priv->regmap)) { - ret =3D PTR_ERR(priv->regmap); - dev_err_probe(dev, ret, "Failed to init regmap\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->regmap)) + return dev_err_probe(dev, PTR_ERR(priv->regmap), + "Failed to init regmap\n"); =20 priv->clkin =3D devm_clk_get_optional(dev, "clkin"); - if (IS_ERR(priv->clkin)) { - ret =3D PTR_ERR(priv->clkin); - dev_err_probe(dev, ret, "failed to parse 'clkin'\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->clkin)) + return dev_err_probe(dev, PTR_ERR(priv->clkin), + "Failed to parse 'clkin'\n"); =20 ret =3D ub953_parse_dt(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_hw_init(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_gpiochip_probe(priv); - if (ret) { - dev_err_probe(dev, ret, "Failed to init gpiochip\n"); - goto err_mutex_destroy; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to init gpiochip\n"); =20 ret =3D ub953_register_clkout(priv); if (ret) { @@ -1395,8 +1391,6 @@ static int ub953_probe(struct i2c_client *client) ub953_subdev_uninit(priv); err_gpiochip_remove: ub953_gpiochip_remove(priv); -err_mutex_destroy: - mutex_destroy(&priv->reg_lock); =20 return ret; } @@ -1411,7 +1405,6 @@ static void ub953_remove(struct i2c_client *client) ub953_subdev_uninit(priv); =20 ub953_gpiochip_remove(priv); - mutex_destroy(&priv->reg_lock); } =20 static const struct ub953_hw_data ds90ub953_hw =3D { --=20 2.34.1 From nobody Thu Oct 2 20:46:44 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010008.outbound.protection.outlook.com [52.101.69.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0207A2E7646; Thu, 11 Sep 2025 08:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580321; cv=fail; b=exjVqEGFiyOLC5MNsBusaanfnmC46fl20Fpd3jDvRGNrg74SYZDibNnnNJKX7CoLdyQ15r+KBsXI6n+c293eVhYeBHo0QgdKfGLKMBumS3QUndlSBmYe8zkLGa8mxqzvKLI3NHpf6pjmOnQevxB81ITlsZ8z9w/F5uRs/xlgMUE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757580321; c=relaxed/simple; bh=6d3mWuUYDw8tnTR38YyF26BnpnRjF0qjmAf8kf5BO+A=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Hui5gGgkZK1se2suVUOMvWJdXrtOLpPGqa0T1KdRMZtTFMkcUw/zyz4b1E9rU9rFMm7H0Dc8OcG3hP2w46Pa/xfp7YL18HmAsf0WH8dLqH4pDKfP2lxPRKxXsc9YX828QXJqa1nwc6qg0vAMxQroODGJ9B5VdpMJoG7QiknkkoY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BzQH6HWj; arc=fail smtp.client-ip=52.101.69.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BzQH6HWj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zQceY57OFkZFCjaq1diY1fmaqNSQDj10uz0qWyGcYBNXxl/36gf7zFbYMTim8MptheEQ5W/EmXnAirR3Qpluon+bnTL4frQXwXU4LHSQcjxiko9PgbkxqHnnglr5oswe6uZ+1H9T7pc0fWYncOK5m0Sf1zyejSd/aSM5wRX16Sgdb58fgbIKfH3rbbA8ZKQ0Fx0WNtzAgJdunphMII7m2CX8Qag1DFD7XBvfr9Zr+C9YBv3n6IyvICzKbYTLipR5vGpl3fYEFnVv8MtT2A9OyUtcD/eTAgywMHVX/VNQKeal2hL/UKdmNeVrfWBQa4th1SZYRoAKST1Cxy5bIkq5fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYoYb7iV4ipkKuNy+CDk55YkqOIsyYZqytIIP544B9k=; b=j7QKM2VByVZifA3br+R9cwHcVUbgUHz0VfknWe9icNRYTtb9yhTxz6NAnRbynLF5ayh3Y7foUfDfIX8GOnyQl2w4RmoNezfqkir/8zp0bSgAsaarmDQnS1h/koRhF7Lyo0xdcsqntw10Kcf/MyKwGXZaODwi8UfNPyfvAmvrS8yb01jBjn+SBpD8eoagREud3jqoB0+qi5qmT3JaOIy1we/Ty/QBumApQAURUsKi1h83rDlR7DALsP9/9+qcog8lgCUKdYU9BfTrfva2szc3qD3SB0zQGWD3u9L6TnLTRJVaWEC96A3Att8zOxVNVS0FsNQ3oQxoaZ9MRMBcRFVlJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYoYb7iV4ipkKuNy+CDk55YkqOIsyYZqytIIP544B9k=; b=BzQH6HWjN+bJ0T0QfPKyGG55RH6GZ7SKdnTMuxBki6zsreCmeyrfm+tWjzeYCgn0LJid0+ltN+MljA8FHcHPe7MbD+uJ5AWYOhQL31T4O563hke4I4K99c4qpliv9mOLSpEnHmAQm46LlT0gEajI0QB5GRnbWGGccwBRCnctN07uiA0V3V23LZvBKD1DgTtl9MsDjw+vSkjo96i3bCJR8Z821tcctNwEH64CmMFbB7w2jJRzTg6BKnaHeF9456NF6DiZ4Zpn14NF3DfPEcUT35RkYpYM5Alqifae1GXXkSbgZ8Khzq1lATjoShvLsQF6Mom/b6pKwpFP88402ZOOsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by DB9PR04MB8364.eurprd04.prod.outlook.com (2603:10a6:10:24c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.15; Thu, 11 Sep 2025 08:45:15 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Thu, 11 Sep 2025 08:45:12 +0000 From: Guoniu Zhou Date: Thu, 11 Sep 2025 16:44:25 +0800 Subject: [PATCH v2 4/4] media: i2c: ds90ub953: use guard() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-ds90ub953-v2-4-03ee76eb6b59@nxp.com> References: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> In-Reply-To: <20250911-ds90ub953-v2-0-03ee76eb6b59@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757580308; l=3324; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=6d3mWuUYDw8tnTR38YyF26BnpnRjF0qjmAf8kf5BO+A=; b=kJunZ9RMtc/G+tPj1BU7s7zX5oird7AEsi4iQwiXtxUgil+IXq25Gmsq/lq7Bq/t3HxL8rIxr yG4tWY2z0R4BWdnxE9XfeW8Yor6xh3al7crUJ9v+AGDZyuD5wKKhg28 X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI1PR02CA0026.apcprd02.prod.outlook.com (2603:1096:4:1f4::11) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|DB9PR04MB8364:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e6bf1bd-14e1-4b38-2783-08ddf10f858b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|19092799006|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RUMyYUFMbzRscExUM3cvSXNZSW50S0QyOFg3YkhMRzJPdlFBaXRxbUR0MnF2?= =?utf-8?B?RW1NVnRiK1FvbkFhc08yT0N6ZkZOTm9zWHhvazBpTU1TeXpvMHVXQWI4SzlO?= =?utf-8?B?R3ZxTjFHNEFGaDJKd2JHRXFEdTBBWjR1Qnk4YkoyenJHMncwWjdzSVlYbW5j?= =?utf-8?B?L0dtMThXNjVyU3dkNDVnYmkzbkNUWUZaM3Qzcldjb1g3Ty9XcEVtUGs2eThS?= =?utf-8?B?bVZJSmJwQjZjbW50TXJkdFVKQStsdWlKbWZTcm9sbE5pcXQ5ZVlwSWlOY0x5?= =?utf-8?B?REQvYnQwRkErdUk4V3BTMjNMNkFuTmo4Q25OdGFIOC9DbWNwOUhnL3p1YTV4?= =?utf-8?B?bnQrOU9QK0gvL0E4K1hFMDlLRWRIcHVGdUpsR3dDdGpOakRVZWdJL1M4Z2Vm?= =?utf-8?B?MlBRb3FGRGlLbWM5MVA3NDFBMFE4MFRNdldXTHhXOWxIcllpSlNJRDhjWGJ5?= =?utf-8?B?ZTRTR3R4TVJFMHRhWk1xeDVXUm4xUkIwUDBXSDNZbVRlRFVuM3oyZTAyWlFE?= =?utf-8?B?Skw1R1N4ajhJSy9OYzNnY1pKdyt3a21odzhYdjBVZ004TFM2WE1NVy9HRXQw?= =?utf-8?B?UnNnZUtkbXNRang2VWJ6bkFaOFh1MzAxMzR4MnpGVGw5THBKb0txbXFRZzFx?= =?utf-8?B?QWlxcG1KREptcWpIdmJjR3ErWEtITDVKempzL1V0b2dzK204TVhGV3IwV3Ix?= =?utf-8?B?VWtZVlJ5Z1loNWsyVmc5SG1DYnBNVkdNQnJaY0VhWElNWlBJL2t3QS9OVG8z?= =?utf-8?B?cFFWbW9VcTlDK2E0Szd5a2hDUGV0YnBmM0xiUUxPU2NrMDRBUjNlWG01cWFo?= =?utf-8?B?THQ4dUNFQmI3SFJCS0xkSzNvbjdPMjBIdE81bWV1VlRQbERmZ2JCVXNzcGJr?= =?utf-8?B?RWMzaHVJQWM4Nmh0NlJnaFFCZ2xMeERPWUw0VEtQU3ZHaC9vT3kwOExCVW9v?= =?utf-8?B?MkFCejdHUWdjUndVMTVJRmZpYW0rbEc2VXdKMXFtQWlqYlV3d25BQkVxeW1q?= =?utf-8?B?aEVuV3puZUw0RS80RzJyajZBREpkbzBtWVBIOERFcERNNS9tSlZwWWlyY3Bp?= =?utf-8?B?c01uSUJldXhyVDRsQzEzeFhRbllzL1hsNmFVdmhja21udkJJSlAxOGZUbU1V?= =?utf-8?B?TDJJV2pqVDE3TTZRZ2M5Z0MvUHRMMUZvaFZNQnBlb2NBTHRMOGxaenFWUGll?= =?utf-8?B?OUtKY0hPbmQzM0pYMkh5UTFkN05yb0d4NHY1aWk1dUljWVB1UzJnMG9TUmVC?= =?utf-8?B?dXpIL2dvSTFFUUxQZC9WcDZLL0NaTTgxNkFveFV5WGd0VEovenZrcWloR2xy?= =?utf-8?B?MytTdnFwUWVFRDFqbnlGMHozb01jMkdVL0QyZjJHWEVJdllwQi9qM0dqL3V1?= =?utf-8?B?Tmc4enkzMGpDdTlWZTJyelNKeUxiUHhsWkJrYTlXT3c3QXZqVXM1WTliMDU3?= =?utf-8?B?VHZnb1NvcDF1UVRYSHEvSWVUUk9qMytLbzZUakpWMEdaanZXOU00MStaMTV2?= =?utf-8?B?N0FhNTBzTlBsdzJHM3VSUkp0bU9KVDF5aVk1YXFlcENaUFRRZjN3RmI0L1c1?= =?utf-8?B?STJBd3ErSXI0N0YwbVVVc21JZkRzVWtXUFpTS0xDWUtWczQzcm1mSzJJcVRK?= =?utf-8?B?cDVyU0U0Ry8vWXJzbDJjaENOTWJFenBLK1VWZGxYNkJ6R3dNZ1dKa2w1bWdw?= =?utf-8?B?SW10TjMrWUZSdktnZ1V4Ym5KZHlnVHlma1RsL29XcGZGZ0FOek5CVENKK3hu?= =?utf-8?B?ZmF1c00wYUtlbXJJcnozY3dia1hEdWZTUXJrQUlJdFVXeWZIVlpRR2l1WDli?= =?utf-8?B?elRNQ1ZQTml1c0svR25aYStWdFk1OVlxMjU0ZEhQVXNuMTQ3OUlNMUtCNDFX?= =?utf-8?B?TG5RVnNrc1ZNUVpwbGkvbWxMRlhZNWFCQlBlUTU2WVZFMU0rTFJuU0I3RUJY?= =?utf-8?B?MVNBaHFPTERUY29JSitENVF5ZElhbnZFOE4xZGx4T0Z3emRDNy9yWGp1REMw?= =?utf-8?Q?ThxRgN25lp+EcfSGmnprhhjX10+CEE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(19092799006)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGdidE0za2F6Vk01TGgzdGdrdVpOL3g4L3JjcCtrQmdMMFA5WUJoL2xnM2hT?= =?utf-8?B?SWxPZmorQVFvbVBWSGlBMFM1K2dJUHFkcjByaFpHRGo2MHR2RXVnYkExSWdS?= =?utf-8?B?czFRWkNhTXN2VGNvZmZHMldNT1ZEUmx2T0ZNOS90WjByZW1RdklmbjlhQ25R?= =?utf-8?B?M3puQXJES1o2WkMzcXh3V1dwOERBMk5uR2huRWpWRDJmSVY5bVR1VEgranQw?= =?utf-8?B?eUx1cTFvNVBpdys4M3c3bUNFNXFoczJiK0pBTUhWdURmbFM1MHB1SkEwWmhT?= =?utf-8?B?cWozWmNXV3FJRStST3gzUGJRdXYwQk9rbWJBK21SaFRqYnB3Y2drbjBUUXJS?= =?utf-8?B?dlhXdklhbDd2eEZMWFNid1R3VkxIZ2hlWE9YVmZJaWFXcSt6ZEZ0ZVhqR1RD?= =?utf-8?B?WVNTRGx3b0dPNzU3WFIrbUNJdVF4cHhIU0FaWWQ0MWlnYU1IZGI0RjkzKzFU?= =?utf-8?B?SFhmWDN5WVJTenNuN3k2Yit3N3JSVk1VcUo4STJwMktpYkwvamRBWWpFdis0?= =?utf-8?B?MUo3WTFndEtxbFUvOTN6dXlEMkZwRHh2eUtXYXA4S1p4eWtoT3hBMm1VZ3F6?= =?utf-8?B?eVRSaVRUd3ZWcVk4dm5HdlBjOHNiUW5NYkRUbkRaTnlkT05kOHdLWEpFTzJQ?= =?utf-8?B?RUJ2eHgrakRnREJhWFd1aEZXZXo2UmR5ZDdWTC9OcnlBWHdubUY2L0QyVGJI?= =?utf-8?B?Q1JOVlZrQmkrMTE5QjhqRHVOdCtFNzlxcm5QdklPdTVpQ2lWdWlRMUVkNWRu?= =?utf-8?B?dk5BR1lIakZQbUFvZ2d6OWdwY0tLblRMazFyN0diS1hqaUdMVEFBa3hwd05O?= =?utf-8?B?d3hjNGZTcUkzdEN2cXlZVGRoR3g3QmwreVdFSUJSR29ZZnFsZnFQVG9Wc1E0?= =?utf-8?B?RU5VNS9iWFdac2NJTzMvSDIrcU5iOXFZS0IzRHFveVB5UlYzcmxrNjRKbmp2?= =?utf-8?B?S2dQTmFOMGF4TTFKaTZCeDg1U0NSUmNDVjA3SUtPTGxIMkR1WUdIQzlQeVZP?= =?utf-8?B?ek5TTnNxQlNtOEJhUHk4dnRNTG96dHBQQ3pWRENoVGJwNnEvUjJpY2hXRkto?= =?utf-8?B?cm5CKy84L0hRK0ZRb0tFV3JibXpkaFlaQzJuQ0tpMy9raUR1U2h1SHo0MzRh?= =?utf-8?B?dm9vaHd0ZStuaUxpUjRIb1BTOWRPTnpEUWJDT29ib0VrUW8rbDQ5cTJDbkUv?= =?utf-8?B?djJGc3VtOG45REVlUVJLNks2Vkk4WHMzRFBTeGo3TitSWTh2SkFMVUI3T0xZ?= =?utf-8?B?WmNFRlJZOWY5akk3UG5zV0NsWGwvQ045Ti94a0dnczNJQ2lDZUpwekZFaCtt?= =?utf-8?B?QkJJU0F0VXlpYktjWm9tbmZ6c1MzRlFLR3RLaTdaeDg5WEZlYXZvK0VzQVNx?= =?utf-8?B?UTcxOGNldStLYWd1OXZBSE1uSWNmK1Jua2pKMTMrYUpLMHR5eVZjY0QraFBW?= =?utf-8?B?NUs4b3h6SVZrV3pGdy9LSGtKWlB1NWJIRkY3S3crWkxYanpVVkFOdXBuQWZR?= =?utf-8?B?bWJZQ0RTRlFkdXNEd1JnNjhkUGNIN1Yzbk9aOEUvbS83bEtsSFIrU2Qza3hV?= =?utf-8?B?RnZmWVU4eVZBczU2VWplR3JsRHd3SjFjRitLbTVtR2p5N1JyNVdiY295QjJK?= =?utf-8?B?MTUrZ2dTU0tFNG9iTjZMSmtFN0tHMllIYXRPM1hjNnRqME53bjVzUUJGbC95?= =?utf-8?B?RHFJSkltNHUyVnlQaWxOeWU5SFJRbUtISFgvMlFMdmpyejlGb3JQNnJmMmZM?= =?utf-8?B?dE1wenBCSzV5TVJrbEVheS9acXVJWmhVWXpsN0d0ekNNelQ3WU05d1drRll1?= =?utf-8?B?cHZpTUh1QlNOY0pNSExNNzg2aWRPTXJYY1UyMWtFbTRqOVFCa3BvUGtLcGtX?= =?utf-8?B?ci9LRWRMaExVTFhyRmVvY0pGNEVOREx2MG1WcWRTRnU1M0pYa3NRcU1sN0l1?= =?utf-8?B?MDBQSDkrMDVsTmRTMVg5Y0tuTDhGUTdMb3cvUHlmUGtqeFVPd3NDc213dHl2?= =?utf-8?B?ckpUSjNHR1Y3MVFaclMweC9wQ1JtNHJHZWRWNXNkeVA1ZW4ySTROMWtWU0cx?= =?utf-8?B?cXpNVExrOUJVbVhVVzk3MDIxOWcrT2l2akgxbGtUY1JVL1BjMWU5R3dSdnlt?= =?utf-8?Q?eydukmIXRdL5EocZDaanx1BwV?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6bf1bd-14e1-4b38-2783-08ddf10f858b X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2025 08:45:12.5699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8TzKozHpZ9QPyWYoV4IXJ0IllmttxFZ4SANKEPieF671K+SaNRjL35ft1PS27/2LrQulImoydJRVCym1CswKBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8364 Use guard() to simplify mutex locking. No functional change. Reviewed-by: Frank Li Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 0e3b9796dc1aeae58e626e06e7068b20b40dd213..defbd728a0389219397578feee2= d3fdc4042bd31 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -112,20 +112,18 @@ static int ub953_read(struct ub953_data *priv, u8 reg= , u8 *val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_read(priv->regmap, reg, &v); if (ret) { dev_err(&priv->client->dev, "Cannot read register 0x%02x: %d\n", reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -139,15 +137,13 @@ static int ub953_write(struct ub953_data *priv, u8 re= g, u8 val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_write(priv->regmap, reg, val); if (ret) dev_err(&priv->client->dev, "Cannot write register 0x%02x: %d\n", reg, ret); =20 - mutex_unlock(&priv->reg_lock); - if (ret && err) *err =3D ret; =20 @@ -184,18 +180,18 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_read(priv->regmap, UB953_REG_IND_ACC_DATA, &v); @@ -203,14 +199,12 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, dev_err(&priv->client->dev, "Write to IND_ACC_DATA failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -226,18 +220,18 @@ static int ub953_write_ind(struct ub953_data *priv, u= 8 block, u8 reg, u8 val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when writing %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_DATA, val); @@ -247,9 +241,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 = block, u8 reg, u8 val, block, reg, ret); } =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 --=20 2.34.1