From nobody Thu Oct 2 21:41:04 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48693115AB for ; Wed, 10 Sep 2025 20:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537075; cv=none; b=XWZ5qPaDJkTVm7eLSQntSVY55Ytqv9BPr7Bq3V3Y0ZcurDIf6Pq6rvmF/ucD+c7nMgMS2cLOCZ1fiQgNi0DGP00jlAIU6Cuys79tSR0BYol3/hzUzCU86M9/Mez5lVat4hnbOAnGk7H6Iyd0a9s8ypz0dE4jT8/IASCbjKA+lYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537075; c=relaxed/simple; bh=TsM6Bk8IU172J5i+V6pxbaDOzPWuVAASo1qAv/7B0Mc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MMWIOgWHU40S98X+RkEf7T8E+j0FJ6AGv02+JC8qI9SZczHEz4ZXKkagBvpblSytHJaMLo0EQ6C47ZKJQEGAepRgU4ZEKrQHpTcy7qrR4+lDmhKL3p9PdY13H3bUhOynhmgs6IRvnlbC7Xet1ab0JXWI/xvyhrrEHjr66Lq3jeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OaGyExaa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OaGyExaa" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ACgD3E003650 for ; Wed, 10 Sep 2025 20:44:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GjMQrOqt1kzUjiB7WrBgzYzLHVWBj+hV2C1YKYXo120=; b=OaGyExaaQQXe2OT7 yepRG1DWBHoXnJ77boJyY9isfWYOlebMd1ol4dTjE9f4Jbk+f7Ao3h9fvbjpI0/l SzQ7KRsns/1/ovmcQSvkH6V2rFDxt+xMrPNSFbMjqRpoveSajkMWR01NBFs87Wg7 x3oGiuvvCettf+wJJLvswNLXl8wkn+XJS8bp7MyoapEzhbEOvNScSJWjXsgvX4d4 NiO315xIvBTe6UPN/8lm6JAlZlscv4idOJZYMe/ZwF24p/YkFZz6Qd6l+jgFk0Vz iiXh6rxNMoZUFr423h/AUM5jVn5afppPYpwj/JZthBaTNGwu3n78wrHkxkFI1c6U SdP4NA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490bwsdct2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 20:44:33 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-77260b29516so7659b3a.3 for ; Wed, 10 Sep 2025 13:44:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757537072; x=1758141872; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GjMQrOqt1kzUjiB7WrBgzYzLHVWBj+hV2C1YKYXo120=; b=kiVJJVtrJOBXuX6f4m6fA0jL4jd8YmSuVYbOo+ntF1CQP+KA5nIQz9psCJt5lOdDQ4 hPHM/ZV8YbfdD+d0DpolGLcSlAhtU8mP+zu2c1HbH3YLKoyibyqNNb8dgGG1wl5eF9QM XKVKY98iq1p9/iHn1tcCaWlCiFpO8LlhVpfgbRZcx/w96lU3uYyKU6krvYusJ9HvO9no CjIATFqjnwLjg+qx7B76a6l3sX1H+BcWjrqt61KdbOb6ikJD8Q/A4rn95DVgEbU1c5QS dzGJBKr/PRzhHwCekr+iv31PSMwfZkzn9Lnsm7m58E03PBX15LyFIptH8HFl2U0MK6iq LTpg== X-Forwarded-Encrypted: i=1; AJvYcCXrEsbLN+ZVR58T3BbjWtj0dJbBJd+AJ2JvC+w1XgUlprpkjOltjSne91igbwnbbDg3EIm7amRihQ+X5Yk=@vger.kernel.org X-Gm-Message-State: AOJu0YxBGybquBqsEV0zrf2sH4vE0T1nREulJ9AIpnIMogOS/cSFGFcy 09JUnExavWUjU+THe3VL8LteTgtVhnrmtxEXsE6/+pdSgUpEyoOx55Txypyde9D/iPrOMZ6U9gi oJKUeYpkqf0XgvX0Nf0w8zwp5iUehr/S37v/23K+f3nss/PaxxANtF+79jZquULMkQFQ= X-Gm-Gg: ASbGnctee846NxlJGYPsyK3nJtYkcgTd42IkiQEtBRLv6wQs4XCmJ81O7sS9pEnK5Nk 4YXN1QxJjaRI8u6JxOxH2gTCK+pv4txt+AcPSUczzJv9B0gP3k4qYVzSnNf7AKydG/FdVbhPvWs 3hgOs18k5n3ZhGVR+6bmbKgiiOMdWCxZIYVzOpz/7Woc/t5r+L6xrj/f9u1iIUsunhZmVpT/WcY rjTMNHacTv4frX/FK50uqO+1eo9op0w74jJ13T53budgYjVcbfCH18r21HgKlj1kHFVCi3HERyP kN0MqGTh1JIVM0tMZ7tPHQcvMG1JndonJPa9kd68VTRD2QgQEHpQqmoaLKrCiase X-Received: by 2002:a05:6a20:3c8f:b0:251:1b8c:565c with SMTP id adf61e73a8af0-2534441550cmr23941561637.31.1757537072094; Wed, 10 Sep 2025 13:44:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9OV2MeB3Kpz+lIR7PJ0sGEfu8xDO/gzp+R4DHMG4utoV9wKznHz0MNDx+h6Gs3YDnRszCcw== X-Received: by 2002:a05:6a20:3c8f:b0:251:1b8c:565c with SMTP id adf61e73a8af0-2534441550cmr23941533637.31.1757537071574; Wed, 10 Sep 2025 13:44:31 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd61eaa42sm46771a91.5.2025.09.10.13.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 13:44:31 -0700 (PDT) From: Akhil P Oommen Date: Thu, 11 Sep 2025 02:14:04 +0530 Subject: [PATCH v2 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-assorted-sept-1-v2-1-a8bf1ee20792@oss.qualcomm.com> References: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> In-Reply-To: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757537061; l=4407; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=TsM6Bk8IU172J5i+V6pxbaDOzPWuVAASo1qAv/7B0Mc=; b=ducsX3eTW444B3LX7ve+GjHgu50CveeJOKhPEVAFz0SDyyqB4N0olEWFgMcuaDv3ZE4VrnB3p LTjjhefYUPLCBh3hegVS8gvfT8foSgSNQCh0oqzPjvLSCnjT4I2YhA3 X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-ORIG-GUID: h76hm22NxYTgeFrbPiQhL67C4aLC9FHC X-Proofpoint-GUID: h76hm22NxYTgeFrbPiQhL67C4aLC9FHC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAxOCBTYWx0ZWRfX1ZypITL55Lov cx/v1uR3UUGy/FPWjDQXXyp17py7tBgK3wW3q38H6ztS2Bb8KiLK1UK99WVpTlilDrVZQQRT1eR tAfFkN7p1Zzt7CxpBR4UvtTleKnngjHowy6pTCtIPxFT6iqgE3ERkdWlEQ90Vbph0ztDUjra1MX 5IlGrPk+mVHnl9B3T9sf2DPhQ0QfGC3zZNJ6ObiH8g4mNzz/Az6psOjDpmXxGq2GpnLuKv8TIEU CPJ8H4k1dZEh0Yi2S2xb+X7e0D0yZGQPQnxEX5Kj001/J5ZjfKtAgqujkq1IcWYCnd2eE8BoRuh RjCW+O2a0G/RfTYY6wkVKp2ruDUO2zdOrtAIIWffNTvZU91JaTkaz2bobl7K2UaF2UwjDJrDHMQ 8xWAFgiJ X-Authority-Analysis: v=2.4 cv=G4kcE8k5 c=1 sm=1 tr=0 ts=68c1e331 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=wZg4fdH2GHFv12Tp5BEA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060018 The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses drm_gem_obj.gpuva.list, which is not initialized when the drm driver does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms drm driver to fix the splat seen when msm.separate_gpu_drm=3D1 modparam is set. Also, update the description of DRIVER_GEM_GPUVA flag to reflect that it is also used by DRM drivers which doesn't support user defined GPUVA bindings. For eg: msm_kms driver. Unable to handle kernel paging request at virtual address fffffffffffffff0 Mem abort info: ESR =3D 0x0000000096000006 EC =3D 0x25: DABT (current EL), IL =3D 32 bits SET =3D 0, FnV =3D 0 EA =3D 0, S1PTW =3D 0 FSC =3D 0x06: level 2 translation fault Data abort info: ISV =3D 0, ISS =3D 0x00000006, ISS2 =3D 0x00000000 CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0 GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D 0 swapper pgtable: 4k pages, 48-bit VAs, pgdp=3D0000000ad370f000 [fffffffffffffff0] pgd=3D0000000000000000, p4d=3D0000000ad4787403, pud=3D0= 000000ad4788403, pmd=3D0000000000000000 Internal error: Oops: 0000000096000006 [#1] SMP CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted= -fix-00005-g0e9bb53a2282-dirty #3 PREEMPT pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=3D--) pc : lookup_vma+0x28/0xe0 [msm] lr : get_vma_locked+0x2c/0x128 [msm] sp : ffff800082dab460 Call trace: lookup_vma+0x28/0xe0 [msm] (P) get_vma_locked+0x2c/0x128 [msm] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm] msm_gem_get_and_pin_iova+0x18/0x24 [msm] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib] drm_client_register+0x58/0x9c [drm] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib] drm_client_setup+0xb4/0xd8 [drm_client_lib] msm_drm_kms_post_init+0x2c/0x3c [msm] msm_drm_init+0x1a8/0x22c [msm] msm_drm_bind+0x30/0x3c [msm] try_to_bring_up_aggregate_device+0x168/0x1d4 __component_add+0xa4/0x170 component_add+0x14/0x20 msm_dp_display_probe_tail+0x4c/0xac [msm] msm_dp_auxbus_done_probe+0x14/0x20 [msm] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus] really_probe+0xbc/0x298 __driver_probe_device+0x78/0x12c driver_probe_device+0x40/0x160 __driver_attach+0x94/0x19c bus_for_each_dev+0x74/0xd4 driver_attach+0x24/0x30 bus_add_driver+0xe4/0x208 driver_register+0x60/0x128 __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20] do_one_initcall+0x6c/0x1b0 do_init_module+0x58/0x234 load_module+0x19cc/0x1bd4 init_module_from_file+0x84/0xc4 __arm64_sys_finit_module+0x1b8/0x2cc invoke_syscall+0x48/0x110 el0_svc_common.constprop.0+0xc8/0xe8 do_el0_svc+0x20/0x2c el0_svc+0x34/0xf0 el0t_64_sync_handler+0xa0/0xe4 el0t_64_sync+0x198/0x19c Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44) ---[ end trace 0000000000000000 ]--- Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display d= evices") Reviewed-by: Dmitry Baryshkov Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_drv.c | 1 + include/drm/drm_drv.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097= a01c2b2556608 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -826,6 +826,7 @@ static const struct file_operations fops =3D { =20 #define DRIVER_FEATURES_KMS ( \ DRIVER_GEM | \ + DRIVER_GEM_GPUVA | \ DRIVER_ATOMIC | \ DRIVER_MODESET | \ 0 ) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 42fc085f986dee9261f8b08c4fc7d93b8d6d9769..8729c88fd12ba76eb0084fc1a2e= bccaabf377995 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -110,7 +110,8 @@ enum drm_driver_feature { /** * @DRIVER_GEM_GPUVA: * - * Driver supports user defined GPU VA bindings for GEM objects. + * Driver uses the drm_gpuvm infrastructure for managing GPU virtual + * address mappings of GEM objects. */ DRIVER_GEM_GPUVA =3D BIT(8), /** --=20 2.50.1 From nobody Thu Oct 2 21:41:04 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E677C31577B for ; Wed, 10 Sep 2025 20:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537080; cv=none; b=kwobm9PQ2NtyR8oE2Sq+XEIeF1ait8ChnXGexxGHOa6ved1h+3ksatB99gJwBnOt0uxwVbrdg0xvpWHhdVMViQXl1hNUjnzf/BPSyt3kiJK8C7KsIwMpx8Drg02qi1jVw8M3wVnVCdLDB2NQUtwP2dsptyCS4AfoMDTuq+wcyw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537080; c=relaxed/simple; bh=QH5mzD4A8ywK4YBRLZvZeIsieAJxopW4JPv0czcGn2k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SMT1ZjAsgdzQnGXSVo0MP4rSDforWfsbdO3oD1xHD9qXxnGzfFl2L1U/JSVjt+uMKPyrTE/YV2VwJjR9WCAr6HkZjfkGV3GAGgiD1Nn61sLkVHIv2eOdA/tOx5aQcx41UjtruAJrfzmqCxgBq0EULgOpPubwge9EHvn8OaL4Bug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HHIvGWYD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HHIvGWYD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ACgGJd023740 for ; Wed, 10 Sep 2025 20:44:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R/4Wft3ZFrBLCsBTvaTSzzDE7KvwF9edeAejAQ+B/BY=; b=HHIvGWYD30VWgh/x Y0GCG10lxYMkR+VEkiKxEny6Bw64sbPG9PzUNDVCF4cqgtSS5Ircjgk5HVzq5D+H NfoOrx9GGORI+uC6UqxqhhpCpVhygozg5sIw4RbB54EasURackySToq8mI0nmYrN lHSlQZa+CxDOc84l5j9B7GPDCQ7Wq7dTv7RkmV0owc2uhjOfRHcEMKnnhcTJ8eG/ 3HLjhmFD/qa0zKBbneoR2tmySKIYv6Oq+CWl71S/w1NlBog3irsytiQnhxQefaD+ 2WJwJ/eu1yXBRltpcIMW3OP8sEXDhaVJ0aW8jy5+FQa4UzO+dv+WOY0wzh9RZcfT Oru9Qw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490e4m556a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 20:44:38 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b52358ededbso921017a12.1 for ; Wed, 10 Sep 2025 13:44:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757537077; x=1758141877; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R/4Wft3ZFrBLCsBTvaTSzzDE7KvwF9edeAejAQ+B/BY=; b=Ct6X+dYVmN0nyxDZGD7tmckBKQfAmcsokMsaOH7KMJsm7AvdPl3geRzsEQeGvWIgxh ov6+s2RJWO+i8s3TreT/lLWpuGMMb4MHbW72SnPyEK/5Kb2D1zUq1Idwz/wfsXnFF2O6 M460jzBZRxjs9yGFwsamcAJRKxxTm7lXtvAqqi+nyDvR7d1j6CtyElWTYOsJtpEdmYK5 l/wn8yjkYTAjWXhPkV1Bln0y3HXZ85AZHww2A5aT9PQWAfVECL1Rwr9740gxoYg0NcDv UIF4kYItGVXAfu/S0PFBkyFCfoh6tEMSEwXKLaouHCBaIUbNF3IsbhxYBfs/a4GUZBOM J0hA== X-Forwarded-Encrypted: i=1; AJvYcCXvY++/RUp6FSbppM6isI1Cbpn7r4fm/FuQyCy5mWNaZfRpRTISMamwgSgxZBYDnKgt1ZgmdnCGeRy3zCY=@vger.kernel.org X-Gm-Message-State: AOJu0YzOGdUGqIwsNHQPY8Ql/ULqKfMnzjd4cztfQJV/QHw36tNrEtGU CT2wcXCpDJWPteukDAYyt2u/90tNdrqMALKygCXcr90WpUZ5iKwoyz73N2EZx2RQj0yXkkBDpvm ZWVcZYEU0HnjHfd5IdF57Hhjji5ij3eR0Y1+YCuN2196GYIIbFYRR1nFlSsywZ7VQ9mg= X-Gm-Gg: ASbGncvvVYg1WGauRy/7uLFvpgEGkLSpd8K0j+KjiyAioJjzNM/A10lIIH0FHLeHmBq 7uFnUsskKwPbyQuzo07loW/UF/9dJcm2HQb5A2SKQ9hc3YSpQL19gtS/QCLE7oqeUknjXMvsnXu HqjTPIM2RUZFOvpieJnf8h64Xog8Vm1bB1QqzoXlkJnQRQVGx+LtaPR0BjH4CD8acDeQ/g8GgTk phi7wWXBNL28Zr3CmV5oMNBeSxah4Xks4UWWFP9ZyOLtVHs60jfjwzUVwMkrEGOKU/tlM1HCq+g nrykGVJIS8XKOKr2j+enxUy7GpfxfX9qJZFrXJqltyOhYLBuR/rjakyhh3DNZuLZ X-Received: by 2002:a17:90b:3b81:b0:32b:96f2:e2c9 with SMTP id 98e67ed59e1d1-32dd1dbb188mr764763a91.12.1757537077225; Wed, 10 Sep 2025 13:44:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZ34b2+3kXaCBM79RfDIeYcFfBZlEs+rc1jvA1GOQktZ1ERKp+SFIbOTtPjv3X0doccjwcwQ== X-Received: by 2002:a17:90b:3b81:b0:32b:96f2:e2c9 with SMTP id 98e67ed59e1d1-32dd1dbb188mr764732a91.12.1757537076739; Wed, 10 Sep 2025 13:44:36 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd61eaa42sm46771a91.5.2025.09.10.13.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 13:44:36 -0700 (PDT) From: Akhil P Oommen Date: Thu, 11 Sep 2025 02:14:05 +0530 Subject: [PATCH v2 2/4] drm/msm/a6xx: Fix GMU firmware parser Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-assorted-sept-1-v2-2-a8bf1ee20792@oss.qualcomm.com> References: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> In-Reply-To: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757537061; l=1478; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=QH5mzD4A8ywK4YBRLZvZeIsieAJxopW4JPv0czcGn2k=; b=E/JQ2p+GzDCp/eeNWvlYpTUdKgONOclrECZtOlrFo0XCQnrPuI5PqEEU6YFEduipWLvfU2Wdh vzsHgYpuTkTB2Q1CS2zJyzIgbG0fCoHVY2D4nELZY3onLWrozaS2Ia+ X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzOCBTYWx0ZWRfXylTSNNQs0ee9 ktKEM9znCo02f/L0oSgHTYY7ff3a7+7hmukt4DEubS0kKW8dY+75kfG7xLWzRiqxRL5ViD6ikXc tIs+S/JlsufOKkfudyUVn3tP67VczgNBYnFjPRKkRn2SrciPg2YwLaoeHbOxbhxvYVS1eNBr++w DHIBxR9LM0tqF9zxLmQNGv6p9a0cKxDSQWxByoFq5A9PJkeMy4MWZpwwQSLKoV/DeVpJYLoS9mg ewxBomlg6uRqzaM+A7IqYPPp3QlXsFcQsr3lUl1XIErsLaFhszdjHG5tDBQTUyKkOdmM8H/w73F +eTcGIKyUy2xI8htGWcOyHhjbCjqXdkP+Ta0Rx8mjVzSihgor3XdnZNB2qb/pjjuK+EXO/Xy5Rs 6ZHgkiVN X-Authority-Analysis: v=2.4 cv=J66q7BnS c=1 sm=1 tr=0 ts=68c1e336 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=gF2G-XVBjaN319PmpW4A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: Wbnoh3jP9mAiNzt9WxVq13OpGJPQdQjg X-Proofpoint-ORIG-GUID: Wbnoh3jP9mAiNzt9WxVq13OpGJPQdQjg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060038 Current parser logic for GMU firmware assumes a dword aligned payload size for every block. This is not true for all GMU firmwares. So, fix this by using correct 'size' value in the calculation for the offset for the next block's header. Fixes: c6ed04f856a4 ("drm/msm/a6xx: A640/A650 GMU firmware path") Signed-off-by: Akhil P Oommen Acked-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 28e6705c6da682c7b41c748e375dda59a6551898..4c0510cc784864da990af8cad08= 6176a5d92ae8a 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -758,6 +758,9 @@ static bool fw_block_mem(struct a6xx_gmu_bo *bo, const = struct block_header *blk) return true; } =20 +#define NEXT_BLK(blk) \ + ((const struct block_header *)((const char *)(blk) + sizeof(*(blk)) + (bl= k)->size)) + static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu) { struct a6xx_gpu *a6xx_gpu =3D container_of(gmu, struct a6xx_gpu, gmu); @@ -789,7 +792,7 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu) =20 for (blk =3D (const struct block_header *) fw_image->data; (const u8*) blk < fw_image->data + fw_image->size; - blk =3D (const struct block_header *) &blk->data[blk->size >> 2]) { + blk =3D NEXT_BLK(blk)) { if (blk->size =3D=3D 0) continue; =20 --=20 2.50.1 From nobody Thu Oct 2 21:41:04 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604E331577B for ; Wed, 10 Sep 2025 20:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537087; cv=none; b=qunfVJz95HvDYoZv2DmjZxYO13Y5MP8toR1g5TTYNqq0PvkF/LsP2X3VdEncrP/lNmux8owrCay24dgBOLzsCYzELGKJh3aosZNKX9waFYD6U2zwTgNxAbdhl1Sz+g23j+vkkWOGY2RE/qVeqde+5kh5Hqph0sxxe4sqXT0aM8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537087; c=relaxed/simple; bh=ptvCQ44pDwO+JsrlkCUxCIV4rlpZnxasfp9TCljvBM0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tfXntniOmIte7xeku1Eoml790bw+61mhhg8SYPEMT4UJaGZDsD4j4spAUF7kz3ocCJqPQ1/c9idBoA/ZnSRdN96txQiz941ucodnhrv2oNFxzf+7Ez3K8JtaDiUaP/b99vgyBKVpGPvOZAl4Ha2s9XFGJbF61H9f15osSeKLUho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nRKQfVNs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nRKQfVNs" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ACgVH9029937 for ; Wed, 10 Sep 2025 20:44:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b5j0ANF9uGLsHOzn+Dz0rArXdn90tufLs08oVyQ3FJw=; b=nRKQfVNsE3VcO2Qd 3Mnz11ZDL3KXX8MDrf7rtL9XD58FYDHKV11lPEf9QnhoSAzhrpsx/0N3KlYnHsqT +W1rdFCTsPLIOMxqjxASVRXaJquU+Hiv5uxn8+o4D5+IzwLLyxWdZYhdTYxzEcEP l7axTMGpqOTDHsfQVgcoDhRUCI56UFDMEB1hPnEbBeuX9r8WT/FlkaDVPIO+etyh CaIcxi9dlWwqy6PwNn6j7Se42XwLOms0hwXqjMlJSTYxLT2Mt8rDD+Yr/P4bbpgo +g2T7tEjFd4b3Ir0W1SZY/Qyb6g1xW7vrrhKXV3bwCWWBL5c0jNXkWVXYVkv44DF ZQrlgg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490aapngsc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 20:44:43 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-329745d6b89so14687126a91.1 for ; Wed, 10 Sep 2025 13:44:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757537082; x=1758141882; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b5j0ANF9uGLsHOzn+Dz0rArXdn90tufLs08oVyQ3FJw=; b=R4VJFEWhfipSCXwAQfeG8Nx9E7MnzisV9Pxlux/K0OJ7/ODrBAm0690t5iyNTfpBXZ sS2VtJ1EK52ehhI9SsWQkMjazoUedCwV5O8zkGfpetVdqU/2agqJMb/iCruFkdPgyQCD WZUddGtErYVbRqhG9c0ZAhd20d/OJfVi9brfyt3ZPE1AYwqlYKx4epIxP2lxlsbLILed 9gMPYI/eaGTrShB9S6NgHbdYOg2m7dPGlgqDsOeVWmRhOldwUjdKwMU3+V8prHbAkg4y 5QO/RI6Ty6Va6wyJ9QuIEQUIGXT+ri7nEdQxOjRHmmNI+TfR7gT2nriZppsv+/wmHWUb cosw== X-Forwarded-Encrypted: i=1; AJvYcCVMpXjrlqWc6hI/V903xR+PdCDCpcFe7/WaPZ3VT65FHe2QxNfDXmVTsLfT7l8QmmH3ON6ptLV8e3TUu80=@vger.kernel.org X-Gm-Message-State: AOJu0YwmaUn/Mj2Dq6WwuzCbITh1RIsQOyr0nDcISwSPAWlMNyBHKlLa 4ckvtBVHozfR4equeV6lqFQZJIxe6tizg59N+76CAuWxM7kuqI+avj5qzwrhLurpiniD5oP0J3x assH+c6AhiJA+dV332fdPj7ibmRoq0EdqqysNxHjlwLHP3PyLk+ONDm9NGudqgL0r0bY= X-Gm-Gg: ASbGncuCJZWpnpNB4daPAn2udmvJktIRNp2Yd4OvpbM5VfDI9rcEhFoeAytr+rMSvur rsflSRFProwKdIcmBK+sYa/vG5JX2ygWNCUwv1AaCea7hCddL0FwzJpWRmqKK+192ERQgOOhRMo hKh8hOWaIJOq7JHbsD6czpkAkE9z75oDJkdgEACcUiUf1mD+BJPZk8W0ggKazZGkJ0XZheKq3iY +MJEvjyp6MVP7fdGQklSzKJsYUpwjap11Z7hWPZ4cYxKmVfxp0wQ6HOwXkBFxNhYGzG4taEvpUH u1QW40Lh5Pvm66zw3Y8aoHBNSsquWT7ODS/HRTCG3cMdsYxGSWSZWJSWBiarwxjX X-Received: by 2002:a17:90b:2788:b0:329:ca48:7090 with SMTP id 98e67ed59e1d1-32d440df06fmr23284158a91.37.1757537082395; Wed, 10 Sep 2025 13:44:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrr/ras/Xa2STSpUl7+3f4rSITLnWKAYz06qyu08j95UISULF1Zn/GfVdsvegQxaSC1gr7FQ== X-Received: by 2002:a17:90b:2788:b0:329:ca48:7090 with SMTP id 98e67ed59e1d1-32d440df06fmr23284122a91.37.1757537081972; Wed, 10 Sep 2025 13:44:41 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd61eaa42sm46771a91.5.2025.09.10.13.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 13:44:41 -0700 (PDT) From: Akhil P Oommen Date: Thu, 11 Sep 2025 02:14:06 +0530 Subject: [PATCH v2 3/4] drm/msm/adreno: Add a modparam to skip GPU Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-assorted-sept-1-v2-3-a8bf1ee20792@oss.qualcomm.com> References: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> In-Reply-To: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757537061; l=1809; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=ptvCQ44pDwO+JsrlkCUxCIV4rlpZnxasfp9TCljvBM0=; b=p663AlNIchQH8zO+l/OyM2INEDZQkWgx4XF4P+iNm7GhxMKHLnpQ/hNRhJJy3/OfjlqGk5qXS 8h0nxAwt9qOAMSb93F2TMTo0diyYp4LMOMFaNcj6yaONVPmM7ECIguw X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Authority-Analysis: v=2.4 cv=eMETjGp1 c=1 sm=1 tr=0 ts=68c1e33b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=5u7-6dn6khLgd3CzhdsA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: UABVEhhDrVTVkTHCyDyArqLsvd-DGg9h X-Proofpoint-ORIG-GUID: UABVEhhDrVTVkTHCyDyArqLsvd-DGg9h X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAwMCBTYWx0ZWRfXzDVRs6qvGCYr /K8yuYgraRvxpDs3Slq7zzTmUoCsKlTrRh+6ZRtkFdv/iDxoFBJtKfWksHNIch9AptrkVV46Y9B PalIi/58DvKzoDTaJD/ehELaZFXoivaR2yb6ARva839UfC8Or6ktXPy9dpkrBz1AbrOFEXY7j+d upfdYziRbrwVz4SvGCA84uimmzS0XQOI0/1CGAc0VFY6vZ5auGAk3UHd3O5o+tGuNSgIGrNMQ2c 71ondJvWLFeeGGPS+ZQ5Ck+yYecjeLnIUDMMEPfVk/nzLEXNpa4XC/NrB1iqDiZ7Uz5jao07pM/ Wkf35HvCb9YoKLKuXLNEOH2Fj0gkpPKcq5l/J09d0hGS1vOqzYkgPKfPO2exHBzHd6qj/e6xuyF ERvA3sV/ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060000 During bringup of a new GPU support, it is convenient to have knob to quickly disable GPU, but keep the display support. This helps to fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a modparam to support this. Reviewed-by: Dmitry Baryshkov Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 50945bfe9b4992118f23db3cd17ac348be9f9c9d..28f744f3caf7c59412aab06f912= cd09a01e185ea 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -24,6 +24,10 @@ bool disable_acd; MODULE_PARM_DESC(disable_acd, "Forcefully disable GPU ACD"); module_param_unsafe(disable_acd, bool, 0400); =20 +static bool skip_gpu; +MODULE_PARM_DESC(no_gpu, "Disable GPU driver register (0=3Denable GPU driv= er register (default), 1=3Dskip GPU driver register"); +module_param(skip_gpu, bool, 0400); + extern const struct adreno_gpulist a2xx_gpulist; extern const struct adreno_gpulist a3xx_gpulist; extern const struct adreno_gpulist a4xx_gpulist; @@ -184,6 +188,9 @@ bool adreno_has_gpu(struct device_node *node) uint32_t chip_id; int ret; =20 + if (skip_gpu) + return false; + ret =3D find_chipid(node, &chip_id); if (ret) return false; @@ -404,10 +411,16 @@ static struct platform_driver adreno_driver =3D { =20 void __init adreno_register(void) { + if (skip_gpu) + return; + platform_driver_register(&adreno_driver); } =20 void __exit adreno_unregister(void) { + if (skip_gpu) + return; + platform_driver_unregister(&adreno_driver); } --=20 2.50.1 From nobody Thu Oct 2 21:41:04 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0093375D3 for ; Wed, 10 Sep 2025 20:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537092; cv=none; b=jmqR5IA8V2Vfge+lfTLPQVA0AGX0i6qCK1tQpcF+qdAO8xjx0zqa5CBrvz2rnMLHnCuXl1Mr8XABbSIrUuIKMvxpNmE5FF/2ZZ9SO2lX4tEdjUCcxW7ugbiZcHb460/JjtT+2ltsev9NwIVEaeP9MMxS6nNp6aR8RD1hcRW7QZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757537092; c=relaxed/simple; bh=Cc+w7MVJQJo0DUQb98BGTv/aakQ6gRVawbdf+TbmC+Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UGmUjbOwYH5mIOoX3JFAUv5zZjOkNpXA+fJ1l2NsdilQz1VImIpOrBfPgvlmy5fe4SzxoG2r7gbXNV5CEXLA15MxbFRo7Qpi4GP5wEtojhmi1mGrwIae9JlGMjF3mXrhMvmHv9ivnAarutuGdbQRvAX4adRUnctHqXH2IYObAhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pBP3A2xh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pBP3A2xh" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ACgDl5020511 for ; Wed, 10 Sep 2025 20:44:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4zEFniw19gi8VanifAvhqImkhPqqb16gAdVe5GvYgBk=; b=pBP3A2xhm/9Vc7b7 5XvUZa38nD1PWzIpkMiggd2k3I4H5/dUjVXSHb/Csi+n5GghLhFxRIf9yJFj2Pgm dDVzvSmugP6DC6MjPHamzvuHwEqKXVROzU0rgxULgwGVgdOCxa8yAGaQHDgtfI4w /IPzr41fwgT/BK02tW5cMZKoJ45x+szN1rVh/Itb6VZMWGRSyWW3sXDRBppKwMW3 5QjdelzzVWzWzAqUM6tKBxq7qVWCqQ4QJ8A1yJer/L6z1Zi9eEKtOGcCkGzi9QNR 4qZVdoOZxB+46vtJPPodVPeeMYy8tn8reprRI6w9TQeJjXWQzbkD7z4+hP5Zezkl 4twIoA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 491vc299rs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 10 Sep 2025 20:44:49 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3234811cab3so8373255a91.3 for ; Wed, 10 Sep 2025 13:44:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757537088; x=1758141888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4zEFniw19gi8VanifAvhqImkhPqqb16gAdVe5GvYgBk=; b=WHBRsH4VFt8Yy2jzMl8K314PDokqXxEeoWL3UI6dg402bMLR/lhN060byfy6zitWGk aJEcRrXb1/tBIsWCo5hUWKWjW2i34deYkxA+Z8v2oH9qKteLVZi/bvwo6HhZdvQvA8CL PYNxftkSkHF/BcZK27Mq7vzMc4bJ2CeeBsM+WDKGgkLn/XwksFsYFEzX8/itJruJPVpm ShJrBMcjypXvqAXz8HwfhdbJpVKStqEAMpip16l0Szh0maxvdibuh5VCrbio9IOJ07zI SviPcq58ATnupISazrDGpALEeMti+bmw31LbaLyNqjaR/9UlYMXZE+lYWs83NXzDjSqk WfFA== X-Forwarded-Encrypted: i=1; AJvYcCUHdO4xsrD9PP3iUU0pYb4Tic4koedlGC+av3Oub+beenvxmQhILoIIlwnv1lT9adeRRmdfYVQKz36Qj18=@vger.kernel.org X-Gm-Message-State: AOJu0YxzM7rTZB4m4SCtlRWeUlQXHbCiuysgpX2zsNYa2qav2XjUfvER C4ukwrzNXhWSvfLHj5jRgFRh/fhnvDC16di6J1Bn/Wlkwxipqq2UmzD2TwjEAAv7fhXOwOo0Xyr O1TZwabTjyv9pfHPWeTM44JuL7DWjxaTCxwjnc2tJHmtik/g41BU6BhuZkd2PER2BouE= X-Gm-Gg: ASbGncvAN2mQpZQHoV6+a+BHpIqxeLYzekFqFibYazQ1s6E1Fv4fBIFBhwSXT7lwj8p i/+3RkR1LOdRBvQnTv7csMgVX9YB09w9Nh4Y+wTVndfgOEyEyW32Ebn8jUS+o9W/xbAA/kFb/Fh 2+j/OQZCw5O2uCkaeyx5ee5lSw2ejBbWam9S1GnqseDECU3cJ1z/gwtKu07aZjCsDnBHCz7hFAH IdTKDuktypxW9PQyLDR7XN89upvIdBlWJoGXJvC5fEcIimEhLwMc4G9WfMKnhgITix1pjo79Cy1 U6UXjXZ9lTV4P4r3pEh5+/PoBkf/YVeZ9T4iIMuVXapdTUonIZn+u3EVvirZhqh9 X-Received: by 2002:a17:90a:da88:b0:32b:97ff:c941 with SMTP id 98e67ed59e1d1-32d43eff6b4mr23734446a91.12.1757537087777; Wed, 10 Sep 2025 13:44:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5JeaHP78+QQF8BxRzGsrY0698vqlF2QsnYTCp+u1b2tpPw9ban79zLcuyfYHCSYie5Erv5Q== X-Received: by 2002:a17:90a:da88:b0:32b:97ff:c941 with SMTP id 98e67ed59e1d1-32d43eff6b4mr23734421a91.12.1757537087342; Wed, 10 Sep 2025 13:44:47 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd61eaa42sm46771a91.5.2025.09.10.13.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 13:44:47 -0700 (PDT) From: Akhil P Oommen Date: Thu, 11 Sep 2025 02:14:07 +0530 Subject: [PATCH v2 4/4] drm/msm/a6xx: Add a comment to acd_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250911-assorted-sept-1-v2-4-a8bf1ee20792@oss.qualcomm.com> References: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> In-Reply-To: <20250911-assorted-sept-1-v2-0-a8bf1ee20792@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757537061; l=989; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=Cc+w7MVJQJo0DUQb98BGTv/aakQ6gRVawbdf+TbmC+Y=; b=xWRPiIINeFvdpTfSw32jFQ/B9ZRSd9C0TetdrhgEBC7bIXtv5wFHq55xcGfI/ke/rZBcT3KGu bc7geSlPkQwCgsmEfhFN1DFSV8/fZ/hsq4a7zWaKlTfbN2ZoQJ+3FtQ X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Authority-Analysis: v=2.4 cv=FN4bx/os c=1 sm=1 tr=0 ts=68c1e341 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=p01HAiXOVyKYB5BxCaMA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: w8mFJvo4Y5CLlZl70YlyH0Csy41XT05F X-Proofpoint-GUID: w8mFJvo4Y5CLlZl70YlyH0Csy41XT05F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA4MDA5NCBTYWx0ZWRfX9kZXyCsfTJeG +YlqSinABc3DenxJrAD6rxqKu3jJIyK8KsUDQBDSCojdxZYPnV3opN5QrwGBI9cQvj+7fvpPZ/v 8cJJSVF86B2Ttmpxiw7S/Dy+0UCYCx/puRFqiM1dptecMfjrJAlch/0reF/3p2TxyVMs+IzzQf0 uRnSi4QF7ZyyJB1pvfl2XU26bIlJBIqhsFbOcNGOFMlmk549A04qeDG+8wkjBuPzr122upfN5BE NcUZj+s3lbUkRTBriaEkuibTag6ftviD+wpvYHzUuB84HxUfxh3So+tBp+ivmr9nxYKjOM/tqsZ FgOcmYi2PwdP0LDofohc7qKRFGAjzjxJWM20hWrhW7Zh+02ZVAHkO8hjPaSept8asUb18AmjhaM yVuTDCv3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509080094 It is not obvious why we can skip error checking of dev_pm_opp_find_freq_exact() API. Add a comment explaining it. Reviewed-by: Konrad Dybcio Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 4c0510cc784864da990af8cad086176a5d92ae8a..f81e28fb6f2ac4b1ac15fe50cfb= 488572009003d 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1695,6 +1695,10 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu) u32 val; =20 freq =3D gmu->gpu_freqs[i]; + /* + * This is not expected to fail because we are passing back a + * frequency which was retrieved just a bit earlier + */ opp =3D dev_pm_opp_find_freq_exact(&gpu->pdev->dev, freq, true); np =3D dev_pm_opp_get_of_node(opp); =20 --=20 2.50.1