From nobody Thu Sep 11 01:48:09 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA4C132A82D; Wed, 10 Sep 2025 14:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757515037; cv=none; b=T90s/wEw8TvIlvtODYFxqmZZZ9PvQz9LmiLaqD1+QQoaM0AzHuZmldhaVBXdNvscvAh35VyERGjIC1GXbB6JRmQ6nYZyupRnR+8PIUHITWD1ZOoEDRdkEshpd2FCfBb3wKAy/4naHhRZYm++yQGcauqWbriiK/jBlk+JTNVhR2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757515037; c=relaxed/simple; bh=4DSLJ0TDAmWPOipYbwhpaBlzGQi13TeCv46x7pWryak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oIdL15ZNw/vPdX0m4DX88RGM57xCJ10qOYz9A7ltFOan84JTgRnPajB3paijUGPxxV4Ize2pk1cOr0w+7XB3iaN89GL3W1zb46kovuu4HCUceQKNaRngmWGq21blUP6/w+GC1VgQyITAtb04WYb3X+TpnkWlRAkmJuxJf8TXZf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hrNBqVHE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hrNBqVHE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CFC2C4CEF0; Wed, 10 Sep 2025 14:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757515037; bh=4DSLJ0TDAmWPOipYbwhpaBlzGQi13TeCv46x7pWryak=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hrNBqVHEvwgF0wc0JzWFTb221izubC5GRAtDH4r7Ox9sdt++1A/9lpm+bTW6LY0NR LnFpU9QqhJv92ZgNdk5rNUor4wk9DZO+Rr7It0GNC3UIYslfyIKztzEU9JkUFPi6Ww Y9sV7OMaslefEkRtbbwyYwdQJ0tMIRSv8rG9GCGKj6up7o6ZNXxdaoMGFc+5k7vXDv AF+8UZzUHsKdzxbluaKClfFOuY+YgSIpCVC8pbNWz9r8WkK9X0pQG6N1wOkSM/rl+8 1NTJG21lGjdWIzn06wb0EI1mnG+eYb1uSwCeY/dgrUiQh3H0jPJ9qn3kxop1YZVTXl xTw8s6v5kprHw== From: Christian Brauner Date: Wed, 10 Sep 2025 16:36:47 +0200 Subject: [PATCH 02/32] nsfs: validate extensible ioctls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-work-namespace-v1-2-4dd56e7359d8@kernel.org> References: <20250910-work-namespace-v1-0-4dd56e7359d8@kernel.org> In-Reply-To: <20250910-work-namespace-v1-0-4dd56e7359d8@kernel.org> To: Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: Josef Bacik , Jeff Layton , Mike Yuan , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , Lennart Poettering , Daan De Meyer , Aleksa Sarai , Alexander Viro , Jens Axboe , Tejun Heo , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Chuck Lever , linux-nfs@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, netdev@vger.kernel.org, Christian Brauner X-Mailer: b4 0.14.3-dev-385fa X-Developer-Signature: v=1; a=openpgp-sha256; l=879; i=brauner@kernel.org; h=from:subject:message-id; bh=4DSLJ0TDAmWPOipYbwhpaBlzGQi13TeCv46x7pWryak=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWQc7GW/UeDIlDPzOMtvgbpShYzMnu/7/FzOfKzsCW9Wq jCac25tRykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwETM1zIyrNzHoH+a+3Wzm1Fw D+esu0+YNVYxJW5//cz097S+1F1qXxn+meT9mKnxf/YpfYUZj9dH91uUJC7+NcFFZGnw/JmXl4R cYAMA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Validate extensible ioctls stricter than we do now. Signed-off-by: Christian Brauner Reviewed-by: Jan Kara --- fs/nsfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nsfs.c b/fs/nsfs.c index 59aa801347a7..34f0b35d3ead 100644 --- a/fs/nsfs.c +++ b/fs/nsfs.c @@ -169,9 +169,11 @@ static bool nsfs_ioctl_valid(unsigned int cmd) /* Extensible ioctls require some extra handling. */ switch (_IOC_NR(cmd)) { case _IOC_NR(NS_MNT_GET_INFO): + return extensible_ioctl_valid(cmd, NS_MNT_GET_INFO, MNT_NS_INFO_SIZE_VER= 0); case _IOC_NR(NS_MNT_GET_NEXT): + return extensible_ioctl_valid(cmd, NS_MNT_GET_NEXT, MNT_NS_INFO_SIZE_VER= 0); case _IOC_NR(NS_MNT_GET_PREV): - return (_IOC_TYPE(cmd) =3D=3D _IOC_TYPE(cmd)); + return extensible_ioctl_valid(cmd, NS_MNT_GET_PREV, MNT_NS_INFO_SIZE_VER= 0); } =20 return false; --=20 2.47.3