From nobody Wed Sep 10 23:26:38 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75BBA1E520A; Wed, 10 Sep 2025 16:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522460; cv=none; b=pmPbDtj4OJ6W+HV9YNwBYdEMnOOH8Hkhl4JxZlSSW22fTcwipX/C9q9gBRFATQ8bGqg0SYCHoNg2Tk8hh6/P4np26mrNAoT/YJofe1S91K8/6e50981h29JIH3jXFUXwa/RzRoL3Rx8aYFIcN0SBGIDfp00RKuDWBqh2h8V+nyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522460; c=relaxed/simple; bh=uxOG//dCZ2ttzLEjwimxxM920Akc8lBjHA5Df1qVSH8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IuxCMTDu44b7xZpAiBO5yoim40sifdet9OZ7kqV5cGouP+WA/+FIEut493e2y+UuftWHARlZw6ili9W9CizSMBv7wfqHItK0TN1jIBTDTLCEGonzZgFma90wVo3Huqr/dx6G7/GxpGH1U9x4LknXnNCdJNXOAb05vMoeu4uyUxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=Ao6jSOZv; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=eAs3umGN; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="Ao6jSOZv"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="eAs3umGN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522447; bh=uxOG//dCZ2ttzLEjwimxxM920Akc8lBjHA5Df1qVSH8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Ao6jSOZvI4eYuQhAOVYudo5ZVZuzLaStBHo2Udj7o7eGNc7PBmg1jKa6kSzCrYqDz 42GVDaCDQ9IMJDkBgxiQlHVCor229SJgy2OZHuiKw2fVWqmFifwhCxJ9mmC0VKc+Zv yDXxLAQyQegpQdklwjazj0JTWRwoq4q9Uy6jwURJuIc3470W52DlWZJrmk4Wma0hEB Gpb9pm1I9lElrKc16+DlkeWIJDIuD3jOzYhJW6C2iwCMkOLYjJv8M5aMFBguAz90WY qHDMRNurLtUOL4JiJdChXEfngEHdBE2FLh/P7BjYZWcSO8Wo8LsFUZ/FYM7hhlQfIm cYikzrrzv43Bw== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 31875FB02; Wed, 10 Sep 2025 18:40:47 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eYp5uqBiyFwJ; Wed, 10 Sep 2025 18:40:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522442; bh=uxOG//dCZ2ttzLEjwimxxM920Akc8lBjHA5Df1qVSH8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eAs3umGNOboYL8sw290wkCngWZgmKLIlSikZ7fdjKzeLkcrEZeVyctIx6oEgTj0+Y N/FcnHjrZQX71XWIiVB5NgDtvnNzLVMxklsIDyyZesAG3kjkwCKyyQ+5DfFVed3VzJ qnic2AMNSQkz5crpYNQsVEqhDmF2Sml54fGbwnn+F8ZHLaxj9rCU6WlgxZJM5yCm59 iFn6tijMphlqnUHJaSBT839sevKjNCHkotXew7vldCsQs7r7rxKVrGQ3oQbpUC5Unq 9seq2jMU2VHFjaSQqFfes9wEWYlL9Ke3lGNYmgUD2M5KIYgNHi7dwaSMVcoCkQC4W3 oVnto6lc6sZyw== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Wed, 10 Sep 2025 18:39:56 +0200 Subject: [PATCH v3 1/3] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-shift6mq-panel-v3-1-a7729911afb9@sigxcpu.org> References: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> In-Reply-To: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Kaehlcke , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1097; i=agx@sigxcpu.org; h=from:subject:message-id; bh=uxOG//dCZ2ttzLEjwimxxM920Akc8lBjHA5Df1qVSH8=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm93YW41RU5obEFMWEFIbDdHNFVnL3JxbEhFdTNXCnUyaEZFNUkyUlZGUEhqVmJl MHlKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYU1HcCtRQUt DUkFsdjRaU1N2ekI0K05wRUFDQmh3ZkMzVzdjYm9HeU5zemJUWFlFNUk3Zk5jZHY4cXQwYjJQUQ p6eTk0U1JBNFh0OFJiNXE1MlJQVVdZelI0NzVtTnFEYTNJZk5lUGZaaTc5OFJFK2t0Y0lzdVpsV UR3TmlaZ0hXCmtaakliRVB6SVR0NEdFMC9ZKzEyeFE1eHV5Y1Z3Y2hCeWtkVDEyc1NKQmxJWXdV bndYRDFTODc5cnZRSjFOT28KVW5pVW41dTZ4NjRtRk8wTkpCMEloTXNvVjlIbkVBOUxqeDg2UXl sUXJQQ25ZUkhPOW9kYzZhWlYvVlVzRVNDegpvZ2VRaVdhclRnRmh0NVdkYzVXZ0twekNOYTdvN2 puem9sbzVtc2R0VGNWbmlhb2d4dzNPcVgvUmNJY3RsTjE1ClNLNEM1NElVN0ZFSkdpa3hPN2UrK 0FuTFRnVnFUZkFCMnp2elhVSlA2Qkx0SkpjcUgwV0pLd2ZJOHE4RW0raFAKVkFiUUk4ak9najJm a3dSSjVCZDNkS2ZZWkdRcXMrVjZjd0wySS9mQUF2MS9kOGpEZ1dPVGFQeVFWbGRpckJYdAp1dUU yVm9la1k2YlpNV2wxSlhhNnNXR2E3TnNrSmFnNmYxODhnSHRPcnd1Wk9rRmVFSUJKUTBoZ2NkLz FRV0JmCnVjQmNhcEdBL29MR084dWI0TytWTGtjVXNlL25aLzVZK2JRcjdoNUFCY2x1N05Sd3ljS TZOSnVKcGZlS1M1U00KVDUvL3RyRTI4TisxRTVITTZVVW41ejNNZGllV2E5UXIrbVhlSkE2U3pH M1JvQ2tJMlErZTNrNlZPNnlhbmRTRgpLdnlOdFJQU2dabGQ2NmgvcVpvTktQTndwUTBHNXNYQjY 4QzBVMEIyRDJNUHJrNnNVODBCUUk5bUhGWC9TTDRzClRmb1FIQT09Cj00SEVnCi0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 Make the clock frequency match what the sdm845 downstream kernel uses. Otherwise the panel stays black. Fixes: 783334f366b18 ("drm/panel: visionox-rm69299: support the variant fou= nd in the SHIFT6mq") Signed-off-by: Guido G=C3=BCnther Reviewed-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 909c280eab1fb408a713d84051a1afbb252c45e8..5491d601681cff52eca1d72ad44= 89731d2276c30 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1= 080x2248_60hz =3D { }; =20 static const struct drm_display_mode visionox_rm69299_1080x2160_60hz =3D { - .clock =3D 158695, + .clock =3D (2160 + 8 + 4 + 4) * (1080 + 26 + 2 + 36) * 60 / 1000, .hdisplay =3D 1080, .hsync_start =3D 1080 + 26, .hsync_end =3D 1080 + 26 + 2, --=20 2.51.0 From nobody Wed Sep 10 23:26:38 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA91274B55; Wed, 10 Sep 2025 16:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522462; cv=none; b=Hnz1lbRW4K4oohUjquMKQzzNi5w6j+avIBJL1sG1dNYwV+4Muvs+2803p5J+Cqqn4B96QNlZRzf56Af69ea4dO0IGQ7FItZY3Ck8KQsedDP353LhMRs/bIXX8zjkRmKVqvD3q8NvpVnKQamyQCiaPzOankGI4sx4x9Zo+FT4jD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522462; c=relaxed/simple; bh=AmkVaPd4W0IGCcGVWPaikGijSqrf+XTEGsS9JnorjY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m8RrgQ2Y5M8c2aQymkYAyUEnEDE6CyX4dujiq9YSQDE5kPaZKQUXI3CmYXpfH23yA71Rl/rpgA9wGl+OwfStsPHiBY7ZXwvrCTPrxwDZODhVqfIm9Zx7Fzk3w78TX9H6k1Vkjrs6PqFjV/uqLoJMIj7MM2fogQ/IIEYrgUe5p1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=qB4Fcwzl; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=tAeyAZOR; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="qB4Fcwzl"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="tAeyAZOR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522451; bh=AmkVaPd4W0IGCcGVWPaikGijSqrf+XTEGsS9JnorjY8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qB4FcwzlNu+hX+EFrUiNyHsuOGj71VyJ0e7ZCrmCbeDhyLS3/pUujk3b7ptO/6P1f MXO8q2kf/10ykzplFhAuVcx1AkVe2p4ZIDbr3gabJmEL1bRZO21LsVgxYEdy0Lu2Ih ATLw/9w8IP09dX8MJICz7uWGlAHfQXnuBMe0XYvVnpY6ypatVTy1YMRPl26P4zRt3y PuLUX0tyWLMPMvMP2kCuMG9f7i62uODRRkmrU8FoqWvMToE9JKMH9YQdEhlBNS1Slt tqvl/FXaXjQ+tYB1VACC9vwic5Ed1SPDXM01QiOItkkdtZIcNwLtJo5bV5zvI9yse9 +qV3FSYVigakw== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id D6A27FB04; Wed, 10 Sep 2025 18:40:50 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AtkdT_tRGf4e; Wed, 10 Sep 2025 18:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522443; bh=AmkVaPd4W0IGCcGVWPaikGijSqrf+XTEGsS9JnorjY8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=tAeyAZORJsJEaeKv1y628WYk363EI+qY+vFxgUKiYNLfkkG1Q7deEfGxuPRrEN7DG sbWI01HBq1VrhI7vrY6Vl5owQJ9EuzGxra+VY4z9lRF4zeNLXx37LIkmKfL6cVV5ah apSBAF1gZgUaVfl5BU24TsDM2GJEvpAK9IXWH8PCPg3uoRQ/qY4tda0QZhX3+dzB/I SxO6E1ZF4mkhw+NYbNBjxlUesjzeiKJVt0H5/GnmhnTkMuIjl3MA40gFPoaXw9pEkj Lhk1DobV99exxNGIpy/ELaOXmlqiVgKFIEdMHt8tJ0ZbduayQVHNMKTcklx7m0yS1s G8eEPafV+usuw== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Wed, 10 Sep 2025 18:39:57 +0200 Subject: [PATCH v3 2/3] drm/panel: visionox-rm69299: Don't clear all mode flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-shift6mq-panel-v3-2-a7729911afb9@sigxcpu.org> References: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> In-Reply-To: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Kaehlcke , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1051; i=agx@sigxcpu.org; h=from:subject:message-id; bh=AmkVaPd4W0IGCcGVWPaikGijSqrf+XTEGsS9JnorjY8=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm93YW4vemRRZ3pUekdQd1RYQWRyL1Y4bmlDbnZiCnVLVFh5Vy9VTElyZkJ2Q1FJ bEtKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYU1HcC93QUt DUkFsdjRaU1N2ekI0LzBkRUFDdi9hUFcybVVJSk9zc3hDeDBEMzdFM2todXVjNG1EY2dXWndETQ p1WlpTVzc3ZmlldUlTSE5JeC9zUUwzMzFmbUIzeHNGdDJNVzYyMGFIV1kzZVFuUWEzZ1A0TkZLd GlvU0ZreTlRCkY3eVkyV0dxQnpGZnN6VmlTNDdPRGtxaDU3UWtnUkZZMnloc2xHTGordGpOVDdv cmVld3JqTzZGWjJCbkNuY1UKamF1MUhFZncvRkphVVhuRlhua2ZZeldYMmNPbUZJN3R0RGJUOXZ RVkFnZjB0SWgxdFJCeG12bGxLWHd3bkRpbgpCV0xHbWk4eVNoVU5KSU10SVVBckdKQVRZblIzb1 lhb3Rhd090NWJMbWhlT1NHdjFQbXBrNFhDa1FNck13YVJrCktGem90U2Q1OGhqUkFBVWw5THhKY 0VjN005S0VCSkZzZWJNd3RvY09wblZWTjg0Q3NPcFVTZXlxeWxZV3FDQ0kKN2g3TzFVcDBZN2Zr Z2dGalRpYWZpcW1mSHVSeDRkajBsWHBHZUNnVGE1K3RvT3ZvZFRqYzlIaEdmUkJlbUJONwovYWh wdlBaSEVVOVp3TzJLRnlUbVM0TjdLR05DVkF1WDdjWnBRZTNjZ092SmdpdXBzVXZWN3FzU2RKeE 1GTVZnCkFHdERweUZxRi9UaHNjcEwwMWp3ci9COVR3VEZCNnJ2RG9Ka2d0VDZTUTJNMzdUUDhXT XhkMVJYYjBtczhoR3MKakVoMzBld2lnMkZqMzVPbElaU2owa0cxYkRBSk9IdFlYWFo3U2FIam9D UkszVFdpNFVzVlpwc2lIam1lSW16OQowUzZDTlRnUmFoSXdRa2svSGxmMFVpdWZMbXdORHAvSlJ EMXcrb1ppai9aMlNtdE9LNmQ0QWdFYmExdnorZVFxCnIwV05PQT09Cj1tY2k0Ci0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 Don't clear all mode flags. We only want to maek sure we use HS mode during unprepare. Fixes: c7f66d32dd431 ("drm/panel: add support for rm69299 visionox panel") Reviewed-by: Neil Armstrong Signed-off-by: Guido G=C3=BCnther Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 5491d601681cff52eca1d72ad4489731d2276c30..66c30db3b73a71f23b587b6e994= a22dba5e85d25 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -192,7 +192,7 @@ static int visionox_rm69299_unprepare(struct drm_panel = *panel) struct visionox_rm69299 *ctx =3D panel_to_ctx(panel); struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; =20 - ctx->dsi->mode_flags =3D 0; + ctx->dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); =20 --=20 2.51.0 From nobody Wed Sep 10 23:26:38 2025 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54DFE2773FC; Wed, 10 Sep 2025 16:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522463; cv=none; b=RmyqdUV41thZUJSzUr101p6YROpsnyClT07YKaNu8rj9oOtTao0ikO4u4YqE+VuvhWDIswZ/2D2dfrGzNrb5+1Pz/Ri5gkMIemm0yjIMHtNtBizQxG3efKs/9RvhyAFHP/ok6uF4tbFvx8hjEwXkGwVwtE/pZiNZdUMyD2Q7tek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757522463; c=relaxed/simple; bh=9Yw8grUh1cFbMy7hkshDzj8q9xtvDCOgYiEuQuV7J9k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HIsKQtTd++wa9z9P4/tJh95/pvywZQHCmUrmSjQz8VdsS7ObfN4PEDPLRY7E2jwz7frmIYgnZQTXOEFjdReUu/0D7hxdirY17lFYBSoi/SGdjIJlu3tZIdzAXoeubXOEDwAXISyQsudrcomouiAu4sMuNZ5AN+08X1qLi0KEqL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=xsFVk8Ds; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=W4IO7sqX; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="xsFVk8Ds"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="W4IO7sqX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522453; bh=9Yw8grUh1cFbMy7hkshDzj8q9xtvDCOgYiEuQuV7J9k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=xsFVk8DsqIGPSC+X7iAv0Mg1cNVHKktwiyjXwxvMSXt9M0K4A7rvPcdgVTehb6xFg 10foLL8BsTJlafCldlxEF6qkAkPbVopf+eISE2NagCiXNZvauNWZkMAEq7L0Pn+Q2z AeHn2nBDWk1qLzbmM3gLXWGcJJArtj3PQtpxdzAKDwHT9uONOJUyr+60RN6Wm/2+Cy 5nZi8gwShHJVr05RNBI+6AQ6b8JpSRwI0Co9Ym+j7FzaT6ZiwAtIEV8zzWUxtrMU5P mHHztVnoL4Hg9JFihQ7xe9eajuzhkKUYyWiIchgalhNZsKNppgEBMrBGdqbHme2tkn U/4hE9vOhT1iQ== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 41FC3FB06; Wed, 10 Sep 2025 18:40:53 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ys9VigrlREY; Wed, 10 Sep 2025 18:40:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1757522443; bh=9Yw8grUh1cFbMy7hkshDzj8q9xtvDCOgYiEuQuV7J9k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=W4IO7sqX6tRHtGIITLRKPkLbTviYwhyvT7Nk20CsnDi14NyT/QUwZewg0+baGb6wg SRN/lUtGVcu4wR+SgPCy5ulXzvvRClceArb7UN5ZBGJQfuL0FqkXsWPycRoE7ymUJy UGo7qnE4AWgzOX/hOPEnl8Hq4CW0fqfpy02GerQVEPoDbgoD6ve0jYScePXQN4kXQG zQQ+mvNjZvRv3pkY6yp5Xo132vX5d6CaXofvRSD9rJPG9tp++9vQnt+0IMGgLGGeLA KkyWnmhjHFff4Wy11zgJdkXtzLa1UPYAMHSD55o6UhLh0OoEDwBDVTSFSW2AvOlpu+ LF58ZO9sCnJVw== From: =?utf-8?q?Guido_G=C3=BCnther?= Date: Wed, 10 Sep 2025 18:39:58 +0200 Subject: [PATCH v3 3/3] drm/panel: visionox-rm69299: Add backlight support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-shift6mq-panel-v3-3-a7729911afb9@sigxcpu.org> References: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> In-Reply-To: <20250910-shift6mq-panel-v3-0-a7729911afb9@sigxcpu.org> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Kaehlcke , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, =?utf-8?q?Guido_G=C3=BCnther?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3690; i=agx@sigxcpu.org; h=from:subject:message-id; bh=9Yw8grUh1cFbMy7hkshDzj8q9xtvDCOgYiEuQuV7J9k=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FJQVNXL2hsSksvT UhqQWNzbVlnQm93YW9FOTBXcnRUN2lwQnRFYmUrRDdzMkYyMm5UCm9KQnU0OXMraFVmL2hVWEhB OENKQWpNRUFBRUlBQjBXSVFSajlzemZsaUtkQ1NocktzTWx2NFpTU3Z6QjR3VUMKYU1HcUJBQUt DUkFsdjRaU1N2ekI0ODVqRUFDRlBNaHIvNEQzbXdPVEozNW1HOGxuWVJzYTRTVFZMZzRrN1F2bQ pzaHNROFk0d1dkbWJHY3llQlhKQUZqRUFOZ1VsRUxsK3A5Z1VtWGpNSFA4QUhvd0hzOEdEVWFYc U1jRlRqaDkzCmNrb1pPOUVsRFAzaW1URjU5WkkzczYyYXVlOTlmUjhranJ2ZnFydlVqOTc1d0Rw M2tMTjUxYUJUakRDVkNaRi8KZ3h6a1lQUUw3a2pOR2FFcG40cFpHaWhQWHVxc3RiZUpYUlNmNE5 jM0JnOUEzTTNBQ2oxRlVKdjVSSUtDTnFkYwptU1QvOEUyYXlOTVNXa2pjVnpaZU4wODQwaTBQeW FBOGRpMTZDd21FREd3RUYzbFhpMnVjaFJvRUoyUGRSMTJxCjdadzdNaE9idS84TXdnWXljSmVzL zhrcXQwVjMxYWVjNEplVndCU0pyL1drdEdvQldTaWVBUGNsWW1US1oxMmwKRUs1N1RCWldtV3Ba OGFXVjlwVjd6dm8vak53dlJ1UGkva1c4MmVHMkNOSnRnMTVhSjlFL3E2Q0NzZUkwMHJEdQpKVFN wVlBHQXFiTStnWG9rZnY3SXNhZGM2QlhQOUpBN01SdllsZHFmbGZKb0x6ZmtHZDRXd0FreUhaR1 NiWHUzCk9MbzJXTjQ2bVRsdCtJRndMTzA5ekRDTlZibXZsK2NqcDV1dUhNSnRReUhKWllYRlpVZ 3g1eXFmN1RyeUdqMEEKQjViT25CcHZRQzMwcENvRHdJS3FUdFJlcDNuWTlwa25WaUFHTXRPeEFJ VXNvTEU4VGRvSlplTkorenZWSWd4RQpwWkdURytBb25vblRUdlhDcDVodTEzWnRCdEpyekk0c05 OTVVDWGNmVHJkUTBlQVk2U2pqYVBoSzA1akVCdjNWClU5NGlmZz09Cj1iQ3JjCi0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=agx@sigxcpu.org; a=openpgp; fpr=0DB3932762F78E592F6522AFBB5A2C77584122D3 The shift6mq's variant supports controlling the backlight via DSI commands. Use that if a max_brightness is set in the device specific data. Reviewed-by: Neil Armstrong Signed-off-by: Guido G=C3=BCnther Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 67 ++++++++++++++++++++++= ++++ 1 file changed, 67 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 66c30db3b73a71f23b587b6e994a22dba5e85d25..e5e688cf98fdc571ae9726f3c9a= fe7c83db1caf7 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -3,6 +3,7 @@ * Copyright (c) 2019, The Linux Foundation. All rights reserved. */ =20 +#include #include #include #include @@ -20,6 +21,8 @@ struct visionox_rm69299_panel_desc { const struct drm_display_mode *mode; const u8 *init_seq; unsigned int init_seq_len; + int max_brightness; + int initial_brightness; }; =20 struct visionox_rm69299 { @@ -285,6 +288,63 @@ static const struct drm_panel_funcs visionox_rm69299_d= rm_funcs =3D { .get_modes =3D visionox_rm69299_get_modes, }; =20 +static int visionox_rm69299_bl_get_brightness(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi =3D bl_get_data(bl); + u16 brightness; + int ret; + + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + + ret =3D mipi_dsi_dcs_get_display_brightness(dsi, &brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + + return brightness; +} + +static int visionox_rm69299_bl_update_status(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi =3D bl_get_data(bl); + u16 brightness =3D backlight_get_brightness(bl); + int ret; + + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + + ret =3D mipi_dsi_dcs_set_display_brightness(dsi, brightness); + if (ret < 0) + return ret; + + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + + return 0; +} + +static const struct backlight_ops visionox_rm69299_bl_ops =3D { + .update_status =3D visionox_rm69299_bl_update_status, + .get_brightness =3D visionox_rm69299_bl_get_brightness, +}; + +static struct backlight_device * +visionox_rm69299_create_backlight(struct visionox_rm69299 *ctx) +{ + struct device *dev =3D &ctx->dsi->dev; + const struct backlight_properties props =3D { + .type =3D BACKLIGHT_RAW, + .brightness =3D ctx->desc->initial_brightness, + .max_brightness =3D ctx->desc->max_brightness, + }; + + if (!ctx->desc->max_brightness) + return 0; + + return devm_backlight_device_register(dev, dev_name(dev), dev, ctx->dsi, + &visionox_rm69299_bl_ops, + &props); +} + static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) { struct device *dev =3D &dsi->dev; @@ -316,6 +376,11 @@ static int visionox_rm69299_probe(struct mipi_dsi_devi= ce *dsi) return PTR_ERR(ctx->reset_gpio); } =20 + ctx->panel.backlight =3D visionox_rm69299_create_backlight(ctx); + if (IS_ERR(ctx->panel.backlight)) + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), + "Failed to create backlight\n"); + drm_panel_add(&ctx->panel); =20 dsi->lanes =3D 4; @@ -353,6 +418,8 @@ const struct visionox_rm69299_panel_desc visionox_rm692= 99_shift_desc =3D { .mode =3D &visionox_rm69299_1080x2160_60hz, .init_seq =3D (const u8 *)visionox_rm69299_1080x2160_60hz_init_seq, .init_seq_len =3D ARRAY_SIZE(visionox_rm69299_1080x2160_60hz_init_seq), + .max_brightness =3D 255, + .initial_brightness =3D 50, }; =20 static const struct of_device_id visionox_rm69299_of_match[] =3D { --=20 2.51.0