From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F251C269CF1 for ; Wed, 10 Sep 2025 10:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501058; cv=none; b=szixMRbZy+4+fF3xqmLneqX/Kja+1jwrjGPK4p97QH7kN4G1mB7Cbrg6SiNfX2qzRVfwW0vvgIb9qJSa6KlXP/3SXmhBQ0Y07dT4empiWh1JR93Ko48+F4m/2Dk3m9iwEcpORAuFlO1mvqpDN1Wu7IBHb6f86fCWlrIM+xbG2Lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501058; c=relaxed/simple; bh=LQehtAx2kmaY57h5u012j/ttcRk/Yy2y8c0kuDacy/Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o0sQOHtT7O2L1dqGaMtcptxNM7MVtVLdJ3ptvwGeqEXjCvWlqC0qm54q8lyesVEGpe13QPDgHRkf7wBU8Bjpz9bH7nunhleOO0ef7eOr4PIj9FiLMY1l4V6N2qcnTnGIYEdPGvuYptsp983is/a6NePQF5dC+7jOHaoqsjr+K8E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G2FtIkHj; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G2FtIkHj" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-61ea08e565bso737751a12.0 for ; Wed, 10 Sep 2025 03:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501054; x=1758105854; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DJlYrA2HvnrAW5ag27Ypg8qPNoGajHDP94gxoPy/A6E=; b=G2FtIkHjjtRKCRMkNT58GH6FogHxVjMZyFAabf44v3PwhXwbxnOzrwo983oaip5TDf DFMjCYbXYcOz4gKTIV3U3TuzWaLX61jwXUfRDthw1oFR22bbBNHz0WrXnUjDociz/5jm O0pRH0OadGy8QzhpNA7blGgEHYfFZUgm1ZJB1GBpet+Lw0KtbUynicGehnFS/SvXUGF/ Sa71EHx+IkHP/V9dJBXHx467D//qfOrHsZai4JeGxNNOwJx28EXFpdYbXf1P5PwU+uJO xspn50EFaGe7L95VC4tDZFtDI5EtN7w6FdmP9cIxmhpUag9yk3reBS9+QZA/Vm15aOI3 9ayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501054; x=1758105854; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJlYrA2HvnrAW5ag27Ypg8qPNoGajHDP94gxoPy/A6E=; b=oZv+nMabdF7IjunYEtw5B6tnPUttamkck6gUydOEgSe0scbse9PsU6/jGlKY0L+0JN Psva8S0gk5KlppMFV3RBQ7HPZa4a666BuB/fMIizUBZcRVl5B5z3ZUunRjuB/7cd4g3G PXG1J+3ByPkhFPjqx+uXlX7R4izeZDEpr5dUcvvDzLWkjNu8faP8QyupvRazACJ1aGG4 e1Olr7RbUOfwcyVhRS+Tf+JO3/EVGwcXu0eVPQnopK2C/tiEsRjeqoI5MJSaEhu3Kdm0 ohi0kG2DQkEnIop08+VQdyeQgcQLujxCyjugcT6cNfz24WIF/vIt/Oksm1brnGtx6XLL skCA== X-Gm-Message-State: AOJu0YxbGaDa9mHppf439DX8g7l5dPWWeohnZm67neH3LfuWX7emG6+H Xj4MyqTWrK3mlq7tYUy6Fr3YK/1l9/29tqQzJmr8dHTjp8oHyk+YoZq+3lg5RQWwiYw= X-Gm-Gg: ASbGncv39XzPYIM/3qubijlvyoS04xEEchRWjDMJTTeC7jBu/Um3818Whj7yjdLHiuX WywxNoVMxpybvLDMMr9II8guChCbUnP/6LEp7jOXu4yIcaDB7cCpsQ4SnS+xbv5x0auy+SMGJKk 34CAqoWirpIYcvHNVlc6i1BX9Rx+pksvxbjdXKYgGsDNX7dDXVIiHIKY3oTZu06pxBrZDH0OnMe DCjBv53ExC1PfgpITDUGgvMsajEnmnB4rJ1lXffJjbf5Avr+ioZrl9pRCivDsVjdy1DRnqUpvKS shpyy9CEpteIoDpfqvE9idmyhUkDAydP392yqcLg69Ao1Z0iUY8d8nQEOOzGQuR4K4x18kjoKXZ Z1Tn05qwiPPQMfPn4SnGDasy5yZQVyd5F3l9PY+X/Qwq3VTPcdA== X-Google-Smtp-Source: AGHT+IEsbT70WA0co9xUhwpaWZsgJv5uTtdJ6Nltro31AURb0/cmiR5p357gd13wnuViD2P0JC7AOw== X-Received: by 2002:a05:6402:520e:b0:620:bf3a:f6dc with SMTP id 4fb4d7f45d1cf-6237f37d626mr6201259a12.4.1757501054167; Wed, 10 Sep 2025 03:44:14 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:13 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:43:57 +0200 Subject: [PATCH 01/13] memory: tegra124-emc: Simplify return of emc_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-1-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1374; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=LQehtAx2kmaY57h5u012j/ttcRk/Yy2y8c0kuDacy/Q=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZvbVtQiBWq7kKL7wqwIdyXaSh4vUFKxi4Nu jPvYcek1pyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWbwAKCRDBN2bmhouD 1zOTD/93fxj5wirNSqO33U7YLJCBdMWpkWuctswCzYdN4zvpPNv3NXROTZXaO1B0awkxqvMO4TO 40hvcqsVr/pBxZ4ybn14FSQcapT/JHGp9T8kp7e4WLnVqsVATxWj7BFBwSUfjigEcNoqIAdthJl iw/Rsj1/pzWe/JEHqvWmtRhiYNTw/EA/rD49G+V4M03XYhrSQeYgaO4nRSpQJ8spNp8Ta7vE+qn 1J61Z7r+VO+LSH5LlBFHgvyRGAuApcSoPPVNms1eYy3ksm9yuDeuM73OIrW5EVYvT4XQFIovVKX OM3wp8gsU/sNfD52eyMpLP/mgB5YWUjccPQGB//9Lu7hYObSiu9Fh9heNMWO/Dkw7A6VXllJDB/ rNWXGn1uc4zgKBaC3flbmJUhu4cXdbdtMSRrQrb0E24zDbT91PX/YZAs4HJzvFFiH7AXOp+T7Cj Q/+8dPe8awgtS2uuI8fOUlN4nHYjog+Yut77a+rKtlgcOQScZXgLfWESDpi/n55sp3N/J94aNRh NuqmrBpT64MhwtHd7S/qLHvcoK9m2pDn7dEZ/ub9GqCZlCBYE4DHrEDEJMJbA5LjxleDFvde0N9 h3bQHqFQ6n1BjmeHbLInd3wzLgo5VIygdKWV+u0lksA/8WMR1+WpC9zGDbKr9xhRqqwurOicB88 8kZElxNvKFoOSTQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B emc_init() returns always success, so just drop return valye to simplify it. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra124-emc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index 03f1daa2d132a81d28705ec7c62d640d7d25a894..9aad02901613f1b2ed855c11bcd= 76fef153034af 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -896,7 +896,7 @@ static void emc_read_current_timing(struct tegra_emc *e= mc, timing->emc_mode_reset =3D 0; } =20 -static int emc_init(struct tegra_emc *emc) +static void emc_init(struct tegra_emc *emc) { emc->dram_type =3D readl(emc->regs + EMC_FBIO_CFG5); =20 @@ -913,8 +913,6 @@ static int emc_init(struct tegra_emc *emc) emc->dram_num =3D tegra_mc_get_emem_device_count(emc->mc); =20 emc_read_current_timing(emc, &emc->last_timing); - - return 0; } =20 static int load_one_timing_from_dt(struct tegra_emc *emc, @@ -1472,11 +1470,7 @@ static int tegra_emc_probe(struct platform_device *p= dev) ram_code); } =20 - err =3D emc_init(emc); - if (err) { - dev_err(&pdev->dev, "EMC initialization failed: %d\n", err); - return err; - } + emc_init(emc); =20 platform_set_drvdata(pdev, emc); =20 --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172B230648D for ; Wed, 10 Sep 2025 10:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501059; cv=none; b=rb74nI2wQu7vCEQR5J1GrURpjn43WpXXb1ocqJLN7Ta6a2tjQFUG8v/ekUvTgfdaUS1U8aB21Nq4AIuWi48XBNdCXCHRzko2gE1h122X2G32I5esLwNN4x1NoHQnUJThtH+GikKHRux2TGgPzJ9TAHiREif80wuGtWLqDyu/MUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501059; c=relaxed/simple; bh=+1ac3GUtdyb/dGqR8+GvO4DnEY81F76aKbH4bVPkyxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G25RAOCv6zsLvCehQO3B+5B2XICnJUm/tX/6C2FcErYhp5G4/zaL4rUeUxbe8uMbfqxppA9pDKHvkRAdnps5HvcsGNpgYAiUttmqJi4syIfJWP2fo7KeaBYGVktZvRqHEuyGLxQS9cw20xGpr61iyLd149YBvR+0LV7jZgywYnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F3Z3ITp5; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F3Z3ITp5" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-629f06935e6so684377a12.1 for ; Wed, 10 Sep 2025 03:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501055; x=1758105855; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WiDSDs3vgPK4naVERjozVRDiMqNnwv/gBegchhROC9Y=; b=F3Z3ITp5JZuSkEq1hregftRiGURgb+i4NQhT215aY/RdSZecDspVhQfF73cMPU/F6Y r1+WsKX9UtMWN07ZKUnpoUP96ev+sWhnLUmamBQ17lDyhVd8tEIfC7Wriaa9BTuiPNNv 7xkP6m0TuXhPv4zy4T1sF7DyzhCB8T3+1SzwjS0QooCBCgsWkz4Zi8dNhzheRoMt5Ydc 5ljTD0fFWIHgBnxbvry/zOXAM0VWzCWgJCU5/CmUknRurpinT1/sGGjTQQwVUnqb78xP LfFIkbGaidRDes7nsJYaGQnwXOl38xQgkFX7+JQCBo3XFE3tP0zSVk9eLr4PW71hzRwg dIRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501055; x=1758105855; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WiDSDs3vgPK4naVERjozVRDiMqNnwv/gBegchhROC9Y=; b=hHdtkXqEk+TUWbwNq/TlOAAI2QkhR9jhabZCb2No5pmaP/vd9Lp3T4br9xn0ZbeSho Z1JKOzmu7Jdaeel5dyN2CPYt/gZwbO3uaNz9jAHx0ln9Js/j4OMZNDkNvBNs34RWFvR1 elr8aPBMmPRsSmwyJ14zokFhQa3yODncwZqQ0ruQ6QtE83DvjiTW/x+YRpTrPHj2K/l5 CNPV3HQfyDNRdlGJNldiJwvdDQhgH8uxnnVQqZvZIOVTLjjMW07NGuTF3EXicNLnN0cC lvwDMlGYVCJ0dYrnl4YOy4WbecR5H5Vdp/3iTb/TJP76fsb2AiMXTBrYu2WiaSZDmqLp 0cYw== X-Gm-Message-State: AOJu0YxKNuNMJ0eN+37Aa41cZNtY+FX8U6KdzIUqEoyVMgapg5+oCYAH jNSi45g3ZlRHWjw6YK+zih9z2VcqSAju8cNW69iXcxmZxEBcmg7AgWda9DwZSzDr288= X-Gm-Gg: ASbGnctlPvOpItkRkcbOp3BNd3nPnNS2sg5Wj1BkYwk9LgKqDbkrq8Nwl65rrZsSIei 7U3SMyGNF+yNk/5/EaF4x1c+rc3CwigjRuGV36ODbzqJV0yCTvlef+PlXsJ9LtVHisE0LpBOjaq 9bKFhERNQIPZVt1Fr/NWbZj7fMEf9aCm+7JvSeGaNdyLH44mLVlHIUTWjsJIqUvy8YlaSycCzWe TijG3wTCvfXzdSH8rPg2dbKsHb7mMdLA2N18davzufucaHpE3YVcCde/xYkS15weSmrnU4UdL1Y xnyypDb2Ss18OzRbPFFTnQauGHp6EThpzmDEtb6V8q0u/frNwe8bQznFqauRrO7ONsP1ItXlSZs q6Z4mBw2i4Q7uL6kqOI5t8ZbV3MR1vZK6ijkv7/Y= X-Google-Smtp-Source: AGHT+IHdm9CW5J37x7w4w6YiBADoTpSU61DocOxKYkYVYgBvdU9khcBxjYJ/0bHx7R0zRRKmXU54zg== X-Received: by 2002:a05:6402:26cf:b0:62c:af05:5814 with SMTP id 4fb4d7f45d1cf-62caf055e34mr1668538a12.1.1757501055395; Wed, 10 Sep 2025 03:44:15 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:14 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:43:58 +0200 Subject: [PATCH 02/13] memory: tegra124-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-2-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1227; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=+1ac3GUtdyb/dGqR8+GvO4DnEY81F76aKbH4bVPkyxo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZwT3CDVMrlONPdbY6jb2lou5Qzq4s0WqSSA WTLLi9mfjaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWcAAKCRDBN2bmhouD 1z/4D/4wQDr9ImbS8nVtZoels+VrzmHSn2Rn7SqdrZma6/9cna4iaQBKEW0PVotkmNWHCgYVKwW MX1q3lgo/unq1+XXRIT8MDmbPaAtibG/hi9O6ymO1DDp8GzRtI8E6/Aeh6mlpPeyj+H6YwwpeUj Y7spFWZ0fXFjor0fFwCOQ7ciKRAi0RC/z0NoLSeSNp+6NydPNilliS+nmF1zY1PeZTmUGsWOaOZ yqYgGrc6koHC+ghjcmp/dakCHy1tdwKJq3TXZfJiIad8rBzGOa4xgTFXsQ6+m7LHht5v4d7uBu2 QK8n5EfObDLKxZq2oVIXfc8sucLyG4zUDH9F2ndJpBucEfWEn+j0/LGZPuOlTGuH/IByquDSqy9 5qHvgM3KzFqY70NM+Fe1GWIeojMVYoQqRnYQtKjazEVRiQvRI7iAx2YFDGZHwcRDvRjNKG1ClRA MR51FfRSr6kMy2hvYvmlep6vAuTlpRZxWyBw7wh53/ZyGyBc3R2uWiXWb9a4RibASr5kgluA3hE wEWyh5rllJglMLCVnJTbGtB/m8wESG+hqDmIyZowUjoyd11d1CFBU1bQTyVNTse2AIjee4R09uS eqjNXx9fuvaoeMf8XRxvkTw3h52aXz/dGyfVDCAE8fr48zzl9lH31dhZNXt3NHQZdh69aqVw8tZ goBtZtGU27TngFw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra124-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index 9aad02901613f1b2ed855c11bcd76fef153034af..f3372bd78ce8db666015a7844cb= a4e6aad79e61c 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -1350,10 +1350,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1381,7 +1379,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DAED3101BD for ; Wed, 10 Sep 2025 10:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501060; cv=none; b=IlwCuWqhhoGye0wUFBDcUOuM1lh2FsZpCkHNX633BzfoHG1iEc6jiEARUAjqKZZ25RV+0pZEGEcG5dR3S7B2ccnVj98CoDoZfIrRmdQHXoIa8IAFqucFir4r0og2f0qHNCCwluUrBnVE81wYC66KjDBx54sgMv9ETkVWic47WmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501060; c=relaxed/simple; bh=oEubvqZI2n3V9FuebymqRYT9aJaRR3Y7ftHMN9o4xTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZtTzK//qhC/daADgOoznqOKfYmwPn/ZBFCugQsT1LEMPgsL8kIyPfDjBy8XCEl/IKJ9ZNHMBm6qdUt/NgQHe99cqcjQQ/o6wVJvXWBRF7IOGZaxMhbqAJbP4B9nbWHp6jxV4t+9h9w9Mqxy819mkP4NIVUdPnTwbodsJd+eIHGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=be8PJGbh; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="be8PJGbh" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-629f06935e6so684382a12.1 for ; Wed, 10 Sep 2025 03:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501057; x=1758105857; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=65ye4XkCH8izeRtH/tdAUKF+n65DyQp+SjhteFd0SJM=; b=be8PJGbh7EYBgYYjmRfX0phRDdQ0WsEOEV5bhWeK4/0guMbYPnLyxbjQxdsowcxt6b hkTvAT5jBfm+fqqQyIRvFL0GRZe4fyUmQ8nQMfn6M8Cah9LqgcnSYGKgUy6VYZnLbk1i OfjgUl9d9Re/1NcS/RVcDWxHpSaaoRnZNkbFF+e5LouvsvN6ktQcH03TPncasFPmHFlg 4Qzi7QP+W+JA8ftacRHF6AMYt8JmDci3w+UqnBDK1qo91VY29m615VeLCpIXt6FpoyqF +sq0QKAZAQGRvt7bVof77aI4wGUIjd2FJQTjCqvPLtIFRZl+tR5vt+P6LkS4QlOAA0TO 3cWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501057; x=1758105857; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=65ye4XkCH8izeRtH/tdAUKF+n65DyQp+SjhteFd0SJM=; b=QYLhbjkAuDds5j+f+m7lmG2wzI841gh3Uma8xzsLW430lv5o32cyT7PINf7mixp+pr 7Y8tHiPk+jhp2UT7r7VLokO9T47/XgFLEIja8h3OitvA0d6BL358IewS8RfXHKBdKe0o Qjba7bs+taBrVk+wjcNd194xvzs/wYbvUaaRMtXUvNkKklI3gmVoTvcmbFCV2tBc0PVl LYEP9Ip+3LDnayuAZay92CaYaDM910+jRRxWlcrC85dRXV80OPaHcE+fXEO5PgQxsc4M 4jWLNW9IQ+xjdw/dL+Kck3F1zRZZP1YGXTVw+dB+nf1KsNV0bp4ZreJVY6KtxAbEIyCI 8S0Q== X-Gm-Message-State: AOJu0YzFlZiS4YP57FQ07fEGsmzeVf5Zqk5aGQzYqo0+GMDuopIu05x2 4PNomITy7sqfaEa3/vLYSCy1B+GTd3pTK9aLTZCjQqXmbMVRjyikiLAYasrLpkdvgFw= X-Gm-Gg: ASbGncs6GKCGV4Qm/OPeMeNaoKM+UdnsdErlphajHcwgW5pQrVxGJMmhteoFDKsitQg PZfLJmi8fxqFxgoXEnjoAcRjXe3NJlmFfR3LTdnfZ8Fa4excDtf/WOE8rxqaYtv1Pr3nmMb+HsJ tOyn+4+RnwtSpj99JE6ZCiV4y4usZbgePOgTulY5BhJOoctYzBA5JBRBi0j7Jn17GZHwwp/Sp1l 0G9dy96M7dS150AcWCM+mV0AyKcfdmRqg61jfEZYuCqMpnV9Ju8mcIeKN4wJKLO3Z286HQCKFSk sjWvTbq9imr8Ln/5iCbXdIpDsR/G9XBLm5rBSICMEOTMgbyvYFaMe6zdwRdVRXmDk7Ns3Us7laA 186J/H6pbeJ60qAlqmelZyHv+eBixSo4thXXC3zO26JKDbBgCrw== X-Google-Smtp-Source: AGHT+IHgWiURe8rwqi0CThvoChXPR1NJTY3Li8W5h2CF68BaUDzW6c1mZpNja/bMnKWPQ7G6dPP4vw== X-Received: by 2002:a05:6402:42d0:b0:61d:144:81b3 with SMTP id 4fb4d7f45d1cf-6237aec0171mr7047976a12.2.1757501056627; Wed, 10 Sep 2025 03:44:16 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:16 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:43:59 +0200 Subject: [PATCH 03/13] memory: tegra186-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-3-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1229; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=oEubvqZI2n3V9FuebymqRYT9aJaRR3Y7ftHMN9o4xTM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZxV1dccXkjMnXDYvGcn9mUHt1MDzGbra4i/ 0k4sRP6F9aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWcQAKCRDBN2bmhouD 17QaD/9Yk83uNREhrvIVbI1EgtUt2rjF7L96kZj66dFcmCArEVmxlptyov0C/LPYaumKey5wYu8 E6AvRUCRM7uwz29AjCX3epKiHj8V3VA12LPDHtIF4zLq8bTuPfrR4xPHAWAoQMZhSwioutYQGZM kLJ6CWBgwFH7DGAL2r4eyGfjpgJWAcCBZTsV/xTxIbXsGbGMn8WmVho2Wn2UrWJ+ZfbWzNYGvhX E3f/8y/OIUJnXLmXdDxeTBvDg1juyeIiUAGxSsKslWSfcgtvzlbK+r2j+ryp7y7NFeA4v0ZKAB+ oqsW/gy0M46Xr+1fGlGp4EacCrtonLoLwQtKxdDQCBtkEZ8hwxow1qC+7D04m5NRLEPFMGpMsc5 aHOsJy10tWC1YAbKO1IPBIpI5fvbP4ygBbCrl3ngfxNYii30Wz0ZNXMHDhGv+1G22/3X1TaES6e 16ayxO0M5UDeqPkoAbULccWRx32265mhrYCHAkAQ/f7Kb5VZDH0AVkAX1l7olBL9G/umudPNa+n bvbgraONqFq79rewYDIxEw6evmCfVwCfzgD5r9KOxk0ZOZHqlriDnGcbU2BRk66zmDeDfD4r5SG CA+33pcSkarqeJ5veYqP601s37WZfco5bH/04YgM+qDEC/wcnPSnL2VOCJDapWJbg0Jf6AgcrNu G97FONQoxxEp13g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra186-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index d6cd90c7ad5380a9ff9052a60f62c9bcc4fdac5f..00baa7ab89214b1a151ab0c0a9a= b76f90f922478 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -273,10 +273,8 @@ static int tegra_emc_interconnect_init(struct tegra186= _emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -304,7 +302,6 @@ static int tegra_emc_interconnect_init(struct tegra186_= emc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D512311969 for ; Wed, 10 Sep 2025 10:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501061; cv=none; b=Nxu2AtE/1SonBbIVmAu0RnCq4cb6BG54xJv3kOH7n3m3qwARuN5XAu0gcKakossvsYZ4b3nx0J5VvZeZi9wlRjd4WHXj7dCnXLc1Z34Si/16RAVBSRzdr9xvYPdSo8ilGGVDJRiOKM+jcxpUENXKKLebAVunkla2EMHPmbDPmtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501061; c=relaxed/simple; bh=cFuDo5Z2uP1vNw3Fz9+yS4AQ1ai8HrNLm9qBQebCrJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=INDu/7c5RNsoN8znpb/lvdVGOGLAhvIWl/40BJhl1RC3ZrY6SHt59kMGiHryteJe6EcwKkPSQ8fLZyDEXanGjjMdmz8gRqKjkkYM/BzO9asJsSjIhO2vb7CDoB516ONCWeJMY4im/+uqrhcERG4yAoxXkm7lk2d0xCqkCE3sj/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tFoYX3Nr; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tFoYX3Nr" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-62dfed14d68so18802a12.3 for ; Wed, 10 Sep 2025 03:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501058; x=1758105858; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZV4GDPvDgh6nloAqz+zBTonlpmiF4OqD5ra6XGnPRtI=; b=tFoYX3NrDgeaIVYD9fc+qmBtOu4hxqDEoRvjQ1jk+I39/3GNG7MJw05Zys2PRhQbFZ iD2HxfmYNabTF8Dx1GedgGPawqLp1v5TR+g2cCardZy8hQ/tTdCHjQp9iAZwZKY/TrpB 29pZW9V+IxF3nWdxDbAGx/al+xQoewlctg1DRZ5HKz+Ty9cvO7iE1D2y/ve2mkV1lnYY xWiGQBdN9b2f11Cb0MJKBy/SRZTN11ABV9m6bMkPJIsx13yns8Wv9bC2FDkOJ79EnusQ qA1C9kVb/Y56U2UKGAJac/dgJUXGBBBjb4JV6blUs2Zpgbe07AeKWw/ycS5BeKewrDyQ meLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501058; x=1758105858; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZV4GDPvDgh6nloAqz+zBTonlpmiF4OqD5ra6XGnPRtI=; b=KJcNL3BWA8tOZTJuzQsP89Pd3d5aLOF650FoS9WXnruR3zMo0ig+zicNfr4xpPnnLs KVUBdovrTy1NPM1HjDROeetVVeajgKd5qeficSwWkNP3xiACKpJA0UL/s1gellBHOalV WQ+ScAExIU1Q5xS48FzAjtnbTpZCz5l1CSdr024A4mvN6EgwP4j/1aMzJ4Uq2PICtVox AZYFjqRDH8ZsAh+w6DWIxfIXEXyOdkjVWoJNgYzkVFOSxFiRZRbrSf1tTUX/voZZn6Wy AdyAqsuerc9dGCeMSZ3NOUUUYTazv8p55htbVcrYD/I6X4iwluQf/lAjA3YfcRgWE1sg aFQA== X-Gm-Message-State: AOJu0Yxi27NuijJIlZkZGxuatecoWlBfjK6bjBj1LHeZDxdtaYDq0Kuq pEdEV1WV3Kl7/08DW7VpNhv78gHlAas6W17Ox4DCNskplEEE+m/bVe0qGn3kFncw2o4= X-Gm-Gg: ASbGncu0t2N3lb7nwxgKZDClVrmW9Rq9HE/Q0ImV6zV0EguT6gAkHt647lWIVTVYgeo nMHCnRzJmAStkhiZpHuzes3ffaMLhGu8yrc0AhulRyp3cVEjTHutKVlY32MKwkQGfWDwF1P4N1/ 4hJbOW99m+OlruOwTKrTyOTC0VJKZAP2nRtw9nWB7qPfFyy38D5DKuWCUADcY0WyVMvwpQ1uRLO ehKeeUVe6Ef3xD976iGKU++QdHJB2UKPmbTuNEpsdJWqvX3t0KKCyXyKsn8QG+8BM3pW5xEjzGU RVGbpfPY2f2S2SUhq6GO7AxTGvkedNOqh3Mn0MN33FU04SvT9OvHGkrfo/KkyPO7h+Ri8jNQto2 i2CCm/a85JrbGiiLBK/TCTyErOOAuNE9myfn3iC53ixa1TlpNfA== X-Google-Smtp-Source: AGHT+IE2z50n1Y+fVrBJbhvZ+Yu6Q6txu5Ue5AaOkSpz4PTL64znjFvDGWeAFtGSGm/CP5wy6EA9fA== X-Received: by 2002:a05:6402:27d1:b0:620:1c6d:e6dd with SMTP id 4fb4d7f45d1cf-62374d5900dmr6651661a12.0.1757501057775; Wed, 10 Sep 2025 03:44:17 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:17 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:00 +0200 Subject: [PATCH 04/13] memory: tegra20-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-4-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=cFuDo5Z2uP1vNw3Fz9+yS4AQ1ai8HrNLm9qBQebCrJY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZyOnCDYUh2ezqW6uqiofQ9nmLxoCR8QObZj ZbqsoKFx1aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWcgAKCRDBN2bmhouD 1x4GD/4yLEW8npjhNAxrrFsl8kxcpgOPy96ceACrngB37Ooxm34M7vDlPKMjw4wPxepJLm9FCMs QUhi3Ap/9kW3BYyvc3RVrO6QM30JUIuiZrjmBIgkrFL8Ai3uSYvAQXAI3kug4o9c3PkObldEQ1+ wngIaWUNRpXy2p60s0x6kFacyq3h+KFq7er9vpsorP3RIgqvPwoIW3W5TSHHZZaEwcHa0oYEo/8 4INQT6FcvRXyVOisa6nbvKOIED5fvOAt5fbZTiS3QJrr5J0MoXpRstcWg+7njO4pdYQtfqi5ief CsjwR38kU9ldHQhrRlNcqAPanV5Ym9Kpib0ku2oJ78Gd/w/ftd8oRqF9RB9gQvsUfwUmgGCgnD2 x3+MtiewRafEmUKyZxtJTwmJe31hP6/hDm3TO5t2zjFBfy9wxyGsrVRlEx3nhD5kYyr5uou3bUb Ln2QBdq+qZbHbXVDR81JcmmFV5UEPhHKkt0yexYCI9SbNcYR3yuIRFWomtZ/dMpwm/Zrb8Txw6u OTt9t+zzjCffjej7os33yHBWlQ5NE8Oa2+LJEnAs2Mf8AcQ+71fjiSLsOtBupMC8raV13e5HlZT KgqwQTqDjlJTPIFyGNduvOJ3Opnop6AhKrE+CEZvLcVVhuNnnDkwq/tdpXpxdVI90Vdck9KlB5/ +5Nq0n+8umFn1kA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra20-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index 44ac55feacd3eef0bd095271bd3dceec60c34bb7..a34636a1c4c55419c323eabfe96= c5f27375df344 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -1022,10 +1022,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1053,7 +1051,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6D083164AB for ; Wed, 10 Sep 2025 10:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501062; cv=none; b=tpOU2KyfTnZUYRwZ71myotRR5VjS/fTx/hyfcQWcSWNZH/h01P0IN56tOtkmeC5yb4BXQ3aeEzskSOOhB17EqZSbykUX8/MDYE2aceF/tTy88CFVxg+6dnFcDuxmDcy4g0FqNInDaLk23nb5HAzYTGC9sxGdS4o5hYx7QX4gE2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501062; c=relaxed/simple; bh=56WhvEjp/PteZn0tyO9c/SCroF1xJwxk2BOxQgVeGvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YXxWwXZUBqElcLin/PDuoUKc6PK1piu8ROv+mGkZUsqIKifNoUG+mFiFzXuRki4e2u1fCFj1ZpSOYDDf0yAdJGx1vBjNMiykwSzZTHGr5srO8c3AAtbbvhTzS+oEfItajyHO597Z3LggY3ZMYYRWgDhcf+QR1AEdwEucLLrf1xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v8Xyx6Oh; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v8Xyx6Oh" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-61eaa4f6784so1142215a12.3 for ; Wed, 10 Sep 2025 03:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501059; x=1758105859; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3WpkGEUpfxQBkF0AFg2VeVRpKBfctEX+Z1irkwx05L8=; b=v8Xyx6OhWZfUI16FjuVlsNQQP0+fcoTorSx6YqPQTj9ZT32BQjn4E1hB6G3k+FRXiM mOz622H5FWzkCHQF+2cQoXTp7BEaXTpiMCI7ey9CRC7zUIWK+hrIyXwaffojRTOgP2dD QswEIshQu1z8DUqDfFvj4zEKKMh3z3+OQ+aRHi/f6rxZledk8wHJOKjaUOUI+b9ph5Yx JxTFneM+0RbMdq3pcKSKHuxEbsJmkY6ZKggAx9A7+RLkPBpVGjHRmbP3pJQB7X/Vjp8c ZmuVZ7Z6ynN/EyGbko2xq8RH3mfm69rgnoSl782AE1WWW3Kn2SxIUtDp3fdwqYJFl8+f INtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501059; x=1758105859; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3WpkGEUpfxQBkF0AFg2VeVRpKBfctEX+Z1irkwx05L8=; b=tBZuDXpz0W5jYiK+BoVbbSW2rn5Gnyx4k3LX4Isvt5BMi9j63xLR/D6avjed0sfJM2 UjUHpTukV4VBfvt2Eawr01zWPw1E3l/xlW6Nf312AOUbDmud80sqndwtjqfOiGSRLfVn EwfYX5iDjpDHJm/GG0NVv3dDOJN0tj2AxG1LboVxYWtEMeWKz4BUCPraaAag8yROEv+h 09lJn3t0DLVLqQiee+1Et5wAJPAKxoxeaKpCew7VqxMZ/0XxN4pkZ856BsBWtmyxd7P4 KSLC7DpAy5IWC+1WNPwg4En5ighhD4mCjiXaevP+au4B8CiLAuPm+aBf5Rr5QWVSF8WR h7Fw== X-Gm-Message-State: AOJu0Yz2FROtXzIGZBIiGn4ZYiTJt3Ame+uVt0n3U9FmTWhL3DH1mvPB JBSeTIvbUZLsJxEr3iOF1qagbBacOeiivNaCeyVVs3PWEd0PJkeQmWLogIdeeC2hdPY= X-Gm-Gg: ASbGncvVD/g3spK3EPUbULrrUBUXOmLwcid1IRAsfQt5dO55+01ph+JDZraU5D9jfVB 1WVC2B3AJb0gT3iq/w657Zq7/qy7HNXl6rG5gBuNIBU043+zF8CwQhSxcKV4bI2Db44NCL1WmE3 0rAz18PTCEd8RpJObIAY2t9NsopArtuQB4eFfNFAdnrrfSfgP/epf+jiLQ8TPPzXsAAJ0M4sW7K Zkxc9glRHe75FXLacshvhoXmrywqqR3nsfxT1RZZ98JOythzGjMWBX+BFmaMh8euwpaq/A/I8E0 qi+i1KkpzwvIy1SL4zqaa+sRRQDWC2b/0fqSeSfAlROF0A8EGCyVlHV5Ecn0Ev66qhTBu5ntlCP f2qd14jVPrdZEbvb8DKR8Q31MoV/3eLZqkyOlBzk= X-Google-Smtp-Source: AGHT+IGmbydVAXx0O1nO/LcVNbJRNPbs1dnLdhKWCpImMs9fWBcF+2UQFXqS28+DcfFfA7bKKjPXVQ== X-Received: by 2002:a05:6402:26cf:b0:62c:af05:580d with SMTP id 4fb4d7f45d1cf-62caf055e13mr1859074a12.0.1757501058894; Wed, 10 Sep 2025 03:44:18 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:18 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:01 +0200 Subject: [PATCH 05/13] memory: tegra30-emc: Do not print error on icc_node_create() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-5-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1222; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=56WhvEjp/PteZn0tyO9c/SCroF1xJwxk2BOxQgVeGvo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZyO+TuUxzmlqng1BKznkSRk7w9OsWLK/p8K zUsczbtGrKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWcgAKCRDBN2bmhouD 1+FBD/oCk0CGj9IKqnKbHQqr23NwdJ0d7KodNCecjJFeUmLJb+KSe/+DY0vl79lZ1xVRYpLE+LA EsSRrMBrUpL0TdA8CoKV+BEPoOvAU6tH+0aBo4a5QtxaLGUrAPknhVzCdrRkFprTCDn0AiEAWpp 3Cp9KgMoBP8jNpDCBIzAeegCdvIefuirTdCCtcVtsgJRYMAj8wULIqBmzSn1SIDedUEWwDNdobh URLbwWh329ak05l/ER3pqFTic+uKRsbroNi9HtqwWhzvAMB51w+xjywlPAn1k9izh3CH5Sk2B2F A/VY9ZBmMueD08O+T6I1OkvZHN+GfNMs2I+3mUkqHw8BCGzlaID+zhxrYORpStIofMbcd+iwsa2 yhX2/3NdJTmLjcg9JaH31PK9uPD+jyFYbxHmYjvkxocH5thY5Hs75Z/tTZ1LYf2DnUdX88cUrB8 dXZSSFw2/rN96VIzEk0mfHIISQk/g9kh8cyasxiL1+pPZQxnPilATe2o+/m/ilEuIq9OWbRF9ib pNZdHZnOhCm0Eh3tEWHMh1yCZ9QBW7gqrR2LaUM9bcNlah9m9gwSQAsR8MTxJsJEEVqYc3gt/wt jzbzczwZFx06Ux6ZDhe+9JAUwd0zC7LunbOvzACuQFEhWSuPtQINQFmFu+mo4ycUqIq0Kv2nYMZ Tn/jEx7SFZo8p+w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B icc_node_create() is=C2=A0alloc-like function, so no need to print error messages on its failure. Dropping one label makes the code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra30-emc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index 921dce1b8bc6382ea66d70ad0f2a12283316ad90..c96aa63a5aa085a409ae7ec901d= 2a210748f5bcb 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1534,10 +1534,8 @@ static int tegra_emc_interconnect_init(struct tegra_= emc *emc) =20 /* create External Memory Controller node */ node =3D icc_node_create(TEGRA_ICC_EMC); - if (IS_ERR(node)) { - err =3D PTR_ERR(node); - goto err_msg; - } + if (IS_ERR(node)) + return PTR_ERR(node); =20 node->name =3D "External Memory Controller"; icc_node_add(node, &emc->provider); @@ -1565,7 +1563,6 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); -err_msg: dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 return err; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B3D2C2365 for ; Wed, 10 Sep 2025 10:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501064; cv=none; b=F7ZOVBKVLJ/NFEjTJ3cYZDq26Rg8ms+SYei9Jx1NyP0fiQvWuGCUnEyQxBy3Xxa9hBlqFFFteZHCD2mtTVodCShd8m4+xj3WCChnOt0qv+haRUd48S144/jdYFcbdK+HMtjsjwQToUSjUFpgZEzI0ks76SKZhhx6PxAsTzXde6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501064; c=relaxed/simple; bh=9uLbL4CfehXgK0FgR1jl+4z97FyCLswBjlNfgLA3G44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aXcjp4+ygzroOaZdeJdMDcIrDo0A0hvHHpbOjfYeAfOkG1pt4TirxbBouhDIoFuVYF5WVaKz/sVrooXadq+ezy0165m4Aq5ibAyLeLG8LSB75OZ7SsZh0RBczVUf4K2tREAQKNbDdj5AEeljLW+E67zllAwtaV8jChr9W/yaKTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Jp5UqNS1; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Jp5UqNS1" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6217798e8acso992503a12.2 for ; Wed, 10 Sep 2025 03:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501060; x=1758105860; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cqRItD2bt3js5TTmQrynwO8hQqUf0mH+3ap8vOPgmc0=; b=Jp5UqNS1eN9d8Wbrq5dRSOoFAUz0ZBrPhdanqQrMnlfWE4ePAOF/vuh35Bd5fRorXW 7g27a+HIrInmcLsfJZHiN2D4A301ZvDEtdymFly6NW+PL87dNv2fqQi2NJEQl/cK0Xtz nbcO+JtKzfi3jaNo/EpyvbwTtR6WXs1cDe6n8zrBWNnHAaONPeYHhbZaUdg4C4GhCnhA EvhNicI5/ploCgnA4zMPrfqE/BXugHucamzWZLH5fJ+fqplgqkEy/Qpv1roPX9ZAnl4w ZrcgUTycHeeeq40bwKEgTtgeCdbFIMLg9Sk17/DxioVruW7e2ACJTmAohGBb69Ivcg6B rOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501060; x=1758105860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqRItD2bt3js5TTmQrynwO8hQqUf0mH+3ap8vOPgmc0=; b=nJKoArGlD/vyXqRJ2kr/wTcf4Qd4X1P6ro4uPhkj80Bok2RHGz5qhFzNVH+ku5lNq1 V2F8Vcg0ETPpuY2rS/mlpkSejKk0obbHib45KKG5YuB/cXInN3qB7MsilUXlNmv8LcxI nfs4XGg6cwYKRk1LCCnfWAWIqIHNJ75P4pwYwOyoqm4gmt9sK6aJNz1SqvH+dH3ZLjP/ G7N0x2rizvh5XCO+LIbSpKyryNEfDFZPhgL5yAdUNKO9AaqHBxiJYhguax8U3A3WA2lu Ful/8S2yC+HnyL3aAQPRMmfOQ0e6TxFOwyTY8Zhagz8gBm/zl1R2HFNYdUEX+3uzZDdz FQQw== X-Gm-Message-State: AOJu0YzBSOABrF1N8uXq8+UMIY8TVRbQBMa5hpDnCvV0aCxIxiD3pnhH dmBzb5szk23iPDaLw9SkBJNT0VS7qlRLiUWeWukImwVDemRTPGjYvjHXHHsEhT3/qKQ= X-Gm-Gg: ASbGncsOjOE3DseP+05/Sqxkvwkn1EDX6dXYOSvqXibr56iyjxTCbewGOzz4JxOPdKn psLuR9bWjgBfDKO32v6sxVce/Cahz9E/Ha9hGI0QVnN05/GLyHoED4D51ebmksU/mLdk0u9dyca YkOZcnpPOLliHv/mH9A7kslRSgbcgji/YsXt8lQ1hy3XXUZm0yY6ejmcfePXXpDW3luWddk8eP4 iRDIfH9paK+L/Yii6WrSTq+pD35ArQcavBrUrjKYVc9vAY0CcYcV6dzzzjCcu0/9pnc/K5/cGlA kFyoXmIZbatR/Yeeidf6CQFdZf8St12xrFt4SIsu48Jqv0kZ08M/8W6iqu/cAlc/UrBkl/99vds r/V/HjPfsgArCUikyKHLm+dFplh1zAQAtRiByjDg= X-Google-Smtp-Source: AGHT+IEpTQEtThVJ24rqHPh2z2AuC0Jni6hadwlzpRBmk8LSW8tMLyniWOtwKNncJCF0pQQNoWuS9Q== X-Received: by 2002:a05:6402:325b:b0:62d:c7b9:b149 with SMTP id 4fb4d7f45d1cf-62dc7b9b348mr461877a12.2.1757501060110; Wed, 10 Sep 2025 03:44:20 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:19 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:02 +0200 Subject: [PATCH 06/13] memory: tegra30-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-6-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2183; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=9uLbL4CfehXgK0FgR1jl+4z97FyCLswBjlNfgLA3G44=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZz3v9AbJoO2ZDaH8ze2R7RA8EtirBgZASnh lSu5ws/TJGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWcwAKCRDBN2bmhouD 14nSD/4n+XU86XSAKNv1sV0NhsLqho9+ahJdat/d4NoY2PTqmvCcWi8fnFuAUo6QzycsCIAxofq eDJI/DYitrW42nBMAZZfM5SkaNohsY9bXviojcRLC6KQ5zTHaWF09EHEGUtcBGIEzCyc5A1HPtb PtooA36aEQHm9X2+K0qJrgdJKsk2Qpd3hrnFuUGRLgPx3gfenJFhvGLdH1WJWXo9lketY7ynjFC zyxbRvNoh+RRL6I+OgfQEX13zQSnOiWGP1FvLEccsDb0NIjUF+r6dPdTwZF55acqS7H7YiV1gdw jSLNeJWNzneRwHnHpviy7G+CJcGWbWlnqsF0Frn9zE8YPPuXIZMCJYjmclspe028FfeH6zLx70J BpqlOSpJFi9niVl9N++TVp02WgXaOwi4H/3N5fe1PB2yIdF2ZRC4/t7akwrOIHTCakfRej4jNoe H+8595OGsv2r93lquQoel4cHXJAwRvYUep4D6KWI9zWWFQy2Tl+YykeUCVj2Pp50jSrGldLRnP2 g+9L4um2sAqgEsI6Khk2aqSUNai4B0gHWcnCwEqkVSyRN/saXktQ6wGHe+Ee5UtXrGxjKtoUHdq HTm17+Qzxz/P6r82SMkLMqjzsAYY+J9Tfe+IctJSCAIrKNID0aBryJTLj8IyHViNm63tam+zvkp bLx2I71sqNEs7Ng== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra30-emc.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index c96aa63a5aa085a409ae7ec901d2a210748f5bcb..cca386af423e9647266878ce6cd= 1bcec09c8eba4 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1563,9 +1563,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static void devm_tegra_emc_unset_callback(void *data) @@ -1592,16 +1591,13 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return err; =20 emc->clk =3D devm_clk_get(emc->dev, NULL); - if (IS_ERR(emc->clk)) { - dev_err(emc->dev, "failed to get EMC clock: %pe\n", emc->clk); - return PTR_ERR(emc->clk); - } + if (IS_ERR(emc->clk)) + return dev_err_probe(emc->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D clk_notifier_register(emc->clk, &emc->clk_nb); - if (err) { - dev_err(emc->dev, "failed to register clk notifier: %d\n", err); - return err; - } + if (err) + return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unreg_clk_notifier, emc); @@ -1654,10 +1650,8 @@ static int tegra_emc_probe(struct platform_device *p= dev) =20 err =3D devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, dev_name(&pdev->dev), emc); - if (err) { - dev_err(&pdev->dev, "failed to request irq: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, "failed to request irq\n"); =20 err =3D tegra_emc_init_clk(emc); if (err) --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A25330DEB0 for ; Wed, 10 Sep 2025 10:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501064; cv=none; b=UdxEtqTT3oYvMtASaIwG3GbaRNJhgJXsZxLyrT6qUSn4gBk5IICAKSovW7zgh3EgiSDY+qKhw3Y16S0sKO7prAAj2p4drOUPynDleCkYbTver/L7pnkqk9X7XMwRL5UoCgRe4IgIvzYN5VdoOxyFeuZmfT/HZiRWRHXNmIrMV98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501064; c=relaxed/simple; bh=M1UcDlfXbj/5vPqirllwe6Mt+pNopstDQ9HKCl8tOeY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IFSRKdYIvfz6mOhPoohtIepCfe/0NPOM+eJCaMrNK3BqzZaw+DKw3x5+4ORLCMkS3TbV61gk+mVVB0/6L0wzjHCo6ilu8gQBzY5LQKb38cI6qTKBkfTsW1Bmu53xLjOjDy/3WabzA6AnuuYtuPI2T6s11Z1sEx0sErCg7/ko1Ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g/M2mrch; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g/M2mrch" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6285612382aso472842a12.2 for ; Wed, 10 Sep 2025 03:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501061; x=1758105861; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BnBsMIetOHLgxvRafB9XZsD33miPY9fW8C/xMa98MG0=; b=g/M2mrchhOJWWaLk51lksJeDaFxJBaDowFb//By3kF7GJtlNlFe8k4CBd+GBPq72YM Ugw2IjQw8ZmGphzV4r0yo3ToLqzikF5X23LLU7TvPrp3VIkwxPMsqqDyDAQztYmq2p9C G5LI0GXx1G3YuXeQS4jj6FZhk8pie4JaGkvlNKxJJow3Ivt5wvw0XBI52CgzMDB8fxn2 pncn1SkAcUdpdaYVwXVq/OL0kdDVpTOWhXuDWsAU3PH2my+LK+WUWkX0cGX3hxZzuP/1 aTcvzBKoYNoWrTAt83eLSmWRbgTvXMjZiZzhBw66uaF88seIJbv4HofRJB5ueHcCxovR klug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501061; x=1758105861; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BnBsMIetOHLgxvRafB9XZsD33miPY9fW8C/xMa98MG0=; b=ueGJoI10jbWMiPW9AWiyIic4F12rh86mF6zCYyrdbyKUu/2MhdBKntXIzFTYlgNuOe k1rZZ0tLqUxH0znEIcl/WA9Tmsdu1FGtdlTDi4GMWAGqBJjDKtL7DBVkuee8DiGhBMyU 3juwZ0HCC/URNQYKiMNhAY8FKxVqTfqpMRb4efci/7KMnnhtK0dc0MC8MR6ZsQlO+Dx8 EGh5k5Z/VE95IN7EF760ILpuLHwiilEQAmsvgv8vNP8L/zuPbtj8wN9UNODRgb4H1H3g 4TtAlFSD4f+Skv0phOQyp3b0pFUp/WZjwonAb316bg4H/5ARsXkTItSk1Z8urrHM6RuC Q0RQ== X-Gm-Message-State: AOJu0Yyx27dINklScPiGpE87qi8+0b3Dtl8WrSnxKhVtiJBFRTJ13uDD nY5H/5NaCc6qU795RHHc8VNA7OfhtC8MDCXIaKaOlvsoaIOHWqWYmmC17Z/WWYfMmlc= X-Gm-Gg: ASbGncvPNHX507ajBxxWXh0yoP3nzCQxZ00kg5sJtTuociYhNpstqZwT+a65kAitYOX OuuRRlAJV8U6z9d0Sq5CvnfroKu/XWYZZorkaLrGP0OQvqu9qzi0q30Wly7/Gbz6fkcThcYWEmq jwLCq+gUPlIRhIlIKfXaHNHHcB/FmOJhwQaJ2akcNs3WRYQeYygwYFiq04+CbyuiqcBwMeTXBlJ FCHR+qihDP+ZH6iIefbZX0ILFGivK3vbCaGYtnfnVRRUQHKXfcGYcedQwkxjNfGB4BYr/pCnd/c EYhPgzltNtK3k64I3eOz+NRJ8yLDgz5i9wsMydut1wmvf8iCP4jAAVnOTA//ZxRrEsYK6DB70J5 Ebeppfhq/bgSYbbDbvHYUgSzYwpRHltTkrCII+O4= X-Google-Smtp-Source: AGHT+IHndwPgiFalUI0Osr1mhVatUVBRlt9rqFbB1yf+l748O6YjoHNTTNyX3DiefIzkA9XLIxL87g== X-Received: by 2002:a05:6402:2345:b0:628:3c12:8732 with SMTP id 4fb4d7f45d1cf-6283c1294c9mr5449146a12.8.1757501061401; Wed, 10 Sep 2025 03:44:21 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:20 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:03 +0200 Subject: [PATCH 07/13] memory: tegra20-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-7-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2340; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=M1UcDlfXbj/5vPqirllwe6Mt+pNopstDQ9HKCl8tOeY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ0vbHbIrfCHEW8zwOekb7DVpj0wPZ/QUTL8 BZn64ePhuqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWdAAKCRDBN2bmhouD 113ED/49eVcXsqTjBbSJYlPack6vuHMauo2QQxobnfuEmbtlDWntO+UJ23Hw6/HX5diGaMdpJh0 DRjQo+Joy/uwKhWKZQspD5kVHzV/JRuO0MPAvz+pCGYi+CYakhOUAlABQgMrGHrSLMSDncw16p1 wnMOytfiqr0Z9hML8JYbSRWbaKqRCv9WyJ+jiz1o67hv7ROWkAYUV8YG8TFCkhK//TbmDUdPy/7 gwvE4Q8D27+qKxMOZi3Nq2oTTPA6t78zXStaDHWdxYRNFV4wAj7x7pnj9jRNhsLPo0Mszg2aUeO OBQtCfmpqv6RKdWBGGqRq13Q/OQhUbiN1AKCLKf9SxqTGcptBU8dcRkT++a4XkaFkfHachbx00w IVcQGbAGOe3HCAQ7r+MKgatZgeZX739NcvuPzdVPAXgYIiB/Amotv8hFymIyRENCFVR1PsnNdPK XpkVfKU1CvN508lZpOe0vYb19peu+f1EkBypIPgfB2o8ONdsVuwbl8ue9xf7PpWz2s5ZdOoUYuX tsHbc3msA/7P2CvaUspPs/7BFJxGuoyGJ/Sh6VnpxqoVh9E7yYb+L2If0cIeHrVVH0dDqx5vxbD fwJuei1bCGc2+KpTKO8TsXoWIeYG/AvUedwXfQRWs/ZvM2Zb2eB92LH/t6lgY4gGLyAWktgKTFm 9AZAZKQ32Kx4n+Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Also fix missing new line in error message of devm_devfreq_add_device(). Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra20-emc.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index a34636a1c4c55419c323eabfe96c5f27375df344..18e266dde5d2a0fb962fadc0416= 1b03fb79f76cb 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -1051,9 +1051,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static void devm_tegra_emc_unset_callback(void *data) @@ -1080,16 +1079,13 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return err; =20 emc->clk =3D devm_clk_get(emc->dev, NULL); - if (IS_ERR(emc->clk)) { - dev_err(emc->dev, "failed to get EMC clock: %pe\n", emc->clk); - return PTR_ERR(emc->clk); - } + if (IS_ERR(emc->clk)) + return dev_err_probe(emc->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D clk_notifier_register(emc->clk, &emc->clk_nb); - if (err) { - dev_err(emc->dev, "failed to register clk notifier: %d\n", err); - return err; - } + if (err) + return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unreg_clk_notifier, emc); @@ -1172,10 +1168,9 @@ static int tegra_emc_devfreq_init(struct tegra_emc *= emc) devfreq =3D devm_devfreq_add_device(emc->dev, &tegra_emc_devfreq_profile, DEVFREQ_GOV_SIMPLE_ONDEMAND, &emc->ondemand_data); - if (IS_ERR(devfreq)) { - dev_err(emc->dev, "failed to initialize devfreq: %pe", devfreq); - return PTR_ERR(devfreq); - } + if (IS_ERR(devfreq)) + return dev_err_probe(emc->dev, PTR_ERR(devfreq), + "failed to initialize devfreq\n"); =20 return 0; } --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C74430F558 for ; Wed, 10 Sep 2025 10:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501066; cv=none; b=j0bfIwH7/noVr0yZVAkJz/17CuNJem6cB/8enX3X1J0+wh8LbEEbaTkKsbpwHJcZaw7rMpGHx4hsln4J0vHBK+rdcUEU1Z2FHOqGHlP5YCCZ1kl3rrGtrw3h7GETxZ2YEoLktIJDx0bNv/iXN1hhHdtro6GZUoj1ycNwEvCfVMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501066; c=relaxed/simple; bh=RkEbb4vtXH/1xa3ZAFyhmneUOFAU8k6zYcos8ICuhT4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gd5tHW/r4LAi1OnXAw6HjFUaIqevAQ2BlWTokxfx7is1ncY4yVBkbqvkZBDMXsRTTGgjBcoawSLUG/vb3EoNn5mHdgMneWbMZfldYSKe86M2ZaFKghHPBgNJFSTEwjkipDBWBbE5XR5VPO3uKS7ukAsNe3UE9LLNUlXyd4qCSag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a8yDwjRU; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a8yDwjRU" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-61a54560c1fso1496688a12.0 for ; Wed, 10 Sep 2025 03:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501063; x=1758105863; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I5m3ByHgnOeEhXsQQzbVD5zJSTnURIXU/8oB9ElOads=; b=a8yDwjRU3tHH8QstS29htT+J5qYHaWQSu1L0jVovzunnorBfugwofBQb6B4wbkNDQR sMJrjBPA9YE0j5B5NdqEKDhfLHIj5hyz/pFIOWlM8ChZwF2Qz9JdMABzCHETQ5jBTIU9 Wfo/h/HjENg3KOQoULdfSvsw3ZK+0M2AtAyYGQo8uFUwibEY5JsU7C4jR+Xredr/uAAw IVBdQPstdSKQ8s40zdhu1RK/zhxSUx581g/JrGKIsiwe7vOqjO+TTakngUfKGOvE4YsN NycdIxw8ISr7OD9yxLz6Ry8/CleIgsF232dSYMrKXrdBUxnTTlkq7NICMQ0IXm2S8+lI GTCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501063; x=1758105863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I5m3ByHgnOeEhXsQQzbVD5zJSTnURIXU/8oB9ElOads=; b=DYoK8gtID+vqDNBNC2E7siWhh5spaJf2l1ufi7/B1CweVnFQTyWEx3zruHUcYc2Dd6 Wg16hfM52UkeNAgurMQ08N3TPblxR9/EMhA1kLdb8IqjLlE4suNuGs/xeywbDgOZKQBA KE/dKB4RiQfKpxypRQ2NZKe8v8gpYsx33NsLPMTiYoE3IzC+G3yy7MRncsF7QHSn7HUh T08by+3KgmWP+C2Ij51lMwpdlsdeRRZNJK4Zfjocn73qz45OQ4/3jFjVR4eB9ZTFeAwR ahLuo0KIN0i4SDsL64fVa8RKQBrD9a2dwXVwos5xlwcqAafhIliHHfLl0zU5q4v2TPok +idA== X-Gm-Message-State: AOJu0YygIiYpXDRzSerXzniiQmQWY1Wvv+P/4dRoVZrDhI9AeheCcpjl JEIZdpp+ftf3f+zWCEVGqAObduxxLw46hW8BDpR1g2v2+rXRqHc3eVz9caaiEF6ZoDI= X-Gm-Gg: ASbGnctSfV+O9mavboxR5AYIRTkmi+SjwGoDawbtk5q9+XQN/lkWMLg2kPYRNn7H+qS eVryf+PtIoz6oNyMrYAsHCb7jjrftyZBOtO33PEbUQBdJ6mPRsQkex6nge1HN19ioVLolnb0ind gX21eR/M5sGML8uWPkmH4IYA73eMpcsi119GtFfnwspkhZgjfuxGkHkHh6oIFuIwWjlk1fw7YQf MB2boabRt8HbAIirhNK3wa87j/zCZ2rT1/vIzVEpMmkR7irk7/cokmAespUhK6SG3wtUuQENZlw 57YJechq1486hUxfo9i0JiKca2If0bXZ1csTM/aKYcJF9UUAOCBsU3oqfss/BrKJg5nWuTzKMGo CASqnbDCQlv5LTH1m92glIdbEe6LcMg+3bgC+KHjHXuVT6sqL/A== X-Google-Smtp-Source: AGHT+IG0D3sNuTN2XrXIMBjhp8TqIXYO7K0+75E+g9ycjhnJbYIXoO/VzW9HiOeprs/pFGz/fFNgKg== X-Received: by 2002:a05:6402:34cd:b0:62d:a9f8:c265 with SMTP id 4fb4d7f45d1cf-62daa0807f5mr696455a12.7.1757501062702; Wed, 10 Sep 2025 03:44:22 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:22 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:04 +0200 Subject: [PATCH 08/13] memory: tegra186-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-8-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=RkEbb4vtXH/1xa3ZAFyhmneUOFAU8k6zYcos8ICuhT4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ1wVFFeg3BI4yDnSEfM6+mfV3RcN+tYFqHQ SOlXwuQ21+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWdQAKCRDBN2bmhouD 18H2D/0a+Ih6P/4NMskZ/xUL4kgKb2F8UkzIIHo5N3MyJhugxrIuY7leHX+K49FdG9AXpcpdcwi GDcPMENGlgGmheJDuhdDC0KfUiexIwWva3FRmraVsYO0UZUUB+Ge9LgM1tBxB8TRkMcrva2Y/zG +L4cfx3GiN9rDuLJVyijiEyOyBHutOSkOAUHINh6k01JW3beEIK6UDXMea0Bv2FflTWWsDyY3nV nrJnYiL7QPBtgsEDGCzU6BfwhetNJtiEHczXfq1Lwh/jDlYBvRkrO6YuWxPFZDoN73xSjh4hS+7 9RDMTHUUQAA76D3MSnXhPzwndPiQuhuQUE7aIyfqcDkU2ey+rc03pBP+27Am9YX35fG6+64VREi 0oUmvXZ2q24uoZ5hLvfppEyJFV6V/YV4bKzXrH+i3BmwRw1CQmM5JA3mccQWchXajIdOnmlG/8g yAtPSFhPaZux9y+lMElh997TsUKu7jTedrVUvZFKNvDOz0G6Oe7J3FwUYdz4t3BxzzKbxqvHpau /nRlDMhR6yMEG0J+oWYyF+EnsSpklVFvhCRd1z0qTEydePYfv9YBnLsA4GLJCBDwhAeGUP7lUm9 Wuf4vKGQcL8LX/EqoWJgAnhCW06ybU6rsoH0ystsba8g6ctrRGgfkI2Wcl4OOMSrNSCxrvUzJvv XoSpbpfwauiVcRw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra186-emc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index 00baa7ab89214b1a151ab0c0a9ab76f90f922478..a0de80afe3e90531fcfb29d2077= 3aed0d04478c5 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -302,9 +302,8 @@ static int tegra_emc_interconnect_init(struct tegra186_= emc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static int tegra186_emc_probe(struct platform_device *pdev) @@ -319,14 +318,13 @@ static int tegra186_emc_probe(struct platform_device = *pdev) =20 emc->bpmp =3D tegra_bpmp_get(&pdev->dev); if (IS_ERR(emc->bpmp)) - return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get BPMP= \n"); + return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), + "failed to get BPMP\n"); =20 emc->clk =3D devm_clk_get(&pdev->dev, "emc"); - if (IS_ERR(emc->clk)) { - err =3D PTR_ERR(emc->clk); - dev_err(&pdev->dev, "failed to get EMC clock: %d\n", err); - goto put_bpmp; - } + if (IS_ERR(emc->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 platform_set_drvdata(pdev, emc); emc->dev =3D &pdev->dev; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843AF319847 for ; Wed, 10 Sep 2025 10:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501067; cv=none; b=dLQ1T37BJnsc5QUaltZbI5a0ZlHJ7jlpjc7NayzBBcUtfB3MFtVo9owUfogOea8tfIPHKTT8eh8C4igWVeaADakDHyr6rWJo2IwUfu3u6JXFmfUvGEgyexRF3WOkyNn2E4B3FkgqCJveQCEjrxnAlhyCMcloBJFGUevXTAqdn88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501067; c=relaxed/simple; bh=sumypjm5su+//BJZ7zcWLArNigqTGnmSYrUE7kO9jkw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mrkb5fie+AkAswS8JxIizxYC7qIUI0ldGt7i1YhAwHvRxc7ft3g/pJ/GeKSAzYAoiiwwhS2EDamKd1kvrMDMtkItyQS8huMpBI5/Q/iEDWjufZGJHSnsafMNT8q1k7rMYfpXM9m/sik4R7vrOJrXCcQeVsnh3zvnmS0Zz9CECQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IFjOG2Gb; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IFjOG2Gb" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b078af34f8aso5201366b.0 for ; Wed, 10 Sep 2025 03:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501064; x=1758105864; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oOK2rQuOJsLR6f1VEysNbCIuj//keNB8l7Qc/i/XdYU=; b=IFjOG2GbrqL7OTrWskkgfsJ61+WjDD2IAbCeZL8Qx5IHCwu9BeDJvOmy0E/rl50QAP qSaFiDGqdPfGOvMPdNenR+VSWuVfabSfaCOv/28yiQ933JSqP5ssEaSksMQGHHD+DSyG dOMydt6let5QFMZvrQ9Mk010gWlOBXtJla8CytnH0fWCM4FGGmqnTtHSfs1ylYcK5T9q ZUizRjiWNM2G6W4wAoiyDf1elb46IKYWSLBexD4wuW3iJ1RX4Iv9SRqa2wV/6mo3m+rq BVRfjZkdC+ZYnM7Qf5DQ+UZlkBmPrXCQnDxRpTglw4EhaVRkmEsx6MuK0pk7d4jyA4sG Uyaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501064; x=1758105864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oOK2rQuOJsLR6f1VEysNbCIuj//keNB8l7Qc/i/XdYU=; b=Dkddyh74xkLJdbAFp41nGeTyyFrMdtUUXX/xBzMOu4uA5pDnrudyPAJ7xriXWA0N4+ eJjPzRQyLwfW1MSZ+9op+0q1bCU0UZswrCJrGexpdph023J5Hj/XgzNyd95kfemZRQwJ 8RruviUp8E1PgSS57qsyHTjkl51aO4WeDf+R3TxMEpWUEXU/Q9o+1JTvvPOHj3krFc2V ECyWDAaC3r7gYbjpL+EfiCa6LET3BnPCyQeDQCukx+Id+4b5qkBPYEXJCKsylG9f6zZt gvbWjAWOPESMG2EdqoLTC7j/GSd9WB4PKLIc7JGJbqksZh2Q3ZdtDLD7YXGomUO01PIb Y59A== X-Gm-Message-State: AOJu0YysgSHnHrHrbbv+k+AOftFrQwYPqcTqwAUZn38FIS6P1DyZ1pN3 Y6LTrbrJaR2lEk/Jh8MZ01aFtMxpfwhC1OSL6MiyXS/1d0E5VGdu51Ap15V4w/QAhbc= X-Gm-Gg: ASbGnctj+zjlkjJ6vauUhuO+/k8DqcUS1CDgL5hWRWlJnu7AG/n7yb64g9Y8m7LHWpu vQlXnYqQNbes/2J5a86ph2xV3/GhBt9J5pHBEHmrpmFbGs49kjf47FsP+AHX3a2Yux1ieC3KQg8 qO28ugYiGnhdJtoZkDx7/Cl4yRdhoCx5OlpHcFdKwqBB51Vm6cD9/5wWbrH7gyprbNYAPl+Mio6 2FoJjsh4F+XvpWFM+3aLlIiPFXFpA5gnJrEAPQUPgGeyoNbpAyYsERpUTEamKn8ho0dSYHI8oWb ilg4AQey8uPPcjdaYuHn5KKidCwaGakT8p2NctHG3wXZaJ/4F263JljHJ7a7T1ylmIlZMSW2xhV A0OqTLuskpm/r7n1w3r3QyFXX+4UZdD64lEu9rEX4jykr4jAQ5g== X-Google-Smtp-Source: AGHT+IHt9WChMw0+rY+8EShFnRqB8JsLiQJz6XJJbue94qNa0yNdnkkXZabhr0KiARU+GoUEdm4goA== X-Received: by 2002:a05:6402:42c5:b0:61c:3847:680e with SMTP id 4fb4d7f45d1cf-62373eee562mr7728900a12.1.1757501063860; Wed, 10 Sep 2025 03:44:23 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:23 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:05 +0200 Subject: [PATCH 09/13] memory: tegra124-emc: Simplify and handle deferred probe with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-9-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2718; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=sumypjm5su+//BJZ7zcWLArNigqTGnmSYrUE7kO9jkw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ2vhXVORmE0UBFyEJs1mgv9ug/wYJcfTIst KmztF1Wo2mJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWdgAKCRDBN2bmhouD 17CED/9WkA3GTNjR9hH5/Bgi2MEp8cmWRLy23FJaMLB/wg6jo48W9lMULvGXblt2H8rHk+5v+lf 3omqp/TJciy6Jfx5/pKBrkD2q6XwCspvoK8vr/t5VW29/8KWc1dRvgbHtIqMW2XMC5VdDCvokAX JwD+me8AvHVAtSFjyVvciffEdWGKIJMLrT4JQwZIdHKtyZY3MHB0p6fFAzqEFbOTg9OFpp/RfxX r1XbOuiBcOMhVm6828ZuTmCym3GYOmC7GNdakCYjYpEQRTWx5h3eHTdDEraIaF6x+XTK+gpsPOH t3i1owWjAdSSXfdW66DLlkJnccD9gDGAmHSs9kkCwU6vzQ3oXOeYaa9vk0dY2LDXPtNhazk3FQs YExryTstvsUSeGpWgCNve8T4D8T/mIhR//gxI1Q444Uj7uhhPrxhUqN13Z3nNiDmm6l9G1kRryz YFF4VvztJvsMv87R+e9OGFWVm6u16b9qqtyxHF7wgIletWNfvEziiPTANO8/gEJ6YiSrJj0+JGf otvAMn7dxcceztGc54UagCBcGal1rin5XpEtjA2J7qZaSp5b2iI1TGQNi47Zz0inrROCMKHQGOB XI4YY5mKMtPinLk/8ogdc+VquEe69iatFeEFkPSdwzFIDmDpOF6n8jOP1LDcL9rc5JYjGOzysqC mWFUso4M1rpzqZw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Certain calls, like clk_get, can cause probe deferral and driver should handle it. Use dev_err_probe() to fix that and also change other non-deferred errors cases to make the code simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra124-emc.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index f3372bd78ce8db666015a7844cba4e6aad79e61c..f4d703103d9ca155eca92331ee7= 62cecd4e01302 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -1379,9 +1379,8 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) =20 remove_nodes: icc_nodes_remove(&emc->provider); - dev_err(emc->dev, "failed to initialize ICC: %d\n", err); =20 - return err; + return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 static int tegra_emc_opp_table_init(struct tegra_emc *emc) @@ -1390,18 +1389,18 @@ static int tegra_emc_opp_table_init(struct tegra_em= c *emc) int opp_token, err; =20 err =3D dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1); - if (err < 0) { - dev_err(emc->dev, "failed to set OPP supported HW: %d\n", err); - return err; - } + if (err < 0) + return dev_err_probe(emc->dev, err, "failed to set OPP supported HW\n"); + opp_token =3D err; =20 err =3D dev_pm_opp_of_add_table(emc->dev); if (err) { if (err =3D=3D -ENODEV) - dev_err(emc->dev, "OPP table not found, please update your device tree\= n"); + dev_err_probe(emc->dev, err, + "OPP table not found, please update your device tree\n"); else - dev_err(emc->dev, "failed to add OPP table: %d\n", err); + dev_err_probe(emc->dev, err, "failed to add OPP table\n"); =20 goto put_hw_table; } @@ -1412,7 +1411,7 @@ static int tegra_emc_opp_table_init(struct tegra_emc = *emc) /* first dummy rate-set initializes voltage state */ err =3D dev_pm_opp_set_rate(emc->dev, clk_get_rate(emc->clk)); if (err) { - dev_err(emc->dev, "failed to initialize OPP clock: %d\n", err); + dev_err_probe(emc->dev, err, "failed to initialize OPP clock\n"); goto remove_table; } =20 @@ -1480,11 +1479,9 @@ static int tegra_emc_probe(struct platform_device *p= dev) return err; =20 emc->clk =3D devm_clk_get(&pdev->dev, "emc"); - if (IS_ERR(emc->clk)) { - err =3D PTR_ERR(emc->clk); - dev_err(&pdev->dev, "failed to get EMC clock: %d\n", err); - return err; - } + if (IS_ERR(emc->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), + "failed to get EMC clock\n"); =20 err =3D tegra_emc_opp_table_init(emc); if (err) --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4D37319875 for ; Wed, 10 Sep 2025 10:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501069; cv=none; b=EzqWEPSQqeXa1s6+PEpKJg3cSkFJ7B9wy9e5TDpN8Uhjwf9szXrv6PbsTK5kpi3vdUO1pb/X2Yb+OlqNL0GNSVyFOh9iavoMsEKmPfUZ4NtKpg0k+COYdLMP06kCaHw4vEzdOtMKoA5s6lmfC4vgl3U+7gu5VuyNP6mRj9nrxzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501069; c=relaxed/simple; bh=NsGEIgGjbOpROhUmLr+vi+i7gGp3+YQdgw+pRaV7CFw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nsnsxq8bOloREmoXpkJpbKUEMwC1N5uec39nLj9nazMbuLPBoyxKGTMS17NDLCbk92Nw4EUsiLLtvZNutEjKQxt6AEH8CMaD/wkxQaKHcfcpXtp5hxGooLwDXuFcwt6SYvNKmOLwpBX7yX5wpa0ofen3VDp8kmFA9kXs/uOl2zo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f0WXZJw+; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f0WXZJw+" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-628f2102581so598893a12.2 for ; Wed, 10 Sep 2025 03:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501065; x=1758105865; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/EvFDcJgp1O+VKVo0SG7emVdOYaEBH1SQVuBhC1JrkI=; b=f0WXZJw+0E7aTRRmvy52PXpfxOvbC1eT2Nxd7Fe0zT7DflyCbKjbTnU2xpxdNCulDA Ixwt8UWd1j/UnmZRw6H4GcCDXC4GxXRpqfJiAmEDhVo/ufSJVV4C4gJRF8PGbpDF+ona WOzULSC9QQL+dTU2c8C7BX8NGHQoROLR+5ABaOj/NpTmxXj8hFPD82Va19LF7oLxXCMF GDaAwqSachJasS3kKisKFIAHByWzviB5j/RtjpsdMFnuk4Y8/2JLF6qkqhPsMF+Z6MGc A4eyygcyBjuLtN2Nu5A4zi2B4kRfEq8n6nxDyFrdlwdt/IFPfOC4luW4RD0gcezUIe6g 98xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501065; x=1758105865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EvFDcJgp1O+VKVo0SG7emVdOYaEBH1SQVuBhC1JrkI=; b=DAy7Kdj73mcLnUDlJVvkcUydrXfRBJrQ8UinJRe8a4b0kdMc+Oqmk7CyDwrS2zMZP7 6WfXfeBgkDrdLc6esrLlV1pv2dpamH9hpNRAPs6wqdlfZFeyCgN/RKDKmx/4SoXAbcXZ ym4mn99H4OExY9KH4ChSaMFig8Dk411uCqfzXrjNGY+B5+gihEAp4uIA82HFX22Tn/tf 6w/nwpHn4J5EBAbxTxfgWGCuRsY01lT/DU8iiT/FD5kSXg5nrW/PQmrsY73IlmRm8ti+ y3GlaZBzFEyX9gYib14gly5DDhnMhsyBg0oAnuLJD2XXxulD4oXh9o9c3QjigRAh1S+H vLDA== X-Gm-Message-State: AOJu0YxZDO38Mr9yvP+B6tBky2mUg/fR5IZMDsCi1nKWT+zMofBpvoTW yVIZGGtxWiCkz40SzdVdVLUffgSmHOs9OzIWKVNSShCRYz+Qd1c/qaG0cGbptXvj05Y= X-Gm-Gg: ASbGnctyFrDSyHm5HSykVU1CplNZ1Ww2pkovp8fWhwOaUROj9FuZzv4PBP8lwMI6n9g 8VwPkvXSHq89IHrdk7VmWCAs0/hiHDxo5A6Il1gDN7MRjChXb5OpR2lgTMHWsFukLj2zcZ2vkga KkDQ5c4g8eQWTB3SvoCPwBNqqFWn5FbODnyz/JzwaWWYH/cMJLW4E7BEGBX3BfnmO+ltQT9q0nf dwGzMgIyKD3qVT93GjCx6D8Z4mD/MS8UNktxikXiX00igSFlj/j21aLGy6cyMd3qmdcjtN24tps WZJIldUfRc9vi9d/rLyQxQubUiigjTFED+RVlhlcEJ7+l0hehElpn+DLvty5mhdmAHU2NlCys/u 9g4pn47Z0b4PJgkgg3fJXjYLo45SS2RTNvU1iHsY= X-Google-Smtp-Source: AGHT+IGrVEygP3UQK3QPTRuiouliI2cTlmDJdwPnEmCPDJmwgq+w28bEx+GIfvtNrVdyRG2wjb+52w== X-Received: by 2002:a05:6402:5205:b0:628:20b9:2607 with SMTP id 4fb4d7f45d1cf-62820b928c8mr5230834a12.2.1757501065066; Wed, 10 Sep 2025 03:44:25 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:24 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:06 +0200 Subject: [PATCH 10/13] memory: tegra124-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-10-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10836; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=NsGEIgGjbOpROhUmLr+vi+i7gGp3+YQdgw+pRaV7CFw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ3uXiv8MPkFYPIlzPELdHjjsK8XWAaXGIe8 9TlHv+EB6GJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWdwAKCRDBN2bmhouD 12rFEACYAlo4n+X9dQpbM9T4VCfKNl28TRQtZdQtsAm1bXBSu3A4Zjy1WUpJ2PIDXv4RCEJOTvj 8QKuiLDav5lAv4OjyVEfCYi3vU00UgTgOW7QUV6VBDmrw0ml1GIUi4VKJdoEcARNLSjCwC2r5Ct yuezkb+zvIGvhObs1+gqA6zEwbrDQXDX/RjwdHr+NrWp3P1dBJ9nHLvxbl0d8AxVh2WCevcJ671 nvyqc9xKIPfF+CEJWHhhJsnN5lObBCirtXITAlrjy3QPxD4BFeMjfC1hmghOjOiZRAeCecBLhb7 IrmkqMkhE6579MgoehuRd4L1C7jVCm3cmQDqhe476LeBEQcjmxdlu+aGdpt6AftKnGhljIz7KZw hRGTiqV/7TSae63xw6IlbePYrWg4lViEi87FYLSbEjcJY7OIukZpo/gqyLh7BywZHbX9m5qipVa PrjrqyrDvzHOliozYBLKqZsbFGWx8xDCxpH81jlDOirLlcCWqDS053WJis7tMUc3msLrBBE7vsl EIrCeMKaTweVKhR1cJKssnZEw20CxrZFhbSQRaoWhFpitDisXIfDtNb4sYS2Rb8XP+Z980Q8Y7f oIz5OqKvbCKtlNA6YOIrMzh8MY7N8ZwbpSS5L2s3x7jjUJ45h4O2xY2I1ewBVJAQAQWGeWCLWaW zqHeffqH8uhEquA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra124_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra124-emc.c | 98 ++++++++++++++++++---------------= ---- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/teg= ra124-emc.c index f4d703103d9ca155eca92331ee762cecd4e01302..9978ff911c4790b30423064c8fe= 0d3d53e8efcef 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -571,8 +571,8 @@ static void emc_seq_wait_clkchange(struct tegra_emc *em= c) dev_err(emc->dev, "clock change timed out\n"); } =20 -static struct emc_timing *tegra_emc_find_timing(struct tegra_emc *emc, - unsigned long rate) +static struct emc_timing *tegra124_emc_find_timing(struct tegra_emc *emc, + unsigned long rate) { struct emc_timing *timing =3D NULL; unsigned int i; @@ -592,10 +592,10 @@ static struct emc_timing *tegra_emc_find_timing(struc= t tegra_emc *emc, return timing; } =20 -static int tegra_emc_prepare_timing_change(struct tegra_emc *emc, - unsigned long rate) +static int tegra124_emc_prepare_timing_change(struct tegra_emc *emc, + unsigned long rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra124_emc_find_timing(emc, rate); struct emc_timing *last =3D &emc->last_timing; enum emc_dll_change dll_change; unsigned int pre_wait =3D 0; @@ -820,10 +820,10 @@ static int tegra_emc_prepare_timing_change(struct teg= ra_emc *emc, return 0; } =20 -static void tegra_emc_complete_timing_change(struct tegra_emc *emc, - unsigned long rate) +static void tegra124_emc_complete_timing_change(struct tegra_emc *emc, + unsigned long rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra124_emc_find_timing(emc, rate); struct emc_timing *last =3D &emc->last_timing; u32 val; =20 @@ -986,8 +986,8 @@ static int cmp_timings(const void *_a, const void *_b) return 1; } =20 -static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, - struct device_node *node) +static int tegra124_emc_load_timings_from_dt(struct tegra_emc *emc, + struct device_node *node) { int child_count =3D of_get_child_count(node); struct emc_timing *timing; @@ -1015,15 +1015,15 @@ static int tegra_emc_load_timings_from_dt(struct te= gra_emc *emc, return 0; } =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra124_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra124-emc" }, { .compatible =3D "nvidia,tegra132-emc" }, {} }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra124_emc_of_match); =20 static struct device_node * -tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) +tegra124_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) { struct device_node *np; int err; @@ -1041,7 +1041,7 @@ tegra_emc_find_node_by_ram_code(struct device_node *n= ode, u32 ram_code) return NULL; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra124_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -1143,7 +1143,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, un= signed long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra124_emc_validate_rate(struct tegra_emc *emc, unsigned lon= g rate) { unsigned int i; =20 @@ -1154,8 +1154,8 @@ static bool tegra_emc_validate_rate(struct tegra_emc = *emc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, - void *data) +static int tegra124_emc_debug_available_rates_show(struct seq_file *s, + void *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -1171,9 +1171,9 @@ static int tegra_emc_debug_available_rates_show(struc= t seq_file *s, return 0; } =20 -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra124_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra124_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1182,12 +1182,12 @@ static int tegra_emc_debug_min_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra124_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra124_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -1199,11 +1199,11 @@ static int tegra_emc_debug_min_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra124_emc_debug_min_rate_fops, + tegra124_emc_debug_min_rate_get, + tegra124_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra124_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1212,12 +1212,12 @@ static int tegra_emc_debug_max_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra124_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra124_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -1229,9 +1229,9 @@ static int tegra_emc_debug_max_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra124_emc_debug_max_rate_fops, + tegra124_emc_debug_max_rate_get, + tegra124_emc_debug_max_rate_set, "%llu\n"); =20 static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc) { @@ -1266,11 +1266,11 @@ static void emc_debugfs_init(struct device *dev, st= ruct tegra_emc *emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc, - &tegra_emc_debug_available_rates_fops); + &tegra124_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra124_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra124_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1334,7 +1334,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra124_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc =3D emc->mc->soc; struct icc_node *node; @@ -1383,7 +1383,7 @@ static int tegra_emc_interconnect_init(struct tegra_e= mc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static int tegra_emc_opp_table_init(struct tegra_emc *emc) +static int tegra124_emc_opp_table_init(struct tegra_emc *emc) { u32 hw_version =3D BIT(tegra_sku_info.soc_speedo_id); int opp_token, err; @@ -1425,12 +1425,12 @@ static int tegra_emc_opp_table_init(struct tegra_em= c *emc) return err; } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra124_emc_unset_callback(void *data) { tegra124_clk_set_emc_callbacks(NULL, NULL); } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra124_emc_probe(struct platform_device *pdev) { struct device_node *np; struct tegra_emc *emc; @@ -1454,9 +1454,9 @@ static int tegra_emc_probe(struct platform_device *pd= ev) =20 ram_code =3D tegra_read_ram_code(); =20 - np =3D tegra_emc_find_node_by_ram_code(pdev->dev.of_node, ram_code); + np =3D tegra124_emc_find_node_by_ram_code(pdev->dev.of_node, ram_code); if (np) { - err =3D tegra_emc_load_timings_from_dt(emc, np); + err =3D tegra124_emc_load_timings_from_dt(emc, np); of_node_put(np); if (err) return err; @@ -1470,10 +1470,10 @@ static int tegra_emc_probe(struct platform_device *= pdev) =20 platform_set_drvdata(pdev, emc); =20 - tegra124_clk_set_emc_callbacks(tegra_emc_prepare_timing_change, - tegra_emc_complete_timing_change); + tegra124_clk_set_emc_callbacks(tegra124_emc_prepare_timing_change, + tegra124_emc_complete_timing_change); =20 - err =3D devm_add_action_or_reset(&pdev->dev, devm_tegra_emc_unset_callbac= k, + err =3D devm_add_action_or_reset(&pdev->dev, devm_tegra124_emc_unset_call= back, NULL); if (err) return err; @@ -1483,16 +1483,16 @@ static int tegra_emc_probe(struct platform_device *= pdev) return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk), "failed to get EMC clock\n"); =20 - err =3D tegra_emc_opp_table_init(emc); + err =3D tegra124_emc_opp_table_init(emc); if (err) return err; =20 - tegra_emc_rate_requests_init(emc); + tegra124_emc_rate_requests_init(emc); =20 if (IS_ENABLED(CONFIG_DEBUG_FS)) emc_debugfs_init(&pdev->dev, emc); =20 - tegra_emc_interconnect_init(emc); + tegra124_emc_interconnect_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1504,16 +1504,16 @@ static int tegra_emc_probe(struct platform_device *= pdev) return 0; }; =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra124_emc_driver =3D { + .probe =3D tegra124_emc_probe, .driver =3D { .name =3D "tegra-emc", - .of_match_table =3D tegra_emc_of_match, + .of_match_table =3D tegra124_emc_of_match, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra124_emc_driver); =20 MODULE_AUTHOR("Mikko Perttunen "); MODULE_DESCRIPTION("NVIDIA Tegra124 EMC driver"); --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A82131A065 for ; Wed, 10 Sep 2025 10:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501070; cv=none; b=MY7Ckz9sh/2Hf78nOjVS5uX0NizHy5t6Jnx4JphZBQ4A3dOZw7YDm2qnp4YPqb8E+n8nk5MJO9/nuWf2ruBKVY1EEIWN5SJ59rhrIrANBGsW0RXvlnT1Pbar3gj8GNhSTTXjC0erfvTyT1AVOLF+gYHwuYg4wE6XYrDCleEkPXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501070; c=relaxed/simple; bh=Wq0vuHhTAJlaPz6HkeacWOsQOmTgXgsMsPqpxkUBtX0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FRToIjAJt72nZWQcmhwBBjS1bH8filHWvHL9OH9GhW+ihRe2Qxgk06Ckw1eJiv+j8M+hhHUq6oiCGfHXC+mQJ2lJgYPCddekU8e/0icD0utUtBDz5O/ZLLk8Oko3ffC17cxh8q16L73xBrFXcH0DqVYcwLAgqIGpn0+VrfW4nTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qiiutLdN; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qiiutLdN" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-61ebed1e37fso909409a12.3 for ; Wed, 10 Sep 2025 03:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501066; x=1758105866; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sk0N8hWIhOaA0zE24bk/claWEtHXKITnd4Xgk+Np0Gg=; b=qiiutLdNnJwSYh+F4T+QmXsA08RwrsqfxgcPtgUQ0YI8FdL7ePMImnUJ2ai+UNwxgi C9q+GkgRFNO+ySBglfADK4jauuvEgv7ZpUlXPlqQhEcDHwmuxeK0DkVCy8vRsNR+f4HY ++zEHDuPHE7r+Fzg4wxyZLZplNU6eMed1j7EclY8l+539BIHIko7Zvpa0wsQ+V5DFYIy m4FzUTqlDONXJoFeJWPXSMWdPwdYKGlG/1B2h8g+1eBB5bO91PTbNImKjDRJuSF4FR8K tqahKdWkufMhWWwaEvKViaJsKhHSpaLa38PYBB7GGJp5bnyuyWXaMYswqppqcFh6Heif H5qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501066; x=1758105866; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sk0N8hWIhOaA0zE24bk/claWEtHXKITnd4Xgk+Np0Gg=; b=KfIaxsvjcuqW5PPaXjMPzDFJ8hQNFqJxZA2JEjV6YNqN8EDBLobPX+AdOvYNjZ1lw/ dR2QjsfhvFtWdh4CwyIJzVmU6HzB/g1bFK5By9WGX/LylmQNb1S4uDIa5gn5H2Sb/srm +1KCv76rDc/8xozb7XpZ0/6k8NC9OjCwTaE3TvuuFbcljyDXK6AMewQRkL1K2Zdgoj/F xnnSXnFKOM6FNR+Rq8VlnaAlZ10wZqjG0N9pfe/hpwXZsM+GxJUTnAZTZkdhbURAsoEs Zqmpj7uL0JRBcBALbRoJzQz2zOdIwGKnUSTBVP0gwQpOMU216pHLHmF0M5593Rpx+2Rq ooUQ== X-Gm-Message-State: AOJu0Yxq6KGVdt5F+65yjSR/9stG0tMRyni+c+AceWiw/QG5fvGXS/I/ 9GGw1KxhoKWtQjdUL5g63uow+Mcg1m43n61bAq3GD5YpvgSGbT6Unlcsnw2c4Ni4O6I= X-Gm-Gg: ASbGnct5IbW3ZyJdKKFY9AeDbJRyhtfCmmff7vBjimkpbh8W8HzZWkqM9n4P1lgIFkm mArIKnkTedsJxvZwBW7lneJnnlNej0FL9wUfQUB561Dhw0fhO/JJ+2/em+td5/SdpAdmNCeJTSJ Ot070KCpvBd963lL5hQvukkisUJfCcVhL03hvJWOJPoc9PVvm+QjpiM2Cbt8bSApxpJeM1tQIOI uqDYAgCU+zjMiRQaOAzw6/wb13bTebMrkKfAEW319PS5Dqw7PWbWEMgN2KPCHvyZJ2d2b1zGE4z DtdZnEmg53ztG2kPRrwiIGleH49j/Wu0uf2SMMY5kOIIuN3Yt4lEpvTzPaqVBqlCCZuJ21s4idi Ayg+sfCsbJ9n6yzkDX++1a4UN2+zh+sAM0EyGyp6X9mAcoYq1qQ== X-Google-Smtp-Source: AGHT+IFcwfWKWYZW56frObvDREjVKz5uTu21j6RaZXvJLRMYEJI2JkqVO8Se3R+b4vV35iyYOlqO4Q== X-Received: by 2002:a05:6402:520e:b0:61e:a890:aee6 with SMTP id 4fb4d7f45d1cf-6237a42fb5emr7068174a12.7.1757501066334; Wed, 10 Sep 2025 03:44:26 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:25 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:07 +0200 Subject: [PATCH 11/13] memory: tegra186-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-11-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3374; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=Wq0vuHhTAJlaPz6HkeacWOsQOmTgXgsMsPqpxkUBtX0=; b=kA0DAAoBwTdm5oaLg9cByyZiAGjBVnjI2IvsYqiYyv0pRCbNw1ssBZQM2iUs4590HSHcaqjXi okCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJowVZ4AAoJEME3ZuaGi4PXIogP/jri eTvg8lNymEqXda0LSA2MJ/fWzDkAgvrpc3hUt1Dp4ziZ2CtujieSyZBnriJFHI6BBgtG8dQ/vV5 P/XOybdwQu1XQxT/6aE9IFmQadK4QJRpi++DeB+OQvGLDrKtcDZVCzrVhzqTcfCA+vjEFbmK+Vu q8QxvCoez9BQF2XgASjdDD9B4WfQCAmZtKKp/8em+mI5RZG/DQPHsEDbeu3SmLWQO4e7GsORYPt K+JAGVRto+BsoT7TlwBEYPk4OCmQj5pW/V9hcpu2mnR9pX23JMU2w4hnEOhWZwGh/Xktzm/jn3M FHeogvttFWb86SOf+yRGztM8KSvSa4vy3NnZvF/pzA0d4giLAmyb+wN63dlkngQObm8X8xfpJDq KWXpnb1uNy/LKsrmtcNPiMoKEzI+Ttomy/Mxlt+runpVeqkDhLRMMt4y+qKu6mJwUN3KzliYyXy dBVyLtKzF8CGczDljsn1iazYmDvwUBH2GbyJX8q9dUZH9t4Dadh3GsN54f+aiJlxroxchHKqlmG MHGCIGHuKeUsJwO5v3E8Ps/g70YE1/+K8CmYTLK83Ivo2qnF0dgXSqdta0w3Qz3mwDK12qF/zN+ YTCMwo3ct10GmjTeJhDktW249YCgFk9NWnX5VHzzXE/Ci0AA2v3MfC8OfzQX09LHwUyS/IVKbS8 WhJxX X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra124_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra186-emc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/teg= ra186-emc.c index a0de80afe3e90531fcfb29d20773aed0d04478c5..9959ad5804b444b269456d1fbae= 87b4bc111661b 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -218,20 +218,20 @@ static int tegra186_emc_get_emc_dvfs_latency(struct t= egra186_emc *emc) } =20 /* - * tegra_emc_icc_set_bw() - Set BW api for EMC provider + * tegra186_emc_icc_set_bw() - Set BW api for EMC provider * @src: ICC node for External Memory Controller (EMC) * @dst: ICC node for External Memory (DRAM) * * Do nothing here as info to BPMP-FW is now passed in the BW set function * of the MC driver. BPMP-FW sets the final Freq based on the passed value= s. */ -static int tegra_emc_icc_set_bw(struct icc_node *src, struct icc_node *dst) +static int tegra186_emc_icc_set_bw(struct icc_node *src, struct icc_node *= dst) { return 0; } =20 static struct icc_node * -tegra_emc_of_icc_xlate(const struct of_phandle_args *spec, void *data) +tegra186_emc_of_icc_xlate(const struct of_phandle_args *spec, void *data) { struct icc_provider *provider =3D data; struct icc_node *node; @@ -247,7 +247,7 @@ tegra_emc_of_icc_xlate(const struct of_phandle_args *sp= ec, void *data) return ERR_PTR(-EPROBE_DEFER); } =20 -static int tegra_emc_icc_get_init_bw(struct icc_node *node, u32 *avg, u32 = *peak) +static int tegra186_emc_icc_get_init_bw(struct icc_node *node, u32 *avg, u= 32 *peak) { *avg =3D 0; *peak =3D 0; @@ -255,7 +255,7 @@ static int tegra_emc_icc_get_init_bw(struct icc_node *n= ode, u32 *avg, u32 *peak) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra186_emc *emc) +static int tegra186_emc_interconnect_init(struct tegra186_emc *emc) { struct tegra_mc *mc =3D dev_get_drvdata(emc->dev->parent); const struct tegra_mc_soc *soc =3D mc->soc; @@ -263,11 +263,11 @@ static int tegra_emc_interconnect_init(struct tegra18= 6_emc *emc) int err; =20 emc->provider.dev =3D emc->dev; - emc->provider.set =3D tegra_emc_icc_set_bw; + emc->provider.set =3D tegra186_emc_icc_set_bw; emc->provider.data =3D &emc->provider; emc->provider.aggregate =3D soc->icc_ops->aggregate; - emc->provider.xlate =3D tegra_emc_of_icc_xlate; - emc->provider.get_bw =3D tegra_emc_icc_get_init_bw; + emc->provider.xlate =3D tegra186_emc_of_icc_xlate; + emc->provider.get_bw =3D tegra186_emc_icc_get_init_bw; =20 icc_provider_init(&emc->provider); =20 @@ -354,7 +354,7 @@ static int tegra186_emc_probe(struct platform_device *p= dev) * EINVAL instead of passing the request to BPMP-FW later when the BW * request is made by client with 'icc_set_bw()' call. */ - err =3D tegra_emc_interconnect_init(emc); + err =3D tegra186_emc_interconnect_init(emc); if (err) { mc->bpmp =3D NULL; goto put_bpmp; --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8BB31A550 for ; Wed, 10 Sep 2025 10:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501071; cv=none; b=W/2j0KtYK9GbQjf8x6SeV9xWt8RfR3p5v0ES+mEmrF0RQVhospTBQ3opJLd8SWlcBCIY3L5tSSGqvo0MZlJqFN0/dYWkBHPv1qKSmgyOr+I2nC8aV4afWNFPcnorECDOY/UlbcoR8BzlcTmzMCejvGDYw5bfzr1mmw3xLebxrHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501071; c=relaxed/simple; bh=VIT4BVi7PGamIjlHfjP1qCV0HY0GyKrHNwwafRKVOd8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Szu7tyKcN1Fwcgz6gRrlSD+TqF2tinbOEfsOlEKW7adaOdgFfogLelYlqEiNqEaM2nQcE6yp2SvpKIX4ueanE2xvrMzWg5VXX0dHa/yIQWzty5ohuOb/jafhB/pBDPYBtLACAZYj4jrwZbjBjbbcAq3evXGVKMI77M1DUouXEXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DyYjyERU; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DyYjyERU" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6285612382aso472850a12.2 for ; Wed, 10 Sep 2025 03:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501068; x=1758105868; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uMhep867hi/WSPi221RnZKx2fygpfaLD3zan7lNwq6o=; b=DyYjyERUrXAG4jLLd15cLFb2rugB+8W1MRpOOtTA3sS451q+PYL9kTxqcdKQM3hJ/x hzXc9rcpdOi9SvTgw1hAU3ObL6vFz5WcushjKxhNVQ64qdGjSHR4zzbTEFOaaU6wvTxZ VviwnYbPkXBB5IAN7f45MKtDbFg9104PJRsHIGKmgwLV8LBCBwXMm3rpNfnE43wNmttN DsvvapaRIgUElAJfXe6vDck0+DPL69P199T7kYaFPfquGUV0BS92fA4F0pojdu8mKsHf UCjuIlOB55wpxVSWbrHQtJOkPwg1Ntb4/GCYlypye2yqPh046iGHzb6pmeQUD8kWH/Xn OALA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501068; x=1758105868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uMhep867hi/WSPi221RnZKx2fygpfaLD3zan7lNwq6o=; b=aBKNreeUnwk9pvz6XcFm6r2gD2jb7AedxYccJI9fdi2sOCAsswu2C+gmIrc6G7waB7 0Mp/S5CzEv3YAJWCpN2PnhpZNoUdMOX7gAbYtlymBpcj7hhD17NZbXgv48zUBcTjzJPu XBFAACSEopJSMHAXpW+GLgpi1AnihlNsFM4xXHl2ok4Jsc443/fUXIXYimuh+GpqDCKb n/H6zXKsYx/ICOmFLlgBy84BubxQErEfOCrw6RM4o/4YDyGQAUMm1YKLuq0DcIDj5KIt +A2Qkg3h47pCkv3p1fyA0hQCYQrQdbwk3iUZzmVGcUjCxfAxR8QG7+uHHl4jw+W2yMbN BsQA== X-Gm-Message-State: AOJu0YwPNKG87O/k3NoIu1skr9sYLFdV9r3fDTdC/jnIz4SsB4MQIiOM gNuFiplTPa6sXCLVIFAQZUIcY66T9QxxcV/UH8QW04D1RHXuyYEh0ZdMs0gfWs1Lc7o= X-Gm-Gg: ASbGncu6PBkWtK6zBfgb62elP0wAQQf9e2qm8kDPodXsZrUpqNGEOfzRRuSt3bUGh5/ ZaPjKZI+jHe8LO8c6BobJPqF15CoIKetkk7rl+vMtZk5AwR6hrikP+71u3VtUYnSJaUHfCDHmxh bcC6tlKNWokYE9h0G0/yrcjM1nwQoUqGnZjGpoeNtG0KtVp84gil3mmivWmqDqzPgyrEcnkttUm rmvTu+9S/vatHYSd+iySKepl6zzZMSUdPCbQc9fJp0CnNg3aTJ6u/2oJQp+zlMFDJHDCZIme2UX Ht2SLvYizcABhrhbyHoUjvIZZPVt2AZOQO69yGfAlyiqMtI7/YeP+0e62+AyHu11fTGxkxHnuIo 3xdI1oh3X+NiaYUV/3IbbrOzLh8Zi0y0WsMK5Hps= X-Google-Smtp-Source: AGHT+IFzf0g0NWfkrve+N7cuLykZWPWms9zeLTyEANk1GoJ2ax587AmJmXhxcd7kpirVpRJ6NIlPOw== X-Received: by 2002:a05:6402:2345:b0:628:3c12:8732 with SMTP id 4fb4d7f45d1cf-6283c1294c9mr5449285a12.8.1757501067604; Wed, 10 Sep 2025 03:44:27 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:27 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:08 +0200 Subject: [PATCH 12/13] memory: tegra20-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-12-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=13253; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=VIT4BVi7PGamIjlHfjP1qCV0HY0GyKrHNwwafRKVOd8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ5CgpYqYKDVYneA/z1dP3fWU06KkvdXodpi U57l9+4suaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWeQAKCRDBN2bmhouD 189yD/9RWm5boPty65v9D7YeaRJ0V/X8esPnWWkPKKbmSFJfTS4ZKbMiCoqXCCMgGAADDiToxwq G5YkgFb7yp8a95+mRxcCwjmI712eBDdJ8K5cV4AANi16JOqLie2yNsel0VH4QHjUw0K0CBdZjUF SpYRsksaoV9shiQv1dJaEt20qle1B9zFgYsObJbQK6L3lGLwkuGPaBneqqxfLvLfV4XIQo9Q3+V 5ETqJ9Pok58S2lVDnPXBVajX8clIchlc6EtEN7eNxKB/jagvszDp1q1UdDnSWPE16majXALMkVa 15nF5TmOROEyc8P+dtsqP3MsgWpNtGgYYbDcoQXeeG9mPcKxWvNSBo696LdMUqsdH3DBpYwawDT lxUEcKX7Q2mCt3ysNtL+FTVdsf3mQM1EsfExzRvZOWDnZtONGl/h6OzbrZG7KLxGDhk1UlzHbgC nPxVjsVNB/Se6eGN6T/UOult89EqW+4r6vKYN0V9dUeqZyYs3eJs6detENVEkA4cgDhYVZgWkKD /9c8+8jL5U4cKmFbXYQEQXyzUJomv7oZyfcikujBd4XkaTN9y09g1gpK5fUgiC7GyY1XW1j48Lj YvJj7e09dmgqUXVvNLXhlOIFFv/onD14bAcXBVvvFJlxaAMuzYKIg3q7JaQ6aSKD6BvU/7Wq9mj OSN+J4ZrQlrrkCw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra124_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra20-emc.c | 120 ++++++++++++++++++---------------= ---- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegr= a20-emc.c index 18e266dde5d2a0fb962fadc04161b03fb79f76cb..398cb8ae2e38736fcac04d71738= b11b3d5b75f4e 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -232,7 +232,7 @@ struct tegra_emc { bool mrr_error; }; =20 -static irqreturn_t tegra_emc_isr(int irq, void *data) +static irqreturn_t tegra20_emc_isr(int irq, void *data) { struct tegra_emc *emc =3D data; u32 intmask =3D EMC_REFRESH_OVERFLOW_INT; @@ -253,8 +253,8 @@ static irqreturn_t tegra_emc_isr(int irq, void *data) return IRQ_HANDLED; } =20 -static struct emc_timing *tegra_emc_find_timing(struct tegra_emc *emc, - unsigned long rate) +static struct emc_timing *tegra20_emc_find_timing(struct tegra_emc *emc, + unsigned long rate) { struct emc_timing *timing =3D NULL; unsigned int i; @@ -276,7 +276,7 @@ static struct emc_timing *tegra_emc_find_timing(struct = tegra_emc *emc, =20 static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long = rate) { - struct emc_timing *timing =3D tegra_emc_find_timing(emc, rate); + struct emc_timing *timing =3D tegra20_emc_find_timing(emc, rate); unsigned int i; =20 if (!timing) @@ -321,8 +321,8 @@ static int emc_complete_timing_change(struct tegra_emc = *emc, bool flush) return 0; } =20 -static int tegra_emc_clk_change_notify(struct notifier_block *nb, - unsigned long msg, void *data) +static int tegra20_emc_clk_change_notify(struct notifier_block *nb, + unsigned long msg, void *data) { struct tegra_emc *emc =3D container_of(nb, struct tegra_emc, clk_nb); struct clk_notifier_data *cnd =3D data; @@ -407,8 +407,8 @@ static int cmp_timings(const void *_a, const void *_b) return 0; } =20 -static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, - struct device_node *node) +static int tegra20_emc_load_timings_from_dt(struct tegra_emc *emc, + struct device_node *node) { struct emc_timing *timing; int child_count; @@ -452,7 +452,7 @@ static int tegra_emc_load_timings_from_dt(struct tegra_= emc *emc, } =20 static struct device_node * -tegra_emc_find_node_by_ram_code(struct tegra_emc *emc) +tegra20_emc_find_node_by_ram_code(struct tegra_emc *emc) { struct device *dev =3D emc->dev; struct device_node *np; @@ -710,7 +710,7 @@ static long emc_round_rate(unsigned long rate, return timing->rate; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra20_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -812,7 +812,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, unsi= gned long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra20_emc_validate_rate(struct tegra_emc *emc, unsigned long= rate) { unsigned int i; =20 @@ -823,7 +823,7 @@ static bool tegra_emc_validate_rate(struct tegra_emc *e= mc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, void *= data) +static int tegra20_emc_debug_available_rates_show(struct seq_file *s, void= *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -838,9 +838,9 @@ static int tegra_emc_debug_available_rates_show(struct = seq_file *s, void *data) =20 return 0; } -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra20_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra20_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -849,12 +849,12 @@ static int tegra_emc_debug_min_rate_get(void *data, u= 64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra20_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra20_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -866,11 +866,11 @@ static int tegra_emc_debug_min_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(tegra20_emc_debug_min_rate_fops, + tegra20_emc_debug_min_rate_get, + tegra20_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra20_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -879,12 +879,12 @@ static int tegra_emc_debug_max_rate_get(void *data, u= 64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra20_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra20_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -896,11 +896,11 @@ static int tegra_emc_debug_max_rate_set(void *data, u= 64 rate) return 0; } =20 -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(tegra20_emc_debug_max_rate_fops, + tegra20_emc_debug_max_rate_get, + tegra20_emc_debug_max_rate_set, "%llu\n"); =20 -static void tegra_emc_debugfs_init(struct tegra_emc *emc) +static void tegra20_emc_debugfs_init(struct tegra_emc *emc) { struct device *dev =3D emc->dev; unsigned int i; @@ -933,11 +933,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc *= emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, - emc, &tegra_emc_debug_available_rates_fops); + emc, &tegra20_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra20_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra20_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1000,7 +1000,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra20_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc; struct icc_node *node; @@ -1055,25 +1055,25 @@ static int tegra_emc_interconnect_init(struct tegra= _emc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra20_emc_unset_callback(void *data) { tegra20_clk_set_emc_round_callback(NULL, NULL); } =20 -static void devm_tegra_emc_unreg_clk_notifier(void *data) +static void devm_tegra20_emc_unreg_clk_notifier(void *data) { struct tegra_emc *emc =3D data; =20 clk_notifier_unregister(emc->clk, &emc->clk_nb); } =20 -static int tegra_emc_init_clk(struct tegra_emc *emc) +static int tegra20_emc_init_clk(struct tegra_emc *emc) { int err; =20 tegra20_clk_set_emc_round_callback(emc_round_rate, emc); =20 - err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unset_callback, + err =3D devm_add_action_or_reset(emc->dev, devm_tegra20_emc_unset_callbac= k, NULL); if (err) return err; @@ -1088,15 +1088,15 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, - devm_tegra_emc_unreg_clk_notifier, emc); + devm_tegra20_emc_unreg_clk_notifier, emc); if (err) return err; =20 return 0; } =20 -static int tegra_emc_devfreq_target(struct device *dev, unsigned long *fre= q, - u32 flags) +static int tegra20_emc_devfreq_target(struct device *dev, unsigned long *f= req, + u32 flags) { struct tegra_emc *emc =3D dev_get_drvdata(dev); struct dev_pm_opp *opp; @@ -1114,8 +1114,8 @@ static int tegra_emc_devfreq_target(struct device *de= v, unsigned long *freq, return emc_set_min_rate(emc, rate, EMC_RATE_DEVFREQ); } =20 -static int tegra_emc_devfreq_get_dev_status(struct device *dev, - struct devfreq_dev_status *stat) +static int tegra20_emc_devfreq_get_dev_status(struct device *dev, + struct devfreq_dev_status *stat) { struct tegra_emc *emc =3D dev_get_drvdata(dev); =20 @@ -1137,13 +1137,13 @@ static int tegra_emc_devfreq_get_dev_status(struct = device *dev, return 0; } =20 -static struct devfreq_dev_profile tegra_emc_devfreq_profile =3D { +static struct devfreq_dev_profile tegra20_emc_devfreq_profile =3D { .polling_ms =3D 30, - .target =3D tegra_emc_devfreq_target, - .get_dev_status =3D tegra_emc_devfreq_get_dev_status, + .target =3D tegra20_emc_devfreq_target, + .get_dev_status =3D tegra20_emc_devfreq_get_dev_status, }; =20 -static int tegra_emc_devfreq_init(struct tegra_emc *emc) +static int tegra20_emc_devfreq_init(struct tegra_emc *emc) { struct devfreq *devfreq; =20 @@ -1165,7 +1165,7 @@ static int tegra_emc_devfreq_init(struct tegra_emc *e= mc) writel_relaxed(0x00000000, emc->regs + EMC_STAT_LLMC_CONTROL); writel_relaxed(0xffffffff, emc->regs + EMC_STAT_PWR_CLOCK_LIMIT); =20 - devfreq =3D devm_devfreq_add_device(emc->dev, &tegra_emc_devfreq_profile, + devfreq =3D devm_devfreq_add_device(emc->dev, &tegra20_emc_devfreq_profil= e, DEVFREQ_GOV_SIMPLE_ONDEMAND, &emc->ondemand_data); if (IS_ERR(devfreq)) @@ -1175,7 +1175,7 @@ static int tegra_emc_devfreq_init(struct tegra_emc *e= mc) return 0; } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra20_emc_probe(struct platform_device *pdev) { struct tegra_core_opp_params opp_params =3D {}; struct device_node *np; @@ -1191,7 +1191,7 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return -ENOMEM; =20 mutex_init(&emc->rate_lock); - emc->clk_nb.notifier_call =3D tegra_emc_clk_change_notify; + emc->clk_nb.notifier_call =3D tegra20_emc_clk_change_notify; emc->dev =3D &pdev->dev; =20 emc->regs =3D devm_platform_ioremap_resource(pdev, 0); @@ -1202,22 +1202,22 @@ static int tegra_emc_probe(struct platform_device *= pdev) if (err) return err; =20 - np =3D tegra_emc_find_node_by_ram_code(emc); + np =3D tegra20_emc_find_node_by_ram_code(emc); if (np) { - err =3D tegra_emc_load_timings_from_dt(emc, np); + err =3D tegra20_emc_load_timings_from_dt(emc, np); of_node_put(np); if (err) return err; } =20 - err =3D devm_request_irq(&pdev->dev, irq, tegra_emc_isr, 0, + err =3D devm_request_irq(&pdev->dev, irq, tegra20_emc_isr, 0, dev_name(&pdev->dev), emc); if (err) { dev_err(&pdev->dev, "failed to request IRQ: %d\n", err); return err; } =20 - err =3D tegra_emc_init_clk(emc); + err =3D tegra20_emc_init_clk(emc); if (err) return err; =20 @@ -1228,10 +1228,10 @@ static int tegra_emc_probe(struct platform_device *= pdev) return err; =20 platform_set_drvdata(pdev, emc); - tegra_emc_rate_requests_init(emc); - tegra_emc_debugfs_init(emc); - tegra_emc_interconnect_init(emc); - tegra_emc_devfreq_init(emc); + tegra20_emc_rate_requests_init(emc); + tegra20_emc_debugfs_init(emc); + tegra20_emc_interconnect_init(emc); + tegra20_emc_devfreq_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1243,22 +1243,22 @@ static int tegra_emc_probe(struct platform_device *= pdev) return 0; } =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra20_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra20-emc", }, {}, }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra20_emc_of_match); =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra20_emc_driver =3D { + .probe =3D tegra20_emc_probe, .driver =3D { .name =3D "tegra20-emc", - .of_match_table =3D tegra_emc_of_match, + .of_match_table =3D tegra20_emc_of_match, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra20_emc_driver); =20 MODULE_AUTHOR("Dmitry Osipenko "); MODULE_DESCRIPTION("NVIDIA Tegra20 EMC driver"); --=20 2.48.1 From nobody Thu Oct 2 21:47:21 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9082F31AF0C for ; Wed, 10 Sep 2025 10:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501072; cv=none; b=EETkUOGtZ+H4Bo5+p5poeZLaY2pTEZm+lhkVdH4Ei8U/Phcuk0a6mjHyZh+65NuEpwyThZI3cPyohHOztelniQsnv0UJLJWVf2J042/qBGa+f54DThbJMq0/4V1VJbe5dJLTIIzQG+9dYRVdkL5ihYida7FPVoqzo7R9GBakTII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757501072; c=relaxed/simple; bh=tlQi3r+H1JGGrk/YLRDqB/Z+oPYppKLe5bLhnA4eaRQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nQ3asuLQ0hw5WuGHwlwQ2TWbVy0ZALH+i8olW4OwgeTejd9AKLRmW89Ani30j3g9AAp+MVaereL8DLomcLb1HC6Skt1V0B4mjuWMZjFWgra9FdGNOQdV4NhMLdc7Dtdy8K44okPmiw/jYNpn0+F1O1SBGg4OVwxwTgAMwXvJM4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fQTWcIce; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fQTWcIce" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6217d0a194eso962392a12.1 for ; Wed, 10 Sep 2025 03:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757501069; x=1758105869; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=awjAmmSZbAFmfogi+S/l4kjOeQDsQkYCuybhjXS0HiI=; b=fQTWcIceO40bLqzMmCz0LAqlbBYWcU327dNInAf+QoJU/bOxfBMmqBdvKtD2/GjV6j 1NUO191TjaFYK3z3sbb9Bc1a5VqNFK0Gir6Z8zrJivj8DRgUKcuOMHbYJUujkgYvrfNG WycQXOd7FnLa9IqbDl2V8FXn+SU/uVfyILlIufpOYc4hlZYGeb6OlrYvgazEDrLxr38i 7z/N1ZznsaA4ScVa0j0iPkOQJFAfi3ekj3uSkGhs6SRclRog+32TAvYgBLo6egmLGWtD 0UkZ7A/Syn6zwcQaatFk2pd2judJT52u9XA/rwVW5O7qdVb0zAUhoKE6uqhtjQv2A5o4 BzoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757501069; x=1758105869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awjAmmSZbAFmfogi+S/l4kjOeQDsQkYCuybhjXS0HiI=; b=ej4cylhlphYZJEKN8vIz7/yfZo/5SW7PaljG34wc1GHKnoieS7xQOb/uBm8jzbfD4x yokD0NZqsj+3fDAY+Jwf4U+cb2lAl4/tBAD0JCAA/TBFY9qSDNfxd2SWCKeBUfHevdo8 T3y2ScY+annXkyGfY/mOlAaHrHW4hh8rI6XTlfxKlfCpKU+qWn4ZSOi/URaTQFugV7si z8LBopxE+gepXxNOWwV8GU2dlek4s1QbEg/RmerBaHBUuSXZgT87Sdx85y5WKACv0Mv0 llyb03/WLH7Nm/aHudJpdqsacYRGB+p9ozQwr5z2ZXh0iVKxZErOg7/E3LEHJcgoZ237 CCHw== X-Gm-Message-State: AOJu0YzbayXyebstaE+qlbTq3uTiiTRO0tLBD7japLH5wriIf/e28PEt HTPKBy8e3tEgSSNVTsi3pl321S6gO6pTJtG+9PmT+KYxtzKrfZT1spTRU/IM8zNv7Ko= X-Gm-Gg: ASbGnct3aIsqQFKUWyw/kWpKFGO+QzU38CJdWs4wNTDeEEgpaJTf2bdT5JzUZMESK29 P0+T/yixfWSaijq+ZPnWmcszpiAEDNgeNAI53xL1DvkfMEqzPFn0BdkX4mxs/xGyA9hA3ycHBxj EuO2sWtWvzLIdEu/Y6HgMiOod+GXx0opgZffwuN4yi50BX5xntAjOonpCDwa2k7NrHL4usGGfow +QH+BHtryIsfaPIRk6B+Hs5skGcfqmWET3Iftwgnh/sQauI/+N8xKEbQ2nE9VZj3PlBWlnXwnB5 ImSelw/dnoP185FORAykmZbVhrkt3yhf7JoC9QPZ12Cpu/PGIHCJ5P62hgSQJqU1qAG6X4I8XMt TDcIsDlLfMUhaVE+kKUCkK4XRPEoioXv2aHLfo2BhgFENOHxfYw== X-Google-Smtp-Source: AGHT+IHYWOvbvSNVW7lGcnVhQ31yPAiSLv/hdr/5YNQZR/qNGILwRXiZbORt5T5qnaUAFzFEzwKbDA== X-Received: by 2002:a05:6402:26cf:b0:62c:af05:580d with SMTP id 4fb4d7f45d1cf-62caf055e13mr1859284a12.0.1757501068808; Wed, 10 Sep 2025 03:44:28 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62c01ae5f75sm3144890a12.46.2025.09.10.03.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 03:44:28 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 10 Sep 2025 12:44:09 +0200 Subject: [PATCH 13/13] memory: tegra30-emc: Add the SoC model prefix to functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-memory-tegra-cleanup-v1-13-023c33a2d997@linaro.org> References: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> In-Reply-To: <20250910-memory-tegra-cleanup-v1-0-023c33a2d997@linaro.org> To: Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Aaron Kling , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=9709; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=tlQi3r+H1JGGrk/YLRDqB/Z+oPYppKLe5bLhnA4eaRQ=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBowVZ6p+Wg/cvmcpBedI/b23/dTkekCQenKngl8 zJ4021ZUYmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaMFWegAKCRDBN2bmhouD 1xH/D/9v/cFr1rPdatL40Y7SD7ZLaHS1ZHY2/PasggZV3bZuTOpnuVu3Wfng6cFgfPOvkyqDpWf 6xh3J3hj+FH9mkF236GAZq0zk8MibaMmL3jxhqJ0o+1c0XUjX6luZefSoBuxGRp5szuFioL34XZ tXTpU0/eI4zIfHLJGUU/mE0zgVrq/SO7zMRcdUZvyPGslJlWesMSnSzyUR2JZOHPBLbzsRmb8YD Eh9lYwNnqQ2KHbmPI5u2SaTLPRKKiM/j1ioAS47NY4oVkxfIv4twuPjPKq7X1iqkpr3lKW0nVl7 OUx5eijBmbLZRzOHc6nUJKuedUgMv9AmMjBTo1Q2r7qEijVbY3Mew+3emBATEHixykRkTrZNjcc x1A5wO2m+y+ZCNZ4oBZQw51CHd5mLvL7lss6ifVDASn6e/iLODbhWTqmbEsyxE8r9hvCz335ZkM zv8t9Jfz022bDuw0kX8lbzf50gCqE9wYIQ/B+5lJc8Zj6p8V/BA5hiiW0xCTsVZOApusRHUX8p2 8mJcwZI49yFgYUNlE8MSu7HX8WWMqHzyRA+opzUvHvThMnxHLaKqaqGd9YjynMzpUb2CUMdqbBV 4y6yVmM4uuuTi9GbPXihbepRX115kjr578PCzfiGpOJVHF5B/ujwTuWXRGJHyNGoJ2AtMT8uMQu WnVigHq7DUj1K/w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Replace "tegra_emc" with "tegra124_emc" in all functions to: 1. Avoid name clashing with other Tegra EMC drivers which makes it easier to jump to function definitions, 2. Decode the calltraces a bit easier, 3. Unify with other Tegra MC and EMC drivers, which use the SoC model prefixes. No functional impact. Signed-off-by: Krzysztof Kozlowski --- drivers/memory/tegra/tegra30-emc.c | 90 +++++++++++++++++++---------------= ---- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegr= a30-emc.c index cca386af423e9647266878ce6cd1bcec09c8eba4..914116d8ec16d0d52180c7fadd1= 843adc139ceaf 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -413,7 +413,7 @@ static int emc_seq_update_timing(struct tegra_emc *emc) return 0; } =20 -static irqreturn_t tegra_emc_isr(int irq, void *data) +static irqreturn_t tegra30_emc_isr(int irq, void *data) { struct tegra_emc *emc =3D data; u32 intmask =3D EMC_REFRESH_OVERFLOW_INT; @@ -1228,7 +1228,7 @@ static long emc_round_rate(unsigned long rate, return timing->rate; } =20 -static void tegra_emc_rate_requests_init(struct tegra_emc *emc) +static void tegra30_emc_rate_requests_init(struct tegra_emc *emc) { unsigned int i; =20 @@ -1330,7 +1330,7 @@ static int emc_set_max_rate(struct tegra_emc *emc, un= signed long rate, * valid range. */ =20 -static bool tegra_emc_validate_rate(struct tegra_emc *emc, unsigned long r= ate) +static bool tegra30_emc_validate_rate(struct tegra_emc *emc, unsigned long= rate) { unsigned int i; =20 @@ -1341,7 +1341,7 @@ static bool tegra_emc_validate_rate(struct tegra_emc = *emc, unsigned long rate) return false; } =20 -static int tegra_emc_debug_available_rates_show(struct seq_file *s, void *= data) +static int tegra30_emc_debug_available_rates_show(struct seq_file *s, void= *data) { struct tegra_emc *emc =3D s->private; const char *prefix =3D ""; @@ -1356,9 +1356,9 @@ static int tegra_emc_debug_available_rates_show(struc= t seq_file *s, void *data) =20 return 0; } -DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates); +DEFINE_SHOW_ATTRIBUTE(tegra30_emc_debug_available_rates); =20 -static int tegra_emc_debug_min_rate_get(void *data, u64 *rate) +static int tegra30_emc_debug_min_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1367,12 +1367,12 @@ static int tegra_emc_debug_min_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_min_rate_set(void *data, u64 rate) +static int tegra30_emc_debug_min_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra30_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_min_rate(emc, rate, EMC_RATE_DEBUG); @@ -1384,11 +1384,11 @@ static int tegra_emc_debug_min_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra30_emc_debug_min_rate_fops, + tegra30_emc_debug_min_rate_get, + tegra30_emc_debug_min_rate_set, "%llu\n"); =20 -static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) +static int tegra30_emc_debug_max_rate_get(void *data, u64 *rate) { struct tegra_emc *emc =3D data; =20 @@ -1397,12 +1397,12 @@ static int tegra_emc_debug_max_rate_get(void *data,= u64 *rate) return 0; } =20 -static int tegra_emc_debug_max_rate_set(void *data, u64 rate) +static int tegra30_emc_debug_max_rate_set(void *data, u64 rate) { struct tegra_emc *emc =3D data; int err; =20 - if (!tegra_emc_validate_rate(emc, rate)) + if (!tegra30_emc_validate_rate(emc, rate)) return -EINVAL; =20 err =3D emc_set_max_rate(emc, rate, EMC_RATE_DEBUG); @@ -1414,11 +1414,11 @@ static int tegra_emc_debug_max_rate_set(void *data,= u64 rate) return 0; } =20 -DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra30_emc_debug_max_rate_fops, + tegra30_emc_debug_max_rate_get, + tegra30_emc_debug_max_rate_set, "%llu\n"); =20 -static void tegra_emc_debugfs_init(struct tegra_emc *emc) +static void tegra30_emc_debugfs_init(struct tegra_emc *emc) { struct device *dev =3D emc->dev; unsigned int i; @@ -1451,11 +1451,11 @@ static void tegra_emc_debugfs_init(struct tegra_emc= *emc) emc->debugfs.root =3D debugfs_create_dir("emc", NULL); =20 debugfs_create_file("available_rates", 0444, emc->debugfs.root, - emc, &tegra_emc_debug_available_rates_fops); + emc, &tegra30_emc_debug_available_rates_fops); debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); + emc, &tegra30_emc_debug_min_rate_fops); debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + emc, &tegra30_emc_debug_max_rate_fops); } =20 static inline struct tegra_emc * @@ -1518,7 +1518,7 @@ static int emc_icc_set(struct icc_node *src, struct i= cc_node *dst) return 0; } =20 -static int tegra_emc_interconnect_init(struct tegra_emc *emc) +static int tegra30_emc_interconnect_init(struct tegra_emc *emc) { const struct tegra_mc_soc *soc =3D emc->mc->soc; struct icc_node *node; @@ -1567,25 +1567,25 @@ static int tegra_emc_interconnect_init(struct tegra= _emc *emc) return dev_err_probe(emc->dev, err, "failed to initialize ICC\n"); } =20 -static void devm_tegra_emc_unset_callback(void *data) +static void devm_tegra30_emc_unset_callback(void *data) { tegra20_clk_set_emc_round_callback(NULL, NULL); } =20 -static void devm_tegra_emc_unreg_clk_notifier(void *data) +static void devm_tegra30_emc_unreg_clk_notifier(void *data) { struct tegra_emc *emc =3D data; =20 clk_notifier_unregister(emc->clk, &emc->clk_nb); } =20 -static int tegra_emc_init_clk(struct tegra_emc *emc) +static int tegra30_emc_init_clk(struct tegra_emc *emc) { int err; =20 tegra20_clk_set_emc_round_callback(emc_round_rate, emc); =20 - err =3D devm_add_action_or_reset(emc->dev, devm_tegra_emc_unset_callback, + err =3D devm_add_action_or_reset(emc->dev, devm_tegra30_emc_unset_callbac= k, NULL); if (err) return err; @@ -1600,14 +1600,14 @@ static int tegra_emc_init_clk(struct tegra_emc *emc) return dev_err_probe(emc->dev, err, "failed to register clk notifier\n"); =20 err =3D devm_add_action_or_reset(emc->dev, - devm_tegra_emc_unreg_clk_notifier, emc); + devm_tegra30_emc_unreg_clk_notifier, emc); if (err) return err; =20 return 0; } =20 -static int tegra_emc_probe(struct platform_device *pdev) +static int tegra30_emc_probe(struct platform_device *pdev) { struct tegra_core_opp_params opp_params =3D {}; struct device_node *np; @@ -1648,12 +1648,12 @@ static int tegra_emc_probe(struct platform_device *= pdev) =20 emc->irq =3D err; =20 - err =3D devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, + err =3D devm_request_irq(&pdev->dev, emc->irq, tegra30_emc_isr, 0, dev_name(&pdev->dev), emc); if (err) return dev_err_probe(&pdev->dev, err, "failed to request irq\n"); =20 - err =3D tegra_emc_init_clk(emc); + err =3D tegra30_emc_init_clk(emc); if (err) return err; =20 @@ -1664,9 +1664,9 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return err; =20 platform_set_drvdata(pdev, emc); - tegra_emc_rate_requests_init(emc); - tegra_emc_debugfs_init(emc); - tegra_emc_interconnect_init(emc); + tegra30_emc_rate_requests_init(emc); + tegra30_emc_debugfs_init(emc); + tegra30_emc_interconnect_init(emc); =20 /* * Don't allow the kernel module to be unloaded. Unloading adds some @@ -1678,7 +1678,7 @@ static int tegra_emc_probe(struct platform_device *pd= ev) return 0; } =20 -static int tegra_emc_suspend(struct device *dev) +static int tegra30_emc_suspend(struct device *dev) { struct tegra_emc *emc =3D dev_get_drvdata(dev); int err; @@ -1699,7 +1699,7 @@ static int tegra_emc_suspend(struct device *dev) return 0; } =20 -static int tegra_emc_resume(struct device *dev) +static int tegra30_emc_resume(struct device *dev) { struct tegra_emc *emc =3D dev_get_drvdata(dev); =20 @@ -1711,28 +1711,28 @@ static int tegra_emc_resume(struct device *dev) return 0; } =20 -static const struct dev_pm_ops tegra_emc_pm_ops =3D { - .suspend =3D tegra_emc_suspend, - .resume =3D tegra_emc_resume, +static const struct dev_pm_ops tegra30_emc_pm_ops =3D { + .suspend =3D tegra30_emc_suspend, + .resume =3D tegra30_emc_resume, }; =20 -static const struct of_device_id tegra_emc_of_match[] =3D { +static const struct of_device_id tegra30_emc_of_match[] =3D { { .compatible =3D "nvidia,tegra30-emc", }, {}, }; -MODULE_DEVICE_TABLE(of, tegra_emc_of_match); +MODULE_DEVICE_TABLE(of, tegra30_emc_of_match); =20 -static struct platform_driver tegra_emc_driver =3D { - .probe =3D tegra_emc_probe, +static struct platform_driver tegra30_emc_driver =3D { + .probe =3D tegra30_emc_probe, .driver =3D { .name =3D "tegra30-emc", - .of_match_table =3D tegra_emc_of_match, - .pm =3D &tegra_emc_pm_ops, + .of_match_table =3D tegra30_emc_of_match, + .pm =3D &tegra30_emc_pm_ops, .suppress_bind_attrs =3D true, .sync_state =3D icc_sync_state, }, }; -module_platform_driver(tegra_emc_driver); +module_platform_driver(tegra30_emc_driver); =20 MODULE_AUTHOR("Dmitry Osipenko "); MODULE_DESCRIPTION("NVIDIA Tegra30 EMC driver"); --=20 2.48.1