From nobody Thu Oct 2 21:45:17 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302F61B85FD for ; Wed, 10 Sep 2025 13:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757509424; cv=none; b=R6smOW2OJ6h74zxwPadvtJ+8THHpRZjkz/sGX4viV8lRfGxIOUZfCtqpBl528vb1u0OYRDrySTYaJ0IS5i2IGIYaMZUKtQ35GzktIX+LYxcO+0biWEiO/vkFPBOT84maVAox66045Y0uqQwQ1s+uTz9mDcZSpNlYVMSBgkPKILs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757509424; c=relaxed/simple; bh=UXhJw5qdqqlSnkCfF7xwIE+zNV5//HXyiaD7wKDHFPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qBds1Kfgs5iFilRYJFfG9oXjd8ecMBfhg7jZd53jhL0XQ2a40yM5Ag7RYJ3qfXPbmeHYQ89UilIMRirr61sknPJGRH9iikbv3tmgqtsLZJg7Hc2X8v/QKMkMx8r7O3BHl48Zj8uKfvkb2q0/1ay4XoHozzMFxgQ8GjkTovEEBts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uwKU2-0005of-7F; Wed, 10 Sep 2025 15:03:34 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uwKU1-000auH-0t; Wed, 10 Sep 2025 15:03:33 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1uwKU1-00000000poj-0snf; Wed, 10 Sep 2025 15:03:33 +0200 From: Stefan Kerkmann Date: Wed, 10 Sep 2025 15:03:32 +0200 Subject: [PATCH] wifi: mwifiex: fix endianness handling in mwifiex_send_rgpower_table Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-for-next-v1-1-3ee311706231@pengutronix.de> X-B4-Tracking: v=1; b=H4sIACN3wWgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDS0MD3bT8It281IoSXQMDi9QUi1SLRHOTVCWg8oKi1LTMCrBR0bG1tQA /w7uOWgAAAA== X-Change-ID: 20250910-for-next-008ed8e8a74e To: Brian Norris , Francesco Dolcini , Johannes Berg , Dan Carpenter Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Kerkmann X-Mailer: b4 0.14.2 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: s.kerkmann@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The length of the host command is a u16 stored in little endian byte order, which needs byte order conversion to work correctly on big endian systems. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-wireless/aLqZI4FfOI4iJZtf@stanley.mou= ntain Fixes: 7b6f16a25806 ("wifi: mwifiex: add rgpower table loading support") Signed-off-by: Stefan Kerkmann Reviewed-by: Francesco Dolcini --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/w= ireless/marvell/mwifiex/sta_cmd.c index 91d5098081e8b97420322484a229654c026e4618..dcca71158fc682902c0bd3376da= 32e81f8f6561f 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c @@ -1537,7 +1537,7 @@ int mwifiex_send_rgpower_table(struct mwifiex_private= *priv, const u8 *data, } =20 if (*pos =3D=3D '}' && start_raw) { - memcpy(&hostcmd->len, &hostcmd->cmd[2], sizeof(u16)); + hostcmd->len =3D get_unaligned_le16(&hostcmd->cmd[2]); ret =3D mwifiex_send_cmd(priv, 0, 0, 0, hostcmd, false); if (ret) { mwifiex_dbg(adapter, ERROR, --- base-commit: e3ac93e9d916ebae0711a42f524429dad89c4887 change-id: 20250910-for-next-008ed8e8a74e Best regards, --=20 Stefan Kerkmann