From nobody Thu Oct 2 21:50:58 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013006.outbound.protection.outlook.com [40.107.162.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C0730FC0C; Wed, 10 Sep 2025 09:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497506; cv=fail; b=EveWNwPYVWntdD6VVRoorzMDLC8zrV07M33TpGtKApWoYb2xsTOBDAVMz9w8XWhXNseBbEiGezXsuQbPQcXYs376AAg7mDivMOA0VA5KNM9zxYU/tcXF+7R8a4fq7G39Xfx5UmTwQMMgXlz7HJXXn1gTfOD+Z/0U30ZukGWUlBc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497506; c=relaxed/simple; bh=8+lOF+7tZfB1bAPFP8Tw4p+TpFb+iaN20f0vA2nVKSE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jRqWRq2lDEXT+6sIT7W1h5ELDDjVIG/1/377PzXcH6L5/pStcmhAfNAStp+rml4W1AgfBdE6f1h+iHjc6gePILJcIrIryDQaKXDe/WNoidqFKsRuIZCcEJk9NsDU045MR7uo09ZYEOh/pCGXX/N6Q5rK/lb3m/2zfll4AVnYmXE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=DkuYSFHV; arc=fail smtp.client-ip=40.107.162.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="DkuYSFHV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ECqFt363FCb49ySBmYTfIheyl7Rz0XbtJKqQWccxHNCmyn/DJC7jfO1x44mzfxTw2ToTRB4CMSRrUDc7UqA327w1feFLGZ+fWV3R1JeUmKQSIiin2isRU00FgqT5xZ9vyE96qkoHUawkvALItgzNXZoRLz7uowl0zyKMwCAWvR5Z24+tbyRcqDBJWvm96xYf9frv9mAdiZINlf52ivePnAPGD4i0N2Cf7JqbJhHUYDU2HhZSvGVVy0+vwcKG3yDgnXP/yaoA1d9pC5y7+FBf5Dj/o0P0pqBVmGlWuFmY/Avn97G07ueUTeckWQE0VANgSiH6NfOIbnqucRISoi0Pfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaIVmkqeYhA85YqRpqirjMhjI7ZBMVF8Hi7UPalITHQ=; b=qAMYz1B68kFclXt464fbJx27ntetZC9yWTH1PNeKcf7AAY9LCw5I9xjY06PJ39YfT/BXJj+ZAUohjm0Fd5zB8Pdah2+pxq1MpR5WaJKx3EgzuNz1e22KtYvpX2Xitw5+1Hlsnzfj5s99/JpE8w17+4eI7ENvpxkjYAHCMWJcFy5mYVLJW+4owzhGhcsKQVCpIQ9dIiDJ7QJxV1bD15oGut5BhQnlqLKzb5cfEbPvWwzVfmI0jKjqKJPo81aCHxi0QUtmH89NuHmvAGtDdXFuIo326nyAe8Nu/upIsHVTpTIIxzTAshqRN+sPz/i5PaP8WzqCsD8p2ldVv7RF+Xz2JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OaIVmkqeYhA85YqRpqirjMhjI7ZBMVF8Hi7UPalITHQ=; b=DkuYSFHVTouxXIAkVzRobLEy8Ka/NdeqFqeFKnPdqat22b1l+R0WI6BvLFCjfoc18HnozLbyUBy87i0mrG9UvBYNvcBi6NRMFIPknLIEf9oRgcZGmLm7x0gYTw7rh3x7CkeKnBNc/3bRJzM942m3adh2QB2HgROg4uwgucSGQivYkIqqosS5U2JFVUI3DHQlqA9QwzjsBTr4ULdEIBkRFQQuWtW2riJfRsrTc8Wn6kAK/hbCHwEcyLbgNBD/Er21Fb6DwKjGe2ePPHNHJpNXiKXoZNpa5lUsIJeZ/MV6iYZgoVi2qVpLSn1NS7uCAD31ZDwD9NNylOtfGw5EM61H7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by GV2PR04MB11834.eurprd04.prod.outlook.com (2603:10a6:150:2d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14; Wed, 10 Sep 2025 09:45:01 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Wed, 10 Sep 2025 09:45:01 +0000 From: Guoniu Zhou Date: Wed, 10 Sep 2025 17:44:38 +0800 Subject: [PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property ti,gpio-data Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-ds90ub953-v1-1-a7813ffbdf11@nxp.com> References: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> In-Reply-To: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757497507; l=1137; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=8+lOF+7tZfB1bAPFP8Tw4p+TpFb+iaN20f0vA2nVKSE=; b=hIV6/mWR7lMhDTj0KCP3y6IGM/Ji/g1nqPD53JSHFRqeSztgcKwz+X7umZ0+H3IR7YcJMEac3 E9EeLslJwAuDl5Uf1v1QFEbjMwsux2i/daurHjsVpmZJ209yQCGxOhf X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: MAXPR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::30) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|GV2PR04MB11834:EE_ X-MS-Office365-Filtering-Correlation-Id: 27c3a69e-ae1e-4a7f-043f-08ddf04eb654 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|19092799006|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R2VrVC9JSld0cnYwZXl3L2dQdTdybTQwWFBUV1RIZDFZcU9jdng0TlRYYWI3?= =?utf-8?B?U3BHUVVmQjJKU1JlRlRmY3AwUE9MZ0NvTHpRVDhrRmpWMEV2YWRqTkNQR2hv?= =?utf-8?B?OW9VY2YzWXdZWEE5bDJJQkJvNTJQc2FCMlRHTXVBK0hwSTV3dkd4ZkNGdEJT?= =?utf-8?B?U2I2R1BDREgyYmwyenEybmw3WUlYZHhOa0lwckI1Qmp2VkRrWGtWTHpVemk1?= =?utf-8?B?citVY2duMkE3S2lUeUh4WGMybkhnYWw5di85K3RubERGV3pieDdnWkZrZld5?= =?utf-8?B?aE1mRWRYMVRvdFBmZzhnUTUrSEhqUDl3bGl3ZytSaFJNdlp0RmtsaW02Sm8v?= =?utf-8?B?QmlRcUc0YXYwL05IRit2T01YQ0k2Nk81bTR0YWR6RHMyTTVBQitCclRmOG5I?= =?utf-8?B?akwyNlhDVld5eHlFOGE0Rkl3QUNTVk9SbWIxZWVxaWFEZnNFYnZMVFcyeWov?= =?utf-8?B?THIvME9heERSZEYrd0pBOStUblhjRDJSYTc0QndHUFhtRzVZNHNqN054eGNu?= =?utf-8?B?dS96RDR2UGUyMWxjMFlIWGdMRzIrOHJqT0JvNXR1WGNoQ25DdE9yOTZOamll?= =?utf-8?B?alUyeEU2L1hWZDFwcFNrWEFyK3JLQ09ia2RQZ3E3M3BDUmFKYTk3aUhsQTRn?= =?utf-8?B?WEJmOGJidC9IVmp4RGxJS005TEpORytvUGNFOVRqM3JPamhJS1c5QnNQRjZ5?= =?utf-8?B?K1R6OUZmS3RIdzZxV3ozcW9jbXZqTktqRVRQQjd6QXVUNmp5YnUwR2tDeFBs?= =?utf-8?B?bE1QMWtzOTFZYVFVa2pWOHRMYS9PNlVLZHpoWkRnbDl4MXJtNm9hUEFtNXFq?= =?utf-8?B?Nm5hUzdDSWl1MWp1Zjh0blhzNFpyR3F2OW1aZTR4K3VJR1d3bGhRVURCOUVS?= =?utf-8?B?RGZ3OUlrRFRpVUZuUHloSERzTEp0T0V6RWtaOGtRUFpyYUpJbmRYQlVUdmlJ?= =?utf-8?B?T3g3UjZRZWw0dGlMMlE4bUwvamtjRnZKNnF1ZUtYVW9QMFJhVUxJN3VxU1A3?= =?utf-8?B?ejl6bk4rSll0dFRONms2UTJWQnZiSEdtcEFpSURST1FDci84NmlUQXZwUk8r?= =?utf-8?B?VTd0eXF6bmIvODhoUWU5aGdveGp0bzdqc216TlhFaUZhaDdRRFdSSGhtUVFW?= =?utf-8?B?dWpwa0QvRFpqdHBYOWRRblh2b0N4WEpHaDQvM1daRUxnZ0xkSDU3Y3Ywcmho?= =?utf-8?B?SGJEOTE1blVVZTZRL1pqMEpkdlVRZlIwTWticUxGRGlhL0grY29GVittOXEv?= =?utf-8?B?SlBuVTVUZUJFOXBtZW1NMXlLNUZHOVBuNms3TGIwSGpxUEJVclZNSmdDdlVj?= =?utf-8?B?eDB5WlJRSnU5OGdtL3lkSnpjTWU3NHdHZ2hGZXBlRWpzS0VxeTA1TkZFYk5P?= =?utf-8?B?YlN3RmkxbndjL1BEL0ozZmFITnNUSEVSUW5pS1RzQ0IzTWw3YVlEOXgzRFN0?= =?utf-8?B?Vk8zdzdwK0F1R1d0V1NwdUplRFZUL05PRFRTMDREUkI0N05ZenY1Q1BNT3lR?= =?utf-8?B?b3JDL3EzR25CVFJWVDh6YWl1aXAwRXlFdUdvZnNheTg2ekVoSVMzRDBiOFFM?= =?utf-8?B?MWcycjhUWklIQ3A3ekdhRmk2MHUwaEVnN1ZrZmllcEtsKzlQL3NXQ0I5dUtL?= =?utf-8?B?Zk9xU1I1djFQRUhNNnF2TDBJMkVQQjVMNVV6NEpJZTlJLzd5UnFXSTZKT200?= =?utf-8?B?YytMaGV0d2FkSFB6Ym54Qjd0RzVKV0VCSDVSYVlZelR4TGladlV0djVjQi9M?= =?utf-8?B?TjFJT2NNZlY4c0MwcFoxbEN0aVNjekYyOWozQU9XTDY3OEQ3cDNCVGEyZWtk?= =?utf-8?B?TWdSbldiTzlyVjMyTnBibTUrSHR0YkphMFpPYjhhRzlkdXNLN2lrN2ZzVnov?= =?utf-8?B?M2dObm5rSmZDbnNBWVBqVndYWTJKYk41dkJaRE81MWJwVGJKWERycmxSd2l3?= =?utf-8?B?a3dyL25aTHNWak5laWh3Z3NMTm9zeXY1TGJSMitEZ2duckpINzEzeTB0Zjk5?= =?utf-8?Q?7ubuwXbHEwy1o3VclKQgBn/tYvgD+g=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(19092799006)(366016)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVRrTmplRWNjMGxuNG1mODVtdnBDdWlxeVNoM1grdjd0YWRobElMLzhtRS9k?= =?utf-8?B?aGxXNHJreU5RRzk4dUQrTHEvUElQdUV0NFFCbStFSklqMVVobkhyTEJacjVr?= =?utf-8?B?NTBTRW1KU0NsNXV5RkhObzZEQ0llVjVRa1k4MlZGcXZ1bGJSam56ZnYxNmJE?= =?utf-8?B?VzcwazZLNUZrZi9WOU42ZlNtTm8yK0NNa2N5aGIzaldJRE1WbFQxSTViVHI2?= =?utf-8?B?YmIzc2l6cG15Q2tUYytXSjFpcDNjU1kzSjBYUHBWTTJGNlAzOXFvMy9zZmd6?= =?utf-8?B?NEI5R3lYTmo5WkxiRVdMN204K1lHRTRxWjBpeXFHT0tJdTh0MlpoMHV6U2Zo?= =?utf-8?B?a0sxcGhRM2psSllXcDUwcTRkeE1QRVloZmlDZ0pIWVlHbG9XcWxuck1zOHdI?= =?utf-8?B?cFhwdnBQdWFqQ3YwTW9PV3d6TWFWZ1hxNkJZTjhuOWFkNzBCcU40cEVENm42?= =?utf-8?B?dUt6dVZwU2ZtdUpUM0VMR2JzZU4weDdXOXpHckFDdW1kM0g2UitHb3RvTjBF?= =?utf-8?B?SXczWUh1NUtXR0NBaHFHRmw5RmJmdGxKai9Zelk1MW54bjNka0VFNHhKdE16?= =?utf-8?B?cUpYc04zbWR2V0NBb1g4NENrRzRxaHlRTXU2Q3hDWTBIK0dFR3FTVHZxK3pi?= =?utf-8?B?Tk0zTHRVMDkyS3NVY1grMkVjV0ZSdjhsK294dC9IMnh2NThCSFVrZ1NCSVpK?= =?utf-8?B?a3hXRjZJRFFPamRWa2Q5MzkxSEtiT2dJNGZSeE5zSnFhR0cvbmw5cllKOUVU?= =?utf-8?B?eVVENkxXVWVIaHNyL1J6U3RiV3NYZ0hKVTA2cXB3V21Ta2tkOUlyNDQrRC9E?= =?utf-8?B?RzU3NC9vUnQ2TnVzeG41Z291M21BZFg2T0lNOHZUNlBBRENYOTJWYVFyWmpw?= =?utf-8?B?MTIvenNiRkdHbUo2ekx3UHgvRjhURHZnL2pTcFFwcTFXaFZkc012aGhKVmR4?= =?utf-8?B?VVBNWGlYdmw5MU5SOUI3MXNGc1E1cmJmeVpaYUxxKzdyY3lVaVMrMEo2U1BH?= =?utf-8?B?ZEtlOHBWMENmVDI3RThkNkNFMDIxSU1qUkFQM0ZuNDFjT0VyQ3puRUprcUk1?= =?utf-8?B?NnFwWUc0eEZ4b1lSNGpxNm1LOU04ais5YzdRaUZpRTJXVTFSRjcyazI5Nml2?= =?utf-8?B?TDVvcCtNWFFqbDA1YWZtclRYWllrMFd2Y1pkZTlDTFJLdEJabGNaZThZNnRL?= =?utf-8?B?OHJVZktRV21tQk9NVHA3bFNwald1aUV6Tm5mWUp5c2FPVWpWdnBuNWhpRVBl?= =?utf-8?B?S25Ma3QwRG5UcTJkUy9vdFZ4YnJFb1dEMEpFd3VMTHU5aDk0QzhmK3AzSkVy?= =?utf-8?B?M3NnTHhKaWR4MHlNcmFaaEpWV2pzN0VmRVN5bzRkZTVuQ2NNTlpDS0cwWm9z?= =?utf-8?B?TFZ2a3NqbnQ0clg3bG9GcTBRSkw0bXFmK0hkWXkyY3BJL2lJZFRSSGRWNmlr?= =?utf-8?B?Q1dja1M1bHA0RXNjTGhGL1YzNkRFcWJTMm8xd2lUVUtMbWxPTTNQWHA2K3RL?= =?utf-8?B?MUJsSGIwendORlRNazN4YXpLVVh3eUZ1Yk12NEhkRVZpV1NWa3pMYk5SQkVw?= =?utf-8?B?c2hyRVEvVENrbjU5aFdha2tPeDg5TXlZRGNNUjVITXEya1VGVXFxakViK05u?= =?utf-8?B?Wi9QcHcxK0FlTE4xYzBaMmRSbDE1RmhYZGRFNCt0dnlZZFluRDBidTdxcElT?= =?utf-8?B?RG8wc3JGOTVDWDZIM05zNHhoSFZjZTdBbDQ3UjhweDlDRjU2R29mVklwL3R5?= =?utf-8?B?akIxenNJMTVoMHJDZkErSUV6cGU3M1FXVG1tZHJ0OWkyMFJjNkFaa0dLWGZN?= =?utf-8?B?bFkzdFJrNHdoMWM1aXRhYjRIdldlc1dINWVvSFV1aEV6SlZLU1pHQVcyL3pu?= =?utf-8?B?dHNDcnlia0RGSG85TGxBMEZ1N3JzbHpVVWpYNFVsWmdzdlBTU1IzTU5xUjhy?= =?utf-8?B?d3F4RDJ6c1d5K2RsM2g5aFpjSVYyL0htZEoydGNvL2lzOElnNVZxY2ZHZERs?= =?utf-8?B?eE96c2g1cUowWndDc0V2eXI1MVUrZkdoa2xSS3BTZTRsazBiejNzTHgzemFG?= =?utf-8?B?LzRaMW1iMXVsSHVRQVJ6UTBQb0JGMDFmU2ZPbXhnUTkwNzduajhFam1sSEMx?= =?utf-8?Q?1c3DSn0OGvLIyCTBdUVk8Dc/H?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27c3a69e-ae1e-4a7f-043f-08ddf04eb654 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 09:45:01.5632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aNjL7mUqFLTMglo5pUtUfbgoy2SImeiMfMREMojE+TYdPHRam0D83v0yCaPPpZWSuuThtbEM+TZ49UVpBe9KBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR04MB11834 Add new property ti,gpio-data to let user select ds90ub953 gpio output remote data coming from the compatible deserializer. Signed-off-by: Guoniu Zhou --- Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 10 +++++++= +++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml = b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..7c3144677f11004468ed3a3fba7= 4e6eee2d259d2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml @@ -26,6 +26,16 @@ properties: =20 gpio-controller: true =20 + ti,gpio-data: + $ref: /schemas/types.yaml#/definitions/uint8 + default: 0 + minimum: 0 + maximum: 15 + description: | + Program each gpio pin to output remote data coming from compatible + deserializer using the LOCAL_GPIO_DATA[7:4] register. This property + has to be a '/bits/ 8' value. + clocks: maxItems: 1 description: --=20 2.34.1 From nobody Thu Oct 2 21:50:58 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013038.outbound.protection.outlook.com [40.107.162.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE89E315D59; Wed, 10 Sep 2025 09:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497512; cv=fail; b=YvjR4UAlD7WynxL6JUnuKF/oYVnheKJOdo2Q4Lan+peRf9adunRWDj3FLNeVIOc3H8mVfStyUEZN9uFVcAhfIft7/1R4jSdB+m2YfLwZbu46CMsHUhKdZDlHl3dFtAk5o514G+3i5lNUDcOoA5fjugun1f+9CT0t8+2C/i0wJ0o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497512; c=relaxed/simple; bh=LMwFj16qLhVFfCFtF5tVtg7ic5IAufF8pUqPvF3Rlms=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=V8X/9eS4IY5P77zMZH7oRa6kKHQnMgcmNyFFVG6AYWD2NcrLXayjgs/CDdDu9A9gBNFM5f6Y90L7MRjgdYINXUxrDeWKsgSwme5ojEGU4cSGql1zaeWSIexFacfHSwcPHPF2+04erZO6rLTeYUyjXA4WB/jir4iRKojoLpUIuNE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=HJVBx8iE; arc=fail smtp.client-ip=40.107.162.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="HJVBx8iE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ln/u1wZ+r93NqAdyu4D5I8exeEG5CBnnHL1MWHCWYieC+ZWsSZz6daFbl10guDT7pX4Su32SV4HoRpH4EamC9XVrKe7aqvn6B5D/jal5QZjkEFOz7I2rTO6qSLdJr95PVvGCdTZ5iWlhh6zC4KBvy5DTewWUl0AiPj6E8x3nS4JVBACJe1fo3lLMr461n/4L6nxKi6ve0hxLeNqWZPoQXhSLOceaMLnlQ9LCDlLdvHVZOoe6oi9hRMdeuIBfcdRuGnP+tjrBRqokfNtIabq1nbxSnV/D+GyCEbUhTfjeNTwXl+G7bSG4bdyd7mdBar7/X85Qqfkzx2LSknFS2IYuWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F5Y07ZQfrP++r1ZlKQmxgbFbQxK1mbIwtUSYfiHzWSE=; b=PjR8ktcjIpVdBSnv8GaCiVuc9MnZOjaU6feU26ci4+2XmOBtTAe68T7miOxCRlPBEMK/bIGM873i2gEJe/HXWAq+BW0ziFDRdV9BSunfWSv/Hg8UtJD45iZkP4fpfhPkTUSo/qz7uW4Fb+bC+hhINrFJpYVSaEEMRrUSRufkCGoWUh7PwzfHaC7ly6avF2Mxn/ep7kYeL0RBm2tlGwHWVyNB50tIHNDZLzok6SddNlA8/YOAd3+8Qy60Y7NpgdA7/V3xdS00Cx0D6cgGz+sJdazb9gySvzD9s7vunB8SGrIb2odO8wRoMrvEIzno+5cSz4vtQi4NPQN1PGuz4EC/1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F5Y07ZQfrP++r1ZlKQmxgbFbQxK1mbIwtUSYfiHzWSE=; b=HJVBx8iEm92cjFoh4eJWpCNbBdVz/41zQzFcp161xpKtK3Zy2N5Ymwxb794O+Ce+xqZxnEOmPEQBAjJQ9LYBG6L3dYXhi52CkMb6Zn7Kxq84Zyap7E+tV4xz91GhM9EDfKQSfb9M1fqKSPPChcVkpz3JTfPMUARbFt0j8Npb2o2lXq31IJb2WuXkYQ5+p/1TQuKkPZ90Zel1KnI/4gmlcEmaZnUDYP/ISRMQbs2Bt8D2MCGdxI1GrAONHH5GldG2rDusAFo2AlBuwhjvkEAS9weR21iMgBSa15qcuAjWuBvX7hXWyktk/EzFqQ2La3sXQfh0cI+x6O7L7DF1MaOrMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by GV2PR04MB11834.eurprd04.prod.outlook.com (2603:10a6:150:2d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14; Wed, 10 Sep 2025 09:45:05 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Wed, 10 Sep 2025 09:45:05 +0000 From: Guoniu Zhou Date: Wed, 10 Sep 2025 17:44:39 +0800 Subject: [PATCH 2/4] media: i2c: ds90ub953: Add back channel GPIO support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-ds90ub953-v1-2-a7813ffbdf11@nxp.com> References: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> In-Reply-To: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757497507; l=2771; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=LMwFj16qLhVFfCFtF5tVtg7ic5IAufF8pUqPvF3Rlms=; b=dpPfHNwluZBrb9Nc+xxVim+kYMA/grORERN9cs1iqWjgdYBuTDlrl1UiTCH8DfIrJd+gyqL/C ka5CJZEEyqgD9H1ESYZ01TwVdnzW+Dgv7kO2j23JA6s5Z8+RKn3Z3XO X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: MAXPR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::30) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|GV2PR04MB11834:EE_ X-MS-Office365-Filtering-Correlation-Id: 517de0c3-ccf1-48bd-2d92-08ddf04eb8e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|19092799006|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NHlRT0lzK05XVnpSdFl2WXlRQ2VsQThRN3VQd2tBSGYzUDBKOUVWSTNYcnRy?= =?utf-8?B?U29oL2ZCSDJwNFVKWFZITjhYanVwWk1ncVc0SjR1MFF5YnJJSFRWaGQ3ZHNW?= =?utf-8?B?a1ladFFleEIzY0pacFE3YUNYN0RQRG8xRVZQSHZtQTdjaW95bUh4YlMwVEJl?= =?utf-8?B?MTBQNkIwVWVyZTcwV1BNWnQ5VGdGRWp2UzRQWkQ0UWZ2U1c2R3VTR0doZm9N?= =?utf-8?B?NEwyYkxEZmo5YVZEeGJTN3FqMEtNQXByaHMxbUZCRUJKVjBySURycXFMbXpp?= =?utf-8?B?SjcrOTdQeld1bnlKSDlMalJQMmhXVXNQZmFHaHk3Z2liczcvaEYveEZJOFI3?= =?utf-8?B?bVA5YXdZSlNNcngyM1hpaE1hUFJKczUyY2l1VUtpcmEwNXlBdCtTd09zN0pQ?= =?utf-8?B?TGRDRTJWckRGaXpJVFRrcllvamt0Z2NxMkxWRUVFUVozTWhTbTg4c200VkNa?= =?utf-8?B?NmhrUjNqV2xvYVQvTHhsbFlGTzlzT2ZLazJtUURwRE1kWDlWelcrOEJpdHA3?= =?utf-8?B?ZlRxSjRmam4yTmpaWE1ZRjVLWFdnYVh0Q2c2Y3N3UzlaOERxdXZyMnR5Z1ZM?= =?utf-8?B?R21nRDJTRE90UDhuajVYZVhpaHRrTDloblpuTmZ4bEcxUVhBMU0waVNSejZC?= =?utf-8?B?eGg3Z0gzK2dJTW5rVW90MnY3bU41aS9FbGtWUjdqOEFYUHA2K1BiUXh2bTZT?= =?utf-8?B?NG5ETWlYbFdkY0EzWW8yNGJzbTNtV3RWSXA5RURZZTloa1JxTElrK1JoVW9j?= =?utf-8?B?UG9ZalI1eW5BWTNLSXQ0UXdVb1FZdFFpMC9tVVliSGVtbithOGRubFR6RytN?= =?utf-8?B?U1Vhd3hUSG1BcTlsSW9DVVRBM1c1TVl5eTYvd1kwRzlHb05JMnJNWTRJLzN6?= =?utf-8?B?NHNZK2lSM2FaOWNtTDQvcWNYOUVsbGM2d25SS3oxWFI3RStRS1lGMWNjS1N5?= =?utf-8?B?M3ByRUpyYzVwajYxejBOdDhYWjlPVlV6QXlxTW1mZDZIelEwMUgyZW5oT2k1?= =?utf-8?B?RTF6Mm1wejJTNnk3ZnQ2d2YrOW9QYncyVWFEU20vWGR5M2NqMHhhOUtMNXhs?= =?utf-8?B?Ym85UkMvOHFmQlVoaDRJcXlBbDR4T2RydW5FU2JIN1VJQmc5b1ZHQWtxbi9K?= =?utf-8?B?VU83VlZTWUFuYjBtVklrdXloR1ViWC9tZDNsT3ZuYW53elphcGxFemk4UWs1?= =?utf-8?B?WDMzbDh3aWdqaVg3Vm9lOSsyVDZPb1doTjg5Q3BvM1ZzTVF1RVlYeUJ3d0Rr?= =?utf-8?B?WER2bHIzK3Z6Sit6Q2hWcnRFM2ZEektrTnBTbHhNS2sxbTRKWU5QaExmcTlw?= =?utf-8?B?RlJycUxGS2VuWmxBR0JtRUxqUG9OMDBNVTc1YjB5b0Y0V0MwN0RWWENYZmkz?= =?utf-8?B?RWk0cThSR2RpWmVPR1MvM05RZWNPUDNFeUZ5ZEtrMERnb2xsVG9yRFRUUjln?= =?utf-8?B?RHhZMHdOYjU0OUJsZVBWcTFEaEVIT2Z1RzNkbys0TkJFNExqc3dGWnpGTWNE?= =?utf-8?B?dm93Wkp1RjV4V01BVkQ4SFM3UzV4dVRGN1ZUYXZEam95c3RnbEhzZzlEcTFs?= =?utf-8?B?b0M1OS91dTlFUWk2YXpQUVVZeXFUei9TckppR3FvOEFoSEo0dnp4a2JSNWww?= =?utf-8?B?UUd4UVE0cEhFbnk1WU9Zd2pCSjRoMGFxTVZab0lpano2bTg0WS9BblZRQVZ4?= =?utf-8?B?N1RVeFp2bHpwM3lxVFhXWmdHUFF5MWdJeXkxSno4b2lqc1dRR3ZrV0FQVk5X?= =?utf-8?B?YmF5RUZ3Q2w5TnZGdUxNRk1zQ0M4Mkpoank3V3oyV2hQSks5QTdFWldFQ1FJ?= =?utf-8?B?c2ZWTlVkZDFtRDZHZzI0ZHRUcktmUFdhUTZMcWRETkh4b2N1d285cWVuL2FM?= =?utf-8?B?R3dTZXVWZmxsQ0U1N0JxanMrZGJqTjYxREJ3bnpkVnFCSlZVVUgvRDlQM3JB?= =?utf-8?B?RjdXTnpuWU9wWGdId3ZWcGd6REhVZ2VmQXl5OEtMU1J6b0M4ejVZQWEwTE1a?= =?utf-8?Q?Lrrm64zW9XMhqVEHWRR3jGDgoTVFdI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(19092799006)(366016)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDlGb2d0ZlhBMENEZDA0OHh1VHZSVzlPd1N0UjNNNGVBa1pta2YxZjBOSmhR?= =?utf-8?B?NEYxOUt1U0ppUmZzV29tL09oc283TTM0RytFb3FiS1ZhQlY0ZkFUZWhwdEtB?= =?utf-8?B?UHFRbmlWVG45MG9pOWs5Wnp2WHJMMW9NeVVSblJFaUxaS3llaFdsajE1V3h1?= =?utf-8?B?SjAyV29qNDlqS2JMcDQyRVc4L1A1elppSmZGZHJacmdXU1BWWU9jSWFkWUd1?= =?utf-8?B?ZDBtZ3RCMHFNVTRWYVArWnZQTGJxYzFFanAvakliUzZMQjZHOFN2RS9BcmNz?= =?utf-8?B?WWNVT0JoTmpkL3NDazkwWTFaUzl3T1pZZ0xueGQ4eTJCM1FzK2dLTlNlZmFT?= =?utf-8?B?SndLa3dEaGRBNmYycVd2SS9NelRPVEdueSt0UEE0Kys4K3NiQVk0NkhxREI1?= =?utf-8?B?RXRZbTRjV1JpZ3BYcmhON0k3MXlOOXNqTnVKOEptc29nZEhmaWJuUmM1RE1j?= =?utf-8?B?RGp0TEhIQ1o4VkxqRFE3RzFYaEhlTWpDMnoyZ1pIM1hMbG0yWlNRR2xvUjl0?= =?utf-8?B?eExFei9EdnVuMnhpaHc3NVhYaDVMdFBzS21mK0pURzZDSUVwZkk1RG5GcTBw?= =?utf-8?B?YnVuYnV5RTMvWjdNcjd4Z044b0dra2xHa0xnSTVjQzUrREVIK3h5bEUvNkE1?= =?utf-8?B?UEhobWNFZUZYRlhpT2dXcDJLNkd1YUtyTGhGZGVORGc0Z2lva2pyWkNOazVH?= =?utf-8?B?NHpmU3BrTU9kcUYveDZ6Y0RDNSt5QXRZZHFIWVpYWDR3SXBzaFNqVVNNVC8z?= =?utf-8?B?NlVBMUpTamJQNDdXZENyQVU5TllpNkxUWGgzdzJCZ0tRclEyTmpaMFUxWDdS?= =?utf-8?B?SnhOMjZKR2RhQm4zV0NXbllyRFVMZmNFT3NZQzg2bHhjWnVyYlJKV2c2eDA3?= =?utf-8?B?Ykk3TkJ6a0l0Z0taZ2RtMkIvRExXZFdGa1o2V2JldVVNano3SVZvRUNZUE1I?= =?utf-8?B?N25ZOGszN2l1cHVDYWpsamRrY2ZkcFNiYWxLREV0ZFpIN21wOHg4aWN4U1hq?= =?utf-8?B?bjRPeEVFS0VzOVZVbHE1WmtDOE1xWnE4bFpMR2dqQk5obURlL2FCd3JKNlNs?= =?utf-8?B?K2ZSZkpGYVpsUGo5aC9RQ3NLWHVaMXFYankrV1c2dXQ3N3dOSU42SW5GbkJo?= =?utf-8?B?QnpoWGVCYjNobzQ4aHphOWxURnJ0Lzk0RnJ5Yk0zVXlRVXd5M2NFcG1WNXIz?= =?utf-8?B?NkpuNFd5cHNRZHJUcHFnMG5nMWM2ZXQxaXpOUFVDLzFaL0JGcnQ0R3R6Sk85?= =?utf-8?B?ME1NVEdBWXpPeDhybzROTExTR0w5dEhpNXhmUFFia1BTYndJS09EdXh0bjdO?= =?utf-8?B?dnZvcTljOWZuRTcvY2lsSGZacktoY3NWb1VqN2EzWmNQRmdpZ1VWUllrcldk?= =?utf-8?B?aFQ1R3J5T01ZcE1nWndjNkc0MXNGQ054Q2RWaTNKMlhPcDlaMHlYSElIVlBi?= =?utf-8?B?SCthRHdqSFJ3V0F1VWdYOXhzc0FuTy9sZktJcCs4NkRLTVV2NjhrZnZ3aGsr?= =?utf-8?B?ei9LMUxwMjhCdm9QL09VZG43Qkx6UnhKcEFJclZGZVo4MXNFa3pka2JqZCti?= =?utf-8?B?UjFNcGJhbnVTMXQyRlI3azNlV2x6akZIeHcyalRyYkMzSXZqaXIrY0ZuQnFX?= =?utf-8?B?K0VxSFhXQm1QSTBsMkk2d2NGem9WYWpwWUhZbHRVUVFNeEQxOE5GMHZRbnVx?= =?utf-8?B?T3FvVFFnUnlFam9yZkFvL3dWOG9kT0Jwamh4R0JySWVoSVlBMGUzZnRRTFdG?= =?utf-8?B?MitWT2UwZ3YzR0RZUWhIcWhsbi9hT2xIQnBXUHVRMlQ0dngrWWZKVEVUVUxx?= =?utf-8?B?NlRvVW9sSHlzM1FtdTdEU01Vc2I0WUlJNkgzR1duZk5FMzRiM1F2Rkw3YTdk?= =?utf-8?B?eW80T09EK1gzOU1ISGljYm1GUDJIY2dUaFdrWXBiS2l3QVR0d0I3QVA1VHRo?= =?utf-8?B?bXI1M09hZUdtb3pKSjZoQm1PeGNDL0NzT0JWaTVLOG9vY29EblRRaFlxTzdQ?= =?utf-8?B?RXlXb0Z4WVZFWWtJVnRVNSsxYSs4cWZpM1FCV2ZuRFV2MHBiZXpUeWFJa09n?= =?utf-8?B?NDNQSmJYV3JoZlpoTmtjYXpPMDVGTEVRRXNSL1lNazR1VnBzNUh0elJDOHEy?= =?utf-8?Q?3UcT571XQ3jX+NgigrRir8xYv?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 517de0c3-ccf1-48bd-2d92-08ddf04eb8e0 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 09:45:05.8437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wun6QrQCgqXd83JEm9v6Rtptq0Ds4LBJIi9aovB6MY8IRHONv1NopzvHeOSvkU+Wuv4v21//cFpxl/ksF2IvGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR04MB11834 The ds90ub953 supports GPIO0 through GPIO3. When enabled as an output, each GPIO pin can be programed to output remote data coming from the compatible deserializer using the register LOCAL_GPIO_DATA[7:4] field. Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index e3fc9d66970a762d284955f14db48d7105b4b8c4..98d6b6fab810a8f65a01a604923= 8cbf700eb8cd6 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -86,6 +86,7 @@ struct ub953_data { struct mutex reg_lock; =20 u8 current_indirect_target; + u8 gpio_rmten; =20 struct clk_hw clkout_clk_hw; =20 @@ -288,13 +289,17 @@ static int ub953_gpio_direction_out(struct gpio_chip = *gc, unsigned int offset, int value) { struct ub953_data *priv =3D gpiochip_get_data(gc); + unsigned int val; int ret; =20 - ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), - value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : - 0); + val =3D priv->gpio_rmten & BIT(offset) + ? UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(offset) + : value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0; =20 + ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) | + UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(offset), + val); if (ret) return ret; =20 @@ -320,6 +325,12 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsign= ed int offset) static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (priv->gpio_rmten & BIT(offset)) { + dev_err(dev, "GPIO%u be programed to output remote data\n", offset); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), @@ -1133,6 +1144,17 @@ static int ub953_parse_dt(struct ub953_data *priv) struct fwnode_handle *ep_fwnode; unsigned char nlanes; int ret; + u8 val; + + /* + * Config ti,gpio-data to program GPIO pin to output remote data + * coming from the compatible deserializer, it's optional. + */ + ret =3D of_property_read_u8(dev->of_node, "ti,gpio-data", &val); + if (ret =3D=3D 0 && val > 15) + return dev_err_probe(dev, -EINVAL, "Out of range: %u\n", val); + + priv->gpio_rmten =3D ret ? 0 : val; =20 ep_fwnode =3D fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), UB953_PAD_SINK, 0, 0); --=20 2.34.1 From nobody Thu Oct 2 21:50:58 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013038.outbound.protection.outlook.com [40.107.162.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6152F3164C7; Wed, 10 Sep 2025 09:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497514; cv=fail; b=lZuNJz2Qrqi9jyzs1lL6MMggY2QhmBU6LJjfxzxeG7UZ+/3c8lDXIEhYtVYm2yK2SH8OiqJkN59NPXOj1sbEphI4fhZ466Wu7GWckLwzFOLJBj1AAKjZj+ZxSUmlzcQEApzRzAOmr+B061YgmbxQb+IIau/PnPyyx1IDTXrMMPQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497514; c=relaxed/simple; bh=gtCk1hvJL9/iqKtEBIenOrwmKvlDEjsKgF0zn07vSk8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=MphTTY0hQ3HAng1FrDttDe/7Vqpfngyxigs04LR3uirKr67NvSq3zcchYBBltVsBT3+VGdZqvGNEt8FU5IEWOXtwUn0mW2eXQmhbhGrKhfKfM1oIMLTvulU1dqmvsJeq8w0QFXollsbAQMUV/htvFyOl0rL0HiEzHFtGZOwJocI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BZ/+InqD; arc=fail smtp.client-ip=40.107.162.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BZ/+InqD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wdmlMFaJ03b9Wui8fDfnYUv/odOfVWUga05FJd7fQBK6OVAhW15w0xPM7RGn0E37FMtV4i4gV8rPdFGhElBguA8xAX45xKcrtbHqF+l3JXRGBh0RCbSEOkVXs/6igsvh0zv/4ucJBLrULNPzQpDUcbLx5rIdNMyr7WF3aHwORVKYDBC5RdBURcW7wydQsZ8hDY1R+uO6ipJTSn/P0pucqpcdvfLqqcdYPDX6Kh4XBg9jPGo9JzjDGlfzA15pzyrHIAXyaSDkbzRGyufqHIsEa1wFH/E0DGvG3SLTKgAvWPsrT5/cGafub4uoLwKUr++kKdmSVC10YqaSoHVxeqsE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tkV0kVVrI1RoKJeasUbegnFznuNEZiMyo9d+O++2eZI=; b=kUEftzXuuRxTXJ/U9OC+tZAW97LxJeoijr0Hu4SeAzAgahFsI7R4Eg+mdVlJfToI12Z+Y9N4fwr/XhzuyogykM+IPwnHDK4euOeUCT2lOguojYppLWoekyKjZmT6n73x6fk8Ph9v6IpfuHrPDw6QxGGZKt5k3kQXEnxf/kSewNkw93xKL3AUhR8w7wMhd3m5TvriE3CeAe3mixIGqVo/1OcxglN736jGAuHYXdjNuQ8eoBEkb51aSo0fXeQA//A8fW22Nznfq2YdDe6shYindDKvI34P1gUMzZ0XAmTEPQ2V+sj8Ywq7t8fk6k1ll/niMF+9kEU57r4DGwIc9mOytg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tkV0kVVrI1RoKJeasUbegnFznuNEZiMyo9d+O++2eZI=; b=BZ/+InqDa8GQSEMQ35faUtkwS9zRjzmm9eZYWirQ3uY0D3K4tDE7Fvg0RXUwZPDe9pqA6Z4iFXp2XaKHzhvJL27tq77xwByHlToFpqY9eS8oadnD0q3A+EAaMZu+2ra/w2JgY75Iiiv3ps9OM4IGei9IDM7Pj0awURQbf6EwQwVuPWmEIf2YGV6kLdTJuHG5UJ0yS1efnugTVAwx449BQiNo3PXvZWZOPIJWcd8sdKQnT8W/UtDBQ50jdn/nyd6SzHcrxBj5S6zwah4IoztTsDDWmKqBXX87c6izJ9nKTYET3KbHX9YHJmYpmutm/RvbmlWnNI3vZ5L1H22OuA6Zow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by GV2PR04MB11834.eurprd04.prod.outlook.com (2603:10a6:150:2d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14; Wed, 10 Sep 2025 09:45:10 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Wed, 10 Sep 2025 09:45:10 +0000 From: Guoniu Zhou Date: Wed, 10 Sep 2025 17:44:40 +0800 Subject: [PATCH 3/4] media: i2c: ds90ub953: use devm_mutex_init() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-ds90ub953-v1-3-a7813ffbdf11@nxp.com> References: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> In-Reply-To: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757497507; l=2417; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=gtCk1hvJL9/iqKtEBIenOrwmKvlDEjsKgF0zn07vSk8=; b=nRXdT7Qon5oYd0Z+dT6pNFoLj+P7o1RORlROvBBZpB+rhhHv6QzJitgJTDmnFV1v3NtchpyG0 BL9De6mBeuUAYcLNyaBej19ZaPUJbebYmP765GTmELrm6oSvn87X/5g X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: MAXPR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::30) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|GV2PR04MB11834:EE_ X-MS-Office365-Filtering-Correlation-Id: 749fb203-52ab-47ed-2f38-08ddf04ebb6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|19092799006|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cVhGcE93WXRsb0JSdDYwc3l1MDVJeUZHYzc5bXk1d1laU09xWk84K2V2eGNr?= =?utf-8?B?Y1dvK3hXckNzRVUzd0VsanJOYnZ5YTJPNHpxeGFkTnlVd2R4UXFNV2dlZ0pL?= =?utf-8?B?Smd2MTYzSWE5MjJHTlhlMUJhMnl6R05SQitqRi8vM2JnNWU2Nmg1bkQrbHpZ?= =?utf-8?B?bzJ6WHVrd0MyZy9CZUk4RS8wUDM0MXZ1ODIyVWVFd3ZzbEZtbFdHNk16S3A1?= =?utf-8?B?NGFSb0pZVmJlRmxpK1VVN253S2R6R0phM2dQTmJpOTYrc3p5enY4RWRLbDRu?= =?utf-8?B?T0lBa3NjRVVIcHp6Q0loZWhyKytOVTl5YldPR2J2VkNHWGF2SG1aYjEvU3R2?= =?utf-8?B?Wno1ajhnR1poWmxteWZWTkNpUmNtaUhYVmVKcko5b2RRL043b0IwUXArd21M?= =?utf-8?B?ZUF1b0gvcnRqM0FJUEpzOVFtZUxrTUVtNFJOeWtJRWpaRE1aQlQvb215ZVJq?= =?utf-8?B?UFNSd2p6M05ldHpoNGZJYWxXdC8wM3VhSWYvL0NSRGtyaG1aUHgzdTM4amEy?= =?utf-8?B?Q3JoRFh3MitGaE4zVWo1SW9VRE85aWNsdlFheHFjT1hZUkJVREZuaFg5OXZw?= =?utf-8?B?ZVBVWi9nQzM5blhFVlZIaThQZmFGeHdpMkNzRVhKb1FlMjE1MUlHYnNWaE5p?= =?utf-8?B?cEhURWRTajBGVGNpbjNlMkxXZzdlcy9acU9QL3I2d29LZURaTzNmQ2ZVdVRK?= =?utf-8?B?dkRiTG5NS0dKeUU4Vnp5eFBkclVReTd6Zkc1a1l4QUJ0Wmx4MHVOVmMxMG1w?= =?utf-8?B?UUIwWG9WRit5Q01oeHdhMTZBVGNkdS9XNDliaWpVUnRBblAzSStSQUhHek12?= =?utf-8?B?U1hyaTh2Mld5Q1d4OW1OV1ZlMWhsTUlsY3dhSUQ5emxGNSsraWxOdnhUMEdT?= =?utf-8?B?enE5dnJsdy95TmdDbWVnZWVlejcrNUV4a1NOSTFYSUdraDJLelhMTDdocEJB?= =?utf-8?B?MHplTHdJcklGMTIrUnk3SHl5Q3dCNzA1cUR6K284a2VFWk9qK3lxZkgzdjRx?= =?utf-8?B?YzNZWGxrcFBzY2g2N3dLWGpMd2gwUllEdjhyLy83dVBKbkhMdVlwNVJKcmNH?= =?utf-8?B?dERlNTUwMkIxSGp0WmRMc1dwY29mdHovdk82Q3NLNitFME9oaXV3WWZyZ1Zy?= =?utf-8?B?S2l0eVdZZWwySGRiNm5TNXFUYWlsN0hTWEIwZ0VMcFRyUENZQkVEdnUzb2hF?= =?utf-8?B?Zjg1NEI0SGVYckpWc244VlpBRDhueTRvTnhZMW0vdDY0V2EwY3dSZ05qSGZP?= =?utf-8?B?MXBZcmk5MGQ0aHZqak92TFc0QnFpVVl6eENRSW9kOFRDcTFWbHBCb2dUNitO?= =?utf-8?B?RktPNDBZWHNYUjRXR0ZFSnJ4YUZHNjBzTmw5ZzlLNWV5RE9jRENjQVJPejBt?= =?utf-8?B?cXYzemVvWm92STErUGhBQWtpQko3ZEJZSmZZQXMvK3EzRTlBVE1WaVpqN1VJ?= =?utf-8?B?eHk2VXluZlFjVWFmNXB2ZGprU3JBMEJaR1VpTkxyNGNPbEhYSUxNOHpzWkFo?= =?utf-8?B?MlpzK25xOU12a05EcmJESWFucDE3OUVEdTVvM0FkRGprcDFrNExZcmFRZGVJ?= =?utf-8?B?ZzFTS0tJZ29vQTBBT212dkEvMjVXUSt4QTlOQldLSGd4NnpJemRJWjZ6ekZK?= =?utf-8?B?dkNiVjFFTm4vUjhLSm1mY3JvNUlUUkJmWVZJKzQ4ODRscEh3cG1mU2IyaFc2?= =?utf-8?B?TlNBQzAvZk1MWDE0dm1HRks0MExBZGJBV0lxem5RbjhnNzVENzJEa0VFQThE?= =?utf-8?B?Y1dWYVlBLzNPcGNHWHdtRzRzY1dja3J6Y0lnMDAraDczblBZcmhUSXowZC9B?= =?utf-8?B?aWtzTW1meGFvWEorWENyTVB2VERnbzFjSFREMUxLZWw1OHo5V3ZmM1JVL2th?= =?utf-8?B?K3NqNThSSEJFYWk0SllTQjBONHpmdFZOZ2cwKzJSZ1pqR0pJOHMyaHVLOVZQ?= =?utf-8?B?UGNEa1lDcjFFNlZxMUVhRW96V2g1azZNR0p1ZFBKdVBTVGR2MUpMdnJSMHNI?= =?utf-8?Q?JSdt1NzRRMsRul71qCuI4RVhnGM7ek=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(19092799006)(366016)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU4zYzZEcWF3RkNPMzJmdm9MTDhpZko5cWVzZ3djUnVHUDFwSE5mUE5FTWl0?= =?utf-8?B?aW41endPQ3hhdjdHK3NycFJVNzdQeUNCVFRGbW9KbmVlcHZLL3M2K2NXZTRO?= =?utf-8?B?N21LNzFPa3BNT0dySzFBWGtndjYrN1pWNjlHa0dwNDFnNXp6NDV0UW15STJZ?= =?utf-8?B?QVJxbENkNHNBd3RldUxlWlZ1Q0RYei8rTXRNRC8xU3QrWndRUXp2QVJQcUpJ?= =?utf-8?B?V3IrclFXMVF5ZHYzb0RXZTJNc01Sdmg1ZkNUaGlLMktsbXVMemJDUmZhUVps?= =?utf-8?B?eGZSaWRlTnMvZEVRcXZleU8wcUtWd0ViR1BPMCtuQ29lYXlHV0NlTk5MR1Fn?= =?utf-8?B?c3lsdEY2eHEzWStjSkJ4R1YySzBVc2xXKzFxdUtpekduNGZKdmlRMllZN3M5?= =?utf-8?B?UWxMdVp5czBDSVRjQTZMZ3Vwd01kVkhJbXVBYU94dEJzbnBDQUVqWGFtdCtM?= =?utf-8?B?bGhWV05xZ2FKRDhORkFnVThOOXJ4ZHdUMkxNcmx1ZEFDeStIWWtBMWxZRFk0?= =?utf-8?B?Wk5YRk5panBkeXlydFREcElGSysva1A3Nkd0YW5maEVFWEgrYXlQZUllY2Jy?= =?utf-8?B?SmQ5M1hrU0tyUDdsL2IvakoweVR3WVhKVXJuazFUYjJFdEQ1dEF6U0FhSld2?= =?utf-8?B?K1ZFd1RoVWg2dWk2MStVTEpucjZDbWkxdzhhTlhXREVULzQvU0ZtOW9jUThP?= =?utf-8?B?SFlEdUlOdVhyemdoOTkwNVRFWUxMamhxUU1obTdhSi9JR1NhUzljNytBNXJa?= =?utf-8?B?MkwyQ2R1Smk0NVNTbzJjT1VsOWN1ZFdFS0cxWFJLbkhZT05KcXMvRHg1dGts?= =?utf-8?B?ZDlyYkxGaGxNR3lrVzkreC9sdUx5ZnA3bXQ4ay9tTkxyeDRUUENHQ1lENjA0?= =?utf-8?B?MWVlVno1eDVkaGlSRW44VHhuZGNwWnExL1k4aVlGdjM0dFI0akQyWTlpM0lt?= =?utf-8?B?UjhqSVYxaUFiTGxySWVVRzA5UHFqYkhiTVlKYWM3SCsxYjR1N2g3VWFGNVpS?= =?utf-8?B?NWNTNWNHWFZyYmUybzMxcXpCVldCd01GN0V1SUo0cjRyUmphYS9FOFQxS2o5?= =?utf-8?B?UzljeUltakdPNG4xNlptZ1ViSTQzcEJGV3IyV3hLTUxUM0hIUmw2K0VYZGJp?= =?utf-8?B?WWVVUGdudEEvR0ZyeCtBR0xQRiszQVJTaWNhYmU5ZzV0Qnd6QkpZclowT1g5?= =?utf-8?B?Nk5HUGU4Z2VWWm45TUV3ZFFaQ1RRc21FYzUwQit4YkNwNDVuODIzWE01b2FE?= =?utf-8?B?cjVzeDdxYnN4aFFYMTIyTzJNQUdsb09hN3FwVjFDa2RObDNzVjV2aUFnaUZq?= =?utf-8?B?TVQ2OTAwNVpSSXk3ZUZmU2JEN2RDQWd4YWlSY0diL2RzcnBMb05kM1pGZVBK?= =?utf-8?B?bGNmQ2RXOGpCOCtnZFJET2g1ZkJsV2wvWEUxQVJaelRFZW5GZytnS0puVXky?= =?utf-8?B?VTM1dEJiY0FYTG9mejAzanVwWVlyWU5YNVUzM0hKRGNDYXVIQi85eXVDVFgr?= =?utf-8?B?T2pVM1pEM2w0TURXZ09qRW5BdFpZSDdBekwrVFBEQUU0blpFemJxWW1neFc4?= =?utf-8?B?cjNXU3VTQXhBUWprUXZWL2loVys5SGI1SW51dDZCZEVJYnNUbmE3NVZ5YThu?= =?utf-8?B?anhQbC9udm1PR2tNWHZFWkZ2UytjTFNUWVJBNU5ETGxjcndUcHpneVdSdkdq?= =?utf-8?B?cGpwakZFek5UZHVnQ3MxL3gvSEx2MDdFM2t4Rk1GZHRsZkx3aEdVQXhUUGtt?= =?utf-8?B?ZlNzVTdQdVZab29YdkNYbWdyL3RWQUpYenFDR2l6TlBKa1I4MGlYMGlBT0lq?= =?utf-8?B?d2lBQUVVdmNVc3NvcUlzWW5mV2cwN01wZkkvUFpMb1NFSmVCMDl1dzdWSlRT?= =?utf-8?B?cHNrelNCWmU3NlFXcFdWR21saW9lYVBGWVNBbTVOb09zNHU5ZXlZVkd0ckYw?= =?utf-8?B?YTZQMGViQ0pqTjBtNTlvKzMweUUvUTN3djJRWnM5Y2lKbEYyOXhaSkJKRVJQ?= =?utf-8?B?cjExb2NocWUxbWIrN0ZaUmNtOFIvVnc5NWVwVWNmbXFRVG5hWlJ0VmpRZWhm?= =?utf-8?B?cVdHZENBZkV4dXhmcHpmZGMyMmpRZzQ2MjB0cnQwT3g4dlMyU1h6bWZENmZa?= =?utf-8?Q?Mj8i++kX6tqcvkL7Orlitrnst?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 749fb203-52ab-47ed-2f38-08ddf04ebb6c X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 09:45:10.0478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q25G9ROdefWo+tjZkceS2pYepDGYE9bhPY3+oMamAOhzuTSxfjgMFZdhso0iTwwNZFyt9OzWV26pS5MW6srT0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR04MB11834 Use devm_mutex_init() to simplify the code. No functional change. Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 98d6b6fab810a8f65a01a6049238cbf700eb8cd6..6f09322553640384b1f43af0dbd= f4f54b4ba004a 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -1339,7 +1339,9 @@ static int ub953_probe(struct i2c_client *client) if (!priv->plat_data) return dev_err_probe(dev, -ENODEV, "Platform data missing\n"); =20 - mutex_init(&priv->reg_lock); + ret =3D devm_mutex_init(dev, &priv->reg_lock); + if (ret) + return ret; =20 /* * Initialize to invalid values so that the first reg writes will @@ -1350,30 +1352,26 @@ static int ub953_probe(struct i2c_client *client) priv->regmap =3D devm_regmap_init_i2c(client, &ub953_regmap_config); if (IS_ERR(priv->regmap)) { ret =3D PTR_ERR(priv->regmap); - dev_err_probe(dev, ret, "Failed to init regmap\n"); - goto err_mutex_destroy; + return dev_err_probe(dev, ret, "Failed to init regmap\n"); } =20 priv->clkin =3D devm_clk_get_optional(dev, "clkin"); if (IS_ERR(priv->clkin)) { ret =3D PTR_ERR(priv->clkin); - dev_err_probe(dev, ret, "failed to parse 'clkin'\n"); - goto err_mutex_destroy; + return dev_err_probe(dev, ret, "failed to parse 'clkin'\n"); } =20 ret =3D ub953_parse_dt(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_hw_init(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_gpiochip_probe(priv); - if (ret) { - dev_err_probe(dev, ret, "Failed to init gpiochip\n"); - goto err_mutex_destroy; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to init gpiochip\n"); =20 ret =3D ub953_register_clkout(priv); if (ret) { @@ -1397,8 +1395,6 @@ static int ub953_probe(struct i2c_client *client) ub953_subdev_uninit(priv); err_gpiochip_remove: ub953_gpiochip_remove(priv); -err_mutex_destroy: - mutex_destroy(&priv->reg_lock); =20 return ret; } @@ -1413,7 +1409,6 @@ static void ub953_remove(struct i2c_client *client) ub953_subdev_uninit(priv); =20 ub953_gpiochip_remove(priv); - mutex_destroy(&priv->reg_lock); } =20 static const struct ub953_hw_data ds90ub953_hw =3D { --=20 2.34.1 From nobody Thu Oct 2 21:50:58 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011025.outbound.protection.outlook.com [40.107.130.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1393164C7; Wed, 10 Sep 2025 09:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497522; cv=fail; b=SVadNo39gtc+IGdZvBSV49a/OCbd/SE0a36b3mTcavFyolnu67lrb5dFSNq83J1GgR0uBLI6QAcRAHFPPNrhndHPxqTWIGK7hqWVP1roze/8myXOVoZuBccr3plcKLnSN0NDqa82ufqhsVy39fOhgVNcS5k5MPA9dlavw1zrWvo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757497522; c=relaxed/simple; bh=D5Y3COLAcHNi91Pq8SBHE7qJCFI41xY6ArEWXBXp0Pk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lkTfoWO6Vq/JfPFG3VeQS09aKwh0QI+Z8r8BHXIsB5U5o4tHG0PTTtz7BjqoJndAJTjrZi+0+AZYy2RfHMm+wYmEbjcd1+T6v/wIh/+7otugRAMAToMB9Yjd6/Nq0RpAiCAGvynw3kho5olvfDwVoL7T+AZacDDeC8WGs2iJBXw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=bnVJLMIB; arc=fail smtp.client-ip=40.107.130.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="bnVJLMIB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dxb+24QXWswcZa2bN9E3OUFATFYhwQHk6cvGd9hLsk4UENH9+I9yBWX3rgyq0XCagvnPNjqdbz9xD9rU4uxD3l9CaQVtn7rOgLiS36HxJRdwU8FfRdpShNRzyu/B7Hz6fnTJ1zXxZTOsASYvSS7GNpV81KbxQzyHucJkfpp+KNK/5Y484yJm50WDCP/aCCQ0l0KACe3R+QvFhmtGe25y9aVEgGVCXlMcxmeMWaHsBavSCPRvmc0fW9jBb0fqYJlMtw6UwhMzW+XeqFZ1OmFXbGcfeGUgjYEds9NMNegV1jNBs+3osNWwHgEjuyAQljHfbCOwj1rajeLY90/27W4Mfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IgOMY82UeLTzfSXW9l4VfH51f5dnx3SVmKSBL8MsnRU=; b=YZk5qTpbWdgbsHz7XetefGjEuYh+iCLdAllpGDyzN/Wyq38g7lanSNvR+xaPoZ0QU04dw7bgG62MTrQYo4/0ZYR+7eEbjQkejoBo1aSA5BXvZQbVbfFw9jQbDvnftOxc7G4IwK3x6g7diBhJr67W2vy8GwSt6B5uu87xlGF4CQE6XL65XJYzk+PIvi4GHDOqC4CzHc6wmzWpyuUbsjXNFYZ74FlQ446bUrrqljOEJtBix5TeGcvpnjOsRILO97PehfjqHCfNahTuo8rdCD2Sp+2ET61buB64DUQG4a2436GzPWj4gqU0QV48fhJwunKpM90rYU4vb1Ru2mQC7a84RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IgOMY82UeLTzfSXW9l4VfH51f5dnx3SVmKSBL8MsnRU=; b=bnVJLMIBLCyfVM4foiNHfzM1e5jg1Fr+c2tjrrh4X4U33fesWIr5xvaQTzq0BS18QStbqi9OOWccus9urRw3uAH0KhlNz7wmye7uJBqxBnNypLs7RYnpL9nxBb0iQdqDt3x1cazdeYLt/1et1mFt9/VRZRdroG10DLX2pfEw4wY3PSR8jhz42yfOC92zp29ucbY0X9kSIiOAlLlMA75br04gi0V5Gnl47fQe8q5fj63Pba82Dgu1J8SVOCMqRoFwhEW8tDW7odxDzsDkZW0Eeoi/pL0gCmRGNTbNJsAct4jhTpqSFB9BrasR3wa3Ag7m3jsa5/AJqGbxw0D4OEXbMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by GV2PR04MB11834.eurprd04.prod.outlook.com (2603:10a6:150:2d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14; Wed, 10 Sep 2025 09:45:14 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9115.010; Wed, 10 Sep 2025 09:45:14 +0000 From: Guoniu Zhou Date: Wed, 10 Sep 2025 17:44:41 +0800 Subject: [PATCH 4/4] media: i2c: ds90ub953: use guard() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250910-ds90ub953-v1-4-a7813ffbdf11@nxp.com> References: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> In-Reply-To: <20250910-ds90ub953-v1-0-a7813ffbdf11@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757497507; l=3282; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=D5Y3COLAcHNi91Pq8SBHE7qJCFI41xY6ArEWXBXp0Pk=; b=eGhETE+clP48+otChnEq3TyKcMLfKNPtz4aY7uc4ECJbvnL8yB1txCsnsEjTGjFYv05dyCuJe DKkO8/CcpYjCe1L69t7H5on7HiS/QxsIbBCCsYh6VfVQqOloN1Tyf42 X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: MAXPR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::30) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|GV2PR04MB11834:EE_ X-MS-Office365-Filtering-Correlation-Id: d5ae55c1-d160-44c6-5b6d-08ddf04ebde8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|19092799006|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bkhaS0FkbXlNa2NuL2t6aTlZN2FLOXJTYksyQzVna3ZNWDVZYS85Y0FxaS9y?= =?utf-8?B?cXh2aVdzcFpXNTc0TjhrZ0NlZFIvUzNiRU1aV2dzMjFYNG5OdEhxbFdnMnV1?= =?utf-8?B?NmFaSE4xMHBuU3Z4RXh2YVh5YzJqTFNTcHo0TkNWZU9iTEUzTkNtZTFwRUll?= =?utf-8?B?THpJOThOdWZWUUUxbjFzVXRacG9sbUw0NEp6bXFOejV4Sjg4ckhmRktBN1VS?= =?utf-8?B?eHpvb3lYNjNyb2hGa0pSaFRqdkFaMTNqRXJUU0Zvc0lMOHFPTkltbkRXTzVH?= =?utf-8?B?SWRFU24yb21vaXhjMUswN0diZ3c3a0NWVXJYNUtEY2dvbXEwZ1ZsQ2krOWRR?= =?utf-8?B?eDd1QU11N05UN3JCcG91RndlUUpRMng1cHJ1M0lGY0FnQTFZODRxeGdJL2dC?= =?utf-8?B?NzZvWTJyYm91TkpERXBXNGRxemQ3Umd3aW80V3l1SDNaMUdoUFJpSEZwaVZz?= =?utf-8?B?Mk1GcjFTY1lSTzZqbTRpWUJuMW1SRjEybWIydDh5UCt2aWhWcGo1OUltS3Vv?= =?utf-8?B?anF0UlFtdzlJbjhYN3l3VHp5TUp6OGw5bnhwcVpNMmI3ZU4rdVZxRjhTVlk0?= =?utf-8?B?ZWNOdzdsSzI4cG92elFKOGQzbFhyTVk5ajExRkh2eForeW5XRmZ2ek1VdWpN?= =?utf-8?B?NUpGYWlNTW1LVUlha2lCVE5aTGlJT3ExMU9sTlBpelFtbS9tZ1JwL2EyRkVB?= =?utf-8?B?N01MdVY5T1ZkWXJEMkxORjY4a2NGQklTNk9RWnVBbjZGRjZEVE83MTFDUmdW?= =?utf-8?B?WHhPTjY0aktwSzdtTWJmWnJFbDZXR004OC9vM3N3K3JZMkRCQzJBcU9YYlFJ?= =?utf-8?B?WGcwZjBPQ1lqcGltS2JpMUZYckdPalY0Z25xQnFIYmErSnNIVU9KRzJoejVh?= =?utf-8?B?YVVYSFdScWNNUXZ2dlRoZ0JZZ1BvYVJnQlRyQ0twbUdpWStGeVJJNXgrblZj?= =?utf-8?B?blRvb2dJMmhkQ1RMSFVEZXJaNDluUGI1SzFmVWV1b3N6Y1BBUUF1MlU2Z1JP?= =?utf-8?B?S0MrUXAycElsWXBiM0lZeXFWOU5MMDNaQUl5aHNrZCt5eHNQWXc3eE8yODN1?= =?utf-8?B?aXU4UHhZbDBvQ0FFbm1JM2dXYmdhWWZVZzVJNVBKOGk0aHR3c0RSSVpmSm5T?= =?utf-8?B?MFRYUXI2ZFVhZzJweHNUNWNSRStrOTBpV0w5cW9veFpGdGV4RmYxN0VxMk9w?= =?utf-8?B?WVl5aktCYjRmUmNRYzc3UkZrU294ZGJHRjdiRTZsYUlVY1pPNDZTQjhJRXVY?= =?utf-8?B?REZyZldWRkR1MDRmQVN2K0txRXVwT1kvWlFkekUrcTFzRmJTOHc2eTJJS3cw?= =?utf-8?B?SUh5R2JLMmQxL3RCTXo2cTRYdVJTNmpDKzRWdXhKblFXM2syUkxRZTVLNkJs?= =?utf-8?B?ZG5WTjJLVHZYOGVqWVNnUWhMcU1kMlRpYUJKODFoWWxwNkYwTitRRXFXY3FR?= =?utf-8?B?czYwMG9ua1habktwa2ZiWkNzSk1TSmlNaEtUNGs5T09nTVFWYTBId0d6blR5?= =?utf-8?B?Mk1hOTNtN0QvcjM5WXpVSXFSdHVyS1ZrelZhMHBDWXE2cndVblNwN0dLME9I?= =?utf-8?B?bytSam42OGs2OWxXektRRGdzc1M0ckcrbTZXYlJoTXhlc1ZXLy8rSlZUcFIv?= =?utf-8?B?dU13MjhnZmh6akRDeE0wdzFLMTFXWHpaSlJjc3Q3bDIwUXlTU3RoY3FJa01S?= =?utf-8?B?N1RaME4yRkFWMTBZemhMZnNjTzlFZmFmdWFRcmNCWjlHTGhlVzg4MENvQWh1?= =?utf-8?B?QnlrOUFKOWdpVkVXZUcxam1PczNYalFxYzlaZTR3THdZUW5zSzlLbUNUcGVS?= =?utf-8?B?d2IzRFNoa2F0QUxWTzYzelNjM042VFhCNE14SmlJMnlhMXZXNjVSbFFrUy8y?= =?utf-8?B?c3gyMEFyVTRGbzRqQkFVZGI2dkQ1WDdQNU9hOFd3VXhabGZEdEIzWmZVQk8w?= =?utf-8?B?cnR1bGQ0Z3NsSmk3UDUxYXVwVGJYWkhOa2Ird1hhMk1DYk41ZDh1ZFI2cDVz?= =?utf-8?Q?QilGM4ZMhJh9EtVmH3DbOIhNHYgK9I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(19092799006)(366016)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ttbXpDVmxEa3JTSlFVMlpmN05GL0xIbE5admxjYWsrQm9QWkhVZWMrd2xt?= =?utf-8?B?YXVQdGtxL2h6Sml4SnkyYlNvenMrT3hwWkJlVnY0QlhJdTJXNUxQRXpabnJ6?= =?utf-8?B?Z1crQ2kwTk9Da3Z6dDBsaVY0RTQ4QktBbUJXV0pmWGZmSUtTV0VZV1NENFUr?= =?utf-8?B?bkRFbWZydVJZZWJhQUM2Ui9kOENnVzdkZEpWZHl0WVFsa1hGWG41aXJZTGF5?= =?utf-8?B?T0V0RkRMbGZIbk51TVN2ZHVPWVlrc1R2Q3NjRlNTY2pFOFd0c0FVUkJHMlRx?= =?utf-8?B?cTNrZUErdUVMa3JWYUJYOS9IeW1LZmRaM0RIYWpqZjluZXZ4N25NUHNjMGtG?= =?utf-8?B?Z01rK1AvcjBQNFhJakJMT3Zpa1hnK1pTQ3hsUGw1WjY5bFUxNkJjQXdsMy9L?= =?utf-8?B?SGdFS25oK212bEN6d2ErejBxWElPZnlXMDQzQzBnSjB6STdwSERqdEJ4aE1i?= =?utf-8?B?N0h6cmRZV2NmV0V5T0t2K28zYVlEWjUwTTZ1TVZmdGhlZTNyMGNGb3grWFN3?= =?utf-8?B?cXE2T2pZK1lzQ01OVDd6YmJkZm5zNmZqMUoxMmh2T1oxTUt6V3oreURxT2J3?= =?utf-8?B?eG9UcWJyNXQwWmtweURScU9lTnluSFA3R3NBbUZFTGE4QXNBUmdUenN2OTdR?= =?utf-8?B?djcyeGJqZUNtbHRTbE1YYWYxT3lHQVlHTUg1OGJaWkRmRE4veW45QndqMXFp?= =?utf-8?B?VHljanVpRytJNjZuM0tzeHpaUW52TzVQWE1TV1EveU1PUVpZTHpPRDFQSkZW?= =?utf-8?B?Z0Q2andoZkh2QjR3ZmhjSXRpUHVTeHRwb2gzemRuRXl4RThHQnhlL0Y4NFpQ?= =?utf-8?B?bWdtbS83Rm10RWdlT2IvMTFLTUlPYjV0c1RwMHFnejlKczR4anFlUy90WDUy?= =?utf-8?B?M3dWVnZqRDhZbmRkd1YyN2tzZmtHQVdUUVIySkpWOUN3QUV3YVlkRHJXVzV0?= =?utf-8?B?MUlROTZ0QmdPd0QzY1VCTEREbnB4Y2ttTlJtRXV0ekloTjJ2aWx1eGxpUWxj?= =?utf-8?B?NmR4SkFLUjBKMEl4b1NiQkRBUWRLVkh4cXZpZDNVeEpmaTd6SHBTNUNWZ2Fr?= =?utf-8?B?RmxVQmN5RExqR2wydk9oay82aStaVWhBbmF4NE96dGo3Q1kvZUgvV05NK1JE?= =?utf-8?B?SUNWQXdoSU1UKzZQZlowSE1rRDBhQkdNN3ZEc1FjcnFYSytxWldQTzFQMHVY?= =?utf-8?B?VVlsQmQ0bkRmczUyVktoaEowY0xFM2FIazhvUktVRmQxMnU4UzNDQWxUQ2dw?= =?utf-8?B?dkEzNmVxeElzWVdRcmlUSGsrSEMwY1RjNGltSXVaOGhqWGdvMXRMSDh3Mm1S?= =?utf-8?B?NVcyZGNMRWJQUFYrWDlteENaZG9obFIxTklrbWRQY3J5Qnc3SmlyeVlVT3Q2?= =?utf-8?B?M1puanpoakZZaGR2R3p4VU52R2ZSNXI4dkR6MFBmT1piVmxJTjZod3NHUjh5?= =?utf-8?B?djF2by85bHQ0amZUSVNFU3BSb2Nia0cwTUZTZmRNUUNqRUw0WlJyekhKS2o4?= =?utf-8?B?a2dkbFBHenBqMEp5ODZHVXU0blZpSjJTTWhvRTYwZjVxSS9qWER5Ri9vQjNH?= =?utf-8?B?Tm9ndHBpOFBPa2d6VXpTN3lHZEhxWmdKRFBOOElUMVJRMVFvTG5FUWtFSzBq?= =?utf-8?B?Y0dRUFBUL2xjaFErM3FxYUtEakJFR2g3VFJFK0F4US9SeVhwR1dBMnpJcnRx?= =?utf-8?B?eEExNFNHenQ5ckpjZ0I4UjdCbTM0QlBwdkN5WEN2aVRmZ29CRlppcGM0MEVy?= =?utf-8?B?dnpreVhaTWhzOC9CRjdxVzgzSmxXSmllNUZHQWdaamVIT0dLckRab0FkdkRo?= =?utf-8?B?ODNPVGd5d1pYMGpnM3lUTHNRSUZVdWlWZklPMnJ6N3FDMkc2T0RFNmw5clhl?= =?utf-8?B?cWxzR0xOK3Z6RmE0US9OQ0k5K2c2ckRjV3NvV1ZuQk10WXh3S1dLYzNNc1RL?= =?utf-8?B?N0g4UDZwOUFIVDRSZG1hcndiaDhsWDBINVBnbW93a2NHR2laMkRucEVCS0Zk?= =?utf-8?B?VEVIVmpNckNLV21DbWRZK0plSCtXTlhSMzdYY2VLNVZvdFZ6RmN0STluSm5L?= =?utf-8?B?SWpadnczV0U0OHhHNUFVaGNuMDhsMDBkeE83WEY2Mk9TOTR4SUpNNEhPNnlj?= =?utf-8?Q?raSQA/sodj73G7tdjBg1mumri?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5ae55c1-d160-44c6-5b6d-08ddf04ebde8 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 09:45:14.2663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIbNRzJ1Ipk4xKd9q7gN//2fm3snC6iTuPobZ5JoiSdIHEks+0HSmmuVzu5CSWvqMOkigHrT95Tt/W0veq4qlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR04MB11834 Use guard() to simplify mutex locking. No functional change. Signed-off-by: Guoniu Zhou Reviewed-by: Frank Li --- drivers/media/i2c/ds90ub953.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 6f09322553640384b1f43af0dbdf4f54b4ba004a..d7799531773ee32bf9f95eef306= 18cce9d479dd0 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -112,20 +112,18 @@ static int ub953_read(struct ub953_data *priv, u8 reg= , u8 *val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_read(priv->regmap, reg, &v); if (ret) { dev_err(&priv->client->dev, "Cannot read register 0x%02x: %d\n", reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -139,15 +137,13 @@ static int ub953_write(struct ub953_data *priv, u8 re= g, u8 val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_write(priv->regmap, reg, val); if (ret) dev_err(&priv->client->dev, "Cannot write register 0x%02x: %d\n", reg, ret); =20 - mutex_unlock(&priv->reg_lock); - if (ret && err) *err =3D ret; =20 @@ -184,18 +180,18 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_read(priv->regmap, UB953_REG_IND_ACC_DATA, &v); @@ -203,14 +199,12 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, dev_err(&priv->client->dev, "Write to IND_ACC_DATA failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -226,18 +220,18 @@ static int ub953_write_ind(struct ub953_data *priv, u= 8 block, u8 reg, u8 val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when writing %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_DATA, val); @@ -247,9 +241,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 = block, u8 reg, u8 val, block, reg, ret); } =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 --=20 2.34.1