From nobody Thu Oct 2 22:52:50 2025 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A9A255E27 for ; Tue, 9 Sep 2025 15:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757430749; cv=none; b=VHzv/lfOhRIXq3h+WkQ7RTAP2i1kVmFemxBlv2ReDIP3vwr7AioPaSXa8PqDJhSHdZuOKLsrmu2MxtVTiKPvQmlugMo322i7xGODbdnrN+zRQwbiPTShh6d5vitXC5xsNO3AI60LhtMPlgfwpoVFjxC27554rIJXK/5KW4U5vRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757430749; c=relaxed/simple; bh=z0pWl5tmXxe8Yr4RnIREU8SsYE2Ww+p+S8VgecNvLR0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cyEDHbIUeej7OUydotTMVvh6AIr+qykmZnVhLfzck5sABvn++WsoFtSO/0iv/BytZUQCnglSkZDCZIY6LaUFHhJBtzy6rFuWLkuc7q42/lsavLMixRNZkOwPxSSY797Vufg15dK0CPzUvPZEWKKg8Vdjq2PNISc1fBbh8ujFXN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SJVa9R/d; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SJVa9R/d" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1757430743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YTikDlX12kXL3j+5kwkltxNVJHuHuCGZc9SB1ihbGG4=; b=SJVa9R/d9JBXok4g28X5XyNlSwCYDy1Z9ugy6mZB8SX7QL4omrAASdlWcbBZOMqsE0+UPR /gejcTIxHMMnytu9jWBu7OHWYAw7+xtJkvtCgGPFwF5nti1t3+vx+OoWQ0GZ7Ws1QIHsoz 4MMqCMfouJ8X6IPvREtIcp01b0wGFc8= From: Thorsten Blum To: Felix Kuehling , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter Cc: Thorsten Blum , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdkfd: Replace kmalloc + copy_from_user with memdup_user Date: Tue, 9 Sep 2025 17:11:46 +0200 Message-ID: <20250909151146.760450-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace kmalloc() followed by copy_from_user() with memdup_user() to improve and simplify kfd_criu_restore_queue(). No functional changes intended. Signed-off-by: Thorsten Blum --- .../amd/amdkfd/kfd_process_queue_manager.c | 22 +++++-------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drive= rs/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c index 7fbb5c274ccc..70c17a12cadf 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c @@ -1004,13 +1004,9 @@ int kfd_criu_restore_queue(struct kfd_process *p, if (*priv_data_offset + sizeof(*q_data) > max_priv_data_size) return -EINVAL; =20 - q_data =3D kmalloc(sizeof(*q_data), GFP_KERNEL); - if (!q_data) - return -ENOMEM; - - ret =3D copy_from_user(q_data, user_priv_ptr + *priv_data_offset, sizeof(= *q_data)); - if (ret) { - ret =3D -EFAULT; + q_data =3D memdup_user(user_priv_ptr + *priv_data_offset, sizeof(*q_data)= ); + if (IS_ERR(q_data)) { + ret =3D PTR_ERR(q_data); goto exit; } =20 @@ -1022,15 +1018,9 @@ int kfd_criu_restore_queue(struct kfd_process *p, goto exit; } =20 - q_extra_data =3D kmalloc(q_extra_data_size, GFP_KERNEL); - if (!q_extra_data) { - ret =3D -ENOMEM; - goto exit; - } - - ret =3D copy_from_user(q_extra_data, user_priv_ptr + *priv_data_offset, q= _extra_data_size); - if (ret) { - ret =3D -EFAULT; + q_extra_data =3D memdup_user(user_priv_ptr + *priv_data_offset, q_extra_d= ata_size); + if (IS_ERR(q_extra_data)) { + ret =3D PTR_ERR(q_extra_data); goto exit; } =20 --=20 2.51.0