From nobody Wed Sep 10 01:59:49 2025 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A14255F31; Tue, 9 Sep 2025 11:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757417926; cv=none; b=VRCt6c/TXVMYzZRLxSeWx7OvHup0m3fTbzUt0qBJsmZ+eYAVr4bToqQTz21YRDzIc6nDEQwJWitL+LXpwaSsPjmFOKCE7ni04y2xWw0VGXlg1+5QzumMcsVyk10PPZnyratQaeMXoqV8p35o6jj8NgLBpjbIExfr0E1FZms8I5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757417926; c=relaxed/simple; bh=BL7y92URBYyKdU2Z35YuXLrdcUwIHPKCdzy5n31B7EE=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Aeke8SF5J6EXQdGyMNtnUq0fv/DNmnl/3yr44WS1AUrjBSO+whyKoq7bF8ALgc+687nIbkwH0JccYf+IMlyQpzfSYnagFqtMjsszX7gjW1twHbMYyjz3AAyN3PGJwId30a28hjwTsUllchooNnGQL4qgzeWUQUyL0nltFXC5k7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4cLhY76wxZzdckX; Tue, 9 Sep 2025 19:34:03 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 06E60140137; Tue, 9 Sep 2025 19:38:36 +0800 (CST) Received: from kwepemn200010.china.huawei.com (7.202.194.133) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 9 Sep 2025 19:38:35 +0800 Received: from huawei.com (10.44.142.84) by kwepemn200010.china.huawei.com (7.202.194.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 9 Sep 2025 19:38:35 +0800 From: Qi Xi To: , , , , , , , CC: Subject: [PATCH v3] once: fix race by moving DO_ONCE to separate section Date: Tue, 9 Sep 2025 19:29:10 +0800 Message-ID: <20250909112911.66023-1-xiqi2@huawei.com> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemn200010.china.huawei.com (7.202.194.133) Content-Type: text/plain; charset="utf-8" The commit c2c60ea37e5b ("once: use __section(".data.once")") moved DO_ONCE's ___done variable to .data.once section, which conflicts with DO_ONCE_LITE() that also uses the same section. This creates a race condition when clear_warn_once is used: Thread 1 (DO_ONCE) Thread 2 (DO_ONCE) __do_once_start read ___done (false) acquire once_lock execute func __do_once_done write ___done (true) __do_once_start release once_lock // Thread 3 clear_warn_once reset ___done read ___done (false) acquire once_lock execute func schedule once_work __do_once_done once_deferred: OK write ___done (true) static_branch_disable release once_lock schedule once_work once_deferred: BUG_ON(!static_key_enabled) DO_ONCE_LITE() in once_lite.h is used by WARN_ON_ONCE() and other warning macros. Keep its ___done flag in the .data..once section and allow resetting by clear_warn_once, as originally intended. In contrast, DO_ONCE() is used for functions like get_random_once() and relies on its ___done flag for internal synchronization. We should not reset DO_ONCE() by clear_warn_once. Fix it by isolating DO_ONCE's ___done into a separate .data..do_once sectio= n, shielding it from clear_warn_once. Fixes: c2c60ea37e5b ("once: use __section(".data.once")") Reported-by: Hulk Robot Signed-off-by: Qi Xi --- v3 -> v2: apply the same section change to DO_ONCE_SLEEPABLE(). v2 -> v1: add comments for DO_ONCE_LITE() and DO_ONCE(). --- include/asm-generic/vmlinux.lds.h | 1 + include/linux/once.h | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinu= x.lds.h index 883dbac79da9..94850b52e5cc 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -384,6 +384,7 @@ __start_once =3D .; \ *(.data..once) \ __end_once =3D .; \ + *(.data..do_once) \ STRUCT_ALIGN(); \ *(__tracepoints) \ /* implement dynamic printk debug */ \ diff --git a/include/linux/once.h b/include/linux/once.h index 30346fcdc799..449a0e34ad5a 100644 --- a/include/linux/once.h +++ b/include/linux/once.h @@ -46,7 +46,7 @@ void __do_once_sleepable_done(bool *done, struct static_k= ey_true *once_key, #define DO_ONCE(func, ...) \ ({ \ bool ___ret =3D false; \ - static bool __section(".data..once") ___done =3D false; \ + static bool __section(".data..do_once") ___done =3D false; \ static DEFINE_STATIC_KEY_TRUE(___once_key); \ if (static_branch_unlikely(&___once_key)) { \ unsigned long ___flags; \ @@ -64,7 +64,7 @@ void __do_once_sleepable_done(bool *done, struct static_k= ey_true *once_key, #define DO_ONCE_SLEEPABLE(func, ...) \ ({ \ bool ___ret =3D false; \ - static bool __section(".data..once") ___done =3D false; \ + static bool __section(".data..do_once") ___done =3D false; \ static DEFINE_STATIC_KEY_TRUE(___once_key); \ if (static_branch_unlikely(&___once_key)) { \ ___ret =3D __do_once_sleepable_start(&___done); \ --=20 2.33.0