From nobody Thu Oct 2 23:50:51 2025 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0536431CA69 for ; Tue, 9 Sep 2025 11:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416299; cv=none; b=TMDqY8KDSBgickLY4fcA6ILFxDcgD6uW4IXoNdlbRI/WBUDYaqb4CSDmhMmftoIPEoXK/V9qQ0+rb99z74g/xTDEXEAxcrJA0p9R4H447yhR+aBEQcAJ5FcgEdT8IDU6L9jmXdZgz7SllbpOaD3F1+TGIIXn//mIo+g4fsKFtrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416299; c=relaxed/simple; bh=xvvwoB7YyOGKeYMjn+/FWTHBkrkkqNKMwyxu5VcBFHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MC067aUNan1JjbyVlbj2xI6DwsJRTzmKNfAlwrNyXW4/lDslPy+ABDypdat7PXtNstBPUQQLRU4yMdbQ/HSBEiwYTbu+GKvTCz1Y6r+ItJiK3tMenjXiILuEXt35m125Cu4755S6THiFp9gGe5kOO41xfeSrqTjyaHJHzihoRr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C9mDHRyc; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C9mDHRyc" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-55f6b0049fbso6235476e87.0 for ; Tue, 09 Sep 2025 04:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757416295; x=1758021095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ylvE7Edllpe4hKT/WEebW1EKotcR3e4yYuI/L6NTjw8=; b=C9mDHRycjJVqi1DWJEmoi3KIB4swdabs5vzxdwiTNByx++J27Sa60bXgFn+QJYILpP Gdm11++YbPIGl1J75no0uLqI1j/kjThzI0oJQBnPSvu/IQe2FWWMIv5HfX0nuz3GCCV0 OVaboZLx1SOuL+EgiVWRPBezu0Cp/T4nYf2Ci003qeeaB2QOr0nBh35ktQAAH3VzAZ54 sIHLAr3l2OO4s/Yv3HSDjT9Ud6tt3tm+GXbEvlhTx/4hsoDRVApHYGP0NCgmXdY4y6cx 3CeQI69HCbffxyP3f+q51h/wElWPQ/xjEtEjdowdzHF0Rj01yBslMnoHpyt4MQ2sS7v3 lc2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757416295; x=1758021095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ylvE7Edllpe4hKT/WEebW1EKotcR3e4yYuI/L6NTjw8=; b=lR45k+dIo8UDvhc9viojI5aq8DXHXkyOJWk4v05+Y+xZ3nKInTyKE+COft0k1e+BNz fJntpq0oTt8wHNhqwRzCeSmjv8zLcsFcmFTVbdwJyVDs8oK+Er5V8zjw5pnHmVg1ApgX FzBvOkAXLB65MNqDrNWc0///NrjyPUrxdeae2TXlXLge0bgyZN0EJe/TO960tG42C8XT tWXKi4K/fLCb2xm2uOcGrB8Lu/UTtqXB9eSsgoPjnWI8f7jU2uc7k6c1nUcJcatuemIm WxE5mxd2OlHaM3UGmezMoPD7qfXfOi1tmI/bEfXua7346R45o4aAgNG3KrM5ysK1AM/p gjiQ== X-Forwarded-Encrypted: i=1; AJvYcCUkh8/fjearVA4ZcA3x9C5nAs8Rc4NUZXFT8EhYXEoqMjZGmzNd356hJdXzbRAQd9jbpEHmY/ztdl4LK8g=@vger.kernel.org X-Gm-Message-State: AOJu0YxM2ekQkfxAkWJh4J1RZ0Qw59cRs/ukhgRrBkpdgU0PZziWfaEV VA2UmybUkuA++KlK6buuYYq5ZM6RR2LJJ0SdpV33LTMWP6rHj1AzYIx9SisYnxNX8sU= X-Gm-Gg: ASbGncttr/hn6JGkstOMyOxQzIokNFNdZgaJkzLfTcj1BY1dnImBeSTIDPrhdHjPDOX DRK2FQW8TeS7zkMqcbQnPij2yQE9HQu9dpWQH8ygY6UiwMKG3z4ococLgh2mont9oJJx3Sw1Ojr zYosECDj1yv9IVFT5tCDQpibPkAOJSxrbcmDb5l5DhEPL8BzYB9jY50rAp3wRO0ha1gbzRb/AOA mpZWFByCfKnnUhG3p/QGdMHrGPnNE+z0jMmajrZPpO1XQKPolqJ1biwLScIL+GS+Eg40bcRoYA5 dt2MoH0rCxRifpZXIOpUFFBW83Ppx8n9uMhwoD1bwVlyvmz1oXTSsDfxi6lfULJMdKQmqbsN3eT 13EovltluTet2OTo4265aiFNdt2rTFzEYgwFI+nT0AeXg/k0XD6IpJaPTrWtiJ6SBQAyNbOHC X-Google-Smtp-Source: AGHT+IF4O1xigAj0FDirxpcdFMfAw0PezfxnC2jHlhfrcwTgbFgAxA7QwQSCR2UAHH35xR2kprU3qA== X-Received: by 2002:a05:6512:3c98:b0:560:84bf:7bc with SMTP id 2adb3069b0e04-56263c9897fmr3225878e87.56.1757416295035; Tue, 09 Sep 2025 04:11:35 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-568190f8040sm445440e87.148.2025.09.09.04.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 04:11:34 -0700 (PDT) From: Ulf Hansson To: Geert Uytterhoeven , Nicolas Frattaroli , Saravana Kannan , linux-pm@vger.kernel.org Cc: Stephen Boyd , "Rafael J . Wysocki" , Heiko Stuebner , Sebastian Reichel , Sebin Francis , Diederik de Haas , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Johan Hovold , Maulik Shah , Michal Simek , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] pmdomain: core: Restore behaviour for disabling unused PM domains Date: Tue, 9 Sep 2025 13:11:20 +0200 Message-ID: <20250909111130.132976-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909111130.132976-1-ulf.hansson@linaro.org> References: <20250909111130.132976-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Recent changes to genpd prevents those PM domains being powered-on during initialization from being powered-off during the boot sequence. Based upon whether CONFIG_PM_CONFIG_PM_GENERIC_DOMAINS_OF is set of not, genpd relies on the sync_state mechanism or the genpd_power_off_unused() (which is a late_initcall_sync), to understand when it's okay to allow these PM domains to be powered-off. This new behaviour in genpd has lead to problems on different platforms. Let's therefore restore the behavior of genpd_power_off_unused(). Moreover, let's introduce GENPD_FLAG_NO_STAY_ON, to allow genpd OF providers to opt-out from the new behaviour. Link: https://lore.kernel.org/all/20250701114733.636510-1-ulf.hansson@linar= o.org/ Reported-by: Geert Uytterhoeven Link: https://lore.kernel.org/all/20250902-rk3576-lockup-regression-v1-1-c4= a0c9daeb00@collabora.com/ Reported-by: Nicolas Frattaroli Fixes: 0e789b491ba0 ("pmdomain: core: Leave powered-on genpds on until sync= _state") Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late= _initcall_sync") Signed-off-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Tested-by: Heiko Stuebner --- drivers/pmdomain/core.c | 20 ++++++++++++++------ include/linux/pm_domain.h | 7 +++++++ 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index 0006ab3d0789..61c2277c9ce3 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -187,6 +187,7 @@ static const struct genpd_lock_ops genpd_raw_spin_ops = =3D { #define genpd_is_opp_table_fw(genpd) (genpd->flags & GENPD_FLAG_OPP_TABLE_= FW) #define genpd_is_dev_name_fw(genpd) (genpd->flags & GENPD_FLAG_DEV_NAME_FW) #define genpd_is_no_sync_state(genpd) (genpd->flags & GENPD_FLAG_NO_SYNC_S= TATE) +#define genpd_is_no_stay_on(genpd) (genpd->flags & GENPD_FLAG_NO_STAY_ON) =20 static inline bool irq_safe_dev_in_sleep_domain(struct device *dev, const struct generic_pm_domain *genpd) @@ -1357,7 +1358,6 @@ static int genpd_runtime_resume(struct device *dev) return ret; } =20 -#ifndef CONFIG_PM_GENERIC_DOMAINS_OF static bool pd_ignore_unused; static int __init pd_ignore_unused_setup(char *__unused) { @@ -1382,9 +1382,6 @@ static int __init genpd_power_off_unused(void) mutex_lock(&gpd_list_lock); =20 list_for_each_entry(genpd, &gpd_list, gpd_list_node) { - genpd_lock(genpd); - genpd->stay_on =3D false; - genpd_unlock(genpd); genpd_queue_power_off_work(genpd); } =20 @@ -1393,7 +1390,6 @@ static int __init genpd_power_off_unused(void) return 0; } late_initcall_sync(genpd_power_off_unused); -#endif =20 #ifdef CONFIG_PM_SLEEP =20 @@ -2367,6 +2363,18 @@ static void genpd_lock_init(struct generic_pm_domain= *genpd) } } =20 +#ifdef CONFIG_PM_GENERIC_DOMAINS_OF +static void genpd_set_stay_on(struct generic_pm_domain *genpd, bool is_off) +{ + genpd->stay_on =3D !genpd_is_no_stay_on(genpd) && !is_off; +} +#else +static void genpd_set_stay_on(struct generic_pm_domain *genpd, bool is_off) +{ + genpd->stay_on =3D false; +} +#endif + /** * pm_genpd_init - Initialize a generic I/O PM domain object. * @genpd: PM domain object to initialize. @@ -2392,7 +2400,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, INIT_WORK(&genpd->power_off_work, genpd_power_off_work_fn); atomic_set(&genpd->sd_count, 0); genpd->status =3D is_off ? GENPD_STATE_OFF : GENPD_STATE_ON; - genpd->stay_on =3D !is_off; + genpd_set_stay_on(genpd, is_off); genpd->sync_state =3D GENPD_SYNC_STATE_OFF; genpd->device_count =3D 0; genpd->provider =3D NULL; diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index c84edf217819..f67a2cb7d781 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -115,6 +115,12 @@ struct dev_pm_domain_list { * genpd provider specific way, likely through a * parent device node. This flag makes genpd to * skip its internal support for this. + * + * GENPD_FLAG_NO_STAY_ON: For genpd OF providers a powered-on PM domain at + * initialization is prevented from being + * powered-off until the ->sync_state() callback is + * invoked. This flag informs genpd to allow a + * power-off without waiting for ->sync_state(). */ #define GENPD_FLAG_PM_CLK (1U << 0) #define GENPD_FLAG_IRQ_SAFE (1U << 1) @@ -126,6 +132,7 @@ struct dev_pm_domain_list { #define GENPD_FLAG_OPP_TABLE_FW (1U << 7) #define GENPD_FLAG_DEV_NAME_FW (1U << 8) #define GENPD_FLAG_NO_SYNC_STATE (1U << 9) +#define GENPD_FLAG_NO_STAY_ON (1U << 10) =20 enum gpd_status { GENPD_STATE_ON =3D 0, /* PM domain is on */ --=20 2.43.0 From nobody Thu Oct 2 23:50:51 2025 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 825CD322543 for ; Tue, 9 Sep 2025 11:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416300; cv=none; b=GRw4N8LG6tmdO58PUg93DaMTVTO6p41OBjU1YgRq3kACuCpzdXiCJk0BAQ1/zTtVvBERaiFvl91JepRyCaqs8t0Ec9y5IUkbS/ilUjF8VsT+NiYtt2ngx2iZ2szc5l//nTAl0xrQMfOxRdYMbU0IdtLQ74lamlpQRwGnTGdLDc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416300; c=relaxed/simple; bh=FT2wsbDyCZRzD2r+SnftPJClb+shQXg//V9P9Jil0eU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kd3cvLRiJKLdk1tFultZiEBDHecM7l+/yH4dj8C/wm4WdacQ0NCzsJl1ErZ62bRbBENs+ZDCAYZpNeFcuWt687SHwHy12wCX78u2cwUkt+2WyFYWdK3rHbiyOKu/K3jWEeIjfjg/PFIhsfEn3ZKo54EMZa8/Lvu+kXBHgSt7sLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yGNoBs4X; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yGNoBs4X" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-55f78e3cdf9so6695903e87.1 for ; Tue, 09 Sep 2025 04:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757416296; x=1758021096; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xRRJzAp5T/AY0upYHHrWwdi9zh66HciwKxd1T/ME7rY=; b=yGNoBs4XjZ0kr82NOQ6fdutdX09iGIZuWcEw5FA3qVZ0BYpb1I13GrahPRwn7zrPqv DpRKsTwROhnigCx5P9jXgK17kfQneMIm9q9LVYEGoIaW09R5haFPM66THrxCJytbxeDp O5DK3H3ZzC64pOWED9GUIOlYnOS8VqClrW2HgjM12VRQcvyEATrBatjPRaJmr5TVo/NK WB3eDnIS0hUFyuz9v3WgZdKviaq0oqWQfEiC7SacT2M7qEIwDA7OgSFUgJUBY0mQN8y1 A+MPIXX7olMWtIN0BuV+RbFlj0qeF/4m9KOzFrdWpPx1KhA5p5qwfWjL8KRBbsf1ndBO terg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757416296; x=1758021096; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xRRJzAp5T/AY0upYHHrWwdi9zh66HciwKxd1T/ME7rY=; b=UHfRa0rtjP01Dd97QK+vay6jgfBxrR39IV4eDOqGkWuc9TKwnaKrbQzTeZWkBliITN sXDw5QnuEZ9ld0fFMw9Dk+mTneyBBLFppjcGgCm2U7JXT8IhHk5uizNwi7XlBOvVAcTG H1JBtkpoOCdWCXb0K8TnQYuUbtWdy64IpiasnNOish7L6zD8zrrWb9ea6Rr1uPOMAIRs rvedvN0/rJvG8UOXFWYoUtG72mfRAdK33qtuYiyFIV2mG3dzTkKOLDYglnJQr0d/oYkd qlcmqQaX5LAy2E3xsVfZpG+26eqakwB9cM9PGh2kwwFAa8WCfDVYNJePM/o5jTx58ri5 KJJA== X-Forwarded-Encrypted: i=1; AJvYcCXZdfheKrOhM9cadIsnpe5HEdi8jgrJrbZpmVYxqR4gQfdA2UxX5kW0nCDXA9LWHoYEY1I9UW2jhl+a4ws=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9qdNUlnT+tTsY55izM5fL4PT7JSoWw/qrDY8TvZjGFneZ+1MM Gz4SYqf6x5lZsRXAr31RB/+KaHTKdXU6lTemGb+M7ol3e0zd2MFsdfzxKizAyjDwYCk= X-Gm-Gg: ASbGnctQQ21P7xG3hZPZechGmQFG9koj7ufGkqoYTT7Q36OKy7dV19F4FiBq/cC7I3z adD8JFNEz5Add8S0hCi82b1Yl/te5yBsCDjAOFZnmfjz3CfCYrOTkfa+o58hX0wkgl3iwTwFbCZ c8jl7AlfqR9E8T1+Q2S/4BQBoX2vEIKPcQdehQ3SGqOGdiaZ7nzJomc8MevvC/damZ6R1qEppNN gczF0Nk7vmHeqkWGf+EU9pv1hj0tGPsMPvIeFxqJpwqKek7MC/8soRzryFrLpDekWOp6ZA1Y/8X /z0gKgKBHIoiXipmiZjwN67U/Pg2ZyM17KksaVK3eCr1hmeLZYkh5aHpZoJJ5rzYIQUAMFCJM34 YOPzKocwZe5vEpWXTJJFUa/Dk3NOyk8m69GxUJUBQgpq4I927Fg5m2qiQcYWms2ye1JlOLxOXnR lu/e30oPI= X-Google-Smtp-Source: AGHT+IE+Q6v2KTcckCRiOxW67dRfnlJxOytiBrBROHCosdo74CbcYnNRw9OtyMUXGt/Lx7pml2UICg== X-Received: by 2002:a05:6512:b12:b0:560:8b56:5dc5 with SMTP id 2adb3069b0e04-56261cbe1f7mr4363060e87.18.1757416296383; Tue, 09 Sep 2025 04:11:36 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-568190f8040sm445440e87.148.2025.09.09.04.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 04:11:35 -0700 (PDT) From: Ulf Hansson To: Geert Uytterhoeven , Nicolas Frattaroli , Saravana Kannan , linux-pm@vger.kernel.org Cc: Stephen Boyd , "Rafael J . Wysocki" , Heiko Stuebner , Sebastian Reichel , Sebin Francis , Diederik de Haas , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Johan Hovold , Maulik Shah , Michal Simek , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] pmdomain: rockchip: Fix regulator dependency with GENPD_FLAG_NO_STAY_ON Date: Tue, 9 Sep 2025 13:11:21 +0200 Message-ID: <20250909111130.132976-3-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909111130.132976-1-ulf.hansson@linaro.org> References: <20250909111130.132976-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The deferred regulator retrieval for Rockchip PM domains are causing some weird dependencies. More precisely, if the power-domain is powered-on from the HW perspective, its corresponding regulator must not be powered-off via regulator_init_complete(), which is a late_initcall_sync. Even on platforms that don't have the domain-supply regulator specified for the power-domain provider, may suffer from these problems. More precisely, things just happen to work before, because genpd_power_off_unused() (also a late_initcall_sync) managed to power-off the PM domain before regulator_init_complete() powered-off the regulator. Ideally this fragile dependency must be fixed properly for the Rockchip PM domains, but until then, let's fallback to the previous behaviour by using the GENPD_FLAG_NO_STAY_ON flag. Link: https://lore.kernel.org/all/20250902-rk3576-lockup-regression-v1-1-c4= a0c9daeb00@collabora.com/ Reported-by: Nicolas Frattaroli Cc: Heiko Stuebner Cc: Sebastian Reichel Fixes: 0e789b491ba0 ("pmdomain: core: Leave powered-on genpds on until sync= _state") Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late= _initcall_sync") Signed-off-by: Ulf Hansson Acked-by: Heiko Stuebner Tested-by: Heiko Stuebner Tested-by: Nicolas Frattaroli --- drivers/pmdomain/rockchip/pm-domains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rock= chip/pm-domains.c index 242570c505fb..1955c6d453e4 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -865,7 +865,7 @@ static int rockchip_pm_add_one_domain(struct rockchip_p= mu *pmu, pd->genpd.power_on =3D rockchip_pd_power_on; pd->genpd.attach_dev =3D rockchip_pd_attach_dev; pd->genpd.detach_dev =3D rockchip_pd_detach_dev; - pd->genpd.flags =3D GENPD_FLAG_PM_CLK; + pd->genpd.flags =3D GENPD_FLAG_PM_CLK | GENPD_FLAG_NO_STAY_ON; if (pd_info->active_wakeup) pd->genpd.flags |=3D GENPD_FLAG_ACTIVE_WAKEUP; pm_genpd_init(&pd->genpd, NULL, --=20 2.43.0 From nobody Thu Oct 2 23:50:51 2025 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C659D320CAF for ; Tue, 9 Sep 2025 11:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416301; cv=none; b=QZpKfSQVdkn/QzwOBGagirbG7KsDtwsPqDN0+STc9yG8L3K3lmUWOrBbOJI7qK0rLg0eyPAPQoCczwaKDQupeYZibkneloT5jH6X21z7VwbgULqH/4jQclzn18KeDoTe5zUKb1GyGYi6piLdP4dwk4/XdQvotWi6IjRFImQrapQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416301; c=relaxed/simple; bh=hk3zLwcEJKFdhvO6fbF4mETMi1Wbntn3yOBrNMw+h10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=izN1D0V88ehriFzZ0Me/snaF1h68Ry0xlXurfdgzlzpFzdqQKC84BP75xr5bMWCKl4EWWl/9Qg9VeNe5qEO7XNRN+vTedHymvwRtwO2oNrGspgGxKploT+0Msczkglucih9ulPhwtX/9N5A+Fg2o1Y1mjjaocVSfDMhYHM9/CLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Zgu3nzuG; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zgu3nzuG" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5688ac2f39dso626773e87.3 for ; Tue, 09 Sep 2025 04:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757416298; x=1758021098; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fYd82RFH6eK4wGWLoS9WCtFcsYKgozGDQMKLc16TQyQ=; b=Zgu3nzuGB123lSE87IXojwFVMX5+8TiabEOuS0glbhpwAV+oWPNObGzenm8UkEfiyJ XRIENXcxDWahii9aisNy1rkuBaZotUcdCQvYB3d2XkRKN7VAIgUVHglf5k9ofh1Uluza 7YwzlQ6q58JZLCNtQY3O3o4YPKAyPwbLHvuQodJ0ahdP5ilN7C+kHAmwK8kmr3PAworQ 3U3hH+cQCIEIZUWvXKp5ohBamS8m1u5bzy+dlOyuO9rUYmaHgTA5sksM5czjbVffz2qi TCK1RQMxnKd3SilGbitiZ3delYFpefzRVjGOEI6D44yu7ULQYYNXZj9R+bVl7L8ztNQB zyMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757416298; x=1758021098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fYd82RFH6eK4wGWLoS9WCtFcsYKgozGDQMKLc16TQyQ=; b=wHHYSe70DwN5HjvIZnBhKmheZF+1m3fas/43BHZIYPMntADdJ20uVe8tHxla7Mgdup kWlxR0gC30Y+fZMA4kHEjLJYd7o08/EaGznLkxvkdiSzEkCV6XZNNqPIjV+AH67CRdr7 LxBFBczPsqKUQx3SN8AtKM+ER/QR/ZcxvQdr0d/mwScDKPElMrQTjYN3jNDyIWPrPUeG Y5JuOwJ3iAWMrBrnjh2friPPGdAPVj6ie3QWEPn7x3NOcotR8H1OUE1LdvOQB7XGFgli eAAN0WdKWTHeufCiDHOlwO2wJDX8Y0/pv8L3AFhnqLChL+5dl128YBbsqn6DuxA7FfYF xmIA== X-Forwarded-Encrypted: i=1; AJvYcCXDuhQlHBEBGbXEAR7wjxgbRraPk189ZqS5Cvvqj7UjkEzj3sOL5xj21EWb0gh770nZuLf8XhBf5ZbOFMs=@vger.kernel.org X-Gm-Message-State: AOJu0YybDhNvXPgCALuhQAs6dR8f7GIejNDawafOn1ikChdmrLtbj1Z8 sHzjZb3eDd7T/SqfZUZQHEJcQ5s2yUu/GMN586+naEfK4aOINgQ+jr5lDR9Hza/xRTw= X-Gm-Gg: ASbGnctQgJdreUK4B86rU5SOqztpV7hUkaCMWPsToAiNQzDfn4QTVpTRymylmetER11 CnCUSjnGUjtWGbEnohv8og3x0up2/0+fxu4w9sHgtSSf1JaMyUg0Bewlr/T1yegAnfHe71chltO AKt9Izxl/qBOr6cc7hILKjnftJQO0lq01otnzGCR+qz0I4xsOgVdKntuRV/6P3PXr2j+rEOcC8z VT2A/FtNvaJDsOCv7CkkX0vuqJ/JhIe6mfwRGzzxe3E4eGsGnKU/ufUoMjrFKjnU75qP6l3Bipz 78mkXg6G/IMky1ITVhyOFp2A1g9nBvlTZn5S+KEyWr34GKK7sFLLHQSQ6UO9HYu58BBihEokEWL Ax5Ppvq+T4WZknR5AgID4Js4/cU0K6wYKN7SxuJGvRI+9CQoJaaIuA5W90d4eCZOF9Og8M0md60 RS37h48/o= X-Google-Smtp-Source: AGHT+IEDEezqBzu6WD5cRb0Yhvc1WCJvGMbiCnMcquxNLiuAz9Ox4q5bWS49Ks338WKrFgMjtbd8NQ== X-Received: by 2002:a05:6512:220c:b0:55f:6bae:50c5 with SMTP id 2adb3069b0e04-5625ffc80ebmr3407675e87.19.1757416297700; Tue, 09 Sep 2025 04:11:37 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-568190f8040sm445440e87.148.2025.09.09.04.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 04:11:37 -0700 (PDT) From: Ulf Hansson To: Geert Uytterhoeven , Nicolas Frattaroli , Saravana Kannan , linux-pm@vger.kernel.org Cc: Stephen Boyd , "Rafael J . Wysocki" , Heiko Stuebner , Sebastian Reichel , Sebin Francis , Diederik de Haas , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Johan Hovold , Maulik Shah , Michal Simek , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] pmdomain: renesas: rcar-sysc: Don't keep unused PM domains powered-on Date: Tue, 9 Sep 2025 13:11:22 +0200 Message-ID: <20250909111130.132976-4-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909111130.132976-1-ulf.hansson@linaro.org> References: <20250909111130.132976-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The recent changes to genpd makes a genpd OF provider that is powered-on at initialization to stay powered-on, until the ->sync_state() callback is invoked for it. This may not happen at all, if we wait for a consumer device to be probed, leading to wasting energy. There are ways to enforce the ->sync_state() callback to be invoked, through sysfs or via the probe-defer-timeout, but none of them in its current form are a good fit for rcar-sysc PM domains. Let's therefore opt-out from this behaviour of genpd for now, by using the GENPD_FLAG_NO_STAY_ON. Link: https://lore.kernel.org/all/20250701114733.636510-1-ulf.hansson@linar= o.org/ Reported-by: Geert Uytterhoeven Fixes: 0e789b491ba0 ("pmdomain: core: Leave powered-on genpds on until sync= _state") Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late= _initcall_sync") Signed-off-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven --- drivers/pmdomain/renesas/rcar-sysc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pmdomain/renesas/rcar-sysc.c b/drivers/pmdomain/renesa= s/rcar-sysc.c index 2d4161170c63..d8a8ffcde38d 100644 --- a/drivers/pmdomain/renesas/rcar-sysc.c +++ b/drivers/pmdomain/renesas/rcar-sysc.c @@ -241,6 +241,7 @@ static int __init rcar_sysc_pd_setup(struct rcar_sysc_p= d *pd) } } =20 + genpd->flags |=3D GENPD_FLAG_NO_STAY_ON; genpd->power_off =3D rcar_sysc_pd_power_off; genpd->power_on =3D rcar_sysc_pd_power_on; =20 --=20 2.43.0 From nobody Thu Oct 2 23:50:51 2025 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3BFA326D55 for ; Tue, 9 Sep 2025 11:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416302; cv=none; b=eTwzMuJUhC9RYVY9PcwCAHCExpzg0SV8p1QhlDQty2oiBHsa4v93dOjWXe8dY/W0i1ZetID6A8kQW/+aTxhejWj2dUIbSP55AioJZEIy1iAKiyBR0inXupKJVCvf4CpLAb+euV8kt5HoGfKAm1fAUnTMKOcSMg2DTtXECEnJSCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416302; c=relaxed/simple; bh=VvUp9qnNE7LRT6dFMEFfaf+OTUSJqg4fih88UVXdmOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DcTMaioQNbTwZZWiZOXojeLW6YIPDXuruJDtgsyCes/ERUq1T+vocZOQID71opbcc8SHKxqeoUJw+4FFsr5PrWOX/t2KKgZVpo3Q046KRn1Bmb7RTzh9D2DqdEfU/IWtB8owPk2b7nyZzZVnQdnntAvE4VEjwLPGaz6SZqko3RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DuLQFk05; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DuLQFk05" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-55f7039a9fdso5618460e87.1 for ; Tue, 09 Sep 2025 04:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757416299; x=1758021099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=euHGryHJ8QWDxT7cesCDLU1KtKBsI9gmyEIIx1smyRQ=; b=DuLQFk05D+BPKDPUDpp2569BQoR8/S75dTvna+F3aeNY35eq3z544ToC3I7nxQK6NR OWWlIYgJ9t8di+7aaCkfYClEh4pdqvYe6fD6zvyibNuZHyec3zN41lgNzEo7ogbFI6an ZhiBHkBFZWf8dlLeDfPey66TuwQ+Kg/r91v6olnwVJ+r+6Gez7tSOCAj11ib0XXNl8j4 DtDq3rD/0eZHPgzWOIM3SM2Gpz0SZB+2jNUkAeeb1UsrqMpT/t3IT2xnLhzLv/StZY5B Crj2iZtWaAjItfrELWHI0yPzxYxzX2MalV0gYUmbMuj5ay13M9hLidDSrJskyYaWk2ck QLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757416299; x=1758021099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=euHGryHJ8QWDxT7cesCDLU1KtKBsI9gmyEIIx1smyRQ=; b=u4lqrPeNlHELctDcr1xFB8nmkfClnI1redKa75NpV+n2ZzsT4Yb9H0hzx8U+dFuIyk kPoGFolsVpYvWj9b1kpYhjfKILywV2iXzUWUkg9ziSElREiwxUYBVac+YYMKmB/B4QNb KVmh7Pxt/1qu92MKcH3et/seBCzdT/BpbSUnV5BG4z7YBP2pbrt9qR4jbTf6iP7hUTx0 pZs7wKaz86z+duDLMxJ6J3qeHbfSXo2vWCU+2AGBgYTotU/DeMeypoQALH5sBrK6w0Yf gDtDJV85V2Eyat6KK7DeEgMznU0d3tLiQBYWU/7kW85OJ/f7hC8VgpJhWSuinqnNY2cP TAjg== X-Forwarded-Encrypted: i=1; AJvYcCUcBmRsvWs6BfQwRFZmiyb0YEtXtY651uSZ2MS+zLlfHoOobH2fD+6PVI9W/xLPnZaOKzQwXeiNJfzh6WI=@vger.kernel.org X-Gm-Message-State: AOJu0YxhbZhJ+b7JwZg01cu30gf4FlvYGEa/dLMU5E7HZ9uJxTv6R9qm q1jTSRT44fgydM+DAHSrWRjXaxZsf6yLhswvCLEz6NMnvjw81p0VH6JbVoayzMGZc1c= X-Gm-Gg: ASbGncvYobcq2V1AjoyULxcMiAbjBIXXLZUrDdmMtlsTrql0RHcsVyUyWh3hpr0+oWt MC9kfHkofl5RTWCpoY7oI4N68ErsZY+XJsX48hJIu0yVADLm6GPgIp4eCQdlWeIPMrgISQIiFws 9L0hPeAElZockQ6z3Np11oyfdn2PuSBfGHsQm6iw0m6vX6YViQgA48+LfWEHcPsQLkJSAzm8qMv eC36IXj7s6gQqSPFXU9XutbE7E7rkvaGYwn2p/lHpAdgzCmufdfHKyUBCgSR30rCueYHQwy+BYS veVBfe5ycA5//WtO6uIHgOJoCu849xhkJlanjpb1dguOlMuktADcsgZScPy7RASqP+nI0wuXje+ R+19TCabnnisnyok5D6mhUMDcWEn0c0BGVWYaMWy9J0xsO1kKoQ9e9EzlNxMRpoQo03w0Is6SYr UJ5aaHL1c= X-Google-Smtp-Source: AGHT+IFfaEg7KARMsiLKzyUcPFhDsGf7F+a3gcOB6C+SVsQx9Fu2a+sXO0Qgm1wWuW8uSP6aIC1C1A== X-Received: by 2002:a05:6512:108a:b0:55f:4db1:e450 with SMTP id 2adb3069b0e04-56260e3b836mr3025626e87.22.1757416299071; Tue, 09 Sep 2025 04:11:39 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-568190f8040sm445440e87.148.2025.09.09.04.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 04:11:38 -0700 (PDT) From: Ulf Hansson To: Geert Uytterhoeven , Nicolas Frattaroli , Saravana Kannan , linux-pm@vger.kernel.org Cc: Stephen Boyd , "Rafael J . Wysocki" , Heiko Stuebner , Sebastian Reichel , Sebin Francis , Diederik de Haas , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Johan Hovold , Maulik Shah , Michal Simek , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] pmdomain: renesas: rcar-gen4-sysc: Don't keep unused PM domains powered-on Date: Tue, 9 Sep 2025 13:11:23 +0200 Message-ID: <20250909111130.132976-5-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909111130.132976-1-ulf.hansson@linaro.org> References: <20250909111130.132976-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The recent changes to genpd makes a genpd OF provider that is powered-on at initialization to stay powered-on, until the ->sync_state() callback is invoked for it. This may not happen at all, if we wait for a consumer device to be probed, leading to wasting energy. There are ways to enforce the ->sync_state() callback to be invoked, through sysfs or via the probe-defer-timeout, but none of them in its current form are a good fit for rcar-gen4-sysc PM domains. Let's therefore opt-out from this behaviour of genpd for now, by using the GENPD_FLAG_NO_STAY_ON. Link: https://lore.kernel.org/all/20250701114733.636510-1-ulf.hansson@linar= o.org/ Reported-by: Geert Uytterhoeven Fixes: 0e789b491ba0 ("pmdomain: core: Leave powered-on genpds on until sync= _state") Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late= _initcall_sync") Signed-off-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven --- drivers/pmdomain/renesas/rcar-gen4-sysc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pmdomain/renesas/rcar-gen4-sysc.c b/drivers/pmdomain/r= enesas/rcar-gen4-sysc.c index 5aa7fa1df8fe..7434bf42d215 100644 --- a/drivers/pmdomain/renesas/rcar-gen4-sysc.c +++ b/drivers/pmdomain/renesas/rcar-gen4-sysc.c @@ -251,6 +251,7 @@ static int __init rcar_gen4_sysc_pd_setup(struct rcar_g= en4_sysc_pd *pd) genpd->detach_dev =3D cpg_mssr_detach_dev; } =20 + genpd->flags |=3D GENPD_FLAG_NO_STAY_ON; genpd->power_off =3D rcar_gen4_sysc_pd_power_off; genpd->power_on =3D rcar_gen4_sysc_pd_power_on; =20 --=20 2.43.0 From nobody Thu Oct 2 23:50:51 2025 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7611632A3C2 for ; Tue, 9 Sep 2025 11:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416304; cv=none; b=MY8EFfkkZfHFSx0V0fGgsEOpv5NbuMpPvO67xD82HN7MldSnROMhOhBYrg3dEHJnL2DRP0rMo854s3M1+E+R/8Ee6ZvwL4kklvOXjR9Hr5NX1Y364NX4dPVZpfj5eGNVQrVcAxIGgj6llPCnukmAo/yZO+l2+d+ZA7+MXCJI0A8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416304; c=relaxed/simple; bh=qX2XQlnL77P0KB6EClM0+xTAM+le4yDduPWYxg1F5ZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TPGcfDiTbAyF1mIGbNV0GGuYJ4yWPV3sgOisH5nWL/+KI+PMREA8gtS3og0/6txnTW0cRItae1TppxxRjvz0pjKMpO5H7GMLj55JWLVmJHq28FTbRMmkneIKTqddE8T71WvdZ3mmioLWlKH5Rlkygv5PZIYdpaALBmq+SU9L7M0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uuAI8+kr; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uuAI8+kr" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-55f6b0049fbso6235594e87.0 for ; Tue, 09 Sep 2025 04:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757416300; x=1758021100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7s4ue+vxLshDaVNog/qaeHRfYjor1s3xeCpGVICPA0U=; b=uuAI8+kr6UZrPmjAi2JGqIXdQhh8kzvyBETXnFVd/rchL+995Q8kDzBZfYdR0m6oQ5 IysC6wrN9/l6r7cHhbfbTiAycr3ojx493iByx6XlgS50dzcv9O288iSamqMuuEvHQUXy KC8sVTWScjQgGU0vYIUcmodQdoYDUsGfnRS93Sr6xFtjQvw9VEp3Vvca9KJBAcarsr5W V3wMjAaDNHR/m6YSHHwUsJYtI2uSV/OkbLAPJAurqynpJwM5ZRbDK8KZOkTylUP15Guk y8833WK5DN2PVhSteql9nSnHbZjKhWR+Qta4P6YJgVaLRXFYhy7iprbgswtjjA3/N2i6 2V1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757416300; x=1758021100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7s4ue+vxLshDaVNog/qaeHRfYjor1s3xeCpGVICPA0U=; b=CcqlV4KaBeXZwJlcjEgWpwkVvG0H8zk2m3QDRh7aEKmZgqCOSYK08riFCZk44A1LhQ 0MqRsqk5RplXeA9tElgLdnj+03yWVt09SD2nnr3ASsRfn4JUog4KbkGnEw5xFMfvp2bt unprX/Cje2HCYK/xOlaUw9LboLazAB8vuWSKgXKARzsZTEmFeq1D2BseMi5/m56wc9Pg BvPYBGhxUV1I/HLDy8QK3X01AVuWSdpRBcxXs2NlcCkT/HfRPW24FUVQpgFOVOeUWjuc 8JuPYQ3CSUOSkD+HfK2w1eH1GxHB7pj2t5gu5CzD7RGY3pOWJto4v91TtGGTFtq9e3wt eFAg== X-Forwarded-Encrypted: i=1; AJvYcCWmSIpdLNHA6ueOV1d4WBz2dB6gqPaD0JO16pcg0A3e2UbM+hWjPOn8UmDE0Ua/Zw2Xwh2oHfTGB5b9ir4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8YKUgfwBP187J8Z4MOJt0qW/AoD1E5QIkdRCP0Yi+ZBNCt18k YCcyDrnycuWuUeFfE9Vpz4RTkBrpjVygLNrh/G3fbsAR/y4BVPapWhmUKOfUFRHIGEHlBZdWYMD tayEi X-Gm-Gg: ASbGncsMKROniZeiRF55ZAKpMXacZ6+YUFGNMRf7qJDX3LMOL15LzerV8jWYqMbi975 Ylb4riW/5vS2NVloDX/HVNJS7HAswGz2yFxIUf4io46UcBehsShoWWmWZc+ebIE7yQwFJCerZZ4 qmnFtrAsCuDfyunF+0C6LvLSSBUdcWtrE4lHvsflcsvfC3471M2WdPrrDuKljSXpm+qMGhqTmhI cB+xzGmSO+/G64wrSB8VNDazueEbtwTaAHfMyI38MI+w9AL7716/HIXytVqUlj85jWlyweAK6Y5 gIS8GJkRLBbbtb+wrwe5HUG7WabCfbDToVl0x6zN0jomrPRH7tv8RnViWd5wC4TUMoKgoZkgUZr tngaKRB3qbyG7vjKX9SXKBxaUse7lNv66sOTFdeo40RqHjP8hxYMVy4Vk9wW2F8r2GhOQY1RUx1 CAo+oa2h0= X-Google-Smtp-Source: AGHT+IH3If1E1wmdYnnMVHOIWDwlC5uh1BOrgxWYASzxhPPmZmGZqHrDzK8CUhRE0KdKbGrCF4Hbhg== X-Received: by 2002:a05:6512:10ca:b0:55f:5942:43ca with SMTP id 2adb3069b0e04-56260f37a43mr3913159e87.20.1757416300440; Tue, 09 Sep 2025 04:11:40 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-568190f8040sm445440e87.148.2025.09.09.04.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 04:11:40 -0700 (PDT) From: Ulf Hansson To: Geert Uytterhoeven , Nicolas Frattaroli , Saravana Kannan , linux-pm@vger.kernel.org Cc: Stephen Boyd , "Rafael J . Wysocki" , Heiko Stuebner , Sebastian Reichel , Sebin Francis , Diederik de Haas , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Johan Hovold , Maulik Shah , Michal Simek , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] pmdomain: renesas: rmobile-sysc: Don't keep unused PM domains powered-on Date: Tue, 9 Sep 2025 13:11:24 +0200 Message-ID: <20250909111130.132976-6-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909111130.132976-1-ulf.hansson@linaro.org> References: <20250909111130.132976-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The recent changes to genpd makes a genpd OF provider that is powered-on at initialization to stay powered-on, until the ->sync_state() callback is invoked for it. This may not happen at all, if we wait for a consumer device to be probed, leading to wasting energy. There are ways to enforce the ->sync_state() callback to be invoked, through sysfs or via the probe-defer-timeout, but none of them in its current form are a good fit for rmobile-sysc PM domains. Let's therefore opt-out from this behaviour of genpd for now, by using the GENPD_FLAG_NO_STAY_ON. Link: https://lore.kernel.org/all/20250701114733.636510-1-ulf.hansson@linar= o.org/ Reported-by: Geert Uytterhoeven Fixes: 0e789b491ba0 ("pmdomain: core: Leave powered-on genpds on until sync= _state") Fixes: 13a4b7fb6260 ("pmdomain: core: Leave powered-on genpds on until late= _initcall_sync") Signed-off-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven --- drivers/pmdomain/renesas/rmobile-sysc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pmdomain/renesas/rmobile-sysc.c b/drivers/pmdomain/ren= esas/rmobile-sysc.c index 8eedc9a1d825..a6bf7295e909 100644 --- a/drivers/pmdomain/renesas/rmobile-sysc.c +++ b/drivers/pmdomain/renesas/rmobile-sysc.c @@ -100,7 +100,8 @@ static void rmobile_init_pm_domain(struct rmobile_pm_do= main *rmobile_pd) struct generic_pm_domain *genpd =3D &rmobile_pd->genpd; struct dev_power_governor *gov =3D rmobile_pd->gov; =20 - genpd->flags |=3D GENPD_FLAG_PM_CLK | GENPD_FLAG_ACTIVE_WAKEUP; + genpd->flags |=3D GENPD_FLAG_PM_CLK | GENPD_FLAG_ACTIVE_WAKEUP | + GENPD_FLAG_NO_STAY_ON; genpd->attach_dev =3D cpg_mstp_attach_dev; genpd->detach_dev =3D cpg_mstp_detach_dev; =20 --=20 2.43.0