From nobody Thu Oct 2 23:57:57 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367F72D3EEE for ; Tue, 9 Sep 2025 09:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757411888; cv=none; b=YuUaF7c4AtofsWNxmBtFChuFBvCFWh9l8SKKMQExg+PC5YIyh7SMkleyvIWpMZ3TuH5F1m2H4FZxk+1mjkRpiyBVNQ7MigAnApP710elZtsOoli52kiFEXqclIG8UPfdcwWzBBjeKCOHv2mYcF1DPe8il6oGSYmjIu3VHr92FJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757411888; c=relaxed/simple; bh=kDtTh6feFeUUls9s9EeYPr0volqLeNaDI/7jY9MX8bc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hezl1OBRoMtHyNCycM4XJ9NDG8FYTqDY9rE4WgmEnA7UAUaRU5ZUEHmCj8mOiNCDJwrcC3AdKdzutMgBqvOrW9HcUBKyEbs27MpzSKeb0ll5Gq2iaXLrxqBy5GrB72lsmG9V50HJtgH4Il0ykvjNftrhtgM5XjS1yfvxkC7FLgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qYEL1OZ+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qYEL1OZ+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED6CC4CEF7; Tue, 9 Sep 2025 09:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757411887; bh=kDtTh6feFeUUls9s9EeYPr0volqLeNaDI/7jY9MX8bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qYEL1OZ+a5rE0c9nhkupob9mMjTtrtrOZdz3AmEmVELnfnRzrptQLwlV0Uyc1EkFH xcmoEVK5Fzavzo7IohD5PBKGdMfBwPUAcGK6KlJixzyzhHM1Ka/V6AU/d7zH0dzkTU VIHiOQbHujPNpgHABpRzZ+3E9Q2COAKReh5A3u+a5bcGj2eEajuK+9FK6ITuLI62Rs t67t1No2B91M8nFeKnw3HY4HmjuEK9yaGqXb6bNmjLO6WNHTsoUe35dHWQQlIxuPI+ sZ/c14EWbCpxg2lWKOzdVustr2EyS1XCBDA5d2PIJqeKja4u5/5iXyn2ZmI3M82bc0 2oBmItzano5xQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1uvv6z-000000001Sw-3vY8; Tue, 09 Sep 2025 11:58:05 +0200 From: Johan Hovold To: Matthias Brugger , AngeloGioacchino Del Regno Cc: Roger Lu , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/2] soc: mediatek: mtk-svs: fix device leaks on mt8183 probe failure Date: Tue, 9 Sep 2025 11:56:50 +0200 Message-ID: <20250909095651.5530-2-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250909095651.5530-1-johan@kernel.org> References: <20250909095651.5530-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the references taken by of_find_device_by_node() when looking up the thermal sensor and opp devices during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine") Cc: Roger Lu Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-svs.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 7c349a94b45c..48804e1e5a6c 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2165,6 +2165,13 @@ static struct device *svs_add_device_link(struct svs= _platform *svsp, return dev; } =20 +static void svs_put_device(void *_dev) +{ + struct device *dev =3D _dev; + + put_device(dev); +} + static int svs_mt8192_platform_probe(struct svs_platform *svsp) { struct device *dev; @@ -2216,11 +2223,13 @@ static int svs_mt8183_platform_probe(struct svs_pla= tform *svsp) { struct device *dev; u32 idx; + int ret; =20 dev =3D svs_add_device_link(svsp, "thermal-sensor"); if (IS_ERR(dev)) return dev_err_probe(svsp->dev, PTR_ERR(dev), "failed to get thermal device\n"); + put_device(dev); =20 for (idx =3D 0; idx < svsp->bank_max; idx++) { struct svs_bank *svsb =3D &svsp->banks[idx]; @@ -2230,6 +2239,7 @@ static int svs_mt8183_platform_probe(struct svs_platf= orm *svsp) case SVSB_SWID_CPU_LITTLE: case SVSB_SWID_CPU_BIG: svsb->opp_dev =3D get_cpu_device(bdata->cpu_id); + get_device(svsb->opp_dev); break; case SVSB_SWID_CCI: svsb->opp_dev =3D svs_add_device_link(svsp, "cci"); @@ -2246,6 +2256,11 @@ static int svs_mt8183_platform_probe(struct svs_plat= form *svsp) return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev), "failed to get OPP device for bank %d\n", idx); + + ret =3D devm_add_action_or_reset(svsp->dev, svs_put_device, + svsb->opp_dev); + if (ret) + return ret; } =20 return 0; --=20 2.49.1 From nobody Thu Oct 2 23:57:57 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CCAE2D46A9 for ; Tue, 9 Sep 2025 09:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757411888; cv=none; b=gqSuGSRV+H5VIlfGqIWV5gGS9LDkrVQPXfyui65VafVsb34xn+E3GasPpAN6N1RU3zLl9j6/F8rkkxN5GamBf6HMSYk5paYPwJb4ADEguqG4pOo6vDfcjdDWcojbZeLKjBo11eOGXdPA1T5zUERTfOi7wvGhbbLj2LEo4iooiEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757411888; c=relaxed/simple; bh=3okEo1Cju8Ss53Gs44RL0YJvO36IzhAVTGSex/5UecU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZRWN2Jdud3tmpmJwIzBNKfJUPKWsJSvhft0bDXCziE5jnMMfQ5RpSYurh7aY13jaeHpGpBltbzKu+NIUjoXiNIhANcS9ADr1w2EpNwXAd9VLgDn0ZyRAT+l3gqWLwQiSrkE47kRZJcBLlHw/nhQ5cRW7u55lKCo1M80Wx60G7Nk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GhHz5MJh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GhHz5MJh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15189C4CEFB; Tue, 9 Sep 2025 09:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757411888; bh=3okEo1Cju8Ss53Gs44RL0YJvO36IzhAVTGSex/5UecU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GhHz5MJhCTw0gJNKx5By+cAl3hNw3O0jf1qRXjXWNpSGm1W3E6Agtn3Vzh0x+I16+ DnwdLsC1UJ385LSZ1nJP/f66+GZ1y/4dOM4+TCIXLfcy1rR2BuOVXrgnL3QbcaCI3W h2JmOegWVjPOFT4kzTiXxlY84fb687vahI1wKKu9vbxqK/DKE93A1HjS05YK1uK08w 9OMGQGSZ1ML9QGGU/udWdP91cebY7s4TWb0s29TQ9nFcPvbfo27fB3024/PHMaSJZ4 sulacZjjNz9wAYAuljNw4IpIoaEDuJJqZ8YOjgoXXrLR0WzRWh38sNC0Zt8LhE4kjx 06L5bPKKAEo3A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1uvv70-000000001Sy-03c4; Tue, 09 Sep 2025 11:58:06 +0200 From: Johan Hovold To: Matthias Brugger , AngeloGioacchino Del Regno Cc: Roger Lu , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/2] soc: mediatek: mtk-svs: fix device leaks on mt8192 probe failure Date: Tue, 9 Sep 2025 11:56:51 +0200 Message-ID: <20250909095651.5530-3-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250909095651.5530-1-johan@kernel.org> References: <20250909095651.5530-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the references taken by of_find_device_by_node() when looking up the thermal sensor and opp devices during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver") Cc: Roger Lu Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-svs.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 48804e1e5a6c..f45537546553 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2176,6 +2176,7 @@ static int svs_mt8192_platform_probe(struct svs_platf= orm *svsp) { struct device *dev; u32 idx; + int ret; =20 svsp->rst =3D devm_reset_control_get_optional(svsp->dev, "svs_rst"); if (IS_ERR(svsp->rst)) @@ -2186,6 +2187,7 @@ static int svs_mt8192_platform_probe(struct svs_platf= orm *svsp) if (IS_ERR(dev)) return dev_err_probe(svsp->dev, PTR_ERR(dev), "failed to get lvts device\n"); + put_device(dev); =20 for (idx =3D 0; idx < svsp->bank_max; idx++) { struct svs_bank *svsb =3D &svsp->banks[idx]; @@ -2195,6 +2197,7 @@ static int svs_mt8192_platform_probe(struct svs_platf= orm *svsp) case SVSB_SWID_CPU_LITTLE: case SVSB_SWID_CPU_BIG: svsb->opp_dev =3D get_cpu_device(bdata->cpu_id); + get_device(svsb->opp_dev); break; case SVSB_SWID_CCI: svsb->opp_dev =3D svs_add_device_link(svsp, "cci"); @@ -2214,6 +2217,11 @@ static int svs_mt8192_platform_probe(struct svs_plat= form *svsp) return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev), "failed to get OPP device for bank %d\n", idx); + + ret =3D devm_add_action_or_reset(svsp->dev, svs_put_device, + svsb->opp_dev); + if (ret) + return ret; } =20 return 0; --=20 2.49.1