From nobody Thu Oct 2 23:57:55 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B0DD2EC566; Tue, 9 Sep 2025 06:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757397816; cv=none; b=merOCh7+3cOp+tDfThCovSTKpoiJ6rlPZxWYYxjcQRmMDUYOBJCxCsJxT2w1bDOeiIyXyYINbdeh3NfGG8/tJsrXuB6xZPDJgdhIOTFQQbB3s5YqUD32MShAKERhhXLw01fUq8Y4joPCV8VPZ3cDyRsEl+vEcFMmX5LuL17T4k8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757397816; c=relaxed/simple; bh=NYidWFhDgt/4rQVlgu/c+IOpo3PHLcdSChCn6MGsfy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rzpX3UtAUxh8re9UYbmI+YfnBhOfgtK7t4lbtRWh3omtpxUaC6MGvCekqTiSZfbNAWCf2HlRocPRlrJMgcI3rK2GhoPn/mwNkItUikmCItcRho2SBvvwiKqz1jM3rco8tGqNILpIz2//YZwhI+OS+p8sRARLASl/St/6r/aAXHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=StdSGVtd; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="StdSGVtd" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-24c784130e6so58068935ad.3; Mon, 08 Sep 2025 23:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757397814; x=1758002614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ybb16mUwQT+FBVaymvV+gG0Hd0qAFn+Ahs5rmcoHhyc=; b=StdSGVtdrq+z9xRd+gpA1nnCHxm8SXzUOVuUoalnZBewG/T12urvLnCGxyAS0OvA0L 56pSFidCuzgVnPIi3wxf0SZYNPM5Dhy6jG4grWVDCkBQtPCpE+gmK3g8Ng0Ls514JMEt ldMaczV29gV/2wDd2iqRKNi2tGTsRzmHcHaLm8N43RX8of7xuXoA9/KdXuM4xr68XLHg u5/D5ttzUWDRbf3jpSCZ0T2v23oACwFJudreWatzqvAjBHV7xXVaeBFjtR1evnzGE9ms vdE05ur4q4FDwffYZEHZQYAWlscplSfCg/AAWB8FDcY3gWxuEs/aQtPrOjL8dNknXqhT rPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757397814; x=1758002614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ybb16mUwQT+FBVaymvV+gG0Hd0qAFn+Ahs5rmcoHhyc=; b=BYiE3UCPOUI3yCqnwWhmyO6f8W/6ACb/RwfTZ/PhZXtRG2CVrHmzOCf3HAHSIGu2/o tdTy6Z73v7BHlBRF9nVR/5olu5sD+U+bZh6TeBZw7/1VkYv/YZhe9q8UhdBq+m0twUxy OhKz7VAcV7AQUVI5WR0SmW2sEW7H8aPD+Vx+a3LPdq2z0pYGYaCXMwTwJUram7PKyaeN fUcqO1Ai43nLtpXVD9MzPAPlsPBG5Oco1leIGfxjVTUPuJvOtSnsn47B4UUuyfUpW37f 9Fwn+EBRilBKNqd/+5NtniaXKxiPZ6GgQXCxQNVQfG6Aai27rrOnfa7Zc1CgCn9kHuI+ iLwQ== X-Forwarded-Encrypted: i=1; AJvYcCVGvEEToG78qYyjIu8j+ccrD4tl0/iXf4EOogI7D+D4kBiEXlEt1XPpSMwn+K9ujPjr2Ntqa5fHaLWXag==@vger.kernel.org, AJvYcCW7OKg0712pswPW7rWTRQ32ex8XG7dHX+sOApAYE4GKBf67E2i0Y1bsz63G+cEtyH6v6oTRSzJfQ0WxSs5d@vger.kernel.org X-Gm-Message-State: AOJu0YyPbbTy9FSXunfQh16jwVq12iC4/kmAhr1R7L6i11EeDJqr1z/K M2LKxQkW+PT11BfVCmMqR7CcEOwS25tEiogw8UGYEbbhf3DpFs9tL8dd X-Gm-Gg: ASbGncvbrnlL3bVBrIERVI7WJK7VGTxCBa4ikQM7kyhtEDB7w4RRfLXgEaS8biYAgDs pfAFYvS0cVuwyoMHSc6p5dNz2S9jJok1WA8Ew1JvOnPMLSzzL9TXm8+KWF3QUp3p+RssNcW14wd IVX9854njJyV1uzSz1aOleKJcGJBU29yfu2md0Yb5xRumXpCQ/3w/zNOdE+Z0M6/wOc7S1DNOLw bY4aiMywtIkTdP8cNJ0lzeVNARyGedeTZ41xugo3k1kEyUgXBfW+jpjYbY0dP4d1o8bRcfat6bl a1FpjEJ5h/3mGPkOtIqXL7SUwLOq5Gst9+Pr7ZDra+Kbx0qBNm0txlCzyK3wSuChtpoMeV9oThl ukEmgV61vDfBJhqEvBbHx+GxGh1uc9cMxapMOtxqiwBY6zfXryB37WjINKZ66ExslTDTMnubBM4 zb0V35b6z65x8mtZwL2miTQpU= X-Google-Smtp-Source: AGHT+IEWUWYh4uKLh52T8RIw5gvJl4jnAS8UqIpPPCvXwtb088lnW3/RvdIz0c1aBVLTnnqXeAra+A== X-Received: by 2002:a17:903:1111:b0:251:3d1c:81f4 with SMTP id d9443c01a7336-25173bbbab1mr171289945ad.54.1757397814401; Mon, 08 Sep 2025 23:03:34 -0700 (PDT) Received: from klmny09 (n058152109064.netvigator.com. [58.152.109.64]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903724b94sm298665455ad.35.2025.09.08.23.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 23:03:34 -0700 (PDT) From: Yiming Qian To: dan.carpenter@linaro.org Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, qianym1996@gmail.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Subject: [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Date: Tue, 9 Sep 2025 14:01:29 +0800 Message-ID: <20250909060130.12919-2-qianym1996@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250909060130.12919-1-qianym1996@gmail.com> References: <20250909060130.12919-1-qianym1996@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The use of 'volatile' for memory-mapped I/O pointers is discouraged in the Linux kernel as per Documentation/process/volatile-considered-harmful.rst. This patch removes the unnecessary 'volatile' qualifiers from the lynx_accel struct members, improving code quality and maintainability. Signed-off-by: Yiming Qian Reviewed-by: Dan Carpenter --- drivers/staging/sm750fb/sm750.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm75= 0.h index d7f40efe3..41f1fb390 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -50,9 +50,9 @@ struct init_status { =20 struct lynx_accel { /* base virtual address of DPR registers */ - volatile unsigned char __iomem *dprBase; + unsigned char __iomem *dprBase; /* base virtual address of de data port */ - volatile unsigned char __iomem *dpPortBase; + unsigned char __iomem *dpPortBase; =20 /* function pointers */ void (*de_init)(struct lynx_accel *accel); @@ -128,7 +128,7 @@ struct lynx_cursor { char __iomem *vstart; int offset; /* mmio addr of hw cursor */ - volatile char __iomem *mmio; + char __iomem *mmio; }; =20 struct lynxfb_crtc { --=20 2.51.0 From nobody Thu Oct 2 23:57:55 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 488D6301480; Tue, 9 Sep 2025 06:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757397824; cv=none; b=KU1W0ArxAUQV+vV4l4gba/Lm+hELUWSn4amqkYzhUon2M9JEijjKdLWpG9pDBkpGRc+8Aqmw+akAtd/SEwIbOZJwPgJ2ivtM2Wm9n7wcjXn6anAhIv2h+RvOV81lcwSGpYbE3XhFs3mJ10v6zSl0c/CEZG1ijR2d+Yw8zE0IPMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757397824; c=relaxed/simple; bh=sArw20JjfCGt3Tt3VJw4wcfrb4jGqV5C5oSbve8OqSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DsXUDRa91WLseKweRez1yzLm1gpitIGR8G0c6Mzw18aCIMW30VTKWr3mkQMmXmj1sKk+uOxPEJRDBq132/ojB+u3YpCbfdMcGbO9gFnU9RPsBzK9gEp/UemgS5rMWtW0fFPro7gFWnXseLoKCrSDmZ0UrO5P2PjoHosYg+FJDvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E5cY24hc; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E5cY24hc" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-77246079bc9so6213107b3a.3; Mon, 08 Sep 2025 23:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757397822; x=1758002622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0xUdZKaT5B2ZhU9BDE5iqzR0B7D+QHqptUpqCo3VtYQ=; b=E5cY24hc/a4QMqN1+MEjk/UZh/bpa5igthcrWSG9KXZmiTgByWE+9lt5sG7twuLtLy BKmPwtPawIOWfGW3V0h0ymXGnyPi7MlHY5qFzl6B/wjnY5L2gILGkig9fCxuvOzkZZVU Tvtexg7/O+BumkBLgdCDbPgnU8MpiIu9+t3fL4mn/MPTGzCIkDhFKSgzDN8Hb0x93T09 L41UPcdsSb2zsiMCu+saz8HV+DOAY3ziwUmxzN8IBq52Rfnj/T2ry2SCMtZqjxMvFR+t 7A+Vz5MiKL7WF9pHtX7fGyb+uWpfd1rrbKlPhfIVk+1Xh7INjmSTqONcpcRo5IrB3+VV ZZ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757397822; x=1758002622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0xUdZKaT5B2ZhU9BDE5iqzR0B7D+QHqptUpqCo3VtYQ=; b=GXfETsY9x/Ej7LyjG1NXgweazS+Yp7S8B6HAMnlZZ7hCt7X+S0uT4wcKljgwCDuvVF YRVO1Cs9P5GX4xDNZ26OUjhdCtLl0IsaQO/xycyryDezj3T6ARts/XxMSaOLzPug5x9w iTIFe7357lcvpt+u6a54Bo7FaD6dHDTvcoLen1yCwgy1pjlr0+Ym7NlER37ibGmHo+Mc j1bnKIRm7ySK0J4U24LyxroAFRpMV/Ii3KpZ3M+1dLY0WY6AWwpLglSOX3wdwJfUKBx9 QHURIQkCKpJcEXuPwzplOcCGOMXVlCx1uMoLVQFxN/B2gZtQ4HO06b1TGOuyIHW0iVRT oD7A== X-Forwarded-Encrypted: i=1; AJvYcCV8RGFeomWCKTqjEvTR6xT7VYFR93s6sZhiyQjqYTsnGWHFt3qPuZCrJHI/Zq1NuDrM7Vx1eeMgO2q8sg==@vger.kernel.org, AJvYcCVBE1Y9uJF6xHSl9HAL5BwQVJtlHPqwg972uEJuutflb2DHgatWbxxsDaDTZlXMosL898P3Qf/HuOUQ5gva@vger.kernel.org X-Gm-Message-State: AOJu0YyxFqNJmp/H5urtu2E29iRqqRUoYO3sNTdn+3VTmrXFpBGiTZkz 3eHdyfZWeiVyJVW8TTriTiqZMoR92QYSgsfwRL1Qm/YuPkEpT5l6mbAq X-Gm-Gg: ASbGncsgsmBUIhTXnqd+mGqfhXFaGlTKucDG1X05K9Ogj6gkpfc7m4XiGXwgKz0Eiw9 ma+ec/qu8DTkzHWBq08y+P/Yo/o8eS2ojhAA82Nw2Ckfq56TI8iOd0WHMVY6jGq0jnPy1fa+Kgf b5uPgzDwj2V5Uh5XN8YYye0/vhxut6FeEU4OmvrjkWfbVfYFPs8HFgijVnCR0BD2DttGi4QHFss GUOvEU2lL6W+eAmIZUpL+PQv71IrjFRlqoWlZ86BJFzOehsxh4jCjwh1yG6fTN2cQl9Mw352AP2 XDUefCYLVaA6ZP3fkmib8fa4TYwrIp1xVPWffIyBYQZRp7OoX4/G9IOh4WWQOkcyIsD8adF5gQO u5UV5l0lnaYs2aRkb4Vq4Fnk8gyi1mEFuWPKmdHgYEVQEFld/YB//BrBQbQ8y4p3s8yYMyejmbm H+wBfZh6fZjFAhqbljIesEpg== X-Google-Smtp-Source: AGHT+IELkEZWe7bc0mm4YjG+JrKa1xdnUFM2Qo97pI+DJaZi6VrJk2uBZqkDxhuO3JMPgeL9l6sllw== X-Received: by 2002:a05:6a00:4104:b0:772:750f:4e2a with SMTP id d2e1a72fcca58-7742df53ec5mr13133323b3a.31.1757397822314; Mon, 08 Sep 2025 23:03:42 -0700 (PDT) Received: from klmny09 (awork062176.netvigator.com. [203.198.28.176]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77466156d94sm852148b3a.40.2025.09.08.23.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 23:03:42 -0700 (PDT) From: Yiming Qian To: dan.carpenter@linaro.org Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, qianym1996@gmail.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Subject: [PATCH v2 2/2] staging: sm750fb: rename snake case variables Date: Tue, 9 Sep 2025 14:01:30 +0800 Message-ID: <20250909060130.12919-3-qianym1996@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250909060130.12919-1-qianym1996@gmail.com> References: <20250909060130.12919-1-qianym1996@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replaces CamelCase variable names with snake_case: - dprBase -> dpr_base - dpPortBase -> dp_port_base Signed-off-by: Yiming Qian Reviewed-by: Dan Carpenter --- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm75= 0.h index 41f1fb390..fcb7d586e 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -50,9 +50,9 @@ struct init_status { =20 struct lynx_accel { /* base virtual address of DPR registers */ - unsigned char __iomem *dprBase; + unsigned char __iomem *dpr_base; /* base virtual address of de data port */ - unsigned char __iomem *dpPortBase; + unsigned char __iomem *dp_port_base; =20 /* function pointers */ void (*de_init)(struct lynx_accel *accel); diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 44b9e3fe3..7ac2e7b6e 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -19,17 +19,17 @@ #include "sm750_accel.h" static inline void write_dpr(struct lynx_accel *accel, int offset, u32 reg= Value) { - writel(regValue, accel->dprBase + offset); + writel(regValue, accel->dpr_base + offset); } =20 static inline u32 read_dpr(struct lynx_accel *accel, int offset) { - return readl(accel->dprBase + offset); + return readl(accel->dpr_base + offset); } =20 static inline void write_dpPort(struct lynx_accel *accel, u32 data) { - writel(data, accel->dpPortBase); + writel(data, accel->dp_port_base); } =20 void sm750_hw_de_init(struct lynx_accel *accel) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index 7119b67ef..ce46f240c 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -58,8 +58,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_= dev *pdev) } pr_info("mmio virtual addr =3D %p\n", sm750_dev->pvReg); =20 - sm750_dev->accel.dprBase =3D sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dpPortBase =3D sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dpr_base =3D sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dp_port_base =3D sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; =20 mmio750 =3D sm750_dev->pvReg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); --=20 2.51.0