From nobody Thu Oct 2 22:47:37 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 800873568E8; Tue, 9 Sep 2025 16:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436800; cv=none; b=JLxLv4Z4Qofhu2JsG9dWbtcP3e747kdzZXlzOkLiHSCZO6uhheek9EQ6qJB2x2Px6OM20ibmcIuvdWlQc8+5voGuShaFjQ2NbZ2N+RR9OB5TmgkfpqoLagkMBe2jP3VYzY7qrlMc77tbvHbAtJ5H12dtV6BLBOXm9QBRnb/IlXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436800; c=relaxed/simple; bh=6+2/3QovgIsD4JlR4a5A1Rm/4a3dBDLLqwKHpBSCaLQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IP2trNO/zNhksd5PS8gxqt9NQTGcjSBQEHM3bZJmb2Dl2YAkyodw+VMxZf94/Xi5S14cjoY49iiYUm91gl/17o5zB3yl3gEmVj2ous98YDr9SE9ikoKmYxoRm98cInia/EyBlOFSOauDneZoYaTWpOydLbzrOXHN9hR0mn8vf/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z5V3raWP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z5V3raWP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-45b9c35bc0aso51727965e9.2; Tue, 09 Sep 2025 09:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757436795; x=1758041595; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9UQd77e3mqJwctvsT0cCrXoK5tOPAl8yM2/47dO1l8Y=; b=Z5V3raWPkrBkD+BN1rjbrbQMdcwhvwP/9xQ2QOYgSFf/H7phhrsOaviEx98BjVM4m2 H3zufm6fwTL0M3gfXTAx8dR0HZ1Ou5FGLB3iejuD8owp8nxzKh9K6h9YNPgQGjQGZAk+ AnuC3/ciP43AyxKyHsT2A7DyrlKKNTDDVfMtJVg8dpZQ4XCPj1PiF6Ax1VVUwUlXEoMh B+3y+tTlFAmzuekg5mOIO5xXSbp/B7ZwFtwSCkMr2t4DsTUG+ExpwVQlDlmBw0h5HmBp kdI/OkMs4CUZb5O9Zl1tj5N2GUFrpmzihIUq/oEIU4QG99Zyyox+luS5CJqf7wuV7ZWV zftw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757436795; x=1758041595; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UQd77e3mqJwctvsT0cCrXoK5tOPAl8yM2/47dO1l8Y=; b=q/ldsK3hKSl0213jWaK4B+sj2v9oZECTzm6xQiX0t9eAQOMaTOfpQC4zpvSoBauNJG /RAS4tTGnoIsdaGU/oCELpXKqFE+TKZVCdN0FiXkwi3R9Z4mUe2UFT4GcW44wdOj3+LC Gbf+WMOxGFFGXihe9IgCEks2R3tZqPQp9cdiRISDktO2LOe2GllyjK5I9dXAp7PIJ7RI bkO2QcVtfS59Mzk967GAbYIAvkETgu0za6xCpfLklgZ9pye02FNqaclyhWa8wonEWyJT 7g5Evd0p315QlUDVFQH77bLSdG7gBI3oZ8Gh5AU1hi62k0D5GIOqWIDv2LTqtY/heCbf z/Bg== X-Forwarded-Encrypted: i=1; AJvYcCXXFOr3v6oroyiEzTczDgzocAaUZ3Np/vJGuxhjwT4bVAHyFCh83vS4ySZx1KplybL8PaslO44PjTSh@vger.kernel.org X-Gm-Message-State: AOJu0YxHvKEQ7nyPI5W9c/lMRdhJH+mNUWD8jlUvHdjYf5Qc2jZnuj0W zPjbiBL6d4i5sKnn4XIsGtEAARmn4cXgTEFCKmFaTMHhmx/whDiVxkaT X-Gm-Gg: ASbGncszeURlJgtu7AYbXevWlkd1JjhFnrmAmD2DT2gWQZz+fRCCAzjpw6TB4qgjLaU VYkpD67VFGooqw5GZ8pAj18j13dizKuKsBYX04wnOYmHj9DCZn8tgiJ7lB+tU+jiiHfoHwOp865 vBGK37/turjqxTK4YKJ4nh5IFvpcYj2HGVIGyA9aEPrvM4aSJN4svDfsaKC+IaciZ1x6kQtj5jW tNoHXTW+lnCxX9hg/d3gvhTc7b/GcuckatD3TI/UJD8y8O9wPopJtt5/EicEC6s/JQ9YOyl2fmk tEG1FQU6UrOR9vw/lKofznslloJuTTfESKLpYNE5MS6ubLVPxjDp7SiHBwG+B5tjlCrJiSxFQ6J lpq+4RCvlK7ArtN+G2BrE8eILM3q18cHGZrD58ZnGjEAre+Y2fI82LNnSg9pzseYl X-Google-Smtp-Source: AGHT+IEBLkI3NdqhIMdbgw6CEbb25cxSFg2Jt0MGagVD/8Fx1S5O6G0fOqu3h7Q6mSCGIUyj95cI8g== X-Received: by 2002:a05:600c:1f93:b0:45c:b6b1:29a7 with SMTP id 5b1f17b1804b1-45dddea4195mr153958405e9.16.1757436794311; Tue, 09 Sep 2025 09:53:14 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b9ab7c7dbsm314379085e9.11.2025.09.09.09.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 09:53:13 -0700 (PDT) From: Iker Pedrosa Date: Tue, 09 Sep 2025 18:52:43 +0200 Subject: [PATCH v2 1/3] drm: Add driver for Sitronix ST7920 LCD displays Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250909-st7920-v2-1-409f4890fb5f@gmail.com> References: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> In-Reply-To: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add a new DRM/KMS driver for displays using the Sitronix ST7920 controller connected via the SPI bus. This provides a standard framebuffer interface for these common monochrome LCDs. Signed-off-by: Iker Pedrosa --- drivers/gpu/drm/sitronix/Kconfig | 10 + drivers/gpu/drm/sitronix/Makefile | 1 + drivers/gpu/drm/sitronix/st7920.c | 893 ++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 904 insertions(+) diff --git a/drivers/gpu/drm/sitronix/Kconfig b/drivers/gpu/drm/sitronix/Kc= onfig index 6de7d92d9b74c72746915b945869dba91f161d2b..f14115350069849b668d75188f6= d504d56fa3dda 100644 --- a/drivers/gpu/drm/sitronix/Kconfig +++ b/drivers/gpu/drm/sitronix/Kconfig @@ -40,3 +40,13 @@ config DRM_ST7735R =20 If M is selected the module will be called st7735r. =20 +config DRM_ST7920 + tristate "DRM support for Sitronix ST7920 LCD displays" + depends on DRM && SPI && MMU + select DRM_GEM_SHMEM_HELPER + select DRM_KMS_HELPER + select REGMAP_SPI + help + DRM driver for the ST7920 Sitronix LCD controllers. + + If M is selected the module will be called st7920. diff --git a/drivers/gpu/drm/sitronix/Makefile b/drivers/gpu/drm/sitronix/M= akefile index bd139e5a6995fa026cc635b3c29782473d1efad7..2f064a518121bfee3cca73acd42= 589e8c54cd4d7 100644 --- a/drivers/gpu/drm/sitronix/Makefile +++ b/drivers/gpu/drm/sitronix/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_ST7571_I2C) +=3D st7571-i2c.o obj-$(CONFIG_DRM_ST7586) +=3D st7586.o obj-$(CONFIG_DRM_ST7735R) +=3D st7735r.o +obj-$(CONFIG_DRM_ST7920)) +=3D st7920.o diff --git a/drivers/gpu/drm/sitronix/st7920.c b/drivers/gpu/drm/sitronix/s= t7920.c new file mode 100644 index 0000000000000000000000000000000000000000..8f6677f381bcadc75b536fb73f3= 6655a6204ac15 --- /dev/null +++ b/drivers/gpu/drm/sitronix/st7920.c @@ -0,0 +1,893 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * DRM driver for Sitronix ST7920 LCD displays + * + * Copyright 2025 Iker Pedrosa + * + */ + +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define DRIVER_NAME "sitronix_st7920" +#define DRIVER_DESC "DRM driver for Sitronix ST7920 LCD displays" +#define DRIVER_DATE "20250723" +#define DRIVER_MAJOR 1 +#define DRIVER_MINOR 0 + +/* Display organization */ +#define WIDTH_BYTES 16 +#define HEIGHT_IN_PIXELS 64 +#define BYTES_IN_DISPLAY (WIDTH_BYTES * HEIGHT_IN_PIXELS) +#define BYTES_IN_SEGMENT 2 +#define PIXELS_IN_SEGMENT (BYTES_IN_SEGMENT * 8) + +/* Sync sequence */ +#define SYNC_BITS 0xF8 +#define RW_HIGH 0x04 +#define RS_HIGH 0x02 + +/* Commands */ +#define SET_DISPLAY_ON 0x0C +#define SET_DISPLAY_OFF 0x08 +#define SET_DISPLAY_CLEAR 0x01 +#define SET_BASIC_INSTRUCTION_SET 0x30 +#define SET_EXT_INSTRUCTION_SET 0x34 +#define SET_GRAPHICS_DISPLAY 0x36 +#define SET_GDRAM_ADDRESS 0x80 +#define SET_GDRAM_DATA 0xFF /* Driver internal command */ + +/* Masks */ +#define HIGH_DATA_MASK 0xF0 +#define LOW_DATA_MASK 0x0F +#define TOP_VERTICAL_ADDRESS 0x80 +#define BOTTOM_VERTICAL_ADDRESS 0x60 +#define TOP_HORIZONTAL_ADDRESS 0x00 +#define BOTTOM_HORIZONTAL_ADDRESS 0x80 + +#define CMD_SIZE 35 + +enum st7920_variants { + /* st7920 family */ + ST7920_ID +}; + +struct spi7920_error { + int errno; +}; + +struct st7920_deviceinfo { + u32 default_dclk_div; + u32 default_dclk_frq; + u32 default_width; + u32 default_height; +}; + +struct st7920_device { + struct drm_device drm; + struct device *dev; + struct drm_display_mode mode; + struct drm_plane primary_plane; + struct drm_crtc crtc; + struct drm_encoder encoder; + struct drm_connector connector; + struct spi_device *spi; + + struct regmap *regmap; + + const struct st7920_deviceinfo *device_info; + + u32 height; + u32 width; +}; + +const struct st7920_deviceinfo st7920_variants[] =3D { + [ST7920_ID] =3D { + .default_width =3D 128, + .default_height =3D 64, + } +}; +EXPORT_SYMBOL_NS_GPL(st7920_variants, DRM_ST7920); + +struct st7920_plane_state { + struct drm_shadow_plane_state base; + /* Intermediate buffer to convert pixels from XRGB8888 to HW format */ + u8 *buffer; +}; + +struct st7920_crtc_state { + struct drm_crtc_state base; + /* Buffer to store pixels in HW format and written to the panel */ + u8 *data_array; +}; + +static inline struct st7920_plane_state *to_st7920_plane_state(struct drm_= plane_state *state) +{ + return container_of(state, struct st7920_plane_state, base.base); +} + +static inline struct st7920_crtc_state *to_st7920_crtc_state(struct drm_cr= tc_state *state) +{ + return container_of(state, struct st7920_crtc_state, base); +} + +static inline struct st7920_device *drm_to_st7920(struct drm_device *drm) +{ + return container_of(drm, struct st7920_device, drm); +} + +static int st7920_write_gdram_address(const void *data, u8 *reg) +{ + const u8 y_addr =3D *(const u8 *)data; + bool bottom_screen =3D (y_addr >=3D 32); + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + /* Set vertical address */ + if (!bottom_screen) + reg[i++] =3D TOP_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MASK); + else + reg[i++] =3D BOTTOM_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MAS= K); + + reg[i++] =3D *(uint8_t *)data << 4; + /* Set horizontal address */ + reg[i++] =3D SET_GDRAM_ADDRESS; + if (!bottom_screen) + reg[i++] =3D TOP_HORIZONTAL_ADDRESS; + else + reg[i++] =3D BOTTOM_HORIZONTAL_ADDRESS; + + return i; +} + +static int st7920_write_gdram_data(const void *data, u8 *reg) +{ + const u8 *line_data =3D data; + int i =3D 0, j =3D 0; + + reg[i++] =3D SYNC_BITS | RS_HIGH; + + for (j =3D 0; j < 16; j++) { + reg[i++] =3D line_data[j] & 0xF0; + reg[i++] =3D (line_data[j] << 4) & 0xF0; + } + + return i; +} + +static int st7920_write_others(int cmd, const void *data, u8 *reg) +{ + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + reg[i++] =3D cmd & HIGH_DATA_MASK; + reg[i++] =3D (cmd & LOW_DATA_MASK) << 4; + + return i; +} + +static int st7920_spi_write(struct spi_device *spi, int cmd, const void *d= ata, + int delay_us, struct spi7920_error *err) +{ + u8 reg[CMD_SIZE] =3D {0}; + int size =3D 0; + int ret; + + if (err->errno) + return err->errno; + + /* + * First the sync bits are sent: 11111WS0. + * Where W is the read/write (RW) bit and S is the register/data (RS) bit. + * Then, every 8 bits instruction/data will be separated into 2 groups. + * Higher 4 bits (DB7~DB4) will be placed in the first section followed by + * 4 '0's. And lower 4 bits (DB3~DB0) will be placed in the second section + * followed by 4 '0's. + */ + if (cmd =3D=3D SET_GDRAM_ADDRESS) + size =3D st7920_write_gdram_address(data, reg); + else if (cmd =3D=3D SET_GDRAM_DATA) + size =3D st7920_write_gdram_data(data, reg); + else + size =3D st7920_write_others(cmd, data, reg); + + ret =3D spi_write(spi, reg, size); + if (ret) { + err->errno =3D ret; + return ret; + } + + if (delay_us) + udelay(delay_us); + + return ret; +} + +static const struct regmap_config st7920_spi_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, +}; + +static const struct of_device_id st7920_of_match[] =3D { + /* st7920 family */ + { + .compatible =3D "sitronix,st7920", + .data =3D &st7920_variants[ST7920_ID], + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, st7920_of_match); + +/* + * The SPI core always reports a MODALIAS uevent of the form "spi:", = even + * if the device was registered via OF. This means that the module will no= t be + * auto loaded, unless it contains an alias that matches the MODALIAS repo= rted. + * + * To workaround this issue, add a SPI device ID table. Even when this sho= uld + * not be needed for this driver to match the registered SPI devices. + */ +static const struct spi_device_id st7920_spi_id[] =3D { + /* st7920 family */ + { "st7920", ST7920_ID }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(spi, st7920_spi_id); + +static int st7920_power_on(struct st7920_device *st7920) +{ + struct spi7920_error err =3D {0}; + int ret; + + ret =3D st7920_spi_write(st7920->spi, SET_DISPLAY_ON, NULL, 72, &err); + + return ret; +} + +static int st7920_power_off(struct st7920_device *st7920) +{ + struct spi7920_error err =3D {0}; + int ret; + + ret =3D st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err= ); + ret =3D st7920_spi_write(st7920->spi, SET_DISPLAY_OFF, NULL, 72, &err); + + return ret; +} + +static int st7920_init(struct st7920_device *st7920) +{ + struct spi7920_error err =3D {0}; + int ret; + + ret =3D st7920_spi_write(st7920->spi, SET_BASIC_INSTRUCTION_SET, NULL, 72= , &err); + ret =3D st7920_power_on(st7920); + err.errno =3D ret; + ret =3D st7920_spi_write(st7920->spi, SET_GRAPHICS_DISPLAY, NULL, 72, &er= r); + ret =3D st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err= ); + if (ret < 0) + return ret; + + return 0; +} + +static int st7920_update_rect(struct st7920_device *st7920, + struct drm_rect *rect, u8 *buf, + u8 *data_array) +{ + struct spi7920_error err; + u32 array_idx =3D 0; + int i, j; + int ret; + + /* + * The screen is divided in 64(Y)x8(X) segments and each segment is + * further divided in 2 bytes (D15~D0). + * + * Segment 0x0 is in the top-right corner, while segment 63x15 is in the + * bottom-left. They would be displayed in the screen in the following wa= y: + * 0x0 0x1 0x2 ... 0x15 + * 1x0 1x1 1x2 ... 1x15 + * ... + * 63x0 63x1 63x2 ... 63x15 + * + * The data in each byte is big endian. + */ + + for (i =3D 0; i < HEIGHT_IN_PIXELS; i++) { + u8 *line_start =3D buf + (i * WIDTH_BYTES); + u8 line_buffer[WIDTH_BYTES]; + + for (j =3D 0; j < WIDTH_BYTES; j++) { + line_buffer[j] =3D bitrev8(line_start[j]); + data_array[array_idx++] =3D line_buffer[j]; + } + + ret =3D st7920_spi_write(st7920->spi, SET_GDRAM_ADDRESS, &i, 72, &err); + ret =3D st7920_spi_write(st7920->spi, SET_GDRAM_DATA, line_buffer, 72, &= err); + if (ret < 0) + return ret; + } + + return ret; +} + +static void st7920_clear_screen(struct st7920_device *st7920, u8 *data_arr= ay) +{ + struct spi7920_error err; + + memset(data_array, 0, BYTES_IN_DISPLAY); + + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err); +} + +static int st7920_fb_blit_rect(struct drm_framebuffer *fb, + const struct iosys_map *vmap, + struct drm_rect *rect, + u8 *buf, u8 *data_array, + struct drm_format_conv_state *fmtcnv_state) +{ + struct st7920_device *st7920 =3D drm_to_st7920(fb->dev); + struct iosys_map dst; + unsigned int dst_pitch; + + /* Align y to display page boundaries */ + rect->y1 =3D round_down(rect->y1, PIXELS_IN_SEGMENT); + rect->y2 =3D min_t(unsigned int, round_up(rect->y2, PIXELS_IN_SEGMENT), s= t7920->height); + + dst_pitch =3D DIV_ROUND_UP(drm_rect_width(rect), 8); + + iosys_map_set_vaddr(&dst, buf); + drm_fb_xrgb8888_to_mono(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); + + st7920_update_rect(st7920, rect, buf, data_array); + + return 0; +} + +static int st7920_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(plane_s= tate); + struct drm_shadow_plane_state *shadow_plane_state =3D &st7920_state->base; + struct drm_crtc *crtc =3D plane_state->crtc; + struct drm_crtc_state *crtc_state =3D NULL; + const struct drm_format_info *fi; + unsigned int pitch; + int ret; + + if (crtc) + crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); + + ret =3D drm_atomic_helper_check_plane_state(plane_state, crtc_state, + DRM_PLANE_NO_SCALING, + DRM_PLANE_NO_SCALING, + false, false); + if (ret) + return ret; + else if (!plane_state->visible) + return 0; + + fi =3D drm_format_info(DRM_FORMAT_R1); + if (!fi) + return -EINVAL; + + pitch =3D drm_format_info_min_pitch(fi, 0, st7920->width); + + if (plane_state->fb->format !=3D fi) { + void *buf; + + /* format conversion necessary; reserve buffer */ + buf =3D drm_format_conv_state_reserve(&shadow_plane_state->fmtcnv_state, + pitch, GFP_KERNEL); + if (!buf) + return -ENOMEM; + } + + st7920_state->buffer =3D kcalloc(pitch, st7920->height, GFP_KERNEL); + if (!st7920_state->buffer) + return -ENOMEM; + + return 0; +} + +static void st7920_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_stat= e(state, plane); + struct drm_shadow_plane_state *shadow_plane_state =3D to_drm_shadow_plane= _state(plane_state); + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , plane_state->crtc); + struct st7920_crtc_state *st7920_crtc_state =3D to_st7920_crtc_state(crt= c_state); + struct st7920_plane_state *st7920_plane_state =3D to_st7920_plane_state(p= lane_state); + struct drm_framebuffer *fb =3D plane_state->fb; + struct drm_atomic_helper_damage_iter iter; + struct drm_device *drm =3D plane->dev; + struct drm_rect dst_clip; + struct drm_rect damage; + int ret =3D 0; + int idx; + + if (!drm_dev_enter(drm, &idx)) + return; + + ret =3D drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); + if (ret) + return; + + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); + drm_atomic_for_each_plane_damage(&iter, &damage) { + dst_clip =3D plane_state->dst; + + if (!drm_rect_intersect(&dst_clip, &damage)) + continue; + + st7920_fb_blit_rect(fb, &shadow_plane_state->data[0], &dst_clip, + st7920_plane_state->buffer, + st7920_crtc_state->data_array, + &shadow_plane_state->fmtcnv_state); + } + + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + + drm_dev_exit(idx); +} + +static void st7920_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_crtc_state *crtc_state; + struct st7920_crtc_state *st7920_crtc_state; + int idx; + + if (!plane_state->crtc) + return; + + crtc_state =3D drm_atomic_get_new_crtc_state(state, plane_state->crtc); + st7920_crtc_state =3D to_st7920_crtc_state(crtc_state); + + if (!drm_dev_enter(drm, &idx)) + return; + + st7920_clear_screen(st7920, st7920_crtc_state->data_array); + + drm_dev_exit(idx); +} + +/* Called during init to allocate the plane's atomic state. */ +static void st7920_primary_plane_reset(struct drm_plane *plane) +{ + struct st7920_plane_state *st7920_state; + + drm_WARN_ON_ONCE(plane->dev, plane->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_gem_reset_shadow_plane(plane, &st7920_state->base); +} + +static struct drm_plane_state *st7920_primary_plane_duplicate_state(struct= drm_plane *plane) +{ + struct drm_shadow_plane_state *new_shadow_plane_state; + struct st7920_plane_state *old_st7920_state; + struct st7920_plane_state *st7920_state; + + if (drm_WARN_ON_ONCE(plane->dev, !plane->state)) + return NULL; + + old_st7920_state =3D to_st7920_plane_state(plane->state); + st7920_state =3D kmemdup(old_st7920_state, sizeof(*st7920_state), GFP_KER= NEL); + if (!st7920_state) + return NULL; + + /* The buffer is not duplicated and is allocated in .atomic_check */ + st7920_state->buffer =3D NULL; + + new_shadow_plane_state =3D &st7920_state->base; + + __drm_gem_duplicate_shadow_plane_state(plane, new_shadow_plane_state); + + return &new_shadow_plane_state->base; +} + +static void st7920_primary_plane_destroy_state(struct drm_plane *plane, + struct drm_plane_state *state) +{ + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(state); + + kfree(st7920_state->buffer); + + __drm_gem_destroy_shadow_plane_state(&st7920_state->base); + + kfree(st7920_state); +} + +static const struct drm_plane_helper_funcs st7920_primary_plane_helper_fun= cs =3D { + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, + .atomic_check =3D st7920_primary_plane_atomic_check, + .atomic_update =3D st7920_primary_plane_atomic_update, + .atomic_disable =3D st7920_primary_plane_atomic_disable, +}; + +static const struct drm_plane_funcs st7920_primary_plane_funcs =3D { + .update_plane =3D drm_atomic_helper_update_plane, + .disable_plane =3D drm_atomic_helper_disable_plane, + .reset =3D st7920_primary_plane_reset, + .atomic_duplicate_state =3D st7920_primary_plane_duplicate_state, + .atomic_destroy_state =3D st7920_primary_plane_destroy_state, + .destroy =3D drm_plane_cleanup, +}; + +static enum drm_mode_status st7920_crtc_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct st7920_device *st7920 =3D drm_to_st7920(crtc->dev); + + return drm_crtc_helper_mode_valid_fixed(crtc, mode, &st7920->mode); +} + +static int st7920_crtc_atomic_check(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , crtc); + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(crtc_stat= e); + int ret; + + ret =3D drm_crtc_helper_atomic_check(crtc, state); + if (ret) + return ret; + + st7920_state->data_array =3D kmalloc(BYTES_IN_DISPLAY, GFP_KERNEL); + if (!st7920_state->data_array) + return -ENOMEM; + + return 0; +} + +/* Called during init to allocate the CRTC's atomic state. */ +static void st7920_crtc_reset(struct drm_crtc *crtc) +{ + struct st7920_crtc_state *st7920_state; + + drm_WARN_ON_ONCE(crtc->dev, crtc->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_atomic_helper_crtc_reset(crtc, &st7920_state->base); +} + +static struct drm_crtc_state *st7920_crtc_duplicate_state(struct drm_crtc = *crtc) +{ + struct st7920_crtc_state *old_st7920_state; + struct st7920_crtc_state *st7920_state; + + if (drm_WARN_ON_ONCE(crtc->dev, !crtc->state)) + return NULL; + + old_st7920_state =3D to_st7920_crtc_state(crtc->state); + st7920_state =3D kmemdup(old_st7920_state, sizeof(*st7920_state), GFP_KER= NEL); + if (!st7920_state) + return NULL; + + /* The buffer is not duplicated and is allocated in .atomic_check */ + st7920_state->data_array =3D NULL; + + __drm_atomic_helper_crtc_duplicate_state(crtc, &st7920_state->base); + + return &st7920_state->base; +} + +static void st7920_crtc_destroy_state(struct drm_crtc *crtc, + struct drm_crtc_state *state) +{ + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(state); + + kfree(st7920_state->data_array); + + __drm_atomic_helper_crtc_destroy_state(state); + + kfree(st7920_state); +} + +/* + * The CRTC is always enabled. Screen updates are performed by + * the primary plane's atomic_update function. Disabling clears + * the screen in the primary plane's atomic_disable function. + */ +static const struct drm_crtc_helper_funcs st7920_crtc_helper_funcs =3D { + .mode_valid =3D st7920_crtc_mode_valid, + .atomic_check =3D st7920_crtc_atomic_check, +}; + +static const struct drm_crtc_funcs st7920_crtc_funcs =3D { + .reset =3D st7920_crtc_reset, + .destroy =3D drm_crtc_cleanup, + .set_config =3D drm_atomic_helper_set_config, + .page_flip =3D drm_atomic_helper_page_flip, + .atomic_duplicate_state =3D st7920_crtc_duplicate_state, + .atomic_destroy_state =3D st7920_crtc_destroy_state, +}; + +static void st7920_encoder_atomic_enable(struct drm_encoder *encoder, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D encoder->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + int ret; + + ret =3D st7920_init(st7920); + if (ret) + goto power_off; + + return; + +power_off: + st7920_power_off(st7920); +} + +static void st7920_encoder_atomic_disable(struct drm_encoder *encoder, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D encoder->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + + st7920_power_off(st7920); +} + +static const struct drm_encoder_helper_funcs st7920_encoder_helper_funcs = =3D { + .atomic_enable =3D st7920_encoder_atomic_enable, + .atomic_disable =3D st7920_encoder_atomic_disable, +}; + +static const struct drm_encoder_funcs st7920_encoder_funcs =3D { + .destroy =3D drm_encoder_cleanup, +}; + +static int st7920_connector_get_modes(struct drm_connector *connector) +{ + struct st7920_device *st7920 =3D drm_to_st7920(connector->dev); + + return drm_connector_helper_get_modes_fixed(connector, &st7920->mode); +} + +static const struct drm_connector_helper_funcs st7920_connector_helper_fun= cs =3D { + .get_modes =3D st7920_connector_get_modes, +}; + +static const struct drm_connector_funcs st7920_connector_funcs =3D { + .reset =3D drm_atomic_helper_connector_reset, + .fill_modes =3D drm_helper_probe_single_connector_modes, + .destroy =3D drm_connector_cleanup, + .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, +}; + +static const struct drm_mode_config_funcs st7920_mode_config_funcs =3D { + .fb_create =3D drm_gem_fb_create_with_dirty, + .atomic_check =3D drm_atomic_helper_check, + .atomic_commit =3D drm_atomic_helper_commit, +}; + +static const uint32_t st7920_formats[] =3D { + DRM_FORMAT_XRGB8888, +}; + +DEFINE_DRM_GEM_FOPS(st7920_fops); + +static const struct drm_driver st7920_drm_driver =3D { + DRM_GEM_SHMEM_DRIVER_OPS, + DRM_FBDEV_SHMEM_DRIVER_OPS, + .name =3D DRIVER_NAME, + .desc =3D DRIVER_DESC, + .date =3D DRIVER_DATE, + .major =3D DRIVER_MAJOR, + .minor =3D DRIVER_MINOR, + .driver_features =3D DRIVER_ATOMIC | DRIVER_GEM | DRIVER_MODESET, + .fops =3D &st7920_fops, +}; + +static int st7920_init_modeset(struct st7920_device *st7920) +{ + struct drm_display_mode *mode =3D &st7920->mode; + struct device *dev =3D st7920->dev; + struct drm_device *drm =3D &st7920->drm; + unsigned long max_width, max_height; + struct drm_plane *primary_plane; + struct drm_crtc *crtc; + struct drm_encoder *encoder; + struct drm_connector *connector; + int ret; + + /* + * Modesetting + */ + + ret =3D drmm_mode_config_init(drm); + if (ret) { + dev_err(dev, "DRM mode config init failed: %d\n", ret); + return ret; + } + + mode->type =3D DRM_MODE_TYPE_DRIVER; + mode->clock =3D 1; + mode->hdisplay =3D st7920->device_info->default_width; + mode->htotal =3D st7920->device_info->default_width; + mode->hsync_start =3D st7920->device_info->default_width; + mode->hsync_end =3D st7920->device_info->default_width; + mode->vdisplay =3D st7920->device_info->default_height; + mode->vtotal =3D st7920->device_info->default_height; + mode->vsync_start =3D st7920->device_info->default_height; + mode->vsync_end =3D st7920->device_info->default_height; + mode->width_mm =3D 27; + mode->height_mm =3D 27; + + max_width =3D max_t(unsigned long, mode->hdisplay, DRM_SHADOW_PLANE_MAX_W= IDTH); + max_height =3D max_t(unsigned long, mode->vdisplay, DRM_SHADOW_PLANE_MAX_= HEIGHT); + + drm->mode_config.min_width =3D mode->hdisplay; + drm->mode_config.max_width =3D max_width; + drm->mode_config.min_height =3D mode->vdisplay; + drm->mode_config.max_height =3D max_height; + drm->mode_config.preferred_depth =3D 24; + drm->mode_config.funcs =3D &st7920_mode_config_funcs; + + /* Primary plane */ + + primary_plane =3D &st7920->primary_plane; + ret =3D drm_universal_plane_init(drm, primary_plane, 0, &st7920_primary_p= lane_funcs, + st7920_formats, ARRAY_SIZE(st7920_formats), + NULL, DRM_PLANE_TYPE_PRIMARY, NULL); + if (ret) { + dev_err(dev, "DRM primary plane init failed: %d\n", ret); + return ret; + } + + drm_plane_helper_add(primary_plane, &st7920_primary_plane_helper_funcs); + + drm_plane_enable_fb_damage_clips(primary_plane); + + /* CRTC */ + + crtc =3D &st7920->crtc; + ret =3D drm_crtc_init_with_planes(drm, crtc, primary_plane, NULL, + &st7920_crtc_funcs, NULL); + if (ret) { + dev_err(dev, "DRM crtc init failed: %d\n", ret); + return ret; + } + + drm_crtc_helper_add(crtc, &st7920_crtc_helper_funcs); + + /* Encoder */ + + encoder =3D &st7920->encoder; + ret =3D drm_encoder_init(drm, encoder, &st7920_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + dev_err(dev, "DRM encoder init failed: %d\n", ret); + return ret; + } + + drm_encoder_helper_add(encoder, &st7920_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(crtc); + + /* Connector */ + + connector =3D &st7920->connector; + ret =3D drm_connector_init(drm, connector, &st7920_connector_funcs, + DRM_MODE_CONNECTOR_Unknown); + if (ret) { + dev_err(dev, "DRM connector init failed: %d\n", ret); + return ret; + } + + drm_connector_helper_add(connector, &st7920_connector_helper_funcs); + + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) { + dev_err(dev, "DRM attach connector to encoder failed: %d\n", ret); + return ret; + } + + drm_mode_config_reset(drm); + + return 0; +} + +static int st7920_probe(struct spi_device *spi) +{ + struct st7920_device *st7920; + struct regmap *regmap; + struct device *dev =3D &spi->dev; + struct drm_device *drm; + int ret; + + regmap =3D devm_regmap_init_spi(spi, &st7920_spi_regmap_config); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + st7920 =3D devm_drm_dev_alloc(dev, &st7920_drm_driver, + struct st7920_device, drm); + if (IS_ERR(st7920)) + return PTR_ERR(st7920); + + drm =3D &st7920->drm; + + st7920->dev =3D dev; + st7920->regmap =3D regmap; + st7920->spi =3D spi; + st7920->device_info =3D device_get_match_data(dev); + st7920->width =3D st7920->device_info->default_width; + st7920->height =3D st7920->device_info->default_height; + + spi_set_drvdata(spi, st7920); + + ret =3D st7920_init_modeset(st7920); + if (ret) + return ret; + + ret =3D drm_dev_register(drm, 0); + if (ret) + return dev_err_probe(dev, ret, "DRM device register failed\n"); + + drm_client_setup(drm, NULL); + + return 0; +} + +static void st7920_remove(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_dev_unplug(&st7920->drm); + drm_atomic_helper_shutdown(&st7920->drm); +} + +static void st7920_shutdown(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_atomic_helper_shutdown(&st7920->drm); +} + +static struct spi_driver st7920_spi_driver =3D { + .driver =3D { + .name =3D DRIVER_NAME, + .of_match_table =3D st7920_of_match, + }, + .id_table =3D st7920_spi_id, + .probe =3D st7920_probe, + .remove =3D st7920_remove, + .shutdown =3D st7920_shutdown, +}; +module_spi_driver(st7920_spi_driver); + +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_AUTHOR("Iker Pedrosa "); +MODULE_LICENSE("GPL v2"); --=20 2.51.0 From nobody Thu Oct 2 22:47:37 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D341135336F; Tue, 9 Sep 2025 16:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436799; cv=none; b=A3Qf4FEPfUFZLW4NdVCWUx3jgUJE8d5BNQVr/BE5axrMhGDqPnllVJcTPH7ao1tYCDR8T4NAVKYJcoicnT4zFlOcghxD0juodnMRIPCHJFLQj4CsSLrFiHZlVdExPyKQPbPk6eAlZfNtCIKOTqjTBvN2g0u+Bm4bNoVKIG39mwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436799; c=relaxed/simple; bh=HCCjD6YjsAHEKZx/rtQO9mzRxNlQd1YVX0+oejbMm+I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TGDS/ayaY4VV0WN4Tj/7mDCVHQRX046Z+AmheOX47bfQdaD3ajemNTC+TyMWV5OWgLtN2mi1EW8sgE81HM861FkjmsEDt5XxWIDvbpbHVesCnjo0vMndHjTZGUuGaI81ydvvsu+fnE1dvM/8lqB5escBBrE4s2xihyPvdFy3Nvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lLPxo9J7; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lLPxo9J7" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-45b9853e630so54142855e9.0; Tue, 09 Sep 2025 09:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757436796; x=1758041596; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=p94vhBpn6I1H1gadXz17+U2dyfmeO5CYxkWEWa6pquY=; b=lLPxo9J7027/FZfBQU0h6ksGDlFu36NucEoFrrICxot3ZiJ6ZuujMH1cQaoGcepeJN rk06z/see/MbGiImMqXRTjtR/4U1GCNJ/u4ifcUi9Vc7Ze9VgIdSdAuzFbD3W0Qutudp RWMs+yNt3XX9mBR0hPStxgVmhGrlfVCqRKFl6JT//Zyxtb1M8kRmXO5jZc3z09pjLRzc fTy2eSG57aKvXcah8DDtBb/PdosDp/ndC+HsYoXx2T+P+ObkA36kFtusAc2p+mW44+D6 qJM0gGpbzYMFz7tWKSIh3+oJj0z/ADFoTDQbdatPpEvwUlJAcMC2ZSwE6HPvRJ5kN2yh K2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757436796; x=1758041596; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p94vhBpn6I1H1gadXz17+U2dyfmeO5CYxkWEWa6pquY=; b=RWwU1UULrUfvz5g/20xIfT39yjcDEM2GDayYDLAnc6AGW6hU334a0XPHgCtdk7/eGz QX5VhlXF7dJlqKBnm4ij5IsVvctg9cbNgWgty02jwrC0FhthsGFD/518bQyS1110hK7D 0xkxVpoKLyk1KqyzmS64Q64b4i+M3wlmJpEbSfdfn1nJ+ORiM3ikFwlsl++4jkC0Lkf9 1uFhs4+xWs/DtVIYYNF1koDVG/PnuFq9kY4fPmbsBCfjq8su+GUTLEX3hDW78SFgC9/B UtvTCRZah7o3TV4Gmvd7e0jT7FJ4Z+tpOOaarQm9bZ54WShbj6/2TrECuS+8BwceIr2W Si0w== X-Forwarded-Encrypted: i=1; AJvYcCVp4nIw0qFlMyNcXE7QLzKwaYQOms/K8IhzwQcYMpGcQF1fLEatQCU2jMZVSs3ho8lDzHlsfzJR1dSa@vger.kernel.org X-Gm-Message-State: AOJu0YzYLdEaaLDGBPA8sGvufwqubqkiPVVX+xSlslp2QkTNUeEs8C7f ZQCPC0Aqc7ZW2nTMPB61k979Ng03FMXgmYaekAphI3JHy67/+ZSTxLZO X-Gm-Gg: ASbGncvPPWEvCE3JV2TR9hcMmkF6HZCQqt9EeDfPzV0nEZ7PJnO0EhowWK5hmDkqzFM G1o25SKgOSMMifvlgk7poa6LZqS00Hn6Q9fX8RHG6vIX67cwUP+hr11Cq7hxoZS7BEWNiBSv6Ye HrvTRZ2EeJ9+Rcj6N2qdpv4IczNccECpzMDkAa/33kwDUy3WCqbP/98lOINHfWe0Ozh1m1dk93+ bxqCHl55SkkyovG6dPXu+PvwhFLhbLiI2mqkOjzHWPsi3dtBfS5V1ZWfFIhfGvXEtr3LgjkVUPC C6PLe2wIYNVRbwD9Oe/J+5oFHgu7RNP+xufzs4JuMZwjBt9yUUsyhnk7mnf8+98c7LwuvOeOoyQ GhgK70doeoPVkYROFtCSV64ilWCDSXT8YlHugF1VooUATfRXfPZKhTpYH5kySBf5TdCbuvGIik6 s= X-Google-Smtp-Source: AGHT+IEF+jsF9Ep1sxBSIPUi8j40DLrBGK1qvHYFTtZX1Y9LF80IpzZJEcXp+w18dvnss1B8AiANuw== X-Received: by 2002:a05:600c:4fcd:b0:45b:8822:d6c4 with SMTP id 5b1f17b1804b1-45dddee600dmr125529755e9.33.1757436795745; Tue, 09 Sep 2025 09:53:15 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b9ab7c7dbsm314379085e9.11.2025.09.09.09.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 09:53:15 -0700 (PDT) From: Iker Pedrosa Date: Tue, 09 Sep 2025 18:52:44 +0200 Subject: [PATCH v2 2/3] dt-bindings: display: sitronix,st7920: Add DT schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250909-st7920-v2-2-409f4890fb5f@gmail.com> References: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> In-Reply-To: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add binding for Sitronix ST7920 display. Signed-off-by: Iker Pedrosa --- .../bindings/display/sitronix,st7920.yaml | 52 ++++++++++++++++++= ++++ 1 file changed, 52 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7920.yaml= b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml new file mode 100644 index 0000000000000000000000000000000000000000..f08869c48a634cdb2a9e6fb33a0= 510cd1a407970 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sitronix,st7920.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sitronix ST7920 LCD Display Controllers + +maintainers: + - Iker Pedrosa + +description: + The Sitronix ST7920 is a controller for monochrome dot-matrix graphical = LCDs, + most commonly used for 128x64 pixel displays. + +properties: + compatible: + const: sitronix,st7920 + + reg: + description: The chip-select number for the device on the SPI bus. + maxItems: 1 + + spi-max-frequency: + maximum: 600000 + +required: + - compatible + - reg + - spi-max-frequency + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + // Example: ST7920 connected to an SPI bus + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + display@0 { + compatible =3D "sitronix,st7920"; + reg =3D <0>; + spi-max-frequency =3D <600000>; + spi-cs-high; + }; + }; --=20 2.51.0 From nobody Thu Oct 2 22:47:37 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA0CA35A29B; Tue, 9 Sep 2025 16:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436801; cv=none; b=s4Kx1/GRa5tCmfXfGWit2GJx+fWwu5mFgrcq0QkRVJlRZJfX9p7McWy4JIrXPW286fNLOV6eg9PSaHLMd/Bf1wrKPDFNRWZrpDxWPNF4+P4D3svdVdX+x02z2SfPZSn1TQ8QHnelRWyS1vdjrMG5GD4KoZtO8k7MFK1Gy1uKUHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757436801; c=relaxed/simple; bh=3ngI3i1BG0C9azbqBN/4q7nJ2yCSJxmqD7ABvsTPKbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PEQeyJ7M15UoSGbUTveEjPt+FezeANq1MquK3MyyNvOoAq1t/Qogk0dtPyuWaV2jELuQfjjzct8j2vHw+A4EaqXFq5j+3hUe8drxZFUtti6ftygBPv2wDPv3R9SgSFLX2f+1bnmQP4m8FJp1g/BMK5d1JtJdfzdgiyWS/ivw3UQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gCne//a5; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gCne//a5" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45cb5492350so38355555e9.1; Tue, 09 Sep 2025 09:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757436797; x=1758041597; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m97kyP3HTS70kAnw3EPRct0ZUapkHpzYxU+r81cO+AM=; b=gCne//a52umQfl2IhSEp9Ub/EuZXvWGbCx89sxNQXS5gqwWCkJNt0sRKHAN5i5YpaW z2WMD+5laz6VAT+kLM3UXDyng0AbUutETNAdOQ3vYSnneTzniLNwaMR8ZH2gbuQgFU3X NHbziM05Si4elmBkufG399UfqWQfPC88Schu98Qhu7KQnf82aWLE0p3jJXqAtPFIS6Qc cKeziDHH8F+JF/2L68doqbNB4eibFh1HEdh/DyBwg6HuOThvNv2uMxOY+frLuQ6vlGy7 4w++SIDysdaJA2MsnkH4MyW1VGovYFWiC9y0gV9s/IlhyPPmC3w4/M5PaQy4wVtVxRO2 LN5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757436797; x=1758041597; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m97kyP3HTS70kAnw3EPRct0ZUapkHpzYxU+r81cO+AM=; b=wbdVvycSH8ntaqVjg+DzFVrcddbEgrRTI+jarB8bM5Kd93QXjQjWgoTtGBODAhLguz yFNcIkEi2JF0hf2UnIdXj5UaMkNvgfNB3gHU30LmdVZvjylerywbPAqL9lbhypiuGq3E MJTaLXDUKu0//NS4ufqmi4/zX6wIRdgtKMs3CrjqhnpqK8q/Xa809X1cfHBZ4aLuta6v UPsYEca+nOTVXKgAHnb8KJz8Q6QdurkSaIGwlkqx7bUB9EeDCLtWvHTe0SPZ6HwMG/0E OAfBCA4f36FUY97hj5pi3syPxzCPO6p+yT0EQajih+xOufhRD4hEn9TbqobMX9nknMmx Krlg== X-Forwarded-Encrypted: i=1; AJvYcCViMkOczbVkLk5xdvEWS3CLobDKbpZ6LEWme05E6xRXdqRnkPbYQrotT+PE8WAAzWacKSg23UuZ0Egb@vger.kernel.org X-Gm-Message-State: AOJu0Yy1WykScCAuTO5hlaYp35l+JZuWhiTGHGs0L21XvHP66+9IvMbi nI91weo7EQQug8FpurPTDE+uIGU3wHUsvQ6duKWoRQgqP+/MjcBnJ/PK X-Gm-Gg: ASbGncuo/46BUvpSjADatvhOgmIMJGiTPwNf1NVRmBGuksh0/1hfU3rkHecobzxwFfJ 7SgIAm8KhzUqXio0nNTaed2bOLgiRxqRCg9eMw8f0CEm3tiW1yfB9juk5ws9GFJWroXIMNaRYw1 yEVMpyWWIFIM/C4/4BQKyyDv+bu2VcPpuwHjh+7/ii99tjfmKk4n5ChH0Tnpxe4U1oBkuNIYRB2 hxfK/Q4Lgvu5yNP+mjc4tSEwSQfAxoRp/TNoZS6lFAFU3TwkMNi42Boh5AWkT31WlstPfdGbAZl F8q1yDcL2H1FkdtyUyZReIRIMz4AZNRKOSGMYDUV6A8tFECUbCshM7fkYDzOk0c4h3Xy2tv+PYE t3hTiYjmQzrqCpSo9HsHCrJWrcbIpQmqHm2ON1hsLW1fFg6h6ZWKMBkg+qUCHdmjY X-Google-Smtp-Source: AGHT+IEqBRl9J8D3sxXoUKww47Xb7qU0+nNIVTgF1/LB1fSoYc69LlXxBvnR0fTOpf1FSeIqKxSZEQ== X-Received: by 2002:a05:600c:a08c:b0:45b:8a0e:cda9 with SMTP id 5b1f17b1804b1-45dddf22ecdmr100621285e9.2.1757436796956; Tue, 09 Sep 2025 09:53:16 -0700 (PDT) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.138.131]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b9ab7c7dbsm314379085e9.11.2025.09.09.09.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 09:53:16 -0700 (PDT) From: Iker Pedrosa Date: Tue, 09 Sep 2025 18:52:45 +0200 Subject: [PATCH v2 3/3] MAINTAINERS: Add entry for Sitronix ST7920 driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250909-st7920-v2-3-409f4890fb5f@gmail.com> References: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> In-Reply-To: <20250909-st7920-v2-0-409f4890fb5f@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add Iker as ST7920 driver maintainer. Signed-off-by: Iker Pedrosa --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5ddf37f0acc960039422ef988cadfa7176972fc5..79b8a277e38b55ebcff05450d6c= 565c0d87c6b51 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7861,6 +7861,13 @@ T: git https://gitlab.freedesktop.org/drm/misc/kerne= l.git F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml F: drivers/gpu/drm/sitronix/st7735r.c =20 +DRM DRIVER FOR SITRONIX ST7920 LCD DISPLAYS +M: Iker Pedrosa +S: Maintained +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git +F: Documentation/devicetree/bindings/display/sitronix,st7920.yaml +F: drivers/gpu/drm/sitronix/st7920.c + DRM DRIVER FOR SOLOMON SSD130X OLED DISPLAYS M: Javier Martinez Canillas S: Maintained --=20 2.51.0