From nobody Fri Oct 3 01:10:47 2025 Received: from mail-106112.protonmail.ch (mail-106112.protonmail.ch [79.135.106.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616123081A5; Tue, 9 Sep 2025 07:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.112 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757401902; cv=none; b=msJcIxrfgDMEPBc3qTD/5ejuAVE6Cxyyq3D4JQ7ghIwtJYXbbCzG+1iCPGMAZxKdi2Hl3NR2MHUAVnNlyIVk0W80QoCap+5kh7+S726WXji8n19CsXipCbgWWtr+7OQh8OuBQsbyT+Yeoqjt1Gw2QVd3Q5E0yTwI6Mk51m5nIa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757401902; c=relaxed/simple; bh=gAaZ1TanExUpKz8pHuUzLT9Wce3FYd1z99y3OHAO5jE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eUAtheQoDZezVGaMc32oRS83P1aUMtn8u/AQaFKhTpGIMF8xRzRJ46icr47Q8XdC5caBs7E2m8Nz5H3f04HY+gRm0Eljcd0s6GcCDuYRGTIrsL82+1pvZYMZTiFewBO1izzUx4AGM5VKZYmLxX6njbE+I1QRCa7hD5OG1FxOK2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=nsR9hqY2; arc=none smtp.client-ip=79.135.106.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="nsR9hqY2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail2; t=1757401892; x=1757661092; bh=O7HQJC6D4zuz6nZXJL5xFKWOz3c9FOfKqraNYIM6U/4=; h=From:Date:Subject:Message-Id:References:In-Reply-To:To:Cc:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=nsR9hqY2cLbqQQvCPJfUeZ7AjiFsDIXQyRr2wiw9yPP0slzq3gc7gTdPyIYm3+Ptn TupKxhQjvo8wUWzAhcOSTCZ0hriUKmlL+3UlCbW/owItPR5GvTD69szc8glWe5jAvO bRKAs4jaIb3pxgkXDKd8NfvfKtj8uSMV560BVam9vO8Mj3c+BknNWBdzU+/M/9AtOs /6LOAgZGx6jGE7fVoZm0c3j1wgUPBnOLv/F6Lc4fYYUl0z5HB6YSF0XD+a06g/PWuR ozmm2V/dYqaY/h4d3x+U4PmLg84FgvG+R+S6k9/ve8+OPEV1RF9zF9tkdQTpo9fsRY S9jiY5GNNm1ow== X-Pm-Submission-Id: 4cLZkB6BL6z1DDrw From: Sean Nyekjaer Date: Tue, 09 Sep 2025 09:11:10 +0200 Subject: [PATCH v4 4/5] iio: imu: inv_icm42600: Use devm_regulator_get_enable() for vdd regulator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250909-icm42pmreg-v4-4-2bf763662c5c@geanix.com> References: <20250909-icm42pmreg-v4-0-2bf763662c5c@geanix.com> In-Reply-To: <20250909-icm42pmreg-v4-0-2bf763662c5c@geanix.com> To: Jean-Baptiste Maneyrol , rafael@kernel.org, Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Jean-Baptiste Maneyrol , Jonathan Cameron , Sean Nyekjaer X-Mailer: b4 0.14.2 The vdd regulator is not used for runtime power management, so it does not need explicit enable/disable handling. Use devm_regulator_get_enable() to let the regulator be managed automatically by devm. This simplifies the code by removing the manual enable and cleanup logic. Reviewed-by: David Lechner Signed-off-by: Sean Nyekjaer --- drivers/iio/imu/inv_icm42600/inv_icm42600.h | 1 - drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 29 +++++---------------= ---- 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/= inv_icm42600/inv_icm42600.h index 1430ab4f1dea5d5ba6277d74275fc44a6cd30eb8..c8b48a5c5ed0677bb35201d3293= 4936faaf7a1a6 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h @@ -167,7 +167,6 @@ struct inv_icm42600_state { enum inv_icm42600_chip chip; const char *name; struct regmap *map; - struct regulator *vdd_supply; struct regulator *vddio_supply; int irq; struct iio_mount_matrix orientation; diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c b/drivers/iio= /imu/inv_icm42600/inv_icm42600_core.c index ee780f530dc8612cd25dc2216b153ef4e8c32b7b..4bf436c46f1cfd7e7e1bb911d94= a0a566d63e791 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c @@ -697,17 +697,6 @@ static int inv_icm42600_enable_regulator_vddio(struct = inv_icm42600_state *st) return 0; } =20 -static void inv_icm42600_disable_vdd_reg(void *_data) -{ - struct inv_icm42600_state *st =3D _data; - const struct device *dev =3D regmap_get_device(st->map); - int ret; - - ret =3D regulator_disable(st->vdd_supply); - if (ret) - dev_err(dev, "failed to disable vdd error %d\n", ret); -} - static void inv_icm42600_disable_vddio_reg(void *_data) { struct inv_icm42600_state *st =3D _data; @@ -765,23 +754,17 @@ int inv_icm42600_core_probe(struct regmap *regmap, in= t chip, return ret; } =20 - st->vdd_supply =3D devm_regulator_get(dev, "vdd"); - if (IS_ERR(st->vdd_supply)) - return PTR_ERR(st->vdd_supply); + ret =3D devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, + "Failed to get vdd regulator\n"); + + msleep(INV_ICM42600_POWER_UP_TIME_MS); =20 st->vddio_supply =3D devm_regulator_get(dev, "vddio"); if (IS_ERR(st->vddio_supply)) return PTR_ERR(st->vddio_supply); =20 - ret =3D regulator_enable(st->vdd_supply); - if (ret) - return ret; - msleep(INV_ICM42600_POWER_UP_TIME_MS); - - ret =3D devm_add_action_or_reset(dev, inv_icm42600_disable_vdd_reg, st); - if (ret) - return ret; - ret =3D inv_icm42600_enable_regulator_vddio(st); if (ret) return ret; --=20 2.50.1