From nobody Wed Sep 10 01:53:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D6621FF39; Mon, 8 Sep 2025 21:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366876; cv=none; b=Agfw5D4Xg6X5ZrdFFTLxf7jHxHsV53P8ZJG4oFJ4O0Hno4/B7jH35x1S+C9wMYEZ6DVtkeYl0D1m9j5OAwuLmV8TRFy8Z9kKH8vudZ92HTaw2zBBN8Xqv3nfn9xZEW+Y4o8p2+hgQk92Ca0Q8Pa/rBGGRS1HOMf1wFNNq8AeU20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366876; c=relaxed/simple; bh=2pnkprJwXgpBNzbLgqI2s8p4b2iZai3DkVfEhF0IFOE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WmnoRNHkF2///z9n4EGzuNcwoBjs/+0TZeNuhgcaDIgQ3U0eIlJyxA+Ru1eh9Ka7aSEBrIxnDd+uHZW1nuNiAe+jwfoFnRx2DI70g23RPTP/i3/qdj8Em+PKvlwZUC/hsnHbJNR0+bFZT4Brqw+WA5oO8WTSSlL+R5XSX7NvZdA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C3jkUlFs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C3jkUlFs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2B48C4CEF9; Mon, 8 Sep 2025 21:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757366875; bh=2pnkprJwXgpBNzbLgqI2s8p4b2iZai3DkVfEhF0IFOE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=C3jkUlFsAXhgKn4zS221intRVHQASC087PDVppT4sbCPu/9u3ZDmu1RvrOYoY0HMr 1oU1l/91o9Khjxf0sFcqvouS1qYv4IL1SYt8JD3Nve0eCEDrRNUEawf5tZuD8B4UZS wqsJgRdxO5c3OV0l3yHUpFFoAt5yA9deuRIkWdF53DNrcilhb1UVa2MQOF5+HTjVtn OJ60fj4en41jp0qASWvyd28cm48Qxb9l2CpLZRY4v/iSeQY/OVEqSRHMheR3mhYfn6 l6ZeI3b7grUHLXXgZw4tVDmCgpfzCPQy05oP+3PzyRe/uQcNY8eAc+IDNBrV+ktQRV l7+EuYkONKJ3Q== From: "Matthieu Baerts (NGI0)" Date: Mon, 08 Sep 2025 23:27:27 +0200 Subject: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-1-5f2168a66079@kernel.org> References: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> In-Reply-To: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Davide Caratti , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1084; i=matttbe@kernel.org; h=from:subject:message-id; bh=2pnkprJwXgpBNzbLgqI2s8p4b2iZai3DkVfEhF0IFOE=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDL2ewWWXn1/beXCCTqdUh/uiDl/eelwfGHZ690xS/bZz uxOu5sr3FHKwiDGxSArpsgi3RaZP/N5FW+Jl58FzBxWJpAhDFycAjCRox0Mf6V1HuzeZd3uo38m 72959pSYH8Z/26xSub7e2Zv6Q6Gu7CxQRdZHlullLT+fateIRZybc/kiZ3dEheqmAwwfBc7Ul2/ lAgA= X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 This attribute is used as a signed number in the code in pm_netlink.c: nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if)) The specs should then reflect that. Note that other 'if-idx' attributes from the same .yaml file use a signed number as well. Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/netlink/specs/mptcp_pm.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netl= ink/specs/mptcp_pm.yaml index 02f1ddcfbf1cfd81a398dd03c52bb9f281c1aa08..d15335684ec3d6256505f2b3887= ce5818eb57462 100644 --- a/Documentation/netlink/specs/mptcp_pm.yaml +++ b/Documentation/netlink/specs/mptcp_pm.yaml @@ -256,7 +256,7 @@ attribute-sets: type: u32 - name: if-idx - type: u32 + type: s32 - name: reset-reason type: u32 --=20 2.51.0 From nobody Wed Sep 10 01:53:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBC8221FF39; Mon, 8 Sep 2025 21:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366880; cv=none; b=WcgLTRi+DdoqH7LyrvHU1UPK0VvQo9pq6C5Cwc5Ntip3o03o1t/6VKDeFUTQECX/sZYLgShOQ6MtKFqFNWf+sr8cig9eoWJ15A4bEghbe3Iv9cmPFYPaLODOXD9TXTk6kuLcEz4rrP8phX8wFeP9SCSuCcGt1GGYUnMHxuTiTeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366880; c=relaxed/simple; bh=3NT5DqK9ceTmzwhurXujvORIaKtG4LGDHLvhlVLs6D0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WRsF0xqBTcJ6OFrEVswwE2qYS9l9nbNk7VBCeSmUcuScwbtufdJ9yMuQdUooTrCIYgi48Dwfa0ZsphzubUxFg0XJh0W+CGKlElwNu7WYxqOa8/5GZexzl02A6VpH4AqV+gX0Tb2fdeHbfizWAe+nolncAfLsqRk8upQ5vLkcHT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qwi9ViHs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qwi9ViHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48C6AC4CEF1; Mon, 8 Sep 2025 21:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757366879; bh=3NT5DqK9ceTmzwhurXujvORIaKtG4LGDHLvhlVLs6D0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Qwi9ViHsD9iU8yiMgLNJHe1korADT7xRHNjN9bRrN/XtrNc7G9tNGM4+Lg05XcbVa dJ5HOvI7HZsqCv/tTlRldth1yR5PM4B9Fwf32CCh9eyZEsMT0zhePo6i+QsICVTQ2d KvTswjIqHWJjqp3RXcgl6Fib5vOkqgxuHw3TOk+PSNuBZW4n1iAO8evXCAKkxznpJR +v+xVaj8wd9M0TvrfwezPFuCZGtvdYCVwwzPaAE+Hd4qchfeiP/EgJWaAgGqwlEHwO HcszR6TmnwSJsGHGkHlSZOkvxri7hrZcJBMspr1bdcCYEI8M+P2VdknI+/qXFF9XLt DULdvu+XZ0lxQ== From: "Matthieu Baerts (NGI0)" Date: Mon, 08 Sep 2025 23:27:28 +0200 Subject: [PATCH net 2/3] doc: mptcp: net.mptcp.pm_type is deprecated Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-2-5f2168a66079@kernel.org> References: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> In-Reply-To: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Davide Caratti , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1853; i=matttbe@kernel.org; h=from:subject:message-id; bh=3NT5DqK9ceTmzwhurXujvORIaKtG4LGDHLvhlVLs6D0=; b=kA0DAAoWfCLwwvNHCpcByyZiAGi/SlOhh+wwQT7Ge4EoFszL8uduOHWE1fKWYaIlycU6jdlw4 Ih1BAAWCgAdFiEEG4ZZb5nneg10Sk44fCLwwvNHCpcFAmi/SlMACgkQfCLwwvNHCpduzgEAkGNZ ouDFUTOkbBgLDu+PhROiOZ+KQyJ+nqccP33ZVmUA/2EqyaXnZbf6G8qUM8yznGz8c+WCwn7iI4n YvycFhkkB X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The net.mptcp.pm_type sysctl knob has been deprecated in v6.15, net.mptcp.path_manager should be used instead. Adapt the section about path managers to suggest using the new sysctl knob instead of the deprecated one. Fixes: 595c26d122d1 ("mptcp: sysctl: set path manager by name") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman --- Documentation/networking/mptcp.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/networking/mptcp.rst b/Documentation/networking/= mptcp.rst index 17f2bab611644727e19c3969fa08fa974c702d92..2e31038d6462051387be9bd8808= a23230db08315 100644 --- a/Documentation/networking/mptcp.rst +++ b/Documentation/networking/mptcp.rst @@ -60,10 +60,10 @@ address announcements. Typically, it is the client side= that initiates subflows, and the server side that announces additional addresses via the ``ADD_ADDR= `` and ``REMOVE_ADDR`` options. =20 -Path managers are controlled by the ``net.mptcp.pm_type`` sysctl knob -- s= ee -mptcp-sysctl.rst. There are two types: the in-kernel one (type ``0``) wher= e the -same rules are applied for all the connections (see: ``ip mptcp``) ; and t= he -userspace one (type ``1``), controlled by a userspace daemon (i.e. `mptcpd +Path managers are controlled by the ``net.mptcp.path_manager`` sysctl knob= -- +see mptcp-sysctl.rst. There are two types: the in-kernel one (``kernel``) = where +the same rules are applied for all the connections (see: ``ip mptcp``) ; a= nd the +userspace one (``userspace``), controlled by a userspace daemon (i.e. `mpt= cpd `_) where different rules can be applied for ea= ch connection. The path managers can be controlled via a Netlink API; see netlink_spec/mptcp_pm.rst. --=20 2.51.0 From nobody Wed Sep 10 01:53:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E66621FF39; Mon, 8 Sep 2025 21:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366883; cv=none; b=UqqRaAPcGjtUzuFXzrtvgQjbA9y/23F3XDHsRaBsc9F3L8d033mUjFRkuwUVupVphjiJoOjP9n3n3wgiSeBZQNQq0JEu5U9n9JL1jzxg76WIYXZ/qKP2UzTud1oCtxtS0ijX9AV7diyvcv04wN+P+s/Xh+CdPJFnP1CVrzvnWWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757366883; c=relaxed/simple; bh=gDCZvvVNWEMCU3nT1uDyLwDLHgKoibMV4aiujAjJvhU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kJgElTdjlOZpJXpj4uwohBTJfEF0B56qVodRQUz+QKA23EO5MuwJs1bok0Oolj9GZp1j1c4Cw5ccg10TLH1lSLa87KJBdhyQT4PLigJfvh7Py4A7DmdQcCRqsD5AXds3Zl5NxjPtohg5tPYUHrYETNU6squt+NVDbEl033Hd7oU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UEab8R9/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UEab8R9/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3450C4CEF7; Mon, 8 Sep 2025 21:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757366882; bh=gDCZvvVNWEMCU3nT1uDyLwDLHgKoibMV4aiujAjJvhU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UEab8R9/I2NlvC9GuptOXjwWyNik5bnCFfAaT+bUnuhIdp8hm8dbl9uEfbqbgtwOs DUcb42pDgMcyyX9HOK5cwYHomGfx2vM1HDmVDhk+WGg4mKBCJoDheiAMk42G34YC8O eGpIWySvhosZV/B41kL/bj8D8Gn2nK1cRE6ciIjN+u4kIlsROyOTS73gqBQ/IbZljZ zxNt+qBgb3dQz+YXeI0mPwW4yIOfK10DNDDDQqgVTi9NVWswNEWSREJPOuX98l+CtO g1oPRc7nlMOkd3oUtydwpR19nUsNy0eqhfcROTbLjLyP5AO98QTcxsLkEJlTsXmrHL C+ptPjrmCfVfg== From: "Matthieu Baerts (NGI0)" Date: Mon, 08 Sep 2025 23:27:29 +0200 Subject: [PATCH net 3/3] selftests: mptcp: shellcheck: support v0.11.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-3-5f2168a66079@kernel.org> References: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> In-Reply-To: <20250908-net-mptcp-misc-fixes-6-17-rc5-v1-0-5f2168a66079@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Davide Caratti , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4972; i=matttbe@kernel.org; h=from:subject:message-id; bh=gDCZvvVNWEMCU3nT1uDyLwDLHgKoibMV4aiujAjJvhU=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDL2e4Wc7vbjmbjuEffb+Geralk43bI4G44UyC9SZ5dYd GylNcuTjlIWBjEuBlkxRRbptsj8mc+reEu8/Cxg5rAygQxh4OIUgIl4nGb4xfw6bvuaFyxWMU7n omYfSjVc+7stxEl/336ZHY+v2lluPczw353N3qKedeqUGrW1fx2fz5sobSz7Py7066en9VsW5H6 oZgAA X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 This v0.11.0 version introduces SC2329: Warn when (non-escaping) functions are never invoked. Except that, similar to SC2317, ShellCheck is currently unable to figure out functions that are invoked via trap, or indirectly, when calling functions via variables. It is then needed to disable this new SC2329. Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman --- tools/testing/selftests/net/mptcp/diag.sh | 2 +- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +- tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +- tools/testing/selftests/net/mptcp/mptcp_sockopt.sh | 2 +- tools/testing/selftests/net/mptcp/pm_netlink.sh | 5 +++-- tools/testing/selftests/net/mptcp/simult_flows.sh | 2 +- tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +- 7 files changed, 9 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/self= tests/net/mptcp/diag.sh index 7a3cb4c09e450f0ae570015c4724ec268c6dc19f..d847ff1737c30c0eae1cefeb5a8= 3bd3223897707 100755 --- a/tools/testing/selftests/net/mptcp/diag.sh +++ b/tools/testing/selftests/net/mptcp/diag.sh @@ -28,7 +28,7 @@ flush_pids() } =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { ip netns pids "${ns}" | xargs --no-run-if-empty kill -SIGKILL &>/dev/null diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/tes= ting/selftests/net/mptcp/mptcp_connect.sh index 5e3c56253274a1f938d2ed9986c4290fcea8b96b..c2ab9f7f0d2133559bb18ce884b= 613d21d1ec5f0 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -134,7 +134,7 @@ ns4=3D"" TEST_GROUP=3D"" =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { rm -f "$cin_disconnect" diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 82cae37d9c2026cc55466636d53a76f929a03452..7fd555b123b900c135bae5f61da= 30c21a3110eb3 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -8,7 +8,7 @@ =20 # ShellCheck incorrectly believes that most of the code here is unreachable # because it's invoked by variable name, see how the "tests" array is used -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 =20 . "$(dirname "${0}")/mptcp_lib.sh" =20 diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/tes= ting/selftests/net/mptcp/mptcp_sockopt.sh index 418a903c3a4d396bd733bf8b6f68b1447d4d1de3..f01989be6e9b3daeecc5a8f41b3= 7c9a284efef61 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh @@ -95,7 +95,7 @@ init() } =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { mptcp_lib_ns_exit "${ns1}" "${ns2}" "${ns_sbox}" diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testin= g/selftests/net/mptcp/pm_netlink.sh index ac7ec6f9402376a34602ef1ca6c4822e8dde0ded..ec6a8758819194f2c53791d76ae= 68e088f188813 100755 --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh @@ -32,7 +32,7 @@ ns1=3D"" err=3D$(mktemp) =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { rm -f "${err}" @@ -70,8 +70,9 @@ format_endpoints() { mptcp_lib_pm_nl_format_endpoints "${@}" } =20 +# This function is invoked indirectly +#shellcheck disable=3DSC2317,SC2329 get_endpoint() { - # shellcheck disable=3DSC2317 # invoked indirectly mptcp_lib_pm_nl_get_endpoint "${ns1}" "${@}" } =20 diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/test= ing/selftests/net/mptcp/simult_flows.sh index 2329c2f8519b7c336e9f90a705dfa7588207a543..1903e8e84a315175e2ffd620dd7= b4e94dbf25dfb 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -35,7 +35,7 @@ usage() { } =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { rm -f "$cout" "$sout" diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/test= ing/selftests/net/mptcp/userspace_pm.sh index 333064b0b5ac03ae003417d2070f3c08f94743ed..970c329735ff14f87f0048ba003= 0dc7edaaa86bc 100755 --- a/tools/testing/selftests/net/mptcp/userspace_pm.sh +++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh @@ -94,7 +94,7 @@ test_fail() } =20 # This function is used in the cleanup trap -#shellcheck disable=3DSC2317 +#shellcheck disable=3DSC2317,SC2329 cleanup() { print_title "Cleanup" --=20 2.51.0