From nobody Wed Sep 10 01:32:53 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA46A30ACEF for ; Mon, 8 Sep 2025 13:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337183; cv=none; b=I1ENzHjY/1UlfhVlNGpBjV5xZ34IDl0+4USUNYRCi5RmghCmAt8Mm9UYPa8pkc4+LBKBue9nyiG8R0cBgjSLsikpK5Q0PVRFf1cTVPJlDQ9Z07mIr/r0QG5RkzpV09ZqXNLaPoHMcemhNasfiVaa5BG5p2UQvzf/HJ7bYP/DcyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337183; c=relaxed/simple; bh=d16ATURJXaVteyF3Qps5PT9fGye6OfeD6faAj7tSV9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dqK7M4RNCv6e4Fj7Qb9nWprEqVeuabUTkd+AIVN62Gyf84hU1wsVPqAmmL2jNcYT7Bsopgzmkcfd+PNv7m3r87sDGqM2yC+WYCkCBBxsSFrFcgXY43aCM1Ka7pl9ha6fx6ZIHkDqcAhYbC5m2fLha2w5jej8tW4HA9uFkEgsuQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vm0Xrrt0; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vm0Xrrt0" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-45de287cc11so6435965e9.1 for ; Mon, 08 Sep 2025 06:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337180; x=1757941980; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+dqFZom65YcEQkXmUqTDd4+m17RatDWu3bIoNbEjE50=; b=Vm0Xrrt0lJarz765OySh/xBjJzRY2eLuKX7ei+L2VPuXjabjjP27pfRZ/UL/eZ92/k GMco9CXCLjalhXpBzBgPZjQHo5KwicvsxL0lbsmQ3sS0+fK6UFuQBNnoooFLWGGpM6SN TMVzzfqaE1tAjzC+8RG9iNcpyt++inF5fl7bJ1VPIRWb1VoZyH7xrKkKjfI98hnw9IYQ QdM9JAz3XZtl8bDBiBBbwoWpj/fUpipbZ4e3Hz53AfDnuKQF5zT7/ejNAgZLYGUXIUk4 OPZ6vAL0Da6pNT1f8UnP6ha3i7LSucYR2Bms713h4RYkGQlMufbQdhHdElh6oXF+0RvV F2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337180; x=1757941980; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+dqFZom65YcEQkXmUqTDd4+m17RatDWu3bIoNbEjE50=; b=O2KcDlI4/yPfuCocN+yMwN+trX136U9yUwD5wNQsSLvjMcl0vVFUAfKUu1WPpgELND seHV5j5jSfsonNIcsVi3Zo2NpCTYnLN2hceCabg1vlLWzW38oWz1o/GeEK0P8IHZxj8w o+4CUS0p6FUSCzpZ0yIzISyU1urBkL9J8KPRL1sGXBwLZ7VdvAaA/AEpKak6/icC6dFF +hbUT4flrWA9jIToRScfmXTtUvJnCgdkawgJKepb4EBUgacslCidE2AddoMoTJvorEG8 CinrXi0X66Jg0LDi1NM/yOH3yPSX0MMFlYID+OOLDMfNl/InWuLYDxefVaKuj/BPGq7M yiqg== X-Gm-Message-State: AOJu0YzPPfChFSbKuSVWyclul24nZq3Nyz581TMAhKKE0OQ+Fh4aK6g4 7nTL75M9AXhXgu9mwdfFLOi03++GBZvwZiML2jCCQZVqnNfv9zb2Druh7/HsfilcH9o= X-Gm-Gg: ASbGncsBHQ4Bc7R6qa1XRHwIrIRekcbjuAhWJ8hMcw5zf2wYM/RtigZsBCT+y2jLCFI Mm2cM+XTttSLyjB/JAQ+q9cHnflV9K6QRBGVIQEaeFmySPbiiyNSAqvsslsnjcZjurqQcPU7P5D VlH+c6RPMTL3cvBlUXVLx6FWB9oUmC/R9qkViywdc8sY2ecs3vDJELDNjerBHPwOKhw+/esO4Mw obkVA0dEzUooBPqfAPw/+nPrVZtE/2F3MnI21HKUop183U2z0LOjsahRsYs3rHYzWYhyhM5yf6x ktxXFsFcF/B1mCuU+erTwCfGg/Nl6zfoR3i06xMG7Htv4nzglhpplep1tOf6Wfe0a31HWFL6U1p TOdg0V/Eio9U6jjo14Esl6iU9ziAbdsaUXji7EG6S/rvOcd50ejseUeGo5Z1rbKGjGLlTO0eVpF /Z3A== X-Google-Smtp-Source: AGHT+IE7mUMhuSHckm+BOVWYPNlPL88vc/oJXt6OY3cNSKgPrAVUivteuSdEdtgHuOKT9kbXSWZ9Uw== X-Received: by 2002:a05:6000:400c:b0:3dc:2f0e:5e2e with SMTP id ffacd0b85a97d-3e628cd5aecmr6211828f8f.13.1757337179849; Mon, 08 Sep 2025 06:12:59 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:12:59 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:42 +0000 Subject: [PATCH v4 1/5] dt-bindings: firmware: google,gs101-acpm-ipc: add ACPM clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-acpm-clk-v4-1-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=3056; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=d16ATURJXaVteyF3Qps5PT9fGye6OfeD6faAj7tSV9U=; b=suYt9exuHS5pnrnU/6Dl3RDrK+E1WIxhvGPdwwQ3FPHy9Br2xJnfDunovLjDzC9kuHFmAcIiL C/CqsWwn9aPBC/3KL2PvOOXAQkSEBn7TCUXkTH/9eEvTIYcZoUOWhDe X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= The firmware exposes clocks that can be controlled via the Alive Clock and Power Manager (ACPM) interface. Make the ACPM node a clock provider by adding the mandatory "#clock-cells" property, which allows devices to reference its clock outputs. Signed-off-by: Tudor Ambarus Reviewed-by: Rob Herring (Arm) --- .../bindings/firmware/google,gs101-acpm-ipc.yaml | 11 +++++++++ include/dt-bindings/clock/google,gs101-acpm.h | 26 ++++++++++++++++++= ++++ 2 files changed, 37 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-i= pc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.= yaml index 9785aac3b5f34955bbfe2718eec48581d050954f..d3bca6088d128485618bb2b538e= d8596b4ba14f0 100644 --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml @@ -24,6 +24,15 @@ properties: compatible: const: google,gs101-acpm-ipc =20 + "#clock-cells": + const: 1 + description: + Clocks that are variable and index based. These clocks don't provide + an entire range of values between the limits but only discrete points + within the range. The firmware also manages the voltage scaling + appropriately with the clock scaling. The argument is the ID of the + clock contained by the firmware messages. + mboxes: maxItems: 1 =20 @@ -45,6 +54,7 @@ properties: =20 required: - compatible + - "#clock-cells" - mboxes - shmem =20 @@ -56,6 +66,7 @@ examples: =20 power-management { compatible =3D "google,gs101-acpm-ipc"; + #clock-cells =3D <1>; mboxes =3D <&ap2apm_mailbox>; shmem =3D <&apm_sram>; =20 diff --git a/include/dt-bindings/clock/google,gs101-acpm.h b/include/dt-bin= dings/clock/google,gs101-acpm.h new file mode 100644 index 0000000000000000000000000000000000000000..e2ba89e09fa6209f7c81f554dd5= 11b2619009e5b --- /dev/null +++ b/include/dt-bindings/clock/google,gs101-acpm.h @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright 2025 Linaro Ltd. + * + * Device Tree binding constants for Google gs101 ACPM clock controller. + */ + +#ifndef _DT_BINDINGS_CLOCK_GOOGLE_GS101_ACPM_H +#define _DT_BINDINGS_CLOCK_GOOGLE_GS101_ACPM_H + +#define GS101_CLK_ACPM_DVFS_MIF 0 +#define GS101_CLK_ACPM_DVFS_INT 1 +#define GS101_CLK_ACPM_DVFS_CPUCL0 2 +#define GS101_CLK_ACPM_DVFS_CPUCL1 3 +#define GS101_CLK_ACPM_DVFS_CPUCL2 4 +#define GS101_CLK_ACPM_DVFS_G3D 5 +#define GS101_CLK_ACPM_DVFS_G3DL2 6 +#define GS101_CLK_ACPM_DVFS_TPU 7 +#define GS101_CLK_ACPM_DVFS_INTCAM 8 +#define GS101_CLK_ACPM_DVFS_TNR 9 +#define GS101_CLK_ACPM_DVFS_CAM 10 +#define GS101_CLK_ACPM_DVFS_MFC 11 +#define GS101_CLK_ACPM_DVFS_DISP 12 +#define GS101_CLK_ACPM_DVFS_BO 13 + +#endif /* _DT_BINDINGS_CLOCK_GOOGLE_GS101_ACPM_H */ --=20 2.51.0.355.g5224444f11-goog From nobody Wed Sep 10 01:32:53 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA0E30AD0F for ; Mon, 8 Sep 2025 13:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337184; cv=none; b=agoyDbdiG9ik/86NGj9wOOq0Do166JBaD/7BIVNWcrx1L1GEB0ytjgEKwxnYAPoQPVHk+pgTTMy4aXJNeCfmpDgvO7fykSilk3tDETzfnYZqSEUzonQv9jwDi9Fp5VIGZbWcGuNdbclX3StH+P27Un0TLAOAUnG7x/3IVDRtdss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337184; c=relaxed/simple; bh=WEYCc0m08cozmqjakGvBtMPbDEIfLlrQSlYRfrXgnOA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lHI8DmaqZSZ1MVJlCZddRobm5zhszSe9KOwWsF6dcHBrn1SPj7F25qmvGU8+Bdee8XwABeSvxHgh8sVGqYVeEPEWQtygeaYha+ikYYHTP2H37XGpYTn+Zele+6kTMx2n8hAI2BglKuj/nbHtu7NMqCzrsoyKd9ushYJUvJdcyps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ByGNdKfX; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ByGNdKfX" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45de6490e74so9025375e9.2 for ; Mon, 08 Sep 2025 06:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337181; x=1757941981; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=axRyto/ISVMntXEL3ZXAISR7Gp0i8a/1nJ0/ZHfbjHA=; b=ByGNdKfXgtDkG0zJ8yQPHzOlSjpTRpP13jULcOhsqoRRYfSDQKRCy9J3TfzxX0uKZX 8QtJ6W89cJqey3Vsfd/dAQMnNnAcfm8PAx4YnzyflL+g0BMjHnvcKOCAnhDTImLHed8j pNPg5E/VO4jM52ZrS0YxZo0pIzCFJIenQOC5o4FH7KMqGkHza/8pjVip2143kZz+O8kh EIvpqRtC+AYAhMydil7+uWGGAekJNuoLu+31h39zB2WM6IUHG5TtJ4uk72+OuK91T/vS wPkfkRlLVJb5wz9Fx6XuYfolWmp1sU0ajfn0oMf5XLvGXyhvoOU0MPRg/8869hmzdz0E 0D4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337181; x=1757941981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=axRyto/ISVMntXEL3ZXAISR7Gp0i8a/1nJ0/ZHfbjHA=; b=R68k8yyW3gkEsh4ZNY/xEkVHdF9EDLSQ3Xuy/yAwAZW6zqY/H4BhQm47GqCqa6FtWP ZbOeavpAqKE++2Awvd6l4/G3H4TswRwOCbsmRqsT4SMWm5RK/FYyQ31xc+Wi47WC76AW QvSyqpjLewCjUGBdRAvQE6w/EYiv8tk7BKQ4ELePC+J0vbd8Fb6v0J5N33W7c2THVMFn yhUHpixPD7X0mWxHgDG+qWirn6wU9C5uLPIAmmGX+uU8xTNtMd+C4JC2hFGc52wAKVT/ estu87KRrvcJgsaMpDHs/OsKOUKld2ZfbV3il4OgAGiSP6iLt+c8CWprLpcP4CRRi+x7 SiVQ== X-Gm-Message-State: AOJu0YyH8isGntF4s3vdCGQ90f/SqiqTD5FV/HrmfxBlpn3so/Px23L2 Solq+8rS6Ob1OUVTOyrmK6TqUQlVw8WttrdBiAf7/Nxhxo0sfHb+aQArsf9xNbHeRN4= X-Gm-Gg: ASbGncvcIp6GZ6B//diu2Fka3w+cit2T83r3tNlydEJD1xwOi+JAPNQLeVc4987KMlm IoVzfESDvsJGhu6rAN3ZWs1vfgPlgYxLEu2IJ62ykMy/giA0qERUEE70K5GTO5r/rz8unXWtbkZ SkKdayrnRtZERe4ipf4Ee4wF4GfT0VsfYBo93nmLscVLgUPZRW8K7VQuCzkcZLxOMVqtWMuUqWv B+at1d8Jmhljgrq/aEPbfKBOLRaOMCyyaWhwGCnjNuphKxMytGiX7WYDprRPjVEya2Io/5yJah1 wSgkIpB/q9jLD3wBeUuwt35vD2FKAYjISZmgooGJamstLw24Ob7BKIkdD1P3H48LcXomwr9ceOu fz51FJNtrlJYfWzWgtMTRHpAraTXdH00qQmtRTwOyju+IUuSycU8uZdSQV2m/LgKAgDWLQu6240 YFpA+s5IjHXcd2 X-Google-Smtp-Source: AGHT+IGwIG5gbqEOa/X2dR0JZvfb5YQB2PpmEsolXTUv2RvpCoxPAS94Oqup7vYXB9W/8UsdI1FEOQ== X-Received: by 2002:a05:600c:1390:b0:45d:da7c:b36 with SMTP id 5b1f17b1804b1-45ddded7614mr64813635e9.19.1757337180651; Mon, 08 Sep 2025 06:13:00 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:13:00 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:43 +0000 Subject: [PATCH v4 2/5] firmware: exynos-acpm: add DVFS protocol Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-acpm-clk-v4-2-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=6599; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=WEYCc0m08cozmqjakGvBtMPbDEIfLlrQSlYRfrXgnOA=; b=IEHGUjctdjN/UA7r9A7/JSWgbrBpcnXg/M4EDFmiviwzFAkzy2IwstmPk9jHaEZ002lkTifxM LS63Zr3LLjUBR3cFHkPES+5ETiie9FZsaF2sD6M7cTD/QP//jbcxPp3 X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add ACPM DVFS protocol handler. It constructs DVFS messages that the APM firmware can understand. Signed-off-by: Tudor Ambarus --- drivers/firmware/samsung/Makefile | 4 +- drivers/firmware/samsung/exynos-acpm-dvfs.c | 83 ++++++++++++++++++= ++++ drivers/firmware/samsung/exynos-acpm-dvfs.h | 21 ++++++ drivers/firmware/samsung/exynos-acpm.c | 5 ++ .../linux/firmware/samsung/exynos-acpm-protocol.h | 10 +++ 5 files changed, 122 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/samsung/Makefile b/drivers/firmware/samsung/M= akefile index 7b4c9f6f34f54fd731886d97a615fe1aa97ba9a0..80d4f89b33a9558b68c9083da67= 5c70ec3d05f19 100644 --- a/drivers/firmware/samsung/Makefile +++ b/drivers/firmware/samsung/Makefile @@ -1,4 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only =20 -acpm-protocol-objs :=3D exynos-acpm.o exynos-acpm-pmic.o +acpm-protocol-objs :=3D exynos-acpm.o +acpm-protocol-objs +=3D exynos-acpm-pmic.o +acpm-protocol-objs +=3D exynos-acpm-dvfs.o obj-$(CONFIG_EXYNOS_ACPM_PROTOCOL) +=3D acpm-protocol.o diff --git a/drivers/firmware/samsung/exynos-acpm-dvfs.c b/drivers/firmware= /samsung/exynos-acpm-dvfs.c new file mode 100644 index 0000000000000000000000000000000000000000..a8763bf9374d41952a8d26124cc= 77baae0f1c723 --- /dev/null +++ b/drivers/firmware/samsung/exynos-acpm-dvfs.c @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2020 Samsung Electronics Co., Ltd. + * Copyright 2020 Google LLC. + * Copyright 2025 Linaro Ltd. + */ + +#include +#include +#include +#include +#include + +#include "exynos-acpm.h" +#include "exynos-acpm-dvfs.h" + +#define ACPM_DVFS_ID GENMASK(11, 0) +#define ACPM_DVFS_REQ_TYPE GENMASK(15, 0) + +#define ACPM_DVFS_FREQ_REQ 0 +#define ACPM_DVFS_FREQ_GET 1 + +static void acpm_dvfs_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cm= dlen, + unsigned int acpm_chan_id, bool response) +{ + xfer->acpm_chan_id =3D acpm_chan_id; + xfer->txd =3D cmd; + xfer->txlen =3D cmdlen; + + if (response) { + xfer->rxd =3D cmd; + xfer->rxlen =3D cmdlen; + } +} + +static void acpm_dvfs_init_set_rate_cmd(u32 cmd[4], unsigned int clk_id, + unsigned long rate) +{ + cmd[0] =3D FIELD_PREP(ACPM_DVFS_ID, clk_id); + cmd[1] =3D rate / HZ_PER_KHZ; + cmd[2] =3D FIELD_PREP(ACPM_DVFS_REQ_TYPE, ACPM_DVFS_FREQ_REQ); + cmd[3] =3D ktime_to_ms(ktime_get()); +} + +int acpm_dvfs_set_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + unsigned long rate) +{ + struct acpm_xfer xfer =3D {0}; + u32 cmd[4]; + + acpm_dvfs_init_set_rate_cmd(cmd, clk_id, rate); + acpm_dvfs_set_xfer(&xfer, cmd, sizeof(cmd), acpm_chan_id, false); + + return acpm_do_xfer(handle, &xfer); +} + +static void acpm_dvfs_init_get_rate_cmd(u32 cmd[4], unsigned int clk_id, + u32 dbg_val) +{ + cmd[0] =3D FIELD_PREP(ACPM_DVFS_ID, clk_id); + cmd[1] =3D dbg_val; + cmd[2] =3D FIELD_PREP(ACPM_DVFS_REQ_TYPE, ACPM_DVFS_FREQ_GET); + cmd[3] =3D ktime_to_ms(ktime_get()); +} + +unsigned long acpm_dvfs_get_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + u32 dbg_val) +{ + struct acpm_xfer xfer; + unsigned int cmd[4]; + int ret; + + acpm_dvfs_init_get_rate_cmd(cmd, clk_id, dbg_val); + acpm_dvfs_set_xfer(&xfer, cmd, sizeof(cmd), acpm_chan_id, true); + + ret =3D acpm_do_xfer(handle, &xfer); + if (ret) + return 0; + + return xfer.rxd[1] * HZ_PER_KHZ; +} diff --git a/drivers/firmware/samsung/exynos-acpm-dvfs.h b/drivers/firmware= /samsung/exynos-acpm-dvfs.h new file mode 100644 index 0000000000000000000000000000000000000000..85a10bd535d118f2f36e9888e41= b9b705b08ea59 --- /dev/null +++ b/drivers/firmware/samsung/exynos-acpm-dvfs.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2020 Samsung Electronics Co., Ltd. + * Copyright 2020 Google LLC. + * Copyright 2025 Linaro Ltd. + */ +#ifndef __EXYNOS_ACPM_DVFS_H__ +#define __EXYNOS_ACPM_DVFS_H__ + +#include + +struct acpm_handle; + +int acpm_dvfs_set_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int id, + unsigned long rate); +unsigned long acpm_dvfs_get_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + u32 dbg_val); + +#endif /* __EXYNOS_ACPM_DVFS_H__ */ diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/sams= ung/exynos-acpm.c index 3a69fe3234c75e0b5a93cbea6bb210dc6f69d2a6..9fa0335ccf5db32892fdf09e8d4= b0a885a8f8fb5 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -29,6 +29,7 @@ #include =20 #include "exynos-acpm.h" +#include "exynos-acpm-dvfs.h" #include "exynos-acpm-pmic.h" =20 #define ACPM_PROTOCOL_SEQNUM GENMASK(21, 16) @@ -590,8 +591,12 @@ static int acpm_channels_init(struct acpm_info *acpm) */ static void acpm_setup_ops(struct acpm_info *acpm) { + struct acpm_dvfs_ops *dvfs_ops =3D &acpm->handle.ops.dvfs_ops; struct acpm_pmic_ops *pmic_ops =3D &acpm->handle.ops.pmic_ops; =20 + dvfs_ops->set_rate =3D acpm_dvfs_set_rate; + dvfs_ops->get_rate =3D acpm_dvfs_get_rate; + pmic_ops->read_reg =3D acpm_pmic_read_reg; pmic_ops->bulk_read =3D acpm_pmic_bulk_read; pmic_ops->write_reg =3D acpm_pmic_write_reg; diff --git a/include/linux/firmware/samsung/exynos-acpm-protocol.h b/includ= e/linux/firmware/samsung/exynos-acpm-protocol.h index f628bf1862c25fa018a2fe5e7e123bf05c5254b9..e41055316bb578bb8250a1b1177= f1059eeeb2611 100644 --- a/include/linux/firmware/samsung/exynos-acpm-protocol.h +++ b/include/linux/firmware/samsung/exynos-acpm-protocol.h @@ -13,6 +13,15 @@ struct acpm_handle; struct device_node; =20 +struct acpm_dvfs_ops { + int (*set_rate)(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + unsigned long rate); + unsigned long (*get_rate)(const struct acpm_handle *handle, + unsigned int acpm_chan_id, + unsigned int clk_id, u32 dbg_val); +}; + struct acpm_pmic_ops { int (*read_reg)(const struct acpm_handle *handle, unsigned int acpm_chan_id, u8 type, u8 reg, u8 chan, @@ -32,6 +41,7 @@ struct acpm_pmic_ops { }; =20 struct acpm_ops { + struct acpm_dvfs_ops dvfs_ops; struct acpm_pmic_ops pmic_ops; }; =20 --=20 2.51.0.355.g5224444f11-goog From nobody Wed Sep 10 01:32:53 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D35E30B505 for ; Mon, 8 Sep 2025 13:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337186; cv=none; b=F72fUQuZfilHoeghH9rCWIhEplsrGOIkjc8HZWi6+uDhu8LZ/DA+PnTl37i5S7oN+tNYfPErKtBDinCDm0wXa47siyUGqa3962bFlvPq/xF5OY5wFOHSvn9oLl7KQOI+cs7ywYLja4GD8B5x1sjzMZpDB3ghRiKZGnaDziqMnIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337186; c=relaxed/simple; bh=pOrwHMUpTRHTOWnb5cnnDdzeM4ESkRCjGNVfFG9Nc7M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KgqRmnX8fFr7b4SmHOzKwIBOrMDmMM8DryJ1G/Y+klMBLN9rOrRbFXZLlA2pwLFX8Q7nkZwqLb53Gz4Xn/Rwl8pFwYg/x5TWC4ryXCozGpspXRt5VXa+hbsQLJU3ZH8Qy+GRkO6T6qbZn0r7O1nUbIVbV6xD50YhnHTTco42SSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qcVRgX83; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qcVRgX83" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45de1084868so7688675e9.2 for ; Mon, 08 Sep 2025 06:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337182; x=1757941982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6VURWIkfuPan7bcStL9p1ueaB35kinp1F/svGb9kGJc=; b=qcVRgX83ITqAlqXs8msiHonhbIDa57HTNdkjHH5mTX9t2Fgj/oz9aeeD41KZKT5fh2 xR9azaHhwESL31Lbpfm0kNONnMD9TeJfWw/VVTiSQCqtgam8ueO55c3YXorMzVXzFpO2 0b1H+OFTSRuTYVkVJ1uw+6KDQGyx/Z5ORkNHmaOfM8JWpVSLoxTCOh69e5/qMkoi5E2A /4w1nDLckdZV+hhbZCckE8RE60xatjQLbrwW7tjd18Z3xYjsX1kMjBV4/zTo5zPFOsCk RCILDba74IZoyUH/zOSJpmXwkXB4XgBanP9HZsHxsnq9mJ58TvvslKecRD4G4np6seVI TgJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337182; x=1757941982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6VURWIkfuPan7bcStL9p1ueaB35kinp1F/svGb9kGJc=; b=xOE8bk5/PFoSlZP5DToX2GDdGiX7SJgg81tQ9W6QZJRy0rG1EGTtoaL0LID1YYy9zD ZfAmMklYr+LeRRsgO4KW1PYcbcMUDqpP+B2ffdX6WouxpAlNUG+ZBD+SSttOhN7VEJb7 LJQohLcdNdt3nNa80WKCAUPnsDm3Fiytw8OXBDra2j+gJ8oJqp6S4Yt5jgt4J0AfoX5n Nmno6LrjvM/bPPt5YEjm+Y5laRPeN3mWZjG0CrRMVJCi6LNqkm+8eOJ2WIrjmYOe4Mq2 kqx5c5+GTk1Z07bhVz+jE6ZXuh/0Z3Y1kqrhwWg8PyxfPIJdi771DGKnabJuemxbYgYA HbbA== X-Gm-Message-State: AOJu0YwGBhIt0VcmNkv/3ZlAuSQfuQQrH4cxnRnl8OkwTjtDixR1TbA/ NN0b04OVL15Xn6J7D1HBoMYQ+UNJ6EdsEo6cqxKcZxp1Whhgd9FVeA9L1+CVfwdzwlY= X-Gm-Gg: ASbGncvERuLH3to8C28Kf6A3a+woCZwJI89lGH3IruL77LKlv1GC0ppJ/5UKFLUgLjq P9KzZPkdWpItQIkmrFj9JVaaX7YGP0fw3l6B5VBBKLKC1oOiNM5yxRApDvdlav+3efm1yow4Ow8 LgstNpkep6PO80hvljBVpCHQGHMyR0VtvTu/1eIWrlGmJZi47duKzPrRYkG1aVyUGggNdRvbFFP r87mxLAyGvBcAgNCwp8jNn40SKIaS9JHDJoHwt6vIGvQqx4M98w1ama0u2V6ylSgOkPGNYjmmXx 4m1xojjL964KBAqhWDtpnaBdSANT6Tk0gtqBn/BBeOK0bLzB2dy9FAtm0CqATejfULl5GBdwz1B Dcm+zjYyv2kwBRbOcz4roWs7Gobk0KN7LxkTTO3YF0uC39w+YTOGOeL41IaeWizen6AVJcxv2kU gwmA== X-Google-Smtp-Source: AGHT+IF7+1AW9gZi8VQR2eAfB1khonQITj9xmbUIJb5Ssirri3fDS6+tN+4m3PJu5jGzW1eTe1Ha4w== X-Received: by 2002:a05:6000:2681:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e64bde9298mr7276281f8f.40.1757337181458; Mon, 08 Sep 2025 06:13:01 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:13:01 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:44 +0000 Subject: [PATCH v4 3/5] firmware: exynos-acpm: register ACPM clocks pdev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-acpm-clk-v4-3-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=2606; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=pOrwHMUpTRHTOWnb5cnnDdzeM4ESkRCjGNVfFG9Nc7M=; b=UTpAb+oSnFVBaTobsje5fgi9yvKDrERYAhJexCt3pEL95FZ5z5dw1g464Yv1noAWgt1hsVIOP AMaQN6NW/q8D2uKwG/IM/JHV9cOncEqoKaD8YigxQkmL3ikjGunTHUd X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Register by hand a platform device for the ACPM clocks. The ACPM clocks are not modeled as a DT child of ACPM because: 1/ they don't have their own resources. 2/ they are not a block that can be reused. The clock identifying data is reduced (clock ID, clock name and mailbox channel ID) and may differ from a SoC to another. Signed-off-by: Tudor Ambarus --- drivers/firmware/samsung/exynos-acpm.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/sams= ung/exynos-acpm.c index 9fa0335ccf5db32892fdf09e8d4b0a885a8f8fb5..0cb269c7046015d4c5fe5731ba0= d61d48dcaeee1 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -177,9 +177,11 @@ struct acpm_info { /** * struct acpm_match_data - of_device_id data. * @initdata_base: offset in SRAM where the channels configuration resides. + * @acpm_clk_dev_name: base name for the ACPM clocks device that we're reg= istering. */ struct acpm_match_data { loff_t initdata_base; + const char *acpm_clk_dev_name; }; =20 #define client_to_acpm_chan(c) container_of(c, struct acpm_chan, cl) @@ -604,9 +606,15 @@ static void acpm_setup_ops(struct acpm_info *acpm) pmic_ops->update_reg =3D acpm_pmic_update_reg; } =20 +static void acpm_clk_pdev_unregister(void *data) +{ + platform_device_unregister(data); +} + static int acpm_probe(struct platform_device *pdev) { const struct acpm_match_data *match_data; + struct platform_device *acpm_clk_pdev; struct device *dev =3D &pdev->dev; struct device_node *shmem; struct acpm_info *acpm; @@ -647,6 +655,18 @@ static int acpm_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, acpm); =20 + acpm_clk_pdev =3D platform_device_register_data(dev, + match_data->acpm_clk_dev_name, + PLATFORM_DEVID_NONE, NULL, 0); + if (IS_ERR(acpm_clk_pdev)) + return dev_err_probe(dev, PTR_ERR(acpm_clk_pdev), + "Failed to register ACPM clocks device.\n"); + + ret =3D devm_add_action_or_reset(dev, acpm_clk_pdev_unregister, + acpm_clk_pdev); + if (ret) + return dev_err_probe(dev, ret, "Failed to add devm action.\n"); + return devm_of_platform_populate(dev); } =20 @@ -746,6 +766,7 @@ EXPORT_SYMBOL_GPL(devm_acpm_get_by_node); =20 static const struct acpm_match_data acpm_gs101 =3D { .initdata_base =3D ACPM_GS101_INITDATA_BASE, + .acpm_clk_dev_name =3D "gs101-acpm-clk", }; =20 static const struct of_device_id acpm_match[] =3D { --=20 2.51.0.355.g5224444f11-goog From nobody Wed Sep 10 01:32:53 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9793E30B520 for ; Mon, 8 Sep 2025 13:13:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337187; cv=none; b=Vry3i3BHBuG5Ik113Owc749+8FnBKO3gCd5zgnNwT7fOU3fQ0df2ev1cy7amkje8NMehKFedWtQ0dhDtQsoQ5tenKxz67skFbN6evLbktMcoe65t0VzRVwzoYI39LRxT5hnibQX+Dhc5+xF1Afm0fmS9JHfBsZMRGSQggMYj9m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337187; c=relaxed/simple; bh=zsTISx5UPB2MF9C+zHG1pBXN7EwBKTxj7oyZeiQZndI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GHMlszkPtlLWIA2+p1o8VJkZ4mUiXHn3xNqDH3P8oqSrP56NlUY//jWHd+EMd5gAJMDVVxOs+NVECBAz++OKbw7k8WQvrgWrTlcoVgl2MSlVznUC745/gwZReznyXFA5SF13Y1J2tIsrRYGlMBx77Tn1jfomoDfrEQiX8iDva4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NeyDu8hM; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NeyDu8hM" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45dde353b47so7779565e9.3 for ; Mon, 08 Sep 2025 06:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337183; x=1757941983; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nn4ZPBAE1p0WQez+p04HAUrpmNRFyGY7kFnsP9wLhQ4=; b=NeyDu8hMPzY2PwTLQ0d2F3vgR83XUh81rQQt5u+I5qCGWknVPtd9KOR7CtkEyJx1gt ly6fNYu3aFqKt7tU4ITbXOWgqwi8M1RHr0E3X9qwf1OSEmB+54+014MiT/H+682b0hcG s+3A5N7q9eRdvAWa9auoMXYlMHkjMMnefbF4g30ZObE2PswtyTLomQYztTcWVf94RCm9 ZBMXjRHIszwyMOJoVAeAklZIQYBdwfEklMrwpBYqgKunH8MaJt8/v5nSd2i+eP93wGv9 3RjpqIrvnoV1vANLps73vqCDCguUrDOhhp7phVYhEOEn2FUSjqu6Ugzdw992X+gbLqgX OZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337183; x=1757941983; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nn4ZPBAE1p0WQez+p04HAUrpmNRFyGY7kFnsP9wLhQ4=; b=BlV/QujbuuvA5sryrWkL/kb6ekdN8DZGA8/X48CqeaIaM1HFwGL0hUBleu2FImRdnw XhCasaLtqcDDoRUvrNZudH7Rsi+rLbEr3Bu8wcft0+kbXWctfQul9d08hB+l4ZzVgdTN TgqRLFa9p3rnNS0dS6koMiKbHKv+vVyRguZvkvDTQqBdsMU1m7vSF+RtewEuDS8GBEeH KmLz36Lji3NGGW+1pR0jBS8vPIhCX2FM4bdKXa0unfCGq5FSvq4OzFOZjgEv9R7za3mr 0z2OEaTyFw6p0mXpRi4NieCKrp/xIoXTCOcCG8Zwy3hnYRONJ5eJlo0/3LNLUFRIEHTW vMjQ== X-Gm-Message-State: AOJu0YwCeNBh1OWEcl3owRXNQyfJUxQlikhKyXbA3JOVL+dd+c610ijw /pfDVmczuuzeyXSsgQZ7OcIjl6xg0xSn1bhlrmEA4fQXHzCc2Wyg8jUPpG5v7w8zXT8= X-Gm-Gg: ASbGncuDil/al7pEezJ3INjv3RKctR/ODMgQ5036nBM+kR2VWLIQQXXgA+tRv+T17Bo Ukc9QNXLy04btjK47lQwztFdFsZFPxr3VWPDRxc8d1dn35CFKcwjzdq7m/8YnDlziJYp0r75iox A1MzZ8yGjH+8VwtK97GTvn4bJ6OeY2FD9yfuabbpNwOJT86mZN+kmzRRrUZRwmzP0wc0NDp4dMX T0TtoOVB8c/iNOYEl74F22SfUtCm1QLJyG3krJtLyG9L3Z89ngxTa6d2beu1WPbP4Y2glVHr1w7 rGj8DfCQWzbsJy8Ac48+pI7Kjvu1So8kpaEIVH1E6gY43gEkxaGy8uHLIjMDzvIkWi5LCMBeV8C b8Op2SZwnO2ttasiQEl6pk+snsliak/ADtcDwmfSUZePupsLWQj9NSH44UIPLQqw7IM+WjrYSAm nzMgzoAUudo2ES7sdsQzysxkw= X-Google-Smtp-Source: AGHT+IFG/nu92v+wDSAVp23lec/lDejCcvcTcEear99V05L3y7tvjn8NlMnCha7VWiPcoMj0sS7ZnQ== X-Received: by 2002:a05:600c:46d0:b0:45d:d96e:6176 with SMTP id 5b1f17b1804b1-45ddded62d8mr64725115e9.25.1757337182856; Mon, 08 Sep 2025 06:13:02 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:13:02 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:45 +0000 Subject: [PATCH v4 4/5] clk: samsung: add Exynos ACPM clock driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-acpm-clk-v4-4-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=7029; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=zsTISx5UPB2MF9C+zHG1pBXN7EwBKTxj7oyZeiQZndI=; b=zbluNhnpemXb2upjzba7C8KRFYiQ/Zq5DEYaQoCPHVt0hznA8jI0TJt8M6MjE8C9P5mwSqY+y Xv81evSTexqDqIGqCSJ6Kgk4GNdG+YC8HXM75OVGd1JvWoQUEM3AupW X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add the Exynos ACPM clock driver. It provides support for clocks that are controlled by firmware that implements the ACPM interface. Signed-off-by: Tudor Ambarus --- drivers/clk/samsung/Kconfig | 10 +++ drivers/clk/samsung/Makefile | 1 + drivers/clk/samsung/clk-acpm.c | 184 +++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 195 insertions(+) diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index 76a494e95027af26272e30876a87ac293bd56dfa..70a8b82a0136b4d0213d8ff95e0= 29c52436e5c7f 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -95,6 +95,16 @@ config EXYNOS_CLKOUT status of the certains clocks from SoC, but it could also be tied to other devices as an input clock. =20 +config EXYNOS_ACPM_CLK + tristate "Clock driver controlled via ACPM interface" + depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL) + help + This driver provides support for clocks that are controlled by + firmware that implements the ACPM interface. + + This driver uses the ACPM interface to interact with the firmware + providing all the clock controlls. + config TESLA_FSD_COMMON_CLK bool "Tesla FSD clock controller support" if COMPILE_TEST depends on COMMON_CLK_SAMSUNG diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index b77fe288e4bb484c68d1ff497acc0b83d132ea03..04b63436b12f6f5169575d74f54= b105e97bbb052 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -27,6 +27,7 @@ obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-exynos990.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-exynosautov9.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-exynosautov920.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) +=3D clk-gs101.o +obj-$(CONFIG_EXYNOS_ACPM_CLK) +=3D clk-acpm.o obj-$(CONFIG_S3C64XX_COMMON_CLK) +=3D clk-s3c64xx.o obj-$(CONFIG_S5PV210_COMMON_CLK) +=3D clk-s5pv210.o clk-s5pv210-audss.o obj-$(CONFIG_TESLA_FSD_COMMON_CLK) +=3D clk-fsd.o diff --git a/drivers/clk/samsung/clk-acpm.c b/drivers/clk/samsung/clk-acpm.c new file mode 100644 index 0000000000000000000000000000000000000000..8566495265ee3e06dbf370f9e42= 4d5540f5c7457 --- /dev/null +++ b/drivers/clk/samsung/clk-acpm.c @@ -0,0 +1,184 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Samsung Exynos ACPM protocol based clock driver. + * + * Copyright 2025 Linaro Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct acpm_clk { + u32 id; + struct clk_hw hw; + unsigned int mbox_chan_id; + const struct acpm_handle *handle; +}; + +struct acpm_clk_variant { + const char *name; +}; + +struct acpm_clk_driver_data { + const struct acpm_clk_variant *clks; + unsigned int nr_clks; + unsigned int mbox_chan_id; +}; + +#define to_acpm_clk(clk) container_of(clk, struct acpm_clk, hw) + +#define ACPM_CLK(cname) \ + { \ + .name =3D cname, \ + } + +static const struct acpm_clk_variant gs101_acpm_clks[] =3D { + ACPM_CLK("mif"), + ACPM_CLK("int"), + ACPM_CLK("cpucl0"), + ACPM_CLK("cpucl1"), + ACPM_CLK("cpucl2"), + ACPM_CLK("g3d"), + ACPM_CLK("g3dl2"), + ACPM_CLK("tpu"), + ACPM_CLK("intcam"), + ACPM_CLK("tnr"), + ACPM_CLK("cam"), + ACPM_CLK("mfc"), + ACPM_CLK("disp"), + ACPM_CLK("b0"), +}; + +static const struct acpm_clk_driver_data acpm_clk_gs101 =3D { + .clks =3D gs101_acpm_clks, + .nr_clks =3D ARRAY_SIZE(gs101_acpm_clks), + .mbox_chan_id =3D 0, +}; + +static unsigned long acpm_clk_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct acpm_clk *clk =3D to_acpm_clk(hw); + + return clk->handle->ops.dvfs_ops.get_rate(clk->handle, + clk->mbox_chan_id, clk->id, 0); +} + +static int acpm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + /* + * We can't figure out what rate it will be, so just return the + * rate back to the caller. acpm_clk_recalc_rate() will be called + * after the rate is set and we'll know what rate the clock is + * running at then. + */ + return 0; +} + +static int acpm_clk_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct acpm_clk *clk =3D to_acpm_clk(hw); + + return clk->handle->ops.dvfs_ops.set_rate(clk->handle, + clk->mbox_chan_id, clk->id, rate); +} + +static const struct clk_ops acpm_clk_ops =3D { + .recalc_rate =3D acpm_clk_recalc_rate, + .determine_rate =3D acpm_clk_determine_rate, + .set_rate =3D acpm_clk_set_rate, +}; + +static int acpm_clk_ops_init(struct device *dev, struct acpm_clk *aclk, + const char *name) +{ + struct clk_init_data init =3D {}; + + init.name =3D name; + init.ops =3D &acpm_clk_ops; + aclk->hw.init =3D &init; + + return devm_clk_hw_register(dev, &aclk->hw); +} + +static int acpm_clk_probe(struct platform_device *pdev) +{ + const struct acpm_handle *acpm_handle; + struct clk_hw_onecell_data *clk_data; + struct clk_hw **hws; + struct device *dev =3D &pdev->dev; + struct acpm_clk *aclks; + unsigned int mbox_chan_id; + int i, err, count; + + acpm_handle =3D devm_acpm_get_by_node(dev, dev->parent->of_node); + if (IS_ERR(acpm_handle)) + return dev_err_probe(dev, PTR_ERR(acpm_handle), + "Failed to get acpm handle.\n"); + + count =3D acpm_clk_gs101.nr_clks; + mbox_chan_id =3D acpm_clk_gs101.mbox_chan_id; + + clk_data =3D devm_kzalloc(dev, struct_size(clk_data, hws, count), + GFP_KERNEL); + if (!clk_data) + return -ENOMEM; + + clk_data->num =3D count; + hws =3D clk_data->hws; + + aclks =3D devm_kcalloc(dev, count, sizeof(*aclks), GFP_KERNEL); + if (!aclks) + return -ENOMEM; + + for (i =3D 0; i < count; i++) { + struct acpm_clk *aclk =3D &aclks[i]; + + /* + * The code assumes the clock IDs start from zero, + * are sequential and do not have gaps. + */ + aclk->id =3D i; + aclk->handle =3D acpm_handle; + aclk->mbox_chan_id =3D mbox_chan_id; + + hws[i] =3D &aclk->hw; + + err =3D acpm_clk_ops_init(dev, aclk, + acpm_clk_gs101.clks[i].name); + if (err) + return dev_err_probe(dev, err, + "Failed to register clock.\n"); + } + + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, + clk_data); +} + +static const struct platform_device_id acpm_clk_id[] =3D { + { "gs101-acpm-clk" }, + {}, +}; +MODULE_DEVICE_TABLE(platform, acpm_clk_id); + +static struct platform_driver acpm_clk_driver =3D { + .driver =3D { + .name =3D "acpm-clocks", + }, + .probe =3D acpm_clk_probe, + .id_table =3D acpm_clk_id, +}; +module_platform_driver(acpm_clk_driver); + +MODULE_AUTHOR("Tudor Ambarus "); +MODULE_DESCRIPTION("Samsung Exynos ACPM clock driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0.355.g5224444f11-goog From nobody Wed Sep 10 01:32:53 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54D7B30BB86 for ; Mon, 8 Sep 2025 13:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337187; cv=none; b=pZ94dyX2zFcKwM/eBhzjTrc4uoXwhdf87OwctuScHK2Cv+KlvYRvV6V1Sx2Ihf3wryFfdtb+nhiwkh5O7brcGkxdOVNbin05k43Xtaaizcb4u5suiX9yoVXV6ic6ra80r4pIwZ6jmKgS+PWH6ENBeA9kHLFWNDXaY2zS26RDa0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337187; c=relaxed/simple; bh=r9B8eJrWR/g38PUeQ9J2wFXWREa48OIMpTY6cZptlBw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OflqBowCghQVX9JNLHyRMBRFybZHEwsu9JJ7vR/krXJxmZoNE1e9AMcKZeBvTnWRjHzz+HTcHMxMHbtj7+jy9wsiAyqxQhSfWWxvroiirfVUi3nTL+EKgt5OcbM//GkrWSLvPsV3vjAS9l5e9jYs32R9yT6jfNnIDST81tC6YAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gfYgd4/m; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gfYgd4/m" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-45de64f89a9so7602905e9.1 for ; Mon, 08 Sep 2025 06:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337184; x=1757941984; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HX1P98lL0ntVTFobuHZJG04rSny4tquvD0IzM102LdE=; b=gfYgd4/mMQtSOhMVWToxxh3TVJ5Ttd4tiKfBFq3/plCL4xqF4FqEtMRXWDmASYsZNv 1W5WdCcLPvjtpdqg+hL/24jZa2tKC/jEfopUTgEpFQZDXygZbev/2HYFMVjvv+VFcQfB k8wHoFAnN8mXzChyZHGYGJH3TdfaJf9XqnFfvgtioine3k/ouSD6aLqpaQvFWiVPrAl5 8fZTS9+kCEYX9JQWxBgrxyAn6deGUAyGMflM1C+BRiYsE2EBexxJDIwOpPc1O0IsljI+ I+04QdD8Hl7XpjGrDEBq/3/EnVPuyhqY6BhzNMQhLHJgB82NAawPeXcK/XJhlnE1cjZ8 UwuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337184; x=1757941984; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HX1P98lL0ntVTFobuHZJG04rSny4tquvD0IzM102LdE=; b=LHnBCMDGSp6LACCyQFBCFOqO3Ryo/Sp3jUuZbvDssqwUgAFxnlegD6a/h53zXUSXk0 kST+4jUPoY4qP/nY3VO5zWnHGFynXZTI/BYv67koiSxo4rghZcKyK6H5nuvQlmDN7uj+ k9vSyQJMObQPNdq7qBzmR1UvgaUnavrRbLEQNT9GwmfnFnu350al4/Tj/fRvhiw5C1/j ReHxWu3rkSc0l3uA0dW86OKrPJQMhxzbXMx5cqNQoC5U8mrdY4ylhbkND0un9EbM42ve V0bI5mSpJC3nwGtC0Y43hDONzaI0ULjGvewENVNkXkJRrjf3DdNprH7lhOg2XpdatiAu S9tg== X-Gm-Message-State: AOJu0Yzp8xAq/8euZ+jXMjwsqTDZR0u5NG4H5jOQLLmZIIK4UwhQqcj1 mH+nw6h9oV1KcEauI1PfM+FWACCLoSdUu2sVNsy30tRT2694wfDQliRS8AnUJ204BME= X-Gm-Gg: ASbGncuaEyPfWdMg968d9EpEJPTLrJKV+DKLOIKS5doECgkWFeVJA4ORnnef1qVP0zu nGhZMVY3jnZFk4miRY/CL9iYP+xHh5y2n9Ur4R0JJhDqzSjfsrTKY2V5/1WuVMo5YGvS10GlpGL BGXrwHhdSsnZbmFSRrfJRrfCPo8/TmwHWI2qAk8HXFT4fZQlHfwwUlTJlBzQ5REVlKcTkieurc5 EwPgTd2qNlo34cNKe/zQvURz1sIQeI1wbRLE8S4sIWxqgTUgCVim2t3f/fgf8bHvToCC1kVxrA1 2qz5unzGCr4yjjgaq6+zDlpiwe6QPOKDGu7KAGxW8L/AAd9sx+bSrsE8ncz57F8UQuztFX29jpJ XuvL4F/3UhgnM9ma7O36HwfApvzQ7cvecf/y2r/Dn8AMFhL3KzAa96HXtGMCCSZzgxYwx+fNyDB 6ry/hf+w1f2BFF X-Google-Smtp-Source: AGHT+IHrei69SE3S2Wo3PhQL3nGzDL0r6xFLtoIiPAj8bXHlYe0awD9SWK429eaX/ZmPsA2F6T6ySQ== X-Received: by 2002:a05:600c:354f:b0:45c:b61a:b1bd with SMTP id 5b1f17b1804b1-45dde220a2emr74636385e9.18.1757337183601; Mon, 08 Sep 2025 06:13:03 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:13:03 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:46 +0000 Subject: [PATCH v4 5/5] arm64: defconfig: enable Exynos ACPM clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250908-acpm-clk-v4-5-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=820; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=r9B8eJrWR/g38PUeQ9J2wFXWREa48OIMpTY6cZptlBw=; b=9ggP3KUVS2zT7FryKyHNIZtbBh3Rqan9vA/aNkZzb27KJvR7ycYAxiFo0bkteyhSCJ1SQvT4Z n+0HD5LlcvUD4LkTHTo1imFXIzH7ED6AZ4JOBehLysGJoPG0239vgL0 X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Enable the Exynos ACPM clocks driver. Samsung Exynos platforms implement ACPM to provide support for clock configuration, PMIC and temperature sensors. Signed-off-by: Tudor Ambarus --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 58f87d09366cd12ae212a1d107660afe8be6c5ef..4255bc885545fb3bb7e9cf02760= cac35bf2872fa 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1445,6 +1445,7 @@ CONFIG_CLK_GFM_LPASS_SM8250=3Dm CONFIG_SM_VIDEOCC_8450=3Dm CONFIG_CLK_RCAR_USB2_CLOCK_SEL=3Dy CONFIG_CLK_RENESAS_VBATTB=3Dm +CONFIG_EXYNOS_ACPM_CLK=3Dm CONFIG_CLK_SOPHGO_CV1800=3Dy CONFIG_HWSPINLOCK=3Dy CONFIG_HWSPINLOCK_OMAP=3Dm --=20 2.51.0.355.g5224444f11-goog