From nobody Wed Sep 10 08:41:22 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4B627FB0E for ; Sun, 7 Sep 2025 14:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757256747; cv=none; b=byW89ne5pO7tARrb8RF2h43HG5CpSwsNRtd478Ao+yNi7Aym+mx3F6kC3qgrRDLXYvM+WUXeWXcZWsdPHucwsR2EaDMW5Qv1EUhfBQdTkM+QDi4Yv0cDX2IB6rU4h0cZaowUW/lB0QMKhXSY39UvDfUgO+9JNH04iFRo2rcwlwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757256747; c=relaxed/simple; bh=/UGpwgqLbcHspMjEQhf+040bOSKXnckhqkr7K5HPcSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rh1/x4een/lLd67RalSM6/LXU8Z9XsVgR6Lwl6XNO+qvZ0Pcsq5nbzOPk9P5WuxRIjgpGfR8o9/PFmTWUO9RokVxyhPg4u34nSUU4r2yINvvDGyOhrxLJ4xLFamN4KUZptIsVi04/ReMmcscHTgCfvtDHW6lK/jVza52YctpqHE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k+5/s9Yq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k+5/s9Yq" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5878kAD7020355 for ; Sun, 7 Sep 2025 14:52:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uXEvIWnbOkICzt6MJ22YL53UMQf8f9LrhVZWM6rbuZM=; b=k+5/s9Yq0AystLw0 z47uMBoFuMyOgGp2TvjsW8HNhZa5GFeciREo216E552wXVaExN9H8eKhlPcw42Ch UULoZ8wNMc5aRnmqO/VMVzxqDzYvD6Jj2qPthu0p+Mq/EkHTg6ApEbSxHIkqMXTH Ml/0WlrthOzud/kTqmwGDVybMz5PO7mTLW0L2u3I04rus1nsAiGcGNmRZDd6fBKr VYMhjeqHe/+laUCWSlUdHVa256M35rA4r61HPcbc6ww70BNRT58KIX+s6LqCeMOy 7/WlZKWRFKCqlvb5T1Ylc8ILFNcEFsEBwdJGaff+x8+zxwFYWjOi9/2gC02Vzqtk 1FZFhw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490anfae2a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 07 Sep 2025 14:52:23 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-718c2590e94so110174826d6.1 for ; Sun, 07 Sep 2025 07:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757256742; x=1757861542; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uXEvIWnbOkICzt6MJ22YL53UMQf8f9LrhVZWM6rbuZM=; b=l6clkxDpW00EYgFJqZt+MZJwAjOup1AlkmOxFhatNBUnATLl6jHUApAer5sWH9LGPB 9CYRaDj4jCGzzwdsHF9LAQjuDNygkcDgTwvZdsaqVCZArA/b0qFJN2JQKHKYsxTSQXjv aTZJ6vhEip5z5RmuGaYCpm46tbtSQOiIKAt9VEvGJhppBLV8y8mI//xGUbFBP+PLd9Uf AreUmlmsTFac9XvjLP0qapFxQnwUdm1jI3GN23TNtL2HMAbiRHpxaGxCBOt8kAoqcQUR 3ItfUEbufgpWULNsuRwwlphvQ5CpeZ8veMHtAwSBTAGPedOW58s7bO7S7rlUAC8iZ47E /5tg== X-Forwarded-Encrypted: i=1; AJvYcCWM5Ftcm+5wSumlSxBGeJfu+UeT7ma5E5QocXOluvxbTEhro7YWvtZ3tJD13Sj0SrWyocvLu5pS5V2bpA4=@vger.kernel.org X-Gm-Message-State: AOJu0YwTx2o9hT2FYWuNbmVG1K+pZktqeoZVLOh25F3aJ5HLj8S3Iu+y kX204obRbuUVCIewegrxPxMrv21/AWPksnK5hXPWCluGDc1B9c8lnUVvuWxydLloe4fyfZev0Vo atCsPOJUbcjGsrh2kMz7yO6QpntbgNu1eZwKwjfGsq9dD75fw+XJBMhvC+bS1Gg2bMHB5xXGwlt E= X-Gm-Gg: ASbGnct+GoAqZR6XcDgkILNJgt4mLZo2RDXcWk5WLg8hTpIK2Q5a6ALck5SWkP7CkwT JnkM3LY+wZaInKDZcMqePZaBAguZ4KdHp/xLxzGs7R/RYX6o8ueXJQASbotqOAK0zspy338wa8o Mo3UwvFKGDJ6WM95xmUASz1YGoz3lsTHSXmQPMNdlUT7uV/2s6R7+AG44MNm/376KBimR+9VFJS lEyR/YHpiyVLCSlOrwrKIX5nfiIN8+tHrKAEtBTJ6S7/6cDbNHaJuzAjE6C/hyjiu8Lar/GKQ5Q 8JGxBEbGnmQM6awEl0Prf7/4QPRqA+t0eom2HEW30zCsk6J60UtY/E1aXA9GsuN5eoqKsss/L2V pn3Ss4CAXCEt4niM+Da9ioecnnm7vz8yMFcRoJ8PjJHVZ7X+3+7Uj X-Received: by 2002:ad4:5de2:0:b0:722:2301:315 with SMTP id 6a1803df08f44-72bc4f93957mr111576566d6.29.1757256741906; Sun, 07 Sep 2025 07:52:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJHVWmsQlKEwtB5F5SiO5c82N/76wI2OG3Sj8gZLObDi88o8+yPn/Ihsm5i+eJImPr0TQ8pQ== X-Received: by 2002:ad4:5de2:0:b0:722:2301:315 with SMTP id 6a1803df08f44-72bc4f93957mr111576406d6.29.1757256741535; Sun, 07 Sep 2025 07:52:21 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5608ab939d5sm2936738e87.46.2025.09.07.07.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Sep 2025 07:52:20 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 07 Sep 2025 17:52:12 +0300 Subject: [PATCH 3/4] phy: qcom: qmp-pcie: simplify AUX clock registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250907-qcom-dp-phy-v1-3-46634a6a980b@oss.qualcomm.com> References: <20250907-qcom-dp-phy-v1-0-46634a6a980b@oss.qualcomm.com> In-Reply-To: <20250907-qcom-dp-phy-v1-0-46634a6a980b@oss.qualcomm.com> To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1929; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=/UGpwgqLbcHspMjEQhf+040bOSKXnckhqkr7K5HPcSw=; b=kA0DAAoBizyKPgIpKNUByyZiAGi9nB+i9+O9rWaagO59RyRA3FTS3nlrOFKSSJecf0T6cqpxR okBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJovZwfAAoJEIs8ij4CKSjVJ0MH/174 EKbry2VSI0M+MUUSLJmimpY5GH7+VCNsepDpKLUGeAx9epYlURX1qqEWtMLgZhnC7fxl0Ms9Gj6 vEsnSYED1WugA8B07PptbGtGULT/ZaoymEJPZmnNnLiOf7NcxrLlH0/+5TK1CdmIjNKRyfwe/hU hFXMuLJ00qiU4O0Qy2SD6/IW0EDyFgGIVOM/Mf//WKD/DHNbPv+I0TZUKbTqn1r++ftc3Ni2hAe fzXhjUvgpFuviZhcT+f/CdsuGoyWtgBGZ/ljCPqlgSjhig+dtejUKa0dPa4zHD6VUDU1t8kAbEc 0EptjSVcqQXN+SDvHcdet2KL7Ua/DOSCmOM5vks= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: BXu4tE0JQG5FRzUv_4nZhlwomknC-TWa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAwNCBTYWx0ZWRfX7mAugcXKN7Kv 85sLOzOx/D1eU07n9qI8MqrllUfG4Af5/yhm5erSefdj/9/x/IrJAd2rHF8dYzwsMfzpheQ+bf3 tzfD9AfsF9fgaVFPT5UK9wXEDjvtuFn0rKOpahq0NRiVkVdTB+HS5FG6CS3PxhkJCw9jTH+i7G0 6LotPN7fJQi6f8V2xzvEjBjCYyXdVkIw6fldsOVB8duOawOUBiHkvtFKKsj1e1EOjklw0HZe+v/ /xvQGCHFx/y5c4pzsicORxwOFdmzFsp1iW0ZcE8o7MsI7DnToB49zrtpl6LbJ5FreyC1WBmv7RU Wq7VYDhLgXEBBQY6fE4+VJckP5bdbj6y8dEVHZduZGIDmHbyf+GRHbvVP99+gWvB3/yo42v8e99 30Pa9QKq X-Proofpoint-GUID: BXu4tE0JQG5FRzUv_4nZhlwomknC-TWa X-Authority-Analysis: v=2.4 cv=CaoI5Krl c=1 sm=1 tr=0 ts=68bd9c27 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=UpTUyc56fgFd2ZLN3CkA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-07_05,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060004 Instead of hand-coding it, use devm_clk_hw_register_fixed_rate() to register the PHY AUX clock. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcom= m/phy-qcom-qmp-pcie.c index dad44cc0648355fc1533c9afd176b7d37cfa9018..a81facec7e45304f26ca3ce165a= f90aa5ff56f4e 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -3173,7 +3173,7 @@ struct qmp_pcie { int mode; =20 struct clk_hw *pipe_clk_hw; - struct clk_fixed_rate aux_clk_fixed; + struct clk_hw *aux_clk_hw; }; =20 static bool qphy_checkbits(const void __iomem *base, u32 offset, u32 val) @@ -4809,19 +4809,13 @@ static int qmp_pcie_clk_init(struct qmp_pcie *qmp) */ static int phy_aux_clk_register(struct qmp_pcie *qmp, struct device_node *= np) { - struct clk_fixed_rate *fixed =3D &qmp->aux_clk_fixed; - struct clk_init_data init =3D { }; char name[64]; =20 snprintf(name, sizeof(name), "%s::phy_aux_clk", dev_name(qmp->dev)); =20 - init.name =3D name; - init.ops =3D &clk_fixed_rate_ops; - - fixed->fixed_rate =3D qmp->cfg->aux_clock_rate; - fixed->hw.init =3D &init; - - return devm_clk_hw_register(qmp->dev, &fixed->hw); + qmp->aux_clk_hw =3D devm_clk_hw_register_fixed_rate(qmp->dev, name, NULL,= 0, + qmp->cfg->aux_clock_rate); + return PTR_ERR_OR_ZERO(qmp->aux_clk_hw); } =20 static struct clk_hw *qmp_pcie_clk_hw_get(struct of_phandle_args *clkspec,= void *data) @@ -4836,7 +4830,7 @@ static struct clk_hw *qmp_pcie_clk_hw_get(struct of_p= handle_args *clkspec, void case QMP_PCIE_PIPE_CLK: return qmp->pipe_clk_hw; case QMP_PCIE_PHY_AUX_CLK: - return &qmp->aux_clk_fixed.hw; + return qmp->aux_clk_hw; } =20 return ERR_PTR(-EINVAL); --=20 2.47.3