From nobody Tue Sep 9 21:36:10 2025 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B14E72F83C2; Sat, 6 Sep 2025 13:54:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757166855; cv=none; b=GeHwFhuNplVFdSgNtBcbKSwrzBbJ9BAXmkTuG6z5v9W1dbN0Oc8PDmTAgszuVmkixbFZdPizaXmKumQYX+5/K7N2kKVrUeECYkqtyYbbDORc3L5CcAEy0TLlrDkqzlbVoh2r4ZbY6e//udr3+GeVOJ9+A72Ywv/YlC4AJPHBXMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757166855; c=relaxed/simple; bh=u+qJVWyapenrodgmMyyh5sdeoJQIHo+UHZurPNrBBEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lf7mP6d9bUMoV9/BSLF/wWOzz+ZT1995Z7B6/eR0tX3pLh/H22KC0xcFyE3Z6wkU1HD+Rs1kKsehftgjwZFmWRFLONEtK/giMEIplhzudX9JrUzW3gH7l8fOBVGkavU1e216OU6fDcuU4MBX4e8b8K7v3GjKMYv5oPEDLPlHqTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJhZd0Dn; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJhZd0Dn" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-55f6186cc17so2893387e87.2; Sat, 06 Sep 2025 06:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757166852; x=1757771652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oNnZ9HXiG4U5oHkge6rfZLR0dPMVP9tD5A0n1Dg/8XI=; b=ZJhZd0DnpY6QFhTpSM8FmPN8/v4tSM/05x3m6avMlGBT068tOV4XypwB6F1YmT0wbR Iv2eFeFVNfoUdkcbHSVU421bUWLWWh1K3pZkdYEw8ydpvq35v+HwDa5hlH1XCtCEaqCX Nrr0ykCorWHmRLluwHcwJ+dROI8ygvo8PioEmqUmuzaszBMi5mwW9GN0A3+nioYQOk/i 9vhx3JJ4MX7cuVNr5tOu3Y4/I+bVnip9bVeDT2dedjwIXs8iQ9j2bkbR4bl4xs67ai6h rpuTnx91I4yoC3rBza1kv4ZAXUVXb315UHLtBckCcIA6rqo7FmNNt/UNvAYxg+tCfPiX gL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757166852; x=1757771652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oNnZ9HXiG4U5oHkge6rfZLR0dPMVP9tD5A0n1Dg/8XI=; b=rJGgryO42Pv7fKQaMA+MXSpdPWGNoLbpER1yH2PscyJv1BVMc/bmCHgejRTukWfE/R YnWkEX6jD8nQRB+jRO2huTy+01TsymHdMoCfnElUgwWDqO9d7vB95D0CkcjIomFQUygB iafbSsVtmAAKX3CaV3P3EiE2k4EDdNbMsEPrdXBX/ViIXFVuZOJXX7w7mAV9roBeUYlZ 0IENuFna3+6Stm50kEvwPCZQPF05QLL5rWUoYM4Mn7dNFRPm3jEhelmQ3y+ZudYs7E1J y4DlY0kqxmwqABjsC1PCTDwN0CZgL+pratPtQCVNSZ0X6Fig2F3oZ//V7tEG6A2pLhr2 EdUA== X-Forwarded-Encrypted: i=1; AJvYcCUsmk0ux2TH9RzVTCmZ8aVKv80M9YL7JUytkCTUEgidvBVHV3L70cRuaxWuvVQBoktZV894Fuh1BKX0@vger.kernel.org, AJvYcCW1Y14zFV2yvRMYtnWS87uQTzCO5mBld9kHNvvvWIqhwG9ThqleG/8MwTuE0nqZazUttWfY3/mBAAHedKLI@vger.kernel.org, AJvYcCWBicVaK6V0p05x30JKTycL3dtm3Kta74Zcs5DQRK9eGXnYDoy2oh588rcgGckOK6UCxvCg1IyiIiIbSDw=@vger.kernel.org, AJvYcCWlRAHuKfrd4ns3EhzTpZAZ0EVch5IiVzujtYIVaVodG/qTY7TW70FcV/lbt3Drn+IW52rz+O5KdLjQ@vger.kernel.org, AJvYcCXNtwwqnGDe1RMTb2pIz6H2iKU3dHrhO4/PDnBhQ5c5DV7uSQp0qMYZ1YCmTwLyWh9aW7n7rNdWwKn20Wk=@vger.kernel.org X-Gm-Message-State: AOJu0YxI11E3uR+/0yNhGN8iS+rxyfA2WIRg5sh/j7nZZBejoEwfo2sR V+trDXD3oUnUZE1xEnJpDnHL/Kw0Oa2VN90FWBHu7DuBKZnFk+KWsdFJ X-Gm-Gg: ASbGncu+Ww8KqlHv8SpWpHcYZCevxqAjChHCmShPpttUQCK7AGdscBvrjC2YeVp8SZF Gbx8X/+P6ZeDYCfm6fgQUrb5/g0nlFPs9R4R/9wTBATwhJMao8pOgCzmbIJrSClX+4+9WUHtuxg EobYwihkj8FDl+69ZKa4vmSODa9RDbF/qyrHSX7GQMfOoaau7gb+DLHdbFkWghyEfum9epX1KDw U7WglBThKkvI97ENeOCiP1nfTacL0Y0bJJSCeU1zoZPquGBFJvHXFm/1EaiJYK/49NVql3bsW7t gR/4qqmokWytW6PG4/2fW4h1tTEUE0jAN/e8Ecd69CYSAjulREdRUtUMWlmirrj2a5skBNzd9dB emvXjGwboDM4MSNW/Lk0MkqWA X-Google-Smtp-Source: AGHT+IFNdBjIXq5sYz1MCdAhWLRCrwcVaq6AC94sETsLdKECpgkyBPhg/M7G3wdyhSPEeg7Mdr0rBQ== X-Received: by 2002:a05:6512:1390:b0:55f:6eed:7805 with SMTP id 2adb3069b0e04-56261313e4amr564548e87.2.1757166851621; Sat, 06 Sep 2025 06:54:11 -0700 (PDT) Received: from xeon.. ([188.163.112.70]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5608ace9c65sm2357467e87.85.2025.09.06.06.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Sep 2025 06:54:11 -0700 (PDT) From: Svyatoslav Ryhel To: Thierry Reding , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mauro Carvalho Chehab , Greg Kroah-Hartman , Svyatoslav Ryhel , Dmitry Osipenko , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= , Charan Pedumuru Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v2 06/23] staging: media: tegra-video: vi: adjust get_selection op check Date: Sat, 6 Sep 2025 16:53:27 +0300 Message-ID: <20250906135345.241229-7-clamor95@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250906135345.241229-1-clamor95@gmail.com> References: <20250906135345.241229-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Get_selection operation may be implemented only for sink pad and may return error code. Set try_crop to 0 instead of returning error. Signed-off-by: Svyatoslav Ryhel --- drivers/staging/media/tegra-video/vi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media= /tegra-video/vi.c index 7c44a3448588..856b7c18b551 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -476,15 +476,11 @@ static int __tegra_channel_try_format(struct tegra_vi= _channel *chan, fse.code =3D fmtinfo->code; ret =3D v4l2_subdev_call(subdev, pad, enum_frame_size, sd_state, &fse); if (ret) { - if (!v4l2_subdev_has_op(subdev, pad, get_selection)) { + if (!v4l2_subdev_has_op(subdev, pad, get_selection) || + v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel)) { try_crop->width =3D 0; try_crop->height =3D 0; } else { - ret =3D v4l2_subdev_call(subdev, pad, get_selection, - NULL, &sdsel); - if (ret) - return -EINVAL; - try_crop->width =3D sdsel.r.width; try_crop->height =3D sdsel.r.height; } --=20 2.48.1