From nobody Tue Sep 9 05:51:31 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121B4315D3C; Sat, 6 Sep 2025 01:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; cv=none; b=MJIrw14CO+hC24avhJbQ5ricAD7lP3oHHxv4DXuJQ3uUXfD0mNSgAUSZIsHb2tXW02LAMI0JQTJMPRuwg+YlfKGqscyyia1KHpNMqBK8LFvbi/p0VhX+1xV41MIB8IUsQlCCAgwGclWTIWgP3sSLzenV2Yz1ynTYwIvz4wd963U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; c=relaxed/simple; bh=HycOeBz2FihO/ksjDTGyARGoNP6WXbmt9//2f3kTqN4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D8DFU8LxuZE+MuzCZdOFjvpEnI11M59QPa6d8ZATRN3+RdnkYkyO9NwaTy/teHo4cX0Ntt5Oq9bzDfaw02a5C3uWw5NkMLdXXu2JQLVUaQCIi0wvozSEaiVDJHIxCa2IfRmwpzseDgc7x076dswT8iFUMjCjSilQUp4QdpFBwG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HtG1PLnf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HtG1PLnf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 740E2C4CEF4; Sat, 6 Sep 2025 01:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757121148; bh=HycOeBz2FihO/ksjDTGyARGoNP6WXbmt9//2f3kTqN4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=HtG1PLnfsPKO1AKgi/9WcphQXA0WqjNnjzmCRHLvnSHCyHGqdORLfZ1eC84p4GuPc L+mFXQiPW1P2MYHQE5VS+yxRCLMP5L96QlL061fmU12/uhLZevcPRgFtUQUBHE1z4w 3TT75aVD454riMYqTmyzntinj4hHtRLRVX1i3E+31AE4Ob0dI1ogu3VuB/7uYJSPQr GBgD+vmOzqrL+MWMvRuKG561q2FWr6Fx+sVTp1Qgg6cQTydUjSgkRnQOmlJlvlHXcH M3SeylTuaTQ8bpwb4AX3BqAGYdXZ5zJPkV2l1ADTv4rVCROwhdUsZbTKdD3xx4fOWY /XXA/bwMKVjVQ== Received: by venus (Postfix, from userid 1000) id 68EEC1801BB; Sat, 06 Sep 2025 03:12:26 +0200 (CEST) From: Sebastian Reichel Date: Sat, 06 Sep 2025 03:12:03 +0200 Subject: [PATCH v3 1/3] dt-bindings: platform: Add Lenovo Thinkpad T14s EC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250906-thinkpad-t14s-ec-v3-1-3ce6ec21ae89@collabora.com> References: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> In-Reply-To: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Mark Pearson Cc: "Derek J. Clark" , Henrique de Moraes Holschuh , Neil Armstrong , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2093; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=HycOeBz2FihO/ksjDTGyARGoNP6WXbmt9//2f3kTqN4=; b=owEBbQKS/ZANAwAKAdju1/PIO/qaAcsmYgBou4p5ZOo629YrYndKzJAIhBvHkee1mzK3x9bJQ X6UjE9MCReJAjMEAAEKAB0WIQTvZg0HRj+Lcmp5VBPY7tfzyDv6mgUCaLuKeQAKCRDY7tfzyDv6 mpwfD/9Xyt1QXtyGlE9Ikyk5UGsfP6ki315+97O5sTIOctooUcZQLflp+aATvT1dhNX6CCfDobV fi++anMqLnP8YESxCy2F/XtPoyrcgbXROcNX56UJNHZPLALP8z/LW/emz1h4WJK8Ty/obH/neKk zQMC9L4VAXu/uMDptwKUThzDqVbVaFUgJW60m0ao80ITzrDYpBougtiP+gsl3Heqkht4XSlti6d Igvd4aD/gkH6kCl6G+DRrTuUOkZz+QHN4d5zENtVk8GV0GzirosVImsbMtH3gIN0iC1emE6MuBx lt5/dGsUd6tJuosjf9+XqWDy2nUiUIFN+/qStndgjYSJ22S3fCRLJFxAXAbM8DYZkIVaYtO6mF9 S4hV/s3FRdcCJo08k1jQOtwFqTLZY5kR5ot4z2fUGdtRxiwyMBA3fZ22K0f5ooT5Aczu4YZ+st3 +xiOr6S0UpSgP2h605RLOgn1eVuYPvJc1gzzsugryT348RVf0VpUgB+PBkPiliO/rOzJQy9vrqY a36EEOiEQKyPknnKI9b74Mq8qLUanQbnhNIagChzgpwbw8RZvkw4nzo+E7uMnteqZhKv0HHNrnZ uZiiZLwI6gunY/0EMiV6zTEz79D/VjH2xHC6CB3YVp7iUCWVzV8QM/x8tnvgcci7UutxY5W9KOO GSaNfIUdgvDUPCw== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A Add binding for the EC found in the Thinkpad T14s Gen6 Snapdragon, which is based on the Qualcomm X1 Elite. Some of the system LEDs and extra keys are only accessible via the EC. Reviewed-by: Bryan O'Donoghue Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- .../lenovo,thinkpad-t14s-ec.yaml | 50 ++++++++++++++++++= ++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,t= hinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/embedded-controlle= r/lenovo,thinkpad-t14s-ec.yaml new file mode 100644 index 0000000000000000000000000000000000000000..c87ccb5b30868c7a616ec08b869= 286d627dd7406 --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad= -t14s-ec.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/lenovo,thinkpad-t14= s-ec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lenovo Thinkpad T14s Embedded Controller + +maintainers: + - Sebastian Reichel + +description: + The Qualcomm Snapdragon-based Lenovo Thinkpad T14s has an Embedded Contr= oller + (EC) which handles things such as keyboard backlight, LEDs or non-standa= rd + keys. + +properties: + compatible: + const: lenovo,thinkpad-t14s-ec + + reg: + const: 0x28 + + interrupts: + maxItems: 1 + + wakeup-source: true + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - |+ + #include + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@28 { + compatible =3D "lenovo,thinkpad-t14s-ec"; + reg =3D <0x28>; + interrupts-extended =3D <&tlmm 66 IRQ_TYPE_LEVEL_LOW>; + wakeup-source; + }; + }; +... --=20 2.50.1 From nobody Tue Sep 9 05:51:31 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C08D196C7C; Sat, 6 Sep 2025 01:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; cv=none; b=KhfEFrWxXx2pVF6E8BhqzTx9GcC1VsaH55i0jxUfHeUFa+zQlEI5oDkgreGvcDZL0zN1ml5g+oZz9+QCJgbFIhBlROw1AiXK26xTQfL5CbrLzlWa05p9D2YntZTto52ARtJNw06sWXe6bKQSo4fUelW2Zv6f09hnjkizHRMJWGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; c=relaxed/simple; bh=Uj92eq519BtGF85JbwkmAUOjF3bM6FE9soU5BTVCOD0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pijwZTEN0r6SxYfBWxSwter8kQMcZxNLSI50IeStqB5smHAielrOitybdpw/3TXeS4pioX954sn8t0mhrceSs3QhGkWehpa6whFc047YuTe6kJnx4Gl3or/I3KHAO+jO5aSM0YXPolmDjyy2DaVBNu65mVZ0t5DbAuuk1meFx70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ujXFRsM/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ujXFRsM/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71FFEC4CEF1; Sat, 6 Sep 2025 01:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757121148; bh=Uj92eq519BtGF85JbwkmAUOjF3bM6FE9soU5BTVCOD0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ujXFRsM/7qBU833O2pKTYvK0ceF571xJz5bRQ4aM09wMMY8nQgb3e2rZpWRIFLHVf M4Nq7gQqYZuR6egvfLVWTpYma1Rv9WRi8K4j2U1gKEd3UGtdKAN9tfwC3yaAzu/aLY 6zUTIbMd3aMq3/lR/CFEArOBr2twEQwFEIK+Iqr+Q21owHiCAPbI4louBlGyZqZntY AuVAcnblkNecAsKWLxZzKyfSv9ufJWFaBOrOSnQ/kfDvSiU4ONfCBYW9JNk06Jemtk bjGZh4cNtd9sZD+lBEiZaYIzkpAtJ2O4jaGFExnOiWdgg8HW+IZp4xnltQ6IJ5sgRn z8O25PwUxD6vg== Received: by venus (Postfix, from userid 1000) id 69451180B05; Sat, 06 Sep 2025 03:12:26 +0200 (CEST) From: Sebastian Reichel Date: Sat, 06 Sep 2025 03:12:04 +0200 Subject: [PATCH v3 2/3] platform: arm64: thinkpad-t14s-ec: new driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250906-thinkpad-t14s-ec-v3-2-3ce6ec21ae89@collabora.com> References: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> In-Reply-To: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Mark Pearson Cc: "Derek J. Clark" , Henrique de Moraes Holschuh , Neil Armstrong , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-msm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=21983; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=Uj92eq519BtGF85JbwkmAUOjF3bM6FE9soU5BTVCOD0=; b=owEBbQKS/ZANAwAKAdju1/PIO/qaAcsmYgBou4p5ZHIZYm8rR3uXqie+Dpa9y/7KEQBzM2anh TjqwTwE9M+JAjMEAAEKAB0WIQTvZg0HRj+Lcmp5VBPY7tfzyDv6mgUCaLuKeQAKCRDY7tfzyDv6 mv6rEACDNecszQpOwE1bz6SxpLYkO6Nm0Xme7K/VO37ktw0HLLVfhfso+go3Q/8hatOA8/8LL0Y K0RpfvWOWh04zWdY39ZOufp8rihHRWpGGFghWh8LKrGW4ZDyitcc42cO2HXv0UipYA+pDCQh8MK s7XwZ6kSuAB+wW6IaP8kYJMlZlg5k1ZBSIf2SCPihQK5RlnAcl+WCBT5pH6tmS+IXdaVxLpF8Y+ uwAptzdkd+PDuO7kZVBN/P4nNb93BHMzzjTkxUNvnTAoLVcciH22WbBvJjriVy5qLljw/bKINn/ Jviwo4kUqKpjCesCaVY0tf9fjvvD/4MppzG6q1WuCmA4pgAtIuq1qzsYnz5xhP6XOW1vXFXkpAf IVXdXib5LNaIUpFpI/j7/4ys40eGRVJJrU/5wQ/7ZzQjZuPjqub4OJvPwPy/aK5MYEfLu8/2Q2/ LarYnlstOj/4nbkD3XouFMicKWziksmtXC+NPfm7s2BCtKr1wQWxi8MEUtTg8+vnbHju4FSee50 m0SYJM1axvTH8IvYzJ8wOsXDOqSzc246kgOnArx7F3oGjM/kc71UcE8eZlICeyCHq9czHDYXPtc ku+fucoaYPA6nS2l08NcHU0mOTYvwshYIJ6xphJGuIoSZf/mlPPeoCQE05b4v5bVYjls+GsKvLd 8t8goVqbWXS58Lw== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A Introduce EC driver for the ThinkPad T14s Gen6 Snapdragon, which is in theory compatible with ThinkPad ACPI. On Linux the system is booted with device tree, which is not supported by the ThinkPad ACPI driver (drivers/platform/x86/lenovo/thinkpad_acpi.c). Also most of the hardware compatibility is handled via ACPI tables, which are obviously not used when booting via device tree. Thus adding DT compatibility to the existing driver is not worth it as there is almost no code sharing. The driver currently exposes features, which are not available via other means: * Extra Keys * System LEDs * Keyboard Backlight Control The driver has been developed by reading the ACPI DSDT. There are some more features around thermal control, which are not yet supported by the driver. The speaker mute and mic mute LEDs need some additional changes in the ALSA UCM to be set automatically. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Reviewed-by: Bryan O'Donoghue Signed-off-by: Sebastian Reichel --- MAINTAINERS | 6 + drivers/platform/arm64/Kconfig | 20 + drivers/platform/arm64/Makefile | 1 + drivers/platform/arm64/lenovo-thinkpad-t14s.c | 607 ++++++++++++++++++++++= ++++ 4 files changed, 634 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dcfbd11efef87927041f5cf58d70633dbb4b18d..83375e4e6e8c6ddd82e71503416= ad655c25684f0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -25092,6 +25092,12 @@ W: http://thinkwiki.org/wiki/Ibm-acpi T: git git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git F: drivers/platform/x86/lenovo/thinkpad_acpi.c =20 +THINKPAD T14S EMBEDDED CONTROLLER DRIVER +M: Sebastian Reichel +S: Maintained +F: Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml +F: drivers/platform/arm64/lenovo-thinkpad-t14s.c + THINKPAD LMI DRIVER M: Mark Pearson L: platform-driver-x86@vger.kernel.org diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig index 06288aebc5599435065a37f8dacd046b5def80bd..10f905d7d6bfa5fad30a0689d3a= 20481268c781e 100644 --- a/drivers/platform/arm64/Kconfig +++ b/drivers/platform/arm64/Kconfig @@ -70,4 +70,24 @@ config EC_LENOVO_YOGA_C630 =20 Say M or Y here to include this support. =20 +config EC_LENOVO_THINKPAD_T14S + tristate "Lenovo Thinkpad T14s Embedded Controller driver" + depends on ARCH_QCOM || COMPILE_TEST + depends on I2C + depends on INPUT + select INPUT_SPARSEKMAP + select LEDS_CLASS + select NEW_LEDS + select SND_CTL_LED if SND + help + Driver for the Embedded Controller in the Qualcomm Snapdragon-based + Lenovo Thinkpad T14s, which provides access to keyboard backlight + and status LEDs. + + This driver provides support for the mentioned laptop where this + information is not properly exposed via the standard Qualcomm + devices. + + Say M or Y here to include this support. + endif # ARM64_PLATFORM_DEVICES diff --git a/drivers/platform/arm64/Makefile b/drivers/platform/arm64/Makef= ile index 46a99eba3264cc40e812567d1533bb86031a6af3..60c131cff6a15bb51a49c9edab9= 5badf513ee0f6 100644 --- a/drivers/platform/arm64/Makefile +++ b/drivers/platform/arm64/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_EC_ACER_ASPIRE1) +=3D acer-aspire1-ec.o obj-$(CONFIG_EC_HUAWEI_GAOKUN) +=3D huawei-gaokun-ec.o obj-$(CONFIG_EC_LENOVO_YOGA_C630) +=3D lenovo-yoga-c630.o +obj-$(CONFIG_EC_LENOVO_THINKPAD_T14S) +=3D lenovo-thinkpad-t14s.o diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platfo= rm/arm64/lenovo-thinkpad-t14s.c new file mode 100644 index 0000000000000000000000000000000000000000..fed0a4e9fa33b641dd80c21f63c= bd908145505a2 --- /dev/null +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c @@ -0,0 +1,607 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2025, Sebastian Reichel + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define T14S_EC_CMD_ECRD 0x02 +#define T14S_EC_CMD_ECWR 0x03 +#define T14S_EC_CMD_EVT 0xf0 + +#define T14S_EC_REG_LED 0x0c +#define T14S_EC_REG_KBD_BL1 0x0d +#define T14S_EC_REG_KBD_BL2 0xe1 +#define T14S_EC_KBD_BL1_MASK GENMASK_U8(7, 6) +#define T14S_EC_KBD_BL2_MASK GENMASK_U8(3, 2) +#define T14S_EC_REG_AUD 0x30 +#define T14S_EC_MIC_MUTE_LED BIT(5) +#define T14S_EC_SPK_MUTE_LED BIT(6) + +#define T14S_EC_EVT_NONE 0x00 +#define T14S_EC_EVT_KEY_FN_4 0x13 +#define T14S_EC_EVT_KEY_FN_F7 0x16 +#define T14S_EC_EVT_KEY_FN_SPACE 0x1F +#define T14S_EC_EVT_KEY_TP_DOUBLE_TAP 0x20 +#define T14S_EC_EVT_AC_CONNECTED 0x26 +#define T14S_EC_EVT_AC_DISCONNECTED 0x27 +#define T14S_EC_EVT_KEY_POWER 0x28 +#define T14S_EC_EVT_LID_OPEN 0x2A +#define T14S_EC_EVT_LID_CLOSED 0x2B +#define T14S_EC_EVT_KEY_FN_F12 0x62 +#define T14S_EC_EVT_KEY_FN_TAB 0x63 +#define T14S_EC_EVT_KEY_FN_F8 0x64 +#define T14S_EC_EVT_KEY_FN_F10 0x65 +#define T14S_EC_EVT_KEY_FN_F4 0x6A +#define T14S_EC_EVT_KEY_FN_D 0x6B +#define T14S_EC_EVT_KEY_FN_T 0x6C +#define T14S_EC_EVT_KEY_FN_H 0x6D +#define T14S_EC_EVT_KEY_FN_M 0x6E +#define T14S_EC_EVT_KEY_FN_L 0x6F +#define T14S_EC_EVT_KEY_FN_RIGHT_SHIFT 0x71 +#define T14S_EC_EVT_KEY_FN_ESC 0x74 +#define T14S_EC_EVT_KEY_FN_N 0x79 +#define T14S_EC_EVT_KEY_FN_F11 0x7A +#define T14S_EC_EVT_KEY_FN_G 0x7E + +/* Hardware LED blink rate is 1 Hz (500ms off, 500ms on) */ +#define T14S_EC_BLINK_RATE_ON_OFF_MS 500 + +/* + * Add a virtual offset on all key event codes for sparse keymap handling, + * since the sparse keymap infrastructure does not map some raw key event + * codes used by the EC. For example 0x16 (T14S_EC_EVT_KEY_FN_F7) is mapped + * to KEY_MUTE if no offset is applied. + */ +#define T14S_EC_KEY_EVT_OFFSET 0x1000 +#define T14S_EC_KEY_ENTRY(key, value) \ + { KE_KEY, T14S_EC_KEY_EVT_OFFSET + T14S_EC_EVT_KEY_##key, { value } } + +enum thinkpad_t14s_ec_led_status_t { + T14S_EC_LED_OFF =3D 0x00, + T14S_EC_LED_ON =3D 0x80, + T14S_EC_LED_BLINK =3D 0xc0, +}; + +struct thinkpad_t14s_ec_led_classdev { + struct led_classdev led_classdev; + int led; + enum thinkpad_t14s_ec_led_status_t cache; + struct thinkpad_t14s_ec *ec; +}; + +struct thinkpad_t14s_ec { + struct regmap *regmap; + struct device *dev; + struct thinkpad_t14s_ec_led_classdev led_pwr_btn; + struct thinkpad_t14s_ec_led_classdev led_chrg_orange; + struct thinkpad_t14s_ec_led_classdev led_chrg_white; + struct thinkpad_t14s_ec_led_classdev led_lid_logo_dot; + struct led_classdev kbd_backlight; + struct led_classdev led_mic_mute; + struct led_classdev led_spk_mute; + struct input_dev *inputdev; +}; + +static const struct regmap_config thinkpad_t14s_ec_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D 0xff, +}; + +static int thinkpad_t14s_ec_write(void *context, unsigned int reg, + unsigned int val) +{ + u8 buf[5] =3D {T14S_EC_CMD_ECWR, reg, 0x00, 0x01, val}; + struct thinkpad_t14s_ec *ec =3D context; + struct i2c_client *client =3D to_i2c_client(ec->dev); + int ret; + + ret =3D i2c_master_send(client, buf, sizeof(buf)); + if (ret < 0) + return ret; + + return 0; +} + +static int thinkpad_t14s_ec_read(void *context, unsigned int reg, + unsigned int *val) +{ + u8 buf[4] =3D {T14S_EC_CMD_ECRD, reg, 0x00, 0x01}; + struct thinkpad_t14s_ec *ec =3D context; + struct i2c_client *client =3D to_i2c_client(ec->dev); + struct i2c_msg request, response; + u8 result; + int ret; + + request.addr =3D client->addr; + request.flags =3D I2C_M_STOP; + request.len =3D sizeof(buf); + request.buf =3D buf; + response.addr =3D client->addr; + response.flags =3D I2C_M_RD; + response.len =3D 1; + response.buf =3D &result; + + i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT); + + ret =3D __i2c_transfer(client->adapter, &request, 1); + if (ret < 0) + goto out; + + ret =3D __i2c_transfer(client->adapter, &response, 1); + if (ret < 0) + goto out; + + *val =3D result; + ret =3D 0; + +out: + i2c_unlock_bus(client->adapter, I2C_LOCK_SEGMENT); + return ret; +} + +static const struct regmap_bus thinkpad_t14s_ec_regmap_bus =3D { + .reg_write =3D thinkpad_t14s_ec_write, + .reg_read =3D thinkpad_t14s_ec_read, +}; + +static int thinkpad_t14s_ec_read_evt(struct thinkpad_t14s_ec *ec, u8 *val) +{ + u8 buf[4] =3D {T14S_EC_CMD_EVT, 0x00, 0x00, 0x01}; + struct i2c_client *client =3D to_i2c_client(ec->dev); + struct i2c_msg request, response; + int ret; + + request.addr =3D client->addr; + request.flags =3D I2C_M_STOP; + request.len =3D sizeof(buf); + request.buf =3D buf; + response.addr =3D client->addr; + response.flags =3D I2C_M_RD; + response.len =3D 1; + response.buf =3D val; + + i2c_lock_bus(client->adapter, I2C_LOCK_SEGMENT); + + ret =3D __i2c_transfer(client->adapter, &request, 1); + if (ret < 0) + goto out; + + ret =3D __i2c_transfer(client->adapter, &response, 1); + if (ret < 0) + goto out; + + ret =3D 0; + +out: + i2c_unlock_bus(client->adapter, I2C_LOCK_SEGMENT); + return ret; +} + +static int thinkpad_t14s_led_set_status(struct thinkpad_t14s_ec *ec, + struct thinkpad_t14s_ec_led_classdev *led, + const enum thinkpad_t14s_ec_led_status_t ledstatus) +{ + int ret; + + ret =3D regmap_write(ec->regmap, T14S_EC_REG_LED, + led->led | ledstatus); + if (ret < 0) + return ret; + + led->cache =3D ledstatus; + return 0; +} + +static int thinkpad_t14s_led_brightness_set(struct led_classdev *led_cdev, + enum led_brightness brightness) +{ + struct thinkpad_t14s_ec_led_classdev *led =3D container_of(led_cdev, + struct thinkpad_t14s_ec_led_classdev, led_classdev); + enum thinkpad_t14s_ec_led_status_t new_state; + + if (brightness =3D=3D LED_OFF) + new_state =3D T14S_EC_LED_OFF; + else if (led->cache !=3D T14S_EC_LED_BLINK) + new_state =3D T14S_EC_LED_ON; + else + new_state =3D T14S_EC_LED_BLINK; + + return thinkpad_t14s_led_set_status(led->ec, led, new_state); +} + +static int thinkpad_t14s_led_blink_set(struct led_classdev *led_cdev, + unsigned long *delay_on, + unsigned long *delay_off) +{ + struct thinkpad_t14s_ec_led_classdev *led =3D container_of(led_cdev, + struct thinkpad_t14s_ec_led_classdev, led_classdev); + + if (*delay_on =3D=3D 0 && *delay_off =3D=3D 0) { + /* We can choose the blink rate */ + *delay_on =3D T14S_EC_BLINK_RATE_ON_OFF_MS; + *delay_off =3D T14S_EC_BLINK_RATE_ON_OFF_MS; + } else if ((*delay_on !=3D T14S_EC_BLINK_RATE_ON_OFF_MS) || + (*delay_off !=3D T14S_EC_BLINK_RATE_ON_OFF_MS)) + return -EINVAL; + + return thinkpad_t14s_led_set_status(led->ec, led, T14S_EC_LED_BLINK); +} + +static int thinkpad_t14s_init_led(struct thinkpad_t14s_ec *ec, + struct thinkpad_t14s_ec_led_classdev *led, + u8 id, const char *name) +{ + led->led_classdev.name =3D name; + led->led_classdev.flags =3D LED_RETAIN_AT_SHUTDOWN; + led->led_classdev.max_brightness =3D 1; + led->led_classdev.brightness_set_blocking =3D thinkpad_t14s_led_brightnes= s_set; + led->led_classdev.blink_set =3D thinkpad_t14s_led_blink_set; + led->ec =3D ec; + led->led =3D id; + + return devm_led_classdev_register(ec->dev, &led->led_classdev); +} + +static int thinkpad_t14s_leds_probe(struct thinkpad_t14s_ec *ec) +{ + int ret; + + ret =3D thinkpad_t14s_init_led(ec, &ec->led_pwr_btn, 0, + "platform::power"); + if (ret) + return ret; + + ret =3D thinkpad_t14s_init_led(ec, &ec->led_chrg_orange, 1, + "platform:amber:battery-charging"); + if (ret) + return ret; + + ret =3D thinkpad_t14s_init_led(ec, &ec->led_chrg_white, 2, + "platform:white:battery-full"); + if (ret) + return ret; + + ret =3D thinkpad_t14s_init_led(ec, &ec->led_lid_logo_dot, 10, + "platform::lid_logo_dot"); + if (ret) + return ret; + + return 0; +} + +static int thinkpad_t14s_kbd_bl_set(struct led_classdev *led_cdev, + enum led_brightness brightness) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, kbd_backlight); + int ret; + u8 val; + + val =3D FIELD_PREP(T14S_EC_KBD_BL1_MASK, brightness); + ret =3D regmap_update_bits(ec->regmap, T14S_EC_REG_KBD_BL1, + T14S_EC_KBD_BL1_MASK, val); + if (ret < 0) + return ret; + + val =3D FIELD_PREP(T14S_EC_KBD_BL2_MASK, brightness); + ret =3D regmap_update_bits(ec->regmap, T14S_EC_REG_KBD_BL2, + T14S_EC_KBD_BL2_MASK, val); + if (ret < 0) + return ret; + + return 0; +} + +static enum led_brightness thinkpad_t14s_kbd_bl_get(struct led_classdev *l= ed_cdev) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, kbd_backlight); + unsigned int val; + int ret; + + ret =3D regmap_read(ec->regmap, T14S_EC_REG_KBD_BL1, &val); + if (ret < 0) + return ret; + + return FIELD_GET(T14S_EC_KBD_BL1_MASK, val); +} + +static void thinkpad_t14s_kbd_bl_update(struct thinkpad_t14s_ec *ec) +{ + enum led_brightness brightness =3D thinkpad_t14s_kbd_bl_get(&ec->kbd_back= light); + + led_classdev_notify_brightness_hw_changed(&ec->kbd_backlight, brightness); +} + +static int thinkpad_t14s_kbd_backlight_probe(struct thinkpad_t14s_ec *ec) +{ + ec->kbd_backlight.name =3D "platform::kbd_backlight"; + ec->kbd_backlight.flags =3D LED_BRIGHT_HW_CHANGED; + ec->kbd_backlight.max_brightness =3D 2; + ec->kbd_backlight.brightness_set_blocking =3D thinkpad_t14s_kbd_bl_set; + ec->kbd_backlight.brightness_get =3D thinkpad_t14s_kbd_bl_get; + + return devm_led_classdev_register(ec->dev, &ec->kbd_backlight); +} + +static enum led_brightness thinkpad_t14s_audio_led_get(struct thinkpad_t14= s_ec *ec, + u8 led_bit) +{ + unsigned int val; + int ret; + + ret =3D regmap_read(ec->regmap, T14S_EC_REG_AUD, &val); + if (ret < 0) + return ret; + + return !!(val & led_bit) ? LED_ON : LED_OFF; +} + +static enum led_brightness thinkpad_t14s_audio_led_set(struct thinkpad_t14= s_ec *ec, + u8 led_mask, + enum led_brightness brightness) +{ + return regmap_assign_bits(ec->regmap, T14S_EC_REG_AUD, led_mask, brightne= ss > 0); +} + +static enum led_brightness thinkpad_t14s_mic_mute_led_get(struct led_class= dev *led_cdev) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, led_mic_mute); + + return thinkpad_t14s_audio_led_get(ec, T14S_EC_MIC_MUTE_LED); +} + +static int thinkpad_t14s_mic_mute_led_set(struct led_classdev *led_cdev, + enum led_brightness brightness) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, led_mic_mute); + + return thinkpad_t14s_audio_led_set(ec, T14S_EC_MIC_MUTE_LED, brightness); +} + +static enum led_brightness thinkpad_t14s_spk_mute_led_get(struct led_class= dev *led_cdev) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, led_spk_mute); + + return thinkpad_t14s_audio_led_get(ec, T14S_EC_SPK_MUTE_LED); +} + +static int thinkpad_t14s_spk_mute_led_set(struct led_classdev *led_cdev, + enum led_brightness brightness) +{ + struct thinkpad_t14s_ec *ec =3D container_of(led_cdev, + struct thinkpad_t14s_ec, led_spk_mute); + + return thinkpad_t14s_audio_led_set(ec, T14S_EC_SPK_MUTE_LED, brightness); +} + +static int thinkpad_t14s_kbd_audio_led_probe(struct thinkpad_t14s_ec *ec) +{ + int ret; + + ec->led_mic_mute.name =3D "platform::micmute"; + ec->led_mic_mute.max_brightness =3D 1, + ec->led_mic_mute.default_trigger =3D "audio-micmute", + ec->led_mic_mute.brightness_set_blocking =3D thinkpad_t14s_mic_mute_led_s= et; + ec->led_mic_mute.brightness_get =3D thinkpad_t14s_mic_mute_led_get; + + ec->led_spk_mute.name =3D "platform::mute"; + ec->led_spk_mute.max_brightness =3D 1, + ec->led_spk_mute.default_trigger =3D "audio-mute", + ec->led_spk_mute.brightness_set_blocking =3D thinkpad_t14s_spk_mute_led_s= et; + ec->led_spk_mute.brightness_get =3D thinkpad_t14s_spk_mute_led_get; + + ret =3D devm_led_classdev_register(ec->dev, &ec->led_mic_mute); + if (ret) + return ret; + + return devm_led_classdev_register(ec->dev, &ec->led_spk_mute); +} + +static const struct key_entry thinkpad_t14s_keymap[] =3D { + T14S_EC_KEY_ENTRY(FN_4, KEY_SLEEP), + T14S_EC_KEY_ENTRY(FN_N, KEY_VENDOR), + T14S_EC_KEY_ENTRY(FN_F4, KEY_MICMUTE), + T14S_EC_KEY_ENTRY(FN_F7, KEY_SWITCHVIDEOMODE), + T14S_EC_KEY_ENTRY(FN_F8, KEY_PERFORMANCE), + T14S_EC_KEY_ENTRY(FN_F10, KEY_SELECTIVE_SCREENSHOT), + T14S_EC_KEY_ENTRY(FN_F11, KEY_LINK_PHONE), + T14S_EC_KEY_ENTRY(FN_F12, KEY_BOOKMARKS), + T14S_EC_KEY_ENTRY(FN_SPACE, KEY_KBDILLUMTOGGLE), + T14S_EC_KEY_ENTRY(FN_ESC, KEY_FN_ESC), + T14S_EC_KEY_ENTRY(FN_TAB, KEY_ZOOM), + T14S_EC_KEY_ENTRY(FN_RIGHT_SHIFT, KEY_FN_RIGHT_SHIFT), + T14S_EC_KEY_ENTRY(TP_DOUBLE_TAP, KEY_PROG4), + { KE_END } +}; + +static int thinkpad_t14s_input_probe(struct thinkpad_t14s_ec *ec) +{ + int ret; + + ec->inputdev =3D devm_input_allocate_device(ec->dev); + if (!ec->inputdev) + return -ENOMEM; + + ec->inputdev->name =3D "ThinkPad Extra Buttons"; + ec->inputdev->phys =3D "thinkpad/input0"; + ec->inputdev->id.bustype =3D BUS_HOST; + ec->inputdev->dev.parent =3D ec->dev; + + ret =3D sparse_keymap_setup(ec->inputdev, thinkpad_t14s_keymap, NULL); + if (ret) + return ret; + + return input_register_device(ec->inputdev); +} + +static irqreturn_t thinkpad_t14s_ec_irq_handler(int irq, void *data) +{ + struct thinkpad_t14s_ec *ec =3D data; + int ret; + u8 val; + + ret =3D thinkpad_t14s_ec_read_evt(ec, &val); + if (ret < 0) { + dev_err(ec->dev, "Failed to read event\n"); + return IRQ_HANDLED; + } + + switch (val) { + case T14S_EC_EVT_NONE: + break; + case T14S_EC_EVT_KEY_FN_SPACE: + thinkpad_t14s_kbd_bl_update(ec); + fallthrough; + case T14S_EC_EVT_KEY_FN_F4: + case T14S_EC_EVT_KEY_FN_F7: + case T14S_EC_EVT_KEY_FN_4: + case T14S_EC_EVT_KEY_FN_F8: + case T14S_EC_EVT_KEY_FN_F12: + case T14S_EC_EVT_KEY_FN_TAB: + case T14S_EC_EVT_KEY_FN_F10: + case T14S_EC_EVT_KEY_FN_N: + case T14S_EC_EVT_KEY_FN_F11: + case T14S_EC_EVT_KEY_FN_ESC: + case T14S_EC_EVT_KEY_FN_RIGHT_SHIFT: + case T14S_EC_EVT_KEY_TP_DOUBLE_TAP: + sparse_keymap_report_event(ec->inputdev, + T14S_EC_KEY_EVT_OFFSET + val, 1, true); + break; + case T14S_EC_EVT_AC_CONNECTED: + dev_dbg(ec->dev, "AC connected\n"); + break; + case T14S_EC_EVT_AC_DISCONNECTED: + dev_dbg(ec->dev, "AC disconnected\n"); + break; + case T14S_EC_EVT_KEY_POWER: + dev_dbg(ec->dev, "power button\n"); + break; + case T14S_EC_EVT_LID_OPEN: + dev_dbg(ec->dev, "LID open\n"); + break; + case T14S_EC_EVT_LID_CLOSED: + dev_dbg(ec->dev, "LID closed\n"); + break; + case T14S_EC_EVT_KEY_FN_G: + dev_dbg(ec->dev, "FN + G - toggle double-tapping\n"); + break; + case T14S_EC_EVT_KEY_FN_L: + dev_dbg(ec->dev, "FN + L - low performance mode\n"); + break; + case T14S_EC_EVT_KEY_FN_M: + dev_dbg(ec->dev, "FN + M - medium performance mode\n"); + break; + case T14S_EC_EVT_KEY_FN_H: + dev_dbg(ec->dev, "FN + H - high performance mode\n"); + break; + case T14S_EC_EVT_KEY_FN_T: + dev_dbg(ec->dev, "FN + T - toggle intelligent cooling mode\n"); + break; + case T14S_EC_EVT_KEY_FN_D: + dev_dbg(ec->dev, "FN + D - toggle privacy guard mode\n"); + break; + default: + dev_info(ec->dev, "Unknown EC event: 0x%02x\n", val); + break; + } + + return IRQ_HANDLED; +} + +static int thinkpad_t14s_ec_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct thinkpad_t14s_ec *ec; + int ret; + + ec =3D devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL); + if (!ec) + return -ENOMEM; + + ec->dev =3D dev; + + ec->regmap =3D devm_regmap_init(dev, &thinkpad_t14s_ec_regmap_bus, + ec, &thinkpad_t14s_ec_regmap_config); + if (IS_ERR(ec->regmap)) + return dev_err_probe(dev, PTR_ERR(ec->regmap), + "Failed to init regmap\n"); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + thinkpad_t14s_ec_irq_handler, + IRQF_ONESHOT, dev_name(dev), ec); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get IRQ\n"); + + ret =3D thinkpad_t14s_leds_probe(ec); + if (ret < 0) + return ret; + + ret =3D thinkpad_t14s_kbd_backlight_probe(ec); + if (ret < 0) + return ret; + + ret =3D thinkpad_t14s_kbd_audio_led_probe(ec); + if (ret < 0) + return ret; + + ret =3D thinkpad_t14s_input_probe(ec); + if (ret < 0) + return ret; + + /* + * Disable wakeup support by default, because the driver currently does + * not support masking any events and the laptop should not wake up when + * the LID is closed. + */ + device_wakeup_disable(dev); + + return 0; +} + +static const struct of_device_id thinkpad_t14s_ec_of_match[] =3D { + { .compatible =3D "lenovo,thinkpad-t14s-ec" }, + {} +}; +MODULE_DEVICE_TABLE(of, thinkpad_t14s_ec_of_match); + +static const struct i2c_device_id thinkpad_t14s_ec_i2c_id_table[] =3D { + { "thinkpad-t14s-ec", }, + {} +}; +MODULE_DEVICE_TABLE(i2c, thinkpad_t14s_ec_i2c_id_table); + +static struct i2c_driver thinkpad_t14s_ec_i2c_driver =3D { + .driver =3D { + .name =3D "thinkpad-t14s-ec", + .of_match_table =3D thinkpad_t14s_ec_of_match, + }, + .probe =3D thinkpad_t14s_ec_probe, + .id_table =3D thinkpad_t14s_ec_i2c_id_table, +}; +module_i2c_driver(thinkpad_t14s_ec_i2c_driver); + +MODULE_AUTHOR("Sebastian Reichel "); +MODULE_DESCRIPTION("Lenovo Thinkpad T14s Embedded Controller"); +MODULE_LICENSE("GPL"); --=20 2.50.1 From nobody Tue Sep 9 05:51:31 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B4E719F137; Sat, 6 Sep 2025 01:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; cv=none; b=Z7nC1jwsTJIurbiqDTWp+1h1cmjqUDPhENar4t1iBOOY3rmMvkPplifmD/3cX0tnhOTugnoq9WdeplTDXET+znvIbnlJLeHvCjuX/GD1vMXqWO+VMtxyjOIrmMYzm3sNlLlSs+ZIq1N1dysUrhX5W8sxIfVoNLuWmA34lMuNSA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757121149; c=relaxed/simple; bh=jQNO+DAmCip4vesEFMc3Tv1y6ysB3R992Cyyu+ChrEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WPo4D/GvbG8g59mNZ2M6TqHlhjPlaoYcJgtHjlyAd8On9hYzrUsFTtNQ73pCxTwgzlnHduUvkrVhinWZ4VWhaII2xs+37A5YjBIJCWiiT6nmDt3jGDZchahYpMZYCBAOPYZad7cZBWd/JahzKt4zaGZblAFUUhQ00C3miQWXe2U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HZShj5x0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HZShj5x0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AD77C4CEFB; Sat, 6 Sep 2025 01:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757121149; bh=jQNO+DAmCip4vesEFMc3Tv1y6ysB3R992Cyyu+ChrEI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=HZShj5x0BseaSy/k1VmuOiKf9EwmaZ5aCMPb5IkGVbdXiQ2JmtfqyDbO0GjY8L7oc spH2Kj3aeXI1XMRy3BcHmwqcFx+PmzZKaDjAROTSWCT6m5LuhitiPF5nfa7ZORMs6l EDxJleV/8Zgm/lUZhASIZD7S/9f/OMvamT1OiVBgTlfheU1uh7m5WDxgj1o+a+9fd7 8YsrYngGLjER+wph+imN20lwYjcqCsRCNRn6ThIu99x9H2yh4sHnq2LRVEd3pmARcw RDjDjnk7G+1Kb02JoGCSsAyH7/u3wCWMn2ICQ8Dzgi4MHwdToo0zGOdmLjF9UfvV7f OwFJO2n9XtKYA== Received: by venus (Postfix, from userid 1000) id 6B145180B21; Sat, 06 Sep 2025 03:12:26 +0200 (CEST) From: Sebastian Reichel Date: Sat, 06 Sep 2025 03:12:05 +0200 Subject: [PATCH v3 3/3] arm64: dts: qcom: x1e80100-t14s: add EC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250906-thinkpad-t14s-ec-v3-3-3ce6ec21ae89@collabora.com> References: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> In-Reply-To: <20250906-thinkpad-t14s-ec-v3-0-3ce6ec21ae89@collabora.com> To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Mark Pearson Cc: "Derek J. Clark" , Henrique de Moraes Holschuh , Neil Armstrong , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-msm@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1616; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=jQNO+DAmCip4vesEFMc3Tv1y6ysB3R992Cyyu+ChrEI=; b=owEBbQKS/ZANAwAKAdju1/PIO/qaAcsmYgBou4p6xtC8/RqdZxC9m/5OEDCvRd5Y0e2VywFKc /YXpbfA40OJAjMEAAEKAB0WIQTvZg0HRj+Lcmp5VBPY7tfzyDv6mgUCaLuKegAKCRDY7tfzyDv6 mkCiD/9tK9+B2LucYhz4FFgz6rtaNG7aPeA4/zvDAnN3U1TSinvjjBOZKEeSMIpK0zEY/IxNj/N NoV1Dib8BIVpta14jWpMbHEOD5VN0QKqBm3Bg3WgDqwEw7lkmzthMv3lYlppNz7IQV9syBdIPF2 wY2V2iAH2sOFlFVPc3ahlKctL1Hc8YTH5aaL5oaMHyK+xMum28xFKM/xLUZgbaA3EbVFz936ty0 580UbLauwwxdDl7Jjsm1zN44dZDccS7q6c55kxaWsE0uBOvibko7ftugbEkqXaC2YBDsL9sjsiq 4UhiCjCHYQ1VyFON8yJ64vaa9I2pngUbKoq4ktlimkCe6LiVfiyDMSYuTa3DmR95m0e5d70fl7d NNNGm8FbzrreondOWnkJRaVXcOhSnTHiZ1dFq4XtmBwI53swEMvIbKKq1u/yanpP3idTocRGah9 UBZ/pbBPnt29/FfD6nxrffJqGhsNJ5GehXZCY1Z3PwnsEN1DVP/Vb5u2oly7bc/e24mW4rHC0NM 9X/MR2GhckRU1ectnQ8L0fe6i3aXBTqoxxrW7UcGS5osg1yOgAeP0QTetNQsqpeyYncL6D1jZBw AYjoSHlPFNPAzcOu51u3rCHK4Z17ocuCL4GMowdpY+4VqAL4SUmA6qann4qBSE7Al/7lRVjVeYW ocrawVLCirSx1/w== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A Describe ThinkPad Embedded Controller in the T14s device tree, which adds LED and special key support. Tested-by: Neil Armstrong # on Thinkpad T14S OL= ED Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Sebastian Reichel --- .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 24 ++++++++++++++++++= ++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/= arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi index ac1dddf27da30e6a9f7e1d1ecbd5192bf2d0671e..f70489aba870289edbcf84ec22f= db004e010868b 100644 --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi @@ -887,6 +887,24 @@ eusb6_repeater: redriver@4f { }; }; =20 +&i2c6 { + clock-frequency =3D <400000>; + + status =3D "okay"; + + embedded-controller@28 { + compatible =3D "lenovo,thinkpad-t14s-ec"; + reg =3D <0x28>; + + interrupts-extended =3D <&tlmm 66 IRQ_TYPE_LEVEL_LOW>; + + pinctrl-0 =3D <&ec_int_n_default>; + pinctrl-names =3D "default"; + + wakeup-source; + }; +}; + &i2c7 { clock-frequency =3D <400000>; =20 @@ -1267,6 +1285,12 @@ &tlmm { <72 2>, /* Secure EC I2C connection (?) */ <238 1>; /* UFS Reset */ =20 + ec_int_n_default: ec-int-n-state { + pins =3D "gpio66"; + function =3D "gpio"; + bias-disable; + }; + eusb3_reset_n: eusb3-reset-n-state { pins =3D "gpio6"; function =3D "gpio"; --=20 2.50.1