From nobody Tue Sep 9 11:26:32 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BE826C391; Sat, 6 Sep 2025 09:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757149804; cv=none; b=LLzbS2I+IXCF6w/10U2WOgifdtmZG37gHJcKeF2Jiai+Bf0TqzqpFnVgrh4MElL8dZ5CUR+q7fZe9o+luJNwaZuPpRS3EVbYDNRMQ78BmDqm+psD42yM7OUGe8DmrxdaeCQkBzGVRuqhUVBrzi1XP3U6xcsD0Q6zqThHeK1CB+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757149804; c=relaxed/simple; bh=pSNaD3syxyAkp0oDtLOoghbbuLA05KsJaZn/Ggv/oP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oMsnebIR9VHFfF8cvaC2OzX3MjxdzSuTxPDIeuThQSDpZDqxnYuDz/Yiq7yF52iLojKjVE4d8lWutuLbynihIAlitjrFYeXAD3hQwnzbDl7/fe0EOVjdSyXvP6HL3GpV7FSJlwdstvLLZl1HVaDtJT6EjV4TyuDHbm6JTdKaDnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sIqnrFE+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sIqnrFE+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31934C4CEE7; Sat, 6 Sep 2025 09:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757149803; bh=pSNaD3syxyAkp0oDtLOoghbbuLA05KsJaZn/Ggv/oP4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sIqnrFE+V5sSoLhGvf63EJsJQ4sFaV9HrAMbCzZufeFudIhg8FpopUUV55yCPxnAa XI10q7gDIf2BmXGLaPlH5fy0nwBf8g540IgDQC5diMOh9TsGDhOwsvTt9df1vBr3kt ZbJHelzGBH+P8zr0uVXeaj/ym+ZNk15TOb5EGLHv9H+wVC6W+zT6ZsvgyqDe6+kLLw SUjJ291vQRNqTgGrN9QKKK2yNjTAO0QaHvlhXe2xDVdcxnO1pKWL6rXJMEfuWBHeGa PIeRKooJITwMWhvZu1R+lZKzYobCrLXYon1OPNA1QEd8962N39wzvRxjik3wtLzBj2 7zOFxa+3w/Irw== From: Andreas Kemnade Date: Sat, 06 Sep 2025 11:09:13 +0200 Subject: [PATCH 2/4] regulator: sy7636a: fix lifecycle of power good gpio Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250906-sy7636-rsrc-v1-2-e2886a9763a7@kernel.org> References: <20250906-sy7636-rsrc-v1-0-e2886a9763a7@kernel.org> In-Reply-To: <20250906-sy7636-rsrc-v1-0-e2886a9763a7@kernel.org> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alistair Francis , Liam Girdwood , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Andreas Kemnade X-Mailer: b4 0.15-dev-50721 X-Developer-Signature: v=1; a=openpgp-sha256; l=1431; i=akemnade@kernel.org; h=from:subject:message-id; bh=pSNaD3syxyAkp0oDtLOoghbbuLA05KsJaZn/Ggv/oP4=; b=owGbwMvMwCEm/rzkS6lq2x3G02pJDBm7fwWK56ua/g/9yiC7ZtoOJ/YFupcWsWl0fAz7sNnj5 7QrOpNOdJSyMIhxMMiKKbL8slZw+6TyLDd4aoQ9zBxWJpAhDFycAjCR/eKMDH0tLwL0hcxZD6gy FfxW2rXypqL61DIBh4jYY1skLjD8tWT4H8e/5VKNO3P1myMFlqvyw4SSGmbdb42OnLJrUtXzg7y ZzAA= X-Developer-Key: i=akemnade@kernel.org; a=openpgp; fpr=EEC0DB858E66C0DA70620AC07DBD6AC74DE29324 Attach the power good gpio to the regulator device devres instead of the parent device to fix problems if probe is run multiple times (rmmod/insmod or some deferral). Fixes: 8c485bedfb785 ("regulator: sy7636a: Initial commit") Signed-off-by: Andreas Kemnade Reviewed-by: Alistair Francis Reviewed-by: Peng Fan --- drivers/regulator/sy7636a-regulator.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy76= 36a-regulator.c index d1e7ba1fb3e1a..27e3d939b7bb9 100644 --- a/drivers/regulator/sy7636a-regulator.c +++ b/drivers/regulator/sy7636a-regulator.c @@ -83,9 +83,11 @@ static int sy7636a_regulator_probe(struct platform_devic= e *pdev) if (!regmap) return -EPROBE_DEFER; =20 - gdp =3D devm_gpiod_get(pdev->dev.parent, "epd-pwr-good", GPIOD_IN); + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + + gdp =3D devm_gpiod_get(&pdev->dev, "epd-pwr-good", GPIOD_IN); if (IS_ERR(gdp)) { - dev_err(pdev->dev.parent, "Power good GPIO fault %ld\n", PTR_ERR(gdp)); + dev_err(&pdev->dev, "Power good GPIO fault %ld\n", PTR_ERR(gdp)); return PTR_ERR(gdp); } =20 @@ -105,7 +107,6 @@ static int sy7636a_regulator_probe(struct platform_devi= ce *pdev) } =20 config.dev =3D &pdev->dev; - config.dev->of_node =3D pdev->dev.parent->of_node; config.regmap =3D regmap; =20 rdev =3D devm_regulator_register(&pdev->dev, &desc, &config); --=20 2.39.5