From nobody Tue Sep 9 21:36:14 2025 Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCCA136CE1A for ; Fri, 5 Sep 2025 17:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757092834; cv=none; b=q1kHIfeEol4aQuy/hqLoUsQoQWlrPJyNJ5NvRxll2A1tTd0FhN7ThV49qg7xZ5PdIaXAP6/QBe0ZUw6uLRfgWDQc+e9YKBI9CgdKPiin83koXegGBYWac0KLAxQ3af8yihq3QH/h5aoZ36JrXWV3Qn5LAaAJbUwyPdhYo9BYwz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757092834; c=relaxed/simple; bh=lBIehoTE9qHsfEbtzGnpbAnYuCwj+LDwF9UlRj/6mL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gCHnTUSCgtC8bbe3kedgKh9OrhDS9jQLxVrMkL7heBTrCttt8SuUz28bsEo4z4QFokcRxYzL8RjUttOvnsBGHN81dbk/RWM55Ev6JfSyLxnqo5g7sXK6jF0dGoVcTNOoBVcH/cM1LOb1JckGbEpUIgjhqqVzpuJoO7POnHF2FII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=AWLdp5Ui; arc=none smtp.client-ip=209.85.216.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="AWLdp5Ui" Received: by mail-pj1-f100.google.com with SMTP id 98e67ed59e1d1-329a41dc2ebso1657977a91.3 for ; Fri, 05 Sep 2025 10:20:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757092832; x=1757697632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ilwPX9LIjs3l0fybAvTKSDVfu7+GjybA609gdC08RM4=; b=ATH0OPytz/KeV67egMz8L0a47EQHpXK8DxU2fSfaqruc5u7MCg7zhidmbWflXkM8uR R/ndHC9hJvuYRvIo3gabUDHqC2Jyb+lVA/g+u4kxMELoRl3jy/vWmNpC/1XHP7eAkyrV b8cH0wK1has2L8pPfgzGH9tlXm1XSjUqPdRQRMYeyMxmqyBa/OLExlcp2x7OadW8Ugd3 IXVtFpZHS1tJyAd7JfqeDqCP6hAEOw+mKSIByZyaCQxrn0CF8TxBbdPdocnQB9kA1d5U D4ydgRTy2zCYUisv8NaofdkkeNdwptaDtJbebMZe0wwS5n03YwQhLOCKGQ1jIDqdJrgp 8HiA== X-Forwarded-Encrypted: i=1; AJvYcCWHcuGVXX4C+5QMo20AxuodPEf13DwkESAcxAlI0EeHtdD14J67hhBF/gGfCWbwrchTeCAVoivTBeymF2I=@vger.kernel.org X-Gm-Message-State: AOJu0YwrglXwUTf0wuqZe/MUfsEuuvVAb1S3Jf4KF92egPnqwTrliz4l KeOpANdFGnVH+1FIXLv77oVydDesTZ8pm9vODn6/NhQwFNQYCcyhknWY2QANp7LymqInts2WBM+ LgrKQqlCxGRL8Fd5JDeqcPL230CnYIUwnjSSGeM2l+BLZZgbczjFRrj3uvVpSCJG+FwbFwvAD3m AuihMT423fiT7R0y+cI23tfIacWRhkRJ/45JeFljXQ6oqdFctz+epJOt9Y0pIT97mPR13q911bF OIWNQZfivdnLN++Daq/cBlwf21O X-Gm-Gg: ASbGnctB8fm8Jd/202qxmj4pZfDMPTUorQ+Kz+cRcVC0o3cQJWLk618oyuAcfARhC3+ F+0MnX1xQ+BQrOiPKvNlKcRej+5ciPcYJkHveg/3Tz7N9AMa401ZO8JJAmzFVd9xg6apTT/wm4y jYqDnLLtirxJBKD1JbnpB9Vh6t21oUUQRMjLNjpgCYHF/dJJFlogEo5/JVniEzLwlXLYMHLBBz2 /hKEt03cnGytI+qNRIQPS5DhIEJ1JZz2icq5olb8+xe0XOBFNkj2FxOfEopMQ/mHfsqdnFV+BCJ GWsjoD0Rk+6Za7JzbSRIkC/+C5JJ+3JNvEqy77/T/daRs/p9EdAQLUa56pIt1m7OSQJE6hz06O6 7LU8sF2AXXPulzpYv2hMWirE9o58/+QFBmMdhVtSW1lbJXX77UTOtZS1KUxDCjTEMWQi7yzKZxG VBik418AI/ X-Google-Smtp-Source: AGHT+IHHeDKehDwZg4fWN8a+EvAaO8/4OyeWv+Mi3PTdpf1J5qCAa2KUpjY8qdVyZXjYQYW7erNZHl9Iylcj X-Received: by 2002:a17:90b:53cc:b0:327:9e88:7714 with SMTP id 98e67ed59e1d1-328156f991bmr31165929a91.37.1757092832017; Fri, 05 Sep 2025 10:20:32 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-32b96b7ac16sm412118a91.4.2025.09.05.10.20.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Sep 2025 10:20:32 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b47174bdce2so1905711a12.2 for ; Fri, 05 Sep 2025 10:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1757092830; x=1757697630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ilwPX9LIjs3l0fybAvTKSDVfu7+GjybA609gdC08RM4=; b=AWLdp5UipYSdjkUPo90IFa3uxOmiWeSAIFsPQXVhyy6kvyx/cRyocSbUykAJlbNU9d 15YbO61BFebMu8m5YzjUh6s+HPonlCeiftGiK1yU8Tb3/IIDl5lm6+9xaBKrpmCJY3en zcZZlz2bjD1GZmvob6PFTCgXXEW3nJEbgVrqA= X-Forwarded-Encrypted: i=1; AJvYcCVYzqKcmxJ1DcLgAEiKwo80qW84vr8oNx0B3Hw6m3j57i4THxdEEd+KV1lisk+TsVhIrfa3kwOEhLtKItk=@vger.kernel.org X-Received: by 2002:a17:90b:1848:b0:327:6de3:24b6 with SMTP id 98e67ed59e1d1-3281541223dmr29395842a91.8.1757092830019; Fri, 05 Sep 2025 10:20:30 -0700 (PDT) X-Received: by 2002:a17:90b:1848:b0:327:6de3:24b6 with SMTP id 98e67ed59e1d1-3281541223dmr29395805a91.8.1757092829452; Fri, 05 Sep 2025 10:20:29 -0700 (PDT) Received: from hyd-csg-thor2-h1-server2.dhcp.broadcom.net ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7722a2b78d7sm22678001b3a.30.2025.09.05.10.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 10:20:28 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, Bhargava Marreddy , Vikas Gupta , Rajashekar Hudumula Subject: [v6, net-next 04/10] bng_en: Introduce VNIC Date: Fri, 5 Sep 2025 22:46:46 +0000 Message-ID: <20250905224652.48692-5-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250905224652.48692-1-bhargava.marreddy@broadcom.com> References: <20250905224652.48692-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add the VNIC-specific structures and DMA memory necessary to support UC/MC and RSS functionality. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 121 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 30 +++++ 2 files changed, 151 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 207cbaba08a..c2c78df0e9c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -452,6 +452,114 @@ static int bnge_alloc_tx_rings(struct bnge_net *bn) return rc; } =20 +static void bnge_free_vnic_attributes(struct bnge_net *bn) +{ + struct pci_dev *pdev =3D bn->bd->pdev; + struct bnge_vnic_info *vnic; + int i; + + if (!bn->vnic_info) + return; + + for (i =3D 0; i < bn->nr_vnics; i++) { + vnic =3D &bn->vnic_info[i]; + + kfree(vnic->uc_list); + vnic->uc_list =3D NULL; + + if (vnic->mc_list) { + dma_free_coherent(&pdev->dev, vnic->mc_list_size, + vnic->mc_list, vnic->mc_list_mapping); + vnic->mc_list =3D NULL; + } + + if (vnic->rss_table) { + dma_free_coherent(&pdev->dev, vnic->rss_table_size, + vnic->rss_table, + vnic->rss_table_dma_addr); + vnic->rss_table =3D NULL; + } + + vnic->rss_hash_key =3D NULL; + vnic->flags =3D 0; + } +} + +static int bnge_alloc_vnic_attributes(struct bnge_net *bn) +{ + struct bnge_dev *bd =3D bn->bd; + struct bnge_vnic_info *vnic; + int i, size; + + for (i =3D 0; i < bn->nr_vnics; i++) { + vnic =3D &bn->vnic_info[i]; + + if (vnic->flags & BNGE_VNIC_UCAST_FLAG) { + int mem_size =3D (BNGE_MAX_UC_ADDRS - 1) * ETH_ALEN; + + vnic->uc_list =3D kmalloc(mem_size, GFP_KERNEL); + if (!vnic->uc_list) + goto err_free_vnic_attributes; + } + + if (vnic->flags & BNGE_VNIC_MCAST_FLAG) { + vnic->mc_list_size =3D BNGE_MAX_MC_ADDRS * ETH_ALEN; + vnic->mc_list =3D + dma_alloc_coherent(bd->dev, + vnic->mc_list_size, + &vnic->mc_list_mapping, + GFP_KERNEL); + if (!vnic->mc_list) + goto err_free_vnic_attributes; + } + + /* Allocate rss table and hash key */ + size =3D L1_CACHE_ALIGN(BNGE_MAX_RSS_TABLE_SIZE); + + vnic->rss_table_size =3D size + HW_HASH_KEY_SIZE; + vnic->rss_table =3D dma_alloc_coherent(bd->dev, + vnic->rss_table_size, + &vnic->rss_table_dma_addr, + GFP_KERNEL); + if (!vnic->rss_table) + goto err_free_vnic_attributes; + + vnic->rss_hash_key =3D ((void *)vnic->rss_table) + size; + vnic->rss_hash_key_dma_addr =3D vnic->rss_table_dma_addr + size; + } + return 0; + +err_free_vnic_attributes: + bnge_free_vnic_attributes(bn); + return -ENOMEM; +} + +static int bnge_alloc_vnics(struct bnge_net *bn) +{ + int num_vnics; + + /* Allocate only 1 VNIC for now + * Additional VNICs will be added based on RFS/NTUPLE in future patches + */ + num_vnics =3D 1; + + bn->vnic_info =3D kcalloc(num_vnics, sizeof(struct bnge_vnic_info), + GFP_KERNEL); + if (!bn->vnic_info) + return -ENOMEM; + + bn->nr_vnics =3D num_vnics; + + return 0; +} + +static void bnge_free_vnics(struct bnge_net *bn) +{ + kfree(bn->vnic_info); + bn->vnic_info =3D NULL; + bn->nr_vnics =3D 0; +} + static void bnge_free_ring_grps(struct bnge_net *bn) { kfree(bn->grp_info); @@ -460,11 +568,13 @@ static void bnge_free_ring_grps(struct bnge_net *bn) =20 static void bnge_free_core(struct bnge_net *bn) { + bnge_free_vnic_attributes(bn); bnge_free_tx_rings(bn); bnge_free_rx_rings(bn); bnge_free_nq_tree(bn); bnge_free_nq_arrays(bn); bnge_free_ring_grps(bn); + bnge_free_vnics(bn); kfree(bn->tx_ring_map); bn->tx_ring_map =3D NULL; kfree(bn->tx_ring); @@ -551,6 +661,10 @@ static int bnge_alloc_core(struct bnge_net *bn) txr->bnapi =3D bnapi2; } =20 + rc =3D bnge_alloc_vnics(bn); + if (rc) + goto err_free_core; + rc =3D bnge_alloc_nq_arrays(bn); if (rc) goto err_free_core; @@ -566,6 +680,13 @@ static int bnge_alloc_core(struct bnge_net *bn) goto err_free_core; =20 rc =3D bnge_alloc_nq_tree(bn); + if (rc) + goto err_free_core; + + bn->vnic_info[BNGE_VNIC_DEFAULT].flags |=3D BNGE_VNIC_RSS_FLAG | + BNGE_VNIC_MCAST_FLAG | + BNGE_VNIC_UCAST_FLAG; + rc =3D bnge_alloc_vnic_attributes(bn); if (rc) goto err_free_core; return 0; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 8041951da18..7c56786f5a7 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -178,6 +178,8 @@ struct bnge_net { =20 /* grp_info indexed by napi/nq index */ struct bnge_ring_grp_info *grp_info; + struct bnge_vnic_info *vnic_info; + int nr_vnics; int total_irqs; }; =20 @@ -302,4 +304,32 @@ struct bnge_napi { struct bnge_tx_ring_info *tx_ring[BNGE_MAX_TXR_PER_NAPI]; }; =20 +#define INVALID_STATS_CTX_ID -1 +#define BNGE_VNIC_DEFAULT 0 +#define BNGE_MAX_UC_ADDRS 4 + +struct bnge_vnic_info { + u8 *uc_list; + dma_addr_t rss_table_dma_addr; + __le16 *rss_table; + dma_addr_t rss_hash_key_dma_addr; + u64 *rss_hash_key; + int rss_table_size; +#define BNGE_RSS_TABLE_ENTRIES 64 +#define BNGE_RSS_TABLE_SIZE (BNGE_RSS_TABLE_ENTRIES * 4) +#define BNGE_RSS_TABLE_MAX_TBL 8 +#define BNGE_MAX_RSS_TABLE_SIZE \ + (BNGE_RSS_TABLE_SIZE * BNGE_RSS_TABLE_MAX_TBL) + + u8 *mc_list; + int mc_list_size; + int mc_list_count; + dma_addr_t mc_list_mapping; +#define BNGE_MAX_MC_ADDRS 16 + + u32 flags; +#define BNGE_VNIC_RSS_FLAG 1 +#define BNGE_VNIC_MCAST_FLAG 4 +#define BNGE_VNIC_UCAST_FLAG 8 +}; #endif /* _BNGE_NETDEV_H_ */ --=20 2.47.3