From nobody Wed Sep 10 05:50:39 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C273191AA for ; Fri, 5 Sep 2025 17:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757093848; cv=none; b=LAngI+CGW/e9V8KCqGTkOmAePi9MXix2gtKkc6YI1OTiXp8E25pPw528wLG8MtlrDMAXGlDcFl3B2eD2w2oLHJPBq/Sqxz7r584wek4OK/KcOQBF7gQavlzydEFghVkkcm00bgrTrKWq6guVy4+I9y20HyvGcHwUoB2R1P4CWj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757093848; c=relaxed/simple; bh=sxDSb9W3kWYfcQEyJvHl2qhUaQ77eVWABPTDD93pB1s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Q42yRyEE7D/kPwo0B6Mhihqld+tWkLMzbNMj1OVRYVHFKXUQD4deL+hh9Z6bxhFFBeE3arLAN6XcMszil06qnsiP/YvFduB45OH8XnOx0AkUtqiYWvty14yXqcCWCl7+HsFfwFR5f1ch6cWpSZBaU5x3kvfOUgoUehtyiESkjCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g2hNHXg0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g2hNHXg0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45a1b0ce15fso3843055e9.3 for ; Fri, 05 Sep 2025 10:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757093845; x=1757698645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C41s7GNcy2VIbBs1R6Ajjd4rnWCbztAyNNt/x23sqEo=; b=g2hNHXg07y95Gl233ww5L7TKS5GIH5nzMEo/wYFrjUnjmjl8KEavXItFF8mzZkY58e sTdMF7SkkUxlaSFMT+MYU1k9w8yqIp8uR9HOzLSXZFhMQvprlMJT9IrZeij5FR+yL6we FrsQ7nAIKYH5bdgIqJvNXzAnspAsE4xyx+pGrq6E700mWbZG/akix3zA7jzdNAz5qQh2 yzS4j12qH1yvqFjwGg/r6mP0F8J++zJ23kSVyapAO28Mts83QlTidgw038slIurUCUq3 iqEqHfNOcaqoilCpswCJYanL/h5I7nMWW+KEZa73mtPoVGcCNznMKLV3L8XuTIGckoTu Qggg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757093845; x=1757698645; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C41s7GNcy2VIbBs1R6Ajjd4rnWCbztAyNNt/x23sqEo=; b=H2twhiTbcLRwgJhhNhpF0x+jz8n5oq2yU8J7nhj28gFxGMYyGMQ5ija3AlRVOxsM2B 1ZdtTSXfQ8DR143l4Qf92KZxKmalHfFmT6lvVxp/iH+uVKTdFs09jSmm8il01h6ROU9T 6YlGuObpWhAf2WbBLuUdHslviWXxjLjicZCz4gd131CoZ7pq9rtSiiL1z30/X/LZtH55 IYQGejwzaUYflDlkj4EBuyy7+ZM6lLfs22VrA/DITQVt4O16gyWSRV/OujK8/oBS4sei qYho1czI3PoybCaUYBWJqStEpyrAPu7sxLuEUunTxWNbD5lgs5x5RS6sCI03mofjcewy 4DBA== X-Forwarded-Encrypted: i=1; AJvYcCWXX2YwUjK18LkUsSaPeljcTC1V1hUdC7uCxcdQhJxrXrCZc7NAP7sygmUqrAXVJGX7t8fS6xcZu8a60IU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6OU8pV1/WBbqYNg8WSmoi5L4b8Q8qq7aeZQo2vnOHjXRuRMsu ho72x0MPL3uWZffF87/2C9f8OCb2/Nm6k/2MfC67e+DQZs+mzcDqLuXduuW+I9Rw6k4= X-Gm-Gg: ASbGncviWskxtZ2dEPeUDWNbw3aVJW/aKYoYnQffWAPUdrGETquqq5jNcWY5pZn/5bW yKezi2ZciXrYzlNDptVDP3p2CoZ6EzPz5lX8sZnfHmNgDa3mmKUohEBZjktEoZqJqmtmfEFRUJg PrcY1DiiYlCXtiPUMbvMHiD+N3v2rWtkKI3IDYThkLajg3etIslJbOZL1ZYc1NCoqArqVFnfiIi 1aVZ+Le1pau3FQX+VhK0fss2EUPwkYyFK5KxnQAXaPA6GdnbcqO5LE21DgEtPqcgz4sYgZVZ6RE wKcxig1niC7YbjFmfgaio4dxQevGzpRxedTR7qt3OpnAkxgnRwItPuumiixxXhi3FX1zImhCsqn eosd1ZERrEvnnJ0Ff1UQYQ17HUH7KyrnjYg== X-Google-Smtp-Source: AGHT+IHWRNSLIatugRetZO/CpGssuICFcXAn6/N40TrEXg7gQCmSjCxc3dvc4P8G5NAWJ3452VJhbg== X-Received: by 2002:a05:6000:420f:b0:3cd:cb0f:7203 with SMTP id ffacd0b85a97d-3d0f6b3570dmr11699998f8f.0.1757093845275; Fri, 05 Sep 2025 10:37:25 -0700 (PDT) Received: from kuoka.. ([178.197.219.123]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e5100eba33sm1095297f8f.9.2025.09.05.10.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 10:37:24 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] soc: samsung: exynos-pmu: Annotate online/offline functions with __must_hold Date: Fri, 5 Sep 2025 19:37:18 +0200 Message-ID: <20250905173717.34240-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1208; i=krzysztof.kozlowski@linaro.org; h=from:subject; bh=sxDSb9W3kWYfcQEyJvHl2qhUaQ77eVWABPTDD93pB1s=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoux/NK0EZx7r4MPOk/47bnRwvwh/FBnKiD2F8A tqVeTkkzyqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaLsfzQAKCRDBN2bmhouD 158oD/4/V0LUlQQzGC6pFK5dIFV2iahT3jc7md3wP14CXs0BRPS3E/Ci3c06QriLlSw0aW5V2Bq YbzBSDkafkoyeXChCgWMTCKM1tKv2QJwf3UV47IHgQSiJho2gHtltA5u1aF3c9EOSuG7FXpGliM H782ohJA94ci6ED7Eg9TchGhD+xSi4rfruajT7YDIAf5mnXZFmXQU2hELBdtsNBEH1tYj/ZYmDm 9KyBiDqB9f7LhQcHrLVctPt0r9IkA80izurnKizv8FHPg8XdW98LpTRmJPRbZ9Iedp2PU7NSpOf GWkSOXQM42UqCkwu+4isjBxqTlM6YKCKN1Be5x1Tnl//xe1X4cxhIaTZ4K8Vv8Rb/3wMRqg+7QP p8TBVDV+jKbVDmw3C/Gjbuvy70t/cjFV1AD3uvI0/00LHyoOyb8rC6Q9d3OhawP+CBVMxNxH5nP koHQTnWHdTj7V8WNH9VAzbww9bMGa9eHiGmK8a96yWURFpBNK31GEGmxPTk2xPYt0yKwgrzyPkf LRopyr5oK8H3SOSWiEgixeBGfv+vSPnFAbe0bJYw+1jzOMTPAWsgPYa8tfTdSDlLN1ESt9jrL0g mMxomTmcEAHNgZW2R7yiz9KboK5EhxQ7GFfrYYYIv7rWOLrlYknILYGyw7JNo/yKAvB3U1UK8T0 W90WS/kBIbrQl1Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Annotate functions writing to PMU registers to online and offline CPUs as __must_hold() the necessary spinlock for code correctness. These are static functions so possibility of mistakes is low here, but __must_hold() serves as self-documenting code. Signed-off-by: Krzysztof Kozlowski --- drivers/soc/samsung/exynos-pmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-= pmu.c index 22c50ca2aa79..105293970d48 100644 --- a/drivers/soc/samsung/exynos-pmu.c +++ b/drivers/soc/samsung/exynos-pmu.c @@ -364,6 +364,7 @@ EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap_by_phandle); * disabled and cpupm_lock held. */ static int __gs101_cpu_pmu_online(unsigned int cpu) + __must_hold(&pmu_context->cpupm_lock) { unsigned int cpuhint =3D smp_processor_id(); u32 reg, mask; @@ -424,6 +425,7 @@ static int gs101_cpuhp_pmu_online(unsigned int cpu) =20 /* Common function shared by both CPU hot plug and CPUIdle */ static int __gs101_cpu_pmu_offline(unsigned int cpu) + __must_hold(&pmu_context->cpupm_lock) { unsigned int cpuhint =3D smp_processor_id(); u32 reg, mask; --=20 2.48.1