From nobody Wed Sep 10 05:52:53 2025 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010017.outbound.protection.outlook.com [52.101.229.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFAA63728A0; Fri, 5 Sep 2025 14:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083508; cv=fail; b=YN+A/aKMS2Dsaj3JriTJOLLgkM0i98z0I43YI245CgNvEeEaxm0VAhaHaMibB51aiNLkD4es9Ua7c55z9J2lZoaCtOKgKsuZc96A8NLs5OYXIb0tffK1/gtlaa2CxW+SNcy2HiqedhmbCoCSaUU5cYSQ2ipQLrwbawV8YpLn+RU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083508; c=relaxed/simple; bh=LPVAXR+IhpejfYVA7jcP4vowGBfcZuSs8m4S9NGerGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=W26oXxfqurqaDJ9j3FeFA+6mKKWP1gl12+RKYh04Kx6QGfBINHsQjed3inXs8Jgx23kOsdbzZWWlNDtAn0SpzMB/RHS9Zn7BYTClRQyDUtoCAuF7YdSovwetcJ/plJ2IcH8oelPbPb2SOVdbyDdZZLW2AfOroZuWk3nkNRitXfg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=OH3CxHkS; arc=fail smtp.client-ip=52.101.229.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="OH3CxHkS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vy2N9Q7guFPguCiJPOoocug2VCWtC9PfKKxBrurPlIkNzPXFvb9/emCBNt41MA5IH7v8DTG8vYQrP95AfI6oewElzbfQaMHtGpeimycJPOkvSuo7nHb/buZMUwVMaokScsdDWky2qw5/IZf3I1kk/NO+wUx1DxdOh8TC7MMOskNpwaKBDoDuOPm7vabeafLx0d9FZ2un7NN0PxhtjWQDxROjtGhkvUYEWltOVzNA9Q3roZkW1Ik+flwv5VgqWE1Y8aK/8+169W7/zck29YD5toNYHZjvtocvhGKq4/M/YjLUtuq5zewlavqhtJlu0BL/N33dQREzVzrGi0JETecKAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c26Ct3Dny9tcvnroG4QK0MtfZvAmKWnidYRpFm+gLk4=; b=bY3CeEaEC8UccAcP96rK4Zs1CXMUHR3lGtFiN++Hox6cIn/BNQCCMdqJ8Q65adot5Ij2oHIR1u95uljkDLDCjTyA564pIcbihFs4VSK4WjHwPd3OoYkfa+2mi8GIaajmPWzsXtER8zzlymm07MapZt3xAonq/V7H7NErG4Gvaa9HgKipGqpno7yTWMzYaalu9Gso+Juu5xZi6Y1ZWmHLL8uc47MRkz9rhEeogW9yJDhPfF0tfBM/1LwMQS3L+q1h7ID4IMStVGUNAhvTylAIMVC0r/M9dZtCVUlf5fWfE/aYao2LYy3N0vKPucIo4mrKlg2DRfHNDiYyw3UmpCjSgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c26Ct3Dny9tcvnroG4QK0MtfZvAmKWnidYRpFm+gLk4=; b=OH3CxHkS80KClhZqcfQycuqcEv/e2HWbjvny7fsS5ryJgRQ0KznAhnaYufgWHyL8tRGzFgEDfrNR5QaOs6pwDy6ZESbmj6IK6XQvhkB/mHPXtWKiHj1ZmzPDP1MJ4PhJxBZUQHuojxAKRj0G8p4yxOBfVXWhtnWR8JzM6nTEMhE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OS9PR01MB14067.jpnprd01.prod.outlook.com (2603:1096:604:364::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Fri, 5 Sep 2025 14:45:00 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31%5]) with mapi id 15.20.9094.016; Fri, 5 Sep 2025 14:45:00 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Vinod Koul , Geert Uytterhoeven , Fabrizio Castro , Lad Prabhakar , Wolfram Sang , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] dmaengine: sh: rz-dmac: Use devm_pm_runtime_enable() Date: Fri, 5 Sep 2025 16:44:17 +0200 Message-ID: <20250905144427.1840684-2-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> References: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0420.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::17) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OS9PR01MB14067:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f67d080-1ca5-488d-55f3-08ddec8aca7b X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?a29bcPHzfygI2u4LR9Rb4YkOYRG+b+usOSptzC+uVgZKnK/zNCgVw8e2ru/K?= =?us-ascii?Q?0SntisN838TzKaX7S3U0WDtiT/mEWGq2q0V7+56LDR1Ebd+MDwAbulpa9hU9?= =?us-ascii?Q?7vvKQO6fTg+iJcAArmtuAV4fgM6LchxxmFSgxy99KkcjDe8PguqPgE2JlTw5?= =?us-ascii?Q?D6nlBpHcKTSAB3qsESJxK6AfOWD7rvrlpYOVxTrYtYTtEAffMoPqF8kNXpWb?= =?us-ascii?Q?K4+Zs6+LgISuuk66JDzya1XcwcsFWatJ+LmI0/DZs/3CA2YWVdKXKGfEcF0E?= =?us-ascii?Q?a57CWH6VcJr/PxQU2Rb0sjmaiGHM9R75bIzdeWQyIseb7iNU662IaIBDHBMz?= =?us-ascii?Q?W6QeA/VUSiPu1x2dB94/0MYdBXBvZKDrXBaV47Q7sqALvWfhdI4R1xDG/NEi?= =?us-ascii?Q?Rp4S4hE5DyQuAtLMWCrVnoU3Rd2o7cb31Pl2wRDBcUAQJQleBwuzDODc5ruQ?= =?us-ascii?Q?wfoKG6sjSYo9f9DSIAb/Zi7ViUNlswAryh149RoGNuz9BRxdwEJ/HVYpfEfq?= =?us-ascii?Q?e5he6RnsDeghAuMURc/uDPHupwTJSwlLx+LK+uut8sUKbimN6dJ7TZdCfMBp?= =?us-ascii?Q?WIJ7Y/34uih0y84Bf8kt6LOZMEI0wXFdNMZumtjvSjWTzISlW9/j0tHhE1qF?= =?us-ascii?Q?Qy35EFGdGhwLbd2glDrTf+NuAaFaPjuE3PDU+Mm2lplkqVyQ8+W4P3ygnEZu?= =?us-ascii?Q?W1outFiNF2KeCRzquk4XJ+GCITN6/WIorvEtZ8oCuvKfuxpO1hyOMlXYtFb/?= =?us-ascii?Q?/zRijFYf5n4V9FOGgztAYg8+iH+KPjh/mTW7BjAMOPxnVFu1sDrqsSTitoo7?= =?us-ascii?Q?f/LZZSWHgJgsqwAz/TZqREQ9+pwXEgUra97r0anb8ZVImic1ZdBdFX5e53o/?= =?us-ascii?Q?g1VnRzFhr8RIMBLkq4GMvERtQsTfBENeq8WCVOH6YmGxaylJx/ypAlHCl3qh?= =?us-ascii?Q?OebJ2cRitwrQVGqJegr1vpGEJwpZ1xiu2dFJqpjB9mBpAaVQo3msGlyITIh7?= =?us-ascii?Q?wHzTLSb88K6NnKjZrlG47bPndkI52QFZoLo1f4IWLpaAfnpDKgqgsi496aNv?= =?us-ascii?Q?BcH0ztPfnM1kXZvmPDaK2Y0OKAeHECAa8H6TZFYao+Ee3jnjdePoWutJS0gq?= =?us-ascii?Q?odj5tdBdRD1ixcAaU1ITgUejsD6jzk+Y6s8mGRvm3OdbzPs44gYw9UK47CQ5?= =?us-ascii?Q?/812JaDGoCq6aspPbii9q33JtCQJgJfiMGAvJolKvwpjbkH+LRcaIZkckW0O?= =?us-ascii?Q?xz/XqptwLKuQq+SwG8+iu6X3lb8cDNNJQhRXurqJqk7hVjJPcTcU2EKEeZrB?= =?us-ascii?Q?b84ihD/49UOg4Y33QfbjrdKXR2vpceQ2e9DCup1XUfzJ0HLr3wisxY1/GEqe?= =?us-ascii?Q?lpq31D2LDVJvlE9TY38gauyKcaJrHtCMz8T+ZRUlcvJ04DyPWxFZRBYsljXg?= =?us-ascii?Q?u3YBzAJxJhAdwsVVU4phQau+Gup6bjjX8wg5rwxQZ/ytJXCq4VhrHA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EXU0neuOzKyYJR/3s2Canvx70DcNPX1+ITazJNoXiNlEzmx6ysrJvAJGHu+c?= =?us-ascii?Q?DQP0B8NwFRZayM8aVyLn9xAr+8id7Pha1GoyWBFaojNwoR+Tk26GAlFOQEwg?= =?us-ascii?Q?jfZzb4xT4TAcJMImU/rql1+Bu2SXgKje8Bg72M8AtBmaqNswhLb1Y/Rklaty?= =?us-ascii?Q?hYsd8UxP9poCEol8pOuxh4ivoWQ7JWe+njIXsdfzMBHtRG9N8sMO6g1KPjRi?= =?us-ascii?Q?umjkYntwqLyfwov2roeC+Y0nmUgpR0yjnpkoeKxHldt8o6PNpqggV21kX34H?= =?us-ascii?Q?wIRKbcSmdAhJiFI3WERCxEy8D5AnnrC58cePG8yMoRpLf0gGBVtIoX0ndVDu?= =?us-ascii?Q?KeQRJztIa9ax+4RNXHAY5MTk4aIiNWNxG1nDMv/VNqm37bu9ACe7WxfKJzI4?= =?us-ascii?Q?wlE5qAr9VpYY9YlC/eUuRNATQs8K28JDZsrtB8yrmdNoAyCOEpnzLPcslCYS?= =?us-ascii?Q?PXSj2l1Pcz5c//+4Jb6L5Bg35nWefkyIxPi7wtjg443SJqlzMO2+tJNSo0pm?= =?us-ascii?Q?MjvieB1wm8ECl7ptBW37yyaUmYl9K+Cjbk3sWVakfKSrJXfGhQR7PjI/7a+U?= =?us-ascii?Q?AzavoO/AT4hDjFEhrqME8hCROMJLC4rXPHGItfxuWKiO4lHe8CrzdVuDaylV?= =?us-ascii?Q?DSETMB1GCBdowboVz9FZwElV47lHgsBVJwMbxfPfGfelhCOOlCFoixCKcXYr?= =?us-ascii?Q?RY9KNsA6hbleQin0oz4jvWaGPxUJfgEPXdtAs9cTtzJ298cC4l01O682t5O9?= =?us-ascii?Q?Ah5/Pnv0jGQYRR31PZw6kcdVcn4sUdz/DWKYZKX0BS+elwq1YJbYZBGrvi8U?= =?us-ascii?Q?Yv3UzfcKpHyLRF27yZA1n5gZoRMXEYze9UX2QbObKGfRcyUAKTTi1wUqWf4t?= =?us-ascii?Q?PjADXiPYdIcSN37TgPPs24cgJWmi+nnv7ZyXAo8DAmmV/fpygRCJNAmApZ6a?= =?us-ascii?Q?DJ0QcyIU429TYzTjH7HtF3aHrXiHjyPclQLsK8V1bD/MhGbGllMpU0pYSII2?= =?us-ascii?Q?zvgrcLBK0b1QjsXhW9YVxgwUtxEEYi+q6PItoO5QHe9JflhVmwZ8i5iRcVea?= =?us-ascii?Q?NgPS6eKHTzFJKxZzEqwtQPfeYNb0GnN0WsNneo5cEMQnPD2cP72AEUY6Rki1?= =?us-ascii?Q?N3hzjPziu+UfK6LkFIjA2wboZWPG93IoC3IitXJEMvPsKQoU7nhV/B43W++N?= =?us-ascii?Q?r0P0GacR9ZZZEGJSHBwDaoq6tBUGJ0imAaW5z1bugS/WLJ8y7N8650adH0y+?= =?us-ascii?Q?OEbvJLP/53+XNzJoeeKjvA7aiUne0w/KjKyCmpfQ+kPXNQx95dNOOoDQuinC?= =?us-ascii?Q?txoSjzd0RtA3iQfDQVHayVdGWun+UohrCcYQJwmd+l+iIbgbg72Ztzj7tQPM?= =?us-ascii?Q?W2dqAb3J2s+IsWKgXZKWxtswnfN7fjnjZSI8+NqwD3Qy/Ll3r4KhlBYm/8nL?= =?us-ascii?Q?MkJZvRAfOMM6OG6Ux8g/NSAPviuO6zF5Ddztm5Gz2DuLiFDZW4h0b1ycaRHn?= =?us-ascii?Q?/SJMgLXEef/eIsa5e0LNZeDLHK7Di/m0bxrChCalcl1MPqCD4Rf53HZ/KMDi?= =?us-ascii?Q?Cd6HQKZaxHWpIVEeI6hP4ZE9UrsZMzHPrH6U8eQjj+AHH6E099ciiozulQYU?= =?us-ascii?Q?uCFKPdwbdmDHwQTXTgmFOpI=3D?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f67d080-1ca5-488d-55f3-08ddec8aca7b X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 14:45:00.4355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ehs2JdAytklR22+qdTu5mrhzhDMOxsmejMs2iFl2PEi6zBelS/Ma0l1+EtC79YiC/Cgrw3obguGpiVjATsZNgDtcyoKyoSGaNyHmKaQoqD8BYh+DAGVx2sZZkeBhTOTQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB14067 Content-Type: text/plain; charset="utf-8" Use devm_pm_runtime_enable() into rz_dmac_probe() and drop unnecessary pm_runtime_disable() from rz_dmac_probe() and rz_dmac_remove(). Signed-off-by: Tommaso Merciai --- drivers/dma/sh/rz-dmac.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 1f687b08d6b86..0b526cc4d24be 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -963,12 +963,15 @@ static int rz_dmac_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(dmac->rstc), "failed to get resets\n"); =20 - pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(&pdev->dev); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to enable runtime PM\n"); + ret =3D pm_runtime_resume_and_get(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed\n"); - goto err_pm_disable; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "pm_runtime_resume_and_get failed\n"); =20 ret =3D reset_control_deassert(dmac->rstc); if (ret) @@ -1031,8 +1034,6 @@ static int rz_dmac_probe(struct platform_device *pdev) reset_control_assert(dmac->rstc); err_pm_runtime_put: pm_runtime_put(&pdev->dev); -err_pm_disable: - pm_runtime_disable(&pdev->dev); =20 return ret; } @@ -1054,7 +1055,6 @@ static void rz_dmac_remove(struct platform_device *pd= ev) } reset_control_assert(dmac->rstc); pm_runtime_put(&pdev->dev); - pm_runtime_disable(&pdev->dev); =20 platform_device_put(dmac->icu.pdev); } --=20 2.43.0 From nobody Wed Sep 10 05:52:53 2025 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010017.outbound.protection.outlook.com [52.101.229.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45E69374267; Fri, 5 Sep 2025 14:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083510; cv=fail; b=Pu/gNxT+2AWZPwa7KZWDgy350s3q4fMrNyt63aFk0o09V0vTgtFMiSxGavipSmqwAtAIuH95UpkVB5nmCju4XmdANbqF+3JboXMdL0SqCxrB1L3Wr5rN438Nvnoa/AhXuZj5YuYwXnsKv7yH36s3AQgm02LVZIIC1wibeYMF/uI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083510; c=relaxed/simple; bh=9tlk3C/WYrlzCEeFS5SUIqUadUoRHFed2hccwh0NYg0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=D74stg5wtkKmvYbn76jw7O4NujlNNTyh0NdT69oEJAe1Wfps82NPCy6GI9Tr3AUH4AYf6ksFg3/Ql51X1Jk2A3BX8LJ2zuPer/BOL6eJay0i0L6ncwZGcP/wOR66M+2GVd42HUvcEMjM8ALxsHG69MvLGRFamowswBhO1qmJq0s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=YnMel/IH; arc=fail smtp.client-ip=52.101.229.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="YnMel/IH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=itaJmJAfuQDg/oMYW5nzKhPv2xWD1PBRRaWd2MR8onNSMCNpIvtJJ51iGG+wVU8YYcwfq0DdFqrK2LtO/AxleiLgCxtFOvR+G/D8VK88ER+4WkV6bOlv98qf4Vj4deSfHK88qfsy3noI7PN2GswY571/I2cpypvC65Rh2VWKlQNC+CZG6m097uhCgibTvC25eTHgF7p8WaLsMacU6qzxP3fD31rbaA5+70qy2mT60FprTGfzDXzxJ0cQz4do2dSUgbQbdWVL6LGrjVgQ2eR9G0EfIUgkaWfuWfjQm33qK1Qtdq28fTQOb2HofGKP2elJ2RLO9vZa3rYG9e46eMzC7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6F9YZk3fvt1TywJYVX3ZW/FzJX8G5lbTeO4AvAPbAwk=; b=Ztl+anHkq7jjLMOcF5CPs0vDWRFqZdn6kEvfrgp8PPAmoOvBs1GM00Q2+aBrNnnYZTd9j/iY7GT3x1XaaYoxDAdRyGWOv1tJLb40mf6s9mkr0OsxYjfPtpQdUh9kGy0IGAawWKlK4Rr2zhj1Y57Raf6m7Pbg1L4oStkEynYa7VkEsdBzCnHyJqwfOvLIgNHtioJvh5bVYoqYnyu506XXwkbmYhnzQuWSiZuxkel2rTluuo5Gc+IRuWxg+cXI3n/mnmOJFObLDZ/tQ3GYOoHC5Jy8dnKq6/yoe1AbzyPbRUmnNzS/SgdXl56FXTYszPOn1z8+CeYHPIfvn5yXb17FNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6F9YZk3fvt1TywJYVX3ZW/FzJX8G5lbTeO4AvAPbAwk=; b=YnMel/IHabFsroWUFtXt4z7NjVwbsdlLMagrcqRBJHKWYbi0200iHIGutlBqMG2NGlucp2WYpnIoiVGSt5acehEhdylZRBuzQ8wQQqtAAiWcOHYN70ImT1Vb8QZJfvQdJwbZe7ETnnoOJLHAcSr5HwuoRAckKbWcDSM9V5wbw94= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OS9PR01MB14067.jpnprd01.prod.outlook.com (2603:1096:604:364::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Fri, 5 Sep 2025 14:45:06 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31%5]) with mapi id 15.20.9094.016; Fri, 5 Sep 2025 14:45:06 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Vinod Koul , Philipp Zabel , Geert Uytterhoeven , Fabrizio Castro , Lad Prabhakar , Wolfram Sang , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] dmaengine: sh: rz-dmac: Use devm_add_action_or_reset() Date: Fri, 5 Sep 2025 16:44:18 +0200 Message-ID: <20250905144427.1840684-3-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> References: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0420.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::17) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OS9PR01MB14067:EE_ X-MS-Office365-Filtering-Correlation-Id: a1a693ca-2c5e-44d8-469a-08ddec8acdf2 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Iw6MpOkvoac55A9/rO4DGIvk7fdsRnDdZPTnpfer8CGj7TxW4UU0A7Y2XyMK?= =?us-ascii?Q?ErIrK+OzeinbW9QwJ2yJBlQmzkPcSdtDGAbsGsk49RUBp5XdkA4hSZrse2/5?= =?us-ascii?Q?c931DdaHB0uPyN75REeNrCDI+OIuM9FM6po8W8JEGsrthzivReu0okk1Qo0A?= =?us-ascii?Q?bZJoZtWhuwLgDAwJh1No3HeLfco4BNA9uuiAyNW8LyjYvJXWIlUTiV7ckAxp?= =?us-ascii?Q?JqY0Wwg6YFKm8TNkAQJT/hRlRYai8Oj9Uaqp4FYFfMjvjcZtQRmTE0cj1ajJ?= =?us-ascii?Q?ENJ0uHbsay4mwTxjC4UK40MO7PJMWC/nWXSVhNXZsfTQTa0Bd9rCaactUC7b?= =?us-ascii?Q?M88n5Ya5i2OJe1MFOA5uSZ+UEJtken6KLTkgYZrav7bcoewhH0nXQosV0MDo?= =?us-ascii?Q?ww3MRUcTlELC7urnw1ce6M4CYSKu8L4TInJ2rWboVVWboB2Ol5JrwHkIFlkv?= =?us-ascii?Q?Io0paOIYe0FtIFlsleJuw2naEY4N0KsHHW0nYsyJmOd6d+pptdH2uIwgSyNt?= =?us-ascii?Q?d9oJru5EMdD/enhiMjHp+sfmD3S6G2/m7Ole2GvgmzztiJ5H8kShr4/GFIS0?= =?us-ascii?Q?rEWQzaoyTWAtb/Hmw/oELTZa1udAvTcLL2pfVp2ysV9MfvFo7E/IuserdB5H?= =?us-ascii?Q?imx44BnKG6NwBhaSSCfRbSI/cyEUjhsT4ESYAbqVtamzy9+aXGtE/kKI5gWZ?= =?us-ascii?Q?tib3H0H74VB3Ak4wVnbH9qbMbjkI4MgitUyQZKQ0JTwQyfszKNUVZS7FqomC?= =?us-ascii?Q?neKfsqQIPgcukSM4OafvEAxuRHiCrMK+HByww0Vyvxm+YTmiikCq6V5SvDd0?= =?us-ascii?Q?FthoCz0zv6CbN3b1kKC/f8YorlTTxjLGtCClJMtkBTAFN/aRhSBD5dYL82z7?= =?us-ascii?Q?5a2hhNcO/Sk2TWrkLdf+PB6IJL8uWVsEFYUZIK1Hp1dhBdoO37Ht86DkIpFz?= =?us-ascii?Q?p8s3Rp6gqq1hK349tIkESz+HuVeSKIAyBqdqA/Wi0HEaEYdI/JmFGyiEbnKT?= =?us-ascii?Q?WJFQmqAk0v/Td666pbuQxQuRGTyv81ji7Xz1HFZbQ3uIQ000JYqdAGHiNlQg?= =?us-ascii?Q?DQo/rIL2raA4qW2//xVfZBmfc76/y5Lg0JOiAnQRz9PyWfbO+nnLtFLE/EUt?= =?us-ascii?Q?hIQVZUkI23S1JsVnH27U9w3f0fKASoJZ5a4NFRskLz/qr0Xgl5EVAZ71POOP?= =?us-ascii?Q?C8dEmP7Kgb2EDfDRje9Ufk5QcTFjjShCTUAKRyWY2YtLSr0cHP0bT709OqZe?= =?us-ascii?Q?Bbv+T+MSZQDU6rcQ1AumFsA7NvsdcIJD97KqQirV14HYpuK4XLMv2PeWVFeO?= =?us-ascii?Q?HkkaSBhj/9d2hgQIhVDDHTc2PKt6aDH2OcNbi0TWw6gVebmToVUCn7HNnDxS?= =?us-ascii?Q?4wXO/AEmo7ZEGj82rxVb1GcJXpnblX7hqvTC/H/aUac3vNzG+/EySVk4g5FN?= =?us-ascii?Q?YJyHJ/BOPFZgjeYcCWXmck8AxurDW8RUqmbbCNNkDLME0bXXwzJYsg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bjVs0si/1z8xlHcQVkm2MmrkxwPAtCc/kGC2qpoZVdRhS9Ix7x1bz18m+kxi?= =?us-ascii?Q?u6yVnYZx//WZ/kpLXp+uhcSGKtNaNwAerdveF4PZh3Gsj+Ahwzup5PkJdA0v?= =?us-ascii?Q?DpEVQ54gyQiIAJCJbaAIPWvmkrd2uwfWawnAFWmizUP33MfO1zCJX9zaKfMQ?= =?us-ascii?Q?Ffrb0M/n+QlzeQuIBPptQNfurRu4t7/117RcbAqdp7k5+sAeI499j9jCBtJO?= =?us-ascii?Q?9iAq5ncOB1t1VKBC4AEt3LxMQG8OEh0qtCX450Cgwle00RJ32QKaQhHu5fdz?= =?us-ascii?Q?3eIySAIHRmTF93SQ1jeEY59yMjCplcTw/0Yd+5USqAzHTh8fVTb/WcYFdHw8?= =?us-ascii?Q?wtaeqtfaMRsmyv+46IJmjEK16dFiDbc5VbHLuDVf6OkQZksSIa54kiyNP+jr?= =?us-ascii?Q?wumAoVzTfwD8FG+pHS7zkr5nJF1ye/YQFefAvtX68IODJHcG389iyqfxapAw?= =?us-ascii?Q?o8kYSylkXOgwiaPUOOrZX81uqrAojd83HgDvBWVEZeqhNL8Oqm2QGTNYhy9Z?= =?us-ascii?Q?pCU1wPX5x9jFoK+FbRcmP8DOQZxghwAXSQilyVQMcOcH9nDL4Jopgn0pMtbf?= =?us-ascii?Q?150q47bxhBy5LWqLPnI3QuFm1M5yemFX9leE0ovgSjmjnyPN+UJtRuNCTaMA?= =?us-ascii?Q?hFrR6sje/Dhpsb/i+LdMKSewK5h5tR2xoLJxsN5YVocK2X/LvscqWcOXOEJ9?= =?us-ascii?Q?0oTViYUlGHnSlsXCRQTXOLmMNMC65U3ayziNol6A1QDFZaZHppGTc3IVwa9H?= =?us-ascii?Q?emylz4t0WhdOpZ8QgbK2xuUhf5VFlO4gsIIFlebjDplihnca7liYn4HbBHUN?= =?us-ascii?Q?gPGPI7ENvIaUjvsyW+zuNXrZyzoz5EHJnciXkkPp+IEiX3BUCoSzDZGvriYs?= =?us-ascii?Q?fBG6iInTYZLYY1f9I7ACxrYEYe4WHl/YfcJPB206vn9tJFKk1Jaw6s7IhjDt?= =?us-ascii?Q?KImbPtkb6W8syizb0FC1bV03vVvT37OMIcZ0JXtFombnDf655S6qnYfwd73Y?= =?us-ascii?Q?ViNoSwEQdBrfj1pYfk4AzRwd7IQZbtARN0unbzk3fSTlYyhdlrDVi+mw5Qfx?= =?us-ascii?Q?Hl7ofWlTlScwLx9Uw5fW/KM6hS9dku+1xdSumbCvDcvovIkCzrk2H0Fbg3wS?= =?us-ascii?Q?SShhM8bJfWKCgaBOqmdxR0P+bzyfiJf1HogMZaHGGZBz45W0B/OGv3kh06AB?= =?us-ascii?Q?/hbQ2LuE6KzO/h9goODGF5o3eFGwNjaX4LkVuQNDducygLA+tj4/0TrLf7xj?= =?us-ascii?Q?tNxpTzSrhOEiknA2SNZzlOyA6P+f9b/IDzN6SpdNfqQw/u8kLCtPueY8b6ZV?= =?us-ascii?Q?Fnky2fnEFVRMp+UWK/CUXftK06A02bFKEJPBhBz2jQk7nhLSm8lLbpWgmVbp?= =?us-ascii?Q?0O3SIMSc/nkWe7ZNF3U1OaI9pgsh9zwppGZN/bvUB64lYQq/fYQFYam505ei?= =?us-ascii?Q?L7Eqlo+gFYf0TM+sb0pscW7PZ2U9y1T3Jndh4ptXGOfyBHNk+gx8TmGpqGIk?= =?us-ascii?Q?sc/M/WZv3BHkikEcuUk745wOIE1PUGDFwIlcTAtHEgqy3Lluvy/3rorP7Xtm?= =?us-ascii?Q?N3nyc8Qbmv36UsHuo+1s3o7LP1KuO0Wn+1PPHS8ygG8jDkU9ebbaaJ7qTiXp?= =?us-ascii?Q?hSM17RuODxeT/ipWJArrAMc=3D?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1a693ca-2c5e-44d8-469a-08ddec8acdf2 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 14:45:06.2278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XMVmpk5DefYKdkQdprUKxM/texD5e3yjI6jLotbelFBFTxUDlkTYlkKptI/Ap5o+f55k/GY57/e/Ofbm8XerPXxMCzTUdfmklmzORLusWLNhUsz9mtrX3B1jaz3GYDBV X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB14067 Content-Type: text/plain; charset="utf-8" Slightly simplify rz_dmac_probe() by using devm_add_action_or_reset() for reset cleanup. Signed-off-by: Tommaso Merciai --- drivers/dma/sh/rz-dmac.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 0b526cc4d24be..0bc11a6038383 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -905,6 +905,11 @@ static int rz_dmac_parse_of(struct device *dev, struct= rz_dmac *dmac) return rz_dmac_parse_of_icu(dev, dmac); } =20 +static void rz_dmac_reset_control_assert(void *data) +{ + reset_control_assert(data); +} + static int rz_dmac_probe(struct platform_device *pdev) { const char *irqname =3D "error"; @@ -977,6 +982,12 @@ static int rz_dmac_probe(struct platform_device *pdev) if (ret) goto err_pm_runtime_put; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, + rz_dmac_reset_control_assert, + dmac->rstc); + if (ret) + goto err_pm_runtime_put; + for (i =3D 0; i < dmac->n_channels; i++) { ret =3D rz_dmac_chan_probe(dmac, &dmac->channels[i], i); if (ret < 0) @@ -1031,7 +1042,6 @@ static int rz_dmac_probe(struct platform_device *pdev) channel->lmdesc.base_dma); } =20 - reset_control_assert(dmac->rstc); err_pm_runtime_put: pm_runtime_put(&pdev->dev); =20 @@ -1053,7 +1063,6 @@ static void rz_dmac_remove(struct platform_device *pd= ev) channel->lmdesc.base, channel->lmdesc.base_dma); } - reset_control_assert(dmac->rstc); pm_runtime_put(&pdev->dev); =20 platform_device_put(dmac->icu.pdev); --=20 2.43.0 From nobody Wed Sep 10 05:52:53 2025 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010000.outbound.protection.outlook.com [52.101.228.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3DBF37427C; Fri, 5 Sep 2025 14:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083515; cv=fail; b=gTmjz1D8q0dERonDnG2WFY2+2e07XUr2QGGzyIM8Bu8imRu1xA7iCjoCUWWWj6cySmwpgrk/pwnneyCzt/NxDksuyLuJf1PPwe0a3wdqy+Sc+0ECRqgOZeF0f4phLSn+vf3vWU6BOpwzg6EphjFHuj+xYZUor8TR91pNCCGUY2k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083515; c=relaxed/simple; bh=UiLYL0apFnXXxEEcQpVVr2Q3CvDug/+00KW3yZ7qbak=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=CtSog8pdClc6pqcvJsodp6V9p0xriWzjmfIKJA2WKhSkyCt/WktFFqDxQmo43F+cgZ8QEW6P7nGFwXovMuDa0CXhIbaqonjJ+mT1YrcBcP38dfS6hX26hMRVfgPgaSstTTapdhYjz6RcT6RK5xh8jsc/Id1pnL1enO4hKv81ZXk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=ap94kSNT; arc=fail smtp.client-ip=52.101.228.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="ap94kSNT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q8Z9quKjQLnlDXAkKu7Wl3cCuoDdEFEOJFYUuen/+iv0hTnwPegSEhMjOPYnasu8XbvBMC+shoYfeKh6q7utU0OQXr0xsbCy/I8wZ2qMk71uNg/ptyoSoG0rRcdGmx2WfJVWT+SD8T3PnodA6LpLS8j5luQjCLg+vYThCzNXZcg4n2Pidgyg1fuvfCanCyISyilqQHe0TR/5hEBOFwlSzcqcGUdRAmtdlMQ6O517AAN9PZGEaqk4Jpz3cpu90Jf2RS13hcB5qy4GyyzzbynjNNpr9brc2eLwpVD/nIfY8x/xWLuzAezg4nFIl5uXSVUw8KEcR7Qm7tMfpxT5BGoqxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=onuy4OGZVBDwu4UcZTSpwP5Z83ycnYNPUMR64w4oxS0=; b=CgQFlbE9D6rZNiGMobp6e+Dd13dwJtLVKZWBPy8Dk1CNQJOwxquIlnHJcRFt9/GcaxEvhC0IWO2rxHSSS8Ct1wd6reYMtHDTFRElwYjk3iRCGOsy6LHrg7rOTIMM0LB/5J1iIpZCdehNbgS7Q1s63A5eNyLuiAu9PRREa3mYEMZcGvpvFx+1UrgMfy/KqCx7bAszx7ycVz/2ol1rqUgAE7YpmEjWc6lrzga47RLG0+IrYKKEk7BNXqviV2WQbUWgLWVFdku3BepL+gP5aW2Q5gn4zDFqH7uddR3O3hX+knt2ZQYkkaiHBXUWAC1l6n4nHwAuTgWJbBWoV5EXCPWO7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=onuy4OGZVBDwu4UcZTSpwP5Z83ycnYNPUMR64w4oxS0=; b=ap94kSNT7yaDfhkWT/Y9eQj28NWs0ApBcsqp7pEUOb/xyaBnB71SvdIE4bI6/mA/UFTN58oxP1LgDpay1Avo2VxBgznTAo8kh8eBd7v36vZ3ZnFUMEJf2u90vr89NcsPk1hAQRndNWDPsVxcagV5EgUerh1ZS0szu7BaMey63n8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OS9PR01MB14067.jpnprd01.prod.outlook.com (2603:1096:604:364::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Fri, 5 Sep 2025 14:45:11 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31%5]) with mapi id 15.20.9094.016; Fri, 5 Sep 2025 14:45:11 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Vinod Koul , Geert Uytterhoeven , Wolfram Sang , Fabrizio Castro , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] dmaengine: sh: rz-dmac: Refactor runtime PM handling Date: Fri, 5 Sep 2025 16:44:19 +0200 Message-ID: <20250905144427.1840684-4-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> References: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0420.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::17) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OS9PR01MB14067:EE_ X-MS-Office365-Filtering-Correlation-Id: 29d352eb-da7f-42f7-0ab0-08ddec8ad0f9 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+nHY6igO6HnTbXXkwWp8m+nLH4wZyXp4O+DAeBuDPsJerByoXRkDMwjjNb3E?= =?us-ascii?Q?xaumEamlQZo5qtdUkjvZeTiIL1T0GxPawcqNhQx65vYZupiWzbfgH43W3Gmv?= =?us-ascii?Q?w3IACU/o/Pqit+QsiK5eByoOB5ohUIAAg70/6DVwlkFKbe5P69dqgFNRalst?= =?us-ascii?Q?1JiMNZhSmuAJVh30e/D+7lVXcWXv8L3JqmEFWVZDLYrI7AWenjh5AB/QZOMy?= =?us-ascii?Q?awRurSrNSST8ir445BrxVZeSdjjxhXH261idsGUN659hkmX+dIet0zqD6dIR?= =?us-ascii?Q?DrCZyDpSgY8N+Xsd7JUuqCNtBzfqhBaQdiWvYU9/xTWhSMe7+0QnbCdZCcRA?= =?us-ascii?Q?gsLHbsZrX4aVMXFkGwtqtSL8GcqgkFVTKqQMgXQRKEtlr9fjDta92lF1ekA6?= =?us-ascii?Q?mPTvvE61/pFZulTFYgrgjeGVw8vvp/ZshSMcVA704ON8WroVuhlPdnaimT9s?= =?us-ascii?Q?4HK8dXQTuSKjP+mmUKMtIOf1LGHzAYdR0fu0nowiAfGSPrarnp8Rtpr9Sivz?= =?us-ascii?Q?oiivhIVifr9SiK8/yR6OsZJs3H0tChqn2EXEvb557uE6X2X2vf8hPUUDhVXp?= =?us-ascii?Q?6YF9eDDvVwOJnRBt+WvAvVjPRYOnHuU0lTkHmdaYaG73OiAd/aW7NUiiHay/?= =?us-ascii?Q?KvzNw5eh5RiDKGw6klj0s4tXRT4qqnc1+nHvVkSb7GUpr8ynCqItDj7j0Rpj?= =?us-ascii?Q?u+4Iu6PbeBjFEG/potrmkBk9kdkGSMvS8IdsjfX0lgO97uXAg8sBMnDnz/B+?= =?us-ascii?Q?CaQrzhn1nFIZg2y9xzhUSbbMMFC8tQrtLomg4QkMIZMzEnoLwoARy9vF/awP?= =?us-ascii?Q?8RYEQ3ZUsOh6VfKZx+NAl5AQ1ipRu174xX+Z6CaiAmp0Ccfwo3J2PUwLu9Hc?= =?us-ascii?Q?e8RnwlQZ4tf2pMLWIWCTiYxwWWtfYDgUn/T5k6OI5ZQrcqQhmZo+LI9+588Q?= =?us-ascii?Q?nb1o+EBogLiVhJYbqoO4HaSMv9jLCeq8vW/ADTr/iOao0ImO7S+4QG3f70NG?= =?us-ascii?Q?uJKutXVnARPgSTGzq2ixh3D6G4sCvJonlam6G1nUw8UoLVUgGt5F0KSArV3K?= =?us-ascii?Q?dDSaW9qvmvT6CyXiEwEdNwZQiv4YPkdOaSYey3eMt7+G1mzLsukGONLcv1tL?= =?us-ascii?Q?UEFnN78DLFNJxrgBRGw2Ja6GuGBY+EqSgGbaBEeroVaJmyvqamT/7nTye0KM?= =?us-ascii?Q?XbbFvI3kSUA24mp0LalHot3m64L+kReW2+aKU4E9Js5ckb9QsBtMHuMOj1pd?= =?us-ascii?Q?GP0fBZYs4JjichgeeWYc7Oh+oPLqvlgaukLJztO7RXc97FRVaiGkJk0hptRw?= =?us-ascii?Q?OIdD3iu8rxiyzSIj9EQ2UA1y+mNZJktoAuOaMXjx24/JQoCOSR8LLIrJX4Fg?= =?us-ascii?Q?8ewVT3BRdRs0x2xbo1v+veq9YxnA22068h2EIjpjQO3oGSx3N2GyfS/76KJi?= =?us-ascii?Q?ojBbcIsRKiNagTS6GMPqgWH1a0y5qhR2uwPdpsxB7/FQRh0dTCp2bQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UkCvHf+Z8yRo3G0kASzFuH/NBVyoObdCLsNZKCtqM+scstRHg23eNR/EZvTX?= =?us-ascii?Q?KTphLbxTlF7lCMibGWQqxZ6C9kYSeTMwyQjpldzghHBKNgGuS73AEGSt8EPx?= =?us-ascii?Q?OaEWwWvnOpR3hp+VkMJiL76kwneIIRgTpy7L2E2jYk3x2hhCr1LwIJ+U7Y6/?= =?us-ascii?Q?9hcRXhBRlYmfqMXiJmRpyYFDjCV+KnCsWBAZzd5zbxoB/qwhFmOHdzeSU5gx?= =?us-ascii?Q?VDuwXzG7Px/Ncn2n7PoRycouPLp8y0I/Wf65YpDJlzbJcDpyrAeEGDtG8lSU?= =?us-ascii?Q?n+84zmKvUkNldq/Bm4YiybpvS6iMPri9vU9CQpFu8lxPkd71aNS6Vw9ziM6W?= =?us-ascii?Q?DcFVlfrCSpy2PSNGQjGF59760JkH8gmjIi2wFe8PAk9v0s7Qv1xJgtxeGtnK?= =?us-ascii?Q?9AhSQhU1lcVjvu3on8aZRZT0H/xq9wttHUuB5b85rk4Yat78loqROcMm0/S+?= =?us-ascii?Q?Xk3sXpugb6EnYypXf0ok2qZscBIzPtcxYK+m/2TlaOGNBzOw1inFDHG1l9j6?= =?us-ascii?Q?UfNEIrvbP9zfctCssuswYYd7YmwModnuQEDbvekCzEGIamlrx3P3S5VS1gQj?= =?us-ascii?Q?nVBt53tNh6vGjN3Va11BxJHH5aE6yFSVLaUguELE6HCLhux/MURvAIHKok/9?= =?us-ascii?Q?d/INxYxqxc9LOwZlg9t2B3vZlObS5UeWhpjTDLB7b7ksha3Si3wbg6irFj2P?= =?us-ascii?Q?Zug9zi8zv+Mta/MI9nRozWpmlDfhGjON6VJI1RlDwQEwLDtlWU8MjHdy7S3g?= =?us-ascii?Q?Aqx/aiQkdKPxyCf6JZjP72D7hL30HBOw/HJfGxduVX81cS5cKOdVQeeySfQy?= =?us-ascii?Q?tYVYPYl33JibxxHfTbzPUeV+QD6Lf/nt3xOamqYgR2CMCz5gMUSkwFSrkA/N?= =?us-ascii?Q?5QFEm49oNf3PrXQ96mambkMsf6BBfmFsNPbCffoX079MYspHDEaGqHQIcNdt?= =?us-ascii?Q?PS8zGEjSKHJfcUWq+XQHmUbW5WncdDvG8a1jaI0sAIevE9VhSgdPWSZPopeI?= =?us-ascii?Q?FKdKUBwin00cBxpkppvv8IDukTj1+tRt8JI31hQKIKHebVLhXn36HOln8gWL?= =?us-ascii?Q?ebWUhctzeeLwCtaziFfXWiPf9c+5RBoX2x43Q9w0IUsxCrhAx3WDiu5xBbJU?= =?us-ascii?Q?hRl5H5QS6Ikh9WLkSN+MFPNfKGCfA7F2FbmE5TKthDi2QjQ0MmF32iWQhd67?= =?us-ascii?Q?qS3mrMYrZmmn7Ge+PAg8cvaXR3NuQgIs0wNf59bR1xSSwj4GtiZkL5duC7o0?= =?us-ascii?Q?CrGGgIF/saHQEk2Jtn0uIXCkF39t7MkpIp40+rvjQSFIfqN2yqYacquufQea?= =?us-ascii?Q?ni306zoWLs44JzX+brFHSzmcyhuaNJDuyR2nZhut1FU6zFXMMiQvd6FvLoqb?= =?us-ascii?Q?BrjuIlFyVnd5x9lYWNedO+atOw1QWzcWK7SP7049T6SuzckM8cPuCr1ngnk8?= =?us-ascii?Q?ZPSJv1yFmt438iyb6vEr1NDYGEAHw37jQPOReucskbb0BOZ4E4D346qamIAW?= =?us-ascii?Q?yxJyXLbHCJsLd8Gktj+bIqlzGwY7o2Vb1Pbp2FlTxBN3hSF/k5Aw41EyDxSu?= =?us-ascii?Q?T/Yxf6llFJpbt2FUfysVR+i3THoiWa9vAEeathcaJyo3eOOwp82mb4W1KAgc?= =?us-ascii?Q?kgBfYeghbex6tsLlr1iNGXs=3D?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29d352eb-da7f-42f7-0ab0-08ddec8ad0f9 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 14:45:11.5204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v/+kX8eRd47gCB+h59imL4fAd5lHrpY51DJdzj3zscxkHfXe0b3KJi9J1qJSIZq1O8T3t6yX4a5yLbRZenYXi8GvgxapCLX0LQvD6B9begPM7Z/lXp1r1gF+z57uUFQ7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB14067 Content-Type: text/plain; charset="utf-8" Refactor runtime PM handling to ensure correct power management and prevent resource leaks. Invoke pm_runtime_get_sync() when allocating DMA channel resources and pm_runtime_put() when freeing them. Add pm_runtime_put() in rz_dmac_probe() to balance the usage count during device initialization, and remove the unnecessary pm_runtime_put() from rz_dmac_remove() to avoid PM inconsistencies. Signed-off-by: Tommaso Merciai --- drivers/dma/sh/rz-dmac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 0bc11a6038383..4ab6076f5499e 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -455,7 +455,7 @@ static int rz_dmac_alloc_chan_resources(struct dma_chan= *chan) if (!channel->descs_allocated) return -ENOMEM; =20 - return channel->descs_allocated; + return pm_runtime_get_sync(chan->device->dev); } =20 static void rz_dmac_free_chan_resources(struct dma_chan *chan) @@ -490,6 +490,8 @@ static void rz_dmac_free_chan_resources(struct dma_chan= *chan) =20 INIT_LIST_HEAD(&channel->ld_free); vchan_free_chan_resources(&channel->vc); + + pm_runtime_put(chan->device->dev); } =20 static struct dma_async_tx_descriptor * @@ -1027,6 +1029,7 @@ static int rz_dmac_probe(struct platform_device *pdev) dev_err(&pdev->dev, "unable to register\n"); goto dma_register_err; } + pm_runtime_put(&pdev->dev); return 0; =20 dma_register_err: @@ -1063,7 +1066,6 @@ static void rz_dmac_remove(struct platform_device *pd= ev) channel->lmdesc.base, channel->lmdesc.base_dma); } - pm_runtime_put(&pdev->dev); =20 platform_device_put(dmac->icu.pdev); } --=20 2.43.0 From nobody Wed Sep 10 05:52:53 2025 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010010.outbound.protection.outlook.com [52.101.228.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB5C2371EAA; Fri, 5 Sep 2025 14:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083522; cv=fail; b=nRyceT24Lge8nJHSyoK4BzvS43BhDvXUsIlTxM59gYGUoJ9EEl9Xih0pAxGNvrIkX9TxFyslX0r16EQPvuWXw31ciqcN0OTNQIoujavBcUPK1OClTPsPH6NPfP0I6MEAtZGaikVt6gdgQeLZWMN5jfu1XvD0WgIASsy2VmlcP0g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083522; c=relaxed/simple; bh=ZKgAwpKQCCIs0opkW07MfdZajeoof0x0+8MuoFF8eFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Me98J3vp/YgIbs9lVlYMDh6DW3GrblBtOT9XOALSMWxs3+jf4m70JES2+EdeETdYtQXOv8l919D1zOc+t+wQFRVyPmdLZEBJ9tskJiOkQ8zgIgmTNmWQMZW/oAiMdgQHpdIEJfh+wiqIcGEsrUSp4ceV8RlroUDadMNTY62tKaU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=wMg6SZGm; arc=fail smtp.client-ip=52.101.228.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="wMg6SZGm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mh4HCZTmCudDKq8LI6wRxNGOcfF5zXDjS7e6z9QRcRmRCYcjkl/S9i09ztpsZRKylqZcnc7QCSUGB5tS0EfseFEd1xzP6uEIDUbnTMc9E8+a1TaQx1HVLEfcFLIymHiedPS5oX7DmircXc+2fKNla0Oea6JD3B2LbUDevoPoyM4k5a3FPVs8Pps9+1Fk2czycRyN6RkojdqNjIF2QXDU2hvDc2bpsdw31tXcFovX8UjjZJ88h3SYYMNnNl/k+dTlJX5I+VdWYOIqpeFoz5tVXwqwTaqXQ9li4efWUmtISUfyZIjz5c1GaCss5gqPkZ+dEFDiKEKzyLX648LWs+/wuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SQKWIim/2yRuYWuuItOqo8SC+Qj/P/82LI4F0OcoI4=; b=o3MDfhiWZZgvpK/fZ1criAP9D2zSZm4cevUjsoK/i0sqwuWb+TkLTtpsGnl5CvYskGIVqP/A6VuYaNl8scR1MK8Sf4wHe171vOCjcM9gsv2n6UE6dhKadZFQZ5tSQjnIdN9stjczOO21JR+lyvgGuPEY5HO+oZwJ1W7r5o2v7TDZxiXxzprM++AUb8ZKnqdZSj/1WuFX4MYaS5akkhZs8apgi/icVrCaPDin6wsR6TasJ5ySJKOzYGWUhcCdNSz4OFIZvRBOc1yG6lyqHKLXskUKYiYWM4GMRpDt4avFVSxqMGMEbch5tjRgUwn/F45ftmyleSlYkn+uFndby2uJmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SQKWIim/2yRuYWuuItOqo8SC+Qj/P/82LI4F0OcoI4=; b=wMg6SZGmJUM1kVx4Jr1s/cUJU1P4WNtxyRH5sn9N98MY6U7lgCemHWKvV9Bu7gOBXoxAIn/H7xYCtTBGmQYgtRkXFCEWFsPUYgW9bigebMHZYnU1jo3oMeBiARsR31EOyBl9VhfxvSvMgErwuUpPqyCtYg1cCUwq2nz0wZCcwuc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OS9PR01MB14067.jpnprd01.prod.outlook.com (2603:1096:604:364::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Fri, 5 Sep 2025 14:45:17 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::63d8:fff3:8390:8d31%5]) with mapi id 15.20.9094.016; Fri, 5 Sep 2025 14:45:17 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com, Tommaso Merciai , Vinod Koul , Philipp Zabel , Geert Uytterhoeven , Wolfram Sang , Lad Prabhakar , Fabrizio Castro , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] dmaengine: sh: rz-dmac: Add system sleep power management Date: Fri, 5 Sep 2025 16:44:20 +0200 Message-ID: <20250905144427.1840684-5-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> References: <20250905144427.1840684-1-tommaso.merciai.xr@bp.renesas.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0420.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::17) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OS9PR01MB14067:EE_ X-MS-Office365-Filtering-Correlation-Id: e630f729-db02-4e41-d501-08ddec8ad477 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?p1vbohIcIyGPSLzqk+wIZV++/CwX3Oj9fKEwRmDxVVW4PahxSh+MPjjf0P6V?= =?us-ascii?Q?jo1Vpe43PtwAWY+CgpPb5IaFrEv0XQIL9DDu4ba4hZDQmvZ4V5Ijuh4kqm7N?= =?us-ascii?Q?3qRW39HUmSlvVdJ92009EB6zLajwAU0odihHHA1DfA+GQ7+2yI90rx7C1OTF?= =?us-ascii?Q?kNW+Xsm7mVofC87K8qPPt58ysdRW2izO2SnI5fgCugEMwWntXhu+8HQXf6BK?= =?us-ascii?Q?/IBrNOkorGFEwycY5smaCIxNzOz4n7THE2waZPqDTDkahUnsU7pqMDIJvg3M?= =?us-ascii?Q?f5QgNLdg/wwxnOv+tDUU5A8RLIdtiFR64Um5cJNJ/qBHmQ/j7cZyBDUpAzkV?= =?us-ascii?Q?MW839F+B3pwIPQplwcGIhGpjvkClQBpGDpMSzj8ReG5N0CKRAX0Ol0MlkvLK?= =?us-ascii?Q?sv4x9d5y9XrHDuxR8wiuLB4HQye4me4MwB7L5UrNZZU/GL3gCYd705Dg+W1K?= =?us-ascii?Q?F8p3mXGR9V460lTYExautlRsWdsK/XLNNKTWvf73LnU32zZYBj4dhXjozDjq?= =?us-ascii?Q?aSrfIz7X4eRrnjXM/HX4bkE3b959bd32Xc75k2WwOs92WGG3twieO/nNpRIF?= =?us-ascii?Q?TzKT9w5EUka251E5xqGJZQOVYA09yHFtJR5GmzObEpBCECJNSRgrgIWBXDry?= =?us-ascii?Q?kGtQg+XxxfB5WU4GxqG9v9ekqNpSuXOZzZh6lsQam6k5NtcQywz4NoMUGZug?= =?us-ascii?Q?Ucs68K31n4QenbkZAldaJb/hCG2LR/2BxL9eNNtdixckH5Zpf4xQErYwWKG9?= =?us-ascii?Q?tY/shdFGN1WobhV5dwbNjNcYR6vif3bc2JgTRa6ophS3vHVKcHNsR4gKBNEh?= =?us-ascii?Q?jVufYnjdYxSNJQ12pBVl7aC+cKgE0XZNWak0alTzOMe02Y3j1xZWgk9mDHMf?= =?us-ascii?Q?evDwWHarEoSQ+IWIfgkVJFn1H7ykjAxU6I1xponBxAOlqV2aKdapE2/yxvNU?= =?us-ascii?Q?tAmymcIRISwI5miVlMpN1SfkgJaL1r8m8YMK/WUCpDjoNRnWiyaYb3XClD9O?= =?us-ascii?Q?E02EuMg85qYEyBMaB+YFAadn/5nKDaTp5QotATIE8jroV+SlJgOIdxp4bIU1?= =?us-ascii?Q?L5vFXkGS2Vz8ClftnHmGw997QsHHN6o5fXVCGAl6KqEZy6cmT/85v90qNt5S?= =?us-ascii?Q?RmYX8+D/7iFdhwxZ/NzfY1THqlVEXLqjhYS5zJ3R9jkOBArOoDJpiMQq/H47?= =?us-ascii?Q?k0N42OACQ++Ww5UIzPgxWmrrd/9kLnnx+IlIQrRPimPYDwTsEEyAOgYl0icb?= =?us-ascii?Q?/AiUEWWbQ33yeKdbINkFaoiYAcr+Ui2baXqAA+CtCynoQUTaHtOl9Ypybjxm?= =?us-ascii?Q?lTkEckE2/xoShSMTUz8lORCfqEJCtdZABx50fpj/Zl7dM2DYcLfVbp0V0sV6?= =?us-ascii?Q?bg7sbqw4coP6Y9sTlmOFhD/UTQWUFS3kZZjsM/Ro6Xk8BXmvBvR+qXrJa1HP?= =?us-ascii?Q?F4/Mx0avnZr/hnSY8Nzdd1M4k/XBSCAJQHVH979gt7yU7RYUHloG/A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jfE5GfwWNm3q6XVAfkH4/kV4iE+2g/+NwBQBwGUrnlPNKyYhcMRJeEkMRnEM?= =?us-ascii?Q?z68nRAcUoHYwKfS8fZwkLfwVfu9FS1De0kvYnI2Un+6MVd9/SjX9To6cQ+bI?= =?us-ascii?Q?kWf8mJ5KKKk5Js/PG6p9I5hyomFQoOrftUHDgy/DMF2eo5q7HR3jNJU79E16?= =?us-ascii?Q?FBWf1mfl3X4xfyIsSdc3/CSrCjncZzLU2Eb/HqyYfLIv65O3dtIFcvIJuC6W?= =?us-ascii?Q?BPYEx+ULOc/bY8mS4/8/MPDOZWMhVmda5WcWouW9Hr/XCl2QNg4Z94WfiB38?= =?us-ascii?Q?GBjMsLdjxYvSHiQPgDjj+tXkfiibIN8QH13Mr/6EdnHXhYE4y3pm5X4JbAdZ?= =?us-ascii?Q?XauURr3SadU5rCS1MjP1wMYWeHOiEreeJfpCSfttCLoPc1rsE0jXYBSZNXrG?= =?us-ascii?Q?7+yRx1XLal1WaPCNHiu1IvdGn213DtWK2H8wm5WVbQtHF+vubl5PeWVQlJZ3?= =?us-ascii?Q?+cXGad8LE7LFBpwxgfu54X6kIUDI3R7PDMYofIumYEsgSJW57LSQ7nb+RY4l?= =?us-ascii?Q?gswrXyafhUCltetVYCUx3AH+qLBSLCN/i66Pd5PqdEqd//hNPw5I9A+IPLjG?= =?us-ascii?Q?DKDkZ82rnLGHv4JFrj2/hrM0+o5vkL9tnE7F8BXSXtmG8J2xGPUm66unoz73?= =?us-ascii?Q?bX/iED9klhl6XVzhyTa9oW4Sb8spdvCuRy9kIuttxJyQhhNYbrDuKa8ZGsqr?= =?us-ascii?Q?7KS5rCHtWt719uvsTTJblky+Ej3tub2iUARg0oQj5d9qjOz8VKeO1RNpHVT9?= =?us-ascii?Q?WQHb+glFPYq41P3nqxTDB3sI1u91wyCAtXNeCP4nHuzKHIbwYW3PXsl0WGjE?= =?us-ascii?Q?diAm31WdqmD8zaMYPW3loL/KNPa942gXr8zD7LvoaFfPYL+Qb9J0DW2UPNIn?= =?us-ascii?Q?OKJJMnALEX8GDRkAMgtz2PEJEfz0xMd91t/CQwBc6tmR9U9P9WbpNCuBQpeG?= =?us-ascii?Q?UDyMqwPq1Sa002Iw8HyvjHti+jP5G6IkcizVPU8LUjxbg+5QytGrTvKtLyIF?= =?us-ascii?Q?sZXRnN3g6pgAJ1UGEHKFsODQyTd6IaLyCRkW6GzuabUJ3QwHMEzJvhB0B1CR?= =?us-ascii?Q?PC+gugRgUWpMxmAQCxFhz2VmKRDnNgMR+DyXjPWpywgmf1MMtLA787rsaHRu?= =?us-ascii?Q?4QM7dDDkwbDcYTmq9Wxg3/040JL4JI3RpXoWY3Mk7qv1NMLnc1aozjB1cJar?= =?us-ascii?Q?TSLI7T/TkIOfyYqpCey8dBvrlpK8N8RWklpV5/ObIgmRK7j+ddUVc0TzC/go?= =?us-ascii?Q?pejEkC8wWN/+eAtNJPj+xNpPZHm+r8D7MfMvsIe0PEMz1RrTdCliuP4uoXog?= =?us-ascii?Q?MBxrlfXXTEDpVt4zYjnfk6QKkk+GWBYswkUD/GYu6yCGZ/LhnxUVwKGmGmkP?= =?us-ascii?Q?Wyj1DzxXR4m0GOujhjdn+hL/PRH62VfL3L10K7/wEuc/XA0oMtJV3O40rhrb?= =?us-ascii?Q?sow9WJvWImbcmqJSDtvxucn2eF5p1yIMd4gn/6lwl6mgnDEklFytuvTVwyIL?= =?us-ascii?Q?O1es4OwL2rOsryADNzkKJwl1uK4aFolbNRmqJhAJxwku9daRT8iKQhcUv/7V?= =?us-ascii?Q?yedvV9b90rdkl+dyjogmUmdlT36Ya07Vsyb6hCo8GjhwAnTejsouV9HlKMEc?= =?us-ascii?Q?ualBMKzUb12ZqfGU4OarJNI=3D?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: e630f729-db02-4e41-d501-08ddec8ad477 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 14:45:17.3898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ba1zRAB0xhPHxGNfDtGf6vLmdpMLEFzJM0BSOIokxkOCANpr8kyYR7ZWbKYdfF3/j6MiL37NhqhbOUyzK+3pqW3tApupnQgQVeoVowpZNjLRm05z/53L/6g0FcgoVyTr X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB14067 Content-Type: text/plain; charset="utf-8" Add runtime and system sleep power management operations to the RZ DMAC driver. This enables proper handling of suspend and resume sequences, including device reset and channel re-initialization, preparing the driver for power state transitions. Signed-off-by: Tommaso Merciai --- drivers/dma/sh/rz-dmac.c | 47 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 4ab6076f5499e..d849e313a7f79 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -437,6 +437,24 @@ static int rz_dmac_xfer_desc(struct rz_dmac_chan *chan) * DMA engine operations */ =20 +static int rz_dmac_chan_init_all(struct rz_dmac *dmac) +{ + unsigned int i; + int ret; + + ret =3D pm_runtime_resume_and_get(dmac->dev); + if (ret < 0) + return ret; + + rz_dmac_writel(dmac, DCTRL_DEFAULT, CHANNEL_0_7_COMMON_BASE + DCTRL); + rz_dmac_writel(dmac, DCTRL_DEFAULT, CHANNEL_8_15_COMMON_BASE + DCTRL); + + for (i =3D 0; i < dmac->n_channels; i++) + rz_dmac_ch_writel(&dmac->channels[i], CHCTRL_DEFAULT, CHCTRL, 1); + + return pm_runtime_put_sync(dmac->dev); +} + static int rz_dmac_alloc_chan_resources(struct dma_chan *chan) { struct rz_dmac_chan *channel =3D to_rz_dmac_chan(chan); @@ -1070,6 +1088,34 @@ static void rz_dmac_remove(struct platform_device *p= dev) platform_device_put(dmac->icu.pdev); } =20 +static int rz_dmac_suspend(struct device *dev) +{ + struct rz_dmac *dmac =3D dev_get_drvdata(dev); + + return reset_control_assert(dmac->rstc); +} + +static int rz_dmac_resume(struct device *dev) +{ + struct rz_dmac *dmac =3D dev_get_drvdata(dev); + int ret; + + ret =3D reset_control_deassert(dmac->rstc); + if (ret) + return ret; + + return rz_dmac_chan_init_all(dmac); +} + +static const struct dev_pm_ops rz_dmac_pm_ops =3D { + /* + * TODO for system sleep/resume: + * - Wait for the current transfer to complete and stop the device, + * - Resume transfers, if any. + */ + SYSTEM_SLEEP_PM_OPS(rz_dmac_suspend, rz_dmac_resume) +}; + static const struct of_device_id of_rz_dmac_match[] =3D { { .compatible =3D "renesas,r9a09g057-dmac", }, { .compatible =3D "renesas,rz-dmac", }, @@ -1079,6 +1125,7 @@ MODULE_DEVICE_TABLE(of, of_rz_dmac_match); =20 static struct platform_driver rz_dmac_driver =3D { .driver =3D { + .pm =3D pm_sleep_ptr(&rz_dmac_pm_ops), .name =3D "rz-dmac", .of_match_table =3D of_rz_dmac_match, }, --=20 2.43.0