From nobody Wed Sep 10 11:07:13 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF92036CE10 for ; Fri, 5 Sep 2025 14:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757082139; cv=none; b=BOJkmh8AIzIO6KhVXrUzwRKwdiJErNQeGQcYsuQmiDV7uixHZwsFxzJuXlSLNfmaVX0AWwnSag9dflfGxo4JH9Ii2pmjPjZYoMN+rdZRk0hWOoTZW13aoBG5LC8Lgl14kvt1xUg5cGemy9M+CN6UoQle3jFXGj+w0TRVNHgl9Jc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757082139; c=relaxed/simple; bh=Hc11dQRZZPHY3rRj8sQC49olD9NpE7/7qRqZ+w5XAn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hfEWotzDgUbAGffX9cUY5DK7OqlqkUeYetsl5wYUVxVqCScKPZoEVwB0FDuC43zvHlhNqkLtn9EScxDYhlWrtu04+P8pHEb+t13A4CPyRzKWKOFfqkz8CMNqy8uhifZ1EfmAOfAvis/s10cArqKpWTGjP/jajmjrfyEWnQ7IYZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=EGi4rZ3g; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EGi4rZ3g" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b046f6fb2a9so340203266b.2 for ; Fri, 05 Sep 2025 07:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1757082135; x=1757686935; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OV1LDwfiuLJ9IBiJAs7IEkPWomukwV1rFx4+Ev+/eEE=; b=EGi4rZ3gXp98MjF18cLDkcwhmcT3KAvL9cEWX0LJ4qcLVNHyJFtaNShOppa2UcyQhH CArbZZqBY6WpjM2thXJuFIe6HjYgFyUdG18KBKPWrDhuMRNbIZfWKxJ+d2zZisJguuMm QoJPx+6Y9fiPREwXKgX2FUnp4maOj08lmMFJg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757082135; x=1757686935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OV1LDwfiuLJ9IBiJAs7IEkPWomukwV1rFx4+Ev+/eEE=; b=rGEt1IEXsauXYS3fDYbuYt5vCAQ5/XVH1+qEGtRIB41oykpNewJ4Oq2QWuCP5jnbBw fgBog5IhV1IL3DKh/1zia/XqL46q8w6FlmY2rXEXfZMInA62SC2plWPG3MXeXZCOxjHT fBzBPmLo5Wl+CDA2EIEdASB6rraJCg901h5d/xjqTWDryI4BuWEZ+V9fTUy3lk6vizyS 1PKxNVSQJs4Vvs7favF0f1/gO483sVwuzU/X/5YRLUG7raiaBbS2o4lw26bdjooz9UO3 AznXySh7yG0yX0IiT+MktklaIZCrX13T6d0bfXxmvn5bNcZkDeKvu0Hstq0TPeZVHfHP crwA== X-Forwarded-Encrypted: i=1; AJvYcCVXr9xiOXX239Rfq8aWpzs4BRCsYC/XQGo2vDzqfxDw3R0E9G/oxSTgbw0EEWT95KR99ZmTyxx81XhTVtc=@vger.kernel.org X-Gm-Message-State: AOJu0YzX7fcRpv3sbczEPlDAROwtBmenN4rxuKSbH7KkB59nv8eVQkKe E/ufrtnF4pntNGx3p/CpCxum9jq7mkNwvL2rR7XFsB/OPjXL7/qHKJlGt8Xt7akVoQ== X-Gm-Gg: ASbGnctEdxaaGS0ZBzV921wG8dZ/pwxzpFETD+4yj4pehUb4dgfPBocwLUO0sUwi4H+ 1mSlAb5ytJlG6Epydf452Ir4f5EP7XQfYuN1W1H2MdRd/idkdsBmd4yWPerrdoRnAwQKCOm26fI VKzoZbq4FMXtUM0RB8uIuGmucVTAeI9jBjHcnq2yMaa4CA3qoW9nYPIhyWtArYX70PtklMS47H8 y/tqMtCImpzF9r8rXTOYf+goP8ZBNWukPCn3LXaVmTT28qFQO0lv5cH1bMj2nnEH/jWa1CUNseN uyQBwdSo1btszOUZYWDe5fFitPmBWUxz/MuiDggqbPJjrkw8N21FcHQ8UmH2tAgmFVYZqKNFOti yCQJOEtoqrzXXK2LqtQc3jgywHlXIP7UaEMelphJNcTlSDqAD2C6fJ5xCMViqTZCXHqJqDF8g6Z XRG5dqAYoogfMpeRhbDBFHHJXmoA== X-Google-Smtp-Source: AGHT+IFCvd3VJRlMQTN63ZbgjjAhsrShJNCJ07Shx+1GenFVnJohKqUi4MazUtwYOIyKPWi7eRjrKA== X-Received: by 2002:a17:907:1c8c:b0:b04:8ed3:9e81 with SMTP id a640c23a62f3a-b048ed3d358mr431118866b.31.1757082134828; Fri, 05 Sep 2025 07:22:14 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (240.225.32.34.bc.googleusercontent.com. [34.32.225.240]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b0476e0d61esm502141066b.53.2025.09.05.07.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 07:22:14 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v3 1/5] usb: typec: Add mode_control field to port property Date: Fri, 5 Sep 2025 14:22:02 +0000 Message-ID: <20250905142206.4105351-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.51.0.355.g5224444f11-goog In-Reply-To: <20250905142206.4105351-1-akuchynski@chromium.org> References: <20250905142206.4105351-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This new field in the port properties dictates whether the Platform Policy Manager (PPM) allows the OS Policy Manager (OPM) to change the currently active, negotiated alternate mode. Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus --- drivers/usb/typec/class.c | 9 ++++++--- drivers/usb/typec/class.h | 2 ++ include/linux/usb/typec.h | 2 ++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 67a533e35150..9f86605ce125 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -457,11 +457,13 @@ static umode_t typec_altmode_attr_is_visible(struct k= object *kobj, struct attribute *attr, int n) { struct typec_altmode *adev =3D to_typec_altmode(kobj_to_dev(kobj)); + struct typec_port *port =3D typec_altmode2port(adev); =20 if (attr =3D=3D &dev_attr_active.attr) - if (!is_typec_port(adev->dev.parent) && - (!adev->ops || !adev->ops->activate)) - return 0444; + if (!is_typec_port(adev->dev.parent)) { + if (!port->mode_control || !adev->ops || !adev->ops->activate) + return 0444; + } =20 return attr->mode; } @@ -2681,6 +2683,7 @@ struct typec_port *typec_register_port(struct device = *parent, } =20 port->pd =3D cap->pd; + port->mode_control =3D !cap->no_mode_control; =20 ret =3D device_add(&port->dev); if (ret) { diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h index db2fe96c48ff..c53a04b9dc75 100644 --- a/drivers/usb/typec/class.h +++ b/drivers/usb/typec/class.h @@ -80,6 +80,8 @@ struct typec_port { */ struct device *usb2_dev; struct device *usb3_dev; + + bool mode_control; }; =20 #define to_typec_port(_dev_) container_of(_dev_, struct typec_port, dev) diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 252af3f77039..8f51665d44ec 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -287,6 +287,7 @@ enum usb_pd_svdm_ver { * @prefer_role: Initial role preference (DRP ports). * @accessory: Supported Accessory Modes * @usb_capability: Supported USB Modes + * @no_mode_control: Ability to manage Alternate Modes * @fwnode: Optional fwnode of the port * @driver_data: Private pointer for driver specific info * @pd: Optional USB Power Delivery Support @@ -304,6 +305,7 @@ struct typec_capability { enum typec_accessory accessory[TYPEC_MAX_ACCESSORY]; unsigned int orientation_aware:1; u8 usb_capability; + bool no_mode_control; =20 struct fwnode_handle *fwnode; void *driver_data; --=20 2.51.0.355.g5224444f11-goog