From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F7C285C99; Fri, 5 Sep 2025 10:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067852; cv=pass; b=HKdol5IAGneI2okIiUp9r6tGykFocWGZGuXVfMw/52Lanxui53JanzBSq4hn0LjaR2emYHUGAz/7KLSLG8A5NI5e7zI8OIjCGIKSW1iYWkSqFxYE2rE+dnBOfcjpKsd5JVd4dGjcD6jwTrcKQ9caRgXeXXyhylvEPUMS7DtoJ6g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067852; c=relaxed/simple; bh=doo3dsFiTqKsGg19O+EDQAM/al9bo9cfIianA6jd4fU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q0TeA1ONT0zyqHQuyn5TA3p6Udq5aVT3UsqVOOPDUyPs3GrkoM6fVnJu9jwswksgZtHZJYCYs3lzPtA/AVJFq644sym2hNUkmudNUfyPaF0rDTI9Gep5HQNEt2a1OEDuUyNMdY2pIQssuVZRwYVl7HbQuoiYBZ9GwK9bIh6c1W0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=X8H3fZlw; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="X8H3fZlw" ARC-Seal: i=1; a=rsa-sha256; t=1757067824; cv=none; d=zohomail.com; s=zohoarc; b=fORs12r/9P+bFpGppwpXrPNY9ard+PY5cVLBuKdNL3SdN9NZBThRxBIqwBRC3RRlt9JmdS1HgWkXvVGWe1k4WvDv74hVAxzlKBp5Z17eMKIclj4g+cXgXIjTJNVO/YHOiO3dC/b7eFlPCI2Qt+8fOytzOodT60firynnIf+z62M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067824; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Us0SdR9VkXymGZbNuZ4zsRJNiU5eRP0UPu2QfVitveY=; b=iEcxPCRcnqRrp7tx8S1d9qLPnjZJL+OZkt1xQx4yq4wXFal9F3KPmLmLJYfqW81v8uF1MUKH5fZxmprzD84DMXtNTmEr7rltV0YuwodzKJfaxVECq6B5LVIyv9nuPoNqIYhzTA6dPnnE5EWvel35sIqiWVZ2HMCSJPk7JJ4heZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067824; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Us0SdR9VkXymGZbNuZ4zsRJNiU5eRP0UPu2QfVitveY=; b=X8H3fZlwvrqV2W9DrXWK9DH2likHLKheHzb2jOGK1XKGCSDA3mGwvFcXFXWQfwZV 0xvKfdth+jiNISINF6+NsEBWJXizf1P5aeUEHkGZfuAYc/jQrXTe+HpChlxbDyUVovd vG2bxmWJKpiaycfJ4dB2MDjwcYAQB6pu5b4MlmLo= Received: by mx.zohomail.com with SMTPS id 1757067820867668.3962305402956; Fri, 5 Sep 2025 03:23:40 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:22:57 +0200 Subject: [PATCH RFC 01/10] dt-bindings: gpu: mali-valhall-csf: add mediatek,mt8196-mali variant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-1-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 The Mali-based GPU on the MediaTek MT8196 SoC is shackled to its concept of "MFlexGraphics", which in this iteration includes an embedded MCU that needs to be poked to power on the GPU, and is in charge of controlling all the clocks and regulators. In return, it lets us omit the OPP tables from the device tree, as those can now be enumerated at runtime from the MCU. Add the mediatek,mt8196-mali compatible, and a performance-controller property which points to a node representing such setups. It's required on mt8196 devices. Signed-off-by: Nicolas Frattaroli --- .../bindings/gpu/arm,mali-valhall-csf.yaml | 36 ++++++++++++++++++= +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yam= l b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml index a5b4e00217587c5d1f889094e2fff7b76e6148eb..6df802e900b744d226395c29f8d= 87fb6d3282d26 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml @@ -19,6 +19,7 @@ properties: - items: - enum: - rockchip,rk3588-mali + - mediatek,mt8196-mali - const: arm,mali-valhall-csf # Mali Valhall GPU model/revisio= n is fully discoverable =20 reg: @@ -53,6 +54,13 @@ properties: opp-table: type: object =20 + performance-controller: + $ref: /schemas/types.yaml#/definitions/phandle + description: + A phandle of a device that controls this GPU's power and frequency, + if any. If present, this is usually in the form of some specialised + embedded MCU. + power-domains: minItems: 1 maxItems: 5 @@ -91,7 +99,6 @@ required: - interrupts - interrupt-names - clocks - - mali-supply =20 additionalProperties: false =20 @@ -105,9 +112,24 @@ allOf: properties: clocks: minItems: 3 + performance-controller: false power-domains: maxItems: 1 power-domain-names: false + required: + - mali-supply + - if: + properties: + compatible: + contains: + const: rockchip,mt8196-mali + then: + properties: + mali-supply: false + sram-supply: false + operating-points-v2: false + required: + - performance-controller =20 examples: - | @@ -143,5 +165,17 @@ examples: }; }; }; + - | + gpu2: gpu@48000000 { + compatible =3D "mediatek,mt8196-mali", "arm,mali-valhall-csf"; + reg =3D <0x48000000 0x480000>; + clocks =3D <&mfgpll 0>; + clock-names =3D "core"; + interrupts =3D , + , + ; + interrupt-names =3D "job", "mmu", "gpu"; + performance-controller =3D <&gpufreq>; + }; =20 ... --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB292D6626; Fri, 5 Sep 2025 10:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067859; cv=pass; b=E0Fh9swcmoVSo6xirzbqxOnYkAv+cqIeDO2RygqKxRaHsIz7OGuEsd5UEYG1VUNCZT8L7eSIsgj79YGohxb+j+HgfzevZCZfgkLzcJpwZDxaA2Szki4OKr/6eawrtku0BHN5PUbYp8744CCdG+4716vk1mi6XIg+2/7RQzXOSLo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067859; c=relaxed/simple; bh=KKeJHcuyfcAZEQqhEka41a06N41CtHc4T5e3u0Iv8uY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UoFVYvKFrDof6JY2H7PKlG2+bh2xG0p9NcMqBM0TxjFOy9ZL5lnAEYKp7AfSOjWdGYdQ4b3r2q5NWGOJFBpMfh2i2TQuoLU0iQPowGORF9YNnFhTWC0BHFneb8XAdRtpI73jb/Kwa/AlGGMr37BH1uhEQoMpg6XMQBk5jz78Kz4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=g3iqPgC0; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="g3iqPgC0" ARC-Seal: i=1; a=rsa-sha256; t=1757067830; cv=none; d=zohomail.com; s=zohoarc; b=hkH1JYAHlf6zYePcwkDs61WrJEaI2U8t/sNwWsVY11sa6gvljLXFKRyq23txh7Y0Yv/uK19wlrT3e4SXgdCBDWXxCGU2f/oJATnXFjxrS1Xyh56URnRI0fPrXndq6Tjl8qjX+VBIhDeUp5bM1Ci0OK9TjEX3DZ5WB30W1mUPVlw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067830; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=xJDFnVvMBGp0ssnHfwN1wWO5gqMs/oZsQPyIp11iV0U=; b=oHxzZdt1XRFdsUMU9mwdgeHf/jr+YHjl9c1yoeJhH+tc2SygADI4O/gLUbezcJx/4RVn3lZiQr1206srArcmv1rbc1ptKdtZPqI1aabaJNbwK+63CtNPKpYv2MW1qIdseCmoIZuA+DsbGfpOyEGX52kh7FAuB+SL7+qcKW5byHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067830; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=xJDFnVvMBGp0ssnHfwN1wWO5gqMs/oZsQPyIp11iV0U=; b=g3iqPgC0yF5eeVlbjETcewPUummZO+BM/mR5xuxysw/iJzhR3Nwxq4zw7SVT78kb SEqjPanpnv74k+zqvlst6WUHmNUjdT2b0kHoX29/2dt6rOSdoiFAaT9RyxU5Xo+CA/D nqSkQnfZird48/prsZJb/VBo245LgQdYiapYjiI0= Received: by mx.zohomail.com with SMTPS id 1757067828625770.7656618316871; Fri, 5 Sep 2025 03:23:48 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:22:58 +0200 Subject: [PATCH RFC 02/10] dt-bindings: devfreq: add mt8196-gpufreq binding Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-2-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 On the MediaTek MT8196 SoC, the GPU has its power and frequency dynamically controlled by an embedded special-purpose MCU. This MCU is in charge of powering up the GPU silicon. It also provides us with a list of available OPPs at runtime, and is fully in control of all the regulator and clock fiddling it takes to reach a certain level of performance. It's also in charge of enforcing limits on power draw or temperature. Add a binding for this device in the devfreq subdirectory, where it seems to fit in best considering its tasks. The functions of many of the mailbox channels are unknown. This is not the fault of this binding's author; we've never received adequate documentation for this hardware, and the downstream code does not make use of them in a way that'd reveal their purpose. They are kept in the binding as the binding should be complete. Signed-off-by: Nicolas Frattaroli --- .../bindings/devfreq/mediatek,mt8196-gpufreq.yaml | 116 +++++++++++++++++= ++++ 1 file changed, 116 insertions(+) diff --git a/Documentation/devicetree/bindings/devfreq/mediatek,mt8196-gpuf= req.yaml b/Documentation/devicetree/bindings/devfreq/mediatek,mt8196-gpufre= q.yaml new file mode 100644 index 0000000000000000000000000000000000000000..1fe43c9fc94bb603b1fb77e9a97= a27e92fea1ae8 --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/mediatek,mt8196-gpufreq.yaml @@ -0,0 +1,116 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/devfreq/mediatek,mt8196-gpufreq.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MFlexGraphics Performance Controller + +maintainers: + - Nicolas Frattaroli + +properties: + $nodename: + pattern: '^performance-controller@[a-f0-9]+$' + + compatible: + enum: + - mediatek,mt8196-gpufreq + + reg: + items: + - description: GPR memory area + - description: RPC memory area + - description: SoC variant ID register + + reg-names: + items: + - const: gpr + - const: rpc + - const: e2_id + + clocks: + items: + - description: main clock of the embedded controller (EB) + - description: core PLL + - description: stack 0 PLL + - description: stack 1 PLL + + clock-names: + items: + - const: eb + - const: mfgpll + - const: mfgpll_sc0 + - const: mfgpll_sc1 + + mboxes: + items: + - description: FastDVFS events + - description: frequency control + - description: sleep control + - description: timer control + - description: frequency hopping control + - description: hardware voter control + - description: gpumpu (some type of memory control, unknown) + - description: FastDVFS control + - description: Unknown + - description: Unknown + - description: Unknown, but likely controls some boosting behaviour + - description: Unknown + + mbox-names: + items: + - const: fast_dvfs_event + - const: gpufreq + - const: sleep + - const: timer + - const: fhctl + - const: ccf + - const: gpumpu + - const: fast_dvfs + - const: ipir_c_met + - const: ipis_c_met + - const: brisket + - const: ppb + + shmem: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the shared memory region of the GPUEB MCU + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + - mboxes + - mbox-names + - shmem + +additionalProperties: false + +examples: + - | + #include + + gpufreq: performance-controller@4b09fd00 { + compatible =3D "mediatek,mt8196-gpufreq"; + reg =3D <0x4b09fd00 0x80>, + <0x4b800000 0x1000>, + <0x4b860128 0x4>; + reg-names =3D "gpr", "rpc", "e2_id"; + clocks =3D <&topckgen CLK_TOP_MFG_EB>, + <&mfgpll CLK_MFG_AO_MFGPLL>, + <&mfgpll_sc0 CLK_MFGSC0_AO_MFGPLL_SC0>, + <&mfgpll_sc1 CLK_MFGSC1_AO_MFGPLL_SC1>; + clock-names =3D "eb", "mfgpll", "mfgpll_sc0", + "mfgpll_sc1"; + mboxes =3D <&gpueb_mbox 0>, <&gpueb_mbox 1>, <&gpueb_mbox 2>, + <&gpueb_mbox 3>, <&gpueb_mbox 4>, <&gpueb_mbox 5>, + <&gpueb_mbox 6>, <&gpueb_mbox 7>, <&gpueb_mbox 8>, + <&gpueb_mbox 9>, <&gpueb_mbox 10>, <&gpueb_mbox 11>; + mbox-names =3D "fast_dvfs_event", "gpufreq", "sleep", "timer", "fh= ctl", + "ccf", "gpumpu", "fast_dvfs", "ipir_c_met", "ipis_c_m= et", + "brisket", "ppb"; + shmem =3D <&gpufreq_shmem>; + }; --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D082D6E62; Fri, 5 Sep 2025 10:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067862; cv=pass; b=hPyjhXhwNrP59hekqTygG+A5oJ0iM7ZetuQSAkzzJYdFT8beNTSxOkZJnD/IoNMP5uXLiUnj7LZ9e529cqFx8pHtpZNGHvxCET43Ho+xWCdMoX1y1ea0WwQye6qpRGnfK+MG9FHHE+XRr6z6YW2AFPGEBda3DXoH13h9g+ufmm4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067862; c=relaxed/simple; bh=Wk1WuCPAy63+DfPu+yCY5hSD1PmaFUWsdVDHkjsS/+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QQwE3Bekr2Yx1ba5SnTYwKa/bH2IQBgZBGhM/UNqVTMTopX8aMdSer9hpxLqrnWWAZ861ujBxnibt1f9KfaHWYsTFmPYCq2wpZ11xjvk8smueMfiPHbce9ZEvcXxH4azHof7omyOat1V4ENvzMqVsEbNYkfTWXrkb0QXG/WA4LA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=cpZi6IsO; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="cpZi6IsO" ARC-Seal: i=1; a=rsa-sha256; t=1757067836; cv=none; d=zohomail.com; s=zohoarc; b=ATg3h1zfv3/jS6zXhkHRoPD3g9DIqIS+2eN2G4Jo5dnkbCpTKlN97xxnoMyqm+4VEEpq8uKQ4WNKloi2BB983gMCvWM4lTZJ/sSsB3MwL950b0VxSTCrNMRVZutQD0vA2bYko24KR/29ciL0w7IH54uP3eZWncEGMZU6BgGpsnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067836; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=mG1dwW8e+KHt5M47urUQVsE3NGGmomoS29HjaU5lJmw=; b=SoCr2YzRUQWKK3GYq4uMzKPrwztceuMJHaOjBv8SSvqMZHU/VyoxwMCEpEtO62onwgNhocPbEU5f1UyXobly7dnv4RxSk49+euG4EXYuXJkjd6bX3URLE69dLEXrHSACDEwG+BXoalm36VHTp5yR1Zh4xDuP0HXWEoKBcDTIWRk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067836; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=mG1dwW8e+KHt5M47urUQVsE3NGGmomoS29HjaU5lJmw=; b=cpZi6IsOGzsNtksRZR7kgEozkeRs1S/z6eupPnXQ7jCjm8Molu0n31MS0CujbVAH JEx+Lwi2KkSDkymGRZ4yS/shYv/yhDUBx4EpLgsqpbIOjb4CEgxAxXSD907vhyBjlCN TonGngEYG+70JBlUgPfYDMAJ055NKA04HXLjDQKU= Received: by mx.zohomail.com with SMTPS id 175706783425443.237791990502046; Fri, 5 Sep 2025 03:23:54 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:22:59 +0200 Subject: [PATCH RFC 03/10] dt-bindings: sram: Add compatible for mediatek,mt8196-gpufreq-sram Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-3-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 This compatible is used for an SRAM section that's shared between the MT8196's application processor cores and the embedded GPUEB MCU that controls the GPU frequency. Through this SRAM section, things about the GPU frequency controller like the OPP table can be read. Signed-off-by: Nicolas Frattaroli Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/sram/sram.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentati= on/devicetree/bindings/sram/sram.yaml index 7c1337e159f2371401ae99313375656fff014ed4..6ba0dd6a66def11f56a1d5276d7= 397b655bff11e 100644 --- a/Documentation/devicetree/bindings/sram/sram.yaml +++ b/Documentation/devicetree/bindings/sram/sram.yaml @@ -89,6 +89,7 @@ patternProperties: - arm,juno-scp-shmem - arm,scmi-shmem - arm,scp-shmem + - mediatek,mt8196-gpufreq-sram - renesas,smp-sram - rockchip,rk3066-smp-sram - samsung,exynos4210-sysram --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D2E42D640A; Fri, 5 Sep 2025 10:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067870; cv=pass; b=bR4abjVlGkI4MzhL50G6xaYfhvcKIMrzvWSXlw96wiwJqnvSv0bf+IZftJvkv5DLRi3SdBAX/uBSMw/BykHyI3KkBvznfpW7+2nJzVMpefva4KDuZuOQxP+8GD75fjUzMrIanVY7pQeHlGQ6syUQFnyr3W6n4ojlhpinjOjfbnQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067870; c=relaxed/simple; bh=38ojihanihmK8WTQZT45+T1HhdbhtLjB3V1NJxQwLJA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sxSdyNttzVNicee+Wn9EoL+0g7zoL/Kzs9YYsFTcc5AcaP5OxL7m7UTJenIGMUK00k7jlOa26W7hZh5JjdxTe2z5TJRd7E6VFJhuOBmS1f9jrVgbnxgeNn+BVo7URhKovIYKWlBWlXYRCiQE7V8JzfS3eRQgBv9r+6vfmMslFN0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=Hldl4bd6; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="Hldl4bd6" ARC-Seal: i=1; a=rsa-sha256; t=1757067840; cv=none; d=zohomail.com; s=zohoarc; b=hfGlNTvaNfyjc7EUprihGHziCko/dyeAG0KhFB9+bcFFP32qZp+sZLwN/ZZu5yQ8HA+cbOYCi2fjL8tMXPZBAnZFzBsVIMlOAC7ocMa9oXC4oN5dr+2ltvkAWrMI+IHQ+If6hVFpRpmq+pet80MJdCxLXtrA0X61I9ZIUfFmJuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067840; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=28hWbwauwaaUzRKE5Rn+QofWKCrZmo0Z+fU+KOp7vb4=; b=fRAtYjYE1HZUDBdUduTBLgTjIGgSa8d2R3AfVu1Tdrh5Vvj52313olGIBEQXj2QV+Qm63DL6XlslM9bJIfa5fU+FzHR0ll6PPUGUozWHr66U06oe7iRVFXGnsiiqTNquDyGxGMkLuISAmkaaJ4m7ZoY7RVhoUQtxKf93ct+uLI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067840; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=28hWbwauwaaUzRKE5Rn+QofWKCrZmo0Z+fU+KOp7vb4=; b=Hldl4bd6STxNyqkR5U1l/1OGA2b+HBhwp9EuJ057EXjMDyFLGajTZ57A3Ponm3z5 OhZ77KKk2vMpmEEDEWEjKKgkV737SFGo3Z2WoWgamA70ZxR8g6YS9TdaKmxpNbEInSr YG5PYBoPHu3y/3LmMw4XriI3fdFB5Rgb2I+HoRi8= Received: by mx.zohomail.com with SMTPS id 1757067839865275.92172227990136; Fri, 5 Sep 2025 03:23:59 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:00 +0200 Subject: [PATCH RFC 04/10] dt-bindings: mailbox: Add MT8196 GPUEB Mailbox Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-4-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 The MediaTek MT8196 SoC includes an embedded MCU referred to as "GPUEB", acting as glue logic to control power and frequency of the Mali GPU. This MCU runs proprietary firmware for this purpose, and the main application processor communicates with it through a mailbox. Add a binding that describes this mailbox. Signed-off-by: Nicolas Frattaroli --- .../mailbox/mediatek,mt8196-gpueb-mbox.yaml | 64 ++++++++++++++++++= ++++ 1 file changed, 64 insertions(+) diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,mt8196-gpue= b-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,mt8196-gpu= eb-mbox.yaml new file mode 100644 index 0000000000000000000000000000000000000000..506723d54ae0a429b462914f366= 6184c24c4fc5a --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/mediatek,mt8196-gpueb-mbox.= yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mailbox/mediatek,mt8196-gpueb-mbox.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MFlexGraphics GPUEB Mailbox Controller + +maintainers: + - Nicolas Frattaroli + +properties: + compatible: + enum: + - mediatek,mt8196-gpueb-mbox + + reg: + items: + - description: mailbox data registers + - description: mailbox control registers + + reg-names: + items: + - const: mbox + - const: mbox_ctl + + clocks: + items: + - description: main clock of the GPUEB MCU + + interrupts: + items: + - description: fires when a new message is received + + "#mbox-cells": + const: 1 + description: + The number of the mailbox channel. + +required: + - compatible + - reg + - reg-names + - clocks + - interrupts + - "#mbox-cells" + +additionalProperties: false + +examples: + - | + #include + #include + #include + + gpueb_mbox: mailbox@4b09fd80 { + compatible =3D "mediatek,mt8196-gpueb-mbox"; + reg =3D <0x4b09fd80 0x280>, + <0x4b170000 0x7c>; + reg-names =3D "mbox", "mbox_ctl"; + clocks =3D <&topckgen CLK_TOP_MFG_EB>; + interrupts =3D ; + #mbox-cells =3D <1>; + }; --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6D02D73BF; Fri, 5 Sep 2025 10:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067878; cv=pass; b=myoPgg1QtMeAqMLz0aVI/EAWd3ThW1z3ttUHVZ3YmFr6GA1JlifgIYBv/+H/iyBzQBxmAgexhqsSkPLrjA5yM/untbpWVAbY0AH/+kjFkJnnvV20HJL+aHUC1urkt6FAeFWoBh3zySsC+S1tLyFIMX7rY5H78qC2LXFk2myMWcM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067878; c=relaxed/simple; bh=EW4TI+M+YTyeB6BySTVQWy3FOUsIL0NZkItg90zuExs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FVcY68dx53mJNyoOwJl5XRtA6QVC6sGsv7cXRRebzrA6n4ih10/pZhMM6SHyy32kOEAUVv7uGG3jXmMjgdMS72dflLnx/0wS8P+uvVzKA/Ry7p/pCQosW9GXbghnZ9SM30Lnxgf3/XmYUm/suvagTntX5auNB+8lHZ4ioJIIUhc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=VB5WpbeV; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="VB5WpbeV" ARC-Seal: i=1; a=rsa-sha256; t=1757067846; cv=none; d=zohomail.com; s=zohoarc; b=JX35byA9/31dFhHnrRz/D2hMPGhtfj5bKvVKaBQcQhd23r1uvJE0iICriuvKcing7/FVfPuFv+xkwManz4AIqS2irpNi+gQ+ft1+AI/o48V1j4jintBAL//pYYCy8yq3kR5MkVUyM+aofY4SCGdGSB5W+ziEWZROk5gaHzco3Qo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067846; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=jm3XtT05t/JfcT2cGOwXkftDzpRsXc43Ryjsa/YEQAg=; b=DwKxdrsE3n5lFDwzP8USUaMg1feuyf351l0O0VVTJuVNp7oPMxLoVP2NVZQ07n0187+TtzAcdQd2af1Tcf7xSqNuez2UY817C2eJT9t/hxb+FQniPFJv53EANdwe89Ffy87ggkQ8Ic5Tgd3eOmS+QlGpHjAOpQZtvWfC+KzZfsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067846; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=jm3XtT05t/JfcT2cGOwXkftDzpRsXc43Ryjsa/YEQAg=; b=VB5WpbeVRSBNeVbRoIVQWTtPjOoQKkXMpkCfNus20HVLPABfGoEzdFWfsjiN6XhM BEjfaT9kHP9NzDq1gfDtaa9yYp5rKPiEAQlz2Qwgh7Ge8B0WbYb7gY6eratF82B6TVu VSQh/csebEQBbKq7eMPxEvvcyICBYpbij9ZH34c8= Received: by mx.zohomail.com with SMTPS id 1757067845420698.0762341560868; Fri, 5 Sep 2025 03:24:05 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:01 +0200 Subject: [PATCH RFC 05/10] mailbox: add MediaTek GPUEB IPI mailbox Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-5-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 The MT8196 SoC uses an embedded MCU to control frequencies and power of the GPU. This controller is referred to as "GPUEB". It communicates to the application processor, among other ways, through a mailbox. The mailbox exposes one interrupt, which appears to only be fired when a response is received, rather than a transaction is completed. For us, this means we unfortunately need to poll for txdone. The mailbox also requires the EB clock to be on when touching any of the mailbox registers. Add a simple driver for it based on the common mailbox framework. Signed-off-by: Nicolas Frattaroli --- drivers/mailbox/Kconfig | 10 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-gpueb-mailbox.c | 330 ++++++++++++++++++++++++++++++++= ++++ 3 files changed, 342 insertions(+) diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index 02432d4a5ccd46a16156a09c7f277fb03e4013f5..2016defda1fabb5c0fcc8078f84= a52d4e4e00167 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -294,6 +294,16 @@ config MTK_CMDQ_MBOX critical time limitation, such as updating display configuration during the vblank. =20 +config MTK_GPUEB_MBOX + tristate "MediaTek GPUEB Mailbox Support" + depends on ARCH_MEDIATEK || COMPILE_TEST + help + The MediaTek GPUEB mailbox is used to communicate with the embedded + controller in charge of GPU frequency and power management on some + MediaTek SoCs, such as the MT8196. + Say Y or m here if you want to support the MT8196 SoC in your kernel + build. + config ZYNQMP_IPI_MBOX tristate "Xilinx ZynqMP IPI Mailbox" depends on ARCH_ZYNQMP && OF diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile index 98a68f838486eed117d24296138bf59fda3f92e4..564d06e71313e6d1972e4a6036e= 1e78c8c7ec450 100644 --- a/drivers/mailbox/Makefile +++ b/drivers/mailbox/Makefile @@ -63,6 +63,8 @@ obj-$(CONFIG_MTK_ADSP_MBOX) +=3D mtk-adsp-mailbox.o =20 obj-$(CONFIG_MTK_CMDQ_MBOX) +=3D mtk-cmdq-mailbox.o =20 +obj-$(CONFIG_MTK_GPUEB_MBOX) +=3D mtk-gpueb-mailbox.o + obj-$(CONFIG_ZYNQMP_IPI_MBOX) +=3D zynqmp-ipi-mailbox.o =20 obj-$(CONFIG_SUN6I_MSGBOX) +=3D sun6i-msgbox.o diff --git a/drivers/mailbox/mtk-gpueb-mailbox.c b/drivers/mailbox/mtk-gpue= b-mailbox.c new file mode 100644 index 0000000000000000000000000000000000000000..0236fb358136e434a09a21ef293= fe949ced94123 --- /dev/null +++ b/drivers/mailbox/mtk-gpueb-mailbox.c @@ -0,0 +1,330 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MediaTek GPUEB mailbox driver for SoCs such as the MT8196 + * + * Copyright (C) 2025, Collabora Ltd. + * + * Developers harmed in the making of this driver: + * - Nicolas Frattaroli + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MBOX_CTL_TX_STS 0x0000 +#define MBOX_CTL_IRQ_SET 0x0004 +#define MBOX_CTL_IRQ_CLR 0x0074 +#define MBOX_CTL_RX_STS 0x0078 + +#define MBOX_FULL BIT(0) /* i.e. we've received data */ +#define MBOX_CLOGGED BIT(1) /* i.e. the channel is shutdown */ + +struct mtk_gpueb_mbox { + struct device *dev; + struct clk *clk; + void __iomem *mbox_mmio; + void __iomem *mbox_ctl; + void **rx_buf; + atomic_t *rx_status; + struct mbox_controller mbox; + unsigned int *chn; + int irq; + const struct mtk_gpueb_mbox_variant *v; +}; + +struct mtk_gpueb_mbox_ch { + const char *name; + const int num; + const unsigned int tx_offset; + const unsigned int tx_len; + const unsigned int rx_offset; + const unsigned int rx_len; + const bool no_response; +}; + +struct mtk_gpueb_mbox_variant { + unsigned int num_channels; + const struct mtk_gpueb_mbox_ch channels[] __counted_by(num_channels); +}; + +/** + * mtk_gpueb_mbox_read_rx - read RX buffer from MMIO into ebm's RX buffer + * @ebm: pointer to &struct mtk_gpueb_mbox instance + * @channel: number of channel to read + */ +static void mtk_gpueb_mbox_read_rx(struct mtk_gpueb_mbox *ebm, + unsigned int channel) +{ + const struct mtk_gpueb_mbox_ch *ch; + + ch =3D &ebm->v->channels[channel]; + + memcpy_fromio(ebm->rx_buf[channel], ebm->mbox_mmio + ch->rx_offset, + ch->rx_len); + +} + +static irqreturn_t mtk_gpueb_mbox_isr(int irq, void *data) +{ + struct mtk_gpueb_mbox *ebm =3D data; + u32 rx_handled =3D 0; + u32 rx_sts; + int i; + + rx_sts =3D readl(ebm->mbox_ctl + MBOX_CTL_RX_STS); + + for (i =3D 0; i < ebm->v->num_channels; i++) { + if (rx_sts & BIT(i)) { + if (!atomic_cmpxchg(&ebm->rx_status[i], 0, + MBOX_FULL | MBOX_CLOGGED)) + rx_handled |=3D BIT(i); + } + } + + writel(rx_handled, ebm->mbox_ctl + MBOX_CTL_IRQ_CLR); + + if (!(rx_sts ^ rx_handled)) + return IRQ_WAKE_THREAD; + + dev_warn_ratelimited(ebm->dev, "spurious interrupts on 0x%04X\n", + rx_sts ^ rx_handled); + return IRQ_NONE; +} + +static irqreturn_t mtk_gpueb_mbox_thread(int irq, void *data) +{ + struct mtk_gpueb_mbox *ebm =3D data; + irqreturn_t ret =3D IRQ_NONE; + int status; + int i; + + for (i =3D 0; i < ebm->v->num_channels; i++) { + status =3D atomic_cmpxchg(&ebm->rx_status[i], + MBOX_FULL | MBOX_CLOGGED, MBOX_FULL); + if (status =3D=3D (MBOX_FULL | MBOX_CLOGGED)) { + mtk_gpueb_mbox_read_rx(ebm, i); + mbox_chan_received_data(&ebm->mbox.chans[i], + ebm->rx_buf[i]); + /* FIXME: When does MBOX_FULL get cleared? Here? */ + atomic_set(&ebm->rx_status[i], 0); + ret =3D IRQ_HANDLED; + } + } + + return ret; +} + +static int mtk_gpueb_mbox_send_data(struct mbox_chan *chan, void *data) +{ + struct mtk_gpueb_mbox *ebm =3D dev_get_drvdata(chan->mbox->dev); + unsigned int *num =3D chan->con_priv; + int i; + u32 *values =3D data; + + if (*num >=3D ebm->v->num_channels) + return -ECHRNG; + + if (!ebm->v->channels[*num].no_response && + atomic_read(&ebm->rx_status[*num])) + return -EBUSY; + + writel(BIT(*num), ebm->mbox_ctl + MBOX_CTL_IRQ_CLR); + + /* + * We don't want any fancy nonsense, just write the 32-bit values in + * order. memcpy_toio/__iowrite32_copy don't work here, because fancy. + */ + for (i =3D 0; i < ebm->v->channels[*num].tx_len; i +=3D 4) { + writel(values[i / 4], + ebm->mbox_mmio + ebm->v->channels[*num].tx_offset + i); + } + + writel(BIT(*num), ebm->mbox_ctl + MBOX_CTL_IRQ_SET); + + return 0; +} + +static int mtk_gpueb_mbox_startup(struct mbox_chan *chan) +{ + struct mtk_gpueb_mbox *ebm =3D dev_get_drvdata(chan->mbox->dev); + unsigned int *num =3D chan->con_priv; + + if (*num >=3D ebm->v->num_channels) + return -ECHRNG; + + atomic_set(&ebm->rx_status[*num], 0); + + return 0; +} + +static void mtk_gpueb_mbox_shutdown(struct mbox_chan *chan) +{ + struct mtk_gpueb_mbox *ebm =3D dev_get_drvdata(chan->mbox->dev); + unsigned int *num =3D chan->con_priv; + + atomic_set(&ebm->rx_status[*num], MBOX_CLOGGED); +} + +static bool mtk_gpueb_mbox_last_tx_done(struct mbox_chan *chan) +{ + struct mtk_gpueb_mbox *ebm =3D dev_get_drvdata(chan->mbox->dev); + unsigned int *num =3D chan->con_priv; + + return !(readl(ebm->mbox_ctl + MBOX_CTL_TX_STS) & BIT(*num)); +} + +const struct mbox_chan_ops mtk_gpueb_mbox_ops =3D { + .send_data =3D mtk_gpueb_mbox_send_data, + .startup =3D mtk_gpueb_mbox_startup, + .shutdown =3D mtk_gpueb_mbox_shutdown, + .last_tx_done =3D mtk_gpueb_mbox_last_tx_done, +}; + +static struct mbox_chan * +mtk_gpueb_mbox_of_xlate(struct mbox_controller *mbox, + const struct of_phandle_args *sp) +{ + struct mtk_gpueb_mbox *ebm =3D dev_get_drvdata(mbox->dev); + + if (!sp->args_count) + return ERR_PTR(-EINVAL); + + if (sp->args[0] >=3D ebm->v->num_channels) + return ERR_PTR(-ECHRNG); + + return &mbox->chans[sp->args[0]]; +} + +static int mtk_gpueb_mbox_probe(struct platform_device *pdev) +{ + struct mtk_gpueb_mbox *ebm; + unsigned int rx_buf_sz; + void *buf; + unsigned int i; + int ret; + + ebm =3D devm_kzalloc(&pdev->dev, sizeof(*ebm), GFP_KERNEL); + if (!ebm) + return -ENOMEM; + + ebm->dev =3D &pdev->dev; + ebm->v =3D of_device_get_match_data(ebm->dev); + + dev_set_drvdata(ebm->dev, ebm); + + ebm->clk =3D devm_clk_get_enabled(ebm->dev, NULL); + if (IS_ERR(ebm->clk)) + return dev_err_probe(ebm->dev, PTR_ERR(ebm->clk), + "Failed to get 'eb' clock\n"); + + ebm->mbox_mmio =3D devm_platform_ioremap_resource_byname(pdev, "mbox"); + if (IS_ERR(ebm->mbox_mmio)) + return dev_err_probe(ebm->dev, PTR_ERR(ebm->mbox_mmio), + "Couldn't map mailbox registers\n"); + + ebm->mbox_ctl =3D devm_platform_ioremap_resource_byname(pdev, "mbox_ctl"); + if (IS_ERR(ebm->mbox_ctl)) + return dev_err_probe( + ebm->dev, PTR_ERR(ebm->mbox_ctl), + "Couldn't map mailbox control registers\n"); + + rx_buf_sz =3D (ebm->v->channels[ebm->v->num_channels - 1].rx_offset + + ebm->v->channels[ebm->v->num_channels - 1].rx_len); + + buf =3D devm_kzalloc(ebm->dev, rx_buf_sz, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + ebm->rx_buf =3D devm_kmalloc_array(ebm->dev, ebm->v->num_channels, + sizeof(*ebm->rx_buf), GFP_KERNEL); + if (!ebm->rx_buf) + return -ENOMEM; + + ebm->mbox.chans =3D devm_kcalloc(ebm->dev, ebm->v->num_channels, + sizeof(struct mbox_chan), GFP_KERNEL); + if (!ebm->mbox.chans) + return -ENOMEM; + + ebm->rx_status =3D devm_kcalloc(ebm->dev, ebm->v->num_channels, + sizeof(atomic_t), GFP_KERNEL); + if (!ebm->rx_status) + return -ENOMEM; + + ebm->chn =3D devm_kcalloc(ebm->dev, ebm->v->num_channels, + sizeof(*ebm->chn), GFP_KERNEL); + + for (i =3D 0; i < ebm->v->num_channels; i++) { + ebm->rx_buf[i] =3D buf + ebm->v->channels[i].rx_offset; + spin_lock_init(&ebm->mbox.chans[i].lock); + /* the things you do to avoid explicit casting void* */ + ebm->chn[i] =3D i; + ebm->mbox.chans[i].con_priv =3D &ebm->chn[i]; + atomic_set(&ebm->rx_status[i], MBOX_CLOGGED); + } + + ebm->mbox.dev =3D ebm->dev; + ebm->mbox.num_chans =3D ebm->v->num_channels; + ebm->mbox.txdone_poll =3D true; + ebm->mbox.txpoll_period =3D 0; /* minimum hrtimer interval */ + ebm->mbox.of_xlate =3D mtk_gpueb_mbox_of_xlate; + ebm->mbox.ops =3D &mtk_gpueb_mbox_ops; + + ebm->irq =3D platform_get_irq(pdev, 0); + if (ebm->irq < 0) + return ebm->irq; + + ret =3D devm_request_threaded_irq(ebm->dev, ebm->irq, mtk_gpueb_mbox_isr, + mtk_gpueb_mbox_thread, 0, NULL, ebm); + if (ret) + return dev_err_probe(ebm->dev, ret, "failed to request IRQ\n"); + + ret =3D devm_mbox_controller_register(ebm->dev, &ebm->mbox); + + return 0; +} + +static const struct mtk_gpueb_mbox_variant mtk_gpueb_mbox_mt8196 =3D { + .num_channels =3D 12, + .channels =3D { + { "fast_dvfs_event", 0, 0x0000, 16, 0x00e0, 16, false }, + { "gpufreq", 1, 0x0010, 32, 0x00f0, 32, false }, + { "sleep", 2, 0x0030, 12, 0x0110, 4, true }, + { "timer", 3, 0x003c, 24, 0x0114, 4, false }, + { "fhctl", 4, 0x0054, 36, 0x0118, 4, false }, + { "ccf", 5, 0x0078, 16, 0x011c, 16, false }, + { "gpumpu", 6, 0x0088, 24, 0x012c, 4, false }, + { "fast_dvfs", 7, 0x00a0, 24, 0x0130, 24, false }, + { "ipir_c_met", 8, 0x00b8, 4, 0x0148, 16, false }, + { "ipis_c_met", 9, 0x00bc, 16, 0x0158, 4, false }, + { "brisket", 10, 0x00cc, 16, 0x015c, 16, false }, + { "ppb", 11, 0x00dc, 4, 0x016c, 4, false }, + }, +}; + +static const struct of_device_id mtk_gpueb_mbox_of_ids[] =3D { + { .compatible =3D "mediatek,mt8196-gpueb-mbox", + .data =3D &mtk_gpueb_mbox_mt8196 }, + { /* Sentinel */ } +}; +MODULE_DEVICE_TABLE(of, mtk_gpueb_mbox_of_ids); + +static struct platform_driver mtk_gpueb_mbox_drv =3D { + .probe =3D mtk_gpueb_mbox_probe, + .driver =3D { + .name =3D "mtk-gpueb-mbox", + .of_match_table =3D mtk_gpueb_mbox_of_ids, + } +}; +module_platform_driver(mtk_gpueb_mbox_drv); + +MODULE_AUTHOR("Nicolas Frattaroli "); +MODULE_DESCRIPTION("MediaTek GPUEB mailbox driver for SoCs such as the MT8= 196"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33E02D6614; Fri, 5 Sep 2025 10:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067879; cv=pass; b=kAmboY3hAK9PrPxprVgVlcZUmoaTRQQK7TJV+HvPgq/ctuvX/KYjEJEhP65CC0G483T6UlUDKl5H7xwpNWHSOK+Raqd1c60J2yezSJP+1crr4b829mmWo9wjByONPl5ZW30EgtnlRkh2ssD3pMnv301COXX9skneIVqgdZrCLGM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067879; c=relaxed/simple; bh=ejou8j85PmfqjaXKSjWhHMcjEKjgQeu+8UIflZfp8AQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qplFv57soT9iiPYAAkCrLTtfbLF1ZVRRZD8SJap0v+91amGk2tWo3aHw5bfKkJT9/RaXK1JlzOwKAZ9OA1G0B3c7pchFECCb40J1cegnWp2vTOzzr0pN3Gnih7HScV+gozH60VY+jh7RZ+TYRoRTM4omg7hcTj/YKLwLpoSbckQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=b76m1jMe; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="b76m1jMe" ARC-Seal: i=1; a=rsa-sha256; t=1757067852; cv=none; d=zohomail.com; s=zohoarc; b=NsCN2dNjXkpXNDDF6w0VZDotiaFsDeMCtXDFWK3IXSpBPFtniAxCoEV9v1lh7wnO98xbvo7H+MIvBXIxpYTrWj8fgFC5+jc1LfcEhmrPf+Fk83OHoyOuDwOcsYOhS0VKX4OMRCjJyU3oH1pCJE+0ajdyzDjwNfVKSa2k8gj+pmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067852; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZAwFNwjGiMMwCVOuclOW4l6UkejjeuefZl6ajRtFEGM=; b=UlXxRyJ3c3JkLQ/yGohrgpO50oAVFkyhV8pgikFANJKJd0gcdPcOUAOdFRrBxcOwOa9S2cBIVk9a86SbM1LWH/lS+NolxH3Fu2wwtZ0fs4PkAjz3VKCkhw5nAXslevrFcJNAN4Wcx3IPHdOzg3qcQWukb/ozLapp6zsMcpgUTfM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067852; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=ZAwFNwjGiMMwCVOuclOW4l6UkejjeuefZl6ajRtFEGM=; b=b76m1jMeghc0hx1nVU4nNMuBDmhvGZyTh4N7YS/G5pRbaMrw4Sfy7lhk0y24zq+N uNY+47AqkJJKBbx9shUuzBOpkp88iklWw8CNeBHje8M7loLmCMamjeoQC1RjcZMgAuh jPbSgIcaDXUFUTCptjb+VGe9op+M8uB+dnS8fDKQ= Received: by mx.zohomail.com with SMTPS id 1757067851155411.5142900473684; Fri, 5 Sep 2025 03:24:11 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:02 +0200 Subject: [PATCH RFC 06/10] drm/panthor: call into devfreq for current frequency Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-6-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 As it stands, panthor keeps a cached current frequency value for when it wants to retrieve it. This doesn't work well for when things might switch frequency without panthor's knowledge. Instead, implement the get_cur_freq operation, and expose it through a helper function to the rest of panthor. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_devfreq.c | 33 +++++++++++++++++++++++++++= ---- drivers/gpu/drm/panthor/panthor_devfreq.h | 2 ++ drivers/gpu/drm/panthor/panthor_device.h | 3 --- drivers/gpu/drm/panthor/panthor_drv.c | 4 +++- 4 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/pa= nthor/panthor_devfreq.c index 3686515d368db5bb329f4858d4a7247a4957cc24..8903f60c0a3f06313ac2008791c= 210ff32b6bd52 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -62,7 +62,6 @@ static void panthor_devfreq_update_utilization(struct pan= thor_devfreq *pdevfreq) static int panthor_devfreq_target(struct device *dev, unsigned long *freq, u32 flags) { - struct panthor_device *ptdev =3D dev_get_drvdata(dev); struct dev_pm_opp *opp; int err; =20 @@ -72,8 +71,6 @@ static int panthor_devfreq_target(struct device *dev, uns= igned long *freq, dev_pm_opp_put(opp); =20 err =3D dev_pm_opp_set_rate(dev, *freq); - if (!err) - ptdev->current_frequency =3D *freq; =20 return err; } @@ -115,11 +112,21 @@ static int panthor_devfreq_get_dev_status(struct devi= ce *dev, return 0; } =20 +static int panthor_devfreq_get_cur_freq(struct device *dev, unsigned long = *freq) +{ + struct panthor_device *ptdev =3D dev_get_drvdata(dev); + + *freq =3D clk_get_rate(ptdev->clks.core); + + return 0; +} + static struct devfreq_dev_profile panthor_devfreq_profile =3D { .timer =3D DEVFREQ_TIMER_DELAYED, .polling_ms =3D 50, /* ~3 frames */ .target =3D panthor_devfreq_target, .get_dev_status =3D panthor_devfreq_get_dev_status, + .get_cur_freq =3D panthor_devfreq_get_cur_freq, }; =20 int panthor_devfreq_init(struct panthor_device *ptdev) @@ -198,7 +205,6 @@ int panthor_devfreq_init(struct panthor_device *ptdev) return PTR_ERR(opp); =20 panthor_devfreq_profile.initial_freq =3D cur_freq; - ptdev->current_frequency =3D cur_freq; =20 /* * Set the recommend OPP this will enable and configure the regulator @@ -296,3 +302,22 @@ void panthor_devfreq_record_idle(struct panthor_device= *ptdev) =20 spin_unlock_irqrestore(&pdevfreq->lock, irqflags); } + +unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev) +{ + struct panthor_devfreq *pdevfreq =3D ptdev->devfreq; + unsigned long freq =3D 0; + int ret; + + if (!pdevfreq || !pdevfreq->devfreq) + return 0; + + if (pdevfreq->devfreq->profile->get_cur_freq) { + ret =3D pdevfreq->devfreq->profile->get_cur_freq(ptdev->base.dev, + &freq); + if (ret) + return 0; + } + + return freq; +} diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.h b/drivers/gpu/drm/pa= nthor/panthor_devfreq.h index b7631de695f7d79456478c87e8af5dc47673cd1d..f8e29e02f66cb3281ed4bb4c75c= da9bd4df82b92 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.h +++ b/drivers/gpu/drm/panthor/panthor_devfreq.h @@ -18,4 +18,6 @@ void panthor_devfreq_suspend(struct panthor_device *ptdev= ); void panthor_devfreq_record_busy(struct panthor_device *ptdev); void panthor_devfreq_record_idle(struct panthor_device *ptdev); =20 +unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev); + #endif /* __PANTHOR_DEVFREQ_H__ */ diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index 4fc7cf2aeed577f623aac73ed287d6327645ecaa..a14239c8f9ca9229d8d6d36d327= e6fd6d05f8f2f 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -200,9 +200,6 @@ struct panthor_device { /** @profile_mask: User-set profiling flags for job accounting. */ u32 profile_mask; =20 - /** @current_frequency: Device clock frequency at present. Set by DVFS*/ - unsigned long current_frequency; - /** @fast_rate: Maximum device clock frequency. Set by DVFS */ unsigned long fast_rate; =20 diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 4c202fc5ce0504e3f08bf6c8f18a314890eb88ec..c85a16e1339eaa164a8719ffecf= 5214cafff1a55 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -25,6 +25,7 @@ #include #include =20 +#include "panthor_devfreq.h" #include "panthor_device.h" #include "panthor_fw.h" #include "panthor_gem.h" @@ -1519,7 +1520,8 @@ static void panthor_gpu_show_fdinfo(struct panthor_de= vice *ptdev, drm_printf(p, "drm-cycles-panthor:\t%llu\n", pfile->stats.cycles); =20 drm_printf(p, "drm-maxfreq-panthor:\t%lu Hz\n", ptdev->fast_rate); - drm_printf(p, "drm-curfreq-panthor:\t%lu Hz\n", ptdev->current_frequency); + drm_printf(p, "drm-curfreq-panthor:\t%lu Hz\n", + panthor_devfreq_get_freq(ptdev)); } =20 static void panthor_show_internal_memory_stats(struct drm_printer *p, stru= ct drm_file *file) --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034E92D6614; Fri, 5 Sep 2025 10:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067885; cv=pass; b=AZlVFRAo38pUPZRYL8CElMKEUWX9MC2nmf6gysqcAwmQyhNmPalCxntYOLRMK3vg/5tr5dHRCnMTQ5jHd9W/Yc1AUrchmCFgV7b++jhMM09H63LUz9BJvW2E44n9GdGBJI3Qdf5FhVZKZ5qknBW9iS+XwTNOaITK2EWa4p55zCE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067885; c=relaxed/simple; bh=n/XCY+jp5CHf9FhKJnqnlzue4BxaCtQHC1aGYOWC8w0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HevYY3eDmGyBIjg5wbXbLZelP3y1GvPzjM16Ap0LzYdN9OU1G0pzlQPN6HY2vNrvVtodJhKljiEYEzr+18z64KLBSQ4jYG9oWuVTsXsEFMDg5mivXCMv1hY65hFc2DYlsmZYmFH1KYjb0W9NFGUSJPgjdYwF0suLro1trNJDgY4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=RjC3CKaP; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="RjC3CKaP" ARC-Seal: i=1; a=rsa-sha256; t=1757067858; cv=none; d=zohomail.com; s=zohoarc; b=RsEmwD+23vus47pMNdpM7ANm0OHaXMbNM/+tJtTJ7JAELUmo8I/fWsfTVOgCxs2/fJNo9migABsh8TIp6QrAazc5M8ZLVTIJm5QpGcaoP8o1kkxZUL+DjWKaOjpEaOagd+WvO5w0sRVG7RG7LLWpIWNF6I7yVNqYBwjgNXNFjF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067858; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=FtFHp6BLwfa/TieGzbv7DaPGlt+ZTOt4EO8QRQvtQg4=; b=Sdqe3oAhz9tskXval+xaZwJUgDboOpDhDvqMwEV6x5LDUL0t8RDPQImClF4RYbAj/WkOazojVJYXJim5vzkbykdqngU80e8FkwyML6VLWHYAYUmQeECi93Q37qLlv2evtgKosJe/+AFsE32g3R4VA3F5wHv8rbV8Kbcbn3iPGK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067858; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=FtFHp6BLwfa/TieGzbv7DaPGlt+ZTOt4EO8QRQvtQg4=; b=RjC3CKaPmmlM2kdgZNuyQvKTAoJJVnhI79DLjUgu7oE87vlA054WVtZ7QqRdcJwa uWHMhE299+xNMfMkjEzaOygEQf0mjga9jWaGsHudEIDP3C/pdSi/ajgl5xQ+71Xdugl /hgaOoCrswsduuP6Vje07GYg4zbxQfls8R0XcViQ= Received: by mx.zohomail.com with SMTPS id 1757067856839498.1092107368131; Fri, 5 Sep 2025 03:24:16 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:03 +0200 Subject: [PATCH RFC 07/10] drm/panthor: move panthor_devfreq struct to header Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-7-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 In order to make files other than panthor_devfreq.c be able to touch the members of a panthor_devfreq instance, it needs to live somewhere other than the .c file. Move it into the panthor_devfreq.h header, so that the upcoming MediaTek MFG devfreq can use it as well. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_devfreq.c | 32 --------------------------- drivers/gpu/drm/panthor/panthor_devfreq.h | 36 +++++++++++++++++++++++++++= +++- 2 files changed, 35 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/pa= nthor/panthor_devfreq.c index 8903f60c0a3f06313ac2008791c210ff32b6bd52..02eb3ca15d1874e1cbafc6b614b= 196c5cc75b6a1 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -12,38 +12,6 @@ #include "panthor_devfreq.h" #include "panthor_device.h" =20 -/** - * struct panthor_devfreq - Device frequency management - */ -struct panthor_devfreq { - /** @devfreq: devfreq device. */ - struct devfreq *devfreq; - - /** @gov_data: Governor data. */ - struct devfreq_simple_ondemand_data gov_data; - - /** @busy_time: Busy time. */ - ktime_t busy_time; - - /** @idle_time: Idle time. */ - ktime_t idle_time; - - /** @time_last_update: Last update time. */ - ktime_t time_last_update; - - /** @last_busy_state: True if the GPU was busy last time we updated the s= tate. */ - bool last_busy_state; - - /** - * @lock: Lock used to protect busy_time, idle_time, time_last_update and - * last_busy_state. - * - * These fields can be accessed concurrently by panthor_devfreq_get_dev_s= tatus() - * and panthor_devfreq_record_{busy,idle}(). - */ - spinlock_t lock; -}; - static void panthor_devfreq_update_utilization(struct panthor_devfreq *pde= vfreq) { ktime_t now, last; diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.h b/drivers/gpu/drm/pa= nthor/panthor_devfreq.h index f8e29e02f66cb3281ed4bb4c75cda9bd4df82b92..e8b5ccddd45c52ee3215e9c84c6= ebd9109640282 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.h +++ b/drivers/gpu/drm/panthor/panthor_devfreq.h @@ -4,11 +4,45 @@ #ifndef __PANTHOR_DEVFREQ_H__ #define __PANTHOR_DEVFREQ_H__ =20 +#include + struct devfreq; struct thermal_cooling_device; =20 struct panthor_device; -struct panthor_devfreq; + +/** + * struct panthor_devfreq - Device frequency management + */ +struct panthor_devfreq { + /** @devfreq: devfreq device. */ + struct devfreq *devfreq; + + /** @gov_data: Governor data. */ + struct devfreq_simple_ondemand_data gov_data; + + /** @busy_time: Busy time. */ + ktime_t busy_time; + + /** @idle_time: Idle time. */ + ktime_t idle_time; + + /** @time_last_update: Last update time. */ + ktime_t time_last_update; + + /** @last_busy_state: True if the GPU was busy last time we updated the s= tate. */ + bool last_busy_state; + + /** + * @lock: Lock used to protect busy_time, idle_time, time_last_update and + * last_busy_state. + * + * These fields can be accessed concurrently by panthor_devfreq_get_dev_s= tatus() + * and panthor_devfreq_record_{busy,idle}(). + */ + spinlock_t lock; +}; + =20 int panthor_devfreq_init(struct panthor_device *ptdev); =20 --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB850301009; Fri, 5 Sep 2025 10:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067889; cv=pass; b=k1PJ6adyxWK2XGuaWWNMpmZib18zBApCYzURF6HsLd1qeHSswQO29oOSQLVsuCBi/mptUGbOWmkyI9uvV3IXaWSXOkTBHU6dBwsez5iHMlyv5AHwi9ATkDnf2aEt/CsD2LXlrc/FiodJfgrL+3NslXm9EkWqDaenBpoe4jhrmXU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067889; c=relaxed/simple; bh=3NtQ2mX4QCrkZRpM2GRitWLjN5/5S5c0Gq0f7a8UCZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b9wnH8QLZNzDauQ2J32+CpDo8OgJffRuwYfrGvgesXKW4UzgiMJbKG6afMQtsuPs5sbvM61otpu2kqtk1dSxj3fDoBnQE6ph8r/im1R8nd7kNmgWhKGN1qISK+133YXkCta3NXD2tl4T7R9evOjkWzg+9uSZLa/E4zAUVAN8Sq8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=UnSWHfAm; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="UnSWHfAm" ARC-Seal: i=1; a=rsa-sha256; t=1757067864; cv=none; d=zohomail.com; s=zohoarc; b=SuKZyoAwUWFKn7sciDyOB8jFC5iUsDPyz1FIZCDW3txy+Etu6VXei2UlYaf2xP1b6iuMFawC5kuQWb6qkPckdr9nrd2vmO6yJXzhMturuRJHITt63B4b0ZXEUrCCPTaHjApx+p6kBfkI+/hahTQtaLMYZYMiQ8wLN0Yo6FrYBG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067864; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=tD2U/HmgJxBzAQZ2WANquFxFh0SXL7yoKMcGAmneX0U=; b=iIh7mWHrKVxtfKn+7B3Yue8FW+oUjHDd2rhTSpgKc9wNA8j6/ahUKmdP4PeIxPmc0ZVvopxUaW3W2kuTvFSLJAqOIhGf/KtKiGOsEBn1OG94Mkq5zHzDrKKoTZOZFcRrAkYIlBVXp86H6dG8S1j/LU35liFx1xj9ekpJSiDB7Ng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067864; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=tD2U/HmgJxBzAQZ2WANquFxFh0SXL7yoKMcGAmneX0U=; b=UnSWHfAmPsF5kEJY2MbGAr+48Enh3MREpqtahzmiVGlxRHsL1q71jyFIHj2t5SDU YjkD/8HLaSCydf0d8i/Kz3zm0tZJZQJw53W8m9DUJ1+pGq54XJmIPwoBf4RgjcfQcwa lO3WXHv0FHzftQMGyraThzfVbusLsREmhbmlX5NY= Received: by mx.zohomail.com with SMTPS id 1757067862443543.6422329389278; Fri, 5 Sep 2025 03:24:22 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:04 +0200 Subject: [PATCH RFC 08/10] drm/panthor: devfreq: expose get_dev_status and make it more generic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-8-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 The only device-specific part of panthor's get_dev_status devfreq callback is getting the clock frequency. All the other logic surrounding what it does may be useful for other devfreq implementations however. Expose it in the panthor_devfreq.h header file, and make it call back into get_cur_freq instead of poking the common clock framework directly. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_devfreq.c | 29 +++++++++++++++++----------= -- drivers/gpu/drm/panthor/panthor_devfreq.h | 3 +++ 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/pa= nthor/panthor_devfreq.c index 02eb3ca15d1874e1cbafc6b614b196c5cc75b6a1..d495dd856299826c4bddc205087= d8914d01d7fc4 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -43,6 +43,15 @@ static int panthor_devfreq_target(struct device *dev, un= signed long *freq, return err; } =20 +static int panthor_devfreq_get_cur_freq(struct device *dev, unsigned long = *freq) +{ + struct panthor_device *ptdev =3D dev_get_drvdata(dev); + + *freq =3D clk_get_rate(ptdev->clks.core); + + return 0; +} + static void panthor_devfreq_reset(struct panthor_devfreq *pdevfreq) { pdevfreq->busy_time =3D 0; @@ -50,14 +59,18 @@ static void panthor_devfreq_reset(struct panthor_devfre= q *pdevfreq) pdevfreq->time_last_update =3D ktime_get(); } =20 -static int panthor_devfreq_get_dev_status(struct device *dev, - struct devfreq_dev_status *status) +int panthor_devfreq_get_dev_status(struct device *dev, + struct devfreq_dev_status *status) { struct panthor_device *ptdev =3D dev_get_drvdata(dev); struct panthor_devfreq *pdevfreq =3D ptdev->devfreq; + struct devfreq_dev_profile *p =3D pdevfreq->devfreq->profile; unsigned long irqflags; + int ret; =20 - status->current_frequency =3D clk_get_rate(ptdev->clks.core); + ret =3D p->get_cur_freq(dev, &status->current_frequency); + if (ret) + return ret; =20 spin_lock_irqsave(&pdevfreq->lock, irqflags); =20 @@ -79,15 +92,7 @@ static int panthor_devfreq_get_dev_status(struct device = *dev, =20 return 0; } - -static int panthor_devfreq_get_cur_freq(struct device *dev, unsigned long = *freq) -{ - struct panthor_device *ptdev =3D dev_get_drvdata(dev); - - *freq =3D clk_get_rate(ptdev->clks.core); - - return 0; -} +EXPORT_SYMBOL(panthor_devfreq_get_dev_status); =20 static struct devfreq_dev_profile panthor_devfreq_profile =3D { .timer =3D DEVFREQ_TIMER_DELAYED, diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.h b/drivers/gpu/drm/pa= nthor/panthor_devfreq.h index e8b5ccddd45c52ee3215e9c84c6ebd9109640282..a891cb5fdc34636444f141e10f5= d45828fc35b51 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.h +++ b/drivers/gpu/drm/panthor/panthor_devfreq.h @@ -52,6 +52,9 @@ void panthor_devfreq_suspend(struct panthor_device *ptdev= ); void panthor_devfreq_record_busy(struct panthor_device *ptdev); void panthor_devfreq_record_idle(struct panthor_device *ptdev); =20 +int panthor_devfreq_get_dev_status(struct device *dev, + struct devfreq_dev_status *status); + unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev); =20 #endif /* __PANTHOR_DEVFREQ_H__ */ --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDEA92DF712; Fri, 5 Sep 2025 10:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067895; cv=pass; b=uXIAoLdvtnm5Qja9tWIOMY1WE3PCnsYIQs1Ni5I+8tAVn4igbRwSAMczEZygn35COvOqu55CfG41LMMcwRy0wTT2WLDviWcYu+fIG65EIuQWkggf/XyIeELkiW1ayCISRB2gqbldTxUXePMQ0ynLrADSD6VX3nvJov78KfJp68I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067895; c=relaxed/simple; bh=Fq1f6lzd+1IG9LLJlRe8vPIe5S775FvALUuZ0HhKmKY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KlKOOTK2PGU/Um0/PG4tvMDhDr0q7rR+kLK58ZxhyW5k4ncDMWIuOM+r7kvjRp1ZCk3+eG5L/CMruLbOR2ZU6+5Uv21VxCXpm6V0MYBekMXfxt7eFV5J4b9CpBXFgnGnmjVH2nWfpGS9snBf08OEtZvlFrfi4QXUig+kFdXNKVA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=clVEnI9j; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="clVEnI9j" ARC-Seal: i=1; a=rsa-sha256; t=1757067868; cv=none; d=zohomail.com; s=zohoarc; b=L4EPZidN+OdnJX59KwXFztNlAoo2Zv6EB9UwfwXFrIP7QWQ2NVx7hZ5dALXX4axIEelf+J4bNFVjG2cnW8EwEGtV5hf+GuF9ME3TguNeiHXsY8ONeRGcnzHDshfVg4Qxe7eS5/wwbHuqs3iHPtfh0qQ80yWWTYFuFJVYfv5ZSOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067868; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=BgcAwBs9k0Tva6LWKXeX4UCp/51+JkoYADUR446m4EA=; b=eyBSv5Tg5Mdnl7+mhbBZaG8N+3yQ36IxdWWwZRF/kWXg6F+PzCLmiLhE9FiO0rF2h5GF/L5Y06Wqp5vxnmP646ha44FhUjTln02YWJrnnkvwbmM+Ip8ZocD64FD135r8+Kh0Gl0sZtospkLFbcBNYcu05QUlhMyqsHpKa2OwVK4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067868; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=BgcAwBs9k0Tva6LWKXeX4UCp/51+JkoYADUR446m4EA=; b=clVEnI9jKVRfUoVuADf20X59xEZcoOU9i0kBY2vC0PhuzrTiKkH08qLOhhMMihac PAhk0O/X9oP4FGNQ3MsC+D2nvLuulV7RDbj57V2Vs5uUAhsO8rKlphGSXjCHRgdPX/2 treq9HdTYn+jztxCatpObAkfPyQiSYDfvmFJSpwc= Received: by mx.zohomail.com with SMTPS id 1757067868062527.7136886020036; Fri, 5 Sep 2025 03:24:28 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:05 +0200 Subject: [PATCH RFC 09/10] drm/panthor: devfreq: add pluggable devfreq providers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-9-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 On some devices, devfreq is not controlled directly by DT OPPs and the common clock framework, but through an external devfreq driver. To permit this type of usage, add the concept of devfreq providers. Devfreq providers for panthor register themselves with panthor as a provider. panthor then gets whatever driver is suckling on its performance-node property, finds the registered devfreq provider init function for it, and calls it. Should the probe order work out such that panthor probes before the devfreq provider is finished probing and registering itself, then we just defer the probe after adding a device link. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_devfreq.c | 74 +++++++++++++++++++++++++++= +++- drivers/gpu/drm/panthor/panthor_devfreq.h | 16 +++++++ 2 files changed, 89 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/pa= nthor/panthor_devfreq.c index d495dd856299826c4bddc205087d8914d01d7fc4..1b0c21f6f069b059b8b0e412a79= 556c602c5f1e7 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include =20 @@ -12,6 +13,34 @@ #include "panthor_devfreq.h" #include "panthor_device.h" =20 +static LIST_HEAD(panthor_devfreq_providers); +static DEFINE_MUTEX(panthor_devfreq_providers_lock); + +int panthor_devfreq_register_provider(struct panthor_devfreq_provider *pro= v) +{ + guard(mutex)(&panthor_devfreq_providers_lock); + + list_add(&prov->node, &panthor_devfreq_providers); + + return 0; +} +EXPORT_SYMBOL(panthor_devfreq_register_provider); + +static int panthor_devfreq_init_provider(struct panthor_device *ptdev, + struct device *provider_dev) +{ + struct panthor_devfreq_provider *prov; + + guard(mutex)(&panthor_devfreq_providers_lock); + + list_for_each_entry(prov, &panthor_devfreq_providers, node) { + if (prov->dev =3D=3D provider_dev) + return prov->init(ptdev, provider_dev); + } + + return -EPROBE_DEFER; +} + static void panthor_devfreq_update_utilization(struct panthor_devfreq *pde= vfreq) { ktime_t now, last; @@ -102,7 +131,7 @@ static struct devfreq_dev_profile panthor_devfreq_profi= le =3D { .get_cur_freq =3D panthor_devfreq_get_cur_freq, }; =20 -int panthor_devfreq_init(struct panthor_device *ptdev) +static int panthor_devfreq_init_of(struct panthor_device *ptdev) { /* There's actually 2 regulators (mali and sram), but the OPP core only * supports one. @@ -222,6 +251,49 @@ int panthor_devfreq_init(struct panthor_device *ptdev) return 0; } =20 +static int panthor_devfreq_init_platform(struct panthor_device *ptdev) +{ + struct device_node *pcnode; + struct platform_device *pdev; + struct device_link *link; + int ret; + + pcnode =3D of_parse_phandle(ptdev->base.dev->of_node, + "performance-controller", 0); + if (!pcnode) + return -EINVAL; + + pdev =3D of_find_device_by_node(pcnode); + of_node_put(pcnode); + if (!pdev) + return -ENODEV; + + link =3D device_link_add(ptdev->base.dev, &pdev->dev, + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS); + if (!link) { + dev_err(ptdev->base.dev, "failed to add device link\n"); + return -ENODEV; + } + + ret =3D panthor_devfreq_init_provider(ptdev, &pdev->dev); + if (ret) + return dev_err_probe(ptdev->base.dev, ret, + "failed to initialize devfreq provider\n"); + + DRM_DEV_INFO(ptdev->base.dev, "initialized devfreq provider %s\n", + dev_name(&pdev->dev)); + + return 0; +} + +int panthor_devfreq_init(struct panthor_device *ptdev) +{ + if (!of_property_present(ptdev->base.dev->of_node, "performance-controlle= r")) + return panthor_devfreq_init_of(ptdev); + + return panthor_devfreq_init_platform(ptdev); +} + void panthor_devfreq_resume(struct panthor_device *ptdev) { struct panthor_devfreq *pdevfreq =3D ptdev->devfreq; diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.h b/drivers/gpu/drm/pa= nthor/panthor_devfreq.h index a891cb5fdc34636444f141e10f5d45828fc35b51..94c9768d5d038c4ba8516929edb= 565a1f13443fb 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.h +++ b/drivers/gpu/drm/panthor/panthor_devfreq.h @@ -8,6 +8,7 @@ =20 struct devfreq; struct thermal_cooling_device; +struct platform_device; =20 struct panthor_device; =20 @@ -43,6 +44,19 @@ struct panthor_devfreq { spinlock_t lock; }; =20 +struct panthor_devfreq_provider { + /** @dev: device pointer to the provider device */ + struct device *dev; + /** + * @init: the provider's init callback that allocates a + * &struct panthor_devfreq, adds it to panthor, and adds a devfreq + * device to panthor. Will be called during panthor's probe. + */ + int (*init)(struct panthor_device *ptdev, struct device *dev); + + struct list_head node; +}; + =20 int panthor_devfreq_init(struct panthor_device *ptdev); =20 @@ -57,4 +71,6 @@ int panthor_devfreq_get_dev_status(struct device *dev, =20 unsigned long panthor_devfreq_get_freq(struct panthor_device *ptdev); =20 +int panthor_devfreq_register_provider(struct panthor_devfreq_provider *pro= v); + #endif /* __PANTHOR_DEVFREQ_H__ */ --=20 2.51.0 From nobody Tue Sep 9 21:36:17 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90422D63F9; Fri, 5 Sep 2025 10:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067906; cv=pass; b=TAx2PTNh4Fw3PJ5sszGXBykO2n2xJQ59jcvu41Z712BKgQcK5PYayTziAgXwcH3VCcq5PvBLcV2jrQz/stpyKaAcYt6XHx4yaNpdFjRsCNxxnDhSquk+v/o4lqL93oPgJa9tiUkRaIr91hG68KSDgNufnrK7zyQ5UlvSgKKWZG4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757067906; c=relaxed/simple; bh=LOie7xlQJ0scqzXgsdNFHHg0hfBLjYGaNAilgHEsTjE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qKuLxsCwzv87C74yPHcFyq+aCuab9+XnMqsRpuKQfGlcNtg7yZCPyYIZGee64RuMGi1c6D91HdVqWrTMR3W+x9xqxRjD0gOHp+c5HnqOKvDz6T2PxRzx/oYLSl6Jfxt7Y3F0Rh/5xS2wTQ/0MarYqqDhqqnpCUwzzE/MTUnsdr4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=WBRVZcAs; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="WBRVZcAs" ARC-Seal: i=1; a=rsa-sha256; t=1757067875; cv=none; d=zohomail.com; s=zohoarc; b=MAsKo4LeVHFOB/g56olOP/qphebtN2nXyKTUzRmitCHhypINYgjabDTo5qdUETgJhk8LlkSKtQnVMZx66jWF4CVC4Dj1c4Vth2ShtnfGg/3zeA9gVvGO/jOpbduvI7nmQXrwuYUGFSgs9mUzzkvBxWEUdosIT6MTpXmA7Ikrgqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757067875; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=t68GoJOEGUEUjdRNIFT8AZyowHk5MgMEkLYw/UUNqc8=; b=PjRTicYmTIhRvLtkVIOKSmSfXz7mUhNuwGyNYj7UleEwxbwTlNeHMZ1CgejiYJPdI+yzB8BCTFXadT1Zq5EzdU4ueFwU+9x9JoYLs4UMetwCKbPlvJFUZ2ezEPOjyrTejKwJVwrWQ9v3DZW2xMCwg3opEGR/rlKEEVYACagKCow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757067874; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=t68GoJOEGUEUjdRNIFT8AZyowHk5MgMEkLYw/UUNqc8=; b=WBRVZcAswgXyyYK8wK02p4CGwE5nbd2WSG9zWpw1DtS0Es5KTqLMkqPpOFofpmWh s86cJwG+kPisREbQgbBeXU9qRwCQmVIMD3vQncf2o6HrQpyu7Y7byK9qOo52sNtDJdH lso2KM1U60YpZ7DX7/7+/IPnG2FfAOiBNjwuNlhE= Received: by mx.zohomail.com with SMTPS id 1757067873891378.59619255531265; Fri, 5 Sep 2025 03:24:33 -0700 (PDT) From: Nicolas Frattaroli Date: Fri, 05 Sep 2025 12:23:06 +0200 Subject: [PATCH RFC 10/10] drm/panthor: add support for MediaTek MFlexGraphics Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250905-mt8196-gpufreq-v1-10-7b6c2d6be221@collabora.com> References: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> In-Reply-To: <20250905-mt8196-gpufreq-v1-0-7b6c2d6be221@collabora.com> To: AngeloGioacchino Del Regno , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jassi Brar , Kees Cook , "Gustavo A. R. Silva" Cc: Chia-I Wu , Chen-Yu Tsai , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.2 MediaTek uses some glue logic to control frequency and power on some of their GPUs. This is best exposed as a devfreq driver, as it saves us from having to hardcode OPPs into the device tree, and can be extended with additional devfreq-y logic like more clever governors that use the hardware's GPUEB MCU to set frame time targets and power limits. Add this driver to the panthor subdirectory. It needs to live here as it needs to call into panthor's devfreq layer, and panthor for its part also needs to call into this driver during probe to get a devfreq device registered. Solving the cyclical dependency by having mediatek_mfg live without knowledge of what a panthor is would require moving the devfreq provider stuff into a generic devfreq subsystem solution, which I didn't want to do. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/Kconfig | 13 + drivers/gpu/drm/panthor/Makefile | 2 + drivers/gpu/drm/panthor/mediatek_mfg.c | 1053 ++++++++++++++++++++++++++++= ++++ 3 files changed, 1068 insertions(+) diff --git a/drivers/gpu/drm/panthor/Kconfig b/drivers/gpu/drm/panthor/Kcon= fig index 55b40ad07f3b0779e0c434469ddc874ff74fde27..c4d2599c05df9e0e009b8e99b3d= 29c220269ca0d 100644 --- a/drivers/gpu/drm/panthor/Kconfig +++ b/drivers/gpu/drm/panthor/Kconfig @@ -21,3 +21,16 @@ config DRM_PANTHOR =20 Note that the Mali-G68 and Mali-G78, while Valhall architecture, will be supported with the panfrost driver as they are not CSF GPUs. + +config DRM_PANTHOR_MEDIATEK_MFG + tristate "MediaTek MFlexGraphics Extensions for Panthor" + depends on (DRM_PANTHOR && ARCH_MEDIATEK) || COMPILE_TEST + select DEVFREQ_GOV_SIMPLE_ONDEMAND + select PM_DEVFREQ + select MTK_GPUEB_MBOX + help + Support for power and clock control in Panthor for MediaTek + MFlexGraphics devices, such as the GPU on the MT8196 or MT6991 SoCs. + + These extensions are required for the GPU to work on these platforms, + as they control the glue logic that powers on the GPU. diff --git a/drivers/gpu/drm/panthor/Makefile b/drivers/gpu/drm/panthor/Mak= efile index 02db21748c125688d2ef20ed254b5ebd7ff642e4..e0ebfdfb20bd78e0003c860c86c= 040746248fb89 100644 --- a/drivers/gpu/drm/panthor/Makefile +++ b/drivers/gpu/drm/panthor/Makefile @@ -12,4 +12,6 @@ panthor-y :=3D \ panthor_mmu.o \ panthor_sched.o =20 +obj-$(CONFIG_DRM_PANTHOR_MEDIATEK_MFG) +=3D mediatek_mfg.o + obj-$(CONFIG_DRM_PANTHOR) +=3D panthor.o diff --git a/drivers/gpu/drm/panthor/mediatek_mfg.c b/drivers/gpu/drm/panth= or/mediatek_mfg.c new file mode 100644 index 0000000000000000000000000000000000000000..bc2bf6539b28197b3cf347a2827= 4e1618ff10d61 --- /dev/null +++ b/drivers/gpu/drm/panthor/mediatek_mfg.c @@ -0,0 +1,1053 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Driver for MediaTek MFlexGraphics Devices + * + * Copyright (C) 2025, Collabora Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include "panthor_devfreq.h" +#include "panthor_device.h" + +#define GPR_LP_STATE 0x0028 +#define EB_ON_SUSPEND 0x0 +#define EB_ON_RESUME 0x1 +#define GPR_IPI_MAGIC 0x34 + +#define RPC_PWR_CON 0x0504 +#define PWR_ACK_M GENMASK(31, 30) +#define RPC_DUMMY_REG_2 0x0658 +#define RPC_GHPM_CFG0_CON 0x0800 +#define GHPM_ENABLE_M BIT(0) +#define GHPM_ON_SEQ_M BIT(2) +#define RPC_GHPM_RO0_CON 0x09A4 +#define GHPM_STATE_M GENMASK(7, 0) +#define GHPM_PWR_STATE_M BIT(16) + +#define GF_REG_MAGIC 0x0000 +#define GF_REG_GPU_OPP_IDX 0x0004 +#define GF_REG_STK_OPP_IDX 0x0008 +#define GF_REG_GPU_OPP_NUM 0x000c +#define GF_REG_STK_OPP_NUM 0x0010 +#define GF_REG_GPU_OPP_SNUM 0x0014 +#define GF_REG_STK_OPP_SNUM 0x0018 +#define GF_REG_POWER_COUNT 0x001c +#define GF_REG_BUCK_COUNT 0x0020 +#define GF_REG_MTCMOS_COUNT 0x0024 +#define GF_REG_CG_COUNT 0x0028 /* CG =3D Clock Gate? */ +#define GF_REG_ACTIVE_COUNT 0x002C +#define GF_REG_TEMP_RAW 0x0030 +#define GF_REG_TEMP_NORM_GPU 0x0034 +#define GF_REG_TEMP_HIGH_GPU 0x0038 +#define GF_REG_TEMP_NORM_STK 0x003C +#define GF_REG_TEMP_HIGH_STK 0x0040 +#define GF_REG_FREQ_CUR_GPU 0x0044 +#define GF_REG_FREQ_CUR_STK 0x0048 +#define GF_REG_FREQ_OUT_GPU 0x004C /* Guess: actual achieved freq */ +#define GF_REG_FREQ_OUT_STK 0x0050 /* Guess: actual achieved freq */ +#define GF_REG_FREQ_METER_GPU 0x0054 /* Seems unused, always 0 */ +#define GF_REG_FREQ_METER_STK 0x0058 /* Seems unused, always 0 */ +#define GF_REG_VOLT_CUR_GPU 0x005C /* in tens of microvolts */ +#define GF_REG_VOLT_CUR_STK 0x0060 /* in tens of microvolts */ +#define GF_REG_VOLT_CUR_GPU_SRAM 0x0064 +#define GF_REG_VOLT_CUR_STK_SRAM 0x0068 +#define GF_REG_VOLT_CUR_GPU_REG 0x006C /* Seems unused, always 0 */ +#define GF_REG_VOLT_CUR_STK_REG 0x0070 /* Seems unused, always 0 */ +#define GF_REG_VOLT_CUR_GPU_REG_SRAM 0x0074 +#define GF_REG_VOLT_CUR_STK_REG_SRAM 0x0078 +#define GF_REG_PWR_CUR_GPU 0x007C /* in milliwatts */ +#define GF_REG_PWR_CUR_STK 0x0080 /* in milliwatts */ +#define GF_REG_PWR_MAX_GPU 0x0084 /* in milliwatts */ +#define GF_REG_PWR_MAX_STK 0x0088 /* in milliwatts */ +#define GF_REG_PWR_MIN_GPU 0x008C /* in milliwatts */ +#define GF_REG_PWR_MIN_STK 0x0090 /* in milliwatts */ +#define GF_REG_LEAKAGE_RT_GPU 0x0094 /* Unknown */ +#define GF_REG_LEAKAGE_RT_STK 0x0098 /* Unknown */ +#define GF_REG_LEAKAGE_RT_SRAM 0x009C /* Unknown */ +#define GF_REG_LEAKAGE_HT_GPU 0x00A0 /* Unknown */ +#define GF_REG_LEAKAGE_HT_STK 0x00A4 /* Unknown */ +#define GF_REG_LEAKAGE_HT_SRAM 0x00A8 /* Unknown */ +#define GF_REG_VOLT_DAC_LOW_GPU 0x00AC /* Seems unused, always 0 */ +#define GF_REG_VOLT_DAC_LOW_STK 0x00B0 /* Seems unused, always 0 */ +#define GF_REG_OPP_CUR_CEIL 0x00B4 +#define GF_REG_OPP_CUR_FLOOR 0x00B8 +#define GF_REG_OPP_CUR_LIMITER_CEIL 0x00BC +#define GF_REG_OPP_CUR_LIMITER_FLOOR 0x00C0 +#define GF_REG_OPP_PRIORITY_CEIL 0x00C4 +#define GF_REG_OPP_PRIORITY_FLOOR 0x00C8 +#define GF_REG_PWR_CTL 0x00CC +#define GF_REG_ACTIVE_SLEEP_CTL 0x00D0 +#define GF_REG_DVFS_STATE 0x00D4 +#define GF_REG_SHADER_PRESENT 0x00D8 +#define GF_REG_ASENSOR_ENABLE 0x00DC +#define GF_REG_AGING_LOAD 0x00E0 +#define GF_REG_AGING_MARGIN 0x00E4 +#define GF_REG_AVS_ENABLE 0x00E8 +#define GF_REG_AVS_MARGIN 0x00EC +#define GF_REG_CHIP_TYPE 0x00F0 +#define GF_REG_SB_VERSION 0x00F4 +#define GF_REG_PTP_VERSION 0x00F8 +#define GF_REG_DBG_VERSION 0x00FC +#define GF_REG_KDBG_VERSION 0x0100 +#define GF_REG_GPM1_MODE 0x0104 +#define GF_REG_GPM3_MODE 0x0108 +#define GF_REG_DFD_MODE 0x010C +#define GF_REG_DUAL_BUCK 0x0110 +#define GF_REG_SEGMENT_ID 0x0114 +#define GF_REG_POWER_TIME_H 0x0118 +#define GF_REG_POWER_TIME_L 0x011C +#define GF_REG_PWR_STATUS 0x0120 +#define GF_REG_STRESS_TEST 0x0124 +#define GF_REG_TEST_MODE 0x0128 +#define GF_REG_IPS_MODE 0x012C +#define GF_REG_TEMP_COMP_MODE 0x0130 +#define GF_REG_HT_TEMP_COMP_MODE 0x0134 +#define GF_REG_PWR_TRACKER_MODE 0x0138 +#define GF_REG_OPP_TABLE_GPU 0x0314 +#define GF_REG_OPP_TABLE_STK 0x09A4 +#define GF_REG_OPP_TABLE_GPU_S 0x1034 +#define GF_REG_OPP_TABLE_STK_S 0x16c4 +#define GF_REG_LIMIT_TABLE 0x1d54 +#define GF_REG_GPM3_TABLE 0x223C + +#define MFG_MT8196_E2_ID 0x101 +#define GPUEB_SLEEP_MAGIC 0x55667788UL + +#define GPUEB_TIMEOUT_US 10000UL +#define GPUEB_POLL_US 50 + +#define MAX_OPP_NUM 70 + +/* + * This enum is part of the ABI of the GPUEB firmware. Don't change the + * numbering, as you would wreak havoc. + */ +enum mtk_mfg_ipi_cmd { + CMD_INIT_SHARED_MEM =3D 0, + CMD_GET_FREQ_BY_IDX =3D 1, + CMD_GET_POWER_BY_IDX =3D 2, + CMD_GET_OPPIDX_BY_FREQ =3D 3, + CMD_GET_LEAKAGE_POWER =3D 4, + CMD_SET_LIMIT =3D 5, + CMD_POWER_CONTROL =3D 6, + CMD_ACTIVE_SLEEP_CONTROL =3D 7, + CMD_COMMIT =3D 8, + CMD_DUAL_COMMIT =3D 9, + CMD_PDCA_CONFIG =3D 10, + CMD_UPDATE_DEBUG_OPP_INFO =3D 11, + CMD_SWITCH_LIMIT =3D 12, + CMD_FIX_TARGET_OPPIDX =3D 13, + CMD_FIX_DUAL_TARGET_OPPIDX =3D 14, + CMD_FIX_CUSTOM_FREQ_VOLT =3D 15, + CMD_FIX_DUAL_CUSTOM_FREQ_VOLT =3D 16, + CMD_SET_MFGSYS_CONFIG =3D 17, + CMD_MSSV_COMMIT =3D 18, + CMD_NUM =3D 19, +}; + +/* + * This struct is part of the ABI of the GPUEB firmware. Changing it, or + * reordering fields in it, will break things, so don't do it. Thank you. + */ +struct __packed mtk_mfg_ipi_msg { + __le32 magic; + __le32 cmd; + __le32 target; + /* + * Downstream relies on the compiler to implicitly add the following + * padding, as it declares the struct as non-packed. + */ + __le32 padding_lol; + union { + s32 __bitwise oppidx; + s32 __bitwise return_value; + __le32 freq; + __le32 volt; + __le32 power; + __le32 power_state; + __le32 mode; + __le32 value; + struct { + __le64 base; + __le32 size; + } shared_mem; + struct { + __le32 freq; + __le32 volt; + } custom; + struct { + __le32 limiter; + s32 __bitwise ceiling_info; + s32 __bitwise floor_info; + } set_limit; + struct { + __le32 target; + __le32 val; + } mfg_cfg; + struct { + __le32 target; + __le32 val; + } mssv; + struct { + s32 __bitwise gpu_oppidx; + s32 __bitwise stack_oppidx; + } dual_commit; + struct { + __le32 fgpu; + __le32 vgpu; + __le32 fstack; + __le32 vstack; + } dual_custom; + } u; +}; + +struct __packed mtk_mfg_ipi_sleep_msg { + __le32 event; + __le32 state; + __le32 magic; +}; + +/** + * struct mtk_mfg_opp_entry - OPP table entry from firmware + * @freq_khz: The operating point's frequency in kilohertz + * @voltage_core: The operating point's core voltage in tens of microvolts + * @voltage_sram: The operating point's SRAM voltage in tens of microvolts + * @posdiv: exponent of base 2 for PLL frequency divisor used for this OPP + * @voltage_margin: Number of tens of microvolts the voltage can be unders= hot + * @power_mw: estimate of power usage at this operating point, in milliwat= ts + * + * This struct is part of the ABI with the EB firmware. Do not change it. + */ +struct __packed mtk_mfg_opp_entry { + __le32 freq_khz; + __le32 voltage_core; + __le32 voltage_sram; + __le32 posdiv; + __le32 voltage_margin; + __le32 power_mw; +}; + +struct mtk_mfg_mbox { + struct mbox_client cl; + struct completion rx_done; + struct mtk_mfg *mfg; + struct mbox_chan *ch; + void *rx_data; +}; + +struct mtk_mfg { + struct platform_device *pdev; + struct panthor_device *ptdev; + struct clk *clk_eb; + struct clk_bulk_data *gpu_clks; + struct regulator_bulk_data *gpu_regs; + void __iomem *rpc; + void __iomem *gpr; + void __iomem *sram; + phys_addr_t sram_phys; + unsigned int sram_size; + unsigned int ghpm_en_reg; + u32 ipi_magic; + unsigned int num_opps; + unsigned int num_unique_gpu_opps; + struct dev_pm_opp_data *gpu_opps; + struct dev_pm_opp_data *stack_opps; + struct mtk_mfg_mbox *gf_mbox; + struct mtk_mfg_mbox *slp_mbox; + int last_opp; + const struct mtk_mfg_variant *variant; +}; + +struct mtk_mfg_variant { + const char *const *clk_names; + unsigned int num_clks; + const char *const *regulator_names; + unsigned int num_regulators; + int (*init)(struct mtk_mfg *mfg); +}; + +static inline void mtk_mfg_update_reg_bits(void __iomem *addr, u32 mask, u= 32 val) +{ + writel((readl(addr) & ~mask) | (val & mask), addr); +} + +static inline unsigned long mtk_mfg_read_gpu_freq(struct mtk_mfg *mfg) +{ + return readl(mfg->sram + GF_REG_FREQ_CUR_GPU) * 1000UL; +} + +static int mtk_mfg_eb_on(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + u32 val; + int ret; + + /* + * If MFG is already on from e.g. the bootloader, we should skip doing + * the power-on sequence, as it wouldn't work without powering it off + * first. + */ + if ((readl(mfg->rpc + RPC_PWR_CON) & PWR_ACK_M) =3D=3D PWR_ACK_M) + return 0; + + ret =3D readl_poll_timeout(mfg->rpc + RPC_GHPM_RO0_CON, val, + !(val & (GHPM_PWR_STATE_M | GHPM_STATE_M)), + GPUEB_POLL_US, GPUEB_TIMEOUT_US); + if (ret) { + dev_err(dev, "timed out waiting for EB to power on\n"); + return ret; + } + + mtk_mfg_update_reg_bits(mfg->rpc + mfg->ghpm_en_reg, GHPM_ENABLE_M, + GHPM_ENABLE_M); + + mtk_mfg_update_reg_bits(mfg->rpc + RPC_GHPM_CFG0_CON, GHPM_ON_SEQ_M, 0); + mtk_mfg_update_reg_bits(mfg->rpc + RPC_GHPM_CFG0_CON, GHPM_ON_SEQ_M, + GHPM_ON_SEQ_M); + + mtk_mfg_update_reg_bits(mfg->rpc + mfg->ghpm_en_reg, GHPM_ENABLE_M, 0); + + + ret =3D readl_poll_timeout(mfg->rpc + RPC_PWR_CON, val, + (val & PWR_ACK_M) =3D=3D PWR_ACK_M, + GPUEB_POLL_US, GPUEB_TIMEOUT_US); + if (ret) { + dev_err(dev, "timed out waiting for EB power ack, val =3D 0x%X\n", + val); + return ret; + } + + ret =3D readl_poll_timeout(mfg->gpr + GPR_LP_STATE, val, + (val =3D=3D EB_ON_RESUME), + GPUEB_POLL_US, GPUEB_TIMEOUT_US); + if (ret) { + dev_err(dev, "timed out waiting for EB to resume, status =3D 0x%X\n", va= l); + return ret; + } + + return 0; +} + +static int mtk_mfg_eb_off(struct mtk_mfg *mfg) +{ + struct mtk_mfg_ipi_sleep_msg msg =3D { + .event =3D 0, + .state =3D 0, + .magic =3D GPUEB_SLEEP_MAGIC + }; + u32 val; + int ret; + + ret =3D mbox_send_message(mfg->slp_mbox->ch, &msg); + if (ret < 0) { + dev_err(&mfg->pdev->dev, "failure in mbox comms: %pe\n", + ERR_PTR(ret)); + return ret; + } + + ret =3D readl_poll_timeout(mfg->rpc + RPC_PWR_CON, val, + !(val & PWR_ACK_M), GPUEB_POLL_US, + GPUEB_TIMEOUT_US); + + if (ret) { + dev_err(&mfg->pdev->dev, + "timed out waiting for EB to power off, val=3D0x%08X\n", + val); + } + + return ret; +} + +static int mtk_mfg_send_ipi(struct mtk_mfg *mfg, struct mtk_mfg_ipi_msg *m= sg) +{ + int ret; + + msg->magic =3D mfg->ipi_magic; + + ret =3D mbox_send_message(mfg->gf_mbox->ch, msg); + if (ret < 0) { + dev_err(&mfg->pdev->dev, "error from mailbox subsystem: %pe\n", + ERR_PTR(ret)); + return ret; + } + + wait_for_completion(&mfg->gf_mbox->rx_done); + + memcpy(msg, mfg->gf_mbox->rx_data, sizeof(*msg)); + + if (msg->u.return_value < 0) { + dev_err(&mfg->pdev->dev, "IPI return: %d\n", + msg->u.return_value); + return -EPROTO; + } + + return 0; +} + +static int mtk_mfg_init_shared_mem(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + struct mtk_mfg_ipi_msg msg =3D {}; + int ret; + + dev_info(dev, "clearing GPUEB sram, 0x%X bytes\n", mfg->sram_size); + memset_io(mfg->sram, 0, mfg->sram_size); + + msg.cmd =3D CMD_INIT_SHARED_MEM; + msg.u.shared_mem.base =3D mfg->sram_phys; + msg.u.shared_mem.size =3D mfg->sram_size; + + ret =3D mtk_mfg_send_ipi(mfg, &msg); + if (ret) + return ret; + + if (readl(mfg->sram) !=3D 0xBABADADA) { + dev_err(dev, "EB did not initialise SRAM correctly\n"); + return -EIO; + } + + dev_info(dev, "initialised mem at phys 0x%016llX\n", mfg->sram_phys); + + return 0; +} + +static int mtk_mfg_power_control(struct mtk_mfg *mfg, bool enabled) +{ + struct mtk_mfg_ipi_msg msg =3D {}; + + msg.cmd =3D CMD_POWER_CONTROL; + msg.u.power_state =3D enabled ? 1 : 0; + + return mtk_mfg_send_ipi(mfg, &msg); +} + +static int mtk_mfg_set_oppidx(struct mtk_mfg *mfg, int opp_idx) +{ + struct mtk_mfg_ipi_msg msg =3D {}; + int ret; + + if (!mfg->gpu_opps || !mfg->stack_opps) + return 0; + + if (opp_idx >=3D mfg->num_opps) + return -EINVAL; + + if (mfg->last_opp =3D=3D opp_idx) + return 0; + + msg.cmd =3D CMD_FIX_TARGET_OPPIDX; + msg.u.oppidx =3D opp_idx; + + ret =3D mtk_mfg_send_ipi(mfg, &msg); + if (ret) + return ret; + + mfg->last_opp =3D opp_idx; + + return 0; +} + +static int mtk_mfg_read_opp_tables(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + struct mtk_mfg_opp_entry e =3D {}; + unsigned int i; + unsigned long long last_freq; + + mfg->num_opps =3D readl(mfg->sram + GF_REG_GPU_OPP_NUM); + if (mfg->num_opps !=3D readl(mfg->sram + GF_REG_STK_OPP_NUM)) { + dev_err(dev, "OPP count of GPU and Stack differ, %u vs. %u\n", + mfg->num_opps, readl(mfg->sram + GF_REG_STK_OPP_NUM)); + return -EINVAL; + } + + if (mfg->num_opps > MAX_OPP_NUM || mfg->num_opps =3D=3D 0) { + dev_err(dev, "OPP count (%u) out of range %u >=3D count > 0\n", + mfg->num_opps, MAX_OPP_NUM); + return -EINVAL; + } + + mfg->gpu_opps =3D devm_kcalloc(dev, mfg->num_opps, + sizeof(struct dev_pm_opp_data), GFP_KERNEL); + if (!mfg->gpu_opps) + return -ENOMEM; + + mfg->stack_opps =3D devm_kcalloc(dev, mfg->num_opps, + sizeof(struct dev_pm_opp_data), GFP_KERNEL); + if (!mfg->stack_opps) + return -ENOMEM; + + for (i =3D 0; i < mfg->num_opps; i++) { + memcpy_fromio(&e, mfg->sram + GF_REG_OPP_TABLE_GPU + i * sizeof(e), + sizeof(e)); + if (mem_is_zero(&e, sizeof(e))) { + dev_err(dev, "ran into an empty GPU OPP at index %u\n", + i); + return -EINVAL; + } + mfg->gpu_opps[i].freq =3D e.freq_khz * 1000ULL; + mfg->gpu_opps[i].u_volt =3D e.voltage_core * 10; + + if (!last_freq || mfg->gpu_opps[i].freq !=3D last_freq) + mfg->num_unique_gpu_opps++; + + last_freq =3D mfg->gpu_opps[i].freq; + } + + /* Why do I even bother? */ + for (i =3D 0; i < mfg->num_opps; i++) { + memcpy_fromio(&e, mfg->sram + GF_REG_OPP_TABLE_STK + i * sizeof(e), + sizeof(e)); + if (mem_is_zero(&e, sizeof(e))) { + dev_err(dev, "ran into an empty GPU OPP at index %u\n", + i); + return -EINVAL; + } + mfg->stack_opps[i].freq =3D e.freq_khz * 1000ULL; + mfg->stack_opps[i].u_volt =3D e.voltage_core * 10; + } + + return 0; +} + +static inline bool mtk_mfg_opp_idx_match(struct mtk_mfg *mfg, int idx, + unsigned long rate) +{ + if ((idx =3D=3D mfg->num_opps - 1) && mfg->gpu_opps[idx].freq >=3D rate) + return true; + + if (mfg->gpu_opps[idx].freq >=3D rate && mfg->gpu_opps[idx + 1].freq < ra= te) + return true; + + return false; +} + +/** + * mtk_mfg_get_closest_opp_idx - find OPP index for desired GPU frequency + * @mfg: pointer to a &struct mtk_mfg driver instance + * @gpu_rate: desired rate of the GPU core in Hz + * + * Given a desired target frequency for the GPU core, find the index of a + * matching OPP, or the next higher OPP if no exact match is found, or the + * maximum OPP for frequencies exceeding the maximum OPP's frequency. + * + * For duplicate OPP entries, chooses the highest OPP index, as in, the one + * closest to the next lower frequency OPP. + * + * Returns -EINVAL on error, or the OPP index on success. + */ +static int mtk_mfg_get_closest_opp_idx(struct mtk_mfg *mfg, unsigned long = gpu_rate) +{ + int l =3D 0; + int r =3D mfg->num_opps - 1; + int m; + + if (!mfg->gpu_opps) + return -EINVAL; + + if (mfg->gpu_opps[0].freq <=3D gpu_rate) + return 0; + + while (l <=3D r) { + m =3D l + (r - l) / 2; + if (mtk_mfg_opp_idx_match(mfg, m, gpu_rate)) { + return m; + } else if (mfg->gpu_opps[m].freq >=3D gpu_rate) /* >=3D for dupes */ + l =3D m + 1; + else + r =3D m - 1; + } + + return -EINVAL; +} + +static int mtk_mfg_devfreq_target(struct device *dev, unsigned long *freq, + u32 flags) +{ + struct panthor_device *ptdev =3D dev_get_drvdata(dev); + struct panthor_devfreq *pdevfreq =3D ptdev->devfreq; + struct mtk_mfg *mfg =3D dev_get_drvdata(&pdevfreq->devfreq->dev); + int ret, opp; + + opp =3D mtk_mfg_get_closest_opp_idx(mfg, *freq); + if (opp < 0) { + dev_err(dev, "Couldn't get closest OPP: %pe\n", ERR_PTR(opp)); + return opp; + } + + ret =3D pm_runtime_resume_and_get(&mfg->pdev->dev); + if (ret) + return ret; + + ret =3D mtk_mfg_set_oppidx(mfg, opp); + if (!ret) + *freq =3D mtk_mfg_read_gpu_freq(mfg); + else + dev_err(dev, "Couldn't set OPP: %pe\n", ERR_PTR(ret)); + + pm_runtime_put(&mfg->pdev->dev); + + return ret; +} + +static int mtk_mfg_devfreq_get_cur_freq(struct device *dev, unsigned long = *freq) +{ + struct panthor_device *ptdev =3D dev_get_drvdata(dev); + struct panthor_devfreq *pdevfreq =3D ptdev->devfreq; + struct mtk_mfg *mfg; + int ret; + + if (IS_ERR_OR_NULL(pdevfreq->devfreq)) + return -ENODEV; + + mfg =3D dev_get_drvdata(&pdevfreq->devfreq->dev); + if (IS_ERR_OR_NULL(mfg)) { + *freq =3D pdevfreq->devfreq->profile->initial_freq; + return 0; + } + + ret =3D pm_runtime_resume_and_get(&mfg->pdev->dev); + if (ret) + return ret; + + *freq =3D mtk_mfg_read_gpu_freq(mfg); + + pm_runtime_put(&mfg->pdev->dev); + + return 0; +} + +static const struct devfreq_dev_profile mtk_mfg_devfreq_profile =3D { + .timer =3D DEVFREQ_TIMER_DELAYED, + .polling_ms =3D 50, /* ~3 frames */ + .target =3D mtk_mfg_devfreq_target, + .get_dev_status =3D panthor_devfreq_get_dev_status, + .get_cur_freq =3D mtk_mfg_devfreq_get_cur_freq, +}; + +static const char *const mtk_mfg_mt8196_clk_names[] =3D { + "mfgpll", + "mfgpll_sc0", + "mfgpll_sc1", +}; + +static const char *const mtk_mfg_mt8196_regulators[] =3D { + "core", + "stack", + "sram", +}; + +static int mtk_mfg_mt8196_init(struct mtk_mfg *mfg) +{ + void __iomem *e2_base; + + e2_base =3D devm_platform_ioremap_resource_byname(mfg->pdev, "e2_id"); + if (IS_ERR(e2_base)) + return dev_err_probe(&mfg->pdev->dev, PTR_ERR(e2_base), + "Couldn't get e2_id register\n"); + + if (readl(e2_base) =3D=3D MFG_MT8196_E2_ID) + mfg->ghpm_en_reg =3D RPC_DUMMY_REG_2; + else + mfg->ghpm_en_reg =3D RPC_GHPM_CFG0_CON; + + return 0; +}; + +static const struct mtk_mfg_variant mtk_mfg_mt8196_variant =3D { + .clk_names =3D mtk_mfg_mt8196_clk_names, + .num_clks =3D ARRAY_SIZE(mtk_mfg_mt8196_clk_names), + .regulator_names =3D mtk_mfg_mt8196_regulators, + .num_regulators =3D ARRAY_SIZE(mtk_mfg_mt8196_regulators), + .init =3D mtk_mfg_mt8196_init, +}; + +static int mtk_mfg_init_devfreq(struct panthor_device *ptdev, + struct device *gpufreq_dev) +{ + struct device *gpu =3D ptdev->base.dev; + struct panthor_devfreq *pdevfreq; + struct mtk_mfg *mfg; + struct devfreq_dev_profile *profile; + struct dev_pm_opp *opp; + int j =3D 0; + int i, ret; + + mfg =3D dev_get_drvdata(gpufreq_dev); + + if (!mfg) + return -EPROBE_DEFER; + + if (!mfg->gpu_opps) + return -EPROBE_DEFER; + + pdevfreq =3D drmm_kzalloc(&ptdev->base, sizeof(*ptdev->devfreq), GFP_KERN= EL); + if (!pdevfreq) + return -ENOMEM; + + ptdev->devfreq =3D pdevfreq; + mfg->ptdev =3D ptdev; + + spin_lock_init(&pdevfreq->lock); + + profile =3D devm_kmemdup(gpu, &mtk_mfg_devfreq_profile, sizeof(*profile), + GFP_KERNEL); + + if (!profile) + return -ENOMEM; + + ret =3D pm_runtime_resume_and_get(&mfg->pdev->dev); + if (ret) { + dev_err(gpufreq_dev, "could not resume runtime pm: %pe\n", + ERR_PTR(ret)); + return ret; + } + profile->initial_freq =3D mtk_mfg_read_gpu_freq(mfg); + pm_runtime_put(&mfg->pdev->dev); + + profile->freq_table =3D devm_kcalloc(gpu, mfg->num_unique_gpu_opps, + sizeof(*profile->freq_table), + GFP_KERNEL); + if (!profile->freq_table) + return -ENOMEM; + + profile->max_state =3D mfg->num_unique_gpu_opps; + + for (i =3D mfg->num_opps - 1; i >=3D 0 && j < profile->max_state; i--) { + if ((j =3D=3D 0) || (mfg->gpu_opps[i].freq !=3D profile->freq_table[j - = 1])) { + profile->freq_table[j] =3D mfg->gpu_opps[i].freq; + ret =3D dev_pm_opp_add_dynamic(gpu, &mfg->gpu_opps[i]); + if (ret) { + dev_err(gpu, "couldn't add OPP %d: %pe\n", + i, ERR_PTR(ret)); + return ret; + } + j++; + } + } + + opp =3D devfreq_recommended_opp(gpu, &profile->initial_freq, 0); + if (IS_ERR(opp)) { + dev_err(gpufreq_dev, "failed getting OPP recommendation: %pe\n", + opp); + return PTR_ERR(opp); + } + + ret =3D dev_pm_opp_set_opp(gpu, opp); + dev_pm_opp_put(opp); + if (ret) { + dev_err(gpu, "Couldn't set recommended OPP\n"); + return ret; + } + + ptdev->fast_rate =3D profile->freq_table[profile->max_state - 1]; + + pdevfreq->time_last_update =3D ktime_get(); + pdevfreq->gov_data.upthreshold =3D 45; + pdevfreq->gov_data.downdifferential =3D 5; + + pdevfreq->devfreq =3D devm_devfreq_add_device(ptdev->base.dev, profile, + DEVFREQ_GOV_SIMPLE_ONDEMAND, + &pdevfreq->gov_data); + if (IS_ERR(pdevfreq->devfreq)) { + dev_err(gpu, "Failed to register devfreq device: %pe\n", + pdevfreq->devfreq); + return PTR_ERR(pdevfreq->devfreq); + } + + /* + * There are some ways devfreq_add_device can fail without setting an + * error pointer, but setting a NULL pointer instead. We really don't + * want to return 0 in the above check, so return -EINVAL here. + */ + if (!pdevfreq->devfreq) { + dev_err(gpu, "Failed to register devfreq device\n"); + return -EINVAL; + } + + dev_set_drvdata(&pdevfreq->devfreq->dev, mfg); + + return 0; +} + +static void mtk_mfg_mbox_rx_callback(struct mbox_client *cl, void *mssg) +{ + struct mtk_mfg_mbox *mb =3D container_of(cl, struct mtk_mfg_mbox, cl); + + mb->rx_data =3D mssg; + complete(&mb->rx_done); +} + +static int mtk_mfg_init_mbox(struct mtk_mfg *mfg) +{ + struct device *dev =3D &mfg->pdev->dev; + struct mtk_mfg_mbox *gf; + struct mtk_mfg_mbox *slp; + + gf =3D devm_kzalloc(dev, sizeof(*gf), GFP_KERNEL); + if (!gf) + return -ENOMEM; + + slp =3D devm_kzalloc(dev, sizeof(*slp), GFP_KERNEL); + if (!slp) + return -ENOMEM; + + gf->mfg =3D mfg; + init_completion(&gf->rx_done); + gf->cl.dev =3D dev; + gf->cl.rx_callback =3D mtk_mfg_mbox_rx_callback; + gf->cl.tx_tout =3D GPUEB_TIMEOUT_US / USEC_PER_MSEC; + gf->ch =3D mbox_request_channel_byname(&gf->cl, "gpufreq"); + if (IS_ERR(gf->ch)) + return PTR_ERR(gf->ch); + + mfg->gf_mbox =3D gf; + + slp->mfg =3D mfg; + init_completion(&slp->rx_done); + slp->cl.dev =3D dev; + slp->cl.tx_tout =3D GPUEB_TIMEOUT_US / USEC_PER_MSEC; + slp->cl.tx_block =3D true; + slp->ch =3D mbox_request_channel_byname(&slp->cl, "sleep"); + if (IS_ERR(slp->ch)) + return PTR_ERR(slp->ch); + + mfg->slp_mbox =3D slp; + + return 0; +} + +static const struct of_device_id mtk_mfg_of_match[] =3D { + { .compatible =3D "mediatek,mt8196-gpufreq", .data =3D &mtk_mfg_mt8196_va= riant }, + {} +}; +MODULE_DEVICE_TABLE(of, mtk_mfg_of_match); + +static int mtk_mfg_probe(struct platform_device *pdev) +{ + struct device_node *shmem __free(device_node); + struct panthor_devfreq_provider *prov; + struct mtk_mfg *mfg; + struct device *dev =3D &pdev->dev; + const struct mtk_mfg_variant *data =3D of_device_get_match_data(dev); + struct resource res; + int ret; + int i; + + mfg =3D devm_kzalloc(dev, sizeof(*mfg), GFP_KERNEL); + if (!mfg) + return -ENOMEM; + + prov =3D devm_kzalloc(dev, sizeof(*prov), GFP_KERNEL); + if (!prov) + return -ENOMEM; + + prov->dev =3D dev; + prov->init =3D mtk_mfg_init_devfreq; + + mfg->pdev =3D pdev; + mfg->variant =3D data; + + dev_set_drvdata(dev, mfg); + + mfg->gpr =3D devm_platform_ioremap_resource_byname(pdev, "gpr"); + if (IS_ERR(mfg->gpr)) + return dev_err_probe(dev, PTR_ERR(mfg->gpr), + "Could not retrieve GPR MMIO registers\n"); + + mfg->rpc =3D devm_platform_ioremap_resource_byname(pdev, "rpc"); + if (IS_ERR(mfg->rpc)) + return dev_err_probe(dev, PTR_ERR(mfg->rpc), + "Could not retrieve RPC MMIO registers\n"); + + mfg->clk_eb =3D devm_clk_get(dev, "eb"); + if (IS_ERR(mfg->clk_eb)) + return dev_err_probe(dev, PTR_ERR(mfg->clk_eb), + "Could not get 'eb' clock\n"); + + mfg->gpu_clks =3D devm_kcalloc(dev, data->num_clks, sizeof(*mfg->gpu_clks= ), + GFP_KERNEL); + if (!mfg->gpu_clks) + return -ENOMEM; + + for (i =3D 0; i < data->num_clks; i++) + mfg->gpu_clks[i].id =3D data->clk_names[i]; + + ret =3D devm_clk_bulk_get(dev, data->num_clks, mfg->gpu_clks); + if (ret) + return dev_err_probe(dev, ret, "couldn't get GPU clocks\n"); + + mfg->gpu_regs =3D devm_kcalloc(dev, data->num_regulators, + sizeof(*mfg->gpu_regs), GFP_KERNEL); + if (!mfg->gpu_regs) + return -ENOMEM; + + for (i =3D 0; i < data->num_regulators; i++) + mfg->gpu_regs[i].supply =3D data->regulator_names[i]; + + ret =3D devm_regulator_bulk_get(dev, data->num_regulators, mfg->gpu_regs); + if (ret) + return dev_err_probe(dev, ret, "couldn't get GPU regulators\n"); + + shmem =3D of_parse_phandle(dev->of_node, "shmem", 0); + if (!shmem) + return dev_err_probe(dev, -ENODEV, "Could not get 'shmem'\n"); + + ret =3D of_address_to_resource(shmem, 0, &res); + if (ret) + return dev_err_probe(dev, ret, + "failed to get GPUEB shared memory\n"); + + mfg->sram =3D devm_ioremap(dev, res.start, resource_size(&res)); + if (!mfg->sram) + return dev_err_probe(dev, -EADDRNOTAVAIL, + "failed to ioremap GPUEB sram\n"); + mfg->sram_size =3D resource_size(&res); + mfg->sram_phys =3D res.start; + + if (data->init) { + ret =3D data->init(mfg); + if (ret) + return dev_err_probe(dev, ret, "Variant init failed\n"); + } + + ret =3D clk_prepare_enable(mfg->clk_eb); + if (ret) + return dev_err_probe(dev, ret, "failed to turn on EB clock\n"); + mfg->ipi_magic =3D readl(mfg->gpr + GPR_IPI_MAGIC); + writel(0x0, mfg->gpr + GPR_IPI_MAGIC); /* why. */ + + ret =3D mtk_mfg_init_mbox(mfg); + if (ret) { + ret =3D dev_err_probe(dev, ret, "Couldn't initialise mailbox\n"); + goto out; + } + + clk_disable_unprepare(mfg->clk_eb); + + mfg->last_opp =3D -1; + + devm_pm_runtime_enable(dev); + + ret =3D pm_runtime_resume_and_get(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to power on MFG\n"); + + ret =3D mtk_mfg_init_shared_mem(mfg); + if (ret) { + dev_err(dev, "Couldn't initialize EB SRAM: %pe\n", ERR_PTR(ret)); + goto out; + } + + ret =3D mtk_mfg_read_opp_tables(mfg); + if (ret) { + dev_err(dev, "Error reading OPP tables from EB: %pe\n", + ERR_PTR(ret)); + goto out; + } + + panthor_devfreq_register_provider(prov); + +out: + pm_runtime_put(dev); + return ret; +} + +static int mtk_mfg_suspend(struct device *dev) +{ + struct mtk_mfg *mfg =3D dev_get_drvdata(dev); + int ret; + + ret =3D mtk_mfg_power_control(mfg, false); + if (ret) { + dev_err(dev, "power_control failed: %pe\n", ERR_PTR(ret)); + return ret; + } + ret =3D mtk_mfg_eb_off(mfg); + if (ret) { + dev_err(dev, "eb_off failed: %pe\n", ERR_PTR(ret)); + return ret; + } + clk_bulk_disable_unprepare(mfg->variant->num_clks, mfg->gpu_clks); + clk_disable_unprepare(mfg->clk_eb); + ret =3D regulator_bulk_disable(mfg->variant->num_regulators, mfg->gpu_reg= s); + + return ret; +} + +static int mtk_mfg_resume(struct device *dev) +{ + struct mtk_mfg *mfg =3D dev_get_drvdata(dev); + int ret; + + ret =3D regulator_bulk_enable(mfg->variant->num_regulators, + mfg->gpu_regs); + if (ret) + return ret; + + ret =3D clk_prepare_enable(mfg->clk_eb); + if (ret) + goto err_disable_regulators; + + ret =3D clk_bulk_prepare_enable(mfg->variant->num_clks, mfg->gpu_clks); + if (ret) + goto err_disable_eb_clk; + + ret =3D mtk_mfg_eb_on(mfg); + if (ret) + goto err_disable_clks; + + ret =3D mtk_mfg_power_control(mfg, true); + if (ret) + goto err_eb_off; + + return 0; + +err_eb_off: + mtk_mfg_eb_off(mfg); +err_disable_clks: + clk_bulk_disable_unprepare(mfg->variant->num_clks, mfg->gpu_clks); +err_disable_eb_clk: + clk_disable_unprepare(mfg->clk_eb); +err_disable_regulators: + regulator_bulk_disable(mfg->variant->num_regulators, mfg->gpu_regs); + + return ret; +} + + +static DEFINE_RUNTIME_DEV_PM_OPS(mtk_mfg_pm_ops, + mtk_mfg_suspend, + mtk_mfg_resume, + NULL); + +static struct platform_driver mtk_mfg_driver =3D { + .driver =3D { + .name =3D "panthor-mtk-mfg", + .of_match_table =3D mtk_mfg_of_match, + .pm =3D pm_ptr(&mtk_mfg_pm_ops), + }, + .probe =3D mtk_mfg_probe, +}; +module_platform_driver(mtk_mfg_driver); + +MODULE_SOFTDEP("pre: panthor"); +MODULE_AUTHOR("Nicolas Frattaroli "); +MODULE_DESCRIPTION("MediaTek MFlexGraphics Extension for Panthor"); +MODULE_LICENSE("GPL"); --=20 2.51.0