From nobody Fri Oct 3 05:29:23 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C8BE233D9C for ; Thu, 4 Sep 2025 16:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757002664; cv=none; b=Uw/BRwtPmOlr3nBWINZYtYNtB7uzN5qoePE2qhpKLi9xKMHJRMXQ8wEvIANvagWdQf+d0zblGfik73+4zASIQt19E+SxWi5VyQMauBQduLUcSgjHXdxqpwTH1pzXKQWBzmhdaphY2vfapg8ZcGW4KhBYcQBqpQCHt5sY7G8CCvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757002664; c=relaxed/simple; bh=WbwuewpY10icGQu/W7sUvcToRo1R4qP9KKJtQKyOM0s=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=nbKclL6E7GC0yi6ss1GKzvuhRnKY+++Chi7/iZFLlzva8Kn9m9ogNkpTLKf9PFXXvx1ol0NbEOdepv5eGcrpXjykaB3e5xt29dzxsc6MAiI0B2z6I4evCCsjJR/iIpCqSjr9ziSJ9hvGhzrFdIhtpKqBKfOuJowTA02+pv/At6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fBMKu5he; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fBMKu5he" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-24ae30bd2d0so13012115ad.3 for ; Thu, 04 Sep 2025 09:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1757002662; x=1757607462; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=/UOanZ2PmR3kMJHnHNKLCAes3a/LIBraz6jr4hqu0OQ=; b=fBMKu5hehv14p9IF60YoyWG0JCH37j/QF4rfp9k5yfoH9U/zU6Dwq3M5Wsyu7zCVk5 9gu9Rq3Jbf0FnO8CRvXzikJJ6S91Ta02n0U7lr+D5I7pmbFHiYdBtbx/P/dYlEcINkng Fzmpej1sIL22cQ7dJuV/gfRKx7x3EdNQ3bwSLfyug3p10bKDtGzmrBgYqsFBPYon/iGH V/d4gHmWb3WMQxeM+hcvO9l/J5PDLkIjiGxvDWtxrRBdSvIs8F4Rw3wzlETm8kLaKtS9 70p5y+ANcfUErJ2r4RUDNAuysjblY+mQDwq0ZaaW0oWRSXpslRdqAa4lc7leX+S6ydQK 7hvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757002662; x=1757607462; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/UOanZ2PmR3kMJHnHNKLCAes3a/LIBraz6jr4hqu0OQ=; b=vgf9zuyhKloV1G15XKs1zpXUYwMGeGXURV8Jk3maOzruDUym5A2gsdKpT8EG66kte/ L9kIlgAXFDuydqMQJpBrIuZZNXREkQloDlQYHDrNfhE1A4w5n+kmRf1kCjBJL33vn3GT N6cr5ykw+k5kwCn0cBFwdtwGP/x+ZxcEgTS3efwMCbWddMkWhru2XQWCQ0EWDzluZpKm OqZdk6rWtVFvtxF3N1x1rWGrnpdqF/VUnf9z7rf//VF3ZqX/LxYoQOYhN434OZcFKfau 8ZnEahQsviWEN+d/v0ZewKs9gDPY02N6a+0zA6lZ868GJGhGhoAJAnBX69o5BSGlz4R+ 2rwQ== X-Forwarded-Encrypted: i=1; AJvYcCWALkeZSKy97XbdZCah/pwqccmO2hW1TnDTDur5unrnTa4oXin/PFsc8o+awEf9K2gWu4NholHrmZ3zmC4=@vger.kernel.org X-Gm-Message-State: AOJu0YxgR/BZZrwq+I7zi25lnzfFxY/yMpVeXF4z1OabPY8nj+1UDP3y b7QBzHB1Qf1QFea0U2ENfVLpM4JDW+7we6YzVGLIh4XpyjKmbCcZOk3nEDDynrYmNUMnvmGtMYK 0kelA926XgA== X-Google-Smtp-Source: AGHT+IHve4jHgJ8Ftz3JzIwawxkAlew/pKxKturHnhBrtdGSG7IWbPfF3US/ysEaBUE4Mj9is3lfpj8gS3tt X-Received: from plpl17.prod.google.com ([2002:a17:903:3dd1:b0:24c:8b0f:b5e4]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:dac2:b0:24a:b5a1:10cd with SMTP id d9443c01a7336-24ab5a1122fmr220398345ad.52.1757002662335; Thu, 04 Sep 2025 09:17:42 -0700 (PDT) Date: Thu, 4 Sep 2025 09:17:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.338.gd7d06c2dae-goog Message-ID: <20250904161731.1193729-1-irogers@google.com> Subject: [PATCH v1] perf symbol-elf: Add support for the block argument for libbfd From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Haibo Xu , Stephen Brennan , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, "=?UTF-8?q?R=C3=A9mi=20Bernon?=" , Sam James , James Clark Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" James Clark caught that the BUILD_NONDISTRO=3D1 build with libbfd was broken due to an update to the read_build_id function adding a blocking argument. Add support for this argument by first opening the file blocking or non-blocking, then switching from bfd_openr to bfd_fdopenr and passing the opened fd. bfd_fdopenr closes the fd on error and when bfd_close are called. Reported-by: James Clark Closes: https://lore.kernel.org/lkml/20250903-james-perf-read-build-id-fix-= v1-2-6a694d0a980f@linaro.org/ Fixes: 2c369d91d093 ("perf symbol: Add blocking argument to filename__read_= build_id") Signed-off-by: Ian Rogers Reviewed-by: James Clark --- This patch should be applied after: https://lore.kernel.org/lkml/20250903-james-perf-read-build-id-fix-v1-1-6a6= 94d0a980f@linaro.org/ --- tools/perf/util/symbol-elf.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 033c79231a54..1346fd180653 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -873,13 +873,17 @@ static int elf_read_build_id(Elf *elf, void *bf, size= _t size) =20 #ifdef HAVE_LIBBFD_BUILDID_SUPPORT =20 -static int read_build_id(const char *filename, struct build_id *bid) +static int read_build_id(const char *filename, struct build_id *bid, bool = block) { size_t size =3D sizeof(bid->data); - int err =3D -1; + int err =3D -1, fd; bfd *abfd; =20 - abfd =3D bfd_openr(filename, NULL); + fd =3D open(filename, block ? O_RDONLY : (O_RDONLY | O_NONBLOCK)); + if (fd < 0) + return -1; + + abfd =3D bfd_fdopenr(filename, /*target=3D*/NULL, fd); if (!abfd) return -1; =20 --=20 2.51.0.338.gd7d06c2dae-goog