From nobody Fri Oct 3 06:37:02 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6AB62877EE for ; Thu, 4 Sep 2025 07:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756970262; cv=none; b=g4yVPR7Z/CzpH9EAiEjYjK6JLgZOpEge77GDRMdKU/Vxg8IxE99zcmlKCGdFwE9vrRfiqkLWjUTPxjUx8z4778AV0yUTQWCIwbKFYVe0gNRTrs0+xnltbHS5nK3ehxmQewviOFLV/6mG4HxRGphwUW66g2mWOaQR/8VOIrtZVWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756970262; c=relaxed/simple; bh=Xjaa/4KIvlEb0Eb8QUjZKXufKO7jQ3AcbZtE0SnZ4yA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gnYLwVMWWWhdFdXV691flaHNRuFnEMbjF10S/vr2PPqUpwU5KJA3xpqlD0/v9fDXhybE65sy9HPgsWyHfEdrgl7g0olW3Y2NaIDhymbDbe4RfA7k+JeCyXnusYtcVdCoQBzBmJOhLbGCkxeHG2DAh646/NZMUE1wv3osmj+Sql0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8BxXNISPbloTo8GAA--.13794S3; Thu, 04 Sep 2025 15:17:38 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by front1 (Coremail) with SMTP id qMiowJDx_8MNPbloS2h9AA--.2519S3; Thu, 04 Sep 2025 15:17:37 +0800 (CST) From: Bibo Mao To: Huacai Chen , Anna-Maria Behnsen , Frederic Weisbecker , Ingo Molnar , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Xianglai Li Subject: [PATCH v2 1/2] tick: Remove unreasonable detached state set in tick_shutdown() Date: Thu, 4 Sep 2025 15:17:31 +0800 Message-Id: <20250904071732.3513694-2-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20250904071732.3513694-1-maobibo@loongson.cn> References: <20250904071732.3513694-1-maobibo@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowJDx_8MNPbloS2h9AA--.2519S3 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Content-Type: text/plain; charset="utf-8" Function clockevents_switch_state() will check whether it has already switched to specified state, do nothing if it has. In function tick_shutdown(), it will set detached state at first and call clockevents_switch_state() in clockevents_exchange_device(). The function clockevents_switch_state() will do nothing since it is already detached state. So the tick timer device will not be shutdown when CPU is offline. In guest VM system, timer interrupt will prevent vCPU to sleep if vCPU is hot removed. Here remove state set before calling clockevents_exchange_device(), its state will be set in function clockevents_switch_state() if it succeeds to do so. Fixes: bf9a001fb8e4 ("clocksource/drivers/timer-tegra: Remove clockevents s= hutdown call on offlining") Fixes: cd165ce8314f ("clocksource/drivers/qcom: Remove clockevents shutdown= call on offlining") Fixes: 30f8c70a85bc ("clocksource/drivers/armada-370-xp: Remove clockevents= shutdown call on offlining") Fixes: ba23b6c7f974 ("clocksource/drivers/exynos_mct: Remove clockevents sh= utdown call on offlining") Fixes: 15b810e0496e ("clocksource/drivers/arm_global_timer: Remove clockeve= nts shutdown call on offlining") Fixes: 78b5c2ca5f27 ("clocksource/drivers/arm_arch_timer: Remove clockevent= s shutdown call on offlining") Fixes: 900053d9eedf ("ARM: smp_twd: Remove clockevents shutdown call on off= lining") Signed-off-by: Bibo Mao Reviewed-by: Frederic Weisbecker --- kernel/time/tick-common.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 9a3859443c04..eb9b777f5492 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -424,11 +424,6 @@ void tick_shutdown(unsigned int cpu) =20 td->mode =3D TICKDEV_MODE_PERIODIC; if (dev) { - /* - * Prevent that the clock events layer tries to call - * the set mode function! - */ - clockevent_set_state(dev, CLOCK_EVT_STATE_DETACHED); clockevents_exchange_device(dev, NULL); dev->event_handler =3D clockevents_handle_noop; td->evtdev =3D NULL; --=20 2.39.3 From nobody Fri Oct 3 06:37:02 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0109429A310 for ; Thu, 4 Sep 2025 07:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756970262; cv=none; b=aUI5fFgpC2rAYbfYnvkTfIplCJBMe4tXXFkZrptmkkxzKduyrPrJmRIRUv2ca9YjHleaQsq0OgOIzWWC0QnMxy4wbG5H+QFKSFS4jx6TURkivGTXAT54MCkpXexumaG6fzAy+7O6Xn3RKI+N1Yzkw152O9uJtSccoV19EO6bETU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756970262; c=relaxed/simple; bh=EZU3KTl6IPNKUrbj5DDCEcWk5vBANwmZEzz/pD7YdZw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uibP1Pw9fQv1+k1COjqUqgiZcY1+jl8UYuEiF8t8uSV/J61MEfWFcKk6g6JqV6JULyKNjz36nWt43N38SZF8x1TRWZMWlqySTQLJuJtZ4sWyyLyVSOfgcL2m5il31m9Fzg3NZcIIYSr0dRepywltPDy8Aw9NT5ZfitekPOjzOeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8Cx778SPbloUo8GAA--.12548S3; Thu, 04 Sep 2025 15:17:38 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by front1 (Coremail) with SMTP id qMiowJDx_8MNPbloS2h9AA--.2519S4; Thu, 04 Sep 2025 15:17:37 +0800 (CST) From: Bibo Mao To: Huacai Chen , Anna-Maria Behnsen , Frederic Weisbecker , Ingo Molnar , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Xianglai Li Subject: [PATCH v2 2/2] LoongArch: Remove clockevents shutdown call on offlining Date: Thu, 4 Sep 2025 15:17:32 +0800 Message-Id: <20250904071732.3513694-3-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20250904071732.3513694-1-maobibo@loongson.cn> References: <20250904071732.3513694-1-maobibo@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowJDx_8MNPbloS2h9AA--.2519S4 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Content-Type: text/plain; charset="utf-8" The clockevents core already detached and unregistered it at this stage. Signed-off-by: Bibo Mao Reviewed-by: Frederic Weisbecker --- arch/loongarch/kernel/time.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/loongarch/kernel/time.c b/arch/loongarch/kernel/time.c index f3092f2de8b5..6fb92cc1a4c9 100644 --- a/arch/loongarch/kernel/time.c +++ b/arch/loongarch/kernel/time.c @@ -112,8 +112,6 @@ static int arch_timer_starting(unsigned int cpu) =20 static int arch_timer_dying(unsigned int cpu) { - constant_set_state_shutdown(this_cpu_ptr(&constant_clockevent_device)); - /* Clear Timer Interrupt */ write_csr_tintclear(CSR_TINTCLR_TI); =20 --=20 2.39.3